From: Mark Brown <broonie@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Anish Kumar <yesanishhere@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Axel Lin <axel.lin@ingics.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Lars-Peter Clausen <lars@metafoo.de>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ASoC: max98925: reading beyond the end of the array
Date: Tue, 21 Jul 2015 11:04:57 +0000 [thread overview]
Message-ID: <20150721110457.GT11162@sirena.org.uk> (raw)
In-Reply-To: <20150721105743.GO5422@mwanda>
[-- Attachment #1: Type: text/plain, Size: 599 bytes --]
On Tue, Jul 21, 2015 at 01:57:43PM +0300, Dan Carpenter wrote:
> On Tue, Jul 21, 2015 at 11:43:50AM +0100, Mark Brown wrote:
> > On Tue, Jul 21, 2015 at 11:55:27AM +0300, Dan Carpenter wrote:
> > > Debug prints are seldom useful and this one has an annoying thing where
> > > it reads one space beyond the end of the array on error.
> > It's a pretty big stretch to say that debug prints are rarely useful...
> I asked Anish if it was worth fixing and he said to delete it.
Sure, but you're making a general comment about debug prints being
seldom useful rather than just talking about this one.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Anish Kumar <yesanishhere@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Axel Lin <axel.lin@ingics.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Lars-Peter Clausen <lars@metafoo.de>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ASoC: max98925: reading beyond the end of the array
Date: Tue, 21 Jul 2015 12:04:57 +0100 [thread overview]
Message-ID: <20150721110457.GT11162@sirena.org.uk> (raw)
In-Reply-To: <20150721105743.GO5422@mwanda>
[-- Attachment #1: Type: text/plain, Size: 599 bytes --]
On Tue, Jul 21, 2015 at 01:57:43PM +0300, Dan Carpenter wrote:
> On Tue, Jul 21, 2015 at 11:43:50AM +0100, Mark Brown wrote:
> > On Tue, Jul 21, 2015 at 11:55:27AM +0300, Dan Carpenter wrote:
> > > Debug prints are seldom useful and this one has an annoying thing where
> > > it reads one space beyond the end of the array on error.
> > It's a pretty big stretch to say that debug prints are rarely useful...
> I asked Anish if it was worth fixing and he said to delete it.
Sure, but you're making a general comment about debug prints being
seldom useful rather than just talking about this one.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-07-21 11:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 8:55 [patch] ASoC: max98925: reading beyond the end of the array Dan Carpenter
2015-07-21 8:55 ` Dan Carpenter
2015-07-21 10:43 ` Mark Brown
2015-07-21 10:43 ` Mark Brown
2015-07-21 10:57 ` Dan Carpenter
2015-07-21 10:57 ` Dan Carpenter
2015-07-21 11:04 ` Mark Brown [this message]
2015-07-21 11:04 ` Mark Brown
2015-07-21 10:49 ` Applied "ASoC: max98925: reading beyond the end of the array" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721110457.GT11162@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@ingics.com \
--cc=dan.carpenter@oracle.com \
--cc=k.kozlowski@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yesanishhere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.