* [PATCH] Staging:dgap :Compression of lines for immediate return
@ 2015-07-26 17:33 Shraddha Barke
2015-07-27 4:27 ` Sudip Mukherjee
0 siblings, 1 reply; 7+ messages in thread
From: Shraddha Barke @ 2015-07-26 17:33 UTC (permalink / raw)
To: driverdev-devel
This patch compresses two lines into a single line if immediate return statement
is found. Also,remove variable rc as it is no longer needed.
It is done using tool Coccinelle. And semantic patch used for this is as follows:
@@
expression ret;
identifier f;
@@
-ret =
+return
f(...);
-return ret;
---
drivers/staging/dgap/dgap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 26b0446..2bb6c68 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -4953,9 +4953,8 @@ static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
spin_unlock_irqrestore(&ch->ch_lock, lock_flags2);
spin_unlock_irqrestore(&bd->bd_lock, lock_flags);
- rc = put_user(C_CLOCAL(tty) ? 1 : 0,
+ return put_user(C_CLOCAL(tty) ? 1 : 0,
(unsigned long __user *) arg);
- return rc;
case TIOCSSOFTCAR:
spin_unlock_irqrestore(&ch->ch_lock, lock_flags2);
--
2.1.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Staging:dgap :Compression of lines for immediate return
2015-07-26 17:33 [PATCH] Staging:dgap :Compression of lines for immediate return Shraddha Barke
@ 2015-07-27 4:27 ` Sudip Mukherjee
0 siblings, 0 replies; 7+ messages in thread
From: Sudip Mukherjee @ 2015-07-27 4:27 UTC (permalink / raw)
To: Shraddha Barke; +Cc: driverdev-devel
On Sun, Jul 26, 2015 at 11:03:40PM +0530, Shraddha Barke wrote:
> This patch compresses two lines into a single line if immediate return statement
> is found. Also,remove variable rc as it is no longer needed.
> It is done using tool Coccinelle. And semantic patch used for this is as follows:
>
> @@
> expression ret;
> identifier f;
> @@
>
> -ret =
> +return
> f(...);
> -return ret;
> ---
You have missed the Signed-off-by:
regards
sudip
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Staging:dgap :Compression of lines for immediate return
@ 2015-07-27 18:00 Shraddha Barke
0 siblings, 0 replies; 7+ messages in thread
From: Shraddha Barke @ 2015-07-27 18:00 UTC (permalink / raw)
To: Daeseok Youn, Mark Hounschell, Lidza Louina, Greg Kroah-Hartman
Cc: devel, linux-kernel, Shraddha Barke
This patch compresses two lines into a single line
if immediate return statement is found. Remove variable rc as
it is no longer needed.
It is done using script Coccinelle. And coccinelle uses the following
semantic patch for this compression function:
@@
type T;
identifier i,f;
constant C;
@@
- T i;
...when != i
when strict
(
return -C;
|
- i =
+ return
f(...);
- return i;
)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
drivers/staging/dgap/dgap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index b344e03..9112dd2 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -4953,9 +4953,8 @@ static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
spin_unlock_irqrestore(&ch->ch_lock, lock_flags2);
spin_unlock_irqrestore(&bd->bd_lock, lock_flags);
- rc = put_user(C_CLOCAL(tty) ? 1 : 0,
+ return put_user(C_CLOCAL(tty) ? 1 : 0,
(unsigned long __user *) arg);
- return rc;
case TIOCSSOFTCAR:
spin_unlock_irqrestore(&ch->ch_lock, lock_flags2);
--
2.1.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] Staging:dgap :Compression of lines for immediate return
@ 2015-07-27 17:37 Shraddha Barke
0 siblings, 0 replies; 7+ messages in thread
From: Shraddha Barke @ 2015-07-27 17:37 UTC (permalink / raw)
To: Daeseok Youn, Mark Hounschell, Lidza Louina, Greg Kroah-Hartman
Cc: devel, linux-kernel, Shraddha Barke
This patch compresses two lines in a single line in file dgap.c
if immediate return statement is found.It also removes variable rc as
it is no longer needed.
It is done using script Coccinelle.And coccinelle uses the following
semantic patch for this compression function:
@@
expression ret;
identifier f;
@@
-ret =
+return
f(...);
-return ret;
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
drivers/staging/dgap/dgap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index b344e03..9112dd2 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -4953,9 +4953,8 @@ static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
spin_unlock_irqrestore(&ch->ch_lock, lock_flags2);
spin_unlock_irqrestore(&bd->bd_lock, lock_flags);
- rc = put_user(C_CLOCAL(tty) ? 1 : 0,
+ return put_user(C_CLOCAL(tty) ? 1 : 0,
(unsigned long __user *) arg);
- return rc;
case TIOCSSOFTCAR:
spin_unlock_irqrestore(&ch->ch_lock, lock_flags2);
--
2.1.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Staging:dgap :Compression of lines for immediate return
2015-07-26 17:34 Shraddha Barke
2015-07-26 19:39 ` Joe Perches
@ 2015-07-27 4:30 ` Sudip Mukherjee
1 sibling, 0 replies; 7+ messages in thread
From: Sudip Mukherjee @ 2015-07-27 4:30 UTC (permalink / raw)
To: Shraddha Barke; +Cc: linux-kernel
On Sun, Jul 26, 2015 at 11:04:13PM +0530, Shraddha Barke wrote:
> This patch compresses two lines into a single line if immediate return statement
> is found. Also,remove variable rc as it is no longer needed.
> It is done using tool Coccinelle. And semantic patch used for this is as follows:
>
> @@
> expression ret;
> identifier f;
> @@
>
> -ret =
> +return
> f(...);
> -return ret;
> ---
Missed the Signed-off-by: here also, and always add the maintainers in
your To: list.
regards
sudip
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Staging:dgap :Compression of lines for immediate return
2015-07-26 17:34 Shraddha Barke
@ 2015-07-26 19:39 ` Joe Perches
2015-07-27 4:30 ` Sudip Mukherjee
1 sibling, 0 replies; 7+ messages in thread
From: Joe Perches @ 2015-07-26 19:39 UTC (permalink / raw)
To: Shraddha Barke; +Cc: linux-kernel
On Sun, 2015-07-26 at 23:04 +0530, Shraddha Barke wrote:
> This patch compresses two lines into a single line if immediate return statement
> is found. Also,remove variable rc as it is no longer needed.
> It is done using tool Coccinelle. And semantic patch used for this is as follows:
>
> @@
> expression ret;
> identifier f;
> @@
> -ret =
> +return
> f(...);
> -return ret;
This isn't an always safe or side-effect free
semantic patch as there may be a cast lost by
such a conversion.
int foo(void)
{
char i = 0xffffffff;
return i;
}
where i is now int not char
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Staging:dgap :Compression of lines for immediate return
@ 2015-07-26 17:34 Shraddha Barke
2015-07-26 19:39 ` Joe Perches
2015-07-27 4:30 ` Sudip Mukherjee
0 siblings, 2 replies; 7+ messages in thread
From: Shraddha Barke @ 2015-07-26 17:34 UTC (permalink / raw)
To: linux-kernel
This patch compresses two lines into a single line if immediate return statement
is found. Also,remove variable rc as it is no longer needed.
It is done using tool Coccinelle. And semantic patch used for this is as follows:
@@
expression ret;
identifier f;
@@
-ret =
+return
f(...);
-return ret;
---
drivers/staging/dgap/dgap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 26b0446..2bb6c68 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -4953,9 +4953,8 @@ static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
spin_unlock_irqrestore(&ch->ch_lock, lock_flags2);
spin_unlock_irqrestore(&bd->bd_lock, lock_flags);
- rc = put_user(C_CLOCAL(tty) ? 1 : 0,
+ return put_user(C_CLOCAL(tty) ? 1 : 0,
(unsigned long __user *) arg);
- return rc;
case TIOCSSOFTCAR:
spin_unlock_irqrestore(&ch->ch_lock, lock_flags2);
--
2.1.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-07-27 18:02 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-26 17:33 [PATCH] Staging:dgap :Compression of lines for immediate return Shraddha Barke
2015-07-27 4:27 ` Sudip Mukherjee
2015-07-26 17:34 Shraddha Barke
2015-07-26 19:39 ` Joe Perches
2015-07-27 4:30 ` Sudip Mukherjee
2015-07-27 17:37 Shraddha Barke
2015-07-27 18:00 Shraddha Barke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.