* [Buildroot] [PATCH] Disable e4defrag in host-e2fsprogs
@ 2015-07-29 18:47 Hollis Blanchard
2015-07-29 20:21 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Hollis Blanchard @ 2015-07-29 18:47 UTC (permalink / raw)
To: buildroot
e4defrag from e2fsprogs 1.42.13 encounters these build errors on RHEL5.8 hosts:
e4defrag.c:197:2: error: #error sync_file_range not available!
e4defrag.c:201:2: error: #error fallocate64 not available!
It's possible to fix these problems, but we don't use it on the host anyways,
so just disable it.
Signed-off-by: Hollis Blanchard <hollis_blanchard@mentor.com>
---
package/e2fsprogs/e2fsprogs.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk
index c863f70..2f043ca 100644
--- a/package/e2fsprogs/e2fsprogs.mk
+++ b/package/e2fsprogs/e2fsprogs.mk
@@ -12,6 +12,10 @@ E2FSPROGS_LICENSE_FILES = COPYING lib/uuid/COPYING lib/ss/mit-sipb-copyright.h l
E2FSPROGS_INSTALL_STAGING = YES
E2FSPROGS_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) install-libs
+# e4defrag doesn't build on older systems like RHEL5.x, and we don't need it
+# on the host anyways.
+HOST_E2FSPROGS_CONF_OPTS += --disable-defrag
+
E2FSPROGS_CONF_OPTS = \
$(if $(BR2_STATIC_LIBS),,--enable-elf-shlibs) \
$(if $(BR2_PACKAGE_E2FSPROGS_DEBUGFS),,--disable-debugfs) \
--
2.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] Disable e4defrag in host-e2fsprogs
2015-07-29 18:47 [Buildroot] [PATCH] Disable e4defrag in host-e2fsprogs Hollis Blanchard
@ 2015-07-29 20:21 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2015-07-29 20:21 UTC (permalink / raw)
To: buildroot
Dear Hollis Blanchard,
On Wed, 29 Jul 2015 11:47:38 -0700, Hollis Blanchard wrote:
> e4defrag from e2fsprogs 1.42.13 encounters these build errors on RHEL5.8 hosts:
> e4defrag.c:197:2: error: #error sync_file_range not available!
> e4defrag.c:201:2: error: #error fallocate64 not available!
>
> It's possible to fix these problems, but we don't use it on the host anyways,
> so just disable it.
>
> Signed-off-by: Hollis Blanchard <hollis_blanchard@mentor.com>
> ---
> package/e2fsprogs/e2fsprogs.mk | 4 ++++
> 1 file changed, 4 insertions(+)
Commit titles must follow the convention:
<package>: <description>
so I changed the title of your commit to:
e2fsprogs: disable e4defrag in host variant
and applied.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-29 20:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-29 18:47 [Buildroot] [PATCH] Disable e4defrag in host-e2fsprogs Hollis Blanchard
2015-07-29 20:21 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.