[Buildroot] [PATCH 1/1] python-colorama: new package

[Buildroot] [PATCH 1/1] python-colorama: new package

[Augusto Farina]

Colorama is a simple cross-platform colored terminal text in Python.

Tested on a PowerPC e500v2 board. Host build support is also added in
the package makefile, as python-jinja2, because we have third-party
software that requires it (e.g. ARM mbed build-system).

Signed-off-by: Augusto Farina <farina@datacom.ind.br>
---
 package/Config.in                            |  1 +
 package/python-colorama/Config.in            |  6 ++++++
 package/python-colorama/python-colorama.hash |  3 +++
 package/python-colorama/python-colorama.mk   | 15 +++++++++++++++
 4 files changed, 25 insertions(+)
 create mode 100644 package/python-colorama/Config.in
 create mode 100644 package/python-colorama/python-colorama.hash
 create mode 100644 package/python-colorama/python-colorama.mk

diff --git a/package/Config.in b/package/Config.in
index 1e39c74..9f043ad 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -597,6 +597,7 @@ menu "external python modules"
 	source "package/python-cheetah/Config.in"
 	source "package/python-cherrypy/Config.in"
 	source "package/python-coherence/Config.in"
+	source "package/python-colorama/Config.in"
 	source "package/python-configobj/Config.in"
 	source "package/python-configshell-fb/Config.in"
 	source "package/python-crc16/Config.in"
diff --git a/package/python-colorama/Config.in b/package/python-colorama/Config.in
new file mode 100644
index 0000000..50965ae
--- /dev/null
+++ b/package/python-colorama/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PYTHON_COLORAMA
+	bool "python-colorama"
+	help
+	  Simple cross-platform colored terminal text in Python.
+
+	  http://pypi.python.org/pypi/colorama
diff --git a/package/python-colorama/python-colorama.hash b/package/python-colorama/python-colorama.hash
new file mode 100644
index 0000000..5d8598c
--- /dev/null
+++ b/package/python-colorama/python-colorama.hash
@@ -0,0 +1,3 @@
+# md5 from https://pypi.python.org/pypi?:action=show_md5&digest=a56b8dc55158a41ab3c89c4c8feb8824, sha256 locally computed
+md5	a56b8dc55158a41ab3c89c4c8feb8824  colorama-0.3.3.tar.gz
+sha256	eb21f2ba718fbf357afdfdf6f641ab393901c7ca8d9f37edd0bee4806ffa269c  colorama-0.3.3.tar.gz
diff --git a/package/python-colorama/python-colorama.mk b/package/python-colorama/python-colorama.mk
new file mode 100644
index 0000000..f9b0bae
--- /dev/null
+++ b/package/python-colorama/python-colorama.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# python-colorama
+#
+################################################################################
+
+PYTHON_COLORAMA_VERSION = 0.3.3
+PYTHON_COLORAMA_SOURCE = colorama-$(PYTHON_COLORAMA_VERSION).tar.gz
+PYTHON_COLORAMA_SITE = https://pypi.python.org/packages/source/c/colorama
+PYTHON_COLORAMA_SETUP_TYPE = setuptools
+PYTHON_COLORAMA_LICENSE = BSD-3c
+PYTHON_COLORAMA_LICENSE_FILES = LICENSE.txt
+
+$(eval $(python-package))
+$(eval $(host-python-package))
-- 
1.9.1

[Buildroot] [PATCH 1/1] python-colorama: new package

[Thomas Petazzoni]

Augusto,

On Mon,  3 Aug 2015 17:36:59 -0300, Augusto Farina wrote:
> Colorama is a simple cross-platform colored terminal text in Python.
> 
> Tested on a PowerPC e500v2 board. Host build support is also added in
> the package makefile, as python-jinja2, because we have third-party
> software that requires it (e.g. ARM mbed build-system).

As usual, I'm a little bit reluctant to add host packages that are not
used by any other package in Buildroot, because it means they are never
tested.

Do you intend to submit some packages that will use
host-python-colorama?

Also, not your fault, but I must say it's a bit odd for a build-system
to have a mandatory dependency on something that allows to colorize the
terminal output :)

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] python-colorama: new package

[DATACOM - Farina]

Hi Thomas,

On 04-08-2015 05:55, Thomas Petazzoni wrote:
> Augusto,
>
> On Mon,  3 Aug 2015 17:36:59 -0300, Augusto Farina wrote:
>> Colorama is a simple cross-platform colored terminal text in Python.
>>
>> Tested on a PowerPC e500v2 board. Host build support is also added in
>> the package makefile, as python-jinja2, because we have third-party
>> software that requires it (e.g. ARM mbed build-system).
>
> As usual, I'm a little bit reluctant to add host packages that are not
> used by any other package in Buildroot, because it means they are never
> tested.
>

I've heard this :)


> Do you intend to submit some packages that will use
> host-python-colorama?
>

At this specific moment, no. But we are analyzing the ARM mbed package, 
which are widely used libraries and tools for ARM microcontrollers, and 
makes use of host-python-colorama on its build-system.


> Also, not your fault, but I must say it's a bit odd for a build-system
> to have a mandatory dependency on something that allows to colorize the
> terminal output :)
>

I agree with you. But we are trying not to keep recipes of open-source 
packages in our repository, and I just thought this might be useful to 
someone else.


Cheers,

-- 
Augusto Farina
DATACOM / R&D - Access
www.datacom.ind.br

[Buildroot] [PATCH 1/1] python-colorama: new package

[Thomas Petazzoni]

Hello,

On Tue, 04 Aug 2015 10:31:50 -0300, DATACOM - Farina wrote:

> > Do you intend to submit some packages that will use
> > host-python-colorama?
> 
> At this specific moment, no. But we are analyzing the ARM mbed package, 
> which are widely used libraries and tools for ARM microcontrollers, and 
> makes use of host-python-colorama on its build-system.

But why do you use Buildroot to build something for a micro-controller?
I don't really see the connection between using ARM mbed and Buildroot.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] python-colorama: new package

[DATACOM - Farina]

Hi Thomas,

On 04-08-2015 10:38, Thomas Petazzoni wrote:
> Hello,
>
> On Tue, 04 Aug 2015 10:31:50 -0300, DATACOM - Farina wrote:
>
>>> Do you intend to submit some packages that will use
>>> host-python-colorama?
>>
>> At this specific moment, no. But we are analyzing the ARM mbed package,
>> which are widely used libraries and tools for ARM microcontrollers, and
>> makes use of host-python-colorama on its build-system.
>
> But why do you use Buildroot to build something for a micro-controller?
> I don't really see the connection between using ARM mbed and Buildroot.
>

Our boards has PowerPC/ARM/MIPS running Linux. And also has ARM 
microcontrollers.

So, when we build the main firmware (Linux + rootfs) with Buildroot, we 
also build the microcontroller firmware that goes inside the rootfs 
(using a secondary toolchain).

With this way, we have just one build-system (Buildroot), with 
everything we need integrated on it.

My apologies if it is not the Buildroot idea, but this kind of 
integration is facilitating our work.

Cheers,

-- 
Augusto Farina
DATACOM / R&D - Access
www.datacom.ind.br

[Buildroot] [PATCH 1/1] python-colorama: new package

[Thomas Petazzoni]

Hello,

On Tue, 04 Aug 2015 11:23:06 -0300, DATACOM - Farina wrote:

> Our boards has PowerPC/ARM/MIPS running Linux. And also has ARM 
> microcontrollers.
> 
> So, when we build the main firmware (Linux + rootfs) with Buildroot, we 
> also build the microcontroller firmware that goes inside the rootfs 
> (using a secondary toolchain).
> 
> With this way, we have just one build-system (Buildroot), with 
> everything we need integrated on it.
> 
> My apologies if it is not the Buildroot idea, but this kind of 
> integration is facilitating our work.

Interesting use of Buildroot, definitely! I think it makes a lot of
sense to use Buildroot this way, so I understand better what you did.
I'm still a bit reluctant to add host packages in Buildroot without
users, but at least there is a very useful and interesting use case
behind it, so I might be tempted to apply your patch with the host
package included.

I'm obviously interested by the opinion of other Buildroot developers.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] python-colorama: new package

[Arnout Vandecappelle]

On 04-08-15 19:43, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 04 Aug 2015 11:23:06 -0300, DATACOM - Farina wrote:
> 
>> Our boards has PowerPC/ARM/MIPS running Linux. And also has ARM 
>> microcontrollers.
>>
>> So, when we build the main firmware (Linux + rootfs) with Buildroot, we 
>> also build the microcontroller firmware that goes inside the rootfs 
>> (using a secondary toolchain).
>>
>> With this way, we have just one build-system (Buildroot), with 
>> everything we need integrated on it.
>>
>> My apologies if it is not the Buildroot idea, but this kind of 
>> integration is facilitating our work.
> 
> Interesting use of Buildroot, definitely! I think it makes a lot of
> sense to use Buildroot this way, so I understand better what you did.
> I'm still a bit reluctant to add host packages in Buildroot without
> users, but at least there is a very useful and interesting use case
> behind it, so I might be tempted to apply your patch with the host
> package included.
> 
> I'm obviously interested by the opinion of other Buildroot developers.

 I'm not so inclined to include this non-buildable package. I think it's
possible to have a package/python-colorama/python-colorama.mk in BR2_EXTERNAL
that includes the $(host-python-package).

 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 1/1] python-colorama: new package

[Thomas Petazzoni]

Dear Augusto Farina,

On Mon,  3 Aug 2015 17:36:59 -0300, Augusto Farina wrote:
> Colorama is a simple cross-platform colored terminal text in Python.
> 
> Tested on a PowerPC e500v2 board. Host build support is also added in
> the package makefile, as python-jinja2, because we have third-party
> software that requires it (e.g. ARM mbed build-system).
> 
> Signed-off-by: Augusto Farina <farina@datacom.ind.br>

So Arnout agreed with me that we don't want this host only package that
is not used by any other package in Buildroot. Can you resubmit when
this package gets actually used by another menuconfig-selectable
package in Buildroot ?

In the mean time, I'll mark your patch as Changes Requested.

Peter: you never raised your opinion on this one, but please speak up
if you don't agree with the reasoning of Arnout and myself. Thanks!

Augusto, if you still want the target side to be merged, can you resend
an updated version with just the target variant?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] python-colorama: new package

[DATACOM - Farina]

Hi Thomas,

On 01-12-2015 20:09, Thomas Petazzoni wrote:
> Dear Augusto Farina,
>
> On Mon,  3 Aug 2015 17:36:59 -0300, Augusto Farina wrote:
>> Colorama is a simple cross-platform colored terminal text in Python.
>>
>> Tested on a PowerPC e500v2 board. Host build support is also added in
>> the package makefile, as python-jinja2, because we have third-party
>> software that requires it (e.g. ARM mbed build-system).
>>
>> Signed-off-by: Augusto Farina <farina@datacom.ind.br>
>
> So Arnout agreed with me that we don't want this host only package that
> is not used by any other package in Buildroot. Can you resubmit when
> this package gets actually used by another menuconfig-selectable
> package in Buildroot ?
>

No problem, we keep it local.


> In the mean time, I'll mark your patch as Changes Requested.
>
> Peter: you never raised your opinion on this one, but please speak up
> if you don't agree with the reasoning of Arnout and myself. Thanks!
>
> Augusto, if you still want the target side to be merged, can you resend
> an updated version with just the target variant?

We can forget this for now, I believe that this will not add much to 
Buildroot.

Thanks for the feedback.

Cheers,

-- 
Augusto Farina
DATACOM
R&D - Access
Rua America, 1000 - Eldorado do Sul, RS
Tel.: +55 51 3933 3638
Fax.: +55 51 3933 3003
farina at datacom.ind.br
www.datacom.ind.br