From: Mark Brown <broonie@kernel.org>
To: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Cc: linux-rockchip@lists.infradead.org,
Jaroslav Kysela <perex@perex.cz>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Heiko Stuebner <heiko@sntech.de>,
linux-kernel@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/4] ASoC: dt-bindings: add rockchip tranceiver bindings
Date: Fri, 7 Aug 2015 14:05:40 +0100 [thread overview]
Message-ID: <20150807130540.GX20873@sirena.org.uk> (raw)
In-Reply-To: <1438947854-3743-2-git-send-email-sjoerd.simons@collabora.co.uk>
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
On Fri, Aug 07, 2015 at 01:44:11PM +0200, Sjoerd Simons wrote:
> +- compatible: should be one of the following:
> + - "rockchip,rk3066-spdif": for rk3066
> + - "rockchip,rk3188-spdif", "rockchip,rk3066-spdif": for rk3188
> + - "rockchip,rk3288-spdif", "rockchip,rk3066-spdif": for rk3288
The binding claims that we support these three compatibles but the
driver only supports rockchip,rk3066-spdif. It's better to list all the
compatibles in the binding even if they all boil down to the same thing
since it's less error prone when we do start adding device specific
code - people are less likely to forget to handle some variant properly.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Sjoerd Simons <sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Jaroslav Kysela <perex-/Fr2/VpizcU@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Takashi Iwai <tiwai-IBi9RG/b67k@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 1/4] ASoC: dt-bindings: add rockchip tranceiver bindings
Date: Fri, 7 Aug 2015 14:05:40 +0100 [thread overview]
Message-ID: <20150807130540.GX20873@sirena.org.uk> (raw)
In-Reply-To: <1438947854-3743-2-git-send-email-sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
On Fri, Aug 07, 2015 at 01:44:11PM +0200, Sjoerd Simons wrote:
> +- compatible: should be one of the following:
> + - "rockchip,rk3066-spdif": for rk3066
> + - "rockchip,rk3188-spdif", "rockchip,rk3066-spdif": for rk3188
> + - "rockchip,rk3288-spdif", "rockchip,rk3066-spdif": for rk3288
The binding claims that we support these three compatibles but the
driver only supports rockchip,rk3066-spdif. It's better to list all the
compatibles in the binding even if they all boil down to the same thing
since it's less error prone when we do start adding device specific
code - people are less likely to forget to handle some variant properly.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/4] ASoC: dt-bindings: add rockchip tranceiver bindings
Date: Fri, 7 Aug 2015 14:05:40 +0100 [thread overview]
Message-ID: <20150807130540.GX20873@sirena.org.uk> (raw)
In-Reply-To: <1438947854-3743-2-git-send-email-sjoerd.simons@collabora.co.uk>
On Fri, Aug 07, 2015 at 01:44:11PM +0200, Sjoerd Simons wrote:
> +- compatible: should be one of the following:
> + - "rockchip,rk3066-spdif": for rk3066
> + - "rockchip,rk3188-spdif", "rockchip,rk3066-spdif": for rk3188
> + - "rockchip,rk3288-spdif", "rockchip,rk3066-spdif": for rk3288
The binding claims that we support these three compatibles but the
driver only supports rockchip,rk3066-spdif. It's better to list all the
compatibles in the binding even if they all boil down to the same thing
since it's less error prone when we do start adding device specific
code - people are less likely to forget to handle some variant properly.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150807/7ea0e7eb/attachment.sig>
next prev parent reply other threads:[~2015-08-07 13:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 11:44 [PATCH v3 0/4] Add SPDIF support for rockchip Sjoerd Simons
2015-08-07 11:44 ` Sjoerd Simons
2015-08-07 11:44 ` Sjoerd Simons
2015-08-07 11:44 ` [PATCH v3 1/4] ASoC: dt-bindings: add rockchip tranceiver bindings Sjoerd Simons
2015-08-07 11:44 ` Sjoerd Simons
2015-08-07 11:44 ` Sjoerd Simons
2015-08-07 13:05 ` Mark Brown [this message]
2015-08-07 13:05 ` Mark Brown
2015-08-07 13:05 ` Mark Brown
2015-08-07 11:44 ` [PATCH v3 2/4] ASoC: rockchip: Add rockchip SPDIF transceiver driver Sjoerd Simons
2015-08-07 11:44 ` Sjoerd Simons
2015-08-07 11:44 ` Sjoerd Simons
2015-08-07 13:03 ` Mark Brown
2015-08-07 13:03 ` Mark Brown
2015-08-18 18:25 ` Heiko Stuebner
2015-08-18 18:25 ` Heiko Stuebner
2015-08-18 18:25 ` Heiko Stuebner
2015-08-19 6:56 ` Sjoerd Simons
2015-08-19 6:56 ` Sjoerd Simons
2015-08-19 6:56 ` Sjoerd Simons
2015-08-19 7:28 ` Heiko Stuebner
2015-08-19 7:28 ` Heiko Stuebner
2015-08-07 11:44 ` [PATCH v3 3/4] ARM: dts: rockchip: Add SPDIF transceiver for RK3188 Sjoerd Simons
2015-08-07 11:44 ` Sjoerd Simons
2015-08-07 11:44 ` Sjoerd Simons
2015-08-07 11:44 ` [PATCH v3 4/4] ARM: dts: rockchip: Add SPDIF optical out on Radxa Rock Sjoerd Simons
2015-08-07 11:44 ` Sjoerd Simons
2015-08-07 11:44 ` Sjoerd Simons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150807130540.GX20873@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=sjoerd.simons@collabora.co.uk \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.