From: Mark Brown <broonie@kernel.org> To: Paul Bolle <pebolle@tiscali.nl> Cc: Sjoerd Simons <sjoerd.simons@collabora.co.uk>, Mark Rutland <mark.rutland@arm.com>, alsa-devel@alsa-project.org, Heiko Stuebner <heiko@sntech.de>, Pawel Moll <pawel.moll@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>, linux-rockchip@lists.infradead.org, Rob Herring <robh+dt@kernel.org>, Kumar Gala <galak@codeaurora.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/4] ASoc: rockchip: Add rockchip SPDIF transceiver driver Date: Fri, 7 Aug 2015 14:13:59 +0100 [thread overview] Message-ID: <20150807131359.GA8892@sirena.org.uk> (raw) In-Reply-To: <1438159908.5106.32.camel@tiscali.nl> [-- Attachment #1: Type: text/plain, Size: 1253 bytes --] On Wed, Jul 29, 2015 at 10:51:48AM +0200, Paul Bolle wrote: > > + .name = DRV_NAME, > > + .of_match_table = of_match_ptr(rockchip_spdif_match), > > + .pm = &rockchip_spdif_pm_ops, > > + }, > > +}; > > +module_platform_driver(rockchip_spdif_driver); > > +MODULE_ALIAS("platform:" DRV_NAME); > (I seem to remember that Mark Brown is OK with this, at least for the > time being, but for future reference I'll ask the question anyway.) Is > there a corresponding struct platform_device with a "rockchip-spdif" > .name? Because if there's no such platform_device I think this line > doesn't really do anything for this driver. Paul, you've been told this before but please stop providing these review comments. It has been explained to you repeatedly that we do not require any form of machine definition to be merged to merge a driver, please pay attention to those explanations and stop sending the same bogus feedback to patch submitters. This just creates confusion for the submitters and wastes everyone's time. If you have questions the way to raise them is to respond to the original discussions, not to send new replies to other submitters repeating the same feedback you were previously advised was incorrect. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/4] ASoc: rockchip: Add rockchip SPDIF transceiver driver Date: Fri, 7 Aug 2015 14:13:59 +0100 [thread overview] Message-ID: <20150807131359.GA8892@sirena.org.uk> (raw) In-Reply-To: <1438159908.5106.32.camel@tiscali.nl> On Wed, Jul 29, 2015 at 10:51:48AM +0200, Paul Bolle wrote: > > + .name = DRV_NAME, > > + .of_match_table = of_match_ptr(rockchip_spdif_match), > > + .pm = &rockchip_spdif_pm_ops, > > + }, > > +}; > > +module_platform_driver(rockchip_spdif_driver); > > +MODULE_ALIAS("platform:" DRV_NAME); > (I seem to remember that Mark Brown is OK with this, at least for the > time being, but for future reference I'll ask the question anyway.) Is > there a corresponding struct platform_device with a "rockchip-spdif" > .name? Because if there's no such platform_device I think this line > doesn't really do anything for this driver. Paul, you've been told this before but please stop providing these review comments. It has been explained to you repeatedly that we do not require any form of machine definition to be merged to merge a driver, please pay attention to those explanations and stop sending the same bogus feedback to patch submitters. This just creates confusion for the submitters and wastes everyone's time. If you have questions the way to raise them is to respond to the original discussions, not to send new replies to other submitters repeating the same feedback you were previously advised was incorrect. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150807/a24111b4/attachment.sig>
next prev parent reply other threads:[~2015-08-07 13:14 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-28 12:03 [PATCH 0/4] Add SPDIF support for rockchip Sjoerd Simons 2015-07-28 12:03 ` Sjoerd Simons 2015-07-28 12:03 ` [PATCH 1/4] ASoC: dt-bindings: add rockchip tranceiver bindings Sjoerd Simons 2015-07-28 12:03 ` Sjoerd Simons 2015-07-28 12:03 ` [PATCH 2/4] ASoc: rockchip: Add rockchip SPDIF transceiver driver Sjoerd Simons 2015-07-28 12:03 ` Sjoerd Simons 2015-07-28 12:03 ` Sjoerd Simons 2015-07-28 14:28 ` Heiko Stübner 2015-07-28 14:28 ` Heiko Stübner 2015-07-28 15:13 ` Sjoerd Simons 2015-07-28 15:13 ` Sjoerd Simons 2015-07-29 8:51 ` Paul Bolle 2015-07-29 8:51 ` Paul Bolle 2015-08-07 13:13 ` Mark Brown [this message] 2015-08-07 13:13 ` Mark Brown 2015-07-28 12:03 ` [PATCH 3/4] ARM: dts: rockchip: Add SPDIF transceiver for RK3188 Sjoerd Simons 2015-07-28 12:03 ` Sjoerd Simons 2015-07-28 13:48 ` Sergei Shtylyov 2015-07-28 13:48 ` Sergei Shtylyov 2015-07-28 14:20 ` Heiko Stübner 2015-07-28 14:20 ` Heiko Stübner 2015-07-28 12:03 ` [PATCH 4/4] ARM: dts: rockchip: Add SPDIF optical out on Radxa Rock Sjoerd Simons 2015-07-28 12:03 ` Sjoerd Simons
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150807131359.GA8892@sirena.org.uk \ --to=broonie@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=galak@codeaurora.org \ --cc=heiko@sntech.de \ --cc=ijc+devicetree@hellion.org.uk \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=pebolle@tiscali.nl \ --cc=robh+dt@kernel.org \ --cc=sjoerd.simons@collabora.co.uk \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.