Checkpatch.pl warning

Checkpatch.pl warning

[Shraddha Barke]

I have come across the following checkpatch.pl warning a number of times:

WARNING: Prefer ether_addr_equal() or ether_addr_equal_unaligned() over
memcmp()

What exactly does it mean?
What is the fix for this warning?
Any help or links to appropriate Documentation will be good.

Thanks in advance!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20150808/e5bb0f7c/attachment.html 

Checkpatch.pl warning

[Greg KH]

On Sat, Aug 08, 2015 at 11:19:43PM +0530, Shraddha Barke wrote:
> I have come across the following checkpatch.pl warning a number of times:
> 
> WARNING: Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp
> ()
> 
> What exactly does it mean?
> What is the fix for this warning?
> Any help or links to appropriate Documentation will be good.

If you don't know what this is, or how network drivers work, I strongly
recommend not worrying about this at all, it's a tricky thing to get
right, and something that I need a _lot_ of proof before I ever accept
patches that do this.

I suggest working on something else.

best of luck,

greg k-h

Checkpatch.pl warning

[valdis.kletnieks at vt.edu]

On Sun, 30 Sep 2018 16:04:13 +0300, Shubham Singh said:

> Regarding the warning of checkpatch.pl, 
> " 'str' object has no attribute 'decode' "
> This warning is related to spdxcheck.py which is because of version of python
> In python3 str has no attribute decode(), while it works fine in python2, without any warning.
> I checked the patch related to this
> https://lore.kernel.org/lkml/20180717190635.29467-1-jcline at redhat.com/T/#u
> We can resolve the warning by just putting an if statement above line.decode() to resolve the warning. 

I'm assuming you're using a 4.19-rc1 or later kernel, as Cline's patch first appeared
in a mainline kernel at that tag, and next-20180820 for the -next tree.

Are you saying this commit:

commit bed95c43c15eb6b1ccc5b09e5ae08cac726c456d
Author: Jeremy Cline <jcline@redhat.com>
Date:   Fri Aug 17 15:44:01 2018 -0700

    scripts: add Python 3 compatibility to spdxcheck.py

is incomplete and needs patches?

> Am I right or I missed something?

If you are right, there *is* something missing - a patch. :)

Checkpatch.pl warning

[Shubham Singh]

Regarding the warning of checkpatch.pl, 
" 'str' object has no attribute 'decode' "
This warning is related to spdxcheck.py which is because of version of python
In python3 str has no attribute decode(), while it works fine in python2, without any warning.
I checked the patch related to this
https://lore.kernel.org/lkml/20180717190635.29467-1-jcline at redhat.com/T/#u
We can resolve the warning by just putting an if statement above line.decode() to resolve the warning. 
Am I right or I missed something ?
SHUBHAM SINGH
@shubhsherl
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20180930/49315f29/attachment.html>