* [patch 1/2 -mainline] cxgb4: missing curly braces in t4_setup_debugfs()
@ 2015-08-08 19:15 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-08-08 19:15 UTC (permalink / raw)
To: Hariprasad S; +Cc: netdev, kernel-janitors
There were missing curly braces so it means we call add_debugfs_mem()
unintentionally.
Fixes: 3ccc6cf74d8c ('cxgb4: Adds support for T6 adapter')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
index b657734..9e0b670 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
@@ -2665,10 +2665,11 @@ int t4_setup_debugfs(struct adapter *adap)
EXT_MEM1_SIZE_G(size));
}
} else {
- if (i & EXT_MEM_ENABLE_F)
+ if (i & EXT_MEM_ENABLE_F) {
size = t4_read_reg(adap, MA_EXT_MEMORY_BAR_A);
add_debugfs_mem(adap, "mc", MEM_MC,
EXT_MEM_SIZE_G(size));
+ }
}
de = debugfs_create_file_size("flash", S_IRUSR, adap->debugfs_root, adap,
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch 1/2 -mainline] cxgb4: missing curly braces in t4_setup_debugfs()
@ 2015-08-08 19:15 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-08-08 19:15 UTC (permalink / raw)
To: Hariprasad S; +Cc: netdev, kernel-janitors
There were missing curly braces so it means we call add_debugfs_mem()
unintentionally.
Fixes: 3ccc6cf74d8c ('cxgb4: Adds support for T6 adapter')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
index b657734..9e0b670 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
@@ -2665,10 +2665,11 @@ int t4_setup_debugfs(struct adapter *adap)
EXT_MEM1_SIZE_G(size));
}
} else {
- if (i & EXT_MEM_ENABLE_F)
+ if (i & EXT_MEM_ENABLE_F) {
size = t4_read_reg(adap, MA_EXT_MEMORY_BAR_A);
add_debugfs_mem(adap, "mc", MEM_MC,
EXT_MEM_SIZE_G(size));
+ }
}
de = debugfs_create_file_size("flash", S_IRUSR, adap->debugfs_root, adap,
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch 1/2 -mainline] cxgb4: missing curly braces in t4_setup_debugfs()
2015-08-08 19:15 ` Dan Carpenter
@ 2015-08-10 21:27 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-08-10 21:27 UTC (permalink / raw)
To: dan.carpenter; +Cc: hariprasad, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Sat, 8 Aug 2015 22:15:25 +0300
> There were missing curly braces so it means we call add_debugfs_mem()
> unintentionally.
>
> Fixes: 3ccc6cf74d8c ('cxgb4: Adds support for T6 adapter')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to 'net'.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 1/2 -mainline] cxgb4: missing curly braces in t4_setup_debugfs()
@ 2015-08-10 21:27 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-08-10 21:27 UTC (permalink / raw)
To: dan.carpenter; +Cc: hariprasad, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Sat, 8 Aug 2015 22:15:25 +0300
> There were missing curly braces so it means we call add_debugfs_mem()
> unintentionally.
>
> Fixes: 3ccc6cf74d8c ('cxgb4: Adds support for T6 adapter')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to 'net'.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-10 21:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-08 19:15 [patch 1/2 -mainline] cxgb4: missing curly braces in t4_setup_debugfs() Dan Carpenter
2015-08-08 19:15 ` Dan Carpenter
2015-08-10 21:27 ` David Miller
2015-08-10 21:27 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.