From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Goel, Akash" <akash.goel@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Only move to the CPU write domain if keeping the GTT pages
Date: Sun, 9 Aug 2015 11:55:57 +0100 [thread overview]
Message-ID: <20150809105557.GA10889@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <55C7310D.2000703@intel.com>
On Sun, Aug 09, 2015 at 04:23:01PM +0530, Goel, Akash wrote:
> On 8/7/2015 1:37 PM, Daniel Vetter wrote:
> >I presume though you only want to avoid clflush when actually purging an
> >object, so maybe we can keep this by purging the shmem backing node first
> >and checking here for __I915_MADV_PURGED instead?
>
> An object marked as MADV_DONT_NEED, implies that it will be
> purged/truncated right away after the call to put_pages_gtt
> function.
> So doing the other way round by purging first and then checking for
> __I915_MADV_PURGED, might be equivalent.
But disregards a few nice sanity checks, which I would like to keep.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-08-09 10:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 16:43 [PATCH] drm/i915: Only move to the CPU write domain if keeping the GTT pages Chris Wilson
2015-08-07 8:07 ` Daniel Vetter
2015-08-07 10:10 ` Chris Wilson
2015-08-07 11:55 ` Daniel Vetter
2015-08-07 13:07 ` Chris Wilson
2015-08-12 12:35 ` Daniel Vetter
2015-08-12 12:45 ` Chris Wilson
2015-08-09 10:53 ` Goel, Akash
2015-08-09 10:55 ` Chris Wilson [this message]
2015-08-09 11:41 ` Goel, Akash
2015-08-09 12:49 ` Chris Wilson
2015-08-09 13:32 ` Goel, Akash
2015-08-19 14:24 ` akash goel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150809105557.GA10889@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=akash.goel@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.