From: Simon Horman <horms@verge.net.au> To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH v2] DT: mmc: sh_mmcif: fix "compatible" property text Date: Wed, 12 Aug 2015 00:56:28 +0000 [thread overview] Message-ID: <20150812005628.GE15957@verge.net.au> (raw) In-Reply-To: <1643858.nkRxsQo3O3@wasted.cogentembedded.com> Hi Sergei, On Wed, Aug 12, 2015 at 01:37:28AM +0300, Sergei Shtylyov wrote: > The "compatible" property text contradicts even the example given in the MMCIF > binding document itself; moreover, the Renesas MMCIF driver only matches on > the generic "compatible" string and doesn't look for the SoC specific strings > at all. Thus describe "renesas,sh-mmcif" as a fallback value. > > Fixes: b4c27763d749 ("mmc: sh_mmcif: Document DT bindings") > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> I don't believe this file is the appropriate place to describe best-practice for the ordering of compatible strings which must surely be documented elsewhere. > --- > The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' and 'next' branches. > > Changes in version 2: > - kept the SoC specific "compatible" property values mandatory and made the > generic string a fallback. > > Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt > =================================> --- mmc.orig/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt > +++ mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt > @@ -10,7 +10,7 @@ Required properties: > - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs > - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs > - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs > - - "renesas,sh-mmcif" for the generic MMCIF > + followed by "renesas,sh-mmcif". > > - clocks: reference to the functional clock > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au> To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH v2] DT: mmc: sh_mmcif: fix "compatible" property text Date: Wed, 12 Aug 2015 09:56:28 +0900 [thread overview] Message-ID: <20150812005628.GE15957@verge.net.au> (raw) In-Reply-To: <1643858.nkRxsQo3O3@wasted.cogentembedded.com> Hi Sergei, On Wed, Aug 12, 2015 at 01:37:28AM +0300, Sergei Shtylyov wrote: > The "compatible" property text contradicts even the example given in the MMCIF > binding document itself; moreover, the Renesas MMCIF driver only matches on > the generic "compatible" string and doesn't look for the SoC specific strings > at all. Thus describe "renesas,sh-mmcif" as a fallback value. > > Fixes: b4c27763d749 ("mmc: sh_mmcif: Document DT bindings") > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> I don't believe this file is the appropriate place to describe best-practice for the ordering of compatible strings which must surely be documented elsewhere. > --- > The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' and 'next' branches. > > Changes in version 2: > - kept the SoC specific "compatible" property values mandatory and made the > generic string a fallback. > > Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt > =================================================================== > --- mmc.orig/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt > +++ mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt > @@ -10,7 +10,7 @@ Required properties: > - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs > - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs > - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs > - - "renesas,sh-mmcif" for the generic MMCIF > + followed by "renesas,sh-mmcif". > > - clocks: reference to the functional clock > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
next prev parent reply other threads:[~2015-08-12 0:56 UTC|newest] Thread overview: 197+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-04-24 22:39 [PATCH 0/2] Add R8A7791/Henninger board DT support Sergei Shtylyov 2014-04-24 22:39 ` Sergei Shtylyov 2014-04-24 22:39 ` Sergei Shtylyov 2014-04-24 22:42 ` [PATCH 1/2] ARM: shmobile: henninger: initial device tree Sergei Shtylyov 2014-04-24 22:42 ` Sergei Shtylyov 2014-04-24 22:42 ` Sergei Shtylyov 2014-04-24 22:44 ` [PATCH 2/2] ARM: shmobile: henninger: add Ether DT support Sergei Shtylyov 2014-04-24 22:44 ` Sergei Shtylyov 2014-04-24 22:44 ` Sergei Shtylyov 2014-04-25 1:31 ` [PATCH 0/2] Add R8A7791/Henninger board " Simon Horman 2014-04-25 1:31 ` Simon Horman 2014-04-25 1:31 ` Simon Horman 2015-01-30 22:52 ` [PATCH] ARM: shmobile: silk: initial device tree Sergei Shtylyov 2015-01-30 22:52 ` Sergei Shtylyov 2015-01-30 22:52 ` Sergei Shtylyov 2015-01-31 4:21 ` Simon Horman 2015-01-31 4:21 ` Simon Horman 2015-01-31 4:21 ` Simon Horman 2015-01-31 18:27 ` Sergei Shtylyov 2015-01-31 18:27 ` Sergei Shtylyov 2015-01-31 18:27 ` Sergei Shtylyov 2015-02-02 0:19 ` Simon Horman 2015-02-02 0:19 ` Simon Horman 2015-02-02 0:19 ` Simon Horman 2015-02-02 11:03 ` Mark Rutland 2015-02-02 11:03 ` Mark Rutland 2015-02-02 11:03 ` Mark Rutland 2015-02-04 22:46 ` Sergei Shtylyov 2015-02-04 22:46 ` Sergei Shtylyov 2015-02-04 22:46 ` Sergei Shtylyov 2015-02-02 11:05 ` Mark Rutland 2015-02-02 11:05 ` Mark Rutland 2015-02-02 11:05 ` Mark Rutland 2015-02-02 20:57 ` Sergei Shtylyov 2015-02-02 20:57 ` Sergei Shtylyov 2015-02-02 20:57 ` Sergei Shtylyov 2015-02-03 0:36 ` Simon Horman 2015-02-03 0:36 ` Simon Horman 2015-02-03 0:36 ` Simon Horman 2015-02-03 9:53 ` Geert Uytterhoeven 2015-02-03 9:53 ` Geert Uytterhoeven 2015-02-03 9:53 ` Geert Uytterhoeven 2015-02-04 0:28 ` Simon Horman 2015-02-04 0:28 ` Simon Horman 2015-02-04 0:28 ` Simon Horman 2015-02-03 10:48 ` Sergei Shtylyov 2015-02-03 10:48 ` Sergei Shtylyov 2015-02-03 10:48 ` Sergei Shtylyov 2015-02-02 20:49 ` Sergei Shtylyov 2015-02-02 20:49 ` Sergei Shtylyov 2015-02-02 20:49 ` Sergei Shtylyov 2015-02-11 22:06 ` [PATCH] ARM: shmobile: r8a7794: add PFC DT support Sergei Shtylyov 2015-02-11 22:06 ` Sergei Shtylyov 2015-02-11 22:06 ` Sergei Shtylyov 2015-02-12 12:20 ` Geert Uytterhoeven 2015-02-12 12:20 ` Geert Uytterhoeven 2015-02-12 12:20 ` Geert Uytterhoeven 2015-02-15 16:57 ` Simon Horman 2015-02-15 16:57 ` Simon Horman 2015-02-15 16:57 ` Simon Horman 2015-02-15 17:00 ` Simon Horman 2015-02-15 17:00 ` Simon Horman 2015-02-15 17:00 ` Simon Horman 2015-02-15 17:02 ` Sergei Shtylyov 2015-02-15 17:02 ` Sergei Shtylyov 2015-02-15 17:02 ` Sergei Shtylyov 2015-07-28 12:45 ` Sergei Shtylyov 2015-07-28 12:45 ` Sergei Shtylyov 2015-07-28 12:45 ` Sergei Shtylyov 2015-07-28 23:44 ` Simon Horman 2015-07-28 23:44 ` Simon Horman 2015-07-28 23:44 ` Simon Horman 2015-02-11 22:27 ` [PATCH v2] ARM: shmobile: silk: initial device tree Sergei Shtylyov 2015-02-11 22:27 ` Sergei Shtylyov 2015-02-11 22:27 ` Sergei Shtylyov 2015-02-11 22:41 ` [PATCH] ARM: shmobile: silk: add Ether DT support Sergei Shtylyov 2015-02-11 22:41 ` Sergei Shtylyov 2015-02-11 22:41 ` Sergei Shtylyov 2015-07-27 22:29 ` [PATCH v2] ARM: shmobile: r8a7794: add PFC " Sergei Shtylyov 2015-07-27 22:29 ` Sergei Shtylyov 2015-07-27 22:29 ` Sergei Shtylyov 2015-07-28 23:44 ` Simon Horman 2015-07-28 23:44 ` Simon Horman 2015-07-28 23:44 ` Simon Horman 2015-07-28 22:14 ` [PATCH v3] ARM: shmobile: silk: initial device tree Sergei Shtylyov 2015-07-28 22:14 ` Sergei Shtylyov 2015-07-28 22:14 ` Sergei Shtylyov 2015-07-30 0:07 ` Simon Horman 2015-07-30 0:07 ` Simon Horman 2015-07-30 0:07 ` Simon Horman 2015-08-03 13:00 ` Geert Uytterhoeven 2015-08-03 13:00 ` Geert Uytterhoeven 2015-08-03 13:00 ` Geert Uytterhoeven 2015-08-03 15:13 ` Sergei Shtylyov 2015-08-03 15:13 ` Sergei Shtylyov 2015-08-03 15:13 ` Sergei Shtylyov 2015-08-03 15:19 ` Geert Uytterhoeven 2015-08-03 15:19 ` Geert Uytterhoeven 2015-08-03 15:19 ` Geert Uytterhoeven 2015-08-04 0:53 ` Simon Horman 2015-08-04 0:53 ` Simon Horman 2015-08-04 0:53 ` Simon Horman 2015-07-28 22:16 ` [PATCH RESEND] ARM: shmobile: silk: add Ether DT support Sergei Shtylyov 2015-07-28 22:16 ` Sergei Shtylyov 2015-07-28 22:16 ` Sergei Shtylyov 2015-07-30 0:08 ` Simon Horman 2015-07-30 0:08 ` Simon Horman 2015-07-30 0:08 ` Simon Horman 2015-07-30 19:59 ` [PATCH] DT: mmc: sh_mmcif: fix "compatible" property text Sergei Shtylyov 2015-07-30 19:59 ` Sergei Shtylyov 2015-07-30 20:33 ` Sergei Shtylyov 2015-07-30 20:33 ` Sergei Shtylyov 2015-07-31 2:23 ` Magnus Damm 2015-07-31 2:23 ` Magnus Damm 2015-07-31 9:50 ` Sergei Shtylyov 2015-08-03 1:09 ` Magnus Damm 2015-08-03 1:09 ` Magnus Damm 2015-08-03 15:21 ` Sergei Shtylyov 2015-07-31 10:46 ` Sergei Shtylyov 2015-08-01 9:41 ` Laurent Pinchart 2015-08-01 9:41 ` Laurent Pinchart 2015-07-30 21:29 ` [PATCH] DT: mmc: sh_mmcif: document R8A779[34] support Sergei Shtylyov 2015-07-30 21:29 ` Sergei Shtylyov 2015-08-11 22:37 ` [PATCH v2] DT: mmc: sh_mmcif: fix "compatible" property text Sergei Shtylyov 2015-08-11 22:37 ` Sergei Shtylyov 2015-08-12 0:56 ` Simon Horman [this message] 2015-08-12 0:56 ` Simon Horman 2015-08-12 10:41 ` Sergei Shtylyov 2015-08-12 10:41 ` Sergei Shtylyov 2015-08-12 23:58 ` Simon Horman 2015-08-12 23:58 ` Simon Horman 2015-08-11 22:57 ` [PATCH v2] DT: mmc: sh_mmcif: document R8A779[34] support Sergei Shtylyov 2015-08-11 22:57 ` Sergei Shtylyov 2015-08-12 0:59 ` Simon Horman 2015-08-12 0:59 ` Simon Horman 2015-08-12 10:38 ` Sergei Shtylyov 2015-08-12 10:38 ` Sergei Shtylyov 2015-08-12 23:59 ` Simon Horman 2015-08-12 23:59 ` Simon Horman 2015-08-13 9:27 ` Ulrich Hecht 2015-08-13 9:27 ` Ulrich Hecht 2015-09-29 23:26 ` [PATCH] ARM: shmobile: porter: initial device tree Sergei Shtylyov 2015-09-29 23:26 ` Sergei Shtylyov 2015-09-29 23:26 ` Sergei Shtylyov 2015-09-30 6:51 ` Geert Uytterhoeven 2015-09-30 6:51 ` Geert Uytterhoeven 2015-09-30 6:51 ` Geert Uytterhoeven 2015-09-30 13:33 ` Sergei Shtylyov 2015-09-30 13:33 ` Sergei Shtylyov 2015-09-30 13:33 ` Sergei Shtylyov 2015-09-30 19:08 ` Sergei Shtylyov 2015-09-30 19:08 ` Sergei Shtylyov 2015-09-30 19:08 ` Sergei Shtylyov 2015-09-30 23:01 ` [PATCH v2 1/2] ARM: shmobile: add Porter board DT bindings Sergei Shtylyov 2015-09-30 23:01 ` Sergei Shtylyov 2015-09-30 23:01 ` Sergei Shtylyov 2015-10-01 5:59 ` Geert Uytterhoeven 2015-10-01 5:59 ` Geert Uytterhoeven 2015-10-01 5:59 ` Geert Uytterhoeven 2015-10-02 1:16 ` Simon Horman 2015-10-02 1:16 ` Simon Horman 2015-10-02 1:16 ` Simon Horman 2015-09-30 23:02 ` [PATCH v2 2/2] ARM: shmobile: porter: initial device tree Sergei Shtylyov 2015-09-30 23:02 ` Sergei Shtylyov 2015-09-30 23:02 ` Sergei Shtylyov 2015-10-02 21:53 ` [PATCH] ARM: shmobile: fix SILK board name Sergei Shtylyov 2015-10-02 21:53 ` Sergei Shtylyov 2015-10-02 21:53 ` Sergei Shtylyov 2015-10-05 3:03 ` Simon Horman 2015-10-05 3:03 ` Simon Horman 2015-10-05 3:03 ` Simon Horman 2015-10-05 22:51 ` [PATCH] ARM: shmobile: porter: add Ether DT support Sergei Shtylyov 2015-10-05 22:51 ` Sergei Shtylyov 2015-10-05 22:51 ` Sergei Shtylyov 2015-10-06 0:45 ` Simon Horman 2015-10-06 0:45 ` Simon Horman 2015-10-06 0:45 ` Simon Horman 2015-10-15 22:39 ` [PATCH v3] DT: mmc: sh_mmcif: fix "compatible" property text Sergei Shtylyov 2015-10-15 22:39 ` Sergei Shtylyov 2015-10-16 6:42 ` Geert Uytterhoeven 2015-10-16 6:42 ` Geert Uytterhoeven [not found] ` <2188985.g7lrY44qCa-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org> 2015-10-16 13:07 ` Ulf Hansson 2015-10-16 13:07 ` Ulf Hansson 2015-10-15 22:40 ` [PATCH v3] DT: mmc: sh_mmcif: document R8A779[34] support Sergei Shtylyov 2015-10-15 22:40 ` Sergei Shtylyov 2015-10-16 6:42 ` Geert Uytterhoeven 2015-10-16 6:42 ` Geert Uytterhoeven 2015-10-16 13:07 ` Ulf Hansson 2015-10-16 13:07 ` Ulf Hansson 2015-10-20 20:19 ` Sergei Shtylyov 2015-10-20 20:19 ` Sergei Shtylyov [not found] ` <5626A1CF.9050309-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2015-10-21 8:38 ` Ulf Hansson 2015-10-21 8:38 ` Ulf Hansson 2015-10-21 18:42 ` Sergei Shtylyov 2015-10-21 18:42 ` Sergei Shtylyov 2015-10-27 16:58 ` Geert Uytterhoeven 2015-10-27 16:58 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150812005628.GE15957@verge.net.au \ --to=horms@verge.net.au \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ --cc=sergei.shtylyov@cogentembedded.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.