All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] network/tcp_fastopen: fix typo in check_opt() and check_opt_l()
@ 2015-08-25  8:51 Alexey Kodanev
       [not found] ` <55DC450D.4070501@oracle.com>
  0 siblings, 1 reply; 2+ messages in thread
From: Alexey Kodanev @ 2015-08-25  8:51 UTC (permalink / raw)
  To: ltp-list; +Cc: vasily.isaenko

Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
---
 testcases/network/tcp_fastopen/tcp_fastopen.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/network/tcp_fastopen/tcp_fastopen.c b/testcases/network/tcp_fastopen/tcp_fastopen.c
index 6c0d7b8..08a6019 100644
--- a/testcases/network/tcp_fastopen/tcp_fastopen.c
+++ b/testcases/network/tcp_fastopen/tcp_fastopen.c
@@ -669,7 +669,7 @@ static void check_opt(const char *name, char *arg, int *val, int lim)
 		if (sscanf(arg, "%i", val) != 1)
 			tst_brkm(TBROK, NULL, "-%s option arg is not a number",
 				 name);
-		if (clients_num < lim)
+		if (*val < lim)
 			tst_brkm(TBROK, NULL, "-%s option arg is less than %d",
 				name, lim);
 	}
@@ -681,7 +681,7 @@ static void check_opt_l(const char *name, char *arg, long *val, long lim)
 		if (sscanf(arg, "%ld", val) != 1)
 			tst_brkm(TBROK, NULL, "-%s option arg is not a number",
 				 name);
-		if (clients_num < lim)
+		if (*val < lim)
 			tst_brkm(TBROK, NULL, "-%s option arg is less than %ld",
 				name, lim);
 	}
-- 
1.7.1


------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [LTP] [PATCH] network/tcp_fastopen: fix typo in check_opt() and check_opt_l()
       [not found] ` <55DC450D.4070501@oracle.com>
@ 2015-08-25 11:18   ` Cyril Hrubis
  0 siblings, 0 replies; 2+ messages in thread
From: Cyril Hrubis @ 2015-08-25 11:18 UTC (permalink / raw)
  To: Alexey Kodanev; +Cc: vasily.isaenko, ltp-list

Hi!
> Can we apply this patch before release?

Sure, acked.

(I wonder how we missed that in the review...)

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-25 11:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-25  8:51 [LTP] [PATCH] network/tcp_fastopen: fix typo in check_opt() and check_opt_l() Alexey Kodanev
     [not found] ` <55DC450D.4070501@oracle.com>
2015-08-25 11:18   ` Cyril Hrubis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.