All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: sparc: amd7930: Fix module autoload for OF platform driver
@ 2015-09-03 11:03 Luis de Bethencourt
  2015-09-04 10:14   ` Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: Luis de Bethencourt @ 2015-09-03 11:03 UTC (permalink / raw)
  To: linux-kernel
  Cc: Jaroslav Kysela, Takashi Iwai, Wolfram Sang, Christophe JAILLET,
	alsa-devel, Javier Martinez Canillas

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
---

Hello,

This patch adds the missing MODULE_DEVICE_TABLE() for OF to eport
that information so modules have the correct aliases built-in and
autoloading works correctly.

A longer explanation by Javier Canillas can be found here:
https://lkml.org/lkml/2015/7/30/519

Thanks,
Luis

 sound/sparc/amd7930.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/sparc/amd7930.c b/sound/sparc/amd7930.c
index 784ceb8..35c1f6a 100644
--- a/sound/sparc/amd7930.c
+++ b/sound/sparc/amd7930.c
@@ -1064,6 +1064,7 @@ static const struct of_device_id amd7930_match[] = {
 	},
 	{},
 };
+MODULE_DEVICE_TABLE(of, amd7930_match);
 
 static struct platform_driver amd7930_sbus_driver = {
 	.driver = {
-- 
2.4.6


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: sparc: amd7930: Fix module autoload for OF platform driver
  2015-09-03 11:03 [PATCH] ALSA: sparc: amd7930: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-09-04 10:14   ` Takashi Iwai
  0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2015-09-04 10:14 UTC (permalink / raw)
  To: Luis de Bethencourt
  Cc: linux-kernel, alsa-devel, Javier Martinez Canillas,
	Jaroslav Kysela, Wolfram Sang, Christophe JAILLET

On Thu, 03 Sep 2015 13:03:04 +0200,
Luis de Bethencourt wrote:
> 
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>

Applied, thanks.


Takashi

> ---
> 
> Hello,
> 
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to eport
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
> 
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
> 
> Thanks,
> Luis
> 
>  sound/sparc/amd7930.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/sparc/amd7930.c b/sound/sparc/amd7930.c
> index 784ceb8..35c1f6a 100644
> --- a/sound/sparc/amd7930.c
> +++ b/sound/sparc/amd7930.c
> @@ -1064,6 +1064,7 @@ static const struct of_device_id amd7930_match[] = {
>  	},
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, amd7930_match);
>  
>  static struct platform_driver amd7930_sbus_driver = {
>  	.driver = {
> -- 
> 2.4.6
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: sparc: amd7930: Fix module autoload for OF platform driver
@ 2015-09-04 10:14   ` Takashi Iwai
  0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2015-09-04 10:14 UTC (permalink / raw)
  To: Luis de Bethencourt
  Cc: linux-kernel, alsa-devel, Javier Martinez Canillas,
	Jaroslav Kysela, Wolfram Sang, Christophe JAILLET

On Thu, 03 Sep 2015 13:03:04 +0200,
Luis de Bethencourt wrote:
> 
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>

Applied, thanks.


Takashi

> ---
> 
> Hello,
> 
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to eport
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
> 
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
> 
> Thanks,
> Luis
> 
>  sound/sparc/amd7930.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/sparc/amd7930.c b/sound/sparc/amd7930.c
> index 784ceb8..35c1f6a 100644
> --- a/sound/sparc/amd7930.c
> +++ b/sound/sparc/amd7930.c
> @@ -1064,6 +1064,7 @@ static const struct of_device_id amd7930_match[] = {
>  	},
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, amd7930_match);
>  
>  static struct platform_driver amd7930_sbus_driver = {
>  	.driver = {
> -- 
> 2.4.6
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-09-04 10:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-03 11:03 [PATCH] ALSA: sparc: amd7930: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-04 10:14 ` Takashi Iwai
2015-09-04 10:14   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.