All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] staging: mt29f_spinand: Fix module autoload for OF platform driver
@ 2015-09-03 11:13 Luis de Bethencourt
  2015-09-04  6:12 ` Sudip Mukherjee
  0 siblings, 1 reply; 3+ messages in thread
From: Luis de Bethencourt @ 2015-09-03 11:13 UTC (permalink / raw)
  To: linux-kernel
  Cc: Greg Kroah-Hartman, Devendra Naga, Aya Mahfouz, Antonio Borneo,
	devel, Javier Martinez Canillas

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
---
 drivers/staging/mt29f_spinand/mt29f_spinand.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c b/drivers/staging/mt29f_spinand/mt29f_spinand.c
index ad30ce4..1aa449e 100644
--- a/drivers/staging/mt29f_spinand/mt29f_spinand.c
+++ b/drivers/staging/mt29f_spinand/mt29f_spinand.c
@@ -941,6 +941,7 @@ static const struct of_device_id spinand_dt[] = {
 	{ .compatible = "spinand,mt29f", },
 	{}
 };
+MODULE_DEVICE_TABLE(of, spinand_dt);
 
 /*
  * Device name structure description
-- 
2.4.6


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] staging: mt29f_spinand: Fix module autoload for OF platform driver
  2015-09-03 11:13 [PATCH 1/2] staging: mt29f_spinand: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-09-04  6:12 ` Sudip Mukherjee
  2015-09-04 11:30   ` Luis de Bethencourt
  0 siblings, 1 reply; 3+ messages in thread
From: Sudip Mukherjee @ 2015-09-04  6:12 UTC (permalink / raw)
  To: Luis de Bethencourt
  Cc: linux-kernel, devel, Greg Kroah-Hartman, Antonio Borneo,
	Javier Martinez Canillas

On Thu, Sep 03, 2015 at 01:13:14PM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> ---
I think you need to refresh your tree. This has already been done by:
ddaaa82ef93d ("staging: mt29f_spinand: Export OF module alias information");

regards
sudip

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] staging: mt29f_spinand: Fix module autoload for OF platform driver
  2015-09-04  6:12 ` Sudip Mukherjee
@ 2015-09-04 11:30   ` Luis de Bethencourt
  0 siblings, 0 replies; 3+ messages in thread
From: Luis de Bethencourt @ 2015-09-04 11:30 UTC (permalink / raw)
  To: Sudip Mukherjee
  Cc: linux-kernel, devel, Greg Kroah-Hartman, Antonio Borneo,
	Javier Martinez Canillas

On Fri, Sep 04, 2015 at 11:42:37AM +0530, Sudip Mukherjee wrote:
> On Thu, Sep 03, 2015 at 01:13:14PM +0200, Luis de Bethencourt wrote:
> > This platform driver has a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> > 
> > Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> > ---
> I think you need to refresh your tree. This has already been done by:
> ddaaa82ef93d ("staging: mt29f_spinand: Export OF module alias information");
> 
> regards
> sudip

Javier asked me to help him with the autoloading of Open Firmware driving.
We have clashed 3 times.

Sorry about that and thanks for the review Sudip,
Luis

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-09-04 11:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-03 11:13 [PATCH 1/2] staging: mt29f_spinand: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-04  6:12 ` Sudip Mukherjee
2015-09-04 11:30   ` Luis de Bethencourt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.