* [PATCH bluetooth-next] ieee802154: 6lowpan: use correct ESC value for dispatch
@ 2015-09-03 12:54 Stefan Schmidt
2015-09-03 13:06 ` Alexander Aring
2015-09-03 14:07 ` Marcel Holtmann
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Schmidt @ 2015-09-03 12:54 UTC (permalink / raw)
To: linux-wpan; +Cc: Alexander Aring, Stefan Schmidt
The ESC dispatch value has some history and it originally was 0x7f in rfc4944
(see section-5.1). With the release of rfc6282 this value got part of the
LOWPAN_IPHC range and was no longer available for ESC. Instead 0x40 was used
as replacement (see section-2 in rfc6282).
We have been checking the dispatch byte in an order where IPHC would always be
evaluated before ESC and thus we would never reach the ESC check as the IPHC
range already covers this value.
Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
---
net/ieee802154/6lowpan/rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ieee802154/6lowpan/rx.c b/net/ieee802154/6lowpan/rx.c
index 3c31980..b1fd47d 100644
--- a/net/ieee802154/6lowpan/rx.c
+++ b/net/ieee802154/6lowpan/rx.c
@@ -20,7 +20,7 @@
#define LOWPAN_DISPATCH_FRAG_MASK 0xf8
#define LOWPAN_DISPATCH_NALP 0x00
-#define LOWPAN_DISPATCH_ESC 0x7f
+#define LOWPAN_DISPATCH_ESC 0x40
#define LOWPAN_DISPATCH_HC1 0x42
#define LOWPAN_DISPATCH_DFF 0x43
#define LOWPAN_DISPATCH_BC0 0x50
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bluetooth-next] ieee802154: 6lowpan: use correct ESC value for dispatch
2015-09-03 12:54 [PATCH bluetooth-next] ieee802154: 6lowpan: use correct ESC value for dispatch Stefan Schmidt
@ 2015-09-03 13:06 ` Alexander Aring
2015-09-03 14:07 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Aring @ 2015-09-03 13:06 UTC (permalink / raw)
To: Stefan Schmidt; +Cc: linux-wpan
On Thu, Sep 03, 2015 at 02:54:19PM +0200, Stefan Schmidt wrote:
> The ESC dispatch value has some history and it originally was 0x7f in rfc4944
> (see section-5.1). With the release of rfc6282 this value got part of the
> LOWPAN_IPHC range and was no longer available for ESC. Instead 0x40 was used
> as replacement (see section-2 in rfc6282).
>
> We have been checking the dispatch byte in an order where IPHC would always be
> evaluated before ESC and thus we would never reach the ESC check as the IPHC
> range already covers this value.
>
> Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
Acked-by: Alexander Aring <alex.aring@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bluetooth-next] ieee802154: 6lowpan: use correct ESC value for dispatch
2015-09-03 12:54 [PATCH bluetooth-next] ieee802154: 6lowpan: use correct ESC value for dispatch Stefan Schmidt
2015-09-03 13:06 ` Alexander Aring
@ 2015-09-03 14:07 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2015-09-03 14:07 UTC (permalink / raw)
To: Stefan Schmidt; +Cc: linux-wpan, Alexander Aring
Hi Stefan,
> The ESC dispatch value has some history and it originally was 0x7f in rfc4944
> (see section-5.1). With the release of rfc6282 this value got part of the
> LOWPAN_IPHC range and was no longer available for ESC. Instead 0x40 was used
> as replacement (see section-2 in rfc6282).
>
> We have been checking the dispatch byte in an order where IPHC would always be
> evaluated before ESC and thus we would never reach the ESC check as the IPHC
> range already covers this value.
>
> Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
> ---
> net/ieee802154/6lowpan/rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-03 14:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-03 12:54 [PATCH bluetooth-next] ieee802154: 6lowpan: use correct ESC value for dispatch Stefan Schmidt
2015-09-03 13:06 ` Alexander Aring
2015-09-03 14:07 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.