All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] sama5d33ek: enable led D3
@ 2015-09-10 15:09 ` Nicolas Ferre
  0 siblings, 0 replies; 10+ messages in thread
From: Nicolas Ferre @ 2015-09-10 15:09 UTC (permalink / raw)
  To: Josh Wu, Alexandre Belloni
  Cc: linux-arm-kernel, Jean-Christophe PLAGNIOL-VILLARD, linux-kernel

From: Josh Wu <josh.wu@atmel.com>

Signed-off-by: Josh Wu <josh.wu@atmel.com>
---
 arch/arm/boot/dts/sama5d33ek.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/sama5d33ek.dts b/arch/arm/boot/dts/sama5d33ek.dts
index cbd6a3ff1545..48d7445828dd 100644
--- a/arch/arm/boot/dts/sama5d33ek.dts
+++ b/arch/arm/boot/dts/sama5d33ek.dts
@@ -39,6 +39,13 @@
 		};
 	};
 
+	leds {
+		d3 {
+			label = "d3";
+			gpios = <&pioE 24 GPIO_ACTIVE_HIGH>;
+		};
+	};
+
 	sound {
 		status = "okay";
 	};
-- 
2.1.3


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 1/2] sama5d33ek: enable led D3
@ 2015-09-10 15:09 ` Nicolas Ferre
  0 siblings, 0 replies; 10+ messages in thread
From: Nicolas Ferre @ 2015-09-10 15:09 UTC (permalink / raw)
  To: linux-arm-kernel

From: Josh Wu <josh.wu@atmel.com>

Signed-off-by: Josh Wu <josh.wu@atmel.com>
---
 arch/arm/boot/dts/sama5d33ek.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/sama5d33ek.dts b/arch/arm/boot/dts/sama5d33ek.dts
index cbd6a3ff1545..48d7445828dd 100644
--- a/arch/arm/boot/dts/sama5d33ek.dts
+++ b/arch/arm/boot/dts/sama5d33ek.dts
@@ -39,6 +39,13 @@
 		};
 	};
 
+	leds {
+		d3 {
+			label = "d3";
+			gpios = <&pioE 24 GPIO_ACTIVE_HIGH>;
+		};
+	};
+
 	sound {
 		status = "okay";
 	};
-- 
2.1.3

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name
  2015-09-10 15:09 ` Nicolas Ferre
@ 2015-09-10 15:09   ` Nicolas Ferre
  -1 siblings, 0 replies; 10+ messages in thread
From: Nicolas Ferre @ 2015-09-10 15:09 UTC (permalink / raw)
  To: Josh Wu, Alexandre Belloni
  Cc: linux-arm-kernel, Jean-Christophe PLAGNIOL-VILLARD, linux-kernel

From: Josh Wu <josh.wu@atmel.com>

Correct the led labels in at91sam9n12ek.

Signed-off-by: Josh Wu <josh.wu@atmel.com>
---
 arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
index efa75064d38a..186a1705f8d3 100644
--- a/arch/arm/boot/dts/at91sam9n12ek.dts
+++ b/arch/arm/boot/dts/at91sam9n12ek.dts
@@ -204,13 +204,13 @@
 		};
 
 		d9 {
-			label = "d6";
+			label = "d9";
 			gpios = <&pioB 5 GPIO_ACTIVE_LOW>;
 			linux,default-trigger = "nand-disk";
 		};
 
 		d10 {
-			label = "d7";
+			label = "d10";
 			gpios = <&pioB 6 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "heartbeat";
 		};
-- 
2.1.3


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name
@ 2015-09-10 15:09   ` Nicolas Ferre
  0 siblings, 0 replies; 10+ messages in thread
From: Nicolas Ferre @ 2015-09-10 15:09 UTC (permalink / raw)
  To: linux-arm-kernel

From: Josh Wu <josh.wu@atmel.com>

Correct the led labels in at91sam9n12ek.

Signed-off-by: Josh Wu <josh.wu@atmel.com>
---
 arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
index efa75064d38a..186a1705f8d3 100644
--- a/arch/arm/boot/dts/at91sam9n12ek.dts
+++ b/arch/arm/boot/dts/at91sam9n12ek.dts
@@ -204,13 +204,13 @@
 		};
 
 		d9 {
-			label = "d6";
+			label = "d9";
 			gpios = <&pioB 5 GPIO_ACTIVE_LOW>;
 			linux,default-trigger = "nand-disk";
 		};
 
 		d10 {
-			label = "d7";
+			label = "d10";
 			gpios = <&pioB 6 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "heartbeat";
 		};
-- 
2.1.3

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name
  2015-09-10 15:09   ` Nicolas Ferre
@ 2015-09-10 15:24     ` Alexandre Belloni
  -1 siblings, 0 replies; 10+ messages in thread
From: Alexandre Belloni @ 2015-09-10 15:24 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: Josh Wu, linux-arm-kernel, Jean-Christophe PLAGNIOL-VILLARD,
	linux-kernel

Hi,

On 10/09/2015 at 17:09:47 +0200, Nicolas Ferre wrote :
> From: Josh Wu <josh.wu@atmel.com>
> 
> Correct the led labels in at91sam9n12ek.
> 
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
>  arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
> index efa75064d38a..186a1705f8d3 100644
> --- a/arch/arm/boot/dts/at91sam9n12ek.dts
> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
> @@ -204,13 +204,13 @@
>  		};
>  
>  		d9 {
> -			label = "d6";
> +			label = "d9";
>  			gpios = <&pioB 5 GPIO_ACTIVE_LOW>;
>  			linux,default-trigger = "nand-disk";
>  		};
>  
>  		d10 {
> -			label = "d7";
> +			label = "d10";
>  			gpios = <&pioB 6 GPIO_ACTIVE_HIGH>;
>  			linux,default-trigger = "heartbeat";
>  		};

The only concern being that this renaming will break userspace software
assuming the LEDs are wrongly named. Is there anything that has been
released by atmel that uses the wrong names (and my guess is yess and
that is why there are named as such) and do you care about it?


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name
@ 2015-09-10 15:24     ` Alexandre Belloni
  0 siblings, 0 replies; 10+ messages in thread
From: Alexandre Belloni @ 2015-09-10 15:24 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On 10/09/2015 at 17:09:47 +0200, Nicolas Ferre wrote :
> From: Josh Wu <josh.wu@atmel.com>
> 
> Correct the led labels in at91sam9n12ek.
> 
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
>  arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
> index efa75064d38a..186a1705f8d3 100644
> --- a/arch/arm/boot/dts/at91sam9n12ek.dts
> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
> @@ -204,13 +204,13 @@
>  		};
>  
>  		d9 {
> -			label = "d6";
> +			label = "d9";
>  			gpios = <&pioB 5 GPIO_ACTIVE_LOW>;
>  			linux,default-trigger = "nand-disk";
>  		};
>  
>  		d10 {
> -			label = "d7";
> +			label = "d10";
>  			gpios = <&pioB 6 GPIO_ACTIVE_HIGH>;
>  			linux,default-trigger = "heartbeat";
>  		};

The only concern being that this renaming will break userspace software
assuming the LEDs are wrongly named. Is there anything that has been
released by atmel that uses the wrong names (and my guess is yess and
that is why there are named as such) and do you care about it?


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name
  2015-09-10 15:24     ` Alexandre Belloni
@ 2015-09-18 13:46       ` Nicolas Ferre
  -1 siblings, 0 replies; 10+ messages in thread
From: Nicolas Ferre @ 2015-09-18 13:46 UTC (permalink / raw)
  To: Alexandre Belloni, Josh Wu
  Cc: linux-arm-kernel, Jean-Christophe PLAGNIOL-VILLARD, linux-kernel

Le 10/09/2015 17:24, Alexandre Belloni a écrit :
> Hi,
> 
> On 10/09/2015 at 17:09:47 +0200, Nicolas Ferre wrote :
>> From: Josh Wu <josh.wu@atmel.com>
>>
>> Correct the led labels in at91sam9n12ek.
>>
>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
>> ---
>>  arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
>> index efa75064d38a..186a1705f8d3 100644
>> --- a/arch/arm/boot/dts/at91sam9n12ek.dts
>> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
>> @@ -204,13 +204,13 @@
>>  		};
>>  
>>  		d9 {
>> -			label = "d6";
>> +			label = "d9";
>>  			gpios = <&pioB 5 GPIO_ACTIVE_LOW>;
>>  			linux,default-trigger = "nand-disk";
>>  		};
>>  
>>  		d10 {
>> -			label = "d7";
>> +			label = "d10";
>>  			gpios = <&pioB 6 GPIO_ACTIVE_HIGH>;
>>  			linux,default-trigger = "heartbeat";
>>  		};
> 
> The only concern being that this renaming will break userspace software
> assuming the LEDs are wrongly named. Is there anything that has been
> released by atmel that uses the wrong names (and my guess is yess and
> that is why there are named as such) and do you care about it?

My guess is that the label was wrongly named from the beginning and no
board revision had the "d6" nor "d7" names.
It makes sense to rename them for the evaluation kit...

Bye,
-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name
@ 2015-09-18 13:46       ` Nicolas Ferre
  0 siblings, 0 replies; 10+ messages in thread
From: Nicolas Ferre @ 2015-09-18 13:46 UTC (permalink / raw)
  To: linux-arm-kernel

Le 10/09/2015 17:24, Alexandre Belloni a ?crit :
> Hi,
> 
> On 10/09/2015 at 17:09:47 +0200, Nicolas Ferre wrote :
>> From: Josh Wu <josh.wu@atmel.com>
>>
>> Correct the led labels in at91sam9n12ek.
>>
>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
>> ---
>>  arch/arm/boot/dts/at91sam9n12ek.dts | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
>> index efa75064d38a..186a1705f8d3 100644
>> --- a/arch/arm/boot/dts/at91sam9n12ek.dts
>> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
>> @@ -204,13 +204,13 @@
>>  		};
>>  
>>  		d9 {
>> -			label = "d6";
>> +			label = "d9";
>>  			gpios = <&pioB 5 GPIO_ACTIVE_LOW>;
>>  			linux,default-trigger = "nand-disk";
>>  		};
>>  
>>  		d10 {
>> -			label = "d7";
>> +			label = "d10";
>>  			gpios = <&pioB 6 GPIO_ACTIVE_HIGH>;
>>  			linux,default-trigger = "heartbeat";
>>  		};
> 
> The only concern being that this renaming will break userspace software
> assuming the LEDs are wrongly named. Is there anything that has been
> released by atmel that uses the wrong names (and my guess is yess and
> that is why there are named as such) and do you care about it?

My guess is that the label was wrongly named from the beginning and no
board revision had the "d6" nor "d7" names.
It makes sense to rename them for the evaluation kit...

Bye,
-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name
  2015-09-18 13:46       ` Nicolas Ferre
@ 2015-09-18 22:08         ` Alexandre Belloni
  -1 siblings, 0 replies; 10+ messages in thread
From: Alexandre Belloni @ 2015-09-18 22:08 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: Josh Wu, linux-arm-kernel, Jean-Christophe PLAGNIOL-VILLARD,
	linux-kernel

Hi,

On 18/09/2015 at 15:46:33 +0200, Nicolas Ferre wrote :
> > The only concern being that this renaming will break userspace software
> > assuming the LEDs are wrongly named. Is there anything that has been
> > released by atmel that uses the wrong names (and my guess is yess and
> > that is why there are named as such) and do you care about it?
> 
> My guess is that the label was wrongly named from the beginning and no
> board revision had the "d6" nor "d7" names.
> It makes sense to rename them for the evaluation kit...
> 

Yeah, I'm fine with the change. I was simply warning that it may break
some demos Atmel distributed before (but I didn't ever seen or used
those anyway so I may be wrong).

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name
@ 2015-09-18 22:08         ` Alexandre Belloni
  0 siblings, 0 replies; 10+ messages in thread
From: Alexandre Belloni @ 2015-09-18 22:08 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On 18/09/2015 at 15:46:33 +0200, Nicolas Ferre wrote :
> > The only concern being that this renaming will break userspace software
> > assuming the LEDs are wrongly named. Is there anything that has been
> > released by atmel that uses the wrong names (and my guess is yess and
> > that is why there are named as such) and do you care about it?
> 
> My guess is that the label was wrongly named from the beginning and no
> board revision had the "d6" nor "d7" names.
> It makes sense to rename them for the evaluation kit...
> 

Yeah, I'm fine with the change. I was simply warning that it may break
some demos Atmel distributed before (but I didn't ever seen or used
those anyway so I may be wrong).

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-09-18 22:09 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-10 15:09 [PATCH 1/2] sama5d33ek: enable led D3 Nicolas Ferre
2015-09-10 15:09 ` Nicolas Ferre
2015-09-10 15:09 ` [PATCH 2/2] ARM: at91: at91sam9n12ek/dts: fix the led labels name Nicolas Ferre
2015-09-10 15:09   ` Nicolas Ferre
2015-09-10 15:24   ` Alexandre Belloni
2015-09-10 15:24     ` Alexandre Belloni
2015-09-18 13:46     ` Nicolas Ferre
2015-09-18 13:46       ` Nicolas Ferre
2015-09-18 22:08       ` Alexandre Belloni
2015-09-18 22:08         ` Alexandre Belloni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.