[PATCH] drivers: stating: wilc1000: Add a check for SPI availability

[PATCH] drivers: stating: wilc1000: Add a check for SPI availability

[Chandra S Gorentla]

NULL pointer deference is observed in the wilc1000.ko module
with bus type SPI and when SPI is not ready.

Signed-off-by: Chandra S Gorentla <csgorentla@gmail.com>
---

Following are the steps to reproduce.

$ sudo insmod drivers/staging/wilc1000/wilc1000.ko
$ sudo ifconfig wlan1 up

wlan1 in the above command is the device controlled by 'wilc1000.ko'.

 drivers/staging/wilc1000/linux_wlan.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
index 63f44f8..48f063d 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -1634,6 +1634,12 @@ int mac_open(struct net_device *ndev)
 	int i = 0;
 	struct WILC_WFI_priv *priv;
 
+#ifdef WILC_SPI
+	if (!g_linux_wlan || !g_linux_wlan->wilc_spidev) {
+		netdev_err(ndev, "wilc1000: SPI device not ready\n");
+		return -ENODEV;
+	}
+#endif
 	nic = netdev_priv(ndev);
 	priv = wiphy_priv(nic->wilc_netdev->ieee80211_ptr->wiphy);
 	PRINT_D(INIT_DBG, "MAC OPEN[%p]\n", ndev);
-- 
2.5.0

Re: [PATCH] drivers: stating: wilc1000: Add a check for SPI availability

[Sudip Mukherjee]

On Mon, Sep 14, 2015 at 10:21:14PM +0530, Chandra S Gorentla wrote:
> NULL pointer deference is observed in the wilc1000.ko module
> with bus type SPI and when SPI is not ready.
> 
> Signed-off-by: Chandra S Gorentla <csgorentla@gmail.com>
> ---
A small spelling mistake in the subject. It should be "staging" and not
"stating"

regards
sudip