* [GIT PULL 0/8] perf/core improvements and fixes
@ 2015-09-15 15:28 Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 1/8] perf probe: Free perf_probe_event in cleanup_perf_probe_events() Arnaldo Carvalho de Melo
` (8 more replies)
0 siblings, 9 replies; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-15 15:28 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Alexei Starovoitov,
Brendan Gregg, Daniel Borkmann, David Ahern, He Kuang, Jiri Olsa,
Kaixu Xia, Masami Hiramatsu, Matt Fleming, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, pi3orama, Raphael Beamonte,
Wang Nan, Zefan Li, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 9059b284caecb628fac826c2c5cc8ee85708eec1:
Merge tag 'perf-core-for-mingo-2' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-09-15 08:50:59 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to bbbe6bf6037d77816c4a19aaf35f4cecf662b49a:
perf tools: Introduce regs_query_register_offset() for x86 (2015-09-15 09:48:33 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Enhance the error reporting of tracepoint event parsing, e.g.:
$ oldperf record -e sched:sched_switc usleep 1
event syntax error: 'sched:sched_switc'
\___ unknown tracepoint
Run 'perf list' for a list of valid events
Now we get the much nicer:
$ perf record -e sched:sched_switc ls
event syntax error: 'sched:sched_switc'
\___ can't access trace events
Error: No permissions to read /sys/kernel/debug/tracing/events/sched/sched_switc
Hint: Try 'sudo mount -o remount,mode=755 /sys/kernel/debug'
And after we have those mount point permissions fixed:
$ perf record -e sched:sched_switc ls
event syntax error: 'sched:sched_switc'
\___ unknown tracepoint
Error: File /sys/kernel/debug/tracing/events/sched/sched_switc not found.
Hint: Perhaps this kernel misses some CONFIG_ setting to enable this feature?.
Now its just a matter of using what git uses to suggest alternatives when we
make a typo, i.e. that it is just an 'h' missing :-)
I.e. basically now the event parsing routing uses the strerror_open()
routines introduced by and used in 'perf trace' work. (Jiri Olsa)
Infrastructure:
- Export init/exit_probe_symbol_maps() from 'perf probe' for use in eBPF
(Namhyung Kim)
- Free perf_probe_event in cleanup_perf_probe_events() (Namhyung Kim)
- regs_query_register_offset() infrastructure + implementation for x86.
First user will be the perf/eBPF code (Wang Nan)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Jiri Olsa (4):
tools: Add err.h with ERR_PTR PTR_ERR interface
perf tools: Propagate error info for the tracepoint parsing
perf evsel: Propagate error info from tp_format
perf tools: Enhance parsing events tracepoint error output
Namhyung Kim (2):
perf probe: Free perf_probe_event in cleanup_perf_probe_events()
perf probe: Export init/exit_probe_symbol_maps()
Wang Nan (2):
perf tools: regs_query_register_offset() infrastructure
perf tools: Introduce regs_query_register_offset() for x86
tools/include/linux/err.h | 49 +++++++++++
tools/perf/arch/x86/Makefile | 1 +
tools/perf/arch/x86/util/dwarf-regs.c | 122 ++++++++++++++++++++--------
tools/perf/builtin-probe.c | 5 ++
tools/perf/builtin-trace.c | 19 +++--
tools/perf/config/Makefile | 4 +
tools/perf/tests/evsel-tp-sched.c | 10 ++-
tools/perf/tests/mmap-basic.c | 3 +-
tools/perf/tests/openat-syscall-all-cpus.c | 3 +-
tools/perf/tests/openat-syscall-tp-fields.c | 3 +-
tools/perf/tests/openat-syscall.c | 3 +-
tools/perf/util/evlist.c | 3 +-
tools/perf/util/evsel.c | 16 +++-
tools/perf/util/evsel.h | 3 +
tools/perf/util/include/dwarf-regs.h | 8 ++
tools/perf/util/parse-events.c | 66 +++++++++++----
tools/perf/util/parse-events.h | 3 +-
tools/perf/util/parse-events.y | 16 ++--
tools/perf/util/probe-event.c | 32 ++++----
tools/perf/util/probe-event.h | 2 +
tools/perf/util/trace-event.c | 15 +++-
21 files changed, 291 insertions(+), 95 deletions(-)
create mode 100644 tools/include/linux/err.h
^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 1/8] perf probe: Free perf_probe_event in cleanup_perf_probe_events()
2015-09-15 15:28 [GIT PULL 0/8] perf/core improvements and fixes Arnaldo Carvalho de Melo
@ 2015-09-15 15:28 ` Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 2/8] perf probe: Export init/exit_probe_symbol_maps() Arnaldo Carvalho de Melo
` (7 subsequent siblings)
8 siblings, 0 replies; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-15 15:28 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Namhyung Kim, Jiri Olsa, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Namhyung Kim <namhyung@kernel.org>
The cleanup_perf_probe_events() frees all resources related to a perf
probe event. However it only freed resources in trace probe events, not
perf probe events. So call clear_perf_probe_event() too.
Reported-by: Wang Nan <wangnan0@huawei.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1441852026-28974-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/probe-event.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 5964eccbe94d..3d7d60cc6f16 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -2792,6 +2792,7 @@ void cleanup_perf_probe_events(struct perf_probe_event *pevs, int npevs)
clear_probe_trace_event(&pevs[i].tevs[j]);
zfree(&pevs[i].tevs);
pevs[i].ntevs = 0;
+ clear_perf_probe_event(&pevs[i]);
}
exit_symbol_maps();
--
2.1.0
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 2/8] perf probe: Export init/exit_probe_symbol_maps()
2015-09-15 15:28 [GIT PULL 0/8] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 1/8] perf probe: Free perf_probe_event in cleanup_perf_probe_events() Arnaldo Carvalho de Melo
@ 2015-09-15 15:28 ` Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 3/8] tools: Add err.h with ERR_PTR PTR_ERR interface Arnaldo Carvalho de Melo
` (6 subsequent siblings)
8 siblings, 0 replies; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-15 15:28 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Namhyung Kim, Jiri Olsa, Peter Zijlstra, Wang Nan,
Arnaldo Carvalho de Melo
From: Namhyung Kim <namhyung@kernel.org>
The init/exit_symbols_maps() functions are to setup and cleanup
necessary info for probe events. But they need to be called from out of
the probe code now, so this patch exports them.
However the names are too generic, so change them to have 'probe'. :)
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1441852026-28974-2-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-probe.c | 5 +++++
tools/perf/util/probe-event.c | 31 +++++++++++++++----------------
tools/perf/util/probe-event.h | 2 ++
3 files changed, 22 insertions(+), 16 deletions(-)
diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index 2bec9c1ef2a3..94385ee89dc8 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -317,6 +317,10 @@ static int perf_add_probe_events(struct perf_probe_event *pevs, int npevs)
int i, k;
const char *event = NULL, *group = NULL;
+ ret = init_probe_symbol_maps(pevs->uprobes);
+ if (ret < 0)
+ return ret;
+
ret = convert_perf_probe_events(pevs, npevs);
if (ret < 0)
goto out_cleanup;
@@ -354,6 +358,7 @@ static int perf_add_probe_events(struct perf_probe_event *pevs, int npevs)
out_cleanup:
cleanup_perf_probe_events(pevs, npevs);
+ exit_probe_symbol_maps();
return ret;
}
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 3d7d60cc6f16..2b78e8f19b45 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -71,7 +71,7 @@ static char *synthesize_perf_probe_point(struct perf_probe_point *pp);
static struct machine *host_machine;
/* Initialize symbol maps and path of vmlinux/modules */
-static int init_symbol_maps(bool user_only)
+int init_probe_symbol_maps(bool user_only)
{
int ret;
@@ -101,7 +101,7 @@ out:
return ret;
}
-static void exit_symbol_maps(void)
+void exit_probe_symbol_maps(void)
{
if (host_machine) {
machine__delete(host_machine);
@@ -859,11 +859,11 @@ int show_line_range(struct line_range *lr, const char *module, bool user)
{
int ret;
- ret = init_symbol_maps(user);
+ ret = init_probe_symbol_maps(user);
if (ret < 0)
return ret;
ret = __show_line_range(lr, module, user);
- exit_symbol_maps();
+ exit_probe_symbol_maps();
return ret;
}
@@ -941,7 +941,7 @@ int show_available_vars(struct perf_probe_event *pevs, int npevs,
int i, ret = 0;
struct debuginfo *dinfo;
- ret = init_symbol_maps(pevs->uprobes);
+ ret = init_probe_symbol_maps(pevs->uprobes);
if (ret < 0)
return ret;
@@ -958,7 +958,7 @@ int show_available_vars(struct perf_probe_event *pevs, int npevs,
debuginfo__delete(dinfo);
out:
- exit_symbol_maps();
+ exit_probe_symbol_maps();
return ret;
}
@@ -2262,7 +2262,7 @@ int show_perf_probe_events(struct strfilter *filter)
setup_pager();
- ret = init_symbol_maps(false);
+ ret = init_probe_symbol_maps(false);
if (ret < 0)
return ret;
@@ -2278,7 +2278,7 @@ int show_perf_probe_events(struct strfilter *filter)
close(kp_fd);
if (up_fd > 0)
close(up_fd);
- exit_symbol_maps();
+ exit_probe_symbol_maps();
return ret;
}
@@ -2746,10 +2746,6 @@ int convert_perf_probe_events(struct perf_probe_event *pevs, int npevs)
{
int i, ret;
- ret = init_symbol_maps(pevs->uprobes);
- if (ret < 0)
- return ret;
-
/* Loop 1: convert all events */
for (i = 0; i < npevs; i++) {
/* Init kprobe blacklist if needed */
@@ -2794,20 +2790,23 @@ void cleanup_perf_probe_events(struct perf_probe_event *pevs, int npevs)
pevs[i].ntevs = 0;
clear_perf_probe_event(&pevs[i]);
}
-
- exit_symbol_maps();
}
int add_perf_probe_events(struct perf_probe_event *pevs, int npevs)
{
int ret;
+ ret = init_probe_symbol_maps(pevs->uprobes);
+ if (ret < 0)
+ return ret;
+
ret = convert_perf_probe_events(pevs, npevs);
if (ret == 0)
ret = apply_perf_probe_events(pevs, npevs);
cleanup_perf_probe_events(pevs, npevs);
+ exit_probe_symbol_maps();
return ret;
}
@@ -2867,7 +2866,7 @@ int show_available_funcs(const char *target, struct strfilter *_filter,
struct map *map;
int ret;
- ret = init_symbol_maps(user);
+ ret = init_probe_symbol_maps(user);
if (ret < 0)
return ret;
@@ -2897,7 +2896,7 @@ end:
if (user) {
map__put(map);
}
- exit_symbol_maps();
+ exit_probe_symbol_maps();
return ret;
}
diff --git a/tools/perf/util/probe-event.h b/tools/perf/util/probe-event.h
index 9bcea36359f2..ba926c30f8cd 100644
--- a/tools/perf/util/probe-event.h
+++ b/tools/perf/util/probe-event.h
@@ -110,6 +110,8 @@ struct variable_list {
};
struct map;
+int init_probe_symbol_maps(bool user_only);
+void exit_probe_symbol_maps(void);
/* Command string to events */
extern int parse_perf_probe_command(const char *cmd,
--
2.1.0
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 3/8] tools: Add err.h with ERR_PTR PTR_ERR interface
2015-09-15 15:28 [GIT PULL 0/8] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 1/8] perf probe: Free perf_probe_event in cleanup_perf_probe_events() Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 2/8] perf probe: Export init/exit_probe_symbol_maps() Arnaldo Carvalho de Melo
@ 2015-09-15 15:28 ` Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 4/8] perf tools: Propagate error info for the tracepoint parsing Arnaldo Carvalho de Melo
` (5 subsequent siblings)
8 siblings, 0 replies; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-15 15:28 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Jiri Olsa, David Ahern, Matt Fleming, Namhyung Kim,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Jiri Olsa <jolsa@kernel.org>
Adding part of the kernel's <linux/err.h> interface:
inline void * __must_check ERR_PTR(long error);
inline long __must_check PTR_ERR(__force const void *ptr);
inline bool __must_check IS_ERR(__force const void *ptr);
It will be used to propagate error through pointers in following
patches.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Reviewed-by: Raphael Beamonte <raphael.beamonte@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1441615087-13886-2-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/include/linux/err.h | 49 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 49 insertions(+)
create mode 100644 tools/include/linux/err.h
diff --git a/tools/include/linux/err.h b/tools/include/linux/err.h
new file mode 100644
index 000000000000..c9ada48f5156
--- /dev/null
+++ b/tools/include/linux/err.h
@@ -0,0 +1,49 @@
+#ifndef __TOOLS_LINUX_ERR_H
+#define __TOOLS_LINUX_ERR_H
+
+#include <linux/compiler.h>
+#include <linux/types.h>
+
+#include <asm/errno.h>
+
+/*
+ * Original kernel header comment:
+ *
+ * Kernel pointers have redundant information, so we can use a
+ * scheme where we can return either an error code or a normal
+ * pointer with the same return value.
+ *
+ * This should be a per-architecture thing, to allow different
+ * error and pointer decisions.
+ *
+ * Userspace note:
+ * The same principle works for userspace, because 'error' pointers
+ * fall down to the unused hole far from user space, as described
+ * in Documentation/x86/x86_64/mm.txt for x86_64 arch:
+ *
+ * 0000000000000000 - 00007fffffffffff (=47 bits) user space, different per mm hole caused by [48:63] sign extension
+ * ffffffffffe00000 - ffffffffffffffff (=2 MB) unused hole
+ *
+ * It should be the same case for other architectures, because
+ * this code is used in generic kernel code.
+ */
+#define MAX_ERRNO 4095
+
+#define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
+
+static inline void * __must_check ERR_PTR(long error)
+{
+ return (void *) error;
+}
+
+static inline long __must_check PTR_ERR(__force const void *ptr)
+{
+ return (long) ptr;
+}
+
+static inline bool __must_check IS_ERR(__force const void *ptr)
+{
+ return IS_ERR_VALUE((unsigned long)ptr);
+}
+
+#endif /* _LINUX_ERR_H */
--
2.1.0
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 4/8] perf tools: Propagate error info for the tracepoint parsing
2015-09-15 15:28 [GIT PULL 0/8] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (2 preceding siblings ...)
2015-09-15 15:28 ` [PATCH 3/8] tools: Add err.h with ERR_PTR PTR_ERR interface Arnaldo Carvalho de Melo
@ 2015-09-15 15:28 ` Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 5/8] perf evsel: Propagate error info from tp_format Arnaldo Carvalho de Melo
` (4 subsequent siblings)
8 siblings, 0 replies; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-15 15:28 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Jiri Olsa, David Ahern, Namhyung Kim,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Jiri Olsa <jolsa@kernel.org>
Pass 'struct parse_events_error *error' to the parse-event.c tracepoint
adding path. It will be filled with error data in following patches.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Reviewed-by: Raphael Beamonte <raphael.beamonte@gmail.com>
Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1441615087-13886-4-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/parse-events.c | 27 ++++++++++++++++-----------
tools/perf/util/parse-events.h | 3 ++-
tools/perf/util/parse-events.y | 4 ++--
3 files changed, 20 insertions(+), 14 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 3840176642f8..1b284b8ad243 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -387,7 +387,8 @@ int parse_events_add_cache(struct list_head *list, int *idx,
}
static int add_tracepoint(struct list_head *list, int *idx,
- char *sys_name, char *evt_name)
+ char *sys_name, char *evt_name,
+ struct parse_events_error *error __maybe_unused)
{
struct perf_evsel *evsel;
@@ -401,7 +402,8 @@ static int add_tracepoint(struct list_head *list, int *idx,
}
static int add_tracepoint_multi_event(struct list_head *list, int *idx,
- char *sys_name, char *evt_name)
+ char *sys_name, char *evt_name,
+ struct parse_events_error *error)
{
char evt_path[MAXPATHLEN];
struct dirent *evt_ent;
@@ -425,7 +427,7 @@ static int add_tracepoint_multi_event(struct list_head *list, int *idx,
if (!strglobmatch(evt_ent->d_name, evt_name))
continue;
- ret = add_tracepoint(list, idx, sys_name, evt_ent->d_name);
+ ret = add_tracepoint(list, idx, sys_name, evt_ent->d_name, error);
}
closedir(evt_dir);
@@ -433,15 +435,17 @@ static int add_tracepoint_multi_event(struct list_head *list, int *idx,
}
static int add_tracepoint_event(struct list_head *list, int *idx,
- char *sys_name, char *evt_name)
+ char *sys_name, char *evt_name,
+ struct parse_events_error *error)
{
return strpbrk(evt_name, "*?") ?
- add_tracepoint_multi_event(list, idx, sys_name, evt_name) :
- add_tracepoint(list, idx, sys_name, evt_name);
+ add_tracepoint_multi_event(list, idx, sys_name, evt_name, error) :
+ add_tracepoint(list, idx, sys_name, evt_name, error);
}
static int add_tracepoint_multi_sys(struct list_head *list, int *idx,
- char *sys_name, char *evt_name)
+ char *sys_name, char *evt_name,
+ struct parse_events_error *error)
{
struct dirent *events_ent;
DIR *events_dir;
@@ -465,7 +469,7 @@ static int add_tracepoint_multi_sys(struct list_head *list, int *idx,
continue;
ret = add_tracepoint_event(list, idx, events_ent->d_name,
- evt_name);
+ evt_name, error);
}
closedir(events_dir);
@@ -473,12 +477,13 @@ static int add_tracepoint_multi_sys(struct list_head *list, int *idx,
}
int parse_events_add_tracepoint(struct list_head *list, int *idx,
- char *sys, char *event)
+ char *sys, char *event,
+ struct parse_events_error *error)
{
if (strpbrk(sys, "*?"))
- return add_tracepoint_multi_sys(list, idx, sys, event);
+ return add_tracepoint_multi_sys(list, idx, sys, event, error);
else
- return add_tracepoint_event(list, idx, sys, event);
+ return add_tracepoint_event(list, idx, sys, event, error);
}
static int
diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h
index a09b0e210997..ffee7ece75a6 100644
--- a/tools/perf/util/parse-events.h
+++ b/tools/perf/util/parse-events.h
@@ -118,7 +118,8 @@ int parse_events__modifier_event(struct list_head *list, char *str, bool add);
int parse_events__modifier_group(struct list_head *list, char *event_mod);
int parse_events_name(struct list_head *list, char *name);
int parse_events_add_tracepoint(struct list_head *list, int *idx,
- char *sys, char *event);
+ char *sys, char *event,
+ struct parse_events_error *error);
int parse_events_add_numeric(struct parse_events_evlist *data,
struct list_head *list,
u32 type, u64 config,
diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
index 9cd70819c795..54a3004a8192 100644
--- a/tools/perf/util/parse-events.y
+++ b/tools/perf/util/parse-events.y
@@ -376,7 +376,7 @@ PE_NAME '-' PE_NAME ':' PE_NAME
snprintf(&sys_name, 128, "%s-%s", $1, $3);
ALLOC_LIST(list);
- ABORT_ON(parse_events_add_tracepoint(list, &data->idx, &sys_name, $5));
+ ABORT_ON(parse_events_add_tracepoint(list, &data->idx, &sys_name, $5, data->error));
$$ = list;
}
|
@@ -386,7 +386,7 @@ PE_NAME ':' PE_NAME
struct list_head *list;
ALLOC_LIST(list);
- if (parse_events_add_tracepoint(list, &data->idx, $1, $3)) {
+ if (parse_events_add_tracepoint(list, &data->idx, $1, $3, data->error)) {
struct parse_events_error *error = data->error;
if (error) {
--
2.1.0
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 5/8] perf evsel: Propagate error info from tp_format
2015-09-15 15:28 [GIT PULL 0/8] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (3 preceding siblings ...)
2015-09-15 15:28 ` [PATCH 4/8] perf tools: Propagate error info for the tracepoint parsing Arnaldo Carvalho de Melo
@ 2015-09-15 15:28 ` Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 6/8] perf tools: Enhance parsing events tracepoint error output Arnaldo Carvalho de Melo
` (3 subsequent siblings)
8 siblings, 0 replies; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-15 15:28 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Jiri Olsa, David Ahern, Matt Fleming, Namhyung Kim,
Peter Zijlstra, Raphael Beamonte, Arnaldo Carvalho de Melo
From: Jiri Olsa <jolsa@kernel.org>
Propagate error info from tp_format via ERR_PTR to get it all the way
down to the parse-event.c tracepoint adding routines. Following
functions now return pointer with encoded error:
- tp_format
- trace_event__tp_format
- perf_evsel__newtp_idx
- perf_evsel__newtp
This affects several other places in perf, that cannot use pointer check
anymore, but must utilize the err.h interface, when getting error
information from above functions list.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Raphael Beamonte <raphael.beamonte@gmail.com>
Link: http://lkml.kernel.org/r/1441615087-13886-5-git-send-email-jolsa@kernel.org
[ Add two missing ERR_PTR() and one IS_ERR() ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-trace.c | 19 +++++++++++--------
tools/perf/tests/evsel-tp-sched.c | 10 ++++++++--
tools/perf/tests/mmap-basic.c | 3 ++-
tools/perf/tests/openat-syscall-all-cpus.c | 3 ++-
tools/perf/tests/openat-syscall-tp-fields.c | 3 ++-
tools/perf/tests/openat-syscall.c | 3 ++-
tools/perf/util/evlist.c | 3 ++-
tools/perf/util/evsel.c | 16 +++++++++++++---
tools/perf/util/evsel.h | 3 +++
tools/perf/util/parse-events.c | 6 +++---
tools/perf/util/trace-event.c | 15 ++++++++++++---
11 files changed, 60 insertions(+), 24 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 215653274102..93b80f12f35e 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -38,6 +38,7 @@
#include <stdlib.h>
#include <sys/mman.h>
#include <linux/futex.h>
+#include <linux/err.h>
/* For older distros: */
#ifndef MAP_STACK
@@ -245,13 +246,14 @@ static struct perf_evsel *perf_evsel__syscall_newtp(const char *direction, void
struct perf_evsel *evsel = perf_evsel__newtp("raw_syscalls", direction);
/* older kernel (e.g., RHEL6) use syscalls:{enter,exit} */
- if (evsel == NULL)
+ if (IS_ERR(evsel))
evsel = perf_evsel__newtp("syscalls", direction);
- if (evsel) {
- if (perf_evsel__init_syscall_tp(evsel, handler))
- goto out_delete;
- }
+ if (IS_ERR(evsel))
+ return NULL;
+
+ if (perf_evsel__init_syscall_tp(evsel, handler))
+ goto out_delete;
return evsel;
@@ -1705,12 +1707,12 @@ static int trace__read_syscall_info(struct trace *trace, int id)
snprintf(tp_name, sizeof(tp_name), "sys_enter_%s", sc->name);
sc->tp_format = trace_event__tp_format("syscalls", tp_name);
- if (sc->tp_format == NULL && sc->fmt && sc->fmt->alias) {
+ if (IS_ERR(sc->tp_format) && sc->fmt && sc->fmt->alias) {
snprintf(tp_name, sizeof(tp_name), "sys_enter_%s", sc->fmt->alias);
sc->tp_format = trace_event__tp_format("syscalls", tp_name);
}
- if (sc->tp_format == NULL)
+ if (IS_ERR(sc->tp_format))
return -1;
sc->args = sc->tp_format->format.fields;
@@ -2390,7 +2392,8 @@ static size_t trace__fprintf_thread_summary(struct trace *trace, FILE *fp);
static bool perf_evlist__add_vfs_getname(struct perf_evlist *evlist)
{
struct perf_evsel *evsel = perf_evsel__newtp("probe", "vfs_getname");
- if (evsel == NULL)
+
+ if (IS_ERR(evsel))
return false;
if (perf_evsel__field(evsel, "pathname") == NULL) {
diff --git a/tools/perf/tests/evsel-tp-sched.c b/tools/perf/tests/evsel-tp-sched.c
index 52162425c969..790e413d9a1f 100644
--- a/tools/perf/tests/evsel-tp-sched.c
+++ b/tools/perf/tests/evsel-tp-sched.c
@@ -1,3 +1,4 @@
+#include <linux/err.h>
#include <traceevent/event-parse.h>
#include "evsel.h"
#include "tests.h"
@@ -36,8 +37,8 @@ int test__perf_evsel__tp_sched_test(void)
struct perf_evsel *evsel = perf_evsel__newtp("sched", "sched_switch");
int ret = 0;
- if (evsel == NULL) {
- pr_debug("perf_evsel__new\n");
+ if (IS_ERR(evsel)) {
+ pr_debug("perf_evsel__newtp failed with %ld\n", PTR_ERR(evsel));
return -1;
}
@@ -66,6 +67,11 @@ int test__perf_evsel__tp_sched_test(void)
evsel = perf_evsel__newtp("sched", "sched_wakeup");
+ if (IS_ERR(evsel)) {
+ pr_debug("perf_evsel__newtp failed with %ld\n", PTR_ERR(evsel));
+ return -1;
+ }
+
if (perf_evsel__test_field(evsel, "comm", 16, true))
ret = -1;
diff --git a/tools/perf/tests/mmap-basic.c b/tools/perf/tests/mmap-basic.c
index 666b67a4df9d..4495493c9431 100644
--- a/tools/perf/tests/mmap-basic.c
+++ b/tools/perf/tests/mmap-basic.c
@@ -3,6 +3,7 @@
#include "thread_map.h"
#include "cpumap.h"
#include "tests.h"
+#include <linux/err.h>
/*
* This test will generate random numbers of calls to some getpid syscalls,
@@ -65,7 +66,7 @@ int test__basic_mmap(void)
snprintf(name, sizeof(name), "sys_enter_%s", syscall_names[i]);
evsels[i] = perf_evsel__newtp("syscalls", name);
- if (evsels[i] == NULL) {
+ if (IS_ERR(evsels[i])) {
pr_debug("perf_evsel__new\n");
goto out_delete_evlist;
}
diff --git a/tools/perf/tests/openat-syscall-all-cpus.c b/tools/perf/tests/openat-syscall-all-cpus.c
index 495d8126b722..9e104a2e973d 100644
--- a/tools/perf/tests/openat-syscall-all-cpus.c
+++ b/tools/perf/tests/openat-syscall-all-cpus.c
@@ -1,4 +1,5 @@
#include <api/fs/fs.h>
+#include <linux/err.h>
#include "evsel.h"
#include "tests.h"
#include "thread_map.h"
@@ -31,7 +32,7 @@ int test__openat_syscall_event_on_all_cpus(void)
CPU_ZERO(&cpu_set);
evsel = perf_evsel__newtp("syscalls", "sys_enter_openat");
- if (evsel == NULL) {
+ if (IS_ERR(evsel)) {
tracing_path__strerror_open_tp(errno, errbuf, sizeof(errbuf), "syscalls", "sys_enter_openat");
pr_err("%s\n", errbuf);
goto out_thread_map_delete;
diff --git a/tools/perf/tests/openat-syscall-tp-fields.c b/tools/perf/tests/openat-syscall-tp-fields.c
index 01a19626c846..473d3869727e 100644
--- a/tools/perf/tests/openat-syscall-tp-fields.c
+++ b/tools/perf/tests/openat-syscall-tp-fields.c
@@ -1,3 +1,4 @@
+#include <linux/err.h>
#include "perf.h"
#include "evlist.h"
#include "evsel.h"
@@ -30,7 +31,7 @@ int test__syscall_openat_tp_fields(void)
}
evsel = perf_evsel__newtp("syscalls", "sys_enter_openat");
- if (evsel == NULL) {
+ if (IS_ERR(evsel)) {
pr_debug("%s: perf_evsel__newtp\n", __func__);
goto out_delete_evlist;
}
diff --git a/tools/perf/tests/openat-syscall.c b/tools/perf/tests/openat-syscall.c
index 08ac9d94a050..7b1db8306098 100644
--- a/tools/perf/tests/openat-syscall.c
+++ b/tools/perf/tests/openat-syscall.c
@@ -1,4 +1,5 @@
#include <api/fs/tracing_path.h>
+#include <linux/err.h>
#include "thread_map.h"
#include "evsel.h"
#include "debug.h"
@@ -19,7 +20,7 @@ int test__openat_syscall_event(void)
}
evsel = perf_evsel__newtp("syscalls", "sys_enter_openat");
- if (evsel == NULL) {
+ if (IS_ERR(evsel)) {
tracing_path__strerror_open_tp(errno, errbuf, sizeof(errbuf), "syscalls", "sys_enter_openat");
pr_err("%s\n", errbuf);
goto out_thread_map_delete;
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index d51a5200c8af..3cb2bf9bd4bd 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -25,6 +25,7 @@
#include <linux/bitops.h>
#include <linux/hash.h>
#include <linux/log2.h>
+#include <linux/err.h>
static void perf_evlist__mmap_put(struct perf_evlist *evlist, int idx);
static void __perf_evlist__munmap(struct perf_evlist *evlist, int idx);
@@ -265,7 +266,7 @@ int perf_evlist__add_newtp(struct perf_evlist *evlist,
{
struct perf_evsel *evsel = perf_evsel__newtp(sys, name);
- if (evsel == NULL)
+ if (IS_ERR(evsel))
return -1;
evsel->handler = handler;
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 771ade4d5966..6b5d1b509148 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -13,6 +13,7 @@
#include <traceevent/event-parse.h>
#include <linux/hw_breakpoint.h>
#include <linux/perf_event.h>
+#include <linux/err.h>
#include <sys/resource.h>
#include "asm/bug.h"
#include "callchain.h"
@@ -225,11 +226,17 @@ struct perf_evsel *perf_evsel__new_idx(struct perf_event_attr *attr, int idx)
return evsel;
}
+/*
+ * Returns pointer with encoded error via <linux/err.h> interface.
+ */
struct perf_evsel *perf_evsel__newtp_idx(const char *sys, const char *name, int idx)
{
struct perf_evsel *evsel = zalloc(perf_evsel__object.size);
+ int err = -ENOMEM;
- if (evsel != NULL) {
+ if (evsel == NULL) {
+ goto out_err;
+ } else {
struct perf_event_attr attr = {
.type = PERF_TYPE_TRACEPOINT,
.sample_type = (PERF_SAMPLE_RAW | PERF_SAMPLE_TIME |
@@ -240,8 +247,10 @@ struct perf_evsel *perf_evsel__newtp_idx(const char *sys, const char *name, int
goto out_free;
evsel->tp_format = trace_event__tp_format(sys, name);
- if (evsel->tp_format == NULL)
+ if (IS_ERR(evsel->tp_format)) {
+ err = PTR_ERR(evsel->tp_format);
goto out_free;
+ }
event_attr_init(&attr);
attr.config = evsel->tp_format->id;
@@ -254,7 +263,8 @@ struct perf_evsel *perf_evsel__newtp_idx(const char *sys, const char *name, int
out_free:
zfree(&evsel->name);
free(evsel);
- return NULL;
+out_err:
+ return ERR_PTR(err);
}
const char *perf_evsel__hw_names[PERF_COUNT_HW_MAX] = {
diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
index f164a149da82..62ab307b7306 100644
--- a/tools/perf/util/evsel.h
+++ b/tools/perf/util/evsel.h
@@ -160,6 +160,9 @@ static inline struct perf_evsel *perf_evsel__new(struct perf_event_attr *attr)
struct perf_evsel *perf_evsel__newtp_idx(const char *sys, const char *name, int idx);
+/*
+ * Returns pointer with encoded error via <linux/err.h> interface.
+ */
static inline struct perf_evsel *perf_evsel__newtp(const char *sys, const char *name)
{
return perf_evsel__newtp_idx(sys, name, 0);
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 1b284b8ad243..c47831c47220 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -1,4 +1,5 @@
#include <linux/hw_breakpoint.h>
+#include <linux/err.h>
#include "util.h"
#include "../perf.h"
#include "evlist.h"
@@ -393,11 +394,10 @@ static int add_tracepoint(struct list_head *list, int *idx,
struct perf_evsel *evsel;
evsel = perf_evsel__newtp_idx(sys_name, evt_name, (*idx)++);
- if (!evsel)
- return -ENOMEM;
+ if (IS_ERR(evsel))
+ return PTR_ERR(evsel);
list_add_tail(&evsel->node, list);
-
return 0;
}
diff --git a/tools/perf/util/trace-event.c b/tools/perf/util/trace-event.c
index 2f4996ab313d..802bb868d446 100644
--- a/tools/perf/util/trace-event.c
+++ b/tools/perf/util/trace-event.c
@@ -7,6 +7,7 @@
#include <sys/stat.h>
#include <fcntl.h>
#include <linux/kernel.h>
+#include <linux/err.h>
#include <traceevent/event-parse.h>
#include <api/fs/tracing_path.h>
#include "trace-event.h"
@@ -66,6 +67,9 @@ void trace_event__cleanup(struct trace_event *t)
pevent_free(t->pevent);
}
+/*
+ * Returns pointer with encoded error via <linux/err.h> interface.
+ */
static struct event_format*
tp_format(const char *sys, const char *name)
{
@@ -74,12 +78,14 @@ tp_format(const char *sys, const char *name)
char path[PATH_MAX];
size_t size;
char *data;
+ int err;
scnprintf(path, PATH_MAX, "%s/%s/%s/format",
tracing_events_path, sys, name);
- if (filename__read_str(path, &data, &size))
- return NULL;
+ err = filename__read_str(path, &data, &size);
+ if (err)
+ return ERR_PTR(err);
pevent_parse_format(pevent, &event, data, size, sys);
@@ -87,11 +93,14 @@ tp_format(const char *sys, const char *name)
return event;
}
+/*
+ * Returns pointer with encoded error via <linux/err.h> interface.
+ */
struct event_format*
trace_event__tp_format(const char *sys, const char *name)
{
if (!tevent_initialized && trace_event__init2())
- return NULL;
+ return ERR_PTR(-ENOMEM);
return tp_format(sys, name);
}
--
2.1.0
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 6/8] perf tools: Enhance parsing events tracepoint error output
2015-09-15 15:28 [GIT PULL 0/8] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (4 preceding siblings ...)
2015-09-15 15:28 ` [PATCH 5/8] perf evsel: Propagate error info from tp_format Arnaldo Carvalho de Melo
@ 2015-09-15 15:28 ` Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 7/8] perf tools: regs_query_register_offset() infrastructure Arnaldo Carvalho de Melo
` (2 subsequent siblings)
8 siblings, 0 replies; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-15 15:28 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Jiri Olsa, Raphael Beamonte, David Ahern,
Matt Fleming, Namhyung Kim, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Jiri Olsa <jolsa@kernel.org>
Enhancing parsing events tracepoint error output. Adding
more verbose output when the tracepoint is not found or
the tracing event path cannot be access.
$ sudo perf record -e sched:sched_krava ls
event syntax error: 'sched:sched_krava'
\___ unknown tracepoint
Error: File /sys/kernel/debug/tracing//tracing/events/sched/sched_krava not found.
Hint: Perhaps this kernel misses some CONFIG_ setting to enable this feature?.
Run 'perf list' for a list of valid events
...
$ perf record -e sched:sched_krava ls
event syntax error: 'sched:sched_krava'
\___ can't access trace events
Error: No permissions to read /sys/kernel/debug/tracing//tracing/events/sched/sched_krava
Hint: Try 'sudo mount -o remount,mode=755 /sys/kernel/debug'
Run 'perf list' for a list of valid events
...
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Raphael Beamonte <raphael.beamonte@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1441615087-13886-6-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/parse-events.c | 35 ++++++++++++++++++++++++++++++++---
tools/perf/util/parse-events.y | 16 +++++++++-------
2 files changed, 41 insertions(+), 10 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index c47831c47220..d3fb90be6216 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -387,6 +387,33 @@ int parse_events_add_cache(struct list_head *list, int *idx,
return add_event(list, idx, &attr, name, NULL);
}
+static void tracepoint_error(struct parse_events_error *error, int err,
+ char *sys, char *name)
+{
+ char help[BUFSIZ];
+
+ /*
+ * We get error directly from syscall errno ( > 0),
+ * or from encoded pointer's error ( < 0).
+ */
+ err = abs(err);
+
+ switch (err) {
+ case EACCES:
+ error->str = strdup("can't access trace events");
+ break;
+ case ENOENT:
+ error->str = strdup("unknown tracepoint");
+ break;
+ default:
+ error->str = strdup("failed to add tracepoint");
+ break;
+ }
+
+ tracing_path__strerror_open_tp(err, help, sizeof(help), sys, name);
+ error->help = strdup(help);
+}
+
static int add_tracepoint(struct list_head *list, int *idx,
char *sys_name, char *evt_name,
struct parse_events_error *error __maybe_unused)
@@ -394,8 +421,10 @@ static int add_tracepoint(struct list_head *list, int *idx,
struct perf_evsel *evsel;
evsel = perf_evsel__newtp_idx(sys_name, evt_name, (*idx)++);
- if (IS_ERR(evsel))
+ if (IS_ERR(evsel)) {
+ tracepoint_error(error, PTR_ERR(evsel), sys_name, evt_name);
return PTR_ERR(evsel);
+ }
list_add_tail(&evsel->node, list);
return 0;
@@ -413,7 +442,7 @@ static int add_tracepoint_multi_event(struct list_head *list, int *idx,
snprintf(evt_path, MAXPATHLEN, "%s/%s", tracing_events_path, sys_name);
evt_dir = opendir(evt_path);
if (!evt_dir) {
- perror("Can't open event dir");
+ tracepoint_error(error, errno, sys_name, evt_name);
return -1;
}
@@ -453,7 +482,7 @@ static int add_tracepoint_multi_sys(struct list_head *list, int *idx,
events_dir = opendir(tracing_events_path);
if (!events_dir) {
- perror("Can't open event dir");
+ tracepoint_error(error, errno, sys_name, evt_name);
return -1;
}
diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
index 54a3004a8192..8bcc45868457 100644
--- a/tools/perf/util/parse-events.y
+++ b/tools/perf/util/parse-events.y
@@ -371,28 +371,30 @@ event_legacy_tracepoint:
PE_NAME '-' PE_NAME ':' PE_NAME
{
struct parse_events_evlist *data = _data;
+ struct parse_events_error *error = data->error;
struct list_head *list;
char sys_name[128];
snprintf(&sys_name, 128, "%s-%s", $1, $3);
ALLOC_LIST(list);
- ABORT_ON(parse_events_add_tracepoint(list, &data->idx, &sys_name, $5, data->error));
+ if (parse_events_add_tracepoint(list, &data->idx, &sys_name, $5, error)) {
+ if (error)
+ error->idx = @1.first_column;
+ return -1;
+ }
$$ = list;
}
|
PE_NAME ':' PE_NAME
{
struct parse_events_evlist *data = _data;
+ struct parse_events_error *error = data->error;
struct list_head *list;
ALLOC_LIST(list);
- if (parse_events_add_tracepoint(list, &data->idx, $1, $3, data->error)) {
- struct parse_events_error *error = data->error;
-
- if (error) {
+ if (parse_events_add_tracepoint(list, &data->idx, $1, $3, error)) {
+ if (error)
error->idx = @1.first_column;
- error->str = strdup("unknown tracepoint");
- }
return -1;
}
$$ = list;
--
2.1.0
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 7/8] perf tools: regs_query_register_offset() infrastructure
2015-09-15 15:28 [GIT PULL 0/8] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (5 preceding siblings ...)
2015-09-15 15:28 ` [PATCH 6/8] perf tools: Enhance parsing events tracepoint error output Arnaldo Carvalho de Melo
@ 2015-09-15 15:28 ` Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 8/8] perf tools: Introduce regs_query_register_offset() for x86 Arnaldo Carvalho de Melo
2015-09-16 7:25 ` [GIT PULL 0/8] perf/core improvements and fixes Ingo Molnar
8 siblings, 0 replies; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-15 15:28 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Wang Nan, Alexei Starovoitov, Brendan Gregg,
Daniel Borkmann, David Ahern, Jiri Olsa, Kaixu Xia, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Zefan Li, pi3orama, He Kuang,
Arnaldo Carvalho de Melo
From: Wang Nan <wangnan0@huawei.com>
regs_query_register_offset() is a helper function which converts
register name like "%rax" to offset of a register in 'struct pt_regs',
which is required by BPF prologue generator.
PERF_HAVE_ARCH_REGS_QUERY_REGISTER_OFFSET indicates an architecture
supports converting name of a register to its offset in 'struct
pt_regs'.
HAVE_ARCH_REGS_QUERY_REGISTER_OFFSET is introduced as the corresponding
CFLAGS of PERF_HAVE_ARCH_REGS_QUERY_REGISTER_OFFSET.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kaixu Xia <xiakaixu@huawei.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1441523623-152703-19-git-send-email-wangnan0@huawei.com
Signed-off-by: He Kuang <hekuang@huawei.com>
[ Extracted from eBPF patches ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/config/Makefile | 4 ++++
tools/perf/util/include/dwarf-regs.h | 8 ++++++++
2 files changed, 12 insertions(+)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 827557fc7511..0435ac41cea9 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -109,6 +109,10 @@ endif
# include ARCH specific config
-include $(src-perf)/arch/$(ARCH)/Makefile
+ifdef PERF_HAVE_ARCH_REGS_QUERY_REGISTER_OFFSET
+ CFLAGS += -DHAVE_ARCH_REGS_QUERY_REGISTER_OFFSET
+endif
+
include $(src-perf)/config/utilities.mak
ifeq ($(call get-executable,$(FLEX)),)
diff --git a/tools/perf/util/include/dwarf-regs.h b/tools/perf/util/include/dwarf-regs.h
index 8f149655f497..07c644ed64c4 100644
--- a/tools/perf/util/include/dwarf-regs.h
+++ b/tools/perf/util/include/dwarf-regs.h
@@ -5,4 +5,12 @@
const char *get_arch_regstr(unsigned int n);
#endif
+#ifdef HAVE_ARCH_REGS_QUERY_REGISTER_OFFSET
+/*
+ * Arch should support fetching the offset of a register in pt_regs
+ * by its name. See kernel's regs_query_register_offset in
+ * arch/xxx/kernel/ptrace.c.
+ */
+int regs_query_register_offset(const char *name);
+#endif
#endif
--
2.1.0
^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 8/8] perf tools: Introduce regs_query_register_offset() for x86
2015-09-15 15:28 [GIT PULL 0/8] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (6 preceding siblings ...)
2015-09-15 15:28 ` [PATCH 7/8] perf tools: regs_query_register_offset() infrastructure Arnaldo Carvalho de Melo
@ 2015-09-15 15:28 ` Arnaldo Carvalho de Melo
2015-09-16 7:25 ` [GIT PULL 0/8] perf/core improvements and fixes Ingo Molnar
8 siblings, 0 replies; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-15 15:28 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Wang Nan, He Kuang, Alexei Starovoitov,
Brendan Gregg, Daniel Borkmann, David Ahern, Jiri Olsa,
Kaixu Xia, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Zefan Li, pi3orama, Arnaldo Carvalho de Melo
From: Wang Nan <wangnan0@huawei.com>
regs_query_register_offset() is a helper function which converts
register name like "%rax" to offset of a register in 'struct pt_regs',
which is required by BPF prologue generator. Since the function is
identical, try to reuse the code in arch/x86/kernel/ptrace.c.
Comment inside dwarf-regs.c list the differences between this
implementation and kernel code.
get_arch_regstr() switches to regoffset_table and the old string table
is dropped.
Signed-off-by: He Kuang <hekuang@huawei.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: David Ahern <dsahern@gmail.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kaixu Xia <xiakaixu@huawei.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1441523623-152703-20-git-send-email-wangnan0@huawei.com
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/arch/x86/Makefile | 1 +
tools/perf/arch/x86/util/dwarf-regs.c | 122 ++++++++++++++++++++++++----------
2 files changed, 89 insertions(+), 34 deletions(-)
diff --git a/tools/perf/arch/x86/Makefile b/tools/perf/arch/x86/Makefile
index 21322e0385b8..09ba923debe8 100644
--- a/tools/perf/arch/x86/Makefile
+++ b/tools/perf/arch/x86/Makefile
@@ -2,3 +2,4 @@ ifndef NO_DWARF
PERF_HAVE_DWARF_REGS := 1
endif
HAVE_KVM_STAT_SUPPORT := 1
+PERF_HAVE_ARCH_REGS_QUERY_REGISTER_OFFSET := 1
diff --git a/tools/perf/arch/x86/util/dwarf-regs.c b/tools/perf/arch/x86/util/dwarf-regs.c
index a08de0a35b83..9223c164e545 100644
--- a/tools/perf/arch/x86/util/dwarf-regs.c
+++ b/tools/perf/arch/x86/util/dwarf-regs.c
@@ -21,55 +21,109 @@
*/
#include <stddef.h>
+#include <errno.h> /* for EINVAL */
+#include <string.h> /* for strcmp */
+#include <linux/ptrace.h> /* for struct pt_regs */
+#include <linux/kernel.h> /* for offsetof */
#include <dwarf-regs.h>
/*
- * Generic dwarf analysis helpers
+ * See arch/x86/kernel/ptrace.c.
+ * Different from it:
+ *
+ * - Since struct pt_regs is defined differently for user and kernel,
+ * but we want to use 'ax, bx' instead of 'rax, rbx' (which is struct
+ * field name of user's pt_regs), we make REG_OFFSET_NAME to accept
+ * both string name and reg field name.
+ *
+ * - Since accessing x86_32's pt_regs from x86_64 building is difficult
+ * and vise versa, we simply fill offset with -1, so
+ * get_arch_regstr() still works but regs_query_register_offset()
+ * returns error.
+ * The only inconvenience caused by it now is that we are not allowed
+ * to generate BPF prologue for a x86_64 kernel if perf is built for
+ * x86_32. This is really a rare usecase.
+ *
+ * - Order is different from kernel's ptrace.c for get_arch_regstr(). Use
+ * the order defined by dwarf.
*/
-#define X86_32_MAX_REGS 8
-const char *x86_32_regs_table[X86_32_MAX_REGS] = {
- "%ax",
- "%cx",
- "%dx",
- "%bx",
- "$stack", /* Stack address instead of %sp */
- "%bp",
- "%si",
- "%di",
+struct pt_regs_offset {
+ const char *name;
+ int offset;
+};
+
+#define REG_OFFSET_END {.name = NULL, .offset = 0}
+
+#ifdef __x86_64__
+# define REG_OFFSET_NAME_64(n, r) {.name = n, .offset = offsetof(struct pt_regs, r)}
+# define REG_OFFSET_NAME_32(n, r) {.name = n, .offset = -1}
+#else
+# define REG_OFFSET_NAME_64(n, r) {.name = n, .offset = -1}
+# define REG_OFFSET_NAME_32(n, r) {.name = n, .offset = offsetof(struct pt_regs, r)}
+#endif
+
+static const struct pt_regs_offset x86_32_regoffset_table[] = {
+ REG_OFFSET_NAME_32("%ax", eax),
+ REG_OFFSET_NAME_32("%cx", ecx),
+ REG_OFFSET_NAME_32("%dx", edx),
+ REG_OFFSET_NAME_32("%bx", ebx),
+ REG_OFFSET_NAME_32("$stack", esp), /* Stack address instead of %sp */
+ REG_OFFSET_NAME_32("%bp", ebp),
+ REG_OFFSET_NAME_32("%si", esi),
+ REG_OFFSET_NAME_32("%di", edi),
+ REG_OFFSET_END,
};
-#define X86_64_MAX_REGS 16
-const char *x86_64_regs_table[X86_64_MAX_REGS] = {
- "%ax",
- "%dx",
- "%cx",
- "%bx",
- "%si",
- "%di",
- "%bp",
- "%sp",
- "%r8",
- "%r9",
- "%r10",
- "%r11",
- "%r12",
- "%r13",
- "%r14",
- "%r15",
+static const struct pt_regs_offset x86_64_regoffset_table[] = {
+ REG_OFFSET_NAME_64("%ax", rax),
+ REG_OFFSET_NAME_64("%dx", rdx),
+ REG_OFFSET_NAME_64("%cx", rcx),
+ REG_OFFSET_NAME_64("%bx", rbx),
+ REG_OFFSET_NAME_64("%si", rsi),
+ REG_OFFSET_NAME_64("%di", rdi),
+ REG_OFFSET_NAME_64("%bp", rbp),
+ REG_OFFSET_NAME_64("%sp", rsp),
+ REG_OFFSET_NAME_64("%r8", r8),
+ REG_OFFSET_NAME_64("%r9", r9),
+ REG_OFFSET_NAME_64("%r10", r10),
+ REG_OFFSET_NAME_64("%r11", r11),
+ REG_OFFSET_NAME_64("%r12", r12),
+ REG_OFFSET_NAME_64("%r13", r13),
+ REG_OFFSET_NAME_64("%r14", r14),
+ REG_OFFSET_NAME_64("%r15", r15),
+ REG_OFFSET_END,
};
/* TODO: switching by dwarf address size */
#ifdef __x86_64__
-#define ARCH_MAX_REGS X86_64_MAX_REGS
-#define arch_regs_table x86_64_regs_table
+#define regoffset_table x86_64_regoffset_table
#else
-#define ARCH_MAX_REGS X86_32_MAX_REGS
-#define arch_regs_table x86_32_regs_table
+#define regoffset_table x86_32_regoffset_table
#endif
+/* Minus 1 for the ending REG_OFFSET_END */
+#define ARCH_MAX_REGS ((sizeof(regoffset_table) / sizeof(regoffset_table[0])) - 1)
+
/* Return architecture dependent register string (for kprobe-tracer) */
const char *get_arch_regstr(unsigned int n)
{
- return (n < ARCH_MAX_REGS) ? arch_regs_table[n] : NULL;
+ return (n < ARCH_MAX_REGS) ? regoffset_table[n].name : NULL;
+}
+
+/* Reuse code from arch/x86/kernel/ptrace.c */
+/**
+ * regs_query_register_offset() - query register offset from its name
+ * @name: the name of a register
+ *
+ * regs_query_register_offset() returns the offset of a register in struct
+ * pt_regs from its name. If the name is invalid, this returns -EINVAL;
+ */
+int regs_query_register_offset(const char *name)
+{
+ const struct pt_regs_offset *roff;
+ for (roff = regoffset_table; roff->name != NULL; roff++)
+ if (!strcmp(roff->name, name))
+ return roff->offset;
+ return -EINVAL;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [GIT PULL 0/8] perf/core improvements and fixes
2015-09-15 15:28 [GIT PULL 0/8] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (7 preceding siblings ...)
2015-09-15 15:28 ` [PATCH 8/8] perf tools: Introduce regs_query_register_offset() for x86 Arnaldo Carvalho de Melo
@ 2015-09-16 7:25 ` Ingo Molnar
2015-09-16 13:50 ` Arnaldo Carvalho de Melo
8 siblings, 1 reply; 33+ messages in thread
From: Ingo Molnar @ 2015-09-16 7:25 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Alexei Starovoitov, Brendan Gregg, Daniel Borkmann,
David Ahern, He Kuang, Jiri Olsa, Kaixu Xia, Masami Hiramatsu,
Matt Fleming, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
pi3orama, Raphael Beamonte, Wang Nan, Zefan Li,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 9059b284caecb628fac826c2c5cc8ee85708eec1:
>
> Merge tag 'perf-core-for-mingo-2' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-09-15 08:50:59 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
So your perf/urgent bits now conflict with the latest perf/core, in
tools/perf/ui/browsers/hists.c. I have merged perf/urgent into perf/core - please
double check my resolution (d71b0ad8d309).
>
> for you to fetch changes up to bbbe6bf6037d77816c4a19aaf35f4cecf662b49a:
>
> perf tools: Introduce regs_query_register_offset() for x86 (2015-09-15 09:48:33 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Enhance the error reporting of tracepoint event parsing, e.g.:
>
> $ oldperf record -e sched:sched_switc usleep 1
> event syntax error: 'sched:sched_switc'
> \___ unknown tracepoint
> Run 'perf list' for a list of valid events
>
> Now we get the much nicer:
>
> $ perf record -e sched:sched_switc ls
> event syntax error: 'sched:sched_switc'
> \___ can't access trace events
>
> Error: No permissions to read /sys/kernel/debug/tracing/events/sched/sched_switc
> Hint: Try 'sudo mount -o remount,mode=755 /sys/kernel/debug'
>
> And after we have those mount point permissions fixed:
>
> $ perf record -e sched:sched_switc ls
> event syntax error: 'sched:sched_switc'
> \___ unknown tracepoint
>
> Error: File /sys/kernel/debug/tracing/events/sched/sched_switc not found.
> Hint: Perhaps this kernel misses some CONFIG_ setting to enable this feature?.
>
> Now its just a matter of using what git uses to suggest alternatives when we
> make a typo, i.e. that it is just an 'h' missing :-)
Nice changes!
Btw., wouldn't it be even better to allow partial matches? Not allowing
'sched:sched_switc' is unnecessarily pedantic IMHO.
For example 'perf list' allows partial matches as well. As long as the resulting
event is unique, we should allow partial matches. If it's not unique, we should
print the first 3 matching entries or so.
There's a real UI advantage as well: I could abbreviate the command line with:
-e sched_sw
instead of always being forced to type out the full tracepoint name.
(Programmatic tracepoint usage and portable scripts should naturally always spell
out the full event, to make sure new tracepoints don't cause overlaps - but ad-hoc
usage can do abbreviations just fine.)
> I.e. basically now the event parsing routing uses the strerror_open()
> routines introduced by and used in 'perf trace' work. (Jiri Olsa)
>
> Infrastructure:
>
> - Export init/exit_probe_symbol_maps() from 'perf probe' for use in eBPF
> (Namhyung Kim)
>
> - Free perf_probe_event in cleanup_perf_probe_events() (Namhyung Kim)
>
> - regs_query_register_offset() infrastructure + implementation for x86.
> First user will be the perf/eBPF code (Wang Nan)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Jiri Olsa (4):
> tools: Add err.h with ERR_PTR PTR_ERR interface
> perf tools: Propagate error info for the tracepoint parsing
> perf evsel: Propagate error info from tp_format
> perf tools: Enhance parsing events tracepoint error output
>
> Namhyung Kim (2):
> perf probe: Free perf_probe_event in cleanup_perf_probe_events()
> perf probe: Export init/exit_probe_symbol_maps()
>
> Wang Nan (2):
> perf tools: regs_query_register_offset() infrastructure
> perf tools: Introduce regs_query_register_offset() for x86
>
> tools/include/linux/err.h | 49 +++++++++++
> tools/perf/arch/x86/Makefile | 1 +
> tools/perf/arch/x86/util/dwarf-regs.c | 122 ++++++++++++++++++++--------
> tools/perf/builtin-probe.c | 5 ++
> tools/perf/builtin-trace.c | 19 +++--
> tools/perf/config/Makefile | 4 +
> tools/perf/tests/evsel-tp-sched.c | 10 ++-
> tools/perf/tests/mmap-basic.c | 3 +-
> tools/perf/tests/openat-syscall-all-cpus.c | 3 +-
> tools/perf/tests/openat-syscall-tp-fields.c | 3 +-
> tools/perf/tests/openat-syscall.c | 3 +-
> tools/perf/util/evlist.c | 3 +-
> tools/perf/util/evsel.c | 16 +++-
> tools/perf/util/evsel.h | 3 +
> tools/perf/util/include/dwarf-regs.h | 8 ++
> tools/perf/util/parse-events.c | 66 +++++++++++----
> tools/perf/util/parse-events.h | 3 +-
> tools/perf/util/parse-events.y | 16 ++--
> tools/perf/util/probe-event.c | 32 ++++----
> tools/perf/util/probe-event.h | 2 +
> tools/perf/util/trace-event.c | 15 +++-
> 21 files changed, 291 insertions(+), 95 deletions(-)
> create mode 100644 tools/include/linux/err.h
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL 0/8] perf/core improvements and fixes
2015-09-16 7:25 ` [GIT PULL 0/8] perf/core improvements and fixes Ingo Molnar
@ 2015-09-16 13:50 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-16 13:50 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Alexei Starovoitov, Brendan Gregg, Daniel Borkmann,
David Ahern, He Kuang, Jiri Olsa, Kaixu Xia, Masami Hiramatsu,
Matt Fleming, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
pi3orama, Raphael Beamonte, Wang Nan, Zefan Li
Em Wed, Sep 16, 2015 at 09:25:44AM +0200, Ingo Molnar escreveu:
>
> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> > Hi Ingo,
> >
> > Please consider pulling,
> >
> > - Arnaldo
> >
> > The following changes since commit 9059b284caecb628fac826c2c5cc8ee85708eec1:
> >
> > Merge tag 'perf-core-for-mingo-2' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-09-15 08:50:59 +0200)
> >
> > are available in the git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> So your perf/urgent bits now conflict with the latest perf/core, in
> tools/perf/ui/browsers/hists.c. I have merged perf/urgent into perf/core - please
> double check my resolution (d71b0ad8d309).
Looks fine, tested it even, thanks!
- Arnaldo
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL 0/8] perf/core improvements and fixes
2018-03-28 18:49 Arnaldo Carvalho de Melo
@ 2018-03-29 7:23 ` Ingo Molnar
0 siblings, 0 replies; 33+ messages in thread
From: Ingo Molnar @ 2018-03-29 7:23 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, linux-perf-users, Adrian Hunter,
Alexander Shishkin, David Ahern, Heiko Carstens,
Hendrik Brueckner, Jiri Olsa, Kan Liang, Martin Schwidefsky,
Namhyung Kim, Peter Zijlstra, Thomas Richter, Wang Nan,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 631fe154edb0a37308d0116a0f9b7bba9dca6218:
>
> perf/x86: Update rdpmc_always_available static key to the modern API (2018-03-27 07:53:00 +0200)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.17-20180328
>
> for you to fetch changes up to 109d59b900e78834c66657dd4748fcedb9a1fe8d:
>
> perf vendor events s390: Add JSON files for IBM z14 (2018-03-27 13:13:39 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> - Be consistent when checking if a perf_mmap instance had
> its ring buffer unmmaped, fixing segfaults noticed in
> 'perf trace' (Kan Liang, Arnaldo Carvalho de Melo)
>
> - Avoid adding the same option multiple times to the 'diff'
> command in check-headers.sh (Jiri Olsa)
>
> - Add vendor event files (JSON format) to various IBM
> s390 models (z10EC, z10BC, z196, zEC12, zBC12, z13
> and z14) (Thomas Richter)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf mmap: Be consistent when checking for an unmaped ring buffer
>
> Jiri Olsa (1):
> perf build: Fix check-headers.sh opts assignment
>
> Kan Liang (1):
> perf mmap: Fix accessing unmapped mmap in perf_mmap__read_done()
>
> Thomas Richter (5):
> perf vendor events s390: Add JSON files for IBM z10EC z10BC
> perf vendor events s390: Add JSON files for IBM z196
> perf vendor events s390: Add JSON files for IBM zEC12 zBC12
> perf vendor events s390: Add JSON files for IBM z13
> perf vendor events s390: Add JSON files for IBM z14
>
> tools/perf/check-headers.sh | 1 +
> tools/perf/pmu-events/arch/s390/cf_z10/basic.json | 74 +++++
> tools/perf/pmu-events/arch/s390/cf_z10/crypto.json | 98 ++++++
> .../perf/pmu-events/arch/s390/cf_z10/extended.json | 110 +++++++
> tools/perf/pmu-events/arch/s390/cf_z13/basic.json | 74 +++++
> tools/perf/pmu-events/arch/s390/cf_z13/crypto.json | 98 ++++++
> .../perf/pmu-events/arch/s390/cf_z13/extended.json | 338 +++++++++++++++++++++
> tools/perf/pmu-events/arch/s390/cf_z14/basic.json | 50 +++
> tools/perf/pmu-events/arch/s390/cf_z14/crypto.json | 98 ++++++
> .../perf/pmu-events/arch/s390/cf_z14/extended.json | 320 +++++++++++++++++++
> tools/perf/pmu-events/arch/s390/cf_z196/basic.json | 74 +++++
> .../perf/pmu-events/arch/s390/cf_z196/crypto.json | 98 ++++++
> .../pmu-events/arch/s390/cf_z196/extended.json | 146 +++++++++
> .../perf/pmu-events/arch/s390/cf_zec12/basic.json | 74 +++++
> .../perf/pmu-events/arch/s390/cf_zec12/crypto.json | 98 ++++++
> .../pmu-events/arch/s390/cf_zec12/extended.json | 212 +++++++++++++
> tools/perf/pmu-events/arch/s390/mapfile.csv | 6 +
> tools/perf/util/mmap.c | 19 +-
> 18 files changed, 1987 insertions(+), 1 deletion(-)
> create mode 100644 tools/perf/pmu-events/arch/s390/cf_z10/basic.json
> create mode 100644 tools/perf/pmu-events/arch/s390/cf_z10/crypto.json
> create mode 100644 tools/perf/pmu-events/arch/s390/cf_z10/extended.json
> create mode 100644 tools/perf/pmu-events/arch/s390/cf_z13/basic.json
> create mode 100644 tools/perf/pmu-events/arch/s390/cf_z13/crypto.json
> create mode 100644 tools/perf/pmu-events/arch/s390/cf_z13/extended.json
> create mode 100644 tools/perf/pmu-events/arch/s390/cf_z14/basic.json
> create mode 100644 tools/perf/pmu-events/arch/s390/cf_z14/crypto.json
> create mode 100644 tools/perf/pmu-events/arch/s390/cf_z14/extended.json
> create mode 100644 tools/perf/pmu-events/arch/s390/cf_z196/basic.json
> create mode 100644 tools/perf/pmu-events/arch/s390/cf_z196/crypto.json
> create mode 100644 tools/perf/pmu-events/arch/s390/cf_z196/extended.json
> create mode 100644 tools/perf/pmu-events/arch/s390/cf_zec12/basic.json
> create mode 100644 tools/perf/pmu-events/arch/s390/cf_zec12/crypto.json
> create mode 100644 tools/perf/pmu-events/arch/s390/cf_zec12/extended.json
> create mode 100644 tools/perf/pmu-events/arch/s390/mapfile.csv
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 33+ messages in thread
* [GIT PULL 0/8] perf/core improvements and fixes
@ 2018-03-28 18:49 Arnaldo Carvalho de Melo
2018-03-29 7:23 ` Ingo Molnar
0 siblings, 1 reply; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-03-28 18:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linux-perf-users, Arnaldo Carvalho de Melo,
Adrian Hunter, Alexander Shishkin, David Ahern, Heiko Carstens,
Hendrik Brueckner, Jiri Olsa, Kan Liang, Martin Schwidefsky,
Namhyung Kim, Peter Zijlstra, Thomas Richter, Wang Nan,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 631fe154edb0a37308d0116a0f9b7bba9dca6218:
perf/x86: Update rdpmc_always_available static key to the modern API (2018-03-27 07:53:00 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.17-20180328
for you to fetch changes up to 109d59b900e78834c66657dd4748fcedb9a1fe8d:
perf vendor events s390: Add JSON files for IBM z14 (2018-03-27 13:13:39 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
- Be consistent when checking if a perf_mmap instance had
its ring buffer unmmaped, fixing segfaults noticed in
'perf trace' (Kan Liang, Arnaldo Carvalho de Melo)
- Avoid adding the same option multiple times to the 'diff'
command in check-headers.sh (Jiri Olsa)
- Add vendor event files (JSON format) to various IBM
s390 models (z10EC, z10BC, z196, zEC12, zBC12, z13
and z14) (Thomas Richter)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf mmap: Be consistent when checking for an unmaped ring buffer
Jiri Olsa (1):
perf build: Fix check-headers.sh opts assignment
Kan Liang (1):
perf mmap: Fix accessing unmapped mmap in perf_mmap__read_done()
Thomas Richter (5):
perf vendor events s390: Add JSON files for IBM z10EC z10BC
perf vendor events s390: Add JSON files for IBM z196
perf vendor events s390: Add JSON files for IBM zEC12 zBC12
perf vendor events s390: Add JSON files for IBM z13
perf vendor events s390: Add JSON files for IBM z14
tools/perf/check-headers.sh | 1 +
tools/perf/pmu-events/arch/s390/cf_z10/basic.json | 74 +++++
tools/perf/pmu-events/arch/s390/cf_z10/crypto.json | 98 ++++++
.../perf/pmu-events/arch/s390/cf_z10/extended.json | 110 +++++++
tools/perf/pmu-events/arch/s390/cf_z13/basic.json | 74 +++++
tools/perf/pmu-events/arch/s390/cf_z13/crypto.json | 98 ++++++
.../perf/pmu-events/arch/s390/cf_z13/extended.json | 338 +++++++++++++++++++++
tools/perf/pmu-events/arch/s390/cf_z14/basic.json | 50 +++
tools/perf/pmu-events/arch/s390/cf_z14/crypto.json | 98 ++++++
.../perf/pmu-events/arch/s390/cf_z14/extended.json | 320 +++++++++++++++++++
tools/perf/pmu-events/arch/s390/cf_z196/basic.json | 74 +++++
.../perf/pmu-events/arch/s390/cf_z196/crypto.json | 98 ++++++
.../pmu-events/arch/s390/cf_z196/extended.json | 146 +++++++++
.../perf/pmu-events/arch/s390/cf_zec12/basic.json | 74 +++++
.../perf/pmu-events/arch/s390/cf_zec12/crypto.json | 98 ++++++
.../pmu-events/arch/s390/cf_zec12/extended.json | 212 +++++++++++++
tools/perf/pmu-events/arch/s390/mapfile.csv | 6 +
tools/perf/util/mmap.c | 19 +-
18 files changed, 1987 insertions(+), 1 deletion(-)
create mode 100644 tools/perf/pmu-events/arch/s390/cf_z10/basic.json
create mode 100644 tools/perf/pmu-events/arch/s390/cf_z10/crypto.json
create mode 100644 tools/perf/pmu-events/arch/s390/cf_z10/extended.json
create mode 100644 tools/perf/pmu-events/arch/s390/cf_z13/basic.json
create mode 100644 tools/perf/pmu-events/arch/s390/cf_z13/crypto.json
create mode 100644 tools/perf/pmu-events/arch/s390/cf_z13/extended.json
create mode 100644 tools/perf/pmu-events/arch/s390/cf_z14/basic.json
create mode 100644 tools/perf/pmu-events/arch/s390/cf_z14/crypto.json
create mode 100644 tools/perf/pmu-events/arch/s390/cf_z14/extended.json
create mode 100644 tools/perf/pmu-events/arch/s390/cf_z196/basic.json
create mode 100644 tools/perf/pmu-events/arch/s390/cf_z196/crypto.json
create mode 100644 tools/perf/pmu-events/arch/s390/cf_z196/extended.json
create mode 100644 tools/perf/pmu-events/arch/s390/cf_zec12/basic.json
create mode 100644 tools/perf/pmu-events/arch/s390/cf_zec12/crypto.json
create mode 100644 tools/perf/pmu-events/arch/s390/cf_zec12/extended.json
create mode 100644 tools/perf/pmu-events/arch/s390/mapfile.csv
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support. Where clang is available, it is also used to build
perf with/without libelf.
The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# docker images | grep none
# time dm
1 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0
2 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822
3 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0
4 alpine:3.7 : Ok gcc (Alpine 6.4.0) 6.4.0
5 alpine:edge : Ok gcc (Alpine 6.4.0) 6.4.0
6 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-11)
7 amazonlinux:2 : Ok gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2)
8 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
9 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
10 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
11 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)
12 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
13 debian:7 : Ok gcc (Debian 4.7.2-5) 4.7.2
14 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u1) 4.9.2
15 debian:9 : Ok gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
16 debian:experimental : Ok gcc (Debian 7.3.0-12) 7.3.0
17 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 7.3.0-12) 7.3.0
18 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 7.3.0-12) 7.3.0
19 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 7.3.0-11) 7.3.0
20 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 7.3.0-12) 7.3.0
21 fedora:20 : Ok gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
22 fedora:21 : Ok gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)
23 fedora:22 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
24 fedora:23 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
25 fedora:24 : Ok gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
26 fedora:24-x-ARC-uClibc : Ok arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
27 fedora:25 : Ok gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
28 fedora:26 : Ok gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2)
29 fedora:27 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
30 fedora:rawhide : Ok gcc (GCC) 8.0.1 20180222 (Red Hat 8.0.1-0.16)
31 gentoo-stage3-amd64:latest : Ok gcc (Gentoo 6.4.0-r1 p1.3) 6.4.0
32 mageia:5 : Ok gcc (GCC) 4.9.2
33 mageia:6 : Ok gcc (Mageia 5.5.0-1.mga6) 5.5.0
34 opensuse:42.1 : Ok gcc (SUSE Linux) 4.8.5
35 opensuse:42.2 : Ok gcc (SUSE Linux) 4.8.5
36 opensuse:42.3 : Ok gcc (SUSE Linux) 4.8.5
37 opensuse:tumbleweed : Ok gcc (SUSE Linux) 7.3.0
38 oraclelinux:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)
39 oraclelinux:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16.0.3)
40 ubuntu:12.04.5 : Ok gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
41 ubuntu:14.04.4 : Ok gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
42 ubuntu:14.04.4-x-linaro-arm64 : Ok aarch64-linux-gnu-gcc (Linaro GCC 5.4-2017.05) 5.4.1 20170404
43 ubuntu:15.04 : Ok gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2
44 ubuntu:16.04 : Ok gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
45 ubuntu:16.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
46 ubuntu:16.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
47 ubuntu:16.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
48 ubuntu:16.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
49 ubuntu:16.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
50 ubuntu:16.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
51 ubuntu:16.10 : Ok gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005
52 ubuntu:17.04 : Ok gcc (Ubuntu 6.3.0-12ubuntu2) 6.3.0 20170406
53 ubuntu:17.10 : Ok gcc (Ubuntu 7.2.0-8ubuntu3) 7.2.0
54 ubuntu:18.04 : Ok gcc (Ubuntu 7.2.0-16ubuntu1) 7.2.0
#
# uname -r
4.16.0-rc7
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Breakpoint accounting : Skip
22: Number of exit events of a simple workload : Ok
23: Software clock events period values : Ok
24: Object code reading : Ok
25: Sample parsing : Ok
26: Use a dummy software event to keep tracking : Ok
27: Parse with no sample_id_all bit set : Ok
28: Filter hist entries : Ok
29: Lookup mmap thread : Ok
30: Share thread mg : Ok
31: Sort output of hist entries : Ok
32: Cumulate child hist entries : Ok
33: Track with sched_switch : Ok
34: Filter fds with revents mask in a fdarray : Ok
35: Add fd to a fdarray, making it autogrow : Ok
36: kmod_path__parse : Ok
37: Thread map : Ok
38: LLVM search and compile :
38.1: Basic BPF llvm compile : Ok
38.2: kbuild searching : Ok
38.3: Compile source for BPF prologue generation : Ok
38.4: Compile source for BPF relocation : Ok
39: Session topology : Ok
40: BPF filter :
40.1: Basic BPF filtering : Ok
40.2: BPF pinning : Ok
40.3: BPF prologue generation : Ok
40.4: BPF relocation checker : Ok
41: Synthesize thread map : Ok
42: Remove thread map : Ok
43: Synthesize cpu map : Ok
44: Synthesize stat config : Ok
45: Synthesize stat : Ok
46: Synthesize stat round : Ok
47: Synthesize attr update : Ok
48: Event times : Ok
49: Read backward ring buffer : Ok
50: Print cpu map : Ok
51: Probe SDT events : Ok
52: is_printable_array : Ok
53: Print bitmap : Ok
54: perf hooks : Ok
55: builtin clang support : Skip (not compiled in)
56: unit_number__scnprintf : Ok
57: mem2node : Ok
58: x86 rdpmc : Ok
59: Convert perf time to TSC : Ok
60: DWARF unwind : Ok
61: x86 instruction decoder - new instructions : Ok
62: Use vfs_getname probe to get syscall args filenames : Ok
63: probe libc's inet_pton & backtrace it with ping : Ok
64: Check open filename arg using perf trace + vfs_getname: Ok
65: probe libc's inet_pton & backtrace it with ping : Ok
66: Add vfs_getname probe to get syscall args filenames : Ok
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/perf/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_libperl_O: make NO_LIBPERL=1
make_no_libbionic_O: make NO_LIBBIONIC=1
make_install_prefix_O: make install prefix=/tmp/krava
make_perf_o_O: make perf.o
make_no_libpython_O: make NO_LIBPYTHON=1
make_tags_O: make tags
make_install_O: make install
make_doc_O: make doc
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_no_libelf_O: make NO_LIBELF=1
make_install_bin_O: make install-bin
make_no_backtrace_O: make NO_BACKTRACE=1
make_no_gtk2_O: make NO_GTK2=1
make_no_slang_O: make NO_SLANG=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_help_O: make help
make_no_demangle_O: make NO_DEMANGLE=1
make_no_libbpf_O: make NO_LIBBPF=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_clean_all_O: make clean all
make_no_newt_O: make NO_NEWT=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_debug_O: make DEBUG=1
make_pure_O: make
make_no_libnuma_O: make NO_LIBNUMA=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_static_O: make LDFLAGS=-static
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_util_map_o_O: make util/map.o
OK
make: Leaving directory '/home/acme/git/perf/tools/perf'
$
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL 0/8] perf/core improvements and fixes
2017-10-03 12:55 Arnaldo Carvalho de Melo
@ 2017-10-03 16:38 ` Ingo Molnar
0 siblings, 0 replies; 33+ messages in thread
From: Ingo Molnar @ 2017-10-03 16:38 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, linux-perf-users, Adrian Hunter,
Alexei Starovoitov, Andi Kleen, David Ahern, Heiko Carstens,
He Kuang, Hendrik Brueckner, Jiri Olsa, Kan Liang,
Lukasz Odzioba, Martin Schwidefsky, Namhyung Kim, Peter Zijlstra,
Thomas-Mich Richter, Wang Nan, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> I pulled tip/perf/urgent to pick up fixes, please consider
> pulling, I've been away for a while, so I'll be harvesting outstanding
> patches in the next few days, as well as trying and reviewing more
> complex patchkits,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit c976a7d6db215481261b63a89a408cb265a9812b:
>
> Merge remote-tracking branch 'tip/perf/urgent' into perf/core, to pick up fixes (2017-10-02 13:58:12 -0300)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.15-20171003
>
> for you to fetch changes up to f6a9820d572bd8384d982357cbad214b3a6c04bb:
>
> perf tests attr: Fix group stat tests (2017-10-03 09:41:45 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> - Multithread the synthesizing of PERF_RECORD_ events for pre-existing
> threads in 'perf top', speeding up that phase, greatly improving the
> user experience in systems such as Intel's Knights Mill (Kan Liang)
>
> - 'perf test' fixes for the perf_event_attr test case (Jiri Olsa, Thomas Richter)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Jiri Olsa (2):
> perf tests attr: Fix task term values
> perf tests attr: Fix group stat tests
>
> Kan Liang (4):
> perf tools: Lock to protect namespaces and comm list
> perf tools: Lock to protect comm_str rb tree
> perf top: Implement multithreading for perf_event__synthesize_threads
> perf top: Add option to set the number of thread for event synthesize
>
> Thomas Richter (2):
> perf test attr: Fix python error on empty result
> perf test attr: Fix ignored test case result
>
> tools/perf/Documentation/perf-top.txt | 3 +
> tools/perf/builtin-kvm.c | 3 +-
> tools/perf/builtin-record.c | 2 +-
> tools/perf/builtin-top.c | 13 +-
> tools/perf/builtin-trace.c | 2 +-
> tools/perf/tests/attr.c | 2 +-
> tools/perf/tests/attr.py | 6 +-
> tools/perf/tests/attr/base-record | 2 +-
> tools/perf/tests/attr/test-record-group | 1 +
> tools/perf/tests/attr/test-record-group-sampling | 2 +-
> tools/perf/tests/attr/test-record-group1 | 1 +
> tools/perf/tests/attr/test-stat-group | 2 +
> tools/perf/tests/attr/test-stat-group1 | 2 +
> tools/perf/tests/mmap-thread-lookup.c | 2 +-
> tools/perf/util/comm.c | 18 ++-
> tools/perf/util/event.c | 163 ++++++++++++++++++-----
> tools/perf/util/event.h | 3 +-
> tools/perf/util/machine.c | 8 +-
> tools/perf/util/machine.h | 9 +-
> tools/perf/util/thread.c | 53 +++++++-
> tools/perf/util/thread.h | 3 +
> tools/perf/util/top.h | 1 +
> 22 files changed, 249 insertions(+), 52 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 33+ messages in thread
* [GIT PULL 0/8] perf/core improvements and fixes
@ 2017-10-03 12:55 Arnaldo Carvalho de Melo
2017-10-03 16:38 ` Ingo Molnar
0 siblings, 1 reply; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-10-03 12:55 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linux-perf-users, Arnaldo Carvalho de Melo,
Adrian Hunter, Alexei Starovoitov, Andi Kleen, David Ahern,
Heiko Carstens, He Kuang, Hendrik Brueckner, Jiri Olsa,
Kan Liang, Lukasz Odzioba, Martin Schwidefsky, Namhyung Kim,
Peter Zijlstra, Thomas-Mich Richter, Wang Nan,
Arnaldo Carvalho de Melo
Hi Ingo,
I pulled tip/perf/urgent to pick up fixes, please consider
pulling, I've been away for a while, so I'll be harvesting outstanding
patches in the next few days, as well as trying and reviewing more
complex patchkits,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit c976a7d6db215481261b63a89a408cb265a9812b:
Merge remote-tracking branch 'tip/perf/urgent' into perf/core, to pick up fixes (2017-10-02 13:58:12 -0300)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.15-20171003
for you to fetch changes up to f6a9820d572bd8384d982357cbad214b3a6c04bb:
perf tests attr: Fix group stat tests (2017-10-03 09:41:45 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
- Multithread the synthesizing of PERF_RECORD_ events for pre-existing
threads in 'perf top', speeding up that phase, greatly improving the
user experience in systems such as Intel's Knights Mill (Kan Liang)
- 'perf test' fixes for the perf_event_attr test case (Jiri Olsa, Thomas Richter)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Jiri Olsa (2):
perf tests attr: Fix task term values
perf tests attr: Fix group stat tests
Kan Liang (4):
perf tools: Lock to protect namespaces and comm list
perf tools: Lock to protect comm_str rb tree
perf top: Implement multithreading for perf_event__synthesize_threads
perf top: Add option to set the number of thread for event synthesize
Thomas Richter (2):
perf test attr: Fix python error on empty result
perf test attr: Fix ignored test case result
tools/perf/Documentation/perf-top.txt | 3 +
tools/perf/builtin-kvm.c | 3 +-
tools/perf/builtin-record.c | 2 +-
tools/perf/builtin-top.c | 13 +-
tools/perf/builtin-trace.c | 2 +-
tools/perf/tests/attr.c | 2 +-
tools/perf/tests/attr.py | 6 +-
tools/perf/tests/attr/base-record | 2 +-
tools/perf/tests/attr/test-record-group | 1 +
tools/perf/tests/attr/test-record-group-sampling | 2 +-
tools/perf/tests/attr/test-record-group1 | 1 +
tools/perf/tests/attr/test-stat-group | 2 +
tools/perf/tests/attr/test-stat-group1 | 2 +
tools/perf/tests/mmap-thread-lookup.c | 2 +-
tools/perf/util/comm.c | 18 ++-
tools/perf/util/event.c | 163 ++++++++++++++++++-----
tools/perf/util/event.h | 3 +-
tools/perf/util/machine.c | 8 +-
tools/perf/util/machine.h | 9 +-
tools/perf/util/thread.c | 53 +++++++-
tools/perf/util/thread.h | 3 +
tools/perf/util/top.h | 1 +
22 files changed, 249 insertions(+), 52 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support. Where clang is available, it is also used to build
perf with/without libelf.
The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4: Ok
2 alpine:3.5: Ok
3 alpine:3.6: Ok
4 alpine:edge: Ok
5 android-ndk:r12b-arm: Ok
6 android-ndk:r15c-arm: Ok
7 centos:5: Ok
8 centos:6: Ok
9 centos:7: Ok
10 debian:7: Ok
11 debian:8: Ok
12 debian:9: Ok
13 debian:experimental: Ok
14 debian:experimental-x-arm64: Ok
15 debian:experimental-x-mips: Ok
16 debian:experimental-x-mips64: Ok
17 debian:experimental-x-mipsel: Ok
18 fedora:20: Ok
19 fedora:21: Ok
20 fedora:22: Ok
21 fedora:23: Ok
22 fedora:24: Ok
23 fedora:24-x-ARC-uClibc: FAIL
builtin-sched.c: In function 'timehist_sched_switch_event':
builtin-sched.c:2580:1: internal compiler error: in change_address_1, at emit-rtl.c:2150
}
^
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/issues> for instructions.
24 fedora:25: Ok
25 fedora:26: Ok
26 fedora:rawhide: Ok
27 mageia:5: Ok
28 opensuse:42.1: Ok
29 opensuse:42.2: Ok
30 opensuse:42.3: Ok
31 opensuse:tumbleweed: Ok
32 oraclelinux:6: Ok
33 oraclelinux:7: Ok
34 ubuntu:12.04.5: Ok
35 ubuntu:14.04.4: Ok
36 ubuntu:14.04.4-x-linaro-arm64: Ok
37 ubuntu:15.10: Ok
38 ubuntu:16.04: Ok
39 ubuntu:16.04-x-arm: Ok
40 ubuntu:16.04-x-arm64: Ok
41 ubuntu:16.04-x-powerpc: Ok
42 ubuntu:16.04-x-powerpc64: Ok
43 ubuntu:16.04-x-powerpc64el: Ok
44 ubuntu:16.04-x-s390: Ok
# uname -a
Linux jouet 4.13.0+ #3 SMP Mon Sep 25 11:51:22 -03 2017 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Number of exit events of a simple workload : Ok
22: Software clock events period values : Ok
23: Object code reading : Ok
24: Sample parsing : Ok
25: Use a dummy software event to keep tracking : Ok
26: Parse with no sample_id_all bit set : Ok
27: Filter hist entries : Ok
28: Lookup mmap thread : Ok
29: Share thread mg : Ok
30: Sort output of hist entries : Ok
31: Cumulate child hist entries : Ok
32: Track with sched_switch : Ok
33: Filter fds with revents mask in a fdarray : Ok
34: Add fd to a fdarray, making it autogrow : Ok
35: kmod_path__parse : Ok
36: Thread map : Ok
37: LLVM search and compile :
37.1: Basic BPF llvm compile : Ok
37.2: kbuild searching : Ok
37.3: Compile source for BPF prologue generation : Ok
37.4: Compile source for BPF relocation : Ok
38: Session topology : Ok
39: BPF filter :
39.1: Basic BPF filtering : Ok
39.2: BPF pinning : Ok
39.3: BPF prologue generation : Ok
39.4: BPF relocation checker : Ok
40: Synthesize thread map : Ok
41: Remove thread map : Ok
42: Synthesize cpu map : Ok
43: Synthesize stat config : Ok
44: Synthesize stat : Ok
45: Synthesize stat round : Ok
46: Synthesize attr update : Ok
47: Event times : Ok
48: Read backward ring buffer : Ok
49: Print cpu map : Ok
50: Probe SDT events : Ok
51: is_printable_array : Ok
52: Print bitmap : Ok
53: perf hooks : Ok
54: builtin clang support : Skip (not compiled in)
55: unit_number__scnprintf : Ok
56: x86 rdpmc : Ok
57: Convert perf time to TSC : Ok
58: DWARF unwind : Ok
59: x86 instruction decoder - new instructions : Ok
60: Use vfs_getname probe to get syscall args filenames : Ok
61: probe libc's inet_pton & backtrace it with ping : Ok
62: Check open filename arg using perf trace + vfs_getname: Ok
63: Add vfs_getname probe to get syscall args filenames : Ok
#
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL 0/8] perf/core improvements and fixes
2016-01-15 21:40 Arnaldo Carvalho de Melo
@ 2016-01-19 7:32 ` Ingo Molnar
0 siblings, 0 replies; 33+ messages in thread
From: Ingo Molnar @ 2016-01-19 7:32 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Ben Hutchings, Jiri Olsa, Namhyung Kim,
Naveen N . Rao, Peter Zijlstra, pi3orama, Ravi Bangoria,
Wang Nan, Zefan Li, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit c36608843adf4674c462e49f63b64b2987d0ba0b:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-01-13 10:36:03 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 96b9e70b8e6cd65f71ee71889143976f3afb038a:
>
> perf build: Introduce FEATURES_DUMP make variable (2016-01-15 16:32:00 -0300)
>
> ----------------------------------------------------------------
> perf tools improvements and fixes:
>
> User visible bug fixes:
>
> - Fix reading of build-id from vDSO (Ben Hutchings)
>
> - Fix processing samples for guests, noticed with 'perf kvm',
> but noticeable as well via other tools, such as 'perf top'
> (Ravi Bangoria)
>
> Build infrastructure:
>
> - Add feature-dump target and FEATURES_DUMP make variable, to
> allow reusing the feature detection results among multiple
> tools/ living codebases, such as perf and lib/bpf (Jiri Olsa)
>
> - 'make -C tools/perf build-test' improvements, making it more
> paralelizable and allowing building it outside of the source
> tree, using O= (Wang Nan)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Ben Hutchings (1):
> perf symbols: Fix reading of build-id from vDSO
>
> Jiri Olsa (2):
> perf build: Add feature-dump target
> perf build: Introduce FEATURES_DUMP make variable
>
> Ravi Bangoria (1):
> perf kvm record/report: 'unprocessable sample' error while recording/reporting guest data
>
> Wang Nan (4):
> perf build: Set parallel making options build-test
> perf build: Pass O option to Makefile.perf in build-test
> perf build: Test correct path of perf in build-test
> perf build: Pass O option to kernel makefile in build-test
>
> tools/perf/Makefile.perf | 25 ++++++++++++++++++++-
> tools/perf/config/Makefile | 4 ++++
> tools/perf/tests/make | 55 +++++++++++++++++++++++++++++++++-------------
> tools/perf/util/session.c | 2 +-
> tools/perf/util/symbol.c | 2 +-
> 5 files changed, 70 insertions(+), 18 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 33+ messages in thread
* [GIT PULL 0/8] perf/core improvements and fixes
@ 2016-01-15 21:40 Arnaldo Carvalho de Melo
2016-01-19 7:32 ` Ingo Molnar
0 siblings, 1 reply; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-01-15 21:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Ben Hutchings, Jiri Olsa,
Namhyung Kim, Naveen N . Rao, Peter Zijlstra, pi3orama,
Ravi Bangoria, Wang Nan, Zefan Li, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit c36608843adf4674c462e49f63b64b2987d0ba0b:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-01-13 10:36:03 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 96b9e70b8e6cd65f71ee71889143976f3afb038a:
perf build: Introduce FEATURES_DUMP make variable (2016-01-15 16:32:00 -0300)
----------------------------------------------------------------
perf tools improvements and fixes:
User visible bug fixes:
- Fix reading of build-id from vDSO (Ben Hutchings)
- Fix processing samples for guests, noticed with 'perf kvm',
but noticeable as well via other tools, such as 'perf top'
(Ravi Bangoria)
Build infrastructure:
- Add feature-dump target and FEATURES_DUMP make variable, to
allow reusing the feature detection results among multiple
tools/ living codebases, such as perf and lib/bpf (Jiri Olsa)
- 'make -C tools/perf build-test' improvements, making it more
paralelizable and allowing building it outside of the source
tree, using O= (Wang Nan)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Ben Hutchings (1):
perf symbols: Fix reading of build-id from vDSO
Jiri Olsa (2):
perf build: Add feature-dump target
perf build: Introduce FEATURES_DUMP make variable
Ravi Bangoria (1):
perf kvm record/report: 'unprocessable sample' error while recording/reporting guest data
Wang Nan (4):
perf build: Set parallel making options build-test
perf build: Pass O option to Makefile.perf in build-test
perf build: Test correct path of perf in build-test
perf build: Pass O option to kernel makefile in build-test
tools/perf/Makefile.perf | 25 ++++++++++++++++++++-
tools/perf/config/Makefile | 4 ++++
tools/perf/tests/make | 55 +++++++++++++++++++++++++++++++++-------------
tools/perf/util/session.c | 2 +-
tools/perf/util/symbol.c | 2 +-
5 files changed, 70 insertions(+), 18 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL 0/8] perf/core improvements and fixes
2015-10-29 23:05 Arnaldo Carvalho de Melo
@ 2015-10-30 9:10 ` Ingo Molnar
0 siblings, 0 replies; 33+ messages in thread
From: Ingo Molnar @ 2015-10-30 9:10 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexei Starovoitov, Andi Kleen,
Brendan Gregg, Daniel Borkmann, David Ahern, He Kuang, Jiri Olsa,
Kaixu Xia, Kan Liang, Masami Hiramatsu, Namhyung Kim,
Peter Zijlstra, pi3orama, Rabin Vincent, Stephane Eranian,
Wang Nan, Yuanfang Chen, Zefan Li, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> This one gets us to pass .c files that gets built and
> loaded, next step will be to be able to access function arguments,
> for which there are patches available, but I'm still reviewing them.
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 66a565c203bc31b76969711fbd92da11bee2f129:
>
> Merge tag 'perf-ebpf-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-29 13:17:56 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 7ed4915ad60788d6b846e2cd034f49ee15698143:
>
> perf unwind: Pass symbol source to libunwind (2015-10-29 17:48:38 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> New features:
>
> - Allow passing C language eBPF scriptlets via --event in all tools,
> so that it gets built using clang and then pass it to the kernel via
> sys_bpf() (Wang Nan)
>
> - Wire up the loaded ebpf object file with associated kprobes, so that
> it can determine if the kprobes will be filtered or not (Wang Nan)
>
> User visible:
>
> - Add cmd string table to decode sys_bpf first arg in 'trace' (Arnaldo Carvalho de Melo)
>
> - Enable printing of branch stack in 'perf script' (Stephane Eranian)
>
> - Pass the right file with debug info to libunwind (Rabin Vincent)
>
> Build Fixes:
>
> - Make sure fixdep is built before libbpf, fixing a race (Jiri Olsa)
>
> - Fix libiberty feature detection (Rabin Vincent)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf trace: Add cmd string table to decode sys_bpf first arg
>
> Jiri Olsa (1):
> perf tools: Make sure fixdep is built before libbpf
>
> Rabin Vincent (2):
> tools build: Fix libiberty feature detection
> perf unwind: Pass symbol source to libunwind
>
> Stephane Eranian (1):
> perf script: Enable printing of branch stack
>
> Wang Nan (3):
> perf bpf: Attach eBPF filter to perf event
> perf record: Add clang options for compiling BPF scripts
> perf tools: Compile scriptlets to BPF objects when passing '.c' to --event
>
> tools/build/feature/Makefile | 4 +-
> tools/perf/Documentation/perf-record.txt | 6 +++
> tools/perf/Documentation/perf-script.txt | 14 +++++-
> tools/perf/Makefile.perf | 2 +-
> tools/perf/builtin-record.c | 7 +++
> tools/perf/builtin-script.c | 82 +++++++++++++++++++++++++++++++-
> tools/perf/builtin-trace.c | 7 +++
> tools/perf/tests/bpf-script-example.c | 44 +++++++++++++++++
> tools/perf/util/bpf-loader.c | 17 ++++++-
> tools/perf/util/bpf-loader.h | 5 +-
> tools/perf/util/evsel.c | 17 +++++++
> tools/perf/util/evsel.h | 1 +
> tools/perf/util/parse-events.c | 11 ++++-
> tools/perf/util/parse-events.h | 3 +-
> tools/perf/util/parse-events.l | 3 ++
> tools/perf/util/parse-events.y | 15 +++++-
> tools/perf/util/unwind-libunwind.c | 5 +-
> 17 files changed, 227 insertions(+), 16 deletions(-)
> create mode 100644 tools/perf/tests/bpf-script-example.c
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 33+ messages in thread
* [GIT PULL 0/8] perf/core improvements and fixes
@ 2015-10-29 23:05 Arnaldo Carvalho de Melo
2015-10-30 9:10 ` Ingo Molnar
0 siblings, 1 reply; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-10-29 23:05 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexei Starovoitov, Andi Kleen, Brendan Gregg, Daniel Borkmann,
David Ahern, He Kuang, Jiri Olsa, Kaixu Xia, Kan Liang,
Masami Hiramatsu, Namhyung Kim, Peter Zijlstra, pi3orama,
Rabin Vincent, Stephane Eranian, Wang Nan, Yuanfang Chen,
Zefan Li, Arnaldo Carvalho de Melo
Hi Ingo,
This one gets us to pass .c files that gets built and
loaded, next step will be to be able to access function arguments,
for which there are patches available, but I'm still reviewing them.
Please consider pulling,
- Arnaldo
The following changes since commit 66a565c203bc31b76969711fbd92da11bee2f129:
Merge tag 'perf-ebpf-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-29 13:17:56 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 7ed4915ad60788d6b846e2cd034f49ee15698143:
perf unwind: Pass symbol source to libunwind (2015-10-29 17:48:38 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
New features:
- Allow passing C language eBPF scriptlets via --event in all tools,
so that it gets built using clang and then pass it to the kernel via
sys_bpf() (Wang Nan)
- Wire up the loaded ebpf object file with associated kprobes, so that
it can determine if the kprobes will be filtered or not (Wang Nan)
User visible:
- Add cmd string table to decode sys_bpf first arg in 'trace' (Arnaldo Carvalho de Melo)
- Enable printing of branch stack in 'perf script' (Stephane Eranian)
- Pass the right file with debug info to libunwind (Rabin Vincent)
Build Fixes:
- Make sure fixdep is built before libbpf, fixing a race (Jiri Olsa)
- Fix libiberty feature detection (Rabin Vincent)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf trace: Add cmd string table to decode sys_bpf first arg
Jiri Olsa (1):
perf tools: Make sure fixdep is built before libbpf
Rabin Vincent (2):
tools build: Fix libiberty feature detection
perf unwind: Pass symbol source to libunwind
Stephane Eranian (1):
perf script: Enable printing of branch stack
Wang Nan (3):
perf bpf: Attach eBPF filter to perf event
perf record: Add clang options for compiling BPF scripts
perf tools: Compile scriptlets to BPF objects when passing '.c' to --event
tools/build/feature/Makefile | 4 +-
tools/perf/Documentation/perf-record.txt | 6 +++
tools/perf/Documentation/perf-script.txt | 14 +++++-
tools/perf/Makefile.perf | 2 +-
tools/perf/builtin-record.c | 7 +++
tools/perf/builtin-script.c | 82 +++++++++++++++++++++++++++++++-
tools/perf/builtin-trace.c | 7 +++
tools/perf/tests/bpf-script-example.c | 44 +++++++++++++++++
tools/perf/util/bpf-loader.c | 17 ++++++-
tools/perf/util/bpf-loader.h | 5 +-
tools/perf/util/evsel.c | 17 +++++++
tools/perf/util/evsel.h | 1 +
tools/perf/util/parse-events.c | 11 ++++-
tools/perf/util/parse-events.h | 3 +-
tools/perf/util/parse-events.l | 3 ++
tools/perf/util/parse-events.y | 15 +++++-
tools/perf/util/unwind-libunwind.c | 5 +-
17 files changed, 227 insertions(+), 16 deletions(-)
create mode 100644 tools/perf/tests/bpf-script-example.c
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL 0/8] perf/core improvements and fixes
2015-10-22 22:14 Arnaldo Carvalho de Melo
@ 2015-10-23 8:28 ` Ingo Molnar
0 siblings, 0 replies; 33+ messages in thread
From: Ingo Molnar @ 2015-10-23 8:28 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Borislav Petkov, Brendan Gregg,
Chandler Carruth, Dave Chinner, David Ahern, Frederic Weisbecker,
Jiri Olsa, Martin Liška, Namhyung Kim, Peter Zijlstra,
Scott Wood, Stephane Eranian, Steven Rostedt, Taeung Song,
Wang Nan, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 4ba792e303e278052bb0ee60cce15d6d7dc15c7c:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-22 09:33:46 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to f06cff7c59b6b252d667435d7baad48687b41002:
>
> perf annotate: Don't die() when finding an invalid config option (2015-10-22 18:10:52 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - The default for callchains is back to 'callee' when --children is not used,
> (Namhyung Kim)
>
> - Move the 'use_offset' option to the right place where the annotate code
> expects it to be to be able to properly handle it (Namhyung Kim)
>
> - Don't die when an unknown 'annotate' option is found in the perf config
> file (usually ~/.perfconfig), just warn the user (Arnaldo Carvalho de Melo)
>
> Infrastructure:
>
> - Support %ps/%pS in libtraceevent (Scott Wood)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (2):
> perf ui tui: Register the error callbacks before initializing the widgets
> perf annotate: Don't die() when finding an invalid config option
>
> Namhyung Kim (5):
> perf tools: Move callchain help messages to callchain.h
> perf top: Support call-graph display options also
> perf tools: Defaults to 'caller' callchain order only if --children is enabled
> perf tools: Improve call graph documents and help messages
> perf annotate: Fix 'annotate.use_offset' config variable usage
>
> Scott Wood (1):
> tools lib traceevent: Support %ps/%pS
>
> tools/lib/traceevent/event-parse.c | 4 +--
> tools/perf/Documentation/perf-record.txt | 9 +++++--
> tools/perf/Documentation/perf-report.txt | 38 ++++++++++++++++++-----------
> tools/perf/Documentation/perf-top.txt | 5 ++--
> tools/perf/builtin-record.c | 11 +++------
> tools/perf/builtin-report.c | 17 ++++++++++---
> tools/perf/builtin-top.c | 30 +++++++++++++++++++----
> tools/perf/ui/browsers/annotate.c | 8 +++---
> tools/perf/ui/tui/setup.c | 8 +++---
> tools/perf/util/callchain.c | 42 +++++++++++++++++++++++++++++---
> tools/perf/util/callchain.h | 26 ++++++++++++++++++++
> tools/perf/util/util.c | 2 +-
> 12 files changed, 151 insertions(+), 49 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 33+ messages in thread
* [GIT PULL 0/8] perf/core improvements and fixes
@ 2015-10-22 22:14 Arnaldo Carvalho de Melo
2015-10-23 8:28 ` Ingo Molnar
0 siblings, 1 reply; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-10-22 22:14 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Borislav Petkov, Brendan Gregg, Chandler Carruth, Dave Chinner,
David Ahern, Frederic Weisbecker, Jiri Olsa, Martin Liška,
Namhyung Kim, Peter Zijlstra, Scott Wood, Stephane Eranian,
Steven Rostedt, Taeung Song, Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 4ba792e303e278052bb0ee60cce15d6d7dc15c7c:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-22 09:33:46 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to f06cff7c59b6b252d667435d7baad48687b41002:
perf annotate: Don't die() when finding an invalid config option (2015-10-22 18:10:52 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- The default for callchains is back to 'callee' when --children is not used,
(Namhyung Kim)
- Move the 'use_offset' option to the right place where the annotate code
expects it to be to be able to properly handle it (Namhyung Kim)
- Don't die when an unknown 'annotate' option is found in the perf config
file (usually ~/.perfconfig), just warn the user (Arnaldo Carvalho de Melo)
Infrastructure:
- Support %ps/%pS in libtraceevent (Scott Wood)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (2):
perf ui tui: Register the error callbacks before initializing the widgets
perf annotate: Don't die() when finding an invalid config option
Namhyung Kim (5):
perf tools: Move callchain help messages to callchain.h
perf top: Support call-graph display options also
perf tools: Defaults to 'caller' callchain order only if --children is enabled
perf tools: Improve call graph documents and help messages
perf annotate: Fix 'annotate.use_offset' config variable usage
Scott Wood (1):
tools lib traceevent: Support %ps/%pS
tools/lib/traceevent/event-parse.c | 4 +--
tools/perf/Documentation/perf-record.txt | 9 +++++--
tools/perf/Documentation/perf-report.txt | 38 ++++++++++++++++++-----------
tools/perf/Documentation/perf-top.txt | 5 ++--
tools/perf/builtin-record.c | 11 +++------
tools/perf/builtin-report.c | 17 ++++++++++---
tools/perf/builtin-top.c | 30 +++++++++++++++++++----
tools/perf/ui/browsers/annotate.c | 8 +++---
tools/perf/ui/tui/setup.c | 8 +++---
tools/perf/util/callchain.c | 42 +++++++++++++++++++++++++++++---
tools/perf/util/callchain.h | 26 ++++++++++++++++++++
tools/perf/util/util.c | 2 +-
12 files changed, 151 insertions(+), 49 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL 0/8] perf/core improvements and fixes
2015-10-13 19:41 Arnaldo Carvalho de Melo
@ 2015-10-14 13:09 ` Ingo Molnar
0 siblings, 0 replies; 33+ messages in thread
From: Ingo Molnar @ 2015-10-14 13:09 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Andi Kleen, Borislav Petkov,
David Ahern, Frederic Weisbecker, He Kuang, Jiri Olsa,
linux-next, Martin Liska, Namhyung Kim, Peter Zijlstra,
Rabin Vincent, Stephane Eranian, Wang Nan,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling.
>
> - Arnaldo
>
> BTW.: There are several outstanding patchkits needing review and processing,
> I'll be out this week for a conference, will try and speed up processing next
> week.
>
> The following changes since commit 0e537fef24d64f7bf3ef61a27edf64a8d9a5424c:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-08 10:52:44 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 3a70fcd3a4db56731f67f0189514953c74257944:
>
> tools build: Fix cross compile build (2015-10-13 11:59:43 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Use the alternative with the most descriptive filename containing
> a vmlinux file for a given build-id, providing a better title line
> for tools such as 'annotate' (Arnaldo Carvalho de Melo)
>
> - Remove help messages about previous right and left arrow keybidings, that
> were repurposed for horizontal scrolling (Arnaldo Carvalho de Melo)
>
> - Inform how to reset the symbol filter in the hists browser (top & report)
> (Arnaldo Carvalho de Melo)
>
> - Add 'm' key for context menu display in the hists browser, that became
> inacessible with the repurposing of the right arrow key for horizontal
> scrolling (Namhyung Kim)
>
> - Use debug_frame for callchains if eh_frame is unusable (Rabin Vicent)
>
> Build fixes:
>
> - Fix strict-aliasing breakage with gcc 4.4 in the READ_ONCE/WRITE_ONCE code
> adopted from the kernel tree, that builds with -fno-strict-aliasing while
> tools/perf/ uses -Wstrict-aliasing=3 (Jiri Olsa)
>
> - Fix unw_word_t pointer casts in code using libunwind for callchains,
> fixing the build in at least 32-bit MIPS systems (Rabin Vicent)
>
> - Workaround cross compile build problems related to fixdep (Jiri Olsa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (3):
> perf symbols: Try the .debug/ DSO cache as a last resort
> perf ui browsers: Remove help messages about use of right and arrow keys
> perf hists browser: Inform how to reset the symbol filter
>
> Jiri Olsa (2):
> tools include: Fix strict-aliasing rules breakage
> tools build: Fix cross compile build
>
> Namhyung Kim (1):
> perf hists browser: Add 'm' key for context menu display
>
> Rabin Vincent (2):
> perf callchain: Use debug_frame if eh_frame is unusable
> perf callchains: Fix unw_word_t pointer casts
>
> tools/build/Makefile.include | 4 ++++
> tools/include/linux/compiler.h | 32 ++++++++++++++++++++++++--------
> tools/perf/ui/browsers/annotate.c | 6 +++---
> tools/perf/ui/browsers/hists.c | 13 ++++++++-----
> tools/perf/ui/browsers/map.c | 2 +-
> tools/perf/ui/browsers/scripts.c | 2 +-
> tools/perf/util/symbol.c | 18 +++++++++---------
> tools/perf/util/unwind-libunwind.c | 14 ++++++++------
> 8 files changed, 58 insertions(+), 33 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 33+ messages in thread
* [GIT PULL 0/8] perf/core improvements and fixes
@ 2015-10-13 19:41 Arnaldo Carvalho de Melo
2015-10-14 13:09 ` Ingo Molnar
0 siblings, 1 reply; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-10-13 19:41 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Borislav Petkov, David Ahern, Frederic Weisbecker,
He Kuang, Jiri Olsa, linux-next, Martin Liska, Namhyung Kim,
Peter Zijlstra, Rabin Vincent, Stephane Eranian, Wang Nan,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling.
- Arnaldo
BTW.: There are several outstanding patchkits needing review and processing,
I'll be out this week for a conference, will try and speed up processing next
week.
The following changes since commit 0e537fef24d64f7bf3ef61a27edf64a8d9a5424c:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-08 10:52:44 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 3a70fcd3a4db56731f67f0189514953c74257944:
tools build: Fix cross compile build (2015-10-13 11:59:43 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Use the alternative with the most descriptive filename containing
a vmlinux file for a given build-id, providing a better title line
for tools such as 'annotate' (Arnaldo Carvalho de Melo)
- Remove help messages about previous right and left arrow keybidings, that
were repurposed for horizontal scrolling (Arnaldo Carvalho de Melo)
- Inform how to reset the symbol filter in the hists browser (top & report)
(Arnaldo Carvalho de Melo)
- Add 'm' key for context menu display in the hists browser, that became
inacessible with the repurposing of the right arrow key for horizontal
scrolling (Namhyung Kim)
- Use debug_frame for callchains if eh_frame is unusable (Rabin Vicent)
Build fixes:
- Fix strict-aliasing breakage with gcc 4.4 in the READ_ONCE/WRITE_ONCE code
adopted from the kernel tree, that builds with -fno-strict-aliasing while
tools/perf/ uses -Wstrict-aliasing=3 (Jiri Olsa)
- Fix unw_word_t pointer casts in code using libunwind for callchains,
fixing the build in at least 32-bit MIPS systems (Rabin Vicent)
- Workaround cross compile build problems related to fixdep (Jiri Olsa)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (3):
perf symbols: Try the .debug/ DSO cache as a last resort
perf ui browsers: Remove help messages about use of right and arrow keys
perf hists browser: Inform how to reset the symbol filter
Jiri Olsa (2):
tools include: Fix strict-aliasing rules breakage
tools build: Fix cross compile build
Namhyung Kim (1):
perf hists browser: Add 'm' key for context menu display
Rabin Vincent (2):
perf callchain: Use debug_frame if eh_frame is unusable
perf callchains: Fix unw_word_t pointer casts
tools/build/Makefile.include | 4 ++++
tools/include/linux/compiler.h | 32 ++++++++++++++++++++++++--------
tools/perf/ui/browsers/annotate.c | 6 +++---
tools/perf/ui/browsers/hists.c | 13 ++++++++-----
tools/perf/ui/browsers/map.c | 2 +-
tools/perf/ui/browsers/scripts.c | 2 +-
tools/perf/util/symbol.c | 18 +++++++++---------
tools/perf/util/unwind-libunwind.c | 14 ++++++++------
8 files changed, 58 insertions(+), 33 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL 0/8] perf/core improvements and fixes
2015-06-17 21:22 Arnaldo Carvalho de Melo
@ 2015-06-18 7:40 ` Ingo Molnar
0 siblings, 0 replies; 33+ messages in thread
From: Ingo Molnar @ 2015-06-18 7:40 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Borislav Petkov, David Ahern,
Don Zickus, Frederic Weisbecker, He Kuang, Jiri Olsa, Li Zhang,
Masami Hiramatsu, Namhyung Kim, Naohiro Aota, Peter Zijlstra,
pi3orama, Stephane Eranian, Sukadev Bhattiprolu, Wang Nan,
Zefan Li, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling, this is on top of perf-core-for-mingo, that is
> still outstanding,
>
> Thanks!
>
> - Arnaldo
>
> The following changes since commit b031220d520238075bd99513a420e65cf37866ad:
>
> perf probe: Fix to return error if no probe is added (2015-06-16 11:39:51 -0300)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-2
>
> for you to fetch changes up to 5d484f99aed547e235f2229653c95392a1bc3692:
>
> perf top: Allow disabling/enabling events dynamicly (2015-06-17 16:50:52 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Allow disabling/enabling events dynamicly in 'perf top':
> a 'perf top' session can instantly become a 'perf report'
> one, i.e. going from dynamic analysis to a static one,
> returning to a dynamic one is possible, to toogle the
> modes, just press CTRL+z. (Arnaldo Carvalho de Melo)
Nice!! :-)
Btw., it would be nice if the status line carried information about whether
collection is 'frozen' or running, at a glance. A hint might also suggest how to
unfreeze the session - in case someone pressed Ctrl-Z to suspend the perf top
session ...
Also, there's now a GUI inconsistency with perf report: which will now exit on
Ctrl-Z. It should probably print a warning in the status line instead, that
freezing/unfreezing only works in 'perf top'.
>
> - Greatly speed up 'perf probe --list' by caching debuginfo
> (Masami Hiramatsu)
>
> - Fix 'perf trace' race condition at the end of started
> workloads (Sukadev Bhattiprolu)
>
> - Fix a problem when opening old perf.data with different
> byte order (Wang Nan)
>
> Infrastructure:
>
> - Ignore .config-detected in .gitignore (Wang Nan)
>
> - Move libtraceevent dynamic list to separated LDFLAGS
> variable (Wang Nan)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (2):
> perf evlist: Add toggle_enable() method
> perf top: Allow disabling/enabling events dynamicly
>
> Masami Hiramatsu (2):
> perf probe: Show usage even if the last event is skipped
> perf probe: Speed up perf probe --list by caching debuginfo
>
> Sukadev Bhattiprolu (1):
> perf trace: Fix race condition at the end of started workloads
>
> Wang Nan (3):
> perf tools: Ignore .config-detected in .gitignore
> perf tools: Fix a problem when opening old perf.data with different byte order
> perf tools: Move libtraceevent dynamic list to separated LDFLAGS variable
>
> tools/perf/.gitignore | 1 +
> tools/perf/Makefile.perf | 8 ++--
> tools/perf/builtin-top.c | 52 ++++++++++++++++++--------
> tools/perf/ui/browsers/hists.c | 2 +
> tools/perf/util/evlist.c | 18 ++++++++-
> tools/perf/util/evlist.h | 2 +
> tools/perf/util/probe-event.c | 83 +++++++++++++++++++++++++++++++-----------
> tools/perf/util/session.c | 50 ++++++++++++++++++-------
> 8 files changed, 160 insertions(+), 56 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 33+ messages in thread
* [GIT PULL 0/8] perf/core improvements and fixes
@ 2015-06-17 21:22 Arnaldo Carvalho de Melo
2015-06-18 7:40 ` Ingo Molnar
0 siblings, 1 reply; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-06-17 21:22 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Borislav Petkov, David Ahern, Don Zickus, Frederic Weisbecker,
He Kuang, Jiri Olsa, Li Zhang, Masami Hiramatsu, Namhyung Kim,
Naohiro Aota, Peter Zijlstra, pi3orama, Stephane Eranian,
Sukadev Bhattiprolu, Wang Nan, Zefan Li,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling, this is on top of perf-core-for-mingo, that is
still outstanding,
Thanks!
- Arnaldo
The following changes since commit b031220d520238075bd99513a420e65cf37866ad:
perf probe: Fix to return error if no probe is added (2015-06-16 11:39:51 -0300)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-2
for you to fetch changes up to 5d484f99aed547e235f2229653c95392a1bc3692:
perf top: Allow disabling/enabling events dynamicly (2015-06-17 16:50:52 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Allow disabling/enabling events dynamicly in 'perf top':
a 'perf top' session can instantly become a 'perf report'
one, i.e. going from dynamic analysis to a static one,
returning to a dynamic one is possible, to toogle the
modes, just press CTRL+z. (Arnaldo Carvalho de Melo)
- Greatly speed up 'perf probe --list' by caching debuginfo
(Masami Hiramatsu)
- Fix 'perf trace' race condition at the end of started
workloads (Sukadev Bhattiprolu)
- Fix a problem when opening old perf.data with different
byte order (Wang Nan)
Infrastructure:
- Ignore .config-detected in .gitignore (Wang Nan)
- Move libtraceevent dynamic list to separated LDFLAGS
variable (Wang Nan)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (2):
perf evlist: Add toggle_enable() method
perf top: Allow disabling/enabling events dynamicly
Masami Hiramatsu (2):
perf probe: Show usage even if the last event is skipped
perf probe: Speed up perf probe --list by caching debuginfo
Sukadev Bhattiprolu (1):
perf trace: Fix race condition at the end of started workloads
Wang Nan (3):
perf tools: Ignore .config-detected in .gitignore
perf tools: Fix a problem when opening old perf.data with different byte order
perf tools: Move libtraceevent dynamic list to separated LDFLAGS variable
tools/perf/.gitignore | 1 +
tools/perf/Makefile.perf | 8 ++--
tools/perf/builtin-top.c | 52 ++++++++++++++++++--------
tools/perf/ui/browsers/hists.c | 2 +
tools/perf/util/evlist.c | 18 ++++++++-
tools/perf/util/evlist.h | 2 +
tools/perf/util/probe-event.c | 83 +++++++++++++++++++++++++++++++-----------
tools/perf/util/session.c | 50 ++++++++++++++++++-------
8 files changed, 160 insertions(+), 56 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL 0/8] perf/core improvements and fixes
2014-10-01 19:50 ` Arnaldo Carvalho de Melo
@ 2014-10-03 3:31 ` Ingo Molnar
-1 siblings, 0 replies; 33+ messages in thread
From: Ingo Molnar @ 2014-10-03 3:31 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Andi Kleen, Chang Hyun Park,
David Ahern, Davidlohr Bueso, Don Zickus, Douglas Hatch,
Frederic Weisbecker, H . Peter Anvin, Jean Pihet, Jiri Olsa,
linux-arm-kernel, Matt Fleming, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Scott J Norton, Stephane Eranian,
Thomas Gleixner, Waiman Long, Will Deacon,
Arnaldo Carvalho de Melo, Peter Zijlstra
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> Best Regards,
>
> - Arnaldo
>
> The following changes since commit 07394b5f13a04f86b27e0ddd96a36c7d9bfe1a4f:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-09-27 09:15:48 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 281f92f233a59ef52bb45287242bd815a67f5647:
>
> perf record: Fix error message for --filter option not coming after tracepoint (2014-10-01 15:05:32 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> . Fix mmap return address truncation to 32-bit in 'perf trace'. (Chang Hyun Park)
>
> o Support operations for shared futexes. (Davidlohr Bueso)
>
> . Fix error message for --filter option not coming after tracepoint. (Arnaldo Carvalho de Melo)
>
> Infrastructure:
>
> . Refactor unit and scale function parameters for pmu parsing routines. (Matt Fleming)
>
> . Improve DSO long names lookup with rbtree, resulting in great speedup for
> workloads with lots of DSOs. (Waiman Long)
>
> . Fix build breakage on arm64 targets. (Will Deacon)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf record: Fix error message for --filter option not coming after tracepoint
>
> Chang Hyun Park (1):
> perf trace: Fix mmap return address truncation to 32-bit
>
> Davidlohr Bueso (2):
> perf bench futex: Support operations for shared futexes
> perf bench futex: Sanitize -q option in requeue
>
> Matt Fleming (1):
> perf tools: Refactor unit and scale function parameters
>
> Waiman Long (2):
> perf symbols: Encapsulate dsos list head into struct dsos
> perf symbols: Improve DSO long names lookup speed with rbtree
>
> Will Deacon (1):
> perf tools: Fix build breakage on arm64 targets
>
> tools/perf/arch/arm64/util/unwind-libunwind.c | 1 +
> tools/perf/bench/futex-hash.c | 7 ++-
> tools/perf/bench/futex-requeue.c | 28 +++++----
> tools/perf/bench/futex-wake.c | 15 +++--
> tools/perf/builtin-trace.c | 6 +-
> tools/perf/util/dso.c | 85 +++++++++++++++++++++++----
> tools/perf/util/dso.h | 16 ++++-
> tools/perf/util/header.c | 32 +++++-----
> tools/perf/util/machine.c | 25 ++++----
> tools/perf/util/machine.h | 5 +-
> tools/perf/util/parse-events.c | 11 ++--
> tools/perf/util/pmu.c | 38 +++++++-----
> tools/perf/util/pmu.h | 7 ++-
> tools/perf/util/probe-event.c | 3 +-
> tools/perf/util/symbol-elf.c | 7 ++-
> 15 files changed, 200 insertions(+), 86 deletions(-)
Pulled into tip:perf/core, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 33+ messages in thread
* [GIT PULL 0/8] perf/core improvements and fixes
@ 2014-10-03 3:31 ` Ingo Molnar
0 siblings, 0 replies; 33+ messages in thread
From: Ingo Molnar @ 2014-10-03 3:31 UTC (permalink / raw)
To: linux-arm-kernel
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> Best Regards,
>
> - Arnaldo
>
> The following changes since commit 07394b5f13a04f86b27e0ddd96a36c7d9bfe1a4f:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-09-27 09:15:48 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 281f92f233a59ef52bb45287242bd815a67f5647:
>
> perf record: Fix error message for --filter option not coming after tracepoint (2014-10-01 15:05:32 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> . Fix mmap return address truncation to 32-bit in 'perf trace'. (Chang Hyun Park)
>
> o Support operations for shared futexes. (Davidlohr Bueso)
>
> . Fix error message for --filter option not coming after tracepoint. (Arnaldo Carvalho de Melo)
>
> Infrastructure:
>
> . Refactor unit and scale function parameters for pmu parsing routines. (Matt Fleming)
>
> . Improve DSO long names lookup with rbtree, resulting in great speedup for
> workloads with lots of DSOs. (Waiman Long)
>
> . Fix build breakage on arm64 targets. (Will Deacon)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> perf record: Fix error message for --filter option not coming after tracepoint
>
> Chang Hyun Park (1):
> perf trace: Fix mmap return address truncation to 32-bit
>
> Davidlohr Bueso (2):
> perf bench futex: Support operations for shared futexes
> perf bench futex: Sanitize -q option in requeue
>
> Matt Fleming (1):
> perf tools: Refactor unit and scale function parameters
>
> Waiman Long (2):
> perf symbols: Encapsulate dsos list head into struct dsos
> perf symbols: Improve DSO long names lookup speed with rbtree
>
> Will Deacon (1):
> perf tools: Fix build breakage on arm64 targets
>
> tools/perf/arch/arm64/util/unwind-libunwind.c | 1 +
> tools/perf/bench/futex-hash.c | 7 ++-
> tools/perf/bench/futex-requeue.c | 28 +++++----
> tools/perf/bench/futex-wake.c | 15 +++--
> tools/perf/builtin-trace.c | 6 +-
> tools/perf/util/dso.c | 85 +++++++++++++++++++++++----
> tools/perf/util/dso.h | 16 ++++-
> tools/perf/util/header.c | 32 +++++-----
> tools/perf/util/machine.c | 25 ++++----
> tools/perf/util/machine.h | 5 +-
> tools/perf/util/parse-events.c | 11 ++--
> tools/perf/util/pmu.c | 38 +++++++-----
> tools/perf/util/pmu.h | 7 ++-
> tools/perf/util/probe-event.c | 3 +-
> tools/perf/util/symbol-elf.c | 7 ++-
> 15 files changed, 200 insertions(+), 86 deletions(-)
Pulled into tip:perf/core, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 33+ messages in thread
* [GIT PULL 0/8] perf/core improvements and fixes
@ 2014-10-01 19:50 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-10-01 19:50 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Chang Hyun Park, David Ahern, Davidlohr Bueso,
Don Zickus, Douglas Hatch, Frederic Weisbecker, H . Peter Anvin,
Jean Pihet, Jiri Olsa, linux-arm-kernel, Matt Fleming,
Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Scott J Norton, Stephane Eranian, Thomas Gleixner, Waiman Long,
Will Deacon, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
Best Regards,
- Arnaldo
The following changes since commit 07394b5f13a04f86b27e0ddd96a36c7d9bfe1a4f:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-09-27 09:15:48 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 281f92f233a59ef52bb45287242bd815a67f5647:
perf record: Fix error message for --filter option not coming after tracepoint (2014-10-01 15:05:32 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
. Fix mmap return address truncation to 32-bit in 'perf trace'. (Chang Hyun Park)
o Support operations for shared futexes. (Davidlohr Bueso)
. Fix error message for --filter option not coming after tracepoint. (Arnaldo Carvalho de Melo)
Infrastructure:
. Refactor unit and scale function parameters for pmu parsing routines. (Matt Fleming)
. Improve DSO long names lookup with rbtree, resulting in great speedup for
workloads with lots of DSOs. (Waiman Long)
. Fix build breakage on arm64 targets. (Will Deacon)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf record: Fix error message for --filter option not coming after tracepoint
Chang Hyun Park (1):
perf trace: Fix mmap return address truncation to 32-bit
Davidlohr Bueso (2):
perf bench futex: Support operations for shared futexes
perf bench futex: Sanitize -q option in requeue
Matt Fleming (1):
perf tools: Refactor unit and scale function parameters
Waiman Long (2):
perf symbols: Encapsulate dsos list head into struct dsos
perf symbols: Improve DSO long names lookup speed with rbtree
Will Deacon (1):
perf tools: Fix build breakage on arm64 targets
tools/perf/arch/arm64/util/unwind-libunwind.c | 1 +
tools/perf/bench/futex-hash.c | 7 ++-
tools/perf/bench/futex-requeue.c | 28 +++++----
tools/perf/bench/futex-wake.c | 15 +++--
tools/perf/builtin-trace.c | 6 +-
tools/perf/util/dso.c | 85 +++++++++++++++++++++++----
tools/perf/util/dso.h | 16 ++++-
tools/perf/util/header.c | 32 +++++-----
tools/perf/util/machine.c | 25 ++++----
tools/perf/util/machine.h | 5 +-
tools/perf/util/parse-events.c | 11 ++--
tools/perf/util/pmu.c | 38 +++++++-----
tools/perf/util/pmu.h | 7 ++-
tools/perf/util/probe-event.c | 3 +-
tools/perf/util/symbol-elf.c | 7 ++-
15 files changed, 200 insertions(+), 86 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* [GIT PULL 0/8] perf/core improvements and fixes
@ 2014-10-01 19:50 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-10-01 19:50 UTC (permalink / raw)
To: linux-arm-kernel
Hi Ingo,
Please consider pulling,
Best Regards,
- Arnaldo
The following changes since commit 07394b5f13a04f86b27e0ddd96a36c7d9bfe1a4f:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-09-27 09:15:48 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 281f92f233a59ef52bb45287242bd815a67f5647:
perf record: Fix error message for --filter option not coming after tracepoint (2014-10-01 15:05:32 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
. Fix mmap return address truncation to 32-bit in 'perf trace'. (Chang Hyun Park)
o Support operations for shared futexes. (Davidlohr Bueso)
. Fix error message for --filter option not coming after tracepoint. (Arnaldo Carvalho de Melo)
Infrastructure:
. Refactor unit and scale function parameters for pmu parsing routines. (Matt Fleming)
. Improve DSO long names lookup with rbtree, resulting in great speedup for
workloads with lots of DSOs. (Waiman Long)
. Fix build breakage on arm64 targets. (Will Deacon)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
perf record: Fix error message for --filter option not coming after tracepoint
Chang Hyun Park (1):
perf trace: Fix mmap return address truncation to 32-bit
Davidlohr Bueso (2):
perf bench futex: Support operations for shared futexes
perf bench futex: Sanitize -q option in requeue
Matt Fleming (1):
perf tools: Refactor unit and scale function parameters
Waiman Long (2):
perf symbols: Encapsulate dsos list head into struct dsos
perf symbols: Improve DSO long names lookup speed with rbtree
Will Deacon (1):
perf tools: Fix build breakage on arm64 targets
tools/perf/arch/arm64/util/unwind-libunwind.c | 1 +
tools/perf/bench/futex-hash.c | 7 ++-
tools/perf/bench/futex-requeue.c | 28 +++++----
tools/perf/bench/futex-wake.c | 15 +++--
tools/perf/builtin-trace.c | 6 +-
tools/perf/util/dso.c | 85 +++++++++++++++++++++++----
tools/perf/util/dso.h | 16 ++++-
tools/perf/util/header.c | 32 +++++-----
tools/perf/util/machine.c | 25 ++++----
tools/perf/util/machine.h | 5 +-
tools/perf/util/parse-events.c | 11 ++--
tools/perf/util/pmu.c | 38 +++++++-----
tools/perf/util/pmu.h | 7 ++-
tools/perf/util/probe-event.c | 3 +-
tools/perf/util/symbol-elf.c | 7 ++-
15 files changed, 200 insertions(+), 86 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL 0/8] perf/core improvements and fixes
2014-05-19 12:30 Jiri Olsa
@ 2014-05-20 6:37 ` Ingo Molnar
0 siblings, 0 replies; 33+ messages in thread
From: Ingo Molnar @ 2014-05-20 6:37 UTC (permalink / raw)
To: Jiri Olsa
Cc: linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Dongsheng Yang, Frederic Weisbecker, Jean Pihet,
Masanari Iida, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Peter Zijlstra, Will Deacon
* Jiri Olsa <jolsa@kernel.org> wrote:
> hi Ingo,
> please consider pulling
>
> thanks,
> jirka
>
>
> The following changes since commit 26f273802b6ed28e059f4359bc7711dffceda022:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-05-12 17:57:48 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 97eac381b113932bd7bd4a5c3c68b18e9ff7a2a0:
>
> perf tools: Add libdw DWARF post unwind support for ARM (2014-05-16 11:39:29 +0200)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> . Add libdw DWARF post unwind support for ARM (Jean Pihet)
>
> . Consolidate types.h for ARM and ARM64 (Jean Pihet)
>
> . Fix possible null pointer dereference in session.c (Masanari Iida)
>
> . Cleanup, remove unused variables in map_switch_event() (Dongsheng Yang)
>
> . Remove nr_state_machine_bugs in perf latency (Dongsheng Yang)
>
> . Remove usage of trace_sched_wakeup(.success) (Peter Zijlstra)
>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
>
> ----------------------------------------------------------------
> Dongsheng Yang (2):
> perf sched: Remove nr_state_machine_bugs in perf latency
> perf sched: Cleanup, remove unused variables in map_switch_event()
>
> Jean Pihet (4):
> perf tools: Consolidate types.h for ARM and ARM64
> perf tests: Introduce perf_regs_load function on ARM
> perf tests: Add dwarf unwind test on ARM
> perf tools: Add libdw DWARF post unwind support for ARM
>
> Masanari Iida (1):
> perf session: Fix possible null pointer dereference in session.c
>
> Peter Zijlstra (1):
> perf tools: Remove usage of trace_sched_wakeup(.success)
>
> tools/perf/Makefile.perf | 2 +-
> tools/perf/arch/arm/Makefile | 7 ++++
> tools/perf/arch/arm/include/perf_regs.h | 7 +++-
> tools/perf/arch/arm/tests/dwarf-unwind.c | 60 +++++++++++++++++++++++++++++++
> tools/perf/arch/arm/tests/regs_load.S | 58 ++++++++++++++++++++++++++++++
> tools/perf/arch/arm/util/unwind-libdw.c | 36 +++++++++++++++++++
> tools/perf/arch/arm64/include/perf_regs.h | 2 +-
> tools/perf/builtin-sched.c | 32 ++++++-----------
> tools/perf/config/Makefile | 4 +--
> tools/perf/tests/builtin-test.c | 2 +-
> tools/perf/tests/evsel-tp-sched.c | 3 --
> tools/perf/tests/tests.h | 2 +-
> tools/perf/util/session.c | 5 +--
> 13 files changed, 187 insertions(+), 33 deletions(-)
> create mode 100644 tools/perf/arch/arm/tests/dwarf-unwind.c
> create mode 100644 tools/perf/arch/arm/tests/regs_load.S
> create mode 100644 tools/perf/arch/arm/util/unwind-libdw.c
Pulled, thanks a lot Jiri!
Ingo
^ permalink raw reply [flat|nested] 33+ messages in thread
* [GIT PULL 0/8] perf/core improvements and fixes
@ 2014-05-19 12:30 Jiri Olsa
2014-05-20 6:37 ` Ingo Molnar
0 siblings, 1 reply; 33+ messages in thread
From: Jiri Olsa @ 2014-05-19 12:30 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Dongsheng Yang, Frederic Weisbecker, Jean Pihet,
Masanari Iida, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Peter Zijlstra, Will Deacon, Jiri Olsa
hi Ingo,
please consider pulling
thanks,
jirka
The following changes since commit 26f273802b6ed28e059f4359bc7711dffceda022:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-05-12 17:57:48 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
for you to fetch changes up to 97eac381b113932bd7bd4a5c3c68b18e9ff7a2a0:
perf tools: Add libdw DWARF post unwind support for ARM (2014-05-16 11:39:29 +0200)
----------------------------------------------------------------
perf/core improvements and fixes:
. Add libdw DWARF post unwind support for ARM (Jean Pihet)
. Consolidate types.h for ARM and ARM64 (Jean Pihet)
. Fix possible null pointer dereference in session.c (Masanari Iida)
. Cleanup, remove unused variables in map_switch_event() (Dongsheng Yang)
. Remove nr_state_machine_bugs in perf latency (Dongsheng Yang)
. Remove usage of trace_sched_wakeup(.success) (Peter Zijlstra)
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
----------------------------------------------------------------
Dongsheng Yang (2):
perf sched: Remove nr_state_machine_bugs in perf latency
perf sched: Cleanup, remove unused variables in map_switch_event()
Jean Pihet (4):
perf tools: Consolidate types.h for ARM and ARM64
perf tests: Introduce perf_regs_load function on ARM
perf tests: Add dwarf unwind test on ARM
perf tools: Add libdw DWARF post unwind support for ARM
Masanari Iida (1):
perf session: Fix possible null pointer dereference in session.c
Peter Zijlstra (1):
perf tools: Remove usage of trace_sched_wakeup(.success)
tools/perf/Makefile.perf | 2 +-
tools/perf/arch/arm/Makefile | 7 ++++
tools/perf/arch/arm/include/perf_regs.h | 7 +++-
tools/perf/arch/arm/tests/dwarf-unwind.c | 60 +++++++++++++++++++++++++++++++
tools/perf/arch/arm/tests/regs_load.S | 58 ++++++++++++++++++++++++++++++
tools/perf/arch/arm/util/unwind-libdw.c | 36 +++++++++++++++++++
tools/perf/arch/arm64/include/perf_regs.h | 2 +-
tools/perf/builtin-sched.c | 32 ++++++-----------
tools/perf/config/Makefile | 4 +--
tools/perf/tests/builtin-test.c | 2 +-
tools/perf/tests/evsel-tp-sched.c | 3 --
tools/perf/tests/tests.h | 2 +-
tools/perf/util/session.c | 5 +--
13 files changed, 187 insertions(+), 33 deletions(-)
create mode 100644 tools/perf/arch/arm/tests/dwarf-unwind.c
create mode 100644 tools/perf/arch/arm/tests/regs_load.S
create mode 100644 tools/perf/arch/arm/util/unwind-libdw.c
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [GIT PULL 0/8] perf/core improvements and fixes
2012-09-06 19:31 Arnaldo Carvalho de Melo
@ 2012-09-07 5:39 ` Ingo Molnar
0 siblings, 0 replies; 33+ messages in thread
From: Ingo Molnar @ 2012-09-07 5:39 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Corey Ashford, David Ahern, Frederic Weisbecker,
Ingo Molnar, Jiri Olsa, Joel Uckelman, Mike Galbraith,
Namhyung Kim, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Stephane Eranian, Steven Rostedt, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 7a4ec938857cf534270b23545495300fbac7f5de:
>
> perf tools: Allow user to indicate path to objdump in command line (2012-09-05 19:41:55 -0300)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
>
> for you to fetch changes up to 275ef3878f698941353780440fec6926107a320b:
>
> perf tools: Fix cache event name generation (2012-09-06 15:01:08 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes
>
> . Fix hardware cache event name generation, fix from Jiri Olsa
>
> . Add round trip test for sw, hw and cache event names, catching the
> problem Jiri fixed, after Jiri's patch, the test passes successfully.
>
> . Clean target should do clean for lib/traceevent too, fix from David Ahern
>
> . Check the right variable for allocation failure, fix from Namhyung Kim
>
> . Set up evsel->tp_format regardless of evsel->name being set already,
> fix from Namhyung Kim
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (4):
> perf test: Add round trip test for sw and hw event names
> perf tools: Remove extraneous newline when parsing hardware cache events
> perf evlist: Add fprintf method
> perf test: Add roundtrip test for hardware cache events
>
> David Ahern (1):
> perf tools: Clean target should do clean for lib/traceevent too
>
> Jiri Olsa (1):
> perf tools: Fix cache event name generation
>
> Namhyung Kim (2):
> perf header: Fix a typo on evsel
> perf header: Prepare tracepoint events regardless of name
>
> tools/perf/Makefile | 5 +-
> tools/perf/builtin-test.c | 114 ++++++++++++++++++++++++++++++++++++++++
> tools/perf/util/evlist.c | 13 +++++
> tools/perf/util/evlist.h | 2 +
> tools/perf/util/evsel.c | 6 +--
> tools/perf/util/evsel.h | 6 ++-
> tools/perf/util/header.c | 36 ++++++++-----
> tools/perf/util/parse-events.c | 2 +-
> 8 files changed, 163 insertions(+), 21 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 33+ messages in thread
* [GIT PULL 0/8] perf/core improvements and fixes
@ 2012-09-06 19:31 Arnaldo Carvalho de Melo
2012-09-07 5:39 ` Ingo Molnar
0 siblings, 1 reply; 33+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-09-06 19:31 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Frederic Weisbecker, Ingo Molnar, Jiri Olsa,
Joel Uckelman, Mike Galbraith, Namhyung Kim, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian, Steven Rostedt,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 7a4ec938857cf534270b23545495300fbac7f5de:
perf tools: Allow user to indicate path to objdump in command line (2012-09-05 19:41:55 -0300)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
for you to fetch changes up to 275ef3878f698941353780440fec6926107a320b:
perf tools: Fix cache event name generation (2012-09-06 15:01:08 -0300)
----------------------------------------------------------------
perf/core improvements and fixes
. Fix hardware cache event name generation, fix from Jiri Olsa
. Add round trip test for sw, hw and cache event names, catching the
problem Jiri fixed, after Jiri's patch, the test passes successfully.
. Clean target should do clean for lib/traceevent too, fix from David Ahern
. Check the right variable for allocation failure, fix from Namhyung Kim
. Set up evsel->tp_format regardless of evsel->name being set already,
fix from Namhyung Kim
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (4):
perf test: Add round trip test for sw and hw event names
perf tools: Remove extraneous newline when parsing hardware cache events
perf evlist: Add fprintf method
perf test: Add roundtrip test for hardware cache events
David Ahern (1):
perf tools: Clean target should do clean for lib/traceevent too
Jiri Olsa (1):
perf tools: Fix cache event name generation
Namhyung Kim (2):
perf header: Fix a typo on evsel
perf header: Prepare tracepoint events regardless of name
tools/perf/Makefile | 5 +-
tools/perf/builtin-test.c | 114 ++++++++++++++++++++++++++++++++++++++++
tools/perf/util/evlist.c | 13 +++++
tools/perf/util/evlist.h | 2 +
tools/perf/util/evsel.c | 6 +--
tools/perf/util/evsel.h | 6 ++-
tools/perf/util/header.c | 36 ++++++++-----
tools/perf/util/parse-events.c | 2 +-
8 files changed, 163 insertions(+), 21 deletions(-)
^ permalink raw reply [flat|nested] 33+ messages in thread
end of thread, other threads:[~2018-03-29 7:23 UTC | newest]
Thread overview: 33+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-15 15:28 [GIT PULL 0/8] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 1/8] perf probe: Free perf_probe_event in cleanup_perf_probe_events() Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 2/8] perf probe: Export init/exit_probe_symbol_maps() Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 3/8] tools: Add err.h with ERR_PTR PTR_ERR interface Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 4/8] perf tools: Propagate error info for the tracepoint parsing Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 5/8] perf evsel: Propagate error info from tp_format Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 6/8] perf tools: Enhance parsing events tracepoint error output Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 7/8] perf tools: regs_query_register_offset() infrastructure Arnaldo Carvalho de Melo
2015-09-15 15:28 ` [PATCH 8/8] perf tools: Introduce regs_query_register_offset() for x86 Arnaldo Carvalho de Melo
2015-09-16 7:25 ` [GIT PULL 0/8] perf/core improvements and fixes Ingo Molnar
2015-09-16 13:50 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2018-03-28 18:49 Arnaldo Carvalho de Melo
2018-03-29 7:23 ` Ingo Molnar
2017-10-03 12:55 Arnaldo Carvalho de Melo
2017-10-03 16:38 ` Ingo Molnar
2016-01-15 21:40 Arnaldo Carvalho de Melo
2016-01-19 7:32 ` Ingo Molnar
2015-10-29 23:05 Arnaldo Carvalho de Melo
2015-10-30 9:10 ` Ingo Molnar
2015-10-22 22:14 Arnaldo Carvalho de Melo
2015-10-23 8:28 ` Ingo Molnar
2015-10-13 19:41 Arnaldo Carvalho de Melo
2015-10-14 13:09 ` Ingo Molnar
2015-06-17 21:22 Arnaldo Carvalho de Melo
2015-06-18 7:40 ` Ingo Molnar
2014-10-01 19:50 Arnaldo Carvalho de Melo
2014-10-01 19:50 ` Arnaldo Carvalho de Melo
2014-10-03 3:31 ` Ingo Molnar
2014-10-03 3:31 ` Ingo Molnar
2014-05-19 12:30 Jiri Olsa
2014-05-20 6:37 ` Ingo Molnar
2012-09-06 19:31 Arnaldo Carvalho de Melo
2012-09-07 5:39 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.