* [patch 1/4] drm/qxl: integer overflow in qxl_process_single_command()
@ 2015-09-17 11:23 Dan Carpenter
2015-09-18 9:50 ` Frediano Ziglio
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-09-17 11:23 UTC (permalink / raw)
To: David Airlie, Ilja Van Sprundel
Cc: Dave Airlie, security, dri-devel, Frediano Ziglio
This size calculation can overflow on 32 bit systems leading to memory
corruption.
Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/qxl/qxl_ioctl.c b/drivers/gpu/drm/qxl/qxl_ioctl.c
index bda5c5f..eda6f30 100644
--- a/drivers/gpu/drm/qxl/qxl_ioctl.c
+++ b/drivers/gpu/drm/qxl/qxl_ioctl.c
@@ -168,7 +168,7 @@ static int qxl_process_single_command(struct qxl_device *qdev,
cmd->command_size))
return -EFAULT;
- reloc_info = kmalloc(sizeof(struct qxl_reloc_info) * cmd->relocs_num, GFP_KERNEL);
+ reloc_info = kmalloc_array(cmd->relocs_num, sizeof(struct qxl_reloc_info), GFP_KERNEL);
if (!reloc_info)
return -ENOMEM;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 1/4] drm/qxl: integer overflow in qxl_process_single_command()
2015-09-17 11:23 [patch 1/4] drm/qxl: integer overflow in qxl_process_single_command() Dan Carpenter
@ 2015-09-18 9:50 ` Frediano Ziglio
0 siblings, 0 replies; 2+ messages in thread
From: Frediano Ziglio @ 2015-09-18 9:50 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Dave Airlie, security, Ilja Van Sprundel, dri-devel
>
> This size calculation can overflow on 32 bit systems leading to memory
> corruption.
>
> Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/qxl/qxl_ioctl.c
> b/drivers/gpu/drm/qxl/qxl_ioctl.c
> index bda5c5f..eda6f30 100644
> --- a/drivers/gpu/drm/qxl/qxl_ioctl.c
> +++ b/drivers/gpu/drm/qxl/qxl_ioctl.c
> @@ -168,7 +168,7 @@ static int qxl_process_single_command(struct qxl_device
> *qdev,
> cmd->command_size))
> return -EFAULT;
>
> - reloc_info = kmalloc(sizeof(struct qxl_reloc_info) * cmd->relocs_num,
> GFP_KERNEL);
> + reloc_info = kmalloc_array(cmd->relocs_num, sizeof(struct qxl_reloc_info),
> GFP_KERNEL);
> if (!reloc_info)
> return -ENOMEM;
>
>
Looks fine.
Acked.
Frediano
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-18 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-17 11:23 [patch 1/4] drm/qxl: integer overflow in qxl_process_single_command() Dan Carpenter
2015-09-18 9:50 ` Frediano Ziglio
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.