* [PATCH] powerpc: mpc512x: drop bogus and unused psc register bit definitions
@ 2015-07-21 7:21 Uwe Kleine-König
2015-09-18 6:36 ` Uwe Kleine-König
2015-10-22 14:09 ` Anatolij Gustschin
0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2015-07-21 7:21 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman
Cc: linuxppc-dev, kernel
These were introduced in commit 25ae3a0739c6 ("[POWERPC] mpc512x: Add
MPC512x PSC support to MPC52xx psc driver") and never used. Moreover
according to the datasheet[1] MEMERROR is bit 25 (0x40) and ORERR is
bit 27 (0x10).
[1] MPC5125RM Rev. 2; 11/2009
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/powerpc/include/asm/mpc52xx_psc.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/include/asm/mpc52xx_psc.h b/arch/powerpc/include/asm/mpc52xx_psc.h
index d0ece257d310..92806c24c2c5 100644
--- a/arch/powerpc/include/asm/mpc52xx_psc.h
+++ b/arch/powerpc/include/asm/mpc52xx_psc.h
@@ -258,8 +258,6 @@ struct mpc52xx_psc_fifo {
#define MPC512x_PSC_FIFO_FULL 0x2
#define MPC512x_PSC_FIFO_ALARM 0x4
#define MPC512x_PSC_FIFO_URERR 0x8
-#define MPC512x_PSC_FIFO_ORERR 0x01
-#define MPC512x_PSC_FIFO_MEMERROR 0x02
struct mpc512x_psc_fifo {
u32 reserved1[10];
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: mpc512x: drop bogus and unused psc register bit definitions
2015-07-21 7:21 [PATCH] powerpc: mpc512x: drop bogus and unused psc register bit definitions Uwe Kleine-König
@ 2015-09-18 6:36 ` Uwe Kleine-König
2015-10-22 14:09 ` Anatolij Gustschin
1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2015-09-18 6:36 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman
Cc: linuxppc-dev, kernel
Hello,
On Tue, Jul 21, 2015 at 09:21:13AM +0200, Uwe Kleine-König wrote:
> These were introduced in commit 25ae3a0739c6 ("[POWERPC] mpc512x: Add
> MPC512x PSC support to MPC52xx psc driver") and never used. Moreover
> according to the datasheet[1] MEMERROR is bit 25 (0x40) and ORERR is
> bit 27 (0x10).
>
> [1] MPC5125RM Rev. 2; 11/2009
I didn't get any feedback for this patch yet. Do you still consider it?
Best regards
Uwe
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> arch/powerpc/include/asm/mpc52xx_psc.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/mpc52xx_psc.h b/arch/powerpc/include/asm/mpc52xx_psc.h
> index d0ece257d310..92806c24c2c5 100644
> --- a/arch/powerpc/include/asm/mpc52xx_psc.h
> +++ b/arch/powerpc/include/asm/mpc52xx_psc.h
> @@ -258,8 +258,6 @@ struct mpc52xx_psc_fifo {
> #define MPC512x_PSC_FIFO_FULL 0x2
> #define MPC512x_PSC_FIFO_ALARM 0x4
> #define MPC512x_PSC_FIFO_URERR 0x8
> -#define MPC512x_PSC_FIFO_ORERR 0x01
> -#define MPC512x_PSC_FIFO_MEMERROR 0x02
>
> struct mpc512x_psc_fifo {
> u32 reserved1[10];
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: mpc512x: drop bogus and unused psc register bit definitions
2015-07-21 7:21 [PATCH] powerpc: mpc512x: drop bogus and unused psc register bit definitions Uwe Kleine-König
2015-09-18 6:36 ` Uwe Kleine-König
@ 2015-10-22 14:09 ` Anatolij Gustschin
1 sibling, 0 replies; 3+ messages in thread
From: Anatolij Gustschin @ 2015-10-22 14:09 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
linuxppc-dev, kernel
On Tue, 21 Jul 2015 09:21:13 +0200
Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de> wrote:
> These were introduced in commit 25ae3a0739c6 ("[POWERPC] mpc512x: Add
> MPC512x PSC support to MPC52xx psc driver") and never used. Moreover
> according to the datasheet[1] MEMERROR is bit 25 (0x40) and ORERR is
> bit 27 (0x10).
>=20
> [1] MPC5125RM Rev. 2; 11/2009
>=20
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> ---
> arch/powerpc/include/asm/mpc52xx_psc.h | 2 --
> 1 file changed, 2 deletions(-)
applied to mpc5xxx/next.
Thanks,
Anatolij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-22 14:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-21 7:21 [PATCH] powerpc: mpc512x: drop bogus and unused psc register bit definitions Uwe Kleine-König
2015-09-18 6:36 ` Uwe Kleine-König
2015-10-22 14:09 ` Anatolij Gustschin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.