All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 2/5] ARM: dts: sun5i: Add PWM channel 0 pinmux setting for A13/A10s
Date: Tue, 22 Sep 2015 16:29:44 +0200	[thread overview]
Message-ID: <20150922142944.GD4684@lukather> (raw)
In-Reply-To: <1442752251-20744-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

On Sun, Sep 20, 2015 at 08:30:48AM -0400, Hans de Goede wrote:
> Add a pinmux setting for the first pwm channel. This is often used for
> backlight dimming on tablets.
> 
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  arch/arm/boot/dts/sun5i.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi
> index 5e036a4..f0714d3 100644
> --- a/arch/arm/boot/dts/sun5i.dtsi
> +++ b/arch/arm/boot/dts/sun5i.dtsi
> @@ -529,6 +529,13 @@
>  				allwinner,drive = <SUN4I_PINCTRL_30_MA>;
>  				allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
>  			};
> +
> +			pwm0_pins: pwm0 {

Is there a reason why you call this pinset pwm0, while it looks like
there's a single pwm controller?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] ARM: dts: sun5i: Add PWM channel 0 pinmux setting for A13/A10s
Date: Tue, 22 Sep 2015 16:29:44 +0200	[thread overview]
Message-ID: <20150922142944.GD4684@lukather> (raw)
In-Reply-To: <1442752251-20744-3-git-send-email-hdegoede@redhat.com>

On Sun, Sep 20, 2015 at 08:30:48AM -0400, Hans de Goede wrote:
> Add a pinmux setting for the first pwm channel. This is often used for
> backlight dimming on tablets.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  arch/arm/boot/dts/sun5i.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi
> index 5e036a4..f0714d3 100644
> --- a/arch/arm/boot/dts/sun5i.dtsi
> +++ b/arch/arm/boot/dts/sun5i.dtsi
> @@ -529,6 +529,13 @@
>  				allwinner,drive = <SUN4I_PINCTRL_30_MA>;
>  				allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
>  			};
> +
> +			pwm0_pins: pwm0 {

Is there a reason why you call this pinset pwm0, while it looks like
there's a single pwm controller?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150922/86ee2f9f/attachment.sig>

  parent reply	other threads:[~2015-09-22 14:29 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-20 12:30 [PATCH 0/5] ARM: dts: sunxi: Add backlight node to q8 tablets Hans de Goede
2015-09-20 12:30 ` Hans de Goede
     [not found] ` <1442752251-20744-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-20 12:30   ` [PATCH 1/5] ARM: dts: sun5i: Add PWM controller node for A13/A10s Hans de Goede
2015-09-20 12:30     ` Hans de Goede
     [not found]     ` <1442752251-20744-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-22 14:28       ` Maxime Ripard
2015-09-22 14:28         ` Maxime Ripard
2015-09-20 12:30   ` [PATCH 2/5] ARM: dts: sun5i: Add PWM channel 0 pinmux setting " Hans de Goede
2015-09-20 12:30     ` Hans de Goede
     [not found]     ` <1442752251-20744-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-22 14:29       ` Maxime Ripard [this message]
2015-09-22 14:29         ` Maxime Ripard
2015-09-20 12:30   ` [PATCH 3/5] ARM: dts: sunxi: Enable PWM controller on Q8 format tablets Hans de Goede
2015-09-20 12:30     ` Hans de Goede
2015-09-20 12:30   ` [PATCH 4/5] ARM: dts: sun8i: Add pwm-backlight device for A23/A33 " Hans de Goede
2015-09-20 12:30     ` Hans de Goede
     [not found]     ` <1442752251-20744-5-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-22 14:44       ` Maxime Ripard
2015-09-22 14:44         ` Maxime Ripard
2015-09-20 12:30   ` [PATCH 5/5] ARM: dts: sun5i: Add backlight node to sun5i-q8-common.dtsi Hans de Goede
2015-09-20 12:30     ` Hans de Goede
     [not found]     ` <1442752251-20744-6-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-20 14:46       ` Chen-Yu Tsai
2015-09-20 14:46         ` Chen-Yu Tsai
     [not found]         ` <CAGb2v66Bg60p8T3dzF6ymo-rTEMK4yUVZsuaOjCXapPBQRn6eg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-20 15:14           ` Hans de Goede
2015-09-20 15:14             ` [linux-sunxi] " Hans de Goede
     [not found]             ` <55FECD38.9010503-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-20 15:21               ` Hans de Goede
2015-09-20 15:21                 ` [linux-sunxi] " Hans de Goede
2015-12-19 10:54     ` 8001010
2015-12-19 10:54       ` 8001010 at gmail.com
     [not found]       ` <5df61312-cf32-43d4-8aba-485acf66787d-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
2015-12-22  3:21         ` Chen-Yu Tsai
2015-12-22  3:21           ` Chen-Yu Tsai
2015-12-21 10:56   ` [PATCH 0/5] ARM: dts: sunxi: Add backlight node to q8 tablets Silvio Pellicano
     [not found]     ` <fc4adcf5-4362-4d4c-b42e-729922c79f65-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
2015-12-21 12:59       ` Hans de Goede
2015-12-21 12:59         ` [linux-sunxi] " Hans de Goede
     [not found]         ` <5677F7CF.3050308-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-01-01  0:17           ` Silvio Pellicano
2016-01-11 10:34         ` [linux-sunxi] " 8001010
2016-01-11 10:34           ` 8001010
     [not found]           ` <5693852A.1060604-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-11 11:09             ` Hans de Goede
2016-01-11 11:09               ` [linux-sunxi] " Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150922142944.GD4684@lukather \
    --to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.