From: Viresh Kumar <viresh.kumar@linaro.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linaro-kernel@lists.linaro.org,
QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
linux-bluetooth@vger.kernel.org,
iommu@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-usb@vger.kernel.org, linux-edac@vger.kernel.org,
linux-mm@kvack.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'
Date: Fri, 25 Sep 2015 11:52:56 -0700 [thread overview]
Message-ID: <20150925185256.GG5951@linux> (raw)
In-Reply-To: <1443206945.2161.9.camel@sipsolutions.net>
On 25-09-15, 20:49, Johannes Berg wrote:
> Ok, then, but that means Rafael is completely wrong ...
> debugfs_create_bool() takes a *pointer* and it needs to be long-lived,
> it can't be on the stack. You also don't get a call when it changes.
Ahh, ofcourse. My bad as well...
I think we can change structure definition but will wait for Rafael's
comment before that.
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
QCA ath9k Development
<ath9k-devel-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Intel Linux Wireless
<ilw-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'
Date: Fri, 25 Sep 2015 11:52:56 -0700 [thread overview]
Message-ID: <20150925185256.GG5951@linux> (raw)
In-Reply-To: <1443206945.2161.9.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
On 25-09-15, 20:49, Johannes Berg wrote:
> Ok, then, but that means Rafael is completely wrong ...
> debugfs_create_bool() takes a *pointer* and it needs to be long-lived,
> it can't be on the stack. You also don't get a call when it changes.
Ahh, ofcourse. My bad as well...
I think we can change structure definition but will wait for Rafael's
comment before that.
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linaro-kernel@lists.linaro.org,
QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
linux-bluetooth@vger.kernel.org,
iommu@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-usb@vger.kernel.org, linux-edac@vger.kernel.org,
linux-mm@kvack.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'
Date: Fri, 25 Sep 2015 11:52:56 -0700 [thread overview]
Message-ID: <20150925185256.GG5951@linux> (raw)
In-Reply-To: <1443206945.2161.9.camel@sipsolutions.net>
On 25-09-15, 20:49, Johannes Berg wrote:
> Ok, then, but that means Rafael is completely wrong ...
> debugfs_create_bool() takes a *pointer* and it needs to be long-lived,
> it can't be on the stack. You also don't get a call when it changes.
Ahh, ofcourse. My bad as well...
I think we can change structure definition but will wait for Rafael's
comment before that.
--
viresh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'
Date: Fri, 25 Sep 2015 11:52:56 -0700 [thread overview]
Message-ID: <20150925185256.GG5951@linux> (raw)
In-Reply-To: <1443206945.2161.9.camel@sipsolutions.net>
On 25-09-15, 20:49, Johannes Berg wrote:
> Ok, then, but that means Rafael is completely wrong ...
> debugfs_create_bool() takes a *pointer* and it needs to be long-lived,
> it can't be on the stack. You also don't get a call when it changes.
Ahh, ofcourse. My bad as well...
I think we can change structure definition but will wait for Rafael's
comment before that.
--
viresh
next prev parent reply other threads:[~2015-09-25 18:52 UTC|newest]
Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 16:41 [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Viresh Kumar
2015-09-25 16:41 ` Viresh Kumar
2015-09-25 16:41 ` Viresh Kumar
2015-09-25 16:41 ` Viresh Kumar
2015-09-25 16:41 ` [PATCH V4 2/2] debugfs: Pass bool pointer to debugfs_create_bool() Viresh Kumar
2015-09-25 16:41 ` Viresh Kumar
2015-09-25 16:41 ` Viresh Kumar
2015-09-25 17:42 ` [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Johannes Berg
2015-09-25 17:42 ` Johannes Berg
2015-09-25 17:42 ` Johannes Berg
2015-09-25 17:42 ` Johannes Berg
2015-09-25 18:47 ` Viresh Kumar
2015-09-25 18:47 ` Viresh Kumar
2015-09-25 18:47 ` Viresh Kumar
2015-09-25 18:47 ` Viresh Kumar
2015-09-25 18:49 ` Johannes Berg
2015-09-25 18:49 ` Johannes Berg
2015-09-25 18:49 ` Johannes Berg
2015-09-25 18:52 ` Viresh Kumar [this message]
2015-09-25 18:52 ` Viresh Kumar
2015-09-25 18:52 ` Viresh Kumar
2015-09-25 18:52 ` Viresh Kumar
2015-09-25 20:26 ` Rafael J. Wysocki
2015-09-25 20:26 ` Rafael J. Wysocki
2015-09-25 20:26 ` Rafael J. Wysocki
2015-09-25 20:33 ` Rafael J. Wysocki
2015-09-25 20:33 ` Rafael J. Wysocki
2015-09-25 20:33 ` Rafael J. Wysocki
2015-09-25 20:33 ` Rafael J. Wysocki
2015-09-25 20:25 ` Viresh Kumar
2015-09-25 20:25 ` Viresh Kumar
2015-09-25 20:25 ` Viresh Kumar
2015-09-25 20:25 ` Viresh Kumar
2015-09-25 20:25 ` Viresh Kumar
2015-09-25 20:25 ` Viresh Kumar
2015-09-25 20:58 ` Rafael J. Wysocki
2015-09-25 20:58 ` Rafael J. Wysocki
2015-09-25 20:58 ` Rafael J. Wysocki
2015-09-25 20:58 ` Rafael J. Wysocki
2015-09-25 20:58 ` Rafael J. Wysocki
2015-09-25 20:58 ` Rafael J. Wysocki
2015-09-25 21:44 ` Viresh Kumar
2015-09-25 21:44 ` Viresh Kumar
2015-09-25 21:44 ` Viresh Kumar
2015-09-25 21:44 ` Viresh Kumar
2015-09-25 21:44 ` Viresh Kumar
2015-09-25 21:44 ` Viresh Kumar
2015-09-25 22:19 ` Rafael J. Wysocki
2015-09-25 22:19 ` Rafael J. Wysocki
2015-09-25 22:19 ` Rafael J. Wysocki
2015-09-25 22:19 ` Rafael J. Wysocki
2015-09-25 22:19 ` Rafael J. Wysocki
2015-09-26 18:40 ` Viresh Kumar
2015-09-26 18:40 ` Viresh Kumar
2015-09-26 18:40 ` Viresh Kumar
2015-09-26 18:40 ` Viresh Kumar
2015-09-26 18:40 ` Viresh Kumar
2015-09-26 18:40 ` Viresh Kumar
2015-09-26 19:33 ` Arnd Bergmann
2015-09-26 19:33 ` Arnd Bergmann
2015-09-26 19:33 ` Arnd Bergmann
2015-09-26 19:33 ` Arnd Bergmann
2015-09-26 19:33 ` Arnd Bergmann
2015-09-27 14:10 ` Rafael J. Wysocki
2015-09-27 14:10 ` Rafael J. Wysocki
2015-09-27 14:10 ` Rafael J. Wysocki
2015-09-27 14:10 ` Rafael J. Wysocki
2015-09-27 14:10 ` Rafael J. Wysocki
2015-09-27 14:10 ` Rafael J. Wysocki
2015-09-28 8:24 ` Arnd Bergmann
2015-09-28 8:24 ` Arnd Bergmann
2015-09-28 8:24 ` Arnd Bergmann
2015-09-28 8:24 ` Arnd Bergmann
2015-09-28 8:24 ` Arnd Bergmann
2015-09-28 8:24 ` Arnd Bergmann
2015-09-28 13:07 ` Rafael J. Wysocki
2015-09-28 13:07 ` Rafael J. Wysocki
2015-09-28 13:07 ` Rafael J. Wysocki
2015-09-28 13:07 ` Rafael J. Wysocki
2015-09-28 13:07 ` Rafael J. Wysocki
2015-09-28 13:07 ` Rafael J. Wysocki
2015-09-26 19:52 ` James Bottomley
2015-09-26 19:52 ` James Bottomley
2015-09-26 19:52 ` James Bottomley
2015-09-26 19:52 ` James Bottomley
2015-09-26 19:52 ` James Bottomley
2015-09-26 19:52 ` James Bottomley
2015-09-27 14:09 ` Rafael J. Wysocki
2015-09-27 14:09 ` Rafael J. Wysocki
2015-09-27 14:09 ` Rafael J. Wysocki
2015-09-27 14:09 ` Rafael J. Wysocki
2015-09-27 14:09 ` Rafael J. Wysocki
2015-09-28 8:58 ` David Laight
2015-09-28 8:58 ` David Laight
2015-09-28 8:58 ` David Laight
2015-09-28 8:58 ` David Laight
2015-09-28 8:58 ` David Laight
2015-09-28 8:58 ` David Laight
2015-09-28 14:26 ` James Bottomley
2015-09-28 14:26 ` James Bottomley
2015-09-28 14:26 ` James Bottomley
2015-09-28 14:26 ` James Bottomley
2015-09-28 14:26 ` James Bottomley
2015-09-28 14:26 ` James Bottomley
2015-09-28 14:50 ` David Laight
2015-09-28 14:50 ` David Laight
2015-09-28 14:50 ` David Laight
2015-09-28 14:50 ` David Laight
2015-09-28 14:50 ` David Laight
2015-09-28 14:50 ` David Laight
2015-09-28 15:11 ` James Bottomley
2015-09-28 15:11 ` James Bottomley
2015-09-28 15:11 ` James Bottomley
2015-09-28 15:11 ` James Bottomley
2015-09-28 15:11 ` James Bottomley
2015-09-28 15:11 ` James Bottomley
2015-09-28 15:31 ` David Laight
2015-09-28 15:31 ` David Laight
2015-09-28 15:31 ` David Laight
2015-09-28 15:31 ` David Laight
2015-09-28 15:31 ` David Laight
2015-09-28 15:31 ` David Laight
2015-09-25 20:18 ` Rafael J. Wysocki
2015-09-25 20:18 ` Rafael J. Wysocki
2015-09-25 20:18 ` Rafael J. Wysocki
2015-09-25 20:22 ` Rafael J. Wysocki
2015-09-25 20:22 ` Rafael J. Wysocki
2015-09-25 20:22 ` Rafael J. Wysocki
2015-09-27 5:31 ` Jiri Slaby
2015-09-27 14:35 ` Viresh Kumar
2015-09-27 14:35 ` Viresh Kumar
2015-09-27 14:35 ` Viresh Kumar
2015-09-27 14:35 ` Viresh Kumar
2015-09-27 14:35 ` Viresh Kumar
2015-09-27 14:35 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150925185256.GG5951@linux \
--to=viresh.kumar@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilw@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=johannes@sipsolutions.net \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.