All of lore.kernel.org
 help / color / mirror / Atom feed
* [input:next 1341/1344] drivers/input/touchscreen/ft6236.c:316:3-8: No need to set .owner here. The core will do it.
@ 2015-10-06  1:35 kbuild test robot
  2015-10-06  1:35 ` [PATCH] Input: fix platform_no_drv_owner.cocci warnings kbuild test robot
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2015-10-06  1:35 UTC (permalink / raw)
  To: Noralf Trønnes; +Cc: kbuild-all, linux-input, Dmitry Torokhov

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
head:   c65cf815653ec64e73d40819806c2d1aed91681e
commit: 92deea1350f9fa97a841d45cd1f8228d5e8aa667 [1341/1344] Input: add support for FocalTech FT6236 touchscreen controller


coccinelle warnings: (new ones prefixed by >>)

>> drivers/input/touchscreen/ft6236.c:316:3-8: No need to set .owner here. The core will do it.

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] Input: fix platform_no_drv_owner.cocci warnings
  2015-10-06  1:35 [input:next 1341/1344] drivers/input/touchscreen/ft6236.c:316:3-8: No need to set .owner here. The core will do it kbuild test robot
@ 2015-10-06  1:35 ` kbuild test robot
  2015-10-06 22:50     ` Dmitry Torokhov
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2015-10-06  1:35 UTC (permalink / raw)
  To: Noralf Trønnes
  Cc: kbuild-all, linux-input, Dmitry Torokhov, linux-kernel

drivers/input/touchscreen/ft6236.c:316:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Noralf Trønnes <noralf@tronnes.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 ft6236.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/input/touchscreen/ft6236.c
+++ b/drivers/input/touchscreen/ft6236.c
@@ -313,7 +313,6 @@ MODULE_DEVICE_TABLE(i2c, ft6236_id);
 static struct i2c_driver ft6236_driver = {
 	.driver = {
 		.name = "ft6236",
-		.owner = THIS_MODULE,
 		.of_match_table = of_match_ptr(ft6236_of_match),
 	},
 	.probe = ft6236_probe,

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Input: fix platform_no_drv_owner.cocci warnings
  2015-10-06  1:35 ` [PATCH] Input: fix platform_no_drv_owner.cocci warnings kbuild test robot
@ 2015-10-06 22:50     ` Dmitry Torokhov
  0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2015-10-06 22:50 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Noralf Trønnes, kbuild-all, linux-input, linux-kernel

On Tue, Oct 06, 2015 at 09:35:31AM +0800, kbuild test robot wrote:
> drivers/input/touchscreen/ft6236.c:316:3-8: No need to set .owner here. The core will do it.
> 
>  Remove .owner field if calls are used which set it automatically
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> CC: Noralf Trønnes <noralf@tronnes.org>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Applied, thank you.

> ---
> 
>  ft6236.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/input/touchscreen/ft6236.c
> +++ b/drivers/input/touchscreen/ft6236.c
> @@ -313,7 +313,6 @@ MODULE_DEVICE_TABLE(i2c, ft6236_id);
>  static struct i2c_driver ft6236_driver = {
>  	.driver = {
>  		.name = "ft6236",
> -		.owner = THIS_MODULE,
>  		.of_match_table = of_match_ptr(ft6236_of_match),
>  	},
>  	.probe = ft6236_probe,

-- 
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Input: fix platform_no_drv_owner.cocci warnings
@ 2015-10-06 22:50     ` Dmitry Torokhov
  0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2015-10-06 22:50 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Noralf Trønnes, kbuild-all, linux-input, linux-kernel

On Tue, Oct 06, 2015 at 09:35:31AM +0800, kbuild test robot wrote:
> drivers/input/touchscreen/ft6236.c:316:3-8: No need to set .owner here. The core will do it.
> 
>  Remove .owner field if calls are used which set it automatically
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> CC: Noralf Trønnes <noralf@tronnes.org>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Applied, thank you.

> ---
> 
>  ft6236.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/input/touchscreen/ft6236.c
> +++ b/drivers/input/touchscreen/ft6236.c
> @@ -313,7 +313,6 @@ MODULE_DEVICE_TABLE(i2c, ft6236_id);
>  static struct i2c_driver ft6236_driver = {
>  	.driver = {
>  		.name = "ft6236",
> -		.owner = THIS_MODULE,
>  		.of_match_table = of_match_ptr(ft6236_of_match),
>  	},
>  	.probe = ft6236_probe,

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-10-06 22:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-06  1:35 [input:next 1341/1344] drivers/input/touchscreen/ft6236.c:316:3-8: No need to set .owner here. The core will do it kbuild test robot
2015-10-06  1:35 ` [PATCH] Input: fix platform_no_drv_owner.cocci warnings kbuild test robot
2015-10-06 22:50   ` Dmitry Torokhov
2015-10-06 22:50     ` Dmitry Torokhov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.