* [PATCH] staging: wilc1000: move open brace in line with control flow statement
@ 2015-10-09 6:21 Alison Schofield
2015-10-10 7:03 ` [Outreachy kernel] " Sudip Mukherjee
2015-10-12 20:22 ` [PATCH v2] " Alison Schofield
0 siblings, 2 replies; 3+ messages in thread
From: Alison Schofield @ 2015-10-09 6:21 UTC (permalink / raw)
To: outreachy-kernel
Move open braces to be in line with "if" control flow statements.
Addresses checkpatch.pl:
ERROR: that open brace { should be on the previous line
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index 6472777..bf65038 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -1476,8 +1476,8 @@ static int get_key(struct wiphy *wiphy, struct net_device *netdev, u8 key_index,
priv = wiphy_priv(wiphy);
- if (!pairwise)
- {
+ if (!pairwise) {
+
PRINT_D(CFG80211_DBG, "Getting group key idx: %x\n", key_index);
key_params.key = priv->wilc_gtk[key_index]->key;
@@ -1855,8 +1855,8 @@ void WILC_WFI_CfgParseRxAction(u8 *buf, u32 len)
index += buf[index + 1] + 3; /* ID,Length byte */
}
- if (u8WLANChannel != INVALID_CHANNEL)
- {
+ if (u8WLANChannel != INVALID_CHANNEL) {
+
/*Modify channel list attribute*/
if (channel_list_attr_index) {
PRINT_D(GENERIC_DBG, "Modify channel list attribute\n");
@@ -1910,8 +1910,8 @@ void WILC_WFI_CfgParseTxAction(u8 *buf, u32 len, bool bOperChan, u8 iftype)
index += buf[index + 1] + 3; /* ID,Length byte */
}
- if (u8WLANChannel != INVALID_CHANNEL && bOperChan)
- {
+ if (u8WLANChannel != INVALID_CHANNEL && bOperChan) {
+
/*Modify channel list attribute*/
if (channel_list_attr_index) {
PRINT_D(GENERIC_DBG, "Modify channel list attribute\n");
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: wilc1000: move open brace in line with control flow statement
2015-10-09 6:21 [PATCH] staging: wilc1000: move open brace in line with control flow statement Alison Schofield
@ 2015-10-10 7:03 ` Sudip Mukherjee
2015-10-12 20:22 ` [PATCH v2] " Alison Schofield
1 sibling, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2015-10-10 7:03 UTC (permalink / raw)
To: Alison Schofield; +Cc: outreachy-kernel
On Thu, Oct 08, 2015 at 11:21:13PM -0700, Alison Schofield wrote:
> Move open braces to be in line with "if" control flow statements.
> Addresses checkpatch.pl:
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index 6472777..bf65038 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -1476,8 +1476,8 @@ static int get_key(struct wiphy *wiphy, struct net_device *netdev, u8 key_index,
> priv = wiphy_priv(wiphy);
>
>
> - if (!pairwise)
> - {
> + if (!pairwise) {
> +
This patch will be introducing new checkpatch warning of:
Blank lines aren't necessary after an open brace '{'.
The blank lines after the brace is not required.
regards
sudip
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] staging: wilc1000: move open brace in line with control flow statement
2015-10-09 6:21 [PATCH] staging: wilc1000: move open brace in line with control flow statement Alison Schofield
2015-10-10 7:03 ` [Outreachy kernel] " Sudip Mukherjee
@ 2015-10-12 20:22 ` Alison Schofield
1 sibling, 0 replies; 3+ messages in thread
From: Alison Schofield @ 2015-10-12 20:22 UTC (permalink / raw)
To: outreachy-kernel
Move open braces to be in line with "if" control flow statements.
Addresses checkpatch.pl:
ERROR: that open brace { should be on the previous line
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
---
Changes in v2: removed blank lines after open braces
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index 6472777..906700f 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -1476,8 +1476,7 @@ static int get_key(struct wiphy *wiphy, struct net_device *netdev, u8 key_index,
priv = wiphy_priv(wiphy);
- if (!pairwise)
- {
+ if (!pairwise) {
PRINT_D(CFG80211_DBG, "Getting group key idx: %x\n", key_index);
key_params.key = priv->wilc_gtk[key_index]->key;
@@ -1854,9 +1853,8 @@ void WILC_WFI_CfgParseRxAction(u8 *buf, u32 len)
op_channel_attr_index = index;
index += buf[index + 1] + 3; /* ID,Length byte */
}
+ if (u8WLANChannel != INVALID_CHANNEL) {
- if (u8WLANChannel != INVALID_CHANNEL)
- {
/*Modify channel list attribute*/
if (channel_list_attr_index) {
PRINT_D(GENERIC_DBG, "Modify channel list attribute\n");
@@ -1909,9 +1907,8 @@ void WILC_WFI_CfgParseTxAction(u8 *buf, u32 len, bool bOperChan, u8 iftype)
op_channel_attr_index = index;
index += buf[index + 1] + 3; /* ID,Length byte */
}
+ if (u8WLANChannel != INVALID_CHANNEL && bOperChan) {
- if (u8WLANChannel != INVALID_CHANNEL && bOperChan)
- {
/*Modify channel list attribute*/
if (channel_list_attr_index) {
PRINT_D(GENERIC_DBG, "Modify channel list attribute\n");
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-12 20:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-09 6:21 [PATCH] staging: wilc1000: move open brace in line with control flow statement Alison Schofield
2015-10-10 7:03 ` [Outreachy kernel] " Sudip Mukherjee
2015-10-12 20:22 ` [PATCH v2] " Alison Schofield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.