* [PATCH v3] drivers: power: twl4030_charger: fix link problems when building as module
@ 2015-09-25 20:20 ` Marek Belisko
0 siblings, 0 replies; 25+ messages in thread
From: Marek Belisko @ 2015-09-25 20:20 UTC (permalink / raw)
To: sre, dbaryshkov, dwmw2
Cc: neilb, devicetree, linux-kernel, linux-arm-kernel, linux-pm, hns,
Marek Belisko
If either twl4030_charger or twl4030_madc is configured as MODULE,
we get build (link) errors.
To solve, the direct call of twl4030_get_madc_conversion() is replaced
by a call to iio_read_channel_processed().
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Marek Belisko <marek@goldelico.com>
---
changes from v2: make iio propries optional to keep functionality for old DT also
changes from V1: added missing iio_channel_release + document and add new DT bindings
drivers/power/twl4030_charger.c | 45 ++++++++++++++++++++++++++++-------------
1 file changed, 31 insertions(+), 14 deletions(-)
diff --git a/drivers/power/twl4030_charger.c b/drivers/power/twl4030_charger.c
index f4f2c1f..82e2a05 100644
--- a/drivers/power/twl4030_charger.c
+++ b/drivers/power/twl4030_charger.c
@@ -22,7 +22,7 @@
#include <linux/power_supply.h>
#include <linux/notifier.h>
#include <linux/usb/otg.h>
-#include <linux/i2c/twl4030-madc.h>
+#include <linux/iio/consumer.h>
#define TWL4030_BCIMDEN 0x00
#define TWL4030_BCIMDKEY 0x01
@@ -91,21 +91,23 @@
#define TWL4030_MSTATEC_COMPLETE1 0x0b
#define TWL4030_MSTATEC_COMPLETE4 0x0e
-#if IS_ENABLED(CONFIG_TWL4030_MADC)
/*
* If AC (Accessory Charger) voltage exceeds 4.5V (MADC 11)
* then AC is available.
*/
-static inline int ac_available(void)
+static inline int ac_available(struct iio_channel *channel_vac)
{
- return twl4030_get_madc_conversion(11) > 4500;
-}
-#else
-static inline int ac_available(void)
-{
- return 0;
+ int val, err;
+
+ if (!channel_vac)
+ return 0;
+
+ err = iio_read_channel_processed(channel_vac, &val);
+ if (err < 0)
+ return 0;
+ return val > 4500;
}
-#endif
+
static bool allow_usb;
module_param(allow_usb, bool, 0644);
MODULE_PARM_DESC(allow_usb, "Allow USB charge drawing default current");
@@ -128,6 +130,7 @@ struct twl4030_bci {
*/
unsigned int ichg_eoc, ichg_lo, ichg_hi;
unsigned int usb_cur, ac_cur;
+ struct iio_channel *channel_vac;
bool ac_is_active;
int usb_mode, ac_mode; /* charging mode requested */
#define CHARGE_OFF 0
@@ -278,7 +281,7 @@ static int twl4030_charger_update_current(struct twl4030_bci *bci)
* If AC (Accessory Charger) voltage exceeds 4.5V (MADC 11)
* and AC is enabled, set current for 'ac'
*/
- if (ac_available()) {
+ if (ac_available(bci->channel_vac)) {
cur = bci->ac_cur;
bci->ac_is_active = true;
} else {
@@ -1048,6 +1051,12 @@ static int twl4030_bci_probe(struct platform_device *pdev)
return ret;
}
+ bci->channel_vac = iio_channel_get(&pdev->dev, "vac");
+ if (IS_ERR(bci->channel_vac)) {
+ bci->channel_vac = NULL;
+ dev_warn(&pdev->dev, "could not request vac iio channel");
+ }
+
INIT_WORK(&bci->work, twl4030_bci_usb_work);
INIT_DELAYED_WORK(&bci->current_worker, twl4030_current_worker);
@@ -1061,8 +1070,10 @@ static int twl4030_bci_probe(struct platform_device *pdev)
bci->transceiver = devm_usb_get_phy_by_node(
bci->dev, phynode, &bci->usb_nb);
if (IS_ERR(bci->transceiver) &&
- PTR_ERR(bci->transceiver) == -EPROBE_DEFER)
- return -EPROBE_DEFER;
+ PTR_ERR(bci->transceiver) == -EPROBE_DEFER) {
+ ret = -EPROBE_DEFER;
+ goto fail;
+ }
}
}
@@ -1073,7 +1084,7 @@ static int twl4030_bci_probe(struct platform_device *pdev)
TWL4030_INTERRUPTS_BCIIMR1A);
if (ret < 0) {
dev_err(&pdev->dev, "failed to unmask interrupts: %d\n", ret);
- return ret;
+ goto fail;
}
reg = ~(u32)(TWL4030_VBATOV | TWL4030_VBUSOV | TWL4030_ACCHGOV);
@@ -1106,6 +1117,10 @@ static int twl4030_bci_probe(struct platform_device *pdev)
twl4030_charger_enable_backup(0, 0);
return 0;
+fail:
+ iio_channel_release(bci->channel_vac);
+
+ return ret;
}
static int __exit twl4030_bci_remove(struct platform_device *pdev)
@@ -1116,6 +1131,8 @@ static int __exit twl4030_bci_remove(struct platform_device *pdev)
twl4030_charger_enable_usb(bci, false);
twl4030_charger_enable_backup(0, 0);
+ iio_channel_release(bci->channel_vac);
+
device_remove_file(&bci->usb->dev, &dev_attr_max_current);
device_remove_file(&bci->usb->dev, &dev_attr_mode);
device_remove_file(&bci->ac->dev, &dev_attr_max_current);
--
1.9.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v3] drivers: power: twl4030_charger: fix link problems when building as module
@ 2015-09-25 20:20 ` Marek Belisko
0 siblings, 0 replies; 25+ messages in thread
From: Marek Belisko @ 2015-09-25 20:20 UTC (permalink / raw)
To: linux-arm-kernel
If either twl4030_charger or twl4030_madc is configured as MODULE,
we get build (link) errors.
To solve, the direct call of twl4030_get_madc_conversion() is replaced
by a call to iio_read_channel_processed().
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Marek Belisko <marek@goldelico.com>
---
changes from v2: make iio propries optional to keep functionality for old DT also
changes from V1: added missing iio_channel_release + document and add new DT bindings
drivers/power/twl4030_charger.c | 45 ++++++++++++++++++++++++++++-------------
1 file changed, 31 insertions(+), 14 deletions(-)
diff --git a/drivers/power/twl4030_charger.c b/drivers/power/twl4030_charger.c
index f4f2c1f..82e2a05 100644
--- a/drivers/power/twl4030_charger.c
+++ b/drivers/power/twl4030_charger.c
@@ -22,7 +22,7 @@
#include <linux/power_supply.h>
#include <linux/notifier.h>
#include <linux/usb/otg.h>
-#include <linux/i2c/twl4030-madc.h>
+#include <linux/iio/consumer.h>
#define TWL4030_BCIMDEN 0x00
#define TWL4030_BCIMDKEY 0x01
@@ -91,21 +91,23 @@
#define TWL4030_MSTATEC_COMPLETE1 0x0b
#define TWL4030_MSTATEC_COMPLETE4 0x0e
-#if IS_ENABLED(CONFIG_TWL4030_MADC)
/*
* If AC (Accessory Charger) voltage exceeds 4.5V (MADC 11)
* then AC is available.
*/
-static inline int ac_available(void)
+static inline int ac_available(struct iio_channel *channel_vac)
{
- return twl4030_get_madc_conversion(11) > 4500;
-}
-#else
-static inline int ac_available(void)
-{
- return 0;
+ int val, err;
+
+ if (!channel_vac)
+ return 0;
+
+ err = iio_read_channel_processed(channel_vac, &val);
+ if (err < 0)
+ return 0;
+ return val > 4500;
}
-#endif
+
static bool allow_usb;
module_param(allow_usb, bool, 0644);
MODULE_PARM_DESC(allow_usb, "Allow USB charge drawing default current");
@@ -128,6 +130,7 @@ struct twl4030_bci {
*/
unsigned int ichg_eoc, ichg_lo, ichg_hi;
unsigned int usb_cur, ac_cur;
+ struct iio_channel *channel_vac;
bool ac_is_active;
int usb_mode, ac_mode; /* charging mode requested */
#define CHARGE_OFF 0
@@ -278,7 +281,7 @@ static int twl4030_charger_update_current(struct twl4030_bci *bci)
* If AC (Accessory Charger) voltage exceeds 4.5V (MADC 11)
* and AC is enabled, set current for 'ac'
*/
- if (ac_available()) {
+ if (ac_available(bci->channel_vac)) {
cur = bci->ac_cur;
bci->ac_is_active = true;
} else {
@@ -1048,6 +1051,12 @@ static int twl4030_bci_probe(struct platform_device *pdev)
return ret;
}
+ bci->channel_vac = iio_channel_get(&pdev->dev, "vac");
+ if (IS_ERR(bci->channel_vac)) {
+ bci->channel_vac = NULL;
+ dev_warn(&pdev->dev, "could not request vac iio channel");
+ }
+
INIT_WORK(&bci->work, twl4030_bci_usb_work);
INIT_DELAYED_WORK(&bci->current_worker, twl4030_current_worker);
@@ -1061,8 +1070,10 @@ static int twl4030_bci_probe(struct platform_device *pdev)
bci->transceiver = devm_usb_get_phy_by_node(
bci->dev, phynode, &bci->usb_nb);
if (IS_ERR(bci->transceiver) &&
- PTR_ERR(bci->transceiver) == -EPROBE_DEFER)
- return -EPROBE_DEFER;
+ PTR_ERR(bci->transceiver) == -EPROBE_DEFER) {
+ ret = -EPROBE_DEFER;
+ goto fail;
+ }
}
}
@@ -1073,7 +1084,7 @@ static int twl4030_bci_probe(struct platform_device *pdev)
TWL4030_INTERRUPTS_BCIIMR1A);
if (ret < 0) {
dev_err(&pdev->dev, "failed to unmask interrupts: %d\n", ret);
- return ret;
+ goto fail;
}
reg = ~(u32)(TWL4030_VBATOV | TWL4030_VBUSOV | TWL4030_ACCHGOV);
@@ -1106,6 +1117,10 @@ static int twl4030_bci_probe(struct platform_device *pdev)
twl4030_charger_enable_backup(0, 0);
return 0;
+fail:
+ iio_channel_release(bci->channel_vac);
+
+ return ret;
}
static int __exit twl4030_bci_remove(struct platform_device *pdev)
@@ -1116,6 +1131,8 @@ static int __exit twl4030_bci_remove(struct platform_device *pdev)
twl4030_charger_enable_usb(bci, false);
twl4030_charger_enable_backup(0, 0);
+ iio_channel_release(bci->channel_vac);
+
device_remove_file(&bci->usb->dev, &dev_attr_max_current);
device_remove_file(&bci->usb->dev, &dev_attr_mode);
device_remove_file(&bci->ac->dev, &dev_attr_max_current);
--
1.9.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v3] Documentation: DT: twl-charger: document new iio properties
2015-09-25 20:20 ` Marek Belisko
@ 2015-09-25 20:20 ` Marek Belisko
-1 siblings, 0 replies; 25+ messages in thread
From: Marek Belisko @ 2015-09-25 20:20 UTC (permalink / raw)
To: sre, dbaryshkov, dwmw2
Cc: neilb, devicetree, linux-kernel, linux-arm-kernel, linux-pm, hns,
Marek Belisko
Document added iio properties to avoid using direct function call from twl4030-madc
driver.
Signed-off-by: Marek Belisko <marek@goldelico.com>
---
Documentation/devicetree/bindings/power/twl-charger.txt | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/power/twl-charger.txt b/Documentation/devicetree/bindings/power/twl-charger.txt
index 3b4ea1b..e198650 100644
--- a/Documentation/devicetree/bindings/power/twl-charger.txt
+++ b/Documentation/devicetree/bindings/power/twl-charger.txt
@@ -19,12 +19,18 @@ Required properties:
Optional properties:
- ti,bb-uvolt: microvolts for charging the backup battery.
- ti,bb-uamp: microamps for charging the backup battery.
+- io-channels: Should contain following: <&twl4030_madc 11>
+- io-channel-names: Should contains following value:
+ * "vac" - ADC channel for measuring the voltage of the external AC charger
+If io properties aren't provided then functionality of accesory charger doesn't work.
Examples:
bci {
compatible = "ti,twl4030-bci";
interrupts = <9>, <2>;
+ io-channels = <&twl4030_madc 11>;
+ io-channel-name = "vac";
ti,bb-uvolt = <3200000>;
ti,bb-uamp = <150>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v3] Documentation: DT: twl-charger: document new iio properties
@ 2015-09-25 20:20 ` Marek Belisko
0 siblings, 0 replies; 25+ messages in thread
From: Marek Belisko @ 2015-09-25 20:20 UTC (permalink / raw)
To: linux-arm-kernel
Document added iio properties to avoid using direct function call from twl4030-madc
driver.
Signed-off-by: Marek Belisko <marek@goldelico.com>
---
Documentation/devicetree/bindings/power/twl-charger.txt | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/power/twl-charger.txt b/Documentation/devicetree/bindings/power/twl-charger.txt
index 3b4ea1b..e198650 100644
--- a/Documentation/devicetree/bindings/power/twl-charger.txt
+++ b/Documentation/devicetree/bindings/power/twl-charger.txt
@@ -19,12 +19,18 @@ Required properties:
Optional properties:
- ti,bb-uvolt: microvolts for charging the backup battery.
- ti,bb-uamp: microamps for charging the backup battery.
+- io-channels: Should contain following: <&twl4030_madc 11>
+- io-channel-names: Should contains following value:
+ * "vac" - ADC channel for measuring the voltage of the external AC charger
+If io properties aren't provided then functionality of accesory charger doesn't work.
Examples:
bci {
compatible = "ti,twl4030-bci";
interrupts = <9>, <2>;
+ io-channels = <&twl4030_madc 11>;
+ io-channel-name = "vac";
ti,bb-uvolt = <3200000>;
ti,bb-uamp = <150>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
2015-09-25 20:20 ` Marek Belisko
@ 2015-09-25 20:20 ` Marek Belisko
-1 siblings, 0 replies; 25+ messages in thread
From: Marek Belisko @ 2015-09-25 20:20 UTC (permalink / raw)
To: sre, dbaryshkov, dwmw2
Cc: neilb, devicetree, linux-kernel, linux-arm-kernel, linux-pm, hns,
Marek Belisko
Added new iio properties which are required for twl4030-charger driver and
allow to use twl4030-madc indirectly.
Signed-off-by: Marek Belisko <marek@goldelico.com>
---
arch/arm/boot/dts/twl4030.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/twl4030.dtsi b/arch/arm/boot/dts/twl4030.dtsi
index 36ae916..482b7aa 100644
--- a/arch/arm/boot/dts/twl4030.dtsi
+++ b/arch/arm/boot/dts/twl4030.dtsi
@@ -22,6 +22,8 @@
charger: bci {
compatible = "ti,twl4030-bci";
interrupts = <9>, <2>;
+ io-channels = <&twl4030_madc 11>;
+ io-channel-name = "vac";
bci3v1-supply = <&vusb3v1>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
@ 2015-09-25 20:20 ` Marek Belisko
0 siblings, 0 replies; 25+ messages in thread
From: Marek Belisko @ 2015-09-25 20:20 UTC (permalink / raw)
To: linux-arm-kernel
Added new iio properties which are required for twl4030-charger driver and
allow to use twl4030-madc indirectly.
Signed-off-by: Marek Belisko <marek@goldelico.com>
---
arch/arm/boot/dts/twl4030.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/twl4030.dtsi b/arch/arm/boot/dts/twl4030.dtsi
index 36ae916..482b7aa 100644
--- a/arch/arm/boot/dts/twl4030.dtsi
+++ b/arch/arm/boot/dts/twl4030.dtsi
@@ -22,6 +22,8 @@
charger: bci {
compatible = "ti,twl4030-bci";
interrupts = <9>, <2>;
+ io-channels = <&twl4030_madc 11>;
+ io-channel-name = "vac";
bci3v1-supply = <&vusb3v1>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v3] drivers: power: twl4030_charger: fix link problems when building as module
2015-09-25 20:20 ` Marek Belisko
@ 2015-09-26 17:23 ` Sebastian Reichel
-1 siblings, 0 replies; 25+ messages in thread
From: Sebastian Reichel @ 2015-09-26 17:23 UTC (permalink / raw)
To: Marek Belisko
Cc: dbaryshkov, dwmw2, neilb, devicetree, linux-kernel,
linux-arm-kernel, linux-pm, hns
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
Hi Marek,
On Fri, Sep 25, 2015 at 10:20:45PM +0200, Marek Belisko wrote:
> If either twl4030_charger or twl4030_madc is configured as MODULE,
> we get build (link) errors.
>
> To solve, the direct call of twl4030_get_madc_conversion() is replaced
> by a call to iio_read_channel_processed().
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> Signed-off-by: Marek Belisko <marek@goldelico.com>
Thanks, queued for 4.4 together with the DT binding patch.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v3] drivers: power: twl4030_charger: fix link problems when building as module
@ 2015-09-26 17:23 ` Sebastian Reichel
0 siblings, 0 replies; 25+ messages in thread
From: Sebastian Reichel @ 2015-09-26 17:23 UTC (permalink / raw)
To: linux-arm-kernel
Hi Marek,
On Fri, Sep 25, 2015 at 10:20:45PM +0200, Marek Belisko wrote:
> If either twl4030_charger or twl4030_madc is configured as MODULE,
> we get build (link) errors.
>
> To solve, the direct call of twl4030_get_madc_conversion() is replaced
> by a call to iio_read_channel_processed().
>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> Signed-off-by: Marek Belisko <marek@goldelico.com>
Thanks, queued for 4.4 together with the DT binding patch.
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150926/8cdd8bc4/attachment.sig>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
@ 2015-09-26 17:29 ` Sebastian Reichel
0 siblings, 0 replies; 25+ messages in thread
From: Sebastian Reichel @ 2015-09-26 17:29 UTC (permalink / raw)
To: Marek Belisko
Cc: neilb, devicetree, linux-kernel, linux-arm-kernel, linux-pm, hns
[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]
Hi Marek,
On Fri, Sep 25, 2015 at 10:20:47PM +0200, Marek Belisko wrote:
> Added new iio properties which are required for twl4030-charger driver and
> allow to use twl4030-madc indirectly.
>
> Signed-off-by: Marek Belisko <marek@goldelico.com>
> ---
> arch/arm/boot/dts/twl4030.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/twl4030.dtsi b/arch/arm/boot/dts/twl4030.dtsi
> index 36ae916..482b7aa 100644
> --- a/arch/arm/boot/dts/twl4030.dtsi
> +++ b/arch/arm/boot/dts/twl4030.dtsi
> @@ -22,6 +22,8 @@
> charger: bci {
> compatible = "ti,twl4030-bci";
> interrupts = <9>, <2>;
> + io-channels = <&twl4030_madc 11>;
> + io-channel-name = "vac";
> bci3v1-supply = <&vusb3v1>;
> };
Acked-By: Sebastian Reichel <sre@kernel.org>
This patch is missing correct To/Cc:
$ grep -A5 "OMAP DEVICE TREE SUPPORT" MAINTAINERS
OMAP DEVICE TREE SUPPORT
M: Benoît Cousson <bcousson@baylibre.com>
M: Tony Lindgren <tony@atomide.com>
L: linux-omap@vger.kernel.org
L: devicetree@vger.kernel.org
S: Maintained
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
@ 2015-09-26 17:29 ` Sebastian Reichel
0 siblings, 0 replies; 25+ messages in thread
From: Sebastian Reichel @ 2015-09-26 17:29 UTC (permalink / raw)
To: Marek Belisko
Cc: neilb-l3A5Bk7waGM, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-pm-u79uwXL29TY76Z2rM5mHXA, hns-xXXSsgcRVICgSpxsJD1C4w
[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]
Hi Marek,
On Fri, Sep 25, 2015 at 10:20:47PM +0200, Marek Belisko wrote:
> Added new iio properties which are required for twl4030-charger driver and
> allow to use twl4030-madc indirectly.
>
> Signed-off-by: Marek Belisko <marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
> ---
> arch/arm/boot/dts/twl4030.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/twl4030.dtsi b/arch/arm/boot/dts/twl4030.dtsi
> index 36ae916..482b7aa 100644
> --- a/arch/arm/boot/dts/twl4030.dtsi
> +++ b/arch/arm/boot/dts/twl4030.dtsi
> @@ -22,6 +22,8 @@
> charger: bci {
> compatible = "ti,twl4030-bci";
> interrupts = <9>, <2>;
> + io-channels = <&twl4030_madc 11>;
> + io-channel-name = "vac";
> bci3v1-supply = <&vusb3v1>;
> };
Acked-By: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
This patch is missing correct To/Cc:
$ grep -A5 "OMAP DEVICE TREE SUPPORT" MAINTAINERS
OMAP DEVICE TREE SUPPORT
M: Benoît Cousson <bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
M: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
L: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
L: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
S: Maintained
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
@ 2015-09-26 17:29 ` Sebastian Reichel
0 siblings, 0 replies; 25+ messages in thread
From: Sebastian Reichel @ 2015-09-26 17:29 UTC (permalink / raw)
To: linux-arm-kernel
Hi Marek,
On Fri, Sep 25, 2015 at 10:20:47PM +0200, Marek Belisko wrote:
> Added new iio properties which are required for twl4030-charger driver and
> allow to use twl4030-madc indirectly.
>
> Signed-off-by: Marek Belisko <marek@goldelico.com>
> ---
> arch/arm/boot/dts/twl4030.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/twl4030.dtsi b/arch/arm/boot/dts/twl4030.dtsi
> index 36ae916..482b7aa 100644
> --- a/arch/arm/boot/dts/twl4030.dtsi
> +++ b/arch/arm/boot/dts/twl4030.dtsi
> @@ -22,6 +22,8 @@
> charger: bci {
> compatible = "ti,twl4030-bci";
> interrupts = <9>, <2>;
> + io-channels = <&twl4030_madc 11>;
> + io-channel-name = "vac";
> bci3v1-supply = <&vusb3v1>;
> };
Acked-By: Sebastian Reichel <sre@kernel.org>
This patch is missing correct To/Cc:
$ grep -A5 "OMAP DEVICE TREE SUPPORT" MAINTAINERS
OMAP DEVICE TREE SUPPORT
M: Beno?t Cousson <bcousson@baylibre.com>
M: Tony Lindgren <tony@atomide.com>
L: linux-omap at vger.kernel.org
L: devicetree at vger.kernel.org
S: Maintained
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150926/9343b2ec/attachment.sig>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
2015-09-26 17:29 ` Sebastian Reichel
(?)
@ 2015-09-26 19:58 ` Belisko Marek
-1 siblings, 0 replies; 25+ messages in thread
From: Belisko Marek @ 2015-09-26 19:58 UTC (permalink / raw)
To: Tony Lindgren, Benoit Cousson
Cc: Neil Brown, Sebastian Reichel, devicetree, LKML,
linux-arm-kernel, Linux PM mailing list,
Dr. H. Nikolaus Schaller, linux-omap
Tony sorry I forgot to add you to the recipients for this patchset.
Can you please queue this patch. Many thanks.
@Sebastian: thanks for noticing
On Sat, Sep 26, 2015 at 7:29 PM, Sebastian Reichel <sre@kernel.org> wrote:
> Hi Marek,
>
> On Fri, Sep 25, 2015 at 10:20:47PM +0200, Marek Belisko wrote:
>> Added new iio properties which are required for twl4030-charger driver and
>> allow to use twl4030-madc indirectly.
>>
>> Signed-off-by: Marek Belisko <marek@goldelico.com>
>> ---
>> arch/arm/boot/dts/twl4030.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/twl4030.dtsi b/arch/arm/boot/dts/twl4030.dtsi
>> index 36ae916..482b7aa 100644
>> --- a/arch/arm/boot/dts/twl4030.dtsi
>> +++ b/arch/arm/boot/dts/twl4030.dtsi
>> @@ -22,6 +22,8 @@
>> charger: bci {
>> compatible = "ti,twl4030-bci";
>> interrupts = <9>, <2>;
>> + io-channels = <&twl4030_madc 11>;
>> + io-channel-name = "vac";
>> bci3v1-supply = <&vusb3v1>;
>> };
>
> Acked-By: Sebastian Reichel <sre@kernel.org>
>
> This patch is missing correct To/Cc:
>
> $ grep -A5 "OMAP DEVICE TREE SUPPORT" MAINTAINERS
> OMAP DEVICE TREE SUPPORT
> M: Benoît Cousson <bcousson@baylibre.com>
> M: Tony Lindgren <tony@atomide.com>
> L: linux-omap@vger.kernel.org
> L: devicetree@vger.kernel.org
> S: Maintained
>
> -- Sebastian
BR,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
@ 2015-09-26 19:58 ` Belisko Marek
0 siblings, 0 replies; 25+ messages in thread
From: Belisko Marek @ 2015-09-26 19:58 UTC (permalink / raw)
To: Tony Lindgren, Benoit Cousson
Cc: Neil Brown, Sebastian Reichel, devicetree-u79uwXL29TY76Z2rM5mHXA,
LKML, linux-arm-kernel, Linux PM mailing list,
Dr. H. Nikolaus Schaller, linux-omap-u79uwXL29TY76Z2rM5mHXA
Tony sorry I forgot to add you to the recipients for this patchset.
Can you please queue this patch. Many thanks.
@Sebastian: thanks for noticing
On Sat, Sep 26, 2015 at 7:29 PM, Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> Hi Marek,
>
> On Fri, Sep 25, 2015 at 10:20:47PM +0200, Marek Belisko wrote:
>> Added new iio properties which are required for twl4030-charger driver and
>> allow to use twl4030-madc indirectly.
>>
>> Signed-off-by: Marek Belisko <marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
>> ---
>> arch/arm/boot/dts/twl4030.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/twl4030.dtsi b/arch/arm/boot/dts/twl4030.dtsi
>> index 36ae916..482b7aa 100644
>> --- a/arch/arm/boot/dts/twl4030.dtsi
>> +++ b/arch/arm/boot/dts/twl4030.dtsi
>> @@ -22,6 +22,8 @@
>> charger: bci {
>> compatible = "ti,twl4030-bci";
>> interrupts = <9>, <2>;
>> + io-channels = <&twl4030_madc 11>;
>> + io-channel-name = "vac";
>> bci3v1-supply = <&vusb3v1>;
>> };
>
> Acked-By: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>
> This patch is missing correct To/Cc:
>
> $ grep -A5 "OMAP DEVICE TREE SUPPORT" MAINTAINERS
> OMAP DEVICE TREE SUPPORT
> M: Benoît Cousson <bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> M: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> L: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> L: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> S: Maintained
>
> -- Sebastian
BR,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
@ 2015-09-26 19:58 ` Belisko Marek
0 siblings, 0 replies; 25+ messages in thread
From: Belisko Marek @ 2015-09-26 19:58 UTC (permalink / raw)
To: linux-arm-kernel
Tony sorry I forgot to add you to the recipients for this patchset.
Can you please queue this patch. Many thanks.
@Sebastian: thanks for noticing
On Sat, Sep 26, 2015 at 7:29 PM, Sebastian Reichel <sre@kernel.org> wrote:
> Hi Marek,
>
> On Fri, Sep 25, 2015 at 10:20:47PM +0200, Marek Belisko wrote:
>> Added new iio properties which are required for twl4030-charger driver and
>> allow to use twl4030-madc indirectly.
>>
>> Signed-off-by: Marek Belisko <marek@goldelico.com>
>> ---
>> arch/arm/boot/dts/twl4030.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/twl4030.dtsi b/arch/arm/boot/dts/twl4030.dtsi
>> index 36ae916..482b7aa 100644
>> --- a/arch/arm/boot/dts/twl4030.dtsi
>> +++ b/arch/arm/boot/dts/twl4030.dtsi
>> @@ -22,6 +22,8 @@
>> charger: bci {
>> compatible = "ti,twl4030-bci";
>> interrupts = <9>, <2>;
>> + io-channels = <&twl4030_madc 11>;
>> + io-channel-name = "vac";
>> bci3v1-supply = <&vusb3v1>;
>> };
>
> Acked-By: Sebastian Reichel <sre@kernel.org>
>
> This patch is missing correct To/Cc:
>
> $ grep -A5 "OMAP DEVICE TREE SUPPORT" MAINTAINERS
> OMAP DEVICE TREE SUPPORT
> M: Beno?t Cousson <bcousson@baylibre.com>
> M: Tony Lindgren <tony@atomide.com>
> L: linux-omap at vger.kernel.org
> L: devicetree at vger.kernel.org
> S: Maintained
>
> -- Sebastian
BR,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
@ 2015-10-12 21:38 ` Tony Lindgren
0 siblings, 0 replies; 25+ messages in thread
From: Tony Lindgren @ 2015-10-12 21:38 UTC (permalink / raw)
To: Belisko Marek
Cc: Benoit Cousson, Neil Brown, Sebastian Reichel, devicetree, LKML,
linux-arm-kernel, Linux PM mailing list,
Dr. H. Nikolaus Schaller, linux-omap
* Belisko Marek <marek.belisko@gmail.com> [150926 13:02]:
> Tony sorry I forgot to add you to the recipients for this patchset.
> Can you please queue this patch. Many thanks.
OK applying into omap-for-v4.4/dt thanks.
Tony
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
@ 2015-10-12 21:38 ` Tony Lindgren
0 siblings, 0 replies; 25+ messages in thread
From: Tony Lindgren @ 2015-10-12 21:38 UTC (permalink / raw)
To: Belisko Marek
Cc: Benoit Cousson, Neil Brown, Sebastian Reichel,
devicetree-u79uwXL29TY76Z2rM5mHXA, LKML, linux-arm-kernel,
Linux PM mailing list, Dr. H. Nikolaus Schaller,
linux-omap-u79uwXL29TY76Z2rM5mHXA
* Belisko Marek <marek.belisko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [150926 13:02]:
> Tony sorry I forgot to add you to the recipients for this patchset.
> Can you please queue this patch. Many thanks.
OK applying into omap-for-v4.4/dt thanks.
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
@ 2015-10-12 21:38 ` Tony Lindgren
0 siblings, 0 replies; 25+ messages in thread
From: Tony Lindgren @ 2015-10-12 21:38 UTC (permalink / raw)
To: linux-arm-kernel
* Belisko Marek <marek.belisko@gmail.com> [150926 13:02]:
> Tony sorry I forgot to add you to the recipients for this patchset.
> Can you please queue this patch. Many thanks.
OK applying into omap-for-v4.4/dt thanks.
Tony
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
@ 2015-10-12 22:20 ` Tony Lindgren
0 siblings, 0 replies; 25+ messages in thread
From: Tony Lindgren @ 2015-10-12 22:20 UTC (permalink / raw)
To: Belisko Marek
Cc: devicetree, Linux PM mailing list, Neil Brown,
Dr. H. Nikolaus Schaller, Sebastian Reichel, LKML,
Benoit Cousson, linux-omap, linux-arm-kernel
* Tony Lindgren <tony@atomide.com> [151012 14:43]:
> * Belisko Marek <marek.belisko@gmail.com> [150926 13:02]:
> > Tony sorry I forgot to add you to the recipients for this patchset.
> > Can you please queue this patch. Many thanks.
>
> OK applying into omap-for-v4.4/dt thanks.
Actually dropping this one, it makes build fail as we don't
have twl4030_madc yet.
Maybe please send a separate set of dts patches for me.
Regards,
Tony
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
@ 2015-10-12 22:20 ` Tony Lindgren
0 siblings, 0 replies; 25+ messages in thread
From: Tony Lindgren @ 2015-10-12 22:20 UTC (permalink / raw)
To: Belisko Marek
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Linux PM mailing list,
Neil Brown, Dr. H. Nikolaus Schaller, Sebastian Reichel, LKML,
Benoit Cousson, linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel
* Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> [151012 14:43]:
> * Belisko Marek <marek.belisko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [150926 13:02]:
> > Tony sorry I forgot to add you to the recipients for this patchset.
> > Can you please queue this patch. Many thanks.
>
> OK applying into omap-for-v4.4/dt thanks.
Actually dropping this one, it makes build fail as we don't
have twl4030_madc yet.
Maybe please send a separate set of dts patches for me.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
@ 2015-10-12 22:20 ` Tony Lindgren
0 siblings, 0 replies; 25+ messages in thread
From: Tony Lindgren @ 2015-10-12 22:20 UTC (permalink / raw)
To: linux-arm-kernel
* Tony Lindgren <tony@atomide.com> [151012 14:43]:
> * Belisko Marek <marek.belisko@gmail.com> [150926 13:02]:
> > Tony sorry I forgot to add you to the recipients for this patchset.
> > Can you please queue this patch. Many thanks.
>
> OK applying into omap-for-v4.4/dt thanks.
Actually dropping this one, it makes build fail as we don't
have twl4030_madc yet.
Maybe please send a separate set of dts patches for me.
Regards,
Tony
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
2015-10-12 22:20 ` Tony Lindgren
@ 2015-10-12 23:53 ` Sebastian Reichel
-1 siblings, 0 replies; 25+ messages in thread
From: Sebastian Reichel @ 2015-10-12 23:53 UTC (permalink / raw)
To: Tony Lindgren
Cc: Belisko Marek, devicetree, Linux PM mailing list, Neil Brown,
Dr. H. Nikolaus Schaller, LKML, Benoit Cousson, linux-omap,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 846 bytes --]
Hi,
On Mon, Oct 12, 2015 at 03:20:10PM -0700, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [151012 14:43]:
> > * Belisko Marek <marek.belisko@gmail.com> [150926 13:02]:
> > > Tony sorry I forgot to add you to the recipients for this patchset.
> > > Can you please queue this patch. Many thanks.
> >
> > OK applying into omap-for-v4.4/dt thanks.
>
> Actually dropping this one, it makes build fail as we don't
> have twl4030_madc yet.
>
> Maybe please send a separate set of dts patches for me.
mh that's strange, twl4030-madc is there since a long time. But
checking the patch, it seems Marek got the phandle wrong:
$ grep -B1 "ti,twl4030-madc" arch/arm/boot/dts/twl4030.dtsi
twl_madc: madc {
compatible = "ti,twl4030-madc";
Once that is fixed, the patch should have no dependencies.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
@ 2015-10-12 23:53 ` Sebastian Reichel
0 siblings, 0 replies; 25+ messages in thread
From: Sebastian Reichel @ 2015-10-12 23:53 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Mon, Oct 12, 2015 at 03:20:10PM -0700, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [151012 14:43]:
> > * Belisko Marek <marek.belisko@gmail.com> [150926 13:02]:
> > > Tony sorry I forgot to add you to the recipients for this patchset.
> > > Can you please queue this patch. Many thanks.
> >
> > OK applying into omap-for-v4.4/dt thanks.
>
> Actually dropping this one, it makes build fail as we don't
> have twl4030_madc yet.
>
> Maybe please send a separate set of dts patches for me.
mh that's strange, twl4030-madc is there since a long time. But
checking the patch, it seems Marek got the phandle wrong:
$ grep -B1 "ti,twl4030-madc" arch/arm/boot/dts/twl4030.dtsi
twl_madc: madc {
compatible = "ti,twl4030-madc";
Once that is fixed, the patch should have no dependencies.
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151013/d9f28361/attachment.sig>
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
2015-10-12 23:53 ` Sebastian Reichel
@ 2015-10-13 6:43 ` Belisko Marek
-1 siblings, 0 replies; 25+ messages in thread
From: Belisko Marek @ 2015-10-13 6:43 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Tony Lindgren, devicetree, Linux PM mailing list, Neil Brown,
Dr. H. Nikolaus Schaller, LKML, Benoit Cousson, linux-omap,
linux-arm-kernel
Hi,
On Tue, Oct 13, 2015 at 1:53 AM, Sebastian Reichel <sre@kernel.org> wrote:
> Hi,
>
> On Mon, Oct 12, 2015 at 03:20:10PM -0700, Tony Lindgren wrote:
>> * Tony Lindgren <tony@atomide.com> [151012 14:43]:
>> > * Belisko Marek <marek.belisko@gmail.com> [150926 13:02]:
>> > > Tony sorry I forgot to add you to the recipients for this patchset.
>> > > Can you please queue this patch. Many thanks.
>> >
>> > OK applying into omap-for-v4.4/dt thanks.
>>
>> Actually dropping this one, it makes build fail as we don't
>> have twl4030_madc yet.
>>
>> Maybe please send a separate set of dts patches for me.
>
> mh that's strange, twl4030-madc is there since a long time. But
> checking the patch, it seems Marek got the phandle wrong:
OK, thanks for letting me know. I'll send update soon. Thanks.
>
> $ grep -B1 "ti,twl4030-madc" arch/arm/boot/dts/twl4030.dtsi
> twl_madc: madc {
> compatible = "ti,twl4030-madc";
>
> Once that is fixed, the patch should have no dependencies.
>
> -- Sebastian
BR,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode
@ 2015-10-13 6:43 ` Belisko Marek
0 siblings, 0 replies; 25+ messages in thread
From: Belisko Marek @ 2015-10-13 6:43 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Tue, Oct 13, 2015 at 1:53 AM, Sebastian Reichel <sre@kernel.org> wrote:
> Hi,
>
> On Mon, Oct 12, 2015 at 03:20:10PM -0700, Tony Lindgren wrote:
>> * Tony Lindgren <tony@atomide.com> [151012 14:43]:
>> > * Belisko Marek <marek.belisko@gmail.com> [150926 13:02]:
>> > > Tony sorry I forgot to add you to the recipients for this patchset.
>> > > Can you please queue this patch. Many thanks.
>> >
>> > OK applying into omap-for-v4.4/dt thanks.
>>
>> Actually dropping this one, it makes build fail as we don't
>> have twl4030_madc yet.
>>
>> Maybe please send a separate set of dts patches for me.
>
> mh that's strange, twl4030-madc is there since a long time. But
> checking the patch, it seems Marek got the phandle wrong:
OK, thanks for letting me know. I'll send update soon. Thanks.
>
> $ grep -B1 "ti,twl4030-madc" arch/arm/boot/dts/twl4030.dtsi
> twl_madc: madc {
> compatible = "ti,twl4030-madc";
>
> Once that is fixed, the patch should have no dependencies.
>
> -- Sebastian
BR,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH] ARM: dts: twl4030: Add iio properties for bci subnode
2015-09-25 20:20 ` Marek Belisko
` (3 preceding siblings ...)
(?)
@ 2015-10-13 20:08 ` Marek Belisko
-1 siblings, 0 replies; 25+ messages in thread
From: Marek Belisko @ 2015-10-13 20:08 UTC (permalink / raw)
To: tony, sre, dbaryshkov, dwmw2
Cc: neilb, hns, linux-kernel, devicetree, Marek Belisko
Added new iio properties which are required for twl4030-charger driver and
allow to use twl4030-madc indirectly.
Signed-off-by: Marek Belisko <marek@goldelico.com>
---
arch/arm/boot/dts/twl4030.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/twl4030.dtsi b/arch/arm/boot/dts/twl4030.dtsi
index 36ae916..c8197f2 100644
--- a/arch/arm/boot/dts/twl4030.dtsi
+++ b/arch/arm/boot/dts/twl4030.dtsi
@@ -22,6 +22,8 @@
charger: bci {
compatible = "ti,twl4030-bci";
interrupts = <9>, <2>;
+ io-channels = <&twl_madc 11>;
+ io-channel-name = "vac";
bci3v1-supply = <&vusb3v1>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 25+ messages in thread
end of thread, other threads:[~2015-10-13 20:09 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-25 20:20 [PATCH v3] drivers: power: twl4030_charger: fix link problems when building as module Marek Belisko
2015-09-25 20:20 ` Marek Belisko
2015-09-25 20:20 ` [PATCH v3] Documentation: DT: twl-charger: document new iio properties Marek Belisko
2015-09-25 20:20 ` Marek Belisko
2015-09-25 20:20 ` [PATCH v3] ARM: dts: twl4030: Add iio properties for bci subnode Marek Belisko
2015-09-25 20:20 ` Marek Belisko
2015-09-26 17:29 ` Sebastian Reichel
2015-09-26 17:29 ` Sebastian Reichel
2015-09-26 17:29 ` Sebastian Reichel
2015-09-26 19:58 ` Belisko Marek
2015-09-26 19:58 ` Belisko Marek
2015-09-26 19:58 ` Belisko Marek
2015-10-12 21:38 ` Tony Lindgren
2015-10-12 21:38 ` Tony Lindgren
2015-10-12 21:38 ` Tony Lindgren
2015-10-12 22:20 ` Tony Lindgren
2015-10-12 22:20 ` Tony Lindgren
2015-10-12 22:20 ` Tony Lindgren
2015-10-12 23:53 ` Sebastian Reichel
2015-10-12 23:53 ` Sebastian Reichel
2015-10-13 6:43 ` Belisko Marek
2015-10-13 6:43 ` Belisko Marek
2015-09-26 17:23 ` [PATCH v3] drivers: power: twl4030_charger: fix link problems when building as module Sebastian Reichel
2015-09-26 17:23 ` Sebastian Reichel
2015-10-13 20:08 ` [PATCH] ARM: dts: twl4030: Add iio properties for bci subnode Marek Belisko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.