All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Heiko Schocher <hs@denx.de>
Cc: linux-kernel@vger.kernel.org, Georg.Soffel@bosch-si.com,
	rtc-linux@googlegroups.com,
	Alessandro Zummo <a.zummo@towertech.it>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH] rtc: pcf8563: disable CLKOUT
Date: Tue, 13 Oct 2015 22:17:03 +0200	[thread overview]
Message-ID: <20151013201703.GA3421@piout.net> (raw)
In-Reply-To: <1444712938-22865-1-git-send-email-hs@denx.de>

Hi,

On 13/10/2015 at 07:08:58 +0200, Heiko Schocher wrote :
> Disable the CLKOUT of the RTC after power-up.
> After power-up/reset of the RTC, CLKOUT is enabled by default,
> with CLKOUT enabled the RTC chip has 2-3 times higher power
> consumption. If you do not need CLKOUT, you can disable the
> CLKOUT with setting "disable-clkout" property.
> 

I think you can simply unconditionally disable clkout. My preferred way
of doing what you suggest is probably to register a clock in the CCF. If
the clock is not used, it will be automatically disabled.
It will also provide a generic way of setting the clkout frequency (some
RTC are able to output 32kHZ, 1kHz and 1Hz).

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Heiko Schocher <hs@denx.de>
Cc: linux-kernel@vger.kernel.org, Georg.Soffel@bosch-si.com,
	rtc-linux@googlegroups.com,
	Alessandro Zummo <a.zummo@towertech.it>,
	devicetree@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH] rtc: pcf8563: disable CLKOUT
Date: Tue, 13 Oct 2015 22:17:03 +0200	[thread overview]
Message-ID: <20151013201703.GA3421@piout.net> (raw)
In-Reply-To: <1444712938-22865-1-git-send-email-hs@denx.de>

Hi,

On 13/10/2015 at 07:08:58 +0200, Heiko Schocher wrote :
> Disable the CLKOUT of the RTC after power-up.
> After power-up/reset of the RTC, CLKOUT is enabled by default,
> with CLKOUT enabled the RTC chip has 2-3 times higher power
> consumption. If you do not need CLKOUT, you can disable the
> CLKOUT with setting "disable-clkout" property.
> 

I think you can simply unconditionally disable clkout. My preferred way
of doing what you suggest is probably to register a clock in the CCF. If
the clock is not used, it will be automatically disabled.
It will also provide a generic way of setting the clkout frequency (some
RTC are able to output 32kHZ, 1kHz and 1Hz).

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

  reply	other threads:[~2015-10-13 20:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13  5:08 [PATCH] rtc: pcf8563: disable CLKOUT Heiko Schocher
2015-10-13  5:08 ` Heiko Schocher
2015-10-13  5:08 ` [rtc-linux] " Heiko Schocher
2015-10-13 20:17 ` Alexandre Belloni [this message]
2015-10-13 20:17   ` [rtc-linux] " Alexandre Belloni
2015-10-14  4:19   ` Heiko Schocher
2015-10-14  4:19     ` Heiko Schocher
2015-10-14  4:19     ` [rtc-linux] " Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151013201703.GA3421@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=Georg.Soffel@bosch-si.com \
    --cc=a.zummo@towertech.it \
    --cc=devicetree@vger.kernel.org \
    --cc=hs@denx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.