All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: pabeni@redhat.com
Cc: netdev@vger.kernel.org, corbet@lwn.net, kuznet@ms2.inr.ac.ru,
	jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net
Subject: Re: [PATCH net-next] Revert "ipv4/icmp: redirect messages can use the ingress daddr as source"
Date: Wed, 14 Oct 2015 06:02:03 -0700 (PDT)	[thread overview]
Message-ID: <20151014.060203.761451152118070620.davem@davemloft.net> (raw)
In-Reply-To: <4e53a9f0ca945e532b6598e6bdc7254d2ce47c43.1444825488.git.pabeni@redhat.com>

From: Paolo Abeni <pabeni@redhat.com>
Date: Wed, 14 Oct 2015 14:25:53 +0200

> Revert the commit e2ca690b657f ("ipv4/icmp: redirect messages
> can use the ingress daddr as source"), which tried to introduce a more
> suitable behaviour for ICMP redirect messages generated by VRRP routers.
> However RFC 5798 section 8.1.1 states:
> 
>     The IPv4 source address of an ICMP redirect should be the address
>     that the end-host used when making its next-hop routing decision.
> 
> while said commit used the generating packet destination
> address, which do not match the above and in most cases leads to
> no redirect packets to be generated.
> 
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>

Applied, thanks.

I honestly still didn't like the change at all, but begrudgedly applied
it hoping to avoid people saying crap like "Linux refuses to support VRRP"...

      reply	other threads:[~2015-10-14 12:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 12:25 [PATCH net-next] Revert "ipv4/icmp: redirect messages can use the ingress daddr as source" Paolo Abeni
2015-10-14 13:02 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151014.060203.761451152118070620.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=corbet@lwn.net \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.