All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ronen.arad@intel.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/4] Rightsize IFLA_AF_SPEC size calculation
Date: Wed, 14 Oct 2015 18:44:11 -0700 (PDT)	[thread overview]
Message-ID: <20151014.184411.1172845560887990370.davem@davemloft.net> (raw)
In-Reply-To: <1444802314-28830-1-git-send-email-ronen.arad@intel.com>

From: Ronen Arad <ronen.arad@intel.com>
Date: Tue, 13 Oct 2015 22:58:30 -0700

> if_nlmsg_size() overestimates the minimum allocation size of netlink dump
> request (when called from rtnl_calcit()) or the size of the message (when called
> from rtnl_getlink()). This is because ext_filter_mask is not supported by
> rtnl_link_get_af_size() and rtnl_link_get_size().
> 
> The over-estimation is significant when at least one netdev has many VLANs
> configured (8 bytes for each configured VLAN).
> 
> This patch-set "rightsizes" the protocol specific attribute size calculation by
> propagating ext_filter_mask to rtnl_link_get_af_size() and adding optional
> filtering aware get_af_size_filtered op in struct rtnl_af_ops. Bridge module,
> which already used filtering aware sizing for notification, is enhanced to do
> the same for netlink dump requests.

There are only three implementations of get_link_af_size, so please just simply
change it's signature by adding the ext_filter_mask parameter instead of creating
a completely new operation.

  parent reply	other threads:[~2015-10-15  1:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14  5:58 [PATCH net-next 0/4] Rightsize IFLA_AF_SPEC size calculation Ronen Arad
2015-10-14  5:58 ` [PATCH net-next 1/4] rtnetlink: Add get_link_af_size_filtered to rtnl_af_ops Ronen Arad
2015-10-14  9:55   ` Jiri Benc
2015-10-14 14:46     ` Arad, Ronen
2015-10-14  5:58 ` [PATCH net-next 2/4] bridge: br_af_ops add br_get_link_af_size_filtered Ronen Arad
2015-10-14  5:58 ` [PATCH net-next 3/4] rtnetlink: Prefer filtering-aware af sizing Ronen Arad
2015-10-14  5:58 ` [PATCH net-next 4/4] bridge: Remove br_get_link_af_size Ronen Arad
2015-10-14 15:51 ` [PATCH net-next v2] netlink: Rightsize IFLA_AF_SPEC size calculation Ronen Arad
2015-10-15  2:24   ` David Miller
2015-10-15  5:52     ` Arad, Ronen
2015-10-15  5:50   ` [PATCH net-next v3] " Ronen Arad
2015-10-15 13:02     ` David Miller
2015-10-19 16:23     ` Ronen Arad
2015-10-21  6:31       ` Samudrala, Sridhar
2015-10-22  2:15       ` David Miller
2015-10-15  1:44 ` David Miller [this message]
2015-10-15  1:32   ` [PATCH net-next 0/4] " Arad, Ronen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151014.184411.1172845560887990370.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=ronen.arad@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.