All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Arad, Ronen" <ronen.arad@intel.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net-next v2] netlink: Rightsize IFLA_AF_SPEC size calculation
Date: Thu, 15 Oct 2015 05:52:40 +0000	[thread overview]
Message-ID: <E4CD12F19ABA0C4D8729E087A761DC350F7AD4DB@ORSMSX101.amr.corp.intel.com> (raw)
In-Reply-To: <20151014.192422.1272488031691006858.davem@davemloft.net>



>-----Original Message-----
>From: David Miller [mailto:davem@davemloft.net]
>Sent: Wednesday, October 14, 2015 7:24 PM
>To: Arad, Ronen
>Cc: netdev@vger.kernel.org
>Subject: Re: [PATCH net-next v2] netlink: Rightsize IFLA_AF_SPEC size
>calculation
>
>From: Ronen Arad <ronen.arad@intel.com>
>Date: Wed, 14 Oct 2015 08:51:28 -0700
>
>> @@ -900,7 +901,7 @@ static noinline size_t if_nlmsg_size(const struct
>net_device *dev,
>>  	       + rtnl_vfinfo_size(dev, ext_filter_mask) /* IFLA_VFINFO_LIST */
>>  	       + rtnl_port_size(dev, ext_filter_mask) /* IFLA_VF_PORTS +
>IFLA_PORT_SELF */
>>  	       + rtnl_link_get_size(dev) /* IFLA_LINKINFO */
>> -	       + rtnl_link_get_af_size(dev) /* IFLA_AF_SPEC */
>> +		+ rtnl_link_get_af_size(dev, ext_filter_mask) /* IFLA_AF_SPEC */
>>  	       + nla_total_size(MAX_PHYS_ITEM_ID_LEN) /* IFLA_PHYS_PORT_ID */
>
>Please don't change the indentation on this line, keep it matching
>the indentation of all of the surrounding lines of this expression.
[@Ronen] Sure. V3 submitted. My editor didn't like the indentation of the
surrounding lines which are one less than two TAB spaces but consistency
is important. 
>
>Thanks.

  reply	other threads:[~2015-10-15  5:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14  5:58 [PATCH net-next 0/4] Rightsize IFLA_AF_SPEC size calculation Ronen Arad
2015-10-14  5:58 ` [PATCH net-next 1/4] rtnetlink: Add get_link_af_size_filtered to rtnl_af_ops Ronen Arad
2015-10-14  9:55   ` Jiri Benc
2015-10-14 14:46     ` Arad, Ronen
2015-10-14  5:58 ` [PATCH net-next 2/4] bridge: br_af_ops add br_get_link_af_size_filtered Ronen Arad
2015-10-14  5:58 ` [PATCH net-next 3/4] rtnetlink: Prefer filtering-aware af sizing Ronen Arad
2015-10-14  5:58 ` [PATCH net-next 4/4] bridge: Remove br_get_link_af_size Ronen Arad
2015-10-14 15:51 ` [PATCH net-next v2] netlink: Rightsize IFLA_AF_SPEC size calculation Ronen Arad
2015-10-15  2:24   ` David Miller
2015-10-15  5:52     ` Arad, Ronen [this message]
2015-10-15  5:50   ` [PATCH net-next v3] " Ronen Arad
2015-10-15 13:02     ` David Miller
2015-10-19 16:23     ` Ronen Arad
2015-10-21  6:31       ` Samudrala, Sridhar
2015-10-22  2:15       ` David Miller
2015-10-15  1:44 ` [PATCH net-next 0/4] " David Miller
2015-10-15  1:32   ` Arad, Ronen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E4CD12F19ABA0C4D8729E087A761DC350F7AD4DB@ORSMSX101.amr.corp.intel.com \
    --to=ronen.arad@intel.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.