* [PATCH] Staging: rtl8712: rtl8712_xmit: Remove unnecessary cast
@ 2015-10-14 12:29 Shivani Bhardwaj
2015-10-14 12:44 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Shivani Bhardwaj @ 2015-10-14 12:29 UTC (permalink / raw)
To: outreachy-kernel
Explicit typecasting of variables is not required and should be removed.
Semantic patch used:
@@
type T;
T e;
identifier x;
@@
* T x = (T)e;
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
drivers/staging/rtl8712/rtl8712_xmit.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c
index 86206d3..9e50bbf 100644
--- a/drivers/staging/rtl8712/rtl8712_xmit.c
+++ b/drivers/staging/rtl8712/rtl8712_xmit.c
@@ -96,7 +96,7 @@ static u32 get_ff_hwaddr(struct xmit_frame *pxmitframe)
u32 addr = 0;
struct pkt_attrib *pattrib = &pxmitframe->attrib;
struct _adapter *padapter = pxmitframe->padapter;
- struct dvobj_priv *pdvobj = (struct dvobj_priv *)&padapter->dvobjpriv;
+ struct dvobj_priv *pdvobj = &padapter->dvobjpriv;
if (pxmitframe->frame_tag == TXAGG_FRAMETAG)
addr = RTL8712_DMA_H2CCMD;
@@ -237,7 +237,7 @@ void r8712_do_queue_select(struct _adapter *padapter,
struct pkt_attrib *pattrib)
{
unsigned int qsel = 0;
- struct dvobj_priv *pdvobj = (struct dvobj_priv *)&padapter->dvobjpriv;
+ struct dvobj_priv *pdvobj = &padapter->dvobjpriv;
if (pdvobj->nr_endpoint == 6)
qsel = (unsigned int) pattrib->priority;
@@ -374,8 +374,8 @@ u8 r8712_dump_aggr_xframe(struct xmit_buf *pxmitbuf,
struct xmit_frame *pxmitframe)
{
struct _adapter *padapter = pxmitframe->padapter;
- struct dvobj_priv *pdvobj = (struct dvobj_priv *) &padapter->dvobjpriv;
- struct tx_desc *ptxdesc = (struct tx_desc *)pxmitbuf->pbuf;
+ struct dvobj_priv *pdvobj = &padapter->dvobjpriv;
+ struct tx_desc *ptxdesc = pxmitbuf->pbuf;
struct cmd_hdr *pcmd_hdr = (struct cmd_hdr *)
(pxmitbuf->pbuf + TXDESC_SIZE);
u16 total_length = (u16) (ptxdesc->txdw0 & 0xffff);
@@ -419,10 +419,10 @@ static void update_txdesc(struct xmit_frame *pxmitframe, uint *pmem, int sz)
struct qos_priv *pqospriv = &pmlmepriv->qospriv;
struct security_priv *psecuritypriv = &padapter->securitypriv;
struct pkt_attrib *pattrib = &pxmitframe->attrib;
- struct tx_desc *ptxdesc = (struct tx_desc *)pmem;
- struct dvobj_priv *pdvobj = (struct dvobj_priv *)&padapter->dvobjpriv;
+ struct tx_desc *ptxdesc = (struct tx_desc *)pmem;
+ struct dvobj_priv *pdvobj = &padapter->dvobjpriv;
#ifdef CONFIG_R8712_TX_AGGR
- struct cmd_priv *pcmdpriv = (struct cmd_priv *)&padapter->cmdpriv;
+ struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
#endif
u8 blnSetTxDescOffset;
sint bmcst = IS_MCAST(pattrib->ra);
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Outreachy kernel] [PATCH] Staging: rtl8712: rtl8712_xmit: Remove unnecessary cast
2015-10-14 12:29 [PATCH] Staging: rtl8712: rtl8712_xmit: Remove unnecessary cast Shivani Bhardwaj
@ 2015-10-14 12:44 ` Julia Lawall
2015-10-14 13:26 ` Shivani Bhardwaj
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2015-10-14 12:44 UTC (permalink / raw)
To: Shivani Bhardwaj; +Cc: outreachy-kernel
On Wed, 14 Oct 2015, Shivani Bhardwaj wrote:
> Explicit typecasting of variables is not required and should be removed.
> Semantic patch used:
> @@
> type T;
> T e;
> identifier x;
> @@
>
> * T x = (T)e;
>
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
> drivers/staging/rtl8712/rtl8712_xmit.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c
> index 86206d3..9e50bbf 100644
> --- a/drivers/staging/rtl8712/rtl8712_xmit.c
> +++ b/drivers/staging/rtl8712/rtl8712_xmit.c
> @@ -96,7 +96,7 @@ static u32 get_ff_hwaddr(struct xmit_frame *pxmitframe)
> u32 addr = 0;
> struct pkt_attrib *pattrib = &pxmitframe->attrib;
> struct _adapter *padapter = pxmitframe->padapter;
> - struct dvobj_priv *pdvobj = (struct dvobj_priv *)&padapter->dvobjpriv;
> + struct dvobj_priv *pdvobj = &padapter->dvobjpriv;
>
> if (pxmitframe->frame_tag == TXAGG_FRAMETAG)
> addr = RTL8712_DMA_H2CCMD;
> @@ -237,7 +237,7 @@ void r8712_do_queue_select(struct _adapter *padapter,
> struct pkt_attrib *pattrib)
> {
> unsigned int qsel = 0;
> - struct dvobj_priv *pdvobj = (struct dvobj_priv *)&padapter->dvobjpriv;
> + struct dvobj_priv *pdvobj = &padapter->dvobjpriv;
>
> if (pdvobj->nr_endpoint == 6)
> qsel = (unsigned int) pattrib->priority;
> @@ -374,8 +374,8 @@ u8 r8712_dump_aggr_xframe(struct xmit_buf *pxmitbuf,
> struct xmit_frame *pxmitframe)
> {
> struct _adapter *padapter = pxmitframe->padapter;
> - struct dvobj_priv *pdvobj = (struct dvobj_priv *) &padapter->dvobjpriv;
> - struct tx_desc *ptxdesc = (struct tx_desc *)pxmitbuf->pbuf;
> + struct dvobj_priv *pdvobj = &padapter->dvobjpriv;
> + struct tx_desc *ptxdesc = pxmitbuf->pbuf;
It looks like you have added some space before the =. I don't think that
is needed. It wasn't lined up with the previous declaration before, and
it's not lined up with the = on the next line either.
julia
> struct cmd_hdr *pcmd_hdr = (struct cmd_hdr *)
> (pxmitbuf->pbuf + TXDESC_SIZE);
> u16 total_length = (u16) (ptxdesc->txdw0 & 0xffff);
> @@ -419,10 +419,10 @@ static void update_txdesc(struct xmit_frame *pxmitframe, uint *pmem, int sz)
> struct qos_priv *pqospriv = &pmlmepriv->qospriv;
> struct security_priv *psecuritypriv = &padapter->securitypriv;
> struct pkt_attrib *pattrib = &pxmitframe->attrib;
> - struct tx_desc *ptxdesc = (struct tx_desc *)pmem;
> - struct dvobj_priv *pdvobj = (struct dvobj_priv *)&padapter->dvobjpriv;
> + struct tx_desc *ptxdesc = (struct tx_desc *)pmem;
> + struct dvobj_priv *pdvobj = &padapter->dvobjpriv;
> #ifdef CONFIG_R8712_TX_AGGR
> - struct cmd_priv *pcmdpriv = (struct cmd_priv *)&padapter->cmdpriv;
> + struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
> #endif
> u8 blnSetTxDescOffset;
> sint bmcst = IS_MCAST(pattrib->ra);
> --
> 2.1.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151014122915.GA11874%40ubuntu.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Outreachy kernel] [PATCH] Staging: rtl8712: rtl8712_xmit: Remove unnecessary cast
2015-10-14 12:44 ` [Outreachy kernel] " Julia Lawall
@ 2015-10-14 13:26 ` Shivani Bhardwaj
0 siblings, 0 replies; 3+ messages in thread
From: Shivani Bhardwaj @ 2015-10-14 13:26 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel
On Wed, Oct 14, 2015 at 6:14 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Wed, 14 Oct 2015, Shivani Bhardwaj wrote:
>
>> Explicit typecasting of variables is not required and should be removed.
>> Semantic patch used:
>> @@
>> type T;
>> T e;
>> identifier x;
>> @@
>>
>> * T x = (T)e;
>>
>> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
>> ---
>> drivers/staging/rtl8712/rtl8712_xmit.c | 14 +++++++-------
>> 1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c
>> index 86206d3..9e50bbf 100644
>> --- a/drivers/staging/rtl8712/rtl8712_xmit.c
>> +++ b/drivers/staging/rtl8712/rtl8712_xmit.c
>> @@ -96,7 +96,7 @@ static u32 get_ff_hwaddr(struct xmit_frame *pxmitframe)
>> u32 addr = 0;
>> struct pkt_attrib *pattrib = &pxmitframe->attrib;
>> struct _adapter *padapter = pxmitframe->padapter;
>> - struct dvobj_priv *pdvobj = (struct dvobj_priv *)&padapter->dvobjpriv;
>> + struct dvobj_priv *pdvobj = &padapter->dvobjpriv;
>>
>> if (pxmitframe->frame_tag == TXAGG_FRAMETAG)
>> addr = RTL8712_DMA_H2CCMD;
>> @@ -237,7 +237,7 @@ void r8712_do_queue_select(struct _adapter *padapter,
>> struct pkt_attrib *pattrib)
>> {
>> unsigned int qsel = 0;
>> - struct dvobj_priv *pdvobj = (struct dvobj_priv *)&padapter->dvobjpriv;
>> + struct dvobj_priv *pdvobj = &padapter->dvobjpriv;
>>
>> if (pdvobj->nr_endpoint == 6)
>> qsel = (unsigned int) pattrib->priority;
>> @@ -374,8 +374,8 @@ u8 r8712_dump_aggr_xframe(struct xmit_buf *pxmitbuf,
>> struct xmit_frame *pxmitframe)
>> {
>> struct _adapter *padapter = pxmitframe->padapter;
>> - struct dvobj_priv *pdvobj = (struct dvobj_priv *) &padapter->dvobjpriv;
>> - struct tx_desc *ptxdesc = (struct tx_desc *)pxmitbuf->pbuf;
>> + struct dvobj_priv *pdvobj = &padapter->dvobjpriv;
>> + struct tx_desc *ptxdesc = pxmitbuf->pbuf;
>
> It looks like you have added some space before the =. I don't think that
> is needed. It wasn't lined up with the previous declaration before, and
> it's not lined up with the = on the next line either.
>
> julia
>
I'm fixing that.
Thanks.
>> struct cmd_hdr *pcmd_hdr = (struct cmd_hdr *)
>> (pxmitbuf->pbuf + TXDESC_SIZE);
>> u16 total_length = (u16) (ptxdesc->txdw0 & 0xffff);
>> @@ -419,10 +419,10 @@ static void update_txdesc(struct xmit_frame *pxmitframe, uint *pmem, int sz)
>> struct qos_priv *pqospriv = &pmlmepriv->qospriv;
>> struct security_priv *psecuritypriv = &padapter->securitypriv;
>> struct pkt_attrib *pattrib = &pxmitframe->attrib;
>> - struct tx_desc *ptxdesc = (struct tx_desc *)pmem;
>> - struct dvobj_priv *pdvobj = (struct dvobj_priv *)&padapter->dvobjpriv;
>> + struct tx_desc *ptxdesc = (struct tx_desc *)pmem;
>> + struct dvobj_priv *pdvobj = &padapter->dvobjpriv;
>> #ifdef CONFIG_R8712_TX_AGGR
>> - struct cmd_priv *pcmdpriv = (struct cmd_priv *)&padapter->cmdpriv;
>> + struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
>> #endif
>> u8 blnSetTxDescOffset;
>> sint bmcst = IS_MCAST(pattrib->ra);
>> --
>> 2.1.0
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151014122915.GA11874%40ubuntu.
>> For more options, visit https://groups.google.com/d/optout.
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-14 13:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-14 12:29 [PATCH] Staging: rtl8712: rtl8712_xmit: Remove unnecessary cast Shivani Bhardwaj
2015-10-14 12:44 ` [Outreachy kernel] " Julia Lawall
2015-10-14 13:26 ` Shivani Bhardwaj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.