[Qemu-devel] [Bug 1497711] [NEW] tests/libqos/ahci.c:745: redundant condition ?

[Qemu-devel] [Bug 1497711] [NEW] tests/libqos/ahci.c:745: redundant condition ?

[dcb]

Public bug reported:

[qemu/tests/libqos/ahci.c:745]: (style) Redundant condition: props.ncq.
'!props.ncq || (props.ncq && props.lba48)' is equivalent to '!props.ncq
|| props.lba48'

    g_assert(!props->ncq || (props->ncq && props->lba48));

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1497711

Title:
  tests/libqos/ahci.c:745: redundant condition ?

Status in QEMU:
  New

Bug description:
  [qemu/tests/libqos/ahci.c:745]: (style) Redundant condition:
  props.ncq. '!props.ncq || (props.ncq && props.lba48)' is equivalent to
  '!props.ncq || props.lba48'

      g_assert(!props->ncq || (props->ncq && props->lba48));

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1497711/+subscriptions

Re: [Qemu-devel] [Bug 1497711] [NEW] tests/libqos/ahci.c:745: redundant condition ?

[Stefan Hajnoczi]

On Sun, Sep 20, 2015 at 10:08:49AM -0000, dcb wrote:
> Public bug reported:
> 
> [qemu/tests/libqos/ahci.c:745]: (style) Redundant condition: props.ncq.
> '!props.ncq || (props.ncq && props.lba48)' is equivalent to '!props.ncq
> || props.lba48'
> 
>     g_assert(!props->ncq || (props->ncq && props->lba48));

CCing John Snow, AHCI maintainer

[Qemu-devel] [Bug 1497711] Re: tests/libqos/ahci.c:745: redundant condition ?

[Stefan Hajnoczi]

Fixed in:

commit 3d937150dce20cb95cbaae99b6fd48dca4261f32
Author: John Snow <jsnow@redhat.com>
Date:   Mon Oct 5 12:00:55 2015 -0400

    qtest/ahci: fix redundant assertion
    
    Fixes https://bugs.launchpad.net/qemu/+bug/1497711
    
    (!ncq || (ncq && lba48)) is the same as
    (!ncq || lba48).
    
    The intention is simply: "If a command is NCQ,
    it must also be LBA48."
    
    Signed-off-by: John Snow <jsnow@redhat.com>
    Message-id: 1442868929-17777-1-git-send-email-jsnow@redhat.com

** Changed in: qemu
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1497711

Title:
  tests/libqos/ahci.c:745: redundant condition ?

Status in QEMU:
  Fix Committed

Bug description:
  [qemu/tests/libqos/ahci.c:745]: (style) Redundant condition:
  props.ncq. '!props.ncq || (props.ncq && props.lba48)' is equivalent to
  '!props.ncq || props.lba48'

      g_assert(!props->ncq || (props->ncq && props->lba48));

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1497711/+subscriptions

[Qemu-devel] [Bug 1497711] Re: tests/libqos/ahci.c:745: redundant condition ?

[T. Huth]

** Changed in: qemu
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1497711

Title:
  tests/libqos/ahci.c:745: redundant condition ?

Status in QEMU:
  Fix Released

Bug description:
  [qemu/tests/libqos/ahci.c:745]: (style) Redundant condition:
  props.ncq. '!props.ncq || (props.ncq && props.lba48)' is equivalent to
  '!props.ncq || props.lba48'

      g_assert(!props->ncq || (props->ncq && props->lba48));

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1497711/+subscriptions