* [PATCH] ACPI / property: Fix subnode lookup scope for data-only subnodes
@ 2015-10-20 23:51 Rafael J. Wysocki
2015-10-21 13:20 ` Mika Westerberg
0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2015-10-20 23:51 UTC (permalink / raw)
To: ACPI Devel Maling List
Cc: Linux Kernel Mailing List, Mika Westerberg, Darren Hart
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
The correct scope for looking up the objects to generate data packages for
data-only subnodes pointed to by another data-only subnode is the scope
of the parent of that subnode and not the scope containing the _DSD object
at the top of the hierarchy (the latter works only if all of the objects
returning data-only subnode packages in a given hierarchy are in the same
scope).
Fix the code to work as expected.
Fixes: 445b0eb058f5 (ACPI / property: Add support for data-only subnodes)
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
On top of linux-next.
Thanks,
Rafael
---
drivers/acpi/property.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
Index: linux-pm/drivers/acpi/property.c
===================================================================
--- linux-pm.orig/drivers/acpi/property.c
+++ linux-pm/drivers/acpi/property.c
@@ -71,7 +71,14 @@ static bool acpi_nondev_subnode_ok(acpi_
if (acpi_extract_properties(buf.pointer, &dn->data))
dn->handle = handle;
- if (acpi_enumerate_nondev_subnodes(scope, buf.pointer, &dn->data))
+ /*
+ * The scope for the subnode object lookup is the one of the namespace
+ * node (device) containing the object that has returned the package.
+ * That is, it's the scope of that object's parent.
+ */
+ status = acpi_get_parent(handle, &scope);
+ if (ACPI_SUCCESS(status)
+ && acpi_enumerate_nondev_subnodes(scope, buf.pointer, &dn->data))
dn->handle = handle;
if (dn->handle) {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI / property: Fix subnode lookup scope for data-only subnodes
2015-10-20 23:51 [PATCH] ACPI / property: Fix subnode lookup scope for data-only subnodes Rafael J. Wysocki
@ 2015-10-21 13:20 ` Mika Westerberg
2015-10-21 23:44 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Mika Westerberg @ 2015-10-21 13:20 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: ACPI Devel Maling List, Linux Kernel Mailing List, Darren Hart
On Wed, Oct 21, 2015 at 01:51:24AM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The correct scope for looking up the objects to generate data packages for
> data-only subnodes pointed to by another data-only subnode is the scope
> of the parent of that subnode and not the scope containing the _DSD object
> at the top of the hierarchy (the latter works only if all of the objects
> returning data-only subnode packages in a given hierarchy are in the same
> scope).
>
> Fix the code to work as expected.
>
> Fixes: 445b0eb058f5 (ACPI / property: Add support for data-only subnodes)
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
All my tests still pass so you can also add
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI / property: Fix subnode lookup scope for data-only subnodes
2015-10-21 13:20 ` Mika Westerberg
@ 2015-10-21 23:44 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2015-10-21 23:44 UTC (permalink / raw)
To: Mika Westerberg
Cc: ACPI Devel Maling List, Linux Kernel Mailing List, Darren Hart
On Wednesday, October 21, 2015 04:20:36 PM Mika Westerberg wrote:
> On Wed, Oct 21, 2015 at 01:51:24AM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > The correct scope for looking up the objects to generate data packages for
> > data-only subnodes pointed to by another data-only subnode is the scope
> > of the parent of that subnode and not the scope containing the _DSD object
> > at the top of the hierarchy (the latter works only if all of the objects
> > returning data-only subnode packages in a given hierarchy are in the same
> > scope).
> >
> > Fix the code to work as expected.
> >
> > Fixes: 445b0eb058f5 (ACPI / property: Add support for data-only subnodes)
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> All my tests still pass so you can also add
>
> Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-21 23:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-20 23:51 [PATCH] ACPI / property: Fix subnode lookup scope for data-only subnodes Rafael J. Wysocki
2015-10-21 13:20 ` Mika Westerberg
2015-10-21 23:44 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.