All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tools lib traceevent: Support %ps/%pS
@ 2015-08-31 21:16 Scott Wood
  2015-10-22 17:07 ` Steven Rostedt
  2015-10-23  8:30 ` [tip:perf/core] " tip-bot for Scott Wood
  0 siblings, 2 replies; 4+ messages in thread
From: Scott Wood @ 2015-08-31 21:16 UTC (permalink / raw)
  To: linux-kernel, Steven Rostedt; +Cc: Dave Chinner

Commits such as 65dd297ac25565 ("xfs: %pF is only for function
pointers") caused a regression because pretty_print() didn't support
%ps/%pS.  The current %pf/%pF implementation in pretty_print() is what
%ps/%pS is supposed to do, so use the same code for %ps/%pS.

Addressing the incorrect %pf/%pF implementation is beyond the scope of
this patch.

Signed-off-by: Scott Wood <scottwood@freescale.com>
---
 tools/lib/traceevent/event-parse.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index cc25f05..f05e5b0 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -4761,8 +4761,8 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
 				else
 					ls = 2;
 
-				if (*(ptr+1) == 'F' ||
-				    *(ptr+1) == 'f') {
+				if (*(ptr+1) == 'F' || *(ptr+1) == 'f' ||
+				    *(ptr+1) == 'S' || *(ptr+1) == 's') {
 					ptr++;
 					show_func = *ptr;
 				} else if (*(ptr+1) == 'M' || *(ptr+1) == 'm') {
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] tools lib traceevent: Support %ps/%pS
  2015-08-31 21:16 [PATCH] tools lib traceevent: Support %ps/%pS Scott Wood
@ 2015-10-22 17:07 ` Steven Rostedt
  2015-10-22 18:26   ` Arnaldo Carvalho de Melo
  2015-10-23  8:30 ` [tip:perf/core] " tip-bot for Scott Wood
  1 sibling, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2015-10-22 17:07 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo; +Cc: Scott Wood, linux-kernel, Dave Chinner


This fell through the abyss of my INBOX.

Arnaldo, can you take this.

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve


On Mon, 31 Aug 2015 16:16:37 -0500
Scott Wood <scottwood@freescale.com> wrote:

> Commits such as 65dd297ac25565 ("xfs: %pF is only for function
> pointers") caused a regression because pretty_print() didn't support
> %ps/%pS.  The current %pf/%pF implementation in pretty_print() is what
> %ps/%pS is supposed to do, so use the same code for %ps/%pS.
> 
> Addressing the incorrect %pf/%pF implementation is beyond the scope of
> this patch.
> 
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
>  tools/lib/traceevent/event-parse.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index cc25f05..f05e5b0 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -4761,8 +4761,8 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
>  				else
>  					ls = 2;
>  
> -				if (*(ptr+1) == 'F' ||
> -				    *(ptr+1) == 'f') {
> +				if (*(ptr+1) == 'F' || *(ptr+1) == 'f' ||
> +				    *(ptr+1) == 'S' || *(ptr+1) == 's') {
>  					ptr++;
>  					show_func = *ptr;
>  				} else if (*(ptr+1) == 'M' || *(ptr+1) == 'm') {


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] tools lib traceevent: Support %ps/%pS
  2015-10-22 17:07 ` Steven Rostedt
@ 2015-10-22 18:26   ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-10-22 18:26 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Scott Wood, linux-kernel, Dave Chinner

Em Thu, Oct 22, 2015 at 01:07:29PM -0400, Steven Rostedt escreveu:
> 
> This fell through the abyss of my INBOX.
> 
> Arnaldo, can you take this.

Sure
 
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
> 
> -- Steve
> 
> 
> On Mon, 31 Aug 2015 16:16:37 -0500
> Scott Wood <scottwood@freescale.com> wrote:
> 
> > Commits such as 65dd297ac25565 ("xfs: %pF is only for function
> > pointers") caused a regression because pretty_print() didn't support
> > %ps/%pS.  The current %pf/%pF implementation in pretty_print() is what
> > %ps/%pS is supposed to do, so use the same code for %ps/%pS.
> > 
> > Addressing the incorrect %pf/%pF implementation is beyond the scope of
> > this patch.
> > 
> > Signed-off-by: Scott Wood <scottwood@freescale.com>
> > ---
> >  tools/lib/traceevent/event-parse.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> > index cc25f05..f05e5b0 100644
> > --- a/tools/lib/traceevent/event-parse.c
> > +++ b/tools/lib/traceevent/event-parse.c
> > @@ -4761,8 +4761,8 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
> >  				else
> >  					ls = 2;
> >  
> > -				if (*(ptr+1) == 'F' ||
> > -				    *(ptr+1) == 'f') {
> > +				if (*(ptr+1) == 'F' || *(ptr+1) == 'f' ||
> > +				    *(ptr+1) == 'S' || *(ptr+1) == 's') {
> >  					ptr++;
> >  					show_func = *ptr;
> >  				} else if (*(ptr+1) == 'M' || *(ptr+1) == 'm') {

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [tip:perf/core] tools lib traceevent: Support %ps/%pS
  2015-08-31 21:16 [PATCH] tools lib traceevent: Support %ps/%pS Scott Wood
  2015-10-22 17:07 ` Steven Rostedt
@ 2015-10-23  8:30 ` tip-bot for Scott Wood
  1 sibling, 0 replies; 4+ messages in thread
From: tip-bot for Scott Wood @ 2015-10-23  8:30 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: rostedt, david, tglx, acme, linux-kernel, scottwood, mingo, hpa

Commit-ID:  b6bd9c7d543ac160646a667470158c5da319a85c
Gitweb:     http://git.kernel.org/tip/b6bd9c7d543ac160646a667470158c5da319a85c
Author:     Scott Wood <scottwood@freescale.com>
AuthorDate: Mon, 31 Aug 2015 16:16:37 -0500
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 22 Oct 2015 15:39:42 -0300

tools lib traceevent: Support %ps/%pS

Commits such as 65dd297ac25565 ("xfs: %pF is only for function
pointers") caused a regression because pretty_print() didn't support
%ps/%pS.  The current %pf/%pF implementation in pretty_print() is what
%ps/%pS is supposed to do, so use the same code for %ps/%pS.

Addressing the incorrect %pf/%pF implementation is beyond the scope of
this patch.

Signed-off-by: Scott Wood <scottwood@freescale.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Dave Chinner <david@fromorbit.com>
Link: http://lkml.kernel.org/r/20150831211637.GA12848@home.buserror.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/lib/traceevent/event-parse.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 9aa107a..2a912df 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -4905,8 +4905,8 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
 				else
 					ls = 2;
 
-				if (*(ptr+1) == 'F' ||
-				    *(ptr+1) == 'f') {
+				if (*(ptr+1) == 'F' || *(ptr+1) == 'f' ||
+				    *(ptr+1) == 'S' || *(ptr+1) == 's') {
 					ptr++;
 					show_func = *ptr;
 				} else if (*(ptr+1) == 'M' || *(ptr+1) == 'm') {

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-23  8:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-31 21:16 [PATCH] tools lib traceevent: Support %ps/%pS Scott Wood
2015-10-22 17:07 ` Steven Rostedt
2015-10-22 18:26   ` Arnaldo Carvalho de Melo
2015-10-23  8:30 ` [tip:perf/core] " tip-bot for Scott Wood

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.