* [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency @ 2015-10-19 3:02 ` Magnus Damm 0 siblings, 0 replies; 11+ messages in thread From: Magnus Damm @ 2015-10-19 3:02 UTC (permalink / raw) To: iommu Cc: laurent.pinchart+renesas, geert+renesas, linux-sh, joro, linux-kernel, horms+renesas, Magnus Damm From: Magnus Damm <damm+renesas@opensource.se> Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get rid of the dependency. Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using: # CONFIG_ARM_LPAE is not set Signed-off-by: Magnus Damm <damm+renesas@opensource.se> --- drivers/iommu/Kconfig | 1 - 1 file changed, 1 deletion(-) --- 0001/drivers/iommu/Kconfig +++ work/drivers/iommu/Kconfig 2015-10-18 14:58:09.080513000 +0900 @@ -324,7 +324,6 @@ config SHMOBILE_IOMMU_L1SIZE config IPMMU_VMSA bool "Renesas VMSA-compatible IPMMU" - depends on ARM_LPAE depends on ARCH_SHMOBILE || COMPILE_TEST select IOMMU_API select IOMMU_IO_PGTABLE_LPAE ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency @ 2015-10-19 3:02 ` Magnus Damm 0 siblings, 0 replies; 11+ messages in thread From: Magnus Damm @ 2015-10-19 3:02 UTC (permalink / raw) To: iommu Cc: laurent.pinchart+renesas, geert+renesas, linux-sh, joro, linux-kernel, horms+renesas, Magnus Damm From: Magnus Damm <damm+renesas@opensource.se> Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get rid of the dependency. Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using: # CONFIG_ARM_LPAE is not set Signed-off-by: Magnus Damm <damm+renesas@opensource.se> --- drivers/iommu/Kconfig | 1 - 1 file changed, 1 deletion(-) --- 0001/drivers/iommu/Kconfig +++ work/drivers/iommu/Kconfig 2015-10-18 14:58:09.080513000 +0900 @@ -324,7 +324,6 @@ config SHMOBILE_IOMMU_L1SIZE config IPMMU_VMSA bool "Renesas VMSA-compatible IPMMU" - depends on ARM_LPAE depends on ARCH_SHMOBILE || COMPILE_TEST select IOMMU_API select IOMMU_IO_PGTABLE_LPAE ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency 2015-10-19 3:02 ` Magnus Damm @ 2015-10-19 6:42 ` Laurent Pinchart -1 siblings, 0 replies; 11+ messages in thread From: Laurent Pinchart @ 2015-10-19 6:42 UTC (permalink / raw) To: Magnus Damm Cc: iommu, laurent.pinchart+renesas, geert+renesas, linux-sh, joro, linux-kernel, horms+renesas Hi Magnus, Thank you for the patch. On Monday 19 October 2015 12:02:53 Magnus Damm wrote: > From: Magnus Damm <damm+renesas@opensource.se> > > Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE > nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get > rid of the dependency. > > Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using: > # CONFIG_ARM_LPAE is not set The driver only supports the 40-bits page table format for now, hence the dependency on LPAE, but it indeed seems that the dependency is bogus. As long as the 8 MSBs of the translated address are all 0 I assume the output 40-bit address is usable on a 32-bit physical address system. How have you tested the patch ? > Signed-off-by: Magnus Damm <damm+renesas@opensource.se> > --- > > drivers/iommu/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > --- 0001/drivers/iommu/Kconfig > +++ work/drivers/iommu/Kconfig 2015-10-18 14:58:09.080513000 +0900 > @@ -324,7 +324,6 @@ config SHMOBILE_IOMMU_L1SIZE > > config IPMMU_VMSA > bool "Renesas VMSA-compatible IPMMU" > - depends on ARM_LPAE > depends on ARCH_SHMOBILE || COMPILE_TEST > select IOMMU_API > select IOMMU_IO_PGTABLE_LPAE -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency @ 2015-10-19 6:42 ` Laurent Pinchart 0 siblings, 0 replies; 11+ messages in thread From: Laurent Pinchart @ 2015-10-19 6:42 UTC (permalink / raw) To: Magnus Damm Cc: iommu, laurent.pinchart+renesas, geert+renesas, linux-sh, joro, linux-kernel, horms+renesas Hi Magnus, Thank you for the patch. On Monday 19 October 2015 12:02:53 Magnus Damm wrote: > From: Magnus Damm <damm+renesas@opensource.se> > > Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE > nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get > rid of the dependency. > > Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using: > # CONFIG_ARM_LPAE is not set The driver only supports the 40-bits page table format for now, hence the dependency on LPAE, but it indeed seems that the dependency is bogus. As long as the 8 MSBs of the translated address are all 0 I assume the output 40-bit address is usable on a 32-bit physical address system. How have you tested the patch ? > Signed-off-by: Magnus Damm <damm+renesas@opensource.se> > --- > > drivers/iommu/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > --- 0001/drivers/iommu/Kconfig > +++ work/drivers/iommu/Kconfig 2015-10-18 14:58:09.080513000 +0900 > @@ -324,7 +324,6 @@ config SHMOBILE_IOMMU_L1SIZE > > config IPMMU_VMSA > bool "Renesas VMSA-compatible IPMMU" > - depends on ARM_LPAE > depends on ARCH_SHMOBILE || COMPILE_TEST > select IOMMU_API > select IOMMU_IO_PGTABLE_LPAE -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency 2015-10-19 6:42 ` Laurent Pinchart (?) @ 2015-10-20 8:54 ` Magnus Damm -1 siblings, 0 replies; 11+ messages in thread From: Magnus Damm @ 2015-10-20 8:54 UTC (permalink / raw) To: Laurent Pinchart Cc: Laurent Pinchart, Geert Uytterhoeven, SH-Linux, linux-kernel, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, Simon Horman Hi Laurent, On Mon, Oct 19, 2015 at 3:42 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > Hi Magnus, > > Thank you for the patch. > > On Monday 19 October 2015 12:02:53 Magnus Damm wrote: >> From: Magnus Damm <damm+renesas@opensource.se> >> >> Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE >> nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get >> rid of the dependency. >> >> Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using: >> # CONFIG_ARM_LPAE is not set > > The driver only supports the 40-bits page table format for now, hence the > dependency on LPAE, but it indeed seems that the dependency is bogus. As long > as the 8 MSBs of the translated address are all 0 I assume the output 40-bit > address is usable on a 32-bit physical address system. > > How have you tested the patch ? Modetest with local IPMMUMX enablement on r8a7794 ALT. Cheers, / magnus ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency @ 2015-10-20 8:54 ` Magnus Damm 0 siblings, 0 replies; 11+ messages in thread From: Magnus Damm @ 2015-10-20 8:54 UTC (permalink / raw) To: Laurent Pinchart Cc: Laurent Pinchart, Geert Uytterhoeven, SH-Linux, linux-kernel, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, Simon Horman Hi Laurent, On Mon, Oct 19, 2015 at 3:42 PM, Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> wrote: > Hi Magnus, > > Thank you for the patch. > > On Monday 19 October 2015 12:02:53 Magnus Damm wrote: >> From: Magnus Damm <damm+renesas-yzvPICuk2ACczHhG9Qg4qA@public.gmane.org> >> >> Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE >> nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get >> rid of the dependency. >> >> Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using: >> # CONFIG_ARM_LPAE is not set > > The driver only supports the 40-bits page table format for now, hence the > dependency on LPAE, but it indeed seems that the dependency is bogus. As long > as the 8 MSBs of the translated address are all 0 I assume the output 40-bit > address is usable on a 32-bit physical address system. > > How have you tested the patch ? Modetest with local IPMMUMX enablement on r8a7794 ALT. Cheers, / magnus ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency @ 2015-10-20 8:54 ` Magnus Damm 0 siblings, 0 replies; 11+ messages in thread From: Magnus Damm @ 2015-10-20 8:54 UTC (permalink / raw) To: Laurent Pinchart Cc: iommu, Laurent Pinchart, Geert Uytterhoeven, SH-Linux, joro, linux-kernel, Simon Horman Hi Laurent, On Mon, Oct 19, 2015 at 3:42 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > Hi Magnus, > > Thank you for the patch. > > On Monday 19 October 2015 12:02:53 Magnus Damm wrote: >> From: Magnus Damm <damm+renesas@opensource.se> >> >> Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE >> nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get >> rid of the dependency. >> >> Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using: >> # CONFIG_ARM_LPAE is not set > > The driver only supports the 40-bits page table format for now, hence the > dependency on LPAE, but it indeed seems that the dependency is bogus. As long > as the 8 MSBs of the translated address are all 0 I assume the output 40-bit > address is usable on a 32-bit physical address system. > > How have you tested the patch ? Modetest with local IPMMUMX enablement on r8a7794 ALT. Cheers, / magnus ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency 2015-10-20 8:54 ` Magnus Damm @ 2015-10-20 10:28 ` Laurent Pinchart -1 siblings, 0 replies; 11+ messages in thread From: Laurent Pinchart @ 2015-10-20 10:28 UTC (permalink / raw) To: Magnus Damm, Geert Uytterhoeven Cc: iommu, SH-Linux, joro, linux-kernel, Simon Horman Hi Magnus, On Tuesday 20 October 2015 17:54:59 Magnus Damm wrote: > On Mon, Oct 19, 2015 at 3:42 PM, Laurent Pinchart wrote: > > On Monday 19 October 2015 12:02:53 Magnus Damm wrote: > >> From: Magnus Damm <damm+renesas@opensource.se> > >> > >> Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE > >> nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get > >> rid of the dependency. > >> > >> Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using: > >> # CONFIG_ARM_LPAE is not set > > > > The driver only supports the 40-bits page table format for now, hence the > > dependency on LPAE, but it indeed seems that the dependency is bogus. As > > long as the 8 MSBs of the translated address are all 0 I assume the > > output 40-bit address is usable on a 32-bit physical address system. > > > > How have you tested the patch ? > > Modetest with local IPMMUMX enablement on r8a7794 ALT. Then, Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency @ 2015-10-20 10:28 ` Laurent Pinchart 0 siblings, 0 replies; 11+ messages in thread From: Laurent Pinchart @ 2015-10-20 10:28 UTC (permalink / raw) To: Magnus Damm, Geert Uytterhoeven Cc: iommu, SH-Linux, joro, linux-kernel, Simon Horman Hi Magnus, On Tuesday 20 October 2015 17:54:59 Magnus Damm wrote: > On Mon, Oct 19, 2015 at 3:42 PM, Laurent Pinchart wrote: > > On Monday 19 October 2015 12:02:53 Magnus Damm wrote: > >> From: Magnus Damm <damm+renesas@opensource.se> > >> > >> Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE > >> nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get > >> rid of the dependency. > >> > >> Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using: > >> # CONFIG_ARM_LPAE is not set > > > > The driver only supports the 40-bits page table format for now, hence the > > dependency on LPAE, but it indeed seems that the dependency is bogus. As > > long as the 8 MSBs of the translated address are all 0 I assume the > > output 40-bit address is usable on a 32-bit physical address system. > > > > How have you tested the patch ? > > Modetest with local IPMMUMX enablement on r8a7794 ALT. Then, Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency 2015-10-19 3:02 ` Magnus Damm @ 2015-10-23 9:49 ` Joerg Roedel -1 siblings, 0 replies; 11+ messages in thread From: Joerg Roedel @ 2015-10-23 9:49 UTC (permalink / raw) To: Magnus Damm Cc: iommu, laurent.pinchart+renesas, geert+renesas, linux-sh, linux-kernel, horms+renesas On Mon, Oct 19, 2015 at 12:02:53PM +0900, Magnus Damm wrote: > From: Magnus Damm <damm+renesas@opensource.se> > > Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE > nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get > rid of the dependency. > > Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using: > # CONFIG_ARM_LPAE is not set > > Signed-off-by: Magnus Damm <damm+renesas@opensource.se> Applied, thanks. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency @ 2015-10-23 9:49 ` Joerg Roedel 0 siblings, 0 replies; 11+ messages in thread From: Joerg Roedel @ 2015-10-23 9:49 UTC (permalink / raw) To: Magnus Damm Cc: iommu, laurent.pinchart+renesas, geert+renesas, linux-sh, linux-kernel, horms+renesas On Mon, Oct 19, 2015 at 12:02:53PM +0900, Magnus Damm wrote: > From: Magnus Damm <damm+renesas@opensource.se> > > Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE > nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get > rid of the dependency. > > Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using: > # CONFIG_ARM_LPAE is not set > > Signed-off-by: Magnus Damm <damm+renesas@opensource.se> Applied, thanks. ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-10-23 9:49 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-10-19 3:02 [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency Magnus Damm 2015-10-19 3:02 ` Magnus Damm 2015-10-19 6:42 ` Laurent Pinchart 2015-10-19 6:42 ` Laurent Pinchart 2015-10-20 8:54 ` Magnus Damm 2015-10-20 8:54 ` Magnus Damm 2015-10-20 8:54 ` Magnus Damm 2015-10-20 10:28 ` Laurent Pinchart 2015-10-20 10:28 ` Laurent Pinchart 2015-10-23 9:49 ` Joerg Roedel 2015-10-23 9:49 ` Joerg Roedel
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.