All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2
@ 2015-10-24 21:00 Romain Naour
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 01/36] package/expedite: move to package directory Romain Naour
                   ` (35 more replies)
  0 siblings, 36 replies; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

This series bump the efl package to the latest stable release and also update
all other packages which use efl.

This series has been tested under Qemu for x86 using the kernel based on
linux config povided in board/qemu/x86. I've enabled CONFIG_FB_CIRRUS
and some other video related options during testing.
An example defconfig can be added in a followup patch.

It also been tested on ARM with a uClibc-ng 1.0.5 + a patch
which has been merged in uClibc-ng 1.0.6 release.
Legacy uClibc toolchains are not supported due to missing mkstemps().

/!\ Warning for autobuilders /!\
All uClibc-ng toolchains must be rebuilt with the latest release.

The libXpresent support has been removed from this series since this
package are not merged in Buildroot yet.

Thanks to an upstream patch from efl 1.15 stable branch, the dependency on
libXp can be removed, so there is no need to (re)add an xlib_libXp package.

Patches  1 and 2 Move expedite and libevas-generic-loaders packages outside of
                 package/efl directory.
Patches  3 to 18 Add a new efl package updated to 1.15.2 and its dependencies.
Patches 19 to 25 Update all other packages which use efl.
Patches 26 to 35 Remove old efl packages.
Patch   36       Add a new package libemotion-generic-players

This is a first part, other packages which use efl are ready and will be
sent in a followup series:

* rage
* terminology
* empc
* ecrire
* python-efl
* econnman
* libetrophy
* elemines
* libcanberra
* e-cho

Thanks to Vicente Bergas for testing on musl!

Since v4:
* Use depends on BR2_PACKAGE_EFL instead of select (ThomasP)
* Add sdl2 support

Since v3:
* fix formating patch issue (rename detection in git)
* keep the efl and libelementary in the same sub-directory (package/efl) in
  order to share the same version number.
* keep the menuconfig BR2_PACKAGE_EFL in package/efl/Config.in

Since v2:
* EFL bump to 1.15.2 instead of 1.15.1
* libelementary bump to 1.15.2 instead of 1.15.2
* enlightenment bump to 0.19.12 instead of 0.19.9
* remove libXp and xproto_printproto packages
* remove libXpresent (can be added later in a followup series)
* add systemd dependency
* enable xinput2.2+

Since v1:
* EFL bump to 1.15.1 instead of 1.14.2
* libelementary bump to 1.15.1 instead of 1.14.2
* enlightenment bump to 0.19.9 instead of 0.19.7

Best regards,
Romain Naour


Romain Naour (35):
  package/expedite: move to package directory
  package/libevas-generic-loaders: move to package directory
  package/efl/libefl: new host-package
  package/efl/libefl: new package
  package/efl/libefl: regenerate the configure script
  package/efl/libefl: add harfbuzz dependency
  package/efl/libefl: add wayland dependency
  package/efl/libefl: add libcurl dependency
  package/efl/libefl: add libblkid dependency
  package/efl/libefl: add webp dependency
  package/efl/libefl: add frame buffer config option
  package/efl/libefl: add jp2k config option
  package/efl/libefl: add X11 support
  package/efl/libefl: add OpenGL/OpenGLES support
  package/efl/libefl: enable xinput2.2
  package/efl/libefl: add systemd dependency
  package/efl/libefl: add sdl2 support
  package/libevas-generic-loaders: bump to version 1.15.0
  package/libevas-generic-loaders: add libraw dependency
  package/efl/libelementary: bump to version 1.15.2
  package/efl/libelementary: add host package
  package/efl: libefl and libelementary share the same version number
  package/enlightenment: bump to version 0.19.12
  package/expedite: bump to efl-1.15 branch
  package/efl/libethumb: remove package
  package/efl/libedje: remove package
  package/efl/libembryo: remove package
  package/efl/libeio: remove package
  package/efl/libefreet: remove package
  package/efl/libedbus: remove package
  package/efl/libecore: remove package
  package/efl/libevas: remove package
  package/efl/libeet: remove package
  package/efl/libeina: remove package
  package/libemotion-generic-players: new package

Vicente Bergas (1):
  package/efl/libefl: fix framebuffer support

 Config.in.legacy                                   |  70 ++++
 package/Config.in                                  |   3 +
 package/efl/Config.in                              |  28 +-
 package/efl/efl.mk                                 |   2 +
 package/efl/libecore/Config.in                     |  46 ---
 package/efl/libecore/libecore.mk                   | 114 -------
 package/efl/libedbus/Config.in                     |  44 ---
 package/efl/libedbus/libedbus.mk                   |  37 --
 package/efl/libedje/Config.in                      |  28 --
 package/efl/libedje/libedje.mk                     |  28 --
 package/efl/libeet/Config.in                       |  11 -
 package/efl/libeet/libeet.mk                       |  27 --
 ...ecore_fb_private.h-define-EAPI-before-use.patch |  64 ++++
 .../libefl/0002-ecore_x-Remove-XPrint-usage.patch  | 153 +++++++++
 package/efl/libefl/Config.in                       | 159 +++++++++
 package/efl/libefl/libefl.hash                     |   2 +
 package/efl/libefl/libefl.mk                       | 373 +++++++++++++++++++++
 package/efl/libefreet/Config.in                    |  10 -
 package/efl/libefreet/libefreet.mk                 |  17 -
 package/efl/libeina/Config.in                      |   6 -
 package/efl/libeina/libeina.mk                     |  18 -
 package/efl/libeio/Config.in                       |  22 --
 package/efl/libeio/libeio.mk                       |  16 -
 package/efl/libelementary/Config.in                |  11 +-
 package/efl/libelementary/libelementary.hash       |   2 +
 package/efl/libelementary/libelementary.mk         |  35 +-
 package/efl/libembryo/Config.in                    |   9 -
 package/efl/libembryo/libembryo.mk                 |  18 -
 package/efl/libethumb/Config.in                    |  15 -
 package/efl/libethumb/libethumb.mk                 |  27 --
 package/efl/libevas/0001-giflib.patch              |  98 ------
 package/efl/libevas/Config.in                      | 211 ------------
 package/efl/libevas/libevas.mk                     | 247 --------------
 package/enlightenment/Config.in                    |  36 +-
 package/enlightenment/enlightenment.hash           |   2 +
 package/enlightenment/enlightenment.mk             |  22 +-
 package/{efl => }/expedite/Config.in               |   9 +-
 package/{efl => }/expedite/expedite.mk             |  13 +-
 package/libemotion-generic-players/Config.in       |  15 +
 .../libemotion-generic-players.hash                |   2 +
 .../libemotion-generic-players.mk                  |  17 +
 .../{efl => }/libevas-generic-loaders/Config.in    |  16 +-
 .../libevas-generic-loaders.hash                   |   2 +
 .../libevas-generic-loaders.mk                     |  18 +-
 44 files changed, 942 insertions(+), 1161 deletions(-)
 delete mode 100644 package/efl/libecore/Config.in
 delete mode 100644 package/efl/libecore/libecore.mk
 delete mode 100644 package/efl/libedbus/Config.in
 delete mode 100644 package/efl/libedbus/libedbus.mk
 delete mode 100644 package/efl/libedje/Config.in
 delete mode 100644 package/efl/libedje/libedje.mk
 delete mode 100644 package/efl/libeet/Config.in
 delete mode 100644 package/efl/libeet/libeet.mk
 create mode 100644 package/efl/libefl/0001-ecore_fb_private.h-define-EAPI-before-use.patch
 create mode 100644 package/efl/libefl/0002-ecore_x-Remove-XPrint-usage.patch
 create mode 100644 package/efl/libefl/Config.in
 create mode 100644 package/efl/libefl/libefl.hash
 create mode 100644 package/efl/libefl/libefl.mk
 delete mode 100644 package/efl/libefreet/Config.in
 delete mode 100644 package/efl/libefreet/libefreet.mk
 delete mode 100644 package/efl/libeina/Config.in
 delete mode 100644 package/efl/libeina/libeina.mk
 delete mode 100644 package/efl/libeio/Config.in
 delete mode 100644 package/efl/libeio/libeio.mk
 create mode 100644 package/efl/libelementary/libelementary.hash
 delete mode 100644 package/efl/libembryo/Config.in
 delete mode 100644 package/efl/libembryo/libembryo.mk
 delete mode 100644 package/efl/libethumb/Config.in
 delete mode 100644 package/efl/libethumb/libethumb.mk
 delete mode 100644 package/efl/libevas/0001-giflib.patch
 delete mode 100644 package/efl/libevas/Config.in
 delete mode 100644 package/efl/libevas/libevas.mk
 create mode 100644 package/enlightenment/enlightenment.hash
 rename package/{efl => }/expedite/Config.in (50%)
 rename package/{efl => }/expedite/expedite.mk (55%)
 create mode 100644 package/libemotion-generic-players/Config.in
 create mode 100644 package/libemotion-generic-players/libemotion-generic-players.hash
 create mode 100644 package/libemotion-generic-players/libemotion-generic-players.mk
 rename package/{efl => }/libevas-generic-loaders/Config.in (54%)
 create mode 100644 package/libevas-generic-loaders/libevas-generic-loaders.hash
 rename package/{efl => }/libevas-generic-loaders/libevas-generic-loaders.mk (64%)

-- 
2.4.3

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 01/36] package/expedite: move to package directory
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 12:33   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 02/36] package/libevas-generic-loaders: " Romain Naour
                   ` (34 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

There is no advantage for efl related packages to share the same version
number anymore (except for Efl and Elementary).

Here are the version number used for the 1.15 stable release:
EFL                     1.15.2
Elementary              1.15.2
Emotion Generic Players 1.15.0
Evas Generic Loaders    1.15.0
Python-EFL              1.15.0

Also, we usually do not have a sub-directory for a family of related
packages which don't share the same version number, so move expedite
to the package directory. Expedite now appears in the
"Graphic libraries and applications (graphic/text)" in the Kconfig menu.

In a followup patch, expedite will be downloaded directly from the 1.15
branch in the git repository since there is no new tarball release after
1.7.0.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: fixes typos (ThomasP)
    Use depends on BR2_PACKAGE_EFL instead of select (ThomasP)
v4: improve the commit log (ThomasP)
    move expedite to "Graphic applications" under
    "Graphic libraries and applications" menu (ThomasP)
    fix package comment dependency on BR2_USE_MMU
---
 package/Config.in                      | 1 +
 package/efl/Config.in                  | 1 -
 package/{efl => }/expedite/Config.in   | 1 +
 package/{efl => }/expedite/expedite.mk | 0
 4 files changed, 2 insertions(+), 1 deletion(-)
 rename package/{efl => }/expedite/Config.in (95%)
 rename package/{efl => }/expedite/expedite.mk (100%)

diff --git a/package/Config.in b/package/Config.in
index 2f74439..c3b9a7a 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -219,6 +219,7 @@ endmenu
 menu "Graphic libraries and applications (graphic/text)"
 
 comment "Graphic applications"
+	source "package/expedite/Config.in"
 	source "package/fswebcam/Config.in"
 	source "package/glmark2/Config.in"
 	source "package/gnuplot/Config.in"
diff --git a/package/efl/Config.in b/package/efl/Config.in
index 3d31a26..cb91660 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -10,7 +10,6 @@ menuconfig BR2_PACKAGE_EFL
 
 if BR2_PACKAGE_EFL
 
-source "package/efl/expedite/Config.in"
 source "package/efl/libeina/Config.in"
 source "package/efl/libecore/Config.in"
 source "package/efl/libeet/Config.in"
diff --git a/package/efl/expedite/Config.in b/package/expedite/Config.in
similarity index 95%
rename from package/efl/expedite/Config.in
rename to package/expedite/Config.in
index 1e12108..de6a056 100644
--- a/package/efl/expedite/Config.in
+++ b/package/expedite/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_EXPEDITE
 	select BR2_PACKAGE_LIBEINA
 	select BR2_PACKAGE_LIBEVAS
 	select BR2_PACKAGE_LIBEET
+	depends on BR2_PACKAGE_EFL
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libevas
 	help
diff --git a/package/efl/expedite/expedite.mk b/package/expedite/expedite.mk
similarity index 100%
rename from package/efl/expedite/expedite.mk
rename to package/expedite/expedite.mk
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 02/36] package/libevas-generic-loaders: move to package directory
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 01/36] package/expedite: move to package directory Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 12:56   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 03/36] package/efl/libefl: new host-package Romain Naour
                   ` (33 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

As for expedite package, there is no advantage for efl related
packages to share the same version number anymore
(except for efl and libelementary).

Also, we usually do not have a sub-directory for a family of related
packages which doen't share the same version number, so move
libevas-generic-loaders to package directory.
Libevas-generic-loaders appear now in "Libraries" -> "Graphics" in
the Kconfig menu.

While at it, remove BR2_USE_WCHAR dependency since the efl package
already depend on it.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: Use depends on BR2_PACKAGE_EFL instead of select (ThomasP)
v4: improve the commit log (ThomasP)
    move libevas-generic-loaders to "Libraries" -> "Graphics" (ThomasP)
    fix package comment dependency on BR2_USE_MMU
---
 package/Config.in                                                   | 1 +
 package/efl/Config.in                                               | 1 -
 package/{efl => }/libevas-generic-loaders/Config.in                 | 6 +++---
 .../{efl => }/libevas-generic-loaders/libevas-generic-loaders.mk    | 0
 4 files changed, 4 insertions(+), 4 deletions(-)
 rename package/{efl => }/libevas-generic-loaders/Config.in (79%)
 rename package/{efl => }/libevas-generic-loaders/libevas-generic-loaders.mk (100%)

diff --git a/package/Config.in b/package/Config.in
index c3b9a7a..8ecb2df 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -819,6 +819,7 @@ menu "Graphics"
 	source "package/libdri2/Config.in"
 	source "package/libdrm/Config.in"
 	source "package/libexif/Config.in"
+	source "package/libevas-generic-loaders/Config.in"
 	source "package/libfm/Config.in"
 	source "package/libfm-extra/Config.in"
 	source "package/libfreeimage/Config.in"
diff --git a/package/efl/Config.in b/package/efl/Config.in
index cb91660..7ce5a36 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -16,7 +16,6 @@ source "package/efl/libeet/Config.in"
 source "package/efl/libefreet/Config.in"
 source "package/efl/libeio/Config.in"
 source "package/efl/libevas/Config.in"
-source "package/efl/libevas-generic-loaders/Config.in"
 source "package/efl/libembryo/Config.in"
 source "package/efl/libedje/Config.in"
 source "package/efl/libethumb/Config.in"
diff --git a/package/efl/libevas-generic-loaders/Config.in b/package/libevas-generic-loaders/Config.in
similarity index 79%
rename from package/efl/libevas-generic-loaders/Config.in
rename to package/libevas-generic-loaders/Config.in
index 3f7581f..d0c3cf4 100644
--- a/package/efl/libevas-generic-loaders/Config.in
+++ b/package/libevas-generic-loaders/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
 	bool "libevas generic loaders"
 	select BR2_PACKAGE_LIBEINA
 	select BR2_PACKAGE_ZLIB
+	depends on BR2_PACKAGE_EFL
 	help
 	  These are additional "generic" loaders for Evas that are
 	  stand-alone executables that evas may run from its generic
@@ -15,15 +16,14 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
 	bool "SVG loader"
 	select BR2_PACKAGE_LIBRSVG
 	select BR2_PACKAGE_CAIRO
-	depends on BR2_USE_WCHAR # librsvg -> glib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # librsvg -> glib2
 	depends on BR2_INSTALL_LIBSTDCPP # librsvg -> pango
 	depends on BR2_ARCH_HAS_ATOMICS # cairo
 	help
 	  This option enables the Evas generic SVG loader
 
-comment "SVG loader needs a toolchain w/ wchar, threads, C++"
+comment "SVG loader needs a toolchain w/ threads, C++"
 	depends on BR2_ARCH_HAS_ATOMICS
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
 
 endif
diff --git a/package/efl/libevas-generic-loaders/libevas-generic-loaders.mk b/package/libevas-generic-loaders/libevas-generic-loaders.mk
similarity index 100%
rename from package/efl/libevas-generic-loaders/libevas-generic-loaders.mk
rename to package/libevas-generic-loaders/libevas-generic-loaders.mk
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 03/36] package/efl/libefl: new host-package
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 01/36] package/expedite: move to package directory Romain Naour
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 02/36] package/libevas-generic-loaders: " Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 13:10   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 04/36] package/efl/libefl: new package Romain Naour
                   ` (32 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

This new host-package provide edje_cc, embryo_cc and eet binaries
that will be used by the upcomming libefl packages which will
contain the new version of efl libraries.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: keep efl as a sub-directory.
    rename this new package to libefl since we want to keep a efl
    and elementary version in sync.
v3: remove trailing slash (Vicente Bergas)
    bump to 1.15.2
---
 package/efl/libefl/libefl.hash |  2 ++
 package/efl/libefl/libefl.mk   | 75 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 77 insertions(+)
 create mode 100644 package/efl/libefl/libefl.hash
 create mode 100644 package/efl/libefl/libefl.mk

diff --git a/package/efl/libefl/libefl.hash b/package/efl/libefl/libefl.hash
new file mode 100644
index 0000000..7ac26f4
--- /dev/null
+++ b/package/efl/libefl/libefl.hash
@@ -0,0 +1,2 @@
+# From https://download.enlightenment.org/rel/libs/efl/efl-1.15.2.tar.xz.sha256
+sha256	dd738f19f454621a7fa1fdb4c008457c170989f5f0c535edfed7b6773ae6c2a4	efl-1.15.2.tar.xz
diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
new file mode 100644
index 0000000..4dca733
--- /dev/null
+++ b/package/efl/libefl/libefl.mk
@@ -0,0 +1,75 @@
+################################################################################
+#
+# libefl
+#
+################################################################################
+
+# hardcode the version here since the bump to 1.15 is not complete in Buildroot
+LIBEFL_VERSION = 1.15.2
+LIBEFL_SOURCE = efl-$(LIBEFL_VERSION).tar.xz
+LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl
+LIBEFL_LICENSE = BSD-2c, LGPLv2.1+, GPLv2+
+LIBEFL_LICENSE_FILES = COPYING
+
+################################################################################
+#
+# host-libefl
+#
+################################################################################
+
+# We want to build only some host tools used later in the build.
+# Actually we want: edje_cc, embryo_cc and eet.
+
+# Host dependencies:
+# * host-dbus: for Eldbus
+# * host-freetype: for libevas
+# * host-libglib2: for libecore
+# * host-libjpeg, host-libpng: for libevas image loader
+# * host-lua: disable luajit dependency
+HOST_LIBEFL_DEPENDENCIES = \
+	host-pkgconf \
+	host-dbus \
+	host-freetype \
+	host-libglib2 \
+	host-libjpeg \
+	host-libpng \
+	host-lua \
+	host-zlib
+
+# Configure options:
+# --disable-audio, --disable-multisense remove libsndfile dependency.
+# --disable-cxx-bindings: disable C++11 bindings.
+# --disable-fontconfig: remove dependency on fontconfig.
+# --disable-fribidi: remove dependency on libfribidi.
+# --disable-gstreamer1: remove dependency on gtreamer 1.0.
+# --disable-libeeze: remove libudev dependency.
+# --disable-libmount: remove dependency on host-util-linux libmount.
+# --disable-physics: remove Bullet dependency.
+# --enable-image-loader-gif=no: disable Gif dependency.
+# --enable-image-loader-tiff=no: disable Tiff dependency.
+# --enable-lua-old: disable Elua and remove luajit dependency.
+# --with-crypto=none: remove dependencies on openssl or gnutls.
+# --with-x11=none: remove dependency on X.org.
+#   Yes I really know what I am doing.
+HOST_LIBEFL_CONF_OPTS += \
+	--disable-audio \
+	--disable-cxx-bindings \
+	--disable-fontconfig \
+	--disable-fribidi \
+	--disable-gstreamer1 \
+	--disable-libeeze \
+	--disable-libmount \
+	--disable-multisense \
+	--disable-physics \
+	--enable-image-loader-gif=no \
+	--enable-image-loader-jpeg=yes \
+	--enable-image-loader-png=yes \
+	--enable-image-loader-tiff=no \
+	--enable-lua-old \
+	--with-crypto=none \
+	--with-glib=yes \
+	--with-opengl=none \
+	--with-x11=none \
+	--enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-aba
+
+$(eval $(host-autotools-package))
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 04/36] package/efl/libefl: new package
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (2 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 03/36] package/efl/libefl: new host-package Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 13:55   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 05/36] package/efl/libefl: regenerate the configure script Romain Naour
                   ` (31 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

Add the libefl package which contains an updated version of the following
libraries:
libecore, libedje, libeet, libfreet, libeina, libeio, libembryo, libthumb
and libevas. It also contains eldbus, ephysics, and escape, see [1].

For now, the bump to efl 1.15.x is not complete.
This allows to build at least a default configuration whithout X11 support
or graphics acceleration.
This support will be added by a follow up patches in the series.

Also, add BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG config option in order to
select all recommended packages that allows to build efl-core whithout the
extra-long --enable-i-really-know-what-i-am-doing...

At the end of the configure script, the summary tab will show that
alsa support is allways disabled even if alsa-utils has been build
before efl-core package.

"Ecore_Audio.....: yes (-alsa +pulseaudio +sndfile)"
This is intentional.

An initial runtime test has been done under Qemu with a glibc x86 toolchain.

An additional runtime test has been done with a uClibc-ng 1.0.5 toolchain
patched with [2] in order to add mkstemps() which is used by Eina library.
This patch has been upstreamed in uClubc-ng 1.0.6 release.

Another test has been done with a musl toolchain by Vicente Bergas (Thanks!)

Add a dependency on threads support since clearly efl libraries are
not even built without thread support [3].

[1] See https://phab.enlightenment.org/phame/live/3/post/efl_1_8/
[2] http://mailman.uclibc-ng.org/pipermail/devel/2015-August/000432.html
[3] https://git.enlightenment.org/core/efl.git/tree/configure.ac#n5032

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Cc: Vicente Bergas <vicencb@gmail.com>
---
v4: rename to libefl
    EFL needs a toolchain with threads support
v3: fix same typo again
    Add a note about multisense support
v2: remove glibc only dependency
    update commit log accordingly
    fix typo in Config.in (Vicente Bergas)

Vicente, can you test this new series and resend your Tested-By tag ? Thanks !
---
 package/efl/Config.in        |  16 +++--
 package/efl/libefl/Config.in |  65 +++++++++++++++++
 package/efl/libefl/libefl.mk | 161 +++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 237 insertions(+), 5 deletions(-)
 create mode 100644 package/efl/libefl/Config.in

diff --git a/package/efl/Config.in b/package/efl/Config.in
index 7ce5a36..2860cd6 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -1,8 +1,12 @@
 menuconfig BR2_PACKAGE_EFL
 	bool "Enlightenment Foundation Libraries"
-	depends on BR2_USE_WCHAR
-	# libeina uses madvise(). To revisit when bumping EFL to 1.8
-	depends on BR2_USE_MMU
+	depends on BR2_INSTALL_LIBSTDCPP # libefl
+	depends on BR2_PACKAGE_HAS_UDEV # libefl -> libudev
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libefl
+	depends on BR2_USE_MMU # libefl
+	depends on BR2_USE_WCHAR # libefl
+	depends on !BR2_STATIC_LIBS # libefl
+	select BR2_PACKAGE_LIBEFL
 	help
 	  Enlightenment Foundation Libraries
 
@@ -13,6 +17,7 @@ if BR2_PACKAGE_EFL
 source "package/efl/libeina/Config.in"
 source "package/efl/libecore/Config.in"
 source "package/efl/libeet/Config.in"
+source "package/efl/libefl/Config.in"
 source "package/efl/libefreet/Config.in"
 source "package/efl/libeio/Config.in"
 source "package/efl/libevas/Config.in"
@@ -24,5 +29,6 @@ source "package/efl/libedbus/Config.in"
 
 endif # BR2_PACKAGE_EFL
 
-comment "EFL needs a toolchain w/ wchar"
-	depends on !BR2_USE_WCHAR
+comment "EFL needs udev /dev management and a toolchain w/ C++, dynamic library, threads, wchar"
+	depends on !BR2_PACKAGE_HAS_UDEV || !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
+	depends on BR2_USE_MMU
diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
new file mode 100644
index 0000000..2b758f0
--- /dev/null
+++ b/package/efl/libefl/Config.in
@@ -0,0 +1,65 @@
+config BR2_PACKAGE_LIBEFL
+	bool "libefl"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_HAS_UDEV # libudev
+	depends on BR2_TOOLCHAIN_HAS_THREADS # untested without threads
+	depends on BR2_USE_MMU
+	depends on BR2_USE_WCHAR # use wchar_t
+	depends on !BR2_STATIC_LIBS # dlfcn.h
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_FREETYPE
+	select BR2_PACKAGE_JPEG # Emile needs libjpeg
+	select BR2_PACKAGE_LUA # Evas lua 5.1 or 5.2
+	help
+	  Enlightenment Foundation Libraries
+
+	  https://enlightenment.org
+
+if BR2_PACKAGE_LIBEFL
+
+config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
+	bool "Use recommended and tested configurations"
+	select BR2_PACKAGE_BULLET
+	select BR2_PACKAGE_FONTCONFIG
+	select BR2_PACKAGE_GSTREAMER1
+	select BR2_PACKAGE_GST1_PLUGINS_BASE
+	select BR2_PACKAGE_LIBFRIBIDI
+	select BR2_PACKAGE_LIBSNDFILE
+	select BR2_PACKAGE_PULSEAUDIO
+	select BR2_PACKAGE_UTIL_LINUX
+	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
+	default y
+	help
+	  Avoid to use untested or not recommended configurations,
+	  otherwise we need to add a very long and obscure option
+	  to start the build.
+
+comment "libevas loaders"
+
+config BR2_PACKAGE_LIBEFL_PNG
+	bool "libevas png loader"
+	select BR2_PACKAGE_LIBPNG
+	help
+	  This enables the loader code that loads png files using
+	  libpng.
+
+config BR2_PACKAGE_LIBEFL_JPEG
+	bool "libevas jpeg loader"
+	help
+	  This enables the loader code that loads jpeg files using
+	  libjpeg.
+
+config BR2_PACKAGE_LIBEFL_GIF
+	bool "libevas gif loader"
+	select BR2_PACKAGE_GIFLIB
+	help
+	  This enables the loader code that loads gif files using
+	  libungif.
+
+config BR2_PACKAGE_LIBEFL_TIFF
+	bool "libevas tiff loader"
+	select BR2_PACKAGE_TIFF
+	help
+	  This enables the loader code that loads tiff files.
+
+endif # BR2_PACKAGE_LIBEFL
diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index 4dca733..781f397 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -11,6 +11,167 @@ LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl
 LIBEFL_LICENSE = BSD-2c, LGPLv2.1+, GPLv2+
 LIBEFL_LICENSE_FILES = COPYING
 
+LIBEFL_INSTALL_STAGING = YES
+
+LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg lua udev zlib
+
+# Configure options:
+# --disable-cxx-bindings: disable C++11 bindings.
+# --enable-lua-old: disable Elua and remove luajit dependency.
+# --with-x11=none: remove dependency on X.org.
+LIBEFL_CONF_OPTS = \
+	--with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc \
+	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
+	--disable-cxx-bindings \
+	--enable-lua-old \
+	--with-x11=none
+
+# Disable untested configuration warning.
+ifeq ($(BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG),)
+LIBEFL_CONF_OPTS += --enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-aba
+endif
+
+# Libmount is used heavily inside Eeze for support of removable devices etc.
+# and disabling this will hurt support for Enlightenment and its filemanager.
+ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBMOUNT),y)
+LIBEFL_DEPENDENCIES += util-linux
+LIBEFL_CONF_OPTS += --enable-libmount
+else
+LIBEFL_CONF_OPTS += --disable-libmount
+endif
+
+# If fontconfig is disabled, this is going to make general font
+# searching not work, and only some very direct 'load /path/file.ttf'
+# will work alongside some old-school ttf file path searching. This
+# is very likely not what you want, so highly reconsider turning
+# fontconfig off. Having it off will lead to visual problems like
+# missing text in many UI areas etc.
+ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
+LIBEFL_CONF_OPTS += --enable-fontconfig
+LIBEFL_DEPENDENCIES += fontconfig
+else
+LIBEFL_CONF_OPTS += --disable-fontconfig
+endif
+
+# Fribidi is used for handling right-to-left text (like Arabic,
+# Hebrew, Farsi, Persian etc.) and is very likely not a feature
+# you want to disable unless you know for absolute certain you
+# will never encounter and have to display such scripts. Also
+# note that we don't test with fribidi disabled so you may also
+# trigger code paths with bugs that are never normally used.
+ifeq ($(BR2_PACKAGE_LIBFRIBIDI),y)
+LIBEFL_CONF_OPTS += --enable-fribidi
+LIBEFL_DEPENDENCIES += libfribidi
+else
+LIBEFL_CONF_OPTS += --disable-fribidi
+endif
+
+# If Gstreamer 1.x support is disabled, it will heavily limit your media
+# support options and render some functionality as useless, leading to
+# visible application bugs.
+ifeq ($(BR2_PACKAGE_GSTREAMER1)$(BR2_PACKAGE_GST1_PLUGINS_BASE),yy)
+LIBEFL_CONF_OPTS += --enable-gstreamer1
+LIBEFL_DEPENDENCIES += gstreamer1 gst1-plugins-base
+else
+LIBEFL_CONF_OPTS += --disable-gstreamer1
+endif
+
+# You have chosen to disable physics support. This disables lots of
+# core functionality and is effectively never tested. You are going
+# to find features that suddenly don't work and as a result cause
+# a series of breakages. This is simply not tested so you are on
+# your own in terms of ensuring everything works if you do this
+ifeq ($(BR2_PACKAGE_BULLET),y)
+LIBEFL_CONF_OPTS += --enable-physics
+LIBEFL_DEPENDENCIES += bullet
+else
+LIBEFL_CONF_OPTS += --disable-physics
+endif
+
+# You disabled audio support in Ecore. This is not tested and may
+# Create bugs for you due to it creating untested code paths.
+# Reconsider disabling audio.
+ifeq ($(BR2_PACKAGE_LIBSNDFILE),y)
+LIBEFL_CONF_OPTS += --enable-audio
+LIBEFL_DEPENDENCIES += libsndfile
+else
+LIBEFL_CONF_OPTS += --disable-audio
+endif
+
+# The only audio output method supported by Ecore right now is via
+# Pulseaudio. You have disabled that and likely have broken a whole
+# bunch of things in the process. Reconsider your configure options.
+# NOTE: multisense support is automatically enabled with pulseaudio.
+ifeq ($(BR2_PACKAGE_PULSEAUDIO),y)
+LIBEFL_CONF_OPTS += --enable-pulseaudio
+LIBEFL_DEPENDENCIES += pulseaudio
+else
+LIBEFL_CONF_OPTS += --disable-pulseaudio
+endif
+
+# There is no alsa support yet in Ecore_Audio.
+# configure will disable alsa support even if alsa-lib is selected.
+
+ifeq ($(BR2_PACKAGE_TSLIB),y)
+LIBEFL_DEPENDENCIES += tslib
+LIBEFL_CONF_OPTS += --enable-tslib
+else
+LIBEFL_CONF_OPTS += --disable-tslib
+endif
+
+ifeq ($(BR2_PACKAGE_LIBGLIB2),y)
+LIBEFL_DEPENDENCIES += libglib2
+# we can also say "always"
+LIBEFL_CONF_OPTS += --with-glib=yes
+else
+LIBEFL_CONF_OPTS += --with-glib=no
+endif
+
+# Prefer openssl (the default) over gnutls.
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBEFL_DEPENDENCIES += openssl
+LIBEFL_CONF_OPTS += --with-crypto=openssl
+else
+ifeq ($(BR2_PACKAGE_GNUTLS)$(BR2_PACKAGE_LIBGCRYPT),yy)
+LIBEFL_DEPENDENCIES += gnutls libgcrypt
+LIBEFL_CONF_OPTS += --with-crypto=gnutls \
+	--with-libgcrypt-prefix=$(STAGING_DIR)/usr
+else
+LIBEFL_CONF_OPTS += --with-crypto=none
+endif
+endif # BR2_PACKAGE_OPENSSL
+
+# image loader: handle only loaders that requires dependencies.
+# All other loaders are builded by default statically.
+ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-png=yes
+LIBEFL_DEPENDENCIES += libpng
+else
+LIBEFL_CONF_OPTS += --enable-image-loader-png=no
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_JPEG),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-jpeg=yes
+else
+LIBEFL_CONF_OPTS += --enable-image-loader-jpeg=no
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_GIF),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-gif=yes
+LIBEFL_DEPENDENCIES += giflib
+else
+LIBEFL_CONF_OPTS += --enable-image-loader-gif=no
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_TIFF),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-tiff=yes
+LIBEFL_DEPENDENCIES += tiff
+else
+LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no
+endif
+
+$(eval $(autotools-package))
+
 ################################################################################
 #
 # host-libefl
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 05/36] package/efl/libefl: regenerate the configure script
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (3 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 04/36] package/efl/libefl: new package Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 14:00   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 06/36] package/efl/libefl: add harfbuzz dependency Romain Naour
                   ` (30 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

Workaround a build issue with eldbus-codegen:

  CCLD     bin/eldbus/eldbus-codegen
  CXXLD    bin/eolian_cxx/eolian_cxx
  CCLD     lib/ecore_x/ecore_x_vsync
  CCLD     lib/evas/common/libevas_op_blend_sse3.la
  CCLD     lib/evas/common/libevas_convert_rgb_32.la
  CCLD     lib/ecore_ipc/libecore_ipc.la
[...]/i686-ctng-linux-gnu/bin/ld: warning: libefl.so.1, needed by lib/ecore/.libs/libecore.so, not found (try using -rpath or -rpath-link)
lib/ecore/.libs/libecore.so: undefined reference to `efl_control_suspend_set'
lib/ecore/.libs/libecore.so: undefined reference to `efl_control_interface_get'
collect2: error: ld returned 1 exit status
Makefile:19135: recipe for target 'bin/eldbus/eldbus-codegen' failed
make[6]: *** [bin/eldbus/eldbus-codegen] Error 1

A dependency on libefl seems to be missing for eldbus but by
regenerating eldbus-codegen build correctly.

Reported upstream: https://phab.enlightenment.org/T2718

Also, gettextize is needed since *.po files were generated with
an "old" gettext version (0.18):

Making all in po
*** error: gettext infrastructure mismatch: using a Makefile.in.in from gettext version 0.18 but the autoconf macros are from gettext version 0.19
Makefile:149: recipe for target 'check-macro-version' failed

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: rename to libefl
v3: fix gettextize
---
 package/efl/libefl/libefl.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index 781f397..609ae6a 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -15,6 +15,11 @@ LIBEFL_INSTALL_STAGING = YES
 
 LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg lua udev zlib
 
+# regenerate the configure script:
+# https://phab.enlightenment.org/T2718
+LIBEFL_AUTORECONF = YES
+LIBEFL_GETTEXTIZE = YES
+
 # Configure options:
 # --disable-cxx-bindings: disable C++11 bindings.
 # --enable-lua-old: disable Elua and remove luajit dependency.
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 06/36] package/efl/libefl: add harfbuzz dependency
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (4 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 05/36] package/efl/libefl: regenerate the configure script Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 14:22   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 07/36] package/efl/libefl: add wayland dependency Romain Naour
                   ` (29 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

Harfbuzz allow to enable complex text shaping and layouting
support in efl libraries.

Also, it one of the "highly recommended" dependecies
according to the README but disabling it doesn't need
the --enable-i-really-know-what-i-am-doing... option.
That's why harfbuzz is not added to
BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: rename to libefl
    improve commit log.
---
 package/efl/libefl/libefl.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index 609ae6a..2e42bb7 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -117,6 +117,13 @@ endif
 # There is no alsa support yet in Ecore_Audio.
 # configure will disable alsa support even if alsa-lib is selected.
 
+ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
+LIBEFL_DEPENDENCIES += harfbuzz
+LIBEFL_CONF_OPTS += --enable-harfbuzz=yes
+else
+LIBEFL_CONF_OPTS += --enable-harfbuzz=no
+endif
+
 ifeq ($(BR2_PACKAGE_TSLIB),y)
 LIBEFL_DEPENDENCIES += tslib
 LIBEFL_CONF_OPTS += --enable-tslib
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 07/36] package/efl/libefl: add wayland dependency
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (5 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 06/36] package/efl/libefl: add harfbuzz dependency Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 14:25   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 08/36] package/efl/libefl: add libcurl dependency Romain Naour
                   ` (28 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

See:
https://www.enlightenment.org/about-wayland

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: rename to libefl
---
 package/efl/libefl/Config.in | 1 +
 package/efl/libefl/libefl.mk | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
index 2b758f0..07aee42 100644
--- a/package/efl/libefl/Config.in
+++ b/package/efl/libefl/Config.in
@@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBEFL
 	select BR2_PACKAGE_FREETYPE
 	select BR2_PACKAGE_JPEG # Emile needs libjpeg
 	select BR2_PACKAGE_LUA # Evas lua 5.1 or 5.2
+	select BR2_PACKAGE_LIBXKBCOMMON if BR2_PACKAGE_WAYLAND
 	help
 	  Enlightenment Foundation Libraries
 
diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index 2e42bb7..c697e41 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -153,6 +153,13 @@ LIBEFL_CONF_OPTS += --with-crypto=none
 endif
 endif # BR2_PACKAGE_OPENSSL
 
+ifeq ($(BR2_PACKAGE_WAYLAND),y)
+LIBEFL_DEPENDENCIES += wayland libxkbcommon
+LIBEFL_CONF_OPTS += --enable-wayland=yes
+else
+LIBEFL_CONF_OPTS += --enable-wayland=no
+endif
+
 # image loader: handle only loaders that requires dependencies.
 # All other loaders are builded by default statically.
 ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 08/36] package/efl/libefl: add libcurl dependency
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (6 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 07/36] package/efl/libefl: add wayland dependency Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 14:37   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 09/36] package/efl/libefl: add libblkid dependency Romain Naour
                   ` (27 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

Curl is listed as an dependency in the README:
https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n453

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: rename to libefl
---
 package/efl/libefl/Config.in | 1 +
 package/efl/libefl/libefl.mk | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
index 07aee42..29aef05 100644
--- a/package/efl/libefl/Config.in
+++ b/package/efl/libefl/Config.in
@@ -9,6 +9,7 @@ config BR2_PACKAGE_LIBEFL
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_FREETYPE
 	select BR2_PACKAGE_JPEG # Emile needs libjpeg
+	select BR2_PACKAGE_LIBCURL # eina_module, runtime dependency
 	select BR2_PACKAGE_LUA # Evas lua 5.1 or 5.2
 	select BR2_PACKAGE_LIBXKBCOMMON if BR2_PACKAGE_WAYLAND
 	help
diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index c697e41..b26f848 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -13,7 +13,8 @@ LIBEFL_LICENSE_FILES = COPYING
 
 LIBEFL_INSTALL_STAGING = YES
 
-LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg lua udev zlib
+LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg libcurl lua \
+	udev zlib
 
 # regenerate the configure script:
 # https://phab.enlightenment.org/T2718
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 09/36] package/efl/libefl: add libblkid dependency
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (7 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 08/36] package/efl/libefl: add libcurl dependency Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 14:40   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 10/36] package/efl/libefl: add webp dependency Romain Naour
                   ` (26 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

util-linux libblkid is listed as an dependency in the README:
https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n478

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: rename to libefl
---
 package/efl/libefl/Config.in | 1 +
 package/efl/libefl/libefl.mk | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
index 29aef05..5c65744 100644
--- a/package/efl/libefl/Config.in
+++ b/package/efl/libefl/Config.in
@@ -29,6 +29,7 @@ config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
 	select BR2_PACKAGE_LIBSNDFILE
 	select BR2_PACKAGE_PULSEAUDIO
 	select BR2_PACKAGE_UTIL_LINUX
+	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
 	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
 	default y
 	help
diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index b26f848..c7ecf51 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -46,6 +46,11 @@ else
 LIBEFL_CONF_OPTS += --disable-libmount
 endif
 
+# libblkid is part of required tools, see EFL's README.
+ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),y)
+LIBEFL_DEPENDENCIES += util-linux
+endif
+
 # If fontconfig is disabled, this is going to make general font
 # searching not work, and only some very direct 'load /path/file.ttf'
 # will work alongside some old-school ttf file path searching. This
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 10/36] package/efl/libefl: add webp dependency
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (8 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 09/36] package/efl/libefl: add libblkid dependency Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 14:41   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 11/36] package/efl/libefl: add frame buffer config option Romain Naour
                   ` (25 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

WebP is a new image format that provides lossless and lossy
compression for images on the web. So enabling webp support
in efl libraries allow to loads images using WebP.

Also, it one of the "highly recommended" dependecies [1]
according to the README but disabling it doesn't need
the --enable-i-really-know-what-i-am-doing... option.
That's why BR2_PACKAGE_LIBEFL_WEBP is not added to
BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG.

[1] https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n486

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: rename to libefl
    improve commit log
---
 package/efl/libefl/Config.in | 5 +++++
 package/efl/libefl/libefl.mk | 7 +++++++
 2 files changed, 12 insertions(+)

diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
index 5c65744..c72ea7e 100644
--- a/package/efl/libefl/Config.in
+++ b/package/efl/libefl/Config.in
@@ -65,4 +65,9 @@ config BR2_PACKAGE_LIBEFL_TIFF
 	help
 	  This enables the loader code that loads tiff files.
 
+config BR2_PACKAGE_LIBEFL_WEBP
+	bool "libevas webp image loader"
+	help
+	  This enables the loader code that loads images using WebP.
+
 endif # BR2_PACKAGE_LIBEFL
diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index c7ecf51..9633630 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -195,6 +195,13 @@ else
 LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_WEBP),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-webp=yes
+LIBEFL_DEPENDENCIES += webp
+else
+LIBEFL_CONF_OPTS += --enable-image-loader-webp=no
+endif
+
 $(eval $(autotools-package))
 
 ################################################################################
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 11/36] package/efl/libefl: add frame buffer config option
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (9 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 10/36] package/efl/libefl: add webp dependency Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 12:31   ` Yann E. MORIN
  2015-10-25 14:43   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 12/36] package/efl/libefl: fix framebuffer support Romain Naour
                   ` (24 subsequent siblings)
  35 siblings, 2 replies; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

Add an config option to enable frame buffer support
in the efl libraries.

From the README [1]:
This requires linux frame-buffer support, headers etc. This supports
basic frame-buffers like /dev/fb as well as input via /dev/input for
keyboards and mice in a basic way.

[1] https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n521

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: rename to libefl
    improve commit log
---
 package/efl/libefl/Config.in | 5 +++++
 package/efl/libefl/libefl.mk | 6 ++++++
 2 files changed, 11 insertions(+)

diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
index c72ea7e..e25911f 100644
--- a/package/efl/libefl/Config.in
+++ b/package/efl/libefl/Config.in
@@ -37,6 +37,11 @@ config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
 	  otherwise we need to add a very long and obscure option
 	  to start the build.
 
+comment "libecore video support"
+
+config BR2_PACKAGE_LIBEFL_FB
+	bool "libecore framebuffer support"
+
 comment "libevas loaders"
 
 config BR2_PACKAGE_LIBEFL_PNG
diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index 9633630..3a4aab1 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -166,6 +166,12 @@ else
 LIBEFL_CONF_OPTS += --enable-wayland=no
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_FB),y)
+LIBEFL_CONF_OPTS += --enable-fb=yes
+else
+LIBEFL_CONF_OPTS += --enable-fb=no
+endif
+
 # image loader: handle only loaders that requires dependencies.
 # All other loaders are builded by default statically.
 ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 12/36] package/efl/libefl: fix framebuffer support
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (10 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 11/36] package/efl/libefl: add frame buffer config option Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 14:45   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 13/36] package/efl/libefl: add jp2k config option Romain Naour
                   ` (23 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

From: Vicente Bergas <vicencb@gmail.com>

From [1]:
When running terminology, a message appears in eina_module_load with:
could not dlopen("/usr/lib/ecore_evas/engines/fb/v-1.15/module.so",
Error relocating /usr/lib/ecore_evas/engines/fb/v-1.15/module.so:
ecore_fb_ts_shutdown: symbol not found): RTLD_NOW
It seems like the EAPI macro has no effect...

A patch from Ross Vandegrift has been posted on enlightenment mailing
list [2], but it's not yet an upstream patch.

[1] http://sourceforge.net/p/enlightenment/mailman/message/34493376
[2] http://sourceforge.net/p/enlightenment/mailman/message/34492801

Signed-off-by: Vicente Bergas <vicencb@gmail.com>
[Romain: use a git formated patch and add a commit log]
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: move the patch to libefl
    improve the commit log
v3: new patch
---
 ...ecore_fb_private.h-define-EAPI-before-use.patch | 64 ++++++++++++++++++++++
 1 file changed, 64 insertions(+)
 create mode 100644 package/efl/libefl/0001-ecore_fb_private.h-define-EAPI-before-use.patch

diff --git a/package/efl/libefl/0001-ecore_fb_private.h-define-EAPI-before-use.patch b/package/efl/libefl/0001-ecore_fb_private.h-define-EAPI-before-use.patch
new file mode 100644
index 0000000..81d14f9
--- /dev/null
+++ b/package/efl/libefl/0001-ecore_fb_private.h-define-EAPI-before-use.patch
@@ -0,0 +1,64 @@
+From 2fb4fdf641e67e49b87a3524038a694c8dd0ba4e Mon Sep 17 00:00:00 2001
+From: Vicente Bergas <vicencb@gmail.com>
+Date: Fri, 9 Oct 2015 23:35:20 +0200
+Subject: [PATCH] ecore_fb_private.h: define EAPI before use
+
+From [1]:
+When running terminology, a message appears in eina_module_load with:
+could not dlopen("/usr/lib/ecore_evas/engines/fb/v-1.15/module.so",
+Error relocating /usr/lib/ecore_evas/engines/fb/v-1.15/module.so:
+ecore_fb_ts_shutdown: symbol not found): RTLD_NOW
+It seems like the EAPI macro has no effect...
+
+A patch from Ross Vandegrift has been posted on enlightenment mailing
+list [2], but it's not yet an upstream patch.
+
+[1] http://sourceforge.net/p/enlightenment/mailman/message/34493376
+[2] http://sourceforge.net/p/enlightenment/mailman/message/34492801
+
+Signed-off-by: Vicente Bergas <vicencb@gmail.com>
+[Romain:
+  - Add a commit log
+  - Add a link to the enlightenment mailing list
+  - Add Vicente's SoB line]
+Signed-off-by: Romain Naour <romain.naour@openwide.fr>
+---
+ src/lib/ecore_fb/ecore_fb_private.h | 17 +++++++++++++++++
+ 1 file changed, 17 insertions(+)
+
+diff --git a/src/lib/ecore_fb/ecore_fb_private.h b/src/lib/ecore_fb/ecore_fb_private.h
+index f7dc0c6..f54c8d2 100644
+--- a/src/lib/ecore_fb/ecore_fb_private.h
++++ b/src/lib/ecore_fb/ecore_fb_private.h
+@@ -33,6 +33,20 @@
+ 
+ #include <Ecore_Fb.h>
+ 
++#ifdef EAPI
++# undef EAPI
++#endif
++
++#ifdef __GNUC__
++# if __GNUC__ >= 4
++#  define EAPI __attribute__ ((visibility("default")))
++# else
++#  define EAPI
++# endif
++#else
++# define EAPI
++#endif
++
+ /* ecore_fb_li.c */
+ struct _Ecore_Fb_Input_Device
+ {
+@@ -92,4 +106,7 @@ void ecore_fb_vt_shutdown(void);
+ #define TS_GET_CAL 0x8014660a
+ #endif
+   
++#undef EAPI
++#define EAPI
++
+ #endif
+-- 
+2.4.3
+
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 13/36] package/efl/libefl: add jp2k config option
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (11 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 12/36] package/efl/libefl: fix framebuffer support Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 14:48   ` Yann E. MORIN
  2015-10-25 14:48   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 14/36] package/efl/libefl: add X11 support Romain Naour
                   ` (22 subsequent siblings)
  35 siblings, 2 replies; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

Like for webp format, add an option to enable the JPEG 2000
codec support in the efl libraries.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: rename to libefl
    improve commit log
---
 package/efl/libefl/Config.in | 7 +++++++
 package/efl/libefl/libefl.mk | 7 +++++++
 2 files changed, 14 insertions(+)

diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
index e25911f..53adea2 100644
--- a/package/efl/libefl/Config.in
+++ b/package/efl/libefl/Config.in
@@ -51,6 +51,13 @@ config BR2_PACKAGE_LIBEFL_PNG
 	  This enables the loader code that loads png files using
 	  libpng.
 
+config BR2_PACKAGE_LIBEFL_JP2K
+	bool "libevas jp2k loader"
+	select BR2_PACKAGE_OPENJPEG
+	help
+	  This enables the loader code that loads jp2k files using
+	  openjpeg.
+
 config BR2_PACKAGE_LIBEFL_JPEG
 	bool "libevas jpeg loader"
 	help
diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index 3a4aab1..e53470d 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -201,6 +201,13 @@ else
 LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_JP2K),y)
+LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=yes
+LIBEFL_DEPENDENCIES += openjpeg
+else
+LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=no
+endif
+
 ifeq ($(BR2_PACKAGE_LIBEFL_WEBP),y)
 LIBEFL_CONF_OPTS += --enable-image-loader-webp=yes
 LIBEFL_DEPENDENCIES += webp
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 14/36] package/efl/libefl: add X11 support
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (12 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 13/36] package/efl/libefl: add jp2k config option Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 15:01   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 15/36] package/efl/libefl: add OpenGL/OpenGLES support Romain Naour
                   ` (21 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

Add an option to enable X11 support in libecore without graphic
acceleration. libecore can use xlib or xcb support but the latter
in not recommended by efl developpers.

Also, set x-includes and x-libraries configure option for cross-compiling.
Previous efl versions had cross-compilation issue (poisoned paths)
if these options are not passed to configure script.

In order to remove the dependency on libXp wich is no longer bundled in
recent X11 release [1], backport an upstream patch [2] to remove xprint
usage.

[1] http://www.x.org/wiki/Releases/ModuleVersions
[2] https://git.enlightenment.org/core/efl.git/commit/?h=efl-1.15&id=434572355c7e929b84210b2f795634d38f13c913

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: rename libefl
    improve commit log
v3: fix typo
    remove xlib_libXp dependency (xprint), since libXp package has been
    removed from this series.
---
 .../libefl/0002-ecore_x-Remove-XPrint-usage.patch  | 153 +++++++++++++++++++++
 package/efl/libefl/Config.in                       |  41 ++++++
 package/efl/libefl/libefl.mk                       |  62 ++++++++-
 3 files changed, 255 insertions(+), 1 deletion(-)
 create mode 100644 package/efl/libefl/0002-ecore_x-Remove-XPrint-usage.patch

diff --git a/package/efl/libefl/0002-ecore_x-Remove-XPrint-usage.patch b/package/efl/libefl/0002-ecore_x-Remove-XPrint-usage.patch
new file mode 100644
index 0000000..4687e4c
--- /dev/null
+++ b/package/efl/libefl/0002-ecore_x-Remove-XPrint-usage.patch
@@ -0,0 +1,153 @@
+From 434572355c7e929b84210b2f795634d38f13c913 Mon Sep 17 00:00:00 2001
+From: Derek Foreman <derekf@osg.samsung.com>
+Date: Tue, 6 Oct 2015 13:13:01 -0400
+Subject: [PATCH] ecore_x: Remove XPrint usage
+
+Summary:
+Xprint has been deprecated since 2008.
+
+It's recently (August 2015) been removed from debian.
+
+Reviewers: zmike, devilhorns
+
+Subscribers: cedric
+
+Differential Revision: https://phab.enlightenment.org/D3150
+---
+ configure.ac                           |  1 -
+ src/lib/ecore_x/xlib/ecore_x.c         | 78 ----------------------------------
+ src/lib/ecore_x/xlib/ecore_x_private.h |  3 --
+ 3 files changed, 82 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index 9c17946..c34191c 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -3624,7 +3624,6 @@ if test "x${want_x11_xlib}" = "xyes" ; then
+    ECORE_CHECK_X_EXTENSION([Xdpms], [dpms.h], [Xext], [DPMSQueryExtension])
+    ECORE_CHECK_X_EXTENSION([Xfixes], [Xfixes.h], [Xfixes], [XFixesExpandRegion])
+    ECORE_CHECK_X_EXTENSION([Xinerama], [Xinerama.h], [Xinerama], [XineramaQueryScreens])
+-   ECORE_CHECK_X_EXTENSION([Xprint], [Print.h], [Xp], [XpQueryScreens])
+    ECORE_CHECK_X_EXTENSION([Xrandr], [Xrandr.h], [Xrandr], [XRRGetScreenResourcesCurrent])
+    ECORE_CHECK_X_EXTENSION([Xrender], [Xrender.h], [Xrender], [XRenderFindVisualFormat])
+    ECORE_CHECK_X_EXTENSION([Xtest], [XTest.h], [Xtst], [XTestFakeKeyEvent])
+diff --git a/src/lib/ecore_x/xlib/ecore_x.c b/src/lib/ecore_x/xlib/ecore_x.c
+index 096f64d..8e2057e 100644
+--- a/src/lib/ecore_x/xlib/ecore_x.c
++++ b/src/lib/ecore_x/xlib/ecore_x.c
+@@ -1219,9 +1219,6 @@ ecore_x_window_root_list(int *num_ret)
+ {
+    int num, i;
+    Ecore_X_Window *roots;
+-#ifdef ECORE_XPRINT
+-   int xp_base, xp_err_base;
+-#endif /* ifdef ECORE_XPRINT */
+ 
+    if (!num_ret)
+      return NULL;
+@@ -1229,80 +1226,6 @@ ecore_x_window_root_list(int *num_ret)
+    *num_ret = 0;
+ 
+    LOGFN(__FILE__, __LINE__, __FUNCTION__);
+-#ifdef ECORE_XPRINT
+-   num = ScreenCount(_ecore_x_disp);
+-   if (XpQueryExtension(_ecore_x_disp, &xp_base, &xp_err_base))
+-     {
+-        Screen **ps = NULL;
+-        int psnum = 0;
+-
+-        ps = XpQueryScreens(_ecore_x_disp, &psnum);
+-        if (ps)
+-          {
+-             int overlap, j;
+-
+-             overlap = 0;
+-             for (i = 0; i < num; i++)
+-               {
+-                  for (j = 0; j < psnum; j++)
+-                    {
+-                       if (ScreenOfDisplay(_ecore_x_disp, i) == ps[j])
+-                         overlap++;
+-                    }
+-               }
+-             roots = malloc(MAX((num - overlap) * sizeof(Ecore_X_Window), 1));
+-             if (roots)
+-               {
+-                  int k;
+-
+-                  k = 0;
+-                  for (i = 0; i < num; i++)
+-                    {
+-                       int is_print;
+-
+-                       is_print = 0;
+-                       for (j = 0; j < psnum; j++)
+-                         {
+-                            if (ScreenOfDisplay(_ecore_x_disp, i) == ps[j])
+-                              {
+-                                 is_print = 1;
+-                                 break;
+-                              }
+-                         }
+-                       if (!is_print)
+-                         {
+-                            roots[k] = RootWindow(_ecore_x_disp, i);
+-                            k++;
+-                         }
+-                    }
+-                  *num_ret = k;
+-               }
+-
+-             XFree(ps);
+-          }
+-        else
+-          {
+-             roots = malloc(num * sizeof(Ecore_X_Window));
+-             if (!roots)
+-               return NULL;
+-
+-             *num_ret = num;
+-             for (i = 0; i < num; i++)
+-               roots[i] = RootWindow(_ecore_x_disp, i);
+-          }
+-     }
+-   else
+-     {
+-        roots = malloc(num * sizeof(Ecore_X_Window));
+-        if (!roots)
+-          return NULL;
+-
+-        *num_ret = num;
+-        for (i = 0; i < num; i++)
+-          roots[i] = RootWindow(_ecore_x_disp, i);
+-     }
+-
+-#else /* ifdef ECORE_XPRINT */
+    num = ScreenCount(_ecore_x_disp);
+    roots = malloc(num * sizeof(Ecore_X_Window));
+    if (!roots)
+@@ -1311,7 +1234,6 @@ ecore_x_window_root_list(int *num_ret)
+    *num_ret = num;
+    for (i = 0; i < num; i++)
+      roots[i] = RootWindow(_ecore_x_disp, i);
+-#endif /* ifdef ECORE_XPRINT */
+    return roots;
+ }
+ 
+diff --git a/src/lib/ecore_x/xlib/ecore_x_private.h b/src/lib/ecore_x/xlib/ecore_x_private.h
+index 97b3858..07c09fb 100644
+--- a/src/lib/ecore_x/xlib/ecore_x_private.h
++++ b/src/lib/ecore_x/xlib/ecore_x_private.h
+@@ -19,9 +19,6 @@
+ #ifdef ECORE_XCURSOR
+ #include <X11/Xcursor/Xcursor.h>
+ #endif /* ifdef ECORE_XCURSOR */
+-#ifdef ECORE_XPRINT
+-#include <X11/extensions/Print.h>
+-#endif /* ifdef ECORE_XPRINT */
+ #ifdef ECORE_XINERAMA
+ #include <X11/extensions/Xinerama.h>
+ #endif /* ifdef ECORE_XINERAMA */
+-- 
+2.4.3
+
diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
index 53adea2..8356fa1 100644
--- a/package/efl/libefl/Config.in
+++ b/package/efl/libefl/Config.in
@@ -42,6 +42,47 @@ comment "libecore video support"
 config BR2_PACKAGE_LIBEFL_FB
 	bool "libecore framebuffer support"
 
+config BR2_PACKAGE_LIBEFL_X
+	bool "libecore X support"
+	depends on BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_XLIB_LIBX11
+	select BR2_PACKAGE_XLIB_LIBXEXT
+
+if BR2_PACKAGE_LIBEFL_X
+
+choice
+	prompt "select libecore XLIB/XCB support"
+
+config BR2_PACKAGE_LIBEFL_X_XLIB
+	bool "libecore XLIB support"
+	select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
+	select BR2_PACKAGE_XLIB_LIBXCURSOR
+	select BR2_PACKAGE_XLIB_LIBXDAMAGE
+	select BR2_PACKAGE_XLIB_LIBXINERAMA
+	select BR2_PACKAGE_XLIB_LIBXP
+	select BR2_PACKAGE_XLIB_LIBXRANDR
+	select BR2_PACKAGE_XLIB_LIBXRENDER
+	select BR2_PACKAGE_XLIB_LIBXSCRNSAVER
+	select BR2_PACKAGE_XLIB_LIBXTST
+	select BR2_PACKAGE_XPROTO_GLPROTO
+
+config BR2_PACKAGE_LIBEFL_X_XCB
+	bool "libecore XCB support"
+	depends on !BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
+	select BR2_PACKAGE_LIBXCB
+	select BR2_PACKAGE_XCB_UTIL_IMAGE # xcb-image.pc
+	select BR2_PACKAGE_XCB_UTIL_KEYSYMS # xcb-keysyms.pc
+	select BR2_PACKAGE_XCB_UTIL_RENDERUTIL # xcb-renderutil.pc
+	select BR2_PACKAGE_XCB_UTIL_WM # xcb-icccm.pc
+	select BR2_PACKAGE_XLIB_LIBX11
+
+comment "for libecore XCB support disable recommended configurations"
+	depends on BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
+
+endchoice
+
+endif # BR2_PACKAGE_LIBEFL_X
+
 comment "libevas loaders"
 
 config BR2_PACKAGE_LIBEFL_PNG
diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index e53470d..6a1a8ae 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -18,6 +18,7 @@ LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg libcurl lua \
 
 # regenerate the configure script:
 # https://phab.enlightenment.org/T2718
+# configure.ac patched by 0002-ecore_x-Remove-XPrint-usage.patch
 LIBEFL_AUTORECONF = YES
 LIBEFL_GETTEXTIZE = YES
 
@@ -30,7 +31,7 @@ LIBEFL_CONF_OPTS = \
 	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
 	--disable-cxx-bindings \
 	--enable-lua-old \
-	--with-x11=none
+	--enable-lua-old
 
 # Disable untested configuration warning.
 ifeq ($(BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG),)
@@ -172,6 +173,65 @@ else
 LIBEFL_CONF_OPTS += --enable-fb=no
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
+LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \
+	--x-includes=$(STAGING_DIR)/usr/include \
+	--x-libraries=$(STAGING_DIR)/usr/lib \
+	--with-opengl=none
+
+LIBEFL_DEPENDENCIES += \
+	xlib_libX11 \
+	xlib_libXext
+else
+LIBEFL_CONF_OPTS += --with-x=no \
+	--with-x11=none
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB),y)
+LIBEFL_DEPENDENCIES += \
+	xlib_libX11 \
+	xlib_libXcomposite \
+	xlib_libXcursor \
+	xlib_libXdamage \
+	xlib_libXext \
+	xlib_libXinerama \
+	xlib_libXrandr \
+	xlib_libXrender \
+	xlib_libXScrnSaver \
+	xlib_libXtst
+LIBEFL_CONF_OPTS += --with-x11=xlib
+endif
+
+# xcb-util-image to provide xcb-image.pc
+# xcb-util-renderutil to provide xcb-renderutil.pc
+# xcb-util-wm to provide xcb-icccm.pc
+# xcb-util-keysyms to provide xcb-keysyms.pc
+ifeq ($(BR2_PACKAGE_LIBEFL_X_XCB),y)
+LIBEFL_DEPENDENCIES += libxcb \
+	xcb-util-image \
+	xcb-util-keysyms \
+	xcb-util-renderutil \
+	xcb-util-wm
+# You have chosen to use XCB instead of Xlib. It is a myth that XCB
+# is amazingly faster than Xlib (when used sensibly). It can be
+# faster in a few corner cases on startup of an app, but it comes
+# with many downsides. One of those is more complex code inside
+# ecore_x, which is far less tested in XCB mode than Xlib. Also
+# the big catch is that OpenGL support basically requires Xlib anyway
+# so if you want OpenGL in X11, you need Xlib regardless and so you
+# gain nothing really in terms of speed and no savings in memory
+# because Xlib is still linked, loaded and used, BUT instead you
+# have OpenGL drivers working with an hybrid XCB/Xlib (mostly XCB)
+# toolkit and this is basically never tested by anyone working on
+# the OpenGL drivers, so you will have bugs. Do not enable XCB
+# and use OpenGL. XCB is only useful if you wish to shave a few Kb
+# off the memory footprint of a whole system and live with less
+# tested code, and possibly unimplemented features in ecore_x. To
+# remove the XCB setup, remove the --with-x11=xcb option to
+# configure.
+LIBEFL_CONF_OPTS += --with-x11=xcb
+endif
+
 # image loader: handle only loaders that requires dependencies.
 # All other loaders are builded by default statically.
 ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 15/36] package/efl/libefl: add OpenGL/OpenGLES support
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (13 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 14/36] package/efl/libefl: add X11 support Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 15:08   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 16/36] package/efl/libefl: enable xinput2.2 Romain Naour
                   ` (20 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

Allow to enable graphic acceleration using OpenGL or
OpenGLES with efl libraries.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: rename libefl
    improve commit log
---
 package/efl/libefl/Config.in | 26 ++++++++++++++++++++++++++
 package/efl/libefl/libefl.mk | 17 +++++++++++++++--
 2 files changed, 41 insertions(+), 2 deletions(-)

diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
index 8356fa1..a3b6f0e 100644
--- a/package/efl/libefl/Config.in
+++ b/package/efl/libefl/Config.in
@@ -81,6 +81,32 @@ comment "for libecore XCB support disable recommended configurations"
 
 endchoice
 
+if BR2_PACKAGE_LIBEFL_X_XLIB
+
+choice
+	prompt "select libevas OpenGL support"
+
+config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_FULL
+	bool "libevas OpenGL full support"
+	depends on BR2_PACKAGE_HAS_LIBGL
+
+comment "libevas OpenGLES support needs libgl"
+	depends on !BR2_PACKAGE_HAS_LIBGL
+
+config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_ES
+	bool "libevas OpenGLES support"
+	depends on BR2_PACKAGE_HAS_LIBGLES
+
+comment "libevas OpenGLES support needs libgles"
+	depends on !BR2_PACKAGE_HAS_LIBGLES
+
+config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_NONE
+	bool "libevas disable OpenGL support"
+
+endchoice
+
+endif # BR2_PACKAGE_LIBEFL_X_XLIB
+
 endif # BR2_PACKAGE_LIBEFL_X
 
 comment "libevas loaders"
diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index 6a1a8ae..e275699 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -176,8 +176,7 @@ endif
 ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
 LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \
 	--x-includes=$(STAGING_DIR)/usr/include \
-	--x-libraries=$(STAGING_DIR)/usr/lib \
-	--with-opengl=none
+	--x-libraries=$(STAGING_DIR)/usr/lib
 
 LIBEFL_DEPENDENCIES += \
 	xlib_libX11 \
@@ -187,6 +186,20 @@ LIBEFL_CONF_OPTS += --with-x=no \
 	--with-x11=none
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB_GLX_FULL),y)
+LIBEFL_CONF_OPTS += --with-opengl=full
+LIBEFL_DEPENDENCIES += libgl
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB_GLX_ES),y)
+LIBEFL_CONF_OPTS += --with-opengl=es
+LIBEFL_DEPENDENCIES += libgles
+endif
+
+ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB_GLX_NONE),y)
+LIBEFL_CONF_OPTS += --with-opengl=none
+endif
+
 ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB),y)
 LIBEFL_DEPENDENCIES += \
 	xlib_libX11 \
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 16/36] package/efl/libefl: enable xinput2.2
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (14 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 15/36] package/efl/libefl: add OpenGL/OpenGLES support Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 15:11   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 17/36] package/efl/libefl: add systemd dependency Romain Naour
                   ` (19 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

X11 XInput v2.2+ support is one of the recommended
feature for the efl libraries:
https://git.enlightenment.org/core/efl.git/tree/README?h=efl-1.15#n490

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: rename to libefl
    improve commit log
v3: new patch
---
 package/efl/libefl/libefl.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index e275699..02c9005 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -173,10 +173,12 @@ else
 LIBEFL_CONF_OPTS += --enable-fb=no
 endif
 
+# --enable-xinput22 is recommended
 ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
 LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \
 	--x-includes=$(STAGING_DIR)/usr/include \
-	--x-libraries=$(STAGING_DIR)/usr/lib
+	--x-libraries=$(STAGING_DIR)/usr/lib \
+	--enable-xinput22
 
 LIBEFL_DEPENDENCIES += \
 	xlib_libX11 \
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 17/36] package/efl/libefl: add systemd dependency
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (15 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 16/36] package/efl/libefl: enable xinput2.2 Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 15:13   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 18/36] package/efl/libefl: add sdl2 support Romain Naour
                   ` (18 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

systemd it one of the "highly recommended" dependecies
according to the README [1] but disabling it doesn't need
the --enable-i-really-know-what-i-am-doing... option.
That's why systemd is not added to
BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG.

[1] https://git.enlightenment.org/core/efl.git/tree/README?h=efl-1.15#n491

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: rename to libefl
    improve commit log
v3: new patch
---
 package/efl/libefl/libefl.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index 02c9005..c26c9c5 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -52,6 +52,13 @@ ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),y)
 LIBEFL_DEPENDENCIES += util-linux
 endif
 
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+LIBEFL_CONF_OPTS += --enable-systemd
+LIBEFL_DEPENDENCIES += systemd
+else
+LIBEFL_CONF_OPTS += --disable-systemd
+endif
+
 # If fontconfig is disabled, this is going to make general font
 # searching not work, and only some very direct 'load /path/file.ttf'
 # will work alongside some old-school ttf file path searching. This
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 18/36] package/efl/libefl: add sdl2 support
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (16 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 17/36] package/efl/libefl: add systemd dependency Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 15:20   ` Yann E. MORIN
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 19/36] package/libevas-generic-loaders: bump to version 1.15.0 Romain Naour
                   ` (17 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

SDL support can't be used with OpenGLES.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: new patch added since sdl2 package is new available
---
 package/efl/libefl/Config.in |  7 +++++++
 package/efl/libefl/libefl.mk | 11 +++++++++++
 2 files changed, 18 insertions(+)

diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
index a3b6f0e..44860a2 100644
--- a/package/efl/libefl/Config.in
+++ b/package/efl/libefl/Config.in
@@ -42,6 +42,12 @@ comment "libecore video support"
 config BR2_PACKAGE_LIBEFL_FB
 	bool "libecore framebuffer support"
 
+config BR2_PACKAGE_LIBEFL_SDL2
+	bool "libevas SDL2 support"
+	# SDL support is not available with OpenGLES.
+	depends on !BR2_PACKAGE_LIBEFL_X_XLIB_GLX_ES
+	select BR2_PACKAGE_SDL2
+
 config BR2_PACKAGE_LIBEFL_X
 	bool "libecore X support"
 	depends on BR2_PACKAGE_XORG7
@@ -89,6 +95,7 @@ choice
 config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_FULL
 	bool "libevas OpenGL full support"
 	depends on BR2_PACKAGE_HAS_LIBGL
+	select BR2_PACKAGE_LIBGLU if BR2_PACKAGE_LIBEFL_SDL2 # evas depends on libglu header in evas_engine.c
 
 comment "libevas OpenGLES support needs libgl"
 	depends on !BR2_PACKAGE_HAS_LIBGL
diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index c26c9c5..8ddca64 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -180,6 +180,17 @@ else
 LIBEFL_CONF_OPTS += --enable-fb=no
 endif
 
+ifeq ($(BR2_PACKAGE_LIBEFL_SDL2),y)
+LIBEFL_CONF_OPTS += --enable-sdl=yes
+LIBEFL_DEPENDENCIES += sdl2
+else
+LIBEFL_CONF_OPTS += --enable-sdl=no
+endif
+
+ifeq ($(BR2_PACKAGE_EFL_X_XLIB_GLX_FULL)$(BR2_PACKAGE_EFL_SDL2),yy)
+EFL_DEPENDENCIES += libglu
+endif
+
 # --enable-xinput22 is recommended
 ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
 LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 19/36] package/libevas-generic-loaders: bump to version 1.15.0
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (17 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 18/36] package/efl/libefl: add sdl2 support Romain Naour
@ 2015-10-24 21:00 ` Romain Naour
  2015-10-25 16:01   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 20/36] package/libevas-generic-loaders: add libraw dependency Romain Naour
                   ` (16 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:00 UTC (permalink / raw)
  To: buildroot

Use the newly added libefl package wich provide a new version
of libeina.

Also, update the upstream url and add a hash file.

While at it, remove BR2_TOOLCHAIN_HAS_THREADS and BR2_INSTALL_LIBSTDCPP
dependencies since the efl package already depend on them.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: Use depends on BR2_PACKAGE_EFL instead of select (ThomasP)
v4: rename to libefl
    improve commit log
    add a dependency on threads
v3: remove trailing slash (Vicente Bergas)
v2: bump to 1.15
    remove glibc only dependency
---
 package/libevas-generic-loaders/Config.in                    | 9 +--------
 package/libevas-generic-loaders/libevas-generic-loaders.hash | 2 ++
 package/libevas-generic-loaders/libevas-generic-loaders.mk   | 9 +++++----
 3 files changed, 8 insertions(+), 12 deletions(-)
 create mode 100644 package/libevas-generic-loaders/libevas-generic-loaders.hash

diff --git a/package/libevas-generic-loaders/Config.in b/package/libevas-generic-loaders/Config.in
index d0c3cf4..5b9f009 100644
--- a/package/libevas-generic-loaders/Config.in
+++ b/package/libevas-generic-loaders/Config.in
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
 	bool "libevas generic loaders"
-	select BR2_PACKAGE_LIBEINA
 	select BR2_PACKAGE_ZLIB
 	depends on BR2_PACKAGE_EFL
 	help
@@ -8,7 +7,7 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
 	  stand-alone executables that evas may run from its generic
 	  loader module.
 
-	  http://trac.enlightenment.org/e/wiki/Evas_Generic_Loaders
+	  https://www.enlightenment.org/
 
 if BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
 
@@ -16,14 +15,8 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
 	bool "SVG loader"
 	select BR2_PACKAGE_LIBRSVG
 	select BR2_PACKAGE_CAIRO
-	depends on BR2_TOOLCHAIN_HAS_THREADS # librsvg -> glib2
-	depends on BR2_INSTALL_LIBSTDCPP # librsvg -> pango
 	depends on BR2_ARCH_HAS_ATOMICS # cairo
 	help
 	  This option enables the Evas generic SVG loader
 
-comment "SVG loader needs a toolchain w/ threads, C++"
-	depends on BR2_ARCH_HAS_ATOMICS
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
-
 endif
diff --git a/package/libevas-generic-loaders/libevas-generic-loaders.hash b/package/libevas-generic-loaders/libevas-generic-loaders.hash
new file mode 100644
index 0000000..32723ba
--- /dev/null
+++ b/package/libevas-generic-loaders/libevas-generic-loaders.hash
@@ -0,0 +1,2 @@
+# From https://download.enlightenment.org/rel/libs/evas_generic_loaders/evas_generic_loaders-1.15.0.tar.xz.sha256
+sha256	1e539e4d4d4e1590345caeb7fdd84f47ec7cd63bb76b6b7107a87420a401fd7f	evas_generic_loaders-1.15.0.tar.xz
diff --git a/package/libevas-generic-loaders/libevas-generic-loaders.mk b/package/libevas-generic-loaders/libevas-generic-loaders.mk
index ac6b1cc..d8ab252 100644
--- a/package/libevas-generic-loaders/libevas-generic-loaders.mk
+++ b/package/libevas-generic-loaders/libevas-generic-loaders.mk
@@ -4,17 +4,18 @@
 #
 ################################################################################
 
-LIBEVAS_GENERIC_LOADERS_VERSION = 1.7.10
-LIBEVAS_GENERIC_LOADERS_SOURCE = evas_generic_loaders-$(LIBEVAS_GENERIC_LOADERS_VERSION).tar.bz2
-LIBEVAS_GENERIC_LOADERS_SITE = http://download.enlightenment.org/releases
+LIBEVAS_GENERIC_LOADERS_VERSION = 1.15.0
+LIBEVAS_GENERIC_LOADERS_SOURCE = evas_generic_loaders-$(LIBEVAS_GENERIC_LOADERS_VERSION).tar.xz
+LIBEVAS_GENERIC_LOADERS_SITE = http://download.enlightenment.org/rel/libs/evas_generic_loaders
 LIBEVAS_GENERIC_LOADERS_LICENSE = GPLv2
 LIBEVAS_GENERIC_LOADERS_LICENSE_FILES = COPYING
 
 LIBEVAS_GENERIC_LOADERS_INSTALL_STAGING = YES
 
-LIBEVAS_GENERIC_LOADERS_DEPENDENCIES = libeina zlib
+LIBEVAS_GENERIC_LOADERS_DEPENDENCIES = libefl zlib
 
 # For now, we only support the SVG loader
+# poppler >= 0.32 is not supported with libevas-generic-loaders 1.14.0
 LIBEVAS_GENERIC_LOADERS_CONF_OPTS += \
 	--disable-poppler \
 	--disable-spectre \
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 20/36] package/libevas-generic-loaders: add libraw dependency
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (18 preceding siblings ...)
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 19/36] package/libevas-generic-loaders: bump to version 1.15.0 Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:03   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 21/36] package/efl/libelementary: bump to version 1.15.2 Romain Naour
                   ` (15 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

libraw it's one of the "highly recommended" dependecies
according to the README [1].

[1] https://git.enlightenment.org/core/evas_generic_loaders.git/tree/README?id=v1.15.0#n31

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: improve commit log
---
 package/libevas-generic-loaders/Config.in                  | 5 +++++
 package/libevas-generic-loaders/libevas-generic-loaders.mk | 9 +++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/package/libevas-generic-loaders/Config.in b/package/libevas-generic-loaders/Config.in
index 5b9f009..26166a8 100644
--- a/package/libevas-generic-loaders/Config.in
+++ b/package/libevas-generic-loaders/Config.in
@@ -11,6 +11,11 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
 
 if BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
 
+config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_LIBRAW
+	bool "Libraw loader"
+	help
+	  This option enables the Evas generic Libraw loader
+
 config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
 	bool "SVG loader"
 	select BR2_PACKAGE_LIBRSVG
diff --git a/package/libevas-generic-loaders/libevas-generic-loaders.mk b/package/libevas-generic-loaders/libevas-generic-loaders.mk
index d8ab252..4665ded 100644
--- a/package/libevas-generic-loaders/libevas-generic-loaders.mk
+++ b/package/libevas-generic-loaders/libevas-generic-loaders.mk
@@ -14,14 +14,19 @@ LIBEVAS_GENERIC_LOADERS_INSTALL_STAGING = YES
 
 LIBEVAS_GENERIC_LOADERS_DEPENDENCIES = libefl zlib
 
-# For now, we only support the SVG loader
 # poppler >= 0.32 is not supported with libevas-generic-loaders 1.14.0
 LIBEVAS_GENERIC_LOADERS_CONF_OPTS += \
 	--disable-poppler \
 	--disable-spectre \
-	--disable-libraw \
 	--disable-gstreamer
 
+ifeq ($(BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_LIBRAW),y)
+LIBEVAS_GENERIC_LOADERS_DEPENDENCIES += libraw
+LIBEVAS_GENERIC_LOADERS_CONF_OPTS += --enable-libraw
+else
+LIBEVAS_GENERIC_LOADERS_CONF_OPTS += --disable-libraw
+endif
+
 ifeq ($(BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG),y)
 LIBEVAS_GENERIC_LOADERS_DEPENDENCIES += librsvg cairo
 LIBEVAS_GENERIC_LOADERS_CONF_OPTS += --enable-svg
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 21/36] package/efl/libelementary: bump to version 1.15.2
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (19 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 20/36] package/libevas-generic-loaders: add libraw dependency Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:09   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 22/36] package/efl/libelementary: add host package Romain Naour
                   ` (14 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

Use the newly added libefl package wich provide a new version
of libeina, libevas, libecore and libedje.

Update the upstream url and add a hash file.

Since eet, eolian_gen and eldbus_codegen are installed in
HOST_DIR by host-efl package, help configure script to find
them.

Explicitly disable doxygen and elementary-test.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: move the hash file to package/efl/libelementary
v4: keep libelementary in package/efl/
v3: bump to 1.15.2
    remove trailing slash (Vicente Bergas)
v2: bump to 1.15.1
    remove glibc only dependency
---
 package/efl/libelementary/Config.in          | 11 +----------
 package/efl/libelementary/libelementary.hash |  2 ++
 package/efl/libelementary/libelementary.mk   | 25 +++++++++----------------
 3 files changed, 12 insertions(+), 26 deletions(-)
 create mode 100644 package/efl/libelementary/libelementary.hash

diff --git a/package/efl/libelementary/Config.in b/package/efl/libelementary/Config.in
index 4f62592..182b14a 100644
--- a/package/efl/libelementary/Config.in
+++ b/package/efl/libelementary/Config.in
@@ -1,17 +1,8 @@
-comment "libelementary needs a toolchain w/ threads, dynamic library"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
-
 config BR2_PACKAGE_LIBELEMENTARY
 	bool "libelementary"
-	select BR2_PACKAGE_LIBEINA
-	select BR2_PACKAGE_LIBEVAS
-	select BR2_PACKAGE_LIBECORE
-	select BR2_PACKAGE_LIBEDJE
-	depends on BR2_TOOLCHAIN_HAS_THREADS # libevas
-	depends on !BR2_STATIC_LIBS
 	help
 	  Elementary is a widget toolkit and EFL wrapper and convenience
 	  library to make it easy to build applications and tools with UIs
 	  with less code.
 
-	  http://trac.enlightenment.org/e/wiki/Elementary
+	  https://enlightenment.org
diff --git a/package/efl/libelementary/libelementary.hash b/package/efl/libelementary/libelementary.hash
new file mode 100644
index 0000000..2cd36d8
--- /dev/null
+++ b/package/efl/libelementary/libelementary.hash
@@ -0,0 +1,2 @@
+# From https://download.enlightenment.org/rel/libs/elementary/elementary-1.15.2.tar.xz.sha256
+sha256	523c3073210b611817d0f56aa8348962ec757282f9f7dfde93825afa164a0f3f	elementary-1.15.2.tar.xz
diff --git a/package/efl/libelementary/libelementary.mk b/package/efl/libelementary/libelementary.mk
index 8bd69fe..a2c4a60 100644
--- a/package/efl/libelementary/libelementary.mk
+++ b/package/efl/libelementary/libelementary.mk
@@ -4,29 +4,22 @@
 #
 ################################################################################
 
-LIBELEMENTARY_VERSION = 1.7.10
-LIBELEMENTARY_SOURCE = elementary-$(LIBELEMENTARY_VERSION).tar.bz2
-LIBELEMENTARY_SITE = http://download.enlightenment.org/releases
+LIBELEMENTARY_VERSION = 1.15.2
+LIBELEMENTARY_SOURCE = elementary-$(LIBELEMENTARY_VERSION).tar.xz
+LIBELEMENTARY_SITE = http://download.enlightenment.org/rel/libs/elementary
 LIBELEMENTARY_LICENSE = LGPLv2.1
 LIBELEMENTARY_LICENSE_FILES = COPYING
 
 LIBELEMENTARY_INSTALL_STAGING = YES
 
-LIBELEMENTARY_DEPENDENCIES = \
-	libeina libevas libecore libedje host-libedje \
-	host-libeet
+LIBELEMENTARY_DEPENDENCIES = host-pkgconf host-libefl libefl
 
 LIBELEMENTARY_CONF_OPTS = \
 	--with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc \
-	--with-eet-eet=$(HOST_DIR)/usr/bin/eet
-
-# libethumb_client is only built when ethumbd is built.
-# ethumbd is only built if edbus is built.
-ifeq ($(BR2_PACKAGE_LIBETHUMB)$(BR2_PACKAGE_LIBEDBUS),yy)
-LIBELEMENTARY_DEPENDENCIES += libethumb
-LIBELEMENTARY_CONF_OPTS += --enable-ethumb
-else
-LIBELEMENTARY_CONF_OPTS += --disable-ethumb
-endif
+	--with-eet-eet=$(HOST_DIR)/usr/bin/eet \
+	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
+	--with-eldbus_codegen=$(HOST_DIR)/usr/bin/eldbus-codegen \
+	--with-doxygen=no \
+	--disable-elementary-test
 
 $(eval $(autotools-package))
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 22/36] package/efl/libelementary: add host package
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (20 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 21/36] package/efl/libelementary: bump to version 1.15.2 Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:11   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 23/36] package/efl: libefl and libelementary share the same version number Romain Naour
                   ` (13 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

elm_prefs_cc builded for the host machine is
needed to cross-compile correctly libelementary
for the target. Otherwise, elm_prefs_cc for the
target is used on the host machine.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: use libefl
    reword the commit message
---
 package/efl/libelementary/libelementary.mk | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/package/efl/libelementary/libelementary.mk b/package/efl/libelementary/libelementary.mk
index a2c4a60..4ba8681 100644
--- a/package/efl/libelementary/libelementary.mk
+++ b/package/efl/libelementary/libelementary.mk
@@ -12,14 +12,26 @@ LIBELEMENTARY_LICENSE_FILES = COPYING
 
 LIBELEMENTARY_INSTALL_STAGING = YES
 
-LIBELEMENTARY_DEPENDENCIES = host-pkgconf host-libefl libefl
+LIBELEMENTARY_DEPENDENCIES = host-pkgconf host-libefl host-libelementary libefl
 
 LIBELEMENTARY_CONF_OPTS = \
 	--with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc \
 	--with-eet-eet=$(HOST_DIR)/usr/bin/eet \
 	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
 	--with-eldbus_codegen=$(HOST_DIR)/usr/bin/eldbus-codegen \
+	--with-elm-prefs-cc=$(HOST_DIR)/usr/bin/elm_prefs_cc \
+	--with-doxygen=no \
+	--disable-elementary-test
+
+# We need a host package in order to provide elm_prefs_cc and
+# elementary_codegen.
+HOST_LIBELEMENTARY_DEPENDENCIES = host-pkgconf host-libefl
+HOST_LIBELEMENTARY_CONF_OPTS = \
+	--with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc \
+	--with-eet-eet=$(HOST_DIR)/usr/bin/eet \
+	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
 	--with-doxygen=no \
 	--disable-elementary-test
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 23/36] package/efl: libefl and libelementary share the same version number
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (21 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 22/36] package/efl/libelementary: add host package Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:13   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 24/36] package/enlightenment: bump to version 0.19.12 Romain Naour
                   ` (12 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/efl/efl.mk                         | 2 ++
 package/efl/libefl/libefl.mk               | 3 +--
 package/efl/libelementary/libelementary.mk | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/package/efl/efl.mk b/package/efl/efl.mk
index 99e4d14..151ac28 100644
--- a/package/efl/efl.mk
+++ b/package/efl/efl.mk
@@ -1,2 +1,4 @@
 
+EFL_VERSION = 1.15.2
+
 include $(sort $(wildcard package/efl/*/*.mk))
diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
index 8ddca64..6aaa08b 100644
--- a/package/efl/libefl/libefl.mk
+++ b/package/efl/libefl/libefl.mk
@@ -4,8 +4,7 @@
 #
 ################################################################################
 
-# hardcode the version here since the bump to 1.15 is not complete in Buildroot
-LIBEFL_VERSION = 1.15.2
+LIBEFL_VERSION = $(EFL_VERSION)
 LIBEFL_SOURCE = efl-$(LIBEFL_VERSION).tar.xz
 LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl
 LIBEFL_LICENSE = BSD-2c, LGPLv2.1+, GPLv2+
diff --git a/package/efl/libelementary/libelementary.mk b/package/efl/libelementary/libelementary.mk
index 4ba8681..c920801 100644
--- a/package/efl/libelementary/libelementary.mk
+++ b/package/efl/libelementary/libelementary.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBELEMENTARY_VERSION = 1.15.2
+LIBELEMENTARY_VERSION = $(EFL_VERSION)
 LIBELEMENTARY_SOURCE = elementary-$(LIBELEMENTARY_VERSION).tar.xz
 LIBELEMENTARY_SITE = http://download.enlightenment.org/rel/libs/elementary
 LIBELEMENTARY_LICENSE = LGPLv2.1
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 24/36] package/enlightenment: bump to version 0.19.12
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (22 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 23/36] package/efl: libefl and libelementary share the same version number Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:28   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 25/36] package/expedite: bump to efl-1.15 branch Romain Naour
                   ` (11 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

Use the newly added libefl package wich provide a new version
of efl libraries.
This new version needs libelementary dependency.

Update upstream url, add hash file and use xz archive.

Select png and jpeg image loader since enlightenment_start
fail at runtime if png and jpeg image loader are not
available in elf libraries.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: Use depends on BR2_PACKAGE_EFL instead of select (ThomasP)
    remove comment on dependencies
v4: update Config.in to use libefl
    improve commit log
    keep the dependency on threads
v3: bymp to 0.19.12
    remove trailing slash (Vicente Bergas)
v2: bump to 0.19.9
    remove glibc only dependency
---
 package/enlightenment/Config.in          | 36 +++++++-------------------------
 package/enlightenment/enlightenment.hash |  2 ++
 package/enlightenment/enlightenment.mk   | 22 +++++++------------
 3 files changed, 17 insertions(+), 43 deletions(-)
 create mode 100644 package/enlightenment/enlightenment.hash

diff --git a/package/enlightenment/Config.in b/package/enlightenment/Config.in
index 58f8f39..4a349fb 100644
--- a/package/enlightenment/Config.in
+++ b/package/enlightenment/Config.in
@@ -1,33 +1,16 @@
 config BR2_PACKAGE_ENLIGHTENMENT
 	bool "enlightenment"
-	select BR2_PACKAGE_EFL
-	select BR2_PACKAGE_LIBECORE
-	select BR2_PACKAGE_LIBECORE_X
-	select BR2_PACKAGE_LIBEINA
-	select BR2_PACKAGE_LIBEET
-	select BR2_PACKAGE_LIBEVAS
-	select BR2_PACKAGE_LIBEVAS_JPEG
-	select BR2_PACKAGE_LIBEVAS_PNG
-	select BR2_PACKAGE_LIBEVAS_EET
-	select BR2_PACKAGE_LIBECORE_EVAS
-	select BR2_PACKAGE_LIBEDJE
-	select BR2_PACKAGE_LIBEFREET
-	select BR2_PACKAGE_LIBEDBUS
-	select BR2_PACKAGE_LIBEIO
-	select BR2_PACKAGE_XCB_UTIL_KEYSYMS
+	select BR2_PACKAGE_LIBEFL_X
+	select BR2_PACKAGE_LIBEFL_JPEG # needed at runtime by enlightenment_start
+	select BR2_PACKAGE_LIBEFL_PNG # needed at runtime by enlightenment_start
+	select BR2_PACKAGE_LIBELEMENTARY
 	select BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
 	select BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
-	# libevas-generic-loaders-svg -> librsvg -> glib2 / pango
-	depends on BR2_USE_WCHAR
-	depends on BR2_INSTALL_LIBSTDCPP
-	# libedbus -> dbus
-	# libedbus -> glib2, libevas
-	depends on BR2_TOOLCHAIN_HAS_THREADS
-	# libedbus -> dbus, efl libraries
-	depends on BR2_USE_MMU
-	depends on BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_XCB_UTIL_KEYSYMS
 	# libevas-generic-loaders-svg -> librsvg -> pango -> cairo
 	depends on BR2_ARCH_HAS_ATOMICS
+	depends on BR2_PACKAGE_EFL
+	depends on BR2_PACKAGE_XORG7
 	help
 	  Enlightenment, also known simply as E, is a stacking window
 	  manager for the X Window System which can be used alone or
@@ -36,8 +19,3 @@ config BR2_PACKAGE_ENLIGHTENMENT
 	  desktop environment.
 
 	  http://www.enlightenment.org/
-
-comment "enlightenment needs a toolchain w/ wchar, C++, threads"
-	depends on BR2_PACKAGE_XORG7 && BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
-	depends on BR2_ARCH_HAS_ATOMICS
diff --git a/package/enlightenment/enlightenment.hash b/package/enlightenment/enlightenment.hash
new file mode 100644
index 0000000..c9b1284
--- /dev/null
+++ b/package/enlightenment/enlightenment.hash
@@ -0,0 +1,2 @@
+# From https://phab.enlightenment.org/phame/live/3/post/e19_12_release/
+sha256	55f23c337e3092e735ae37ada8f6701adab5ddd13f37ef38c63eec8a536f0b25	enlightenment-0.19.12.tar.xz
diff --git a/package/enlightenment/enlightenment.mk b/package/enlightenment/enlightenment.mk
index ddebe06..9127099 100644
--- a/package/enlightenment/enlightenment.mk
+++ b/package/enlightenment/enlightenment.mk
@@ -4,24 +4,18 @@
 #
 ################################################################################
 
-ENLIGHTENMENT_VERSION = 0.17.6
-ENLIGHTENMENT_SITE = http://download.enlightenment.org/releases
+ENLIGHTENMENT_VERSION = 0.19.12
+ENLIGHTENMENT_SOURCE = enlightenment-$(ENLIGHTENMENT_VERSION).tar.xz
+ENLIGHTENMENT_SITE = http://download.enlightenment.org/rel/apps/enlightenment
 ENLIGHTENMENT_LICENSE = BSD-2c
 ENLIGHTENMENT_LICENSE_FILES = COPYING
 
-ENLIGHTENMENT_DEPENDENCIES = 	\
-	host-pkgconf 		\
-	libecore 		\
-	libeet 			\
-	libeina 		\
-	libevas 		\
+ENLIGHTENMENT_DEPENDENCIES = \
+	host-pkgconf \
+	host-libefl \
+	libefl \
+	libelementary \
 	libevas-generic-loaders \
-	libedje 		\
-	libefreet 		\
-	libedbus 		\
-	libeio 			\
-	host-libedje 		\
-	host-libeet		\
 	xcb-util-keysyms
 
 ENLIGHTENMENT_CONF_OPTS = \
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 25/36] package/expedite: bump to efl-1.15 branch
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (23 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 24/36] package/enlightenment: bump to version 0.19.12 Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:36   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 26/36] package/efl/libethumb: remove package Romain Naour
                   ` (10 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

Since expedite hasn't been released since 1.7.10 release,
use efl-1.15 branch in the git tree.

Use the newly added libefl package wich provide a new version
of efl libraries.

Autoreconf the package since there is no configure script
in the git tree.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: Use depends on BR2_PACKAGE_EFL instead of select (ThomasP)
    remove comments on dependencies
v4: update Config.in to use libefl
    improve commit log
    keep the dependency on threads
    Replace the old BR2_PACKAGE_LIBEVAS_X11 by BR2_PACKAGE_LIBEFL_X
v2: bump to 1.15 branch
---
 package/expedite/Config.in   |  8 --------
 package/expedite/expedite.mk | 13 +++++++++----
 2 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/package/expedite/Config.in b/package/expedite/Config.in
index de6a056..7846881 100644
--- a/package/expedite/Config.in
+++ b/package/expedite/Config.in
@@ -1,16 +1,8 @@
 config BR2_PACKAGE_EXPEDITE
 	bool "expedite"
-	select BR2_PACKAGE_LIBEINA
-	select BR2_PACKAGE_LIBEVAS
-	select BR2_PACKAGE_LIBEET
 	depends on BR2_PACKAGE_EFL
-	depends on BR2_INSTALL_LIBSTDCPP
-	depends on BR2_TOOLCHAIN_HAS_THREADS # libevas
 	help
 	  Expedite is the official Evas benchmark tool. It can test different
 	  engines, such as X11, XRender, OpenGL (also ES variant), SDL,
 	  DirectFB and so on. Its tests are quite extensive, trying to
 	  reproduce real world usage cases.
-
-comment "expedite needs a toolchain w/ C++, threads"
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/expedite/expedite.mk b/package/expedite/expedite.mk
index 9b232f8..ae30535 100644
--- a/package/expedite/expedite.mk
+++ b/package/expedite/expedite.mk
@@ -4,14 +4,19 @@
 #
 ################################################################################
 
-EXPEDITE_VERSION = 1.7.10
-EXPEDITE_SITE = http://download.enlightenment.org/releases
+# efl-1.15 branch
+EXPEDITE_VERSION = 3ce8b3f1451700f9a2da60c2e717c644220e2449
+EXPEDITE_SITE = http://git.enlightenment.org/tools/expedite.git
+EXPEDITE_SITE_METHOD = git
 EXPEDITE_LICENSE = BSD-2c
 EXPEDITE_LICENSE_FILES = COPYING
 
-EXPEDITE_DEPENDENCIES = libevas libeina libeet
+EXPEDITE_DEPENDENCIES = host-libefl libefl
 
-ifeq ($(BR2_PACKAGE_LIBEVAS_X11),y)
+# There is no configure script in the git tree.
+EXPEDITE_AUTORECONF = YES
+
+ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
 EXPEDITE_CONF_OPTS += --with-x=$(STAGING_DIR) \
 	--x-includes=$(STAGING_DIR)/usr/include \
 	--x-libraries=$(STAGING_DIR)/usr/lib
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 26/36] package/efl/libethumb: remove package
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (24 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 25/36] package/expedite: bump to efl-1.15 branch Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:38   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 27/36] package/efl/libedje: " Romain Naour
                   ` (9 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

Libethumb is now available in efl package.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: remove libethumb from package/efl/
v3: update legacy option for 2015.11
    update help text
---
 Config.in.legacy                   |  7 +++++++
 package/efl/Config.in              |  1 -
 package/efl/libethumb/Config.in    | 15 ---------------
 package/efl/libethumb/libethumb.mk | 27 ---------------------------
 4 files changed, 7 insertions(+), 43 deletions(-)
 delete mode 100644 package/efl/libethumb/Config.in
 delete mode 100644 package/efl/libethumb/libethumb.mk

diff --git a/Config.in.legacy b/Config.in.legacy
index c5b8223..d35a241 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -107,6 +107,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2015.11"
 
+config BR2_PACKAGE_LIBETHUMB
+	bool "libethumb package has been removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_EFL
+	help
+	  The libethumb package has been removed with the efl bump to 1.15.
+
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_REAL
 	bool "gst1-plugins-bad real plugin has been removed"
 	select BR2_LEGACY
diff --git a/package/efl/Config.in b/package/efl/Config.in
index 2860cd6..0729e02 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -23,7 +23,6 @@ source "package/efl/libeio/Config.in"
 source "package/efl/libevas/Config.in"
 source "package/efl/libembryo/Config.in"
 source "package/efl/libedje/Config.in"
-source "package/efl/libethumb/Config.in"
 source "package/efl/libelementary/Config.in"
 source "package/efl/libedbus/Config.in"
 
diff --git a/package/efl/libethumb/Config.in b/package/efl/libethumb/Config.in
deleted file mode 100644
index 3e9cbde..0000000
--- a/package/efl/libethumb/Config.in
+++ /dev/null
@@ -1,15 +0,0 @@
-comment "libethumb needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
-
-config BR2_PACKAGE_LIBETHUMB
-	bool "libethumb"
-	select BR2_PACKAGE_LIBEINA
-	select BR2_PACKAGE_LIBEVAS
-	select BR2_PACKAGE_LIBECORE
-	select BR2_PACKAGE_LIBECORE_EVAS
-	select BR2_PACKAGE_LIBEDJE
-	depends on BR2_TOOLCHAIN_HAS_THREADS # libevas
-	help
-	  Ethumb is a library for generating thumbnail images of documents.
-
-	  http://trac.enlightenment.org/e/wiki/Ethumb
diff --git a/package/efl/libethumb/libethumb.mk b/package/efl/libethumb/libethumb.mk
deleted file mode 100644
index 314ddf9..0000000
--- a/package/efl/libethumb/libethumb.mk
+++ /dev/null
@@ -1,27 +0,0 @@
-################################################################################
-#
-# libethumb
-#
-################################################################################
-
-LIBETHUMB_VERSION = 1.7.10
-LIBETHUMB_SOURCE = ethumb-$(LIBETHUMB_VERSION).tar.bz2
-LIBETHUMB_SITE = http://download.enlightenment.org/releases
-LIBETHUMB_LICENSE = LGPLv2.1+
-LIBETHUMB_LICENSE_FILES = COPYING
-
-LIBETHUMB_INSTALL_STAGING = YES
-
-LIBETHUMB_DEPENDENCIES = libeina libevas libecore libedje host-libedje
-
-LIBETHUMB_CONF_OPTS = --with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc
-
-ifeq ($(BR2_PACKAGE_LIBEXIF),y)
-LIBETHUMB_DEPENDENCIES += libexif
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEDBUS),y)
-LIBETHUMB_DEPENDENCIES += libedbus
-endif
-
-$(eval $(autotools-package))
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 27/36] package/efl/libedje: remove package
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (25 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 26/36] package/efl/libethumb: remove package Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:41   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 28/36] package/efl/libembryo: " Romain Naour
                   ` (8 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

Libedje is now available in efl package.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: remove libedje directory
v4: update Config.in to use libefl
v3: update legacy option for 2015.11
    update help text
---
 Config.in.legacy               |  7 +++++++
 package/efl/Config.in          |  1 -
 package/efl/libedje/Config.in  | 28 ----------------------------
 package/efl/libedje/libedje.mk | 28 ----------------------------
 4 files changed, 7 insertions(+), 57 deletions(-)
 delete mode 100644 package/efl/libedje/Config.in
 delete mode 100644 package/efl/libedje/libedje.mk

diff --git a/Config.in.legacy b/Config.in.legacy
index d35a241..3349c50 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -107,6 +107,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2015.11"
 
+config BR2_PACKAGE_LIBEDJE
+	bool "libedje package has been removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_EFL
+	help
+	  The libedje package has been removed with the efl bump to 1.15.
+
 config BR2_PACKAGE_LIBETHUMB
 	bool "libethumb package has been removed"
 	select BR2_LEGACY
diff --git a/package/efl/Config.in b/package/efl/Config.in
index 0729e02..5a14192 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -22,7 +22,6 @@ source "package/efl/libefreet/Config.in"
 source "package/efl/libeio/Config.in"
 source "package/efl/libevas/Config.in"
 source "package/efl/libembryo/Config.in"
-source "package/efl/libedje/Config.in"
 source "package/efl/libelementary/Config.in"
 source "package/efl/libedbus/Config.in"
 
diff --git a/package/efl/libedje/Config.in b/package/efl/libedje/Config.in
deleted file mode 100644
index b163508..0000000
--- a/package/efl/libedje/Config.in
+++ /dev/null
@@ -1,28 +0,0 @@
-comment "libedje needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
-
-config BR2_PACKAGE_LIBEDJE
-	bool "libedje"
-	select BR2_PACKAGE_LIBEINA
-	select BR2_PACKAGE_LIBEET
-	select BR2_PACKAGE_LIBECORE
-	select BR2_PACKAGE_LIBECORE_EVAS
-	select BR2_PACKAGE_LIBEMBRYO
-	select BR2_PACKAGE_LIBEVAS
-	select BR2_PACKAGE_LUA
-	depends on BR2_TOOLCHAIN_HAS_THREADS # libevas
-	help
-	  A graphical layout and animation library for animated
-	  resizable, compressed and scalable themes.
-
-	  http://trac.enlightenment.org/e/wiki/Edje
-
-if BR2_PACKAGE_LIBEDJE
-
-config BR2_PACKAGE_LIBEDJE_CC
-	bool "build edje_cc"
-	help
-	  Build and install the Edje compiler for the target. Normally this
-	  is not required.
-
-endif
diff --git a/package/efl/libedje/libedje.mk b/package/efl/libedje/libedje.mk
deleted file mode 100644
index 59189e4..0000000
--- a/package/efl/libedje/libedje.mk
+++ /dev/null
@@ -1,28 +0,0 @@
-################################################################################
-#
-# libedje
-#
-################################################################################
-
-LIBEDJE_VERSION = 1.7.10
-LIBEDJE_SOURCE = edje-$(LIBEDJE_VERSION).tar.bz2
-LIBEDJE_SITE = http://download.enlightenment.org/releases
-LIBEDJE_LICENSE = GPLv2+ (epp binary), BSD-2c (everything else)
-LIBEDJE_LICENSE_FILES = COPYING
-
-LIBEDJE_INSTALL_STAGING = YES
-
-LIBEDJE_DEPENDENCIES = \
-	host-pkgconf lua libeina libeet libecore libevas \
-	libembryo
-
-ifeq ($(BR2_PACKAGE_LIBEDJE_CC),y)
-LIBEDJE_CONF_OPTS += --enable-edje-cc
-else
-LIBEDJE_CONF_OPTS += --disable-edje-cc
-endif
-
-HOST_LIBEDJE_CONF_OPTS = --enable-edje-cc
-
-$(eval $(autotools-package))
-$(eval $(host-autotools-package))
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 28/36] package/efl/libembryo: remove package
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (26 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 27/36] package/efl/libedje: " Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:43   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 29/36] package/efl/libeio: " Romain Naour
                   ` (7 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

Libembryo is now available in efl package.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: remove libembryo directory
v4: update Config.in to use libefl
v3: update legacy option for 2015.11
    update help text
---
 Config.in.legacy                   |  7 +++++++
 package/efl/Config.in              |  1 -
 package/efl/libembryo/Config.in    |  9 ---------
 package/efl/libembryo/libembryo.mk | 18 ------------------
 4 files changed, 7 insertions(+), 28 deletions(-)
 delete mode 100644 package/efl/libembryo/Config.in
 delete mode 100644 package/efl/libembryo/libembryo.mk

diff --git a/Config.in.legacy b/Config.in.legacy
index 3349c50..e7e49e3 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -107,6 +107,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2015.11"
 
+config BR2_PACKAGE_LIBEMBRYO
+	bool "libembryo package has been removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_EFL
+	help
+	  The libembryo package has been removed with the efl bump to 1.15.
+
 config BR2_PACKAGE_LIBEDJE
 	bool "libedje package has been removed"
 	select BR2_LEGACY
diff --git a/package/efl/Config.in b/package/efl/Config.in
index 5a14192..31dc066 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -21,7 +21,6 @@ source "package/efl/libefl/Config.in"
 source "package/efl/libefreet/Config.in"
 source "package/efl/libeio/Config.in"
 source "package/efl/libevas/Config.in"
-source "package/efl/libembryo/Config.in"
 source "package/efl/libelementary/Config.in"
 source "package/efl/libedbus/Config.in"
 
diff --git a/package/efl/libembryo/Config.in b/package/efl/libembryo/Config.in
deleted file mode 100644
index 63c7064..0000000
--- a/package/efl/libembryo/Config.in
+++ /dev/null
@@ -1,9 +0,0 @@
-config BR2_PACKAGE_LIBEMBRYO
-	bool "libembryo"
-	select BR2_PACKAGE_LIBEINA
-	help
-	  Embryo is primarily a shared library that gives you an API
-	  to load and control interpreted programs compiled into an
-	  abstract machine bytecode that it understands.
-
-	  http://trac.enlightenment.org/e/wiki/Embryo
diff --git a/package/efl/libembryo/libembryo.mk b/package/efl/libembryo/libembryo.mk
deleted file mode 100644
index fc45e42..0000000
--- a/package/efl/libembryo/libembryo.mk
+++ /dev/null
@@ -1,18 +0,0 @@
-################################################################################
-#
-# libembryo
-#
-################################################################################
-
-LIBEMBRYO_VERSION = 1.7.10
-LIBEMBRYO_SOURCE = embryo-$(LIBEMBRYO_VERSION).tar.bz2
-LIBEMBRYO_SITE = http://download.enlightenment.org/releases
-LIBEMBRYO_LICENSE = BSD-2c, Embryo license
-LIBEMBRYO_LICENSE_FILES = COPYING
-
-LIBEMBRYO_INSTALL_STAGING = YES
-
-LIBEMBRYO_DEPENDENCIES = host-pkgconf libeina
-
-$(eval $(autotools-package))
-$(eval $(host-autotools-package))
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 29/36] package/efl/libeio: remove package
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (27 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 28/36] package/efl/libembryo: " Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:44   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 30/36] package/efl/libefreet: " Romain Naour
                   ` (6 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

Libeio is now available in efl package.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: remove libeio directory
v4: update Config.in to use libefl
v3: update legacy option for 2015.11
    update help text
---
 Config.in.legacy             |  7 +++++++
 package/efl/Config.in        |  1 -
 package/efl/libeio/Config.in | 22 ----------------------
 package/efl/libeio/libeio.mk | 16 ----------------
 4 files changed, 7 insertions(+), 39 deletions(-)
 delete mode 100644 package/efl/libeio/Config.in
 delete mode 100644 package/efl/libeio/libeio.mk

diff --git a/Config.in.legacy b/Config.in.legacy
index e7e49e3..feda47b 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -107,6 +107,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2015.11"
 
+config BR2_PACKAGE_LIBEIO
+	bool "libeio package has been removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_EFL
+	help
+	  The libeio package has been removed with the efl bump to 1.15.
+
 config BR2_PACKAGE_LIBEMBRYO
 	bool "libembryo package has been removed"
 	select BR2_LEGACY
diff --git a/package/efl/Config.in b/package/efl/Config.in
index 31dc066..9d258eb 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -19,7 +19,6 @@ source "package/efl/libecore/Config.in"
 source "package/efl/libeet/Config.in"
 source "package/efl/libefl/Config.in"
 source "package/efl/libefreet/Config.in"
-source "package/efl/libeio/Config.in"
 source "package/efl/libevas/Config.in"
 source "package/efl/libelementary/Config.in"
 source "package/efl/libedbus/Config.in"
diff --git a/package/efl/libeio/Config.in b/package/efl/libeio/Config.in
deleted file mode 100644
index 5b1e395..0000000
--- a/package/efl/libeio/Config.in
+++ /dev/null
@@ -1,22 +0,0 @@
-config BR2_PACKAGE_LIBEIO
-	bool "libeio"
-	select BR2_PACKAGE_LIBEET
-	select BR2_PACKAGE_LIBEINA
-	select BR2_PACKAGE_LIBECORE
-	depends on BR2_TOOLCHAIN_HAS_THREADS
-	help
-	  Eio integrates with EFL (Ecore, Eina) to provide efficient
-	  filesystem Input/Output (I/O). It use the best techniques to
-	  achieve such purpose, like using at-variants, splice,
-	  properly handling errors and doing it in an asynchronous
-	  fashion by means of worker threads. It is also ported to
-	  Windows, so multi-platform.
-
-	  Whenever you need to list a directory, copy, move or delete
-	  files, Eio will do that task better than you'd achieve with
-	  naive implementations, and it is easy to use.
-
-	  http://trac.enlightenment.org/e/wiki/Eio
-
-comment "libeio needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/efl/libeio/libeio.mk b/package/efl/libeio/libeio.mk
deleted file mode 100644
index e687c32..0000000
--- a/package/efl/libeio/libeio.mk
+++ /dev/null
@@ -1,16 +0,0 @@
-################################################################################
-#
-# libeio
-#
-################################################################################
-
-LIBEIO_VERSION = 1.7.10
-LIBEIO_SOURCE = eio-$(LIBEIO_VERSION).tar.bz2
-LIBEIO_SITE = http://download.enlightenment.org/releases
-LIBEIO_LICENSE = LGPLv2.1
-LIBEIO_LICENSE_FILES = COPYING
-
-LIBEIO_INSTALL_STAGING = YES
-LIBEIO_DEPENDENCIES = libeina libeet libecore
-
-$(eval $(autotools-package))
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 30/36] package/efl/libefreet: remove package
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (28 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 29/36] package/efl/libeio: " Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:45   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 31/36] package/efl/libedbus: " Romain Naour
                   ` (5 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

Libefreet is now available in efl package.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: remove libefreet directory
v4: update Config.in to use libefl
v3: update legacy option for 2015.11
    update help text
---
 Config.in.legacy                   |  7 +++++++
 package/efl/Config.in              |  1 -
 package/efl/libefreet/Config.in    | 10 ----------
 package/efl/libefreet/libefreet.mk | 17 -----------------
 4 files changed, 7 insertions(+), 28 deletions(-)
 delete mode 100644 package/efl/libefreet/Config.in
 delete mode 100644 package/efl/libefreet/libefreet.mk

diff --git a/Config.in.legacy b/Config.in.legacy
index feda47b..e8b6579 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -107,6 +107,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2015.11"
 
+config BR2_PACKAGE_LIBEFREET
+	bool "libefreet package has been removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_EFL
+	help
+	  The libefreet package has been removed with the efl bump to 1.15.
+
 config BR2_PACKAGE_LIBEIO
 	bool "libeio package has been removed"
 	select BR2_LEGACY
diff --git a/package/efl/Config.in b/package/efl/Config.in
index 9d258eb..ba71705 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -18,7 +18,6 @@ source "package/efl/libeina/Config.in"
 source "package/efl/libecore/Config.in"
 source "package/efl/libeet/Config.in"
 source "package/efl/libefl/Config.in"
-source "package/efl/libefreet/Config.in"
 source "package/efl/libevas/Config.in"
 source "package/efl/libelementary/Config.in"
 source "package/efl/libedbus/Config.in"
diff --git a/package/efl/libefreet/Config.in b/package/efl/libefreet/Config.in
deleted file mode 100644
index 8687db4..0000000
--- a/package/efl/libefreet/Config.in
+++ /dev/null
@@ -1,10 +0,0 @@
-config BR2_PACKAGE_LIBEFREET
-	bool "libefreet"
-	select BR2_PACKAGE_LIBEINA
-	select BR2_PACKAGE_LIBEET
-	select BR2_PACKAGE_LIBECORE
-	help
-	  Efreet is a library designed to help apps work with several of the
-	  Freedesktop.org standards regarding Icons, Desktop files and Menus.
-
-	  http://trac.enlightenment.org/e/wiki/Efreet
diff --git a/package/efl/libefreet/libefreet.mk b/package/efl/libefreet/libefreet.mk
deleted file mode 100644
index 65dbd12..0000000
--- a/package/efl/libefreet/libefreet.mk
+++ /dev/null
@@ -1,17 +0,0 @@
-################################################################################
-#
-# libefreet
-#
-################################################################################
-
-LIBEFREET_VERSION = 1.7.10
-LIBEFREET_SOURCE = efreet-$(LIBEFREET_VERSION).tar.bz2
-LIBEFREET_SITE = http://download.enlightenment.org/releases
-LIBEFREET_LICENSE = BSD-2c
-LIBEFREET_LICENSE_FILES = COPYING
-
-LIBEFREET_INSTALL_STAGING = YES
-
-LIBEFREET_DEPENDENCIES = libeina libeet libecore
-
-$(eval $(autotools-package))
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 31/36] package/efl/libedbus: remove package
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (29 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 30/36] package/efl/libefreet: " Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:46   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 32/36] package/efl/libecore: " Romain Naour
                   ` (4 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

Libedbus is now available in efl package.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: remove libedbus directory
v3: update legacy option for 2015.11
    update help text
---
 Config.in.legacy                 |  7 +++++++
 package/efl/Config.in            |  1 -
 package/efl/libedbus/Config.in   | 44 ----------------------------------------
 package/efl/libedbus/libedbus.mk | 37 ---------------------------------
 4 files changed, 7 insertions(+), 82 deletions(-)
 delete mode 100644 package/efl/libedbus/Config.in
 delete mode 100644 package/efl/libedbus/libedbus.mk

diff --git a/Config.in.legacy b/Config.in.legacy
index e8b6579..bba5086 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -107,6 +107,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2015.11"
 
+config BR2_PACKAGE_LIBEDBUS
+	bool "libedbus package has been removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_EFL
+	help
+	  The libedbus package has been removed with the efl bump to 1.15.
+
 config BR2_PACKAGE_LIBEFREET
 	bool "libefreet package has been removed"
 	select BR2_LEGACY
diff --git a/package/efl/Config.in b/package/efl/Config.in
index ba71705..3092c8f 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -20,7 +20,6 @@ source "package/efl/libeet/Config.in"
 source "package/efl/libefl/Config.in"
 source "package/efl/libevas/Config.in"
 source "package/efl/libelementary/Config.in"
-source "package/efl/libedbus/Config.in"
 
 endif # BR2_PACKAGE_EFL
 
diff --git a/package/efl/libedbus/Config.in b/package/efl/libedbus/Config.in
deleted file mode 100644
index 7e862d3..0000000
--- a/package/efl/libedbus/Config.in
+++ /dev/null
@@ -1,44 +0,0 @@
-config BR2_PACKAGE_LIBEDBUS
-	bool "libedbus"
-	select BR2_PACKAGE_LIBEINA
-	select BR2_PACKAGE_LIBECORE
-	select BR2_PACKAGE_DBUS
-	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus
-	depends on BR2_USE_MMU # dbus
-	help
-	  E_Dbus is a set of wrappers around D-Bus APIs so they can be
-	  easily used by EFL applications, automatically providing
-	  Ecore/main loop integration, as well as Eina data types.
-
-	  http://trac.enlightenment.org/e/wiki/E_Dbus
-
-if BR2_PACKAGE_LIBEDBUS
-
-config BR2_PACKAGE_LIBEDBUS_BLUEZ
-	bool "bluez support"
-	depends on !BR2_STATIC_LIBS # bluez_utils
-	depends on BR2_USE_WCHAR # bluez_utils -> glib2
-	depends on BR2_TOOLCHAIN_HAS_THREADS # bluez_utils -> glib2
-	select BR2_PACKAGE_BLUEZ_UTILS
-	help
-	  Bluetooth support.
-
-comment "bluez support needs a toolchain w/ wchar, threads, dynamic library"
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
-
-config BR2_PACKAGE_LIBEDBUS_CONNMAN
-	bool "connman support"
-	depends on BR2_PACKAGE_CONNMAN
-	help
-	  Connection manager support.
-
-config BR2_PACKAGE_LIBEDBUS_NOTIFY
-	bool "notify support"
-	help
-	  Notify support.
-
-endif
-
-comment "libedbus needs a toolchain w/ threads"
-	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/efl/libedbus/libedbus.mk b/package/efl/libedbus/libedbus.mk
deleted file mode 100644
index 634ceaf..0000000
--- a/package/efl/libedbus/libedbus.mk
+++ /dev/null
@@ -1,37 +0,0 @@
-################################################################################
-#
-# libedbus
-#
-################################################################################
-
-LIBEDBUS_VERSION = 1.7.10
-LIBEDBUS_SOURCE = e_dbus-$(LIBEDBUS_VERSION).tar.bz2
-LIBEDBUS_SITE = http://download.enlightenment.org/releases
-LIBEDBUS_LICENSE = BSD-2c
-LIBEDBUS_LICENSE_FILES = COPYING
-
-LIBEDBUS_INSTALL_STAGING = YES
-
-LIBEDBUS_DEPENDENCIES = host-pkgconf dbus libeina libecore
-
-ifeq ($(BR2_PACKAGE_LIBEDBUS_BLUEZ),y)
-LIBEDBUS_CONF_OPTS += --enable-ebluez
-LIBEDBUS_DEPENDENCIES += bluez_utils
-else
-LIBEDBUS_CONF_OPTS += --disable-ebluez
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEDBUS_CONNMAN),y)
-LIBEDBUS_CONF_OPTS += --enable-econnman0_7x
-LIBEDBUS_DEPENDENCIES += connman
-else
-LIBEDBUS_CONF_OPTS += --disable-econnman0_7x
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEDBUS_NOTIFY),y)
-LIBEDBUS_CONF_OPTS += --enable-enotify --disable-edbus-notify-test
-else
-LIBEDBUS_CONF_OPTS += --disable-enotify
-endif
-
-$(eval $(autotools-package))
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 32/36] package/efl/libecore: remove package
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (30 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 31/36] package/efl/libedbus: " Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:50   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 33/36] package/efl/libevas: " Romain Naour
                   ` (3 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

Libecore is now available in efl package.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: remove libecore directory
v4: update Config.in to use libefl
v3: update legacy option for 2015.11
    update help text
---
 Config.in.legacy                 |   7 +++
 package/efl/Config.in            |   1 -
 package/efl/libecore/Config.in   |  46 ----------------
 package/efl/libecore/libecore.mk | 114 ---------------------------------------
 4 files changed, 7 insertions(+), 161 deletions(-)
 delete mode 100644 package/efl/libecore/Config.in
 delete mode 100644 package/efl/libecore/libecore.mk

diff --git a/Config.in.legacy b/Config.in.legacy
index bba5086..6c72a54 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -107,6 +107,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2015.11"
 
+config BR2_PACKAGE_LIBECORE
+	bool "libecore package has been removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_EFL
+	help
+	  The libecore package has been removed with the efl bump to 1.15.
+
 config BR2_PACKAGE_LIBEDBUS
 	bool "libedbus package has been removed"
 	select BR2_LEGACY
diff --git a/package/efl/Config.in b/package/efl/Config.in
index 3092c8f..7bd73dc 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -15,7 +15,6 @@ menuconfig BR2_PACKAGE_EFL
 if BR2_PACKAGE_EFL
 
 source "package/efl/libeina/Config.in"
-source "package/efl/libecore/Config.in"
 source "package/efl/libeet/Config.in"
 source "package/efl/libefl/Config.in"
 source "package/efl/libevas/Config.in"
diff --git a/package/efl/libecore/Config.in b/package/efl/libecore/Config.in
deleted file mode 100644
index a9408dc..0000000
--- a/package/efl/libecore/Config.in
+++ /dev/null
@@ -1,46 +0,0 @@
-config BR2_PACKAGE_LIBECORE
-	bool "libecore"
-	select BR2_PACKAGE_LIBEINA
-	help
-	  Ecore is the event/X abstraction layer that makes doing
-	  selections, Xdnd, general X stuff, event loops, timeouts and
-	  idle handlers fast, optimized, and convenient.
-
-	  http://trac.enlightenment.org/e/wiki/Ecore
-
-if BR2_PACKAGE_LIBECORE
-
-config BR2_PACKAGE_LIBECORE_DIRECTFB
-	bool "libecore DirectFB support"
-	depends on BR2_PACKAGE_DIRECTFB
-	default y
-
-config BR2_PACKAGE_LIBECORE_FB
-	bool "libecore framebuffer support"
-
-config BR2_PACKAGE_LIBECORE_SDL
-	bool "libecore SDL support"
-	select BR2_PACKAGE_SDL
-
-config BR2_PACKAGE_LIBECORE_X
-	bool "libecore X support"
-	depends on BR2_PACKAGE_XORG7
-	select BR2_PACKAGE_XLIB_LIBX11
-	select BR2_PACKAGE_XLIB_LIBXEXT
-
-config BR2_PACKAGE_LIBECORE_X_XCB
-	bool "libecore XCB support"
-	depends on BR2_PACKAGE_XORG7
-	select BR2_PACKAGE_LIBXCB
-	select BR2_PACKAGE_XLIB_LIBX11
-	select BR2_PACKAGE_XCB_UTIL
-
-config BR2_PACKAGE_LIBECORE_EVAS
-	bool "libecore Evas support"
-	select BR2_PACKAGE_LIBEVAS
-	depends on BR2_TOOLCHAIN_HAS_THREADS
-
-comment "evas support needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
-
-endif # BR2_PACKAGE_LIBECORE
diff --git a/package/efl/libecore/libecore.mk b/package/efl/libecore/libecore.mk
deleted file mode 100644
index b5016dc..0000000
--- a/package/efl/libecore/libecore.mk
+++ /dev/null
@@ -1,114 +0,0 @@
-################################################################################
-#
-# libecore
-#
-################################################################################
-
-LIBECORE_VERSION = 1.7.10
-LIBECORE_SOURCE = ecore-$(LIBECORE_VERSION).tar.bz2
-LIBECORE_SITE = http://download.enlightenment.org/releases
-LIBECORE_LICENSE = BSD-2c
-LIBECORE_LICENSE_FILES = COPYING
-
-LIBECORE_INSTALL_STAGING = YES
-
-LIBECORE_DEPENDENCIES = host-pkgconf libeina
-
-HOST_LIBECORE_DEPENDENCIES = host-pkgconf host-libeina host-libevas
-HOST_LIBECORE_CONF_OPTS += 		\
-	--enable-ecore-evas 		\
-	--disable-simple-x11 		\
-	--disable-ecore-directfb 	\
-	--disable-ecore-x 		\
-	--disable-ecore-x-xcb 		\
-	--disable-ecore-imf-xim
-
-# default options
-LIBECORE_CONF_OPTS = --disable-simple-x11
-
-ifeq ($(BR2_PACKAGE_TSLIB),y)
-LIBECORE_DEPENDENCIES += tslib
-endif
-
-ifeq ($(BR2_PACKAGE_LIBGLIB2),y)
-LIBECORE_DEPENDENCIES += libglib2
-endif
-
-ifeq ($(BR2_PACKAGE_OPENSSL),y)
-LIBECORE_DEPENDENCIES += openssl
-LIBECORE_CONF_OPTS += --enable-openssl
-else
-LIBECORE_CONF_OPTS += --disable-openssl
-endif
-
-ifeq ($(BR2_PACKAGE_GNUTLS)$(BR2_PACKAGE_LIBGCRYPT),yy)
-LIBECORE_DEPENDENCIES += gnutls libgcrypt
-LIBECORE_CONF_OPTS += --enable-gnutls --with-libgcrypt-prefix=$(STAGING_DIR)/usr
-else
-LIBECORE_CONF_OPTS += --disable-gnutls
-endif
-
-ifeq ($(BR2_PACKAGE_LIBCURL),y)
-LIBECORE_DEPENDENCIES += libcurl
-endif
-
-# libecore
-ifeq ($(BR2_PACKAGE_LIBECORE_DIRECTFB),y)
-LIBECORE_CONF_OPTS += --enable-ecore-directfb
-LIBECORE_DEPENDENCIES += directfb
-else
-LIBECORE_CONF_OPTS += --disable-ecore-directfb
-endif
-
-ifeq ($(BR2_PACKAGE_LIBECORE_FB),y)
-LIBECORE_CONF_OPTS += --enable-ecore-fb
-else
-LIBECORE_CONF_OPTS += --disable-ecore-fb
-endif
-
-ifeq ($(BR2_PACKAGE_LIBECORE_SDL),y)
-LIBECORE_CONF_OPTS += --enable-ecore-sdl
-LIBECORE_DEPENDENCIES += sdl
-else
-LIBECORE_CONF_OPTS += --disable-ecore-sdl
-endif
-
-ifeq ($(BR2_PACKAGE_LIBECORE_X),y)
-LIBECORE_CONF_OPTS += --enable-ecore-x \
-	--with-x=$(STAGING_DIR) \
-	--x-includes=$(STAGING_DIR)/usr/include \
-	--x-libraries=$(STAGING_DIR)/usr/lib
-LIBECORE_DEPENDENCIES += xlib_libXext xlib_libX11
-else
-LIBECORE_CONF_OPTS += --disable-ecore-x --disable-ecore-imf-xim
-endif
-
-ifeq ($(BR2_PACKAGE_LIBECORE_X_XCB),y)
-LIBECORE_CONF_OPTS += --enable-ecore-x-xcb
-LIBECORE_DEPENDENCIES += libxcb xlib_libX11 xcb-util pixman
-
-# src/util/makekeys is executed at build time to generate
-# ecore_xcb_keysym_table.h, so it should get compiled for the host.
-# The ecore makefile unfortunately doesn't know about cross
-# compilation so this doesn't work.  Long term, we should probably
-# teach it about CC_FOR_BUILD, but for now simply build makekeys by
-# hand in advance
-define LIBECORE_BUILD_MAKEKEYS_FOR_HOST
-	$(HOST_CONFIGURE_OPTS) $(MAKE1) -C $(@D)/src/util makekeys.o makekeys
-endef
-
-LIBECORE_POST_EXTRACT_HOOKS += LIBECORE_BUILD_MAKEKEYS_FOR_HOST
-else
-LIBECORE_CONF_OPTS += --disable-ecore-x-xcb
-endif
-
-# libecore-evas
-ifeq ($(BR2_PACKAGE_LIBECORE_EVAS),y)
-LIBECORE_CONF_OPTS += --enable-ecore-evas
-LIBECORE_DEPENDENCIES += libevas
-else
-LIBECORE_CONF_OPTS += --disable-ecore-evas
-endif
-
-$(eval $(autotools-package))
-$(eval $(host-autotools-package))
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 33/36] package/efl/libevas: remove package
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (31 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 32/36] package/efl/libecore: " Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:52   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 34/36] package/efl/libeet: " Romain Naour
                   ` (2 subsequent siblings)
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

Libevas is now available in efl package.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: remove libevas directory
v4: update Config.in to use libefl
v3: update legacy option for 2015.11
    update help text
---
 Config.in.legacy                      |   7 +
 package/efl/Config.in                 |   1 -
 package/efl/libevas/0001-giflib.patch |  98 --------------
 package/efl/libevas/Config.in         | 211 -----------------------------
 package/efl/libevas/libevas.mk        | 247 ----------------------------------
 5 files changed, 7 insertions(+), 557 deletions(-)
 delete mode 100644 package/efl/libevas/0001-giflib.patch
 delete mode 100644 package/efl/libevas/Config.in
 delete mode 100644 package/efl/libevas/libevas.mk

diff --git a/Config.in.legacy b/Config.in.legacy
index 6c72a54..cb49112 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -107,6 +107,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2015.11"
 
+config BR2_PACKAGE_LIBEVAS
+	bool "libevas package has been removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_EFL
+	help
+	  The libevas package has been removed with the efl bump to 1.15.
+
 config BR2_PACKAGE_LIBECORE
 	bool "libecore package has been removed"
 	select BR2_LEGACY
diff --git a/package/efl/Config.in b/package/efl/Config.in
index 7bd73dc..b35e666 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -17,7 +17,6 @@ if BR2_PACKAGE_EFL
 source "package/efl/libeina/Config.in"
 source "package/efl/libeet/Config.in"
 source "package/efl/libefl/Config.in"
-source "package/efl/libevas/Config.in"
 source "package/efl/libelementary/Config.in"
 
 endif # BR2_PACKAGE_EFL
diff --git a/package/efl/libevas/0001-giflib.patch b/package/efl/libevas/0001-giflib.patch
deleted file mode 100644
index 9342687..0000000
--- a/package/efl/libevas/0001-giflib.patch
+++ /dev/null
@@ -1,98 +0,0 @@
-Adjust source code to work with giflib 5.1x
-
-From http://giflib.sourceforge.net/gif_lib.html: GIF file openers and
-closers - DGifOpenFileName(), DGifOpenFileHandle(), DGifOpen(),
-DGifClose(), EGifOpenFileName(), EGifOpenFileHandle(), EGifOpen(), and
-EGifClose() - all now take a final integer address argument. If
-non-null, this is used to pass back an error code when the function
-returns NULL.
-
-Downloaded from
-http://commit.cvs.pld.groups.com.ru/332837-packagesevas_fix_building_with_giflib_51_rel_6
-
-Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
-
-diff -uNr evas-1.7.10.org/src/modules/loaders/gif/evas_image_load_gif.c evas-1.7.10/src/modules/loaders/gif/evas_image_load_gif.c
---- evas-1.7.10.org/src/modules/loaders/gif/evas_image_load_gif.c	2013-08-01 17:41:35.000000000 +0200
-+++ evas-1.7.10/src/modules/loaders/gif/evas_image_load_gif.c	2015-01-26 19:44:20.132955194 +0100
-@@ -338,7 +338,7 @@
- 
-    if (!cmap)
-      {
--        DGifCloseFile(gif);
-+        DGifCloseFile(gif, NULL);
-         for (i = 0; i < scale_h; i++)
-           {
-              free(rows[i]);
-@@ -725,7 +725,7 @@
-    if ((w < 1) || (h < 1) || (w > IMG_MAX_SIZE) || (h > IMG_MAX_SIZE) ||
-        IMG_TOO_BIG(w, h))
-      {
--        DGifCloseFile(gif);
-+        DGifCloseFile(gif, NULL);
-         if (IMG_TOO_BIG(w, h))
-           *error = EVAS_LOAD_ERROR_RESOURCE_ALLOCATION_FAILED;
-         else
-@@ -740,7 +740,7 @@
-         if (DGifGetRecordType(gif, &rec) == GIF_ERROR)
-           {
-              /* PrintGifError(); */
--             DGifCloseFile(gif);
-+             DGifCloseFile(gif, NULL);
-              *error = EVAS_LOAD_ERROR_UNKNOWN_FORMAT;
-              return EINA_FALSE;
-           }
-@@ -754,7 +754,7 @@
-              if (DGifGetImageDesc(gif) == GIF_ERROR)
-                {
-                   /* PrintGifError(); */
--                  DGifCloseFile(gif);
-+                  DGifCloseFile(gif, NULL);
-                   *error = EVAS_LOAD_ERROR_UNKNOWN_FORMAT;
-                   return EINA_FALSE;
-                }
-@@ -762,7 +762,7 @@
-              if (DGifGetCode(gif, &img_code, &img) == GIF_ERROR)
-                {
-                   /* PrintGifError(); */
--                  DGifCloseFile(gif);
-+                  DGifCloseFile(gif, NULL);
-                   *error = EVAS_LOAD_ERROR_UNKNOWN_FORMAT;
-                   return EINA_FALSE;
-                }
-@@ -818,7 +818,7 @@
-         ie->frames = NULL;
-      }
- 
--   DGifCloseFile(gif);
-+   DGifCloseFile(gif, NULL);
-    *error = EVAS_LOAD_ERROR_NONE;
-    return EINA_TRUE;
- }
-@@ -885,7 +885,7 @@
-      }
- 
-    ie->frames = eina_list_append(ie->frames, frame);
--   DGifCloseFile(gif);
-+   DGifCloseFile(gif, NULL);
-    return EINA_TRUE;
- }
- 
-@@ -959,7 +959,7 @@
-                   *error = EVAS_LOAD_ERROR_UNKNOWN_FORMAT;
-                   return EINA_FALSE;
-                }
--             DGifCloseFile(gif);
-+             DGifCloseFile(gif, NULL);
-              *error = EVAS_LOAD_ERROR_NONE;
-              return EINA_TRUE;
-           }
-@@ -1080,7 +1080,7 @@
-          }
-      } while (rec != TERMINATE_RECORD_TYPE);
- 
--   DGifCloseFile(gif);
-+   DGifCloseFile(gif, NULL);
-    return duration;
- }
- 
diff --git a/package/efl/libevas/Config.in b/package/efl/libevas/Config.in
deleted file mode 100644
index 6645a14..0000000
--- a/package/efl/libevas/Config.in
+++ /dev/null
@@ -1,211 +0,0 @@
-comment "libevas needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
-
-config BR2_PACKAGE_LIBEVAS
-	bool "libevas"
-	# libevas should normally build without threads, but due to a
-	# build issue when the async preloader is disabled, which is
-	# needed when no threads are available, we don't allow evas to
-	# be built without threads. This should be revisited when efl
-	# is bumped to 1.8.
-	depends on BR2_TOOLCHAIN_HAS_THREADS
-	select BR2_PACKAGE_FREETYPE
-	select BR2_PACKAGE_LIBEINA
-	# required to build so far
-	select BR2_PACKAGE_LIBEVAS_SCALE_SMOOTH
-	help
-	  Evas is a clean display canvas API for several target
-	  display systems that can draw anti-aliased text, smooth
-	  super and sub-sampled scaled images, alpha-blend objects
-	  much and more.
-
-	  http://trac.enlightenment.org/e/wiki/Evas
-
-if BR2_PACKAGE_LIBEVAS
-
-comment "libevas rendering options"
-
-config BR2_PACKAGE_LIBEVAS_SCALE_SAMPLE
-	bool "libevas sampling scaler"
-	help
-	  This enables the sampling scaler code. This is the fastest
-	  image scaling code, but also the lowest quality.
-
-config BR2_PACKAGE_LIBEVAS_SCALE_SMOOTH
-	bool "libevas smooth scaler"
-	help
-	  This is the nicest looking scaler that is not that much
-	  slower than tri-linear, but it looks really good.
-
-config BR2_PACKAGE_LIBEVAS_SMALL_DITHERING
-	bool "libevas small dithering"
-	help
-	  This uses a 4x4 dither mask instead of 128x128. On desktop
-	  boxes these days (Pentium, Pentium2, amd etc.) the speed
-	  difference is not really measurable, but the quality of the
-	  128x128 dither mask is quite a lot better.
-
-config BR2_PACKAGE_LIBEVAS_LINE_DITHERING
-	bool "libevas line dithering"
-
-config BR2_PACKAGE_LIBEVAS_NO_DITHERING
-	bool "libevas no dithering"
-
-
-comment "libevas backends"
-
-config BR2_PACKAGE_LIBEVAS_BUFFER
-	bool "libevas buffer backend"
-	help
-	  This enables the software buffer rendering engine. There is
-	  no hardware assist here.
-
-config BR2_PACKAGE_LIBEVAS_DIRECTFB
-	bool "libevas DirectFB backend"
-	depends on BR2_PACKAGE_DIRECTFB
-	default y
-	help
-	  This is the DirectFB engine that uses the DirectFB library
-	  (http://www.directfb.org) on Linux to access the framebuffer
-	  with (or maybe without) acceleration.
-
-config BR2_PACKAGE_LIBEVAS_FB
-	bool "libevas frame buffer backend"
-	help
-	  This is the software framebuffer driving engine. this uses
-	  the linux framebuffer device (/dev/fb<x>) and will currently
-	  just inherit the current framebuffer settings on the fb
-	  device and use them to run in.
-
-config BR2_PACKAGE_LIBEVAS_SDL
-	bool "libevas SDL backend"
-	select BR2_PACKAGE_SDL
-	help
-	  This is the software SDL engine that uses SDL library
-	  (http://www.libsdl.org). This library should work on many
-	  operating systems.
-
-config BR2_PACKAGE_LIBEVAS_SDL_GL
-	bool "libevas SDL OpenGL backend"
-	depends on BR2_PACKAGE_SDL_X11
-	depends on BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR # mesa needs big X
-	help
-	  This is the SDL OpenGL engine that uses SDL library
-	  and OpenGL to render. This may be hardware accelerated.
-
-comment "SDL OpenGL backend needs modular X.org and X11 support in SDL"
-	depends on !(BR2_PACKAGE_SDL_X11 && BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR)
-
-config BR2_PACKAGE_LIBEVAS_X11
-	bool "libevas X11 backend"
-	depends on BR2_PACKAGE_XORG7
-	select BR2_PACKAGE_XLIB_LIBX11
-	select BR2_PACKAGE_XLIB_LIBXEXT
-	help
-	  This enables the software X11 rendering engine that renders
-	  to X drawable targets using highly optimised software
-	  routines. There is no hardware assist here.
-
-config BR2_PACKAGE_LIBEVAS_X11_GLX
-	bool "libevas X11 GLX backend"
-	depends on BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR # mesa needs big X
-	select BR2_PACKAGE_XLIB_LIBX11
-	select BR2_PACKAGE_XLIB_LIBXRENDER
-	select BR2_PACKAGE_XLIB_LIBXEXT
-	select BR2_PACKAGE_XPROTO_GLPROTO
-	help
-	  This enables the OpenGL X11 rendering engine that renders
-	  using GLX which may be hardware accelerated.
-
-config BR2_PACKAGE_LIBEVAS_XCB
-	bool "libevas XCB backend"
-	depends on BR2_PACKAGE_XORG7
-	select BR2_PACKAGE_LIBXCB
-	select BR2_PACKAGE_XCB_UTIL
-	select BR2_PACKAGE_XCB_PROTO
-	select BR2_PACKAGE_PIXMAN
-	help
-	  This enable the software XCB rendering engine. It allows the
-	  same features than the software X11 engine.
-
-config BR2_PACKAGE_LIBEVAS_XCB_GLX
-	bool "libevas XCB GLX backend"
-	depends on BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR # mesa needs big X
-	select BR2_PACKAGE_LIBXCB
-	select BR2_PACKAGE_XCB_UTIL
-	select BR2_PACKAGE_XCB_PROTO
-	select BR2_PACKAGE_XPROTO_GLPROTO
-	help
-	  This enables the OpenGL X11 XCB rendering engine that renders
-	  using GLX which may be hardware accelerated.
-
-choice
-	prompt "libevas OpenGL flavor"
-	depends on BR2_PACKAGE_LIBEVAS_SDL_GL || BR2_PACKAGE_LIBEVAS_X11_GLX || BR2_PACKAGE_LIBEVAS_XCB_GLX
-	default BR2_PACKAGE_LIBEVAS_GL
-
-config BR2_PACKAGE_LIBEVAS_GL
-	bool "generic OpenGL"
-	depends on BR2_PACKAGE_HAS_LIBGL
-	select BR2_PACKAGE_LIBEET
-
-config BR2_PACKAGE_LIBEVAS_GLES_SGX
-	bool "OpenGL-ES SGX"
-
-config BR2_PACKAGE_LIBEVAS_GLES_S3C6410
-	bool "OpenGL-ES S3C6410"
-endchoice
-
-
-comment "libevas loaders"
-
-config BR2_PACKAGE_LIBEVAS_PNG
-	bool "libevas png loader"
-	select BR2_PACKAGE_LIBPNG
-	help
-	  This enables the loader code that loads png files using
-	  libpng.
-
-config BR2_PACKAGE_LIBEVAS_JPEG
-	bool "libevas jpeg loader"
-	select BR2_PACKAGE_JPEG
-	help
-	  This enables the loader code that loads jpeg files using
-	  libjpeg.
-
-config BR2_PACKAGE_LIBEVAS_GIF
-	bool "libevas gif loader"
-	select BR2_PACKAGE_GIFLIB
-	help
-	  This enables the loader code that loads gif files using
-	  libungif.
-
-config BR2_PACKAGE_LIBEVAS_PMAPS
-	bool "libevas pmaps loader"
-	help
-	  This enables the loader code that loads pmaps files.
-
-config BR2_PACKAGE_LIBEVAS_TIFF
-	bool "libevas tiff loader"
-	select BR2_PACKAGE_TIFF
-	help
-	  This enables the loader code that loads tiff files.
-
-config BR2_PACKAGE_LIBEVAS_XPM
-	bool "libevas xpm loader"
-	help
-	  This enables the loader code that loads xpm files.
-
-config BR2_PACKAGE_LIBEVAS_EET
-	bool "libevas eet image loader"
-	select BR2_PACKAGE_LIBEET
-	help
-	  This enables the loader code that loads images using libeet.
-
-config BR2_PACKAGE_LIBEVAS_EET_FONT
-	bool "libevas eet font loader"
-	select BR2_PACKAGE_LIBEET
-	help
-	  This enables the loader code that loads fonts using libeet.
-
-endif # BR2_PACKAGE_LIBEVAS
diff --git a/package/efl/libevas/libevas.mk b/package/efl/libevas/libevas.mk
deleted file mode 100644
index 9adb128..0000000
--- a/package/efl/libevas/libevas.mk
+++ /dev/null
@@ -1,247 +0,0 @@
-################################################################################
-#
-# libevas
-#
-################################################################################
-
-LIBEVAS_VERSION = 1.7.10
-LIBEVAS_SOURCE = evas-$(LIBEVAS_VERSION).tar.bz2
-LIBEVAS_SITE = http://download.enlightenment.org/releases
-LIBEVAS_LICENSE = BSD-2c
-LIBEVAS_LICENSE_FILES = COPYING
-
-LIBEVAS_INSTALL_STAGING = YES
-
-LIBEVAS_DEPENDENCIES = host-pkgconf zlib libeina freetype
-
-HOST_LIBEVAS_DEPENDENCIES = \
-	host-pkgconf host-zlib host-libeina \
-	host-freetype host-libpng host-libjpeg
-HOST_LIBEVAS_CONF_OPTS += \
-	--enable-image-loader-png \
-	--enable-image-loader-jpeg \
-	--disable-image-loader-gif \
-	--disable-image-loader-tiff \
-	--disable-image-loader-eet \
-	--disable-font-loader-eet \
-	--disable-cpu-sse3 \
-	--disable-software-sdl \
-	--disable-gl-sdl \
-	--disable-software-xlib \
-	--disable-gl-xlib \
-	--enable-software-xcb \
-	--disable-gl-xcb
-
-# rendering options
-ifeq ($(BR2_PACKAGE_LIBEVAS_SCALE_SAMPLE),y)
-LIBEVAS_CONF_OPTS += --enable-scale-sample
-else
-LIBEVAS_CONF_OPTS += --disable-scale-sample
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_SCALE_SMOOTH),y)
-LIBEVAS_CONF_OPTS += --enable-scale-smooth
-else
-LIBEVAS_CONF_OPTS += --disable-scale-smooth
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_SMALL_DITHERING),y)
-LIBEVAS_CONF_OPTS += --enable-small-dither-mask
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_LINE_DITHERING),y)
-LIBEVAS_CONF_OPTS += --enable-line-dither-mask
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_NO_DITHERING),y)
-LIBEVAS_CONF_OPTS += --enable-no-dither-mask
-endif
-
-# backends
-ifeq ($(BR2_PACKAGE_LIBEVAS_BUFFER),y)
-LIBEVAS_CONF_OPTS += --enable-buffer
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_X11),y)
-LIBEVAS_CONF_OPTS += --enable-software-xlib \
-	--with-x=$(STAGING_DIR) \
-	--x-includes=$(STAGING_DIR)/usr/include \
-	--x-libraries=$(STAGING_DIR)/usr/lib
-LIBEVAS_DEPENDENCIES += xlib_libX11 xlib_libXext
-else
-LIBEVAS_CONF_OPTS += --disable-software-xlib
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_X11_GLX),y)
-LIBEVAS_CONF_OPTS += --enable-gl-xlib
-LIBEVAS_DEPENDENCIES += \
-	xproto_glproto xlib_libX11 xlib_libXrender \
-	xlib_libXext libeet
-else
-LIBEVAS_CONF_OPTS += --disable-gl-xlib
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_XCB),y)
-LIBEVAS_CONF_OPTS += --enable-software-xcb
-LIBEVAS_DEPENDENCIES += libxcb xcb-proto xcb-util pixman
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_XCB_GLX),y)
-LIBEVAS_CONF_OPTS += --enable-gl-xcb
-LIBEVAS_DEPENDENCIES += libxcb xcb-proto xcb-util xproto_glproto
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_FB),y)
-LIBEVAS_CONF_OPTS += --enable-fb
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_DIRECTFB),y)
-LIBEVAS_CONF_OPTS += --enable-directfb
-LIBEVAS_DEPENDENCIES += directfb
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_SDL),y)
-LIBEVAS_CONF_OPTS += --enable-software-sdl
-LIBEVAS_DEPENDENCIES += sdl
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_SDL_GL),y)
-LIBEVAS_CONF_OPTS += --enable-gl-sdl
-LIBEVAS_DEPENDENCIES += sdl
-# configure script forgets to check for eet / fill this out
-LIBEVAS_CONF_ENV += \
-	GL_EET_CFLAGS='-I$(STAGING_DIR)/usr/include/eet-1' \
-	GL_EET_LIBS='-leet'
-endif
-
-# libevas OpenGL flavor
-ifeq ($(BR2_PACKAGE_LIBEVAS_GL),y)
-LIBEVAS_DEPENDENCIES += mesa3d libeet
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_GLES_SGX),y)
-LIBEVAS_CONF_OPTS += --enable-gl-flavor-gles --enable-gles-variety-sgx
-else
-LIBEVAS_CONF_OPTS += --disable-gles-variety-sgx
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_GLES_S3C6410),y)
-LIBEVAS_CONF_OPTS += --enable-gl-flavor-gles --enable-gles-variety-s3c6410
-else
-LIBEVAS_CONF_OPTS += --disable-gles-variety-s3c6410
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_GLES_SGX)$(BR2_PACKAGE_LIBEVAS_GLES_S3C6410),)
-LIBEVAS_CONF_OPTS += --disable-gl-flavor-gles
-endif
-
-# code options
-ifeq ($(BR2_X86_CPU_HAS_MMX),y)
-LIBEVAS_CONF_OPTS += --enable-cpu-mmx
-else
-LIBEVAS_CONF_OPTS += --disable-cpu-mmx
-endif
-
-ifeq ($(BR2_X86_CPU_HAS_SSE),y)
-LIBEVAS_CONF_OPTS += --enable-cpu-sse
-else
-LIBEVAS_CONF_OPTS += --disable-cpu-sse
-endif
-
-ifeq ($(BR2_X86_CPU_HAS_SSE3),y)
-LIBEVAS_CONF_OPTS += --enable-cpu-sse3
-else
-LIBEVAS_CONF_OPTS += --disable-cpu-sse3
-endif
-
-ifeq ($(BR2_POWERPC_CPU_HAS_ALTIVEC),y)
-LIBEVAS_CONF_OPTS += --enable-cpu-altivec
-else
-LIBEVAS_CONF_OPTS += --disable-cpu-altivec
-endif
-
-ifeq ($(BR2_ARM_CPU_HAS_NEON),y)
-LIBEVAS_CONF_OPTS += --enable-cpu-neon
-else
-LIBEVAS_CONF_OPTS += --disable-cpu-neon
-endif
-
-# loaders
-ifeq ($(BR2_PACKAGE_LIBEVAS_PNG),y)
-LIBEVAS_CONF_OPTS += --enable-image-loader-png
-LIBEVAS_DEPENDENCIES += libpng
-else
-LIBEVAS_CONF_OPTS += --disable-image-loader-png
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_JPEG),y)
-LIBEVAS_CONF_OPTS += --enable-image-loader-jpeg
-LIBEVAS_DEPENDENCIES += jpeg
-else
-LIBEVAS_CONF_OPTS += --disable-image-loader-jpeg
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_GIF),y)
-LIBEVAS_CONF_OPTS += --enable-image-loader-gif
-LIBEVAS_DEPENDENCIES += giflib
-else
-LIBEVAS_CONF_OPTS += --disable-image-loader-gif
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_PMAPS),y)
-LIBEVAS_CONF_OPTS += --enable-image-loader-pmaps
-else
-LIBEVAS_CONF_OPTS += --disable-image-loader-pmaps
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_TIFF),y)
-LIBEVAS_CONF_OPTS += --enable-image-loader-tiff
-LIBEVAS_DEPENDENCIES += tiff
-else
-LIBEVAS_CONF_OPTS += --disable-image-loader-tiff
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_XPM),y)
-LIBEVAS_CONF_OPTS += --enable-image-loader-xpm
-else
-LIBEVAS_CONF_OPTS += --disable-image-loader-xpm
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_EET),y)
-LIBEVAS_CONF_OPTS += --enable-image-loader-eet
-LIBEVAS_DEPENDENCIES += libeet
-else
-LIBEVAS_CONF_OPTS += --disable-image-loader-eet
-endif
-
-ifeq ($(BR2_PACKAGE_LIBEVAS_EET_FONT),y)
-LIBEVAS_CONF_OPTS += --enable-font-loader-eet
-LIBEVAS_DEPENDENCIES += libeet
-else
-LIBEVAS_CONF_OPTS += --disable-font-loader-eet
-endif
-
-ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
-LIBEVAS_CONF_OPTS += --enable-fontconfig
-LIBEVAS_DEPENDENCIES += fontconfig
-else
-LIBEVAS_CONF_OPTS += --disable-fontconfig
-endif
-
-ifeq ($(BR2_PACKAGE_LIBFRIBIDI),y)
-LIBEVAS_CONF_OPTS += --enable-fribidi
-LIBEVAS_DEPENDENCIES += libfribidi
-else
-LIBEVAS_CONF_OPTS += --disable-fribidi
-endif
-
-# libevas installs the source code of examples on the target, which
-# are generally not useful.
-define LIBEVAS_REMOVE_EXAMPLES
-	rm -rf $(TARGET_DIR)/usr/share/evas/examples/
-endef
-
-LIBEVAS_POST_INSTALL_TARGET_HOOKS += LIBEVAS_REMOVE_EXAMPLES
-
-$(eval $(autotools-package))
-$(eval $(host-autotools-package))
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 34/36] package/efl/libeet: remove package
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (32 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 33/36] package/efl/libevas: " Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:52   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 35/36] package/efl/libeina: " Romain Naour
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 36/36] package/libemotion-generic-players: new package Romain Naour
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

Libeet is now available in efl package.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: remove libeet directory
v4: update Config.in to use libefl
v3: update legacy option for 2015.11
    update help text
---
 Config.in.legacy             |  7 +++++++
 package/efl/Config.in        |  1 -
 package/efl/libeet/Config.in | 11 -----------
 package/efl/libeet/libeet.mk | 27 ---------------------------
 4 files changed, 7 insertions(+), 39 deletions(-)
 delete mode 100644 package/efl/libeet/Config.in
 delete mode 100644 package/efl/libeet/libeet.mk

diff --git a/Config.in.legacy b/Config.in.legacy
index cb49112..14da2f2 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -107,6 +107,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2015.11"
 
+config BR2_PACKAGE_LIBEET
+	bool "libeet package has been removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_EFL
+	help
+	  The libeet package has been removed with the efl bump to 1.15.
+
 config BR2_PACKAGE_LIBEVAS
 	bool "libevas package has been removed"
 	select BR2_LEGACY
diff --git a/package/efl/Config.in b/package/efl/Config.in
index b35e666..9e92a6e 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -15,7 +15,6 @@ menuconfig BR2_PACKAGE_EFL
 if BR2_PACKAGE_EFL
 
 source "package/efl/libeina/Config.in"
-source "package/efl/libeet/Config.in"
 source "package/efl/libefl/Config.in"
 source "package/efl/libelementary/Config.in"
 
diff --git a/package/efl/libeet/Config.in b/package/efl/libeet/Config.in
deleted file mode 100644
index 48631a0..0000000
--- a/package/efl/libeet/Config.in
+++ /dev/null
@@ -1,11 +0,0 @@
-config BR2_PACKAGE_LIBEET
-	bool "libeet"
-	select BR2_PACKAGE_ZLIB
-	select BR2_PACKAGE_JPEG
-	select BR2_PACKAGE_LIBEINA
-	help
-	  Eet is a tiny library designed to write an arbitary set of
-	  chunks of data to a file and optionally compress each chunk
-	  (very much like a zip file).
-
-	  http://trac.enlightenment.org/e/wiki/Eet
diff --git a/package/efl/libeet/libeet.mk b/package/efl/libeet/libeet.mk
deleted file mode 100644
index fc3d7f9..0000000
--- a/package/efl/libeet/libeet.mk
+++ /dev/null
@@ -1,27 +0,0 @@
-################################################################################
-#
-# libeet
-#
-################################################################################
-
-LIBEET_VERSION = 1.7.10
-LIBEET_SOURCE = eet-$(LIBEET_VERSION).tar.bz2
-LIBEET_SITE = http://download.enlightenment.org/releases
-LIBEET_LICENSE = BSD-2c
-LIBEET_LICENSE_FILES = COPYING
-
-LIBEET_INSTALL_STAGING = YES
-
-LIBEET_DEPENDENCIES = host-pkgconf zlib jpeg libeina
-HOST_LIBEET_DEPENDENCIES = host-pkgconf host-zlib host-libjpeg host-libeina
-
-ifeq ($(BR2_PACKAGE_GNUTLS)$(BR2_PACKAGE_LIBGCRYPT),yy)
-LIBEET_DEPENDENCIES += gnutls libgcrypt
-LIBEET_CONF_ENV += LIBGCRYPT_CONFIG=$(STAGING_DIR)/usr/bin/libgcrypt-config
-LIBEET_CONF_OPTS += --enable-gnutls
-else
-LIBEET_CONF_OPTS += --disable-gnutls
-endif
-
-$(eval $(autotools-package))
-$(eval $(host-autotools-package))
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 35/36] package/efl/libeina: remove package
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (33 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 34/36] package/efl/libeet: " Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 16:56   ` Yann E. MORIN
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 36/36] package/libemotion-generic-players: new package Romain Naour
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

Libeina is now available in efl package.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: remove libeina directory
v4: update Config.in to use libefl
v3: update legacy option for 2015.11
    update help text
---
 Config.in.legacy               |  7 +++++++
 package/efl/Config.in          |  1 -
 package/efl/libeina/Config.in  |  6 ------
 package/efl/libeina/libeina.mk | 18 ------------------
 4 files changed, 7 insertions(+), 25 deletions(-)
 delete mode 100644 package/efl/libeina/Config.in
 delete mode 100644 package/efl/libeina/libeina.mk

diff --git a/Config.in.legacy b/Config.in.legacy
index 14da2f2..d6cb451 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -107,6 +107,13 @@ endif
 ###############################################################################
 comment "Legacy options removed in 2015.11"
 
+config BR2_PACKAGE_LIBEINA
+	bool "libeina package has been removed"
+	select BR2_LEGACY
+	select BR2_PACKAGE_EFL
+	help
+	  The libeina package has been removed with the efl bump to 1.15.
+
 config BR2_PACKAGE_LIBEET
 	bool "libeet package has been removed"
 	select BR2_LEGACY
diff --git a/package/efl/Config.in b/package/efl/Config.in
index 9e92a6e..bddff8c 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -14,7 +14,6 @@ menuconfig BR2_PACKAGE_EFL
 
 if BR2_PACKAGE_EFL
 
-source "package/efl/libeina/Config.in"
 source "package/efl/libefl/Config.in"
 source "package/efl/libelementary/Config.in"
 
diff --git a/package/efl/libeina/Config.in b/package/efl/libeina/Config.in
deleted file mode 100644
index 80600ad..0000000
--- a/package/efl/libeina/Config.in
+++ /dev/null
@@ -1,6 +0,0 @@
-config BR2_PACKAGE_LIBEINA
-	bool "libeina"
-	help
-	  Eina is a tiny library to handle data types (list, hash, etc.)
-
-	  http://trac.enlightenment.org/e/wiki/Eina
diff --git a/package/efl/libeina/libeina.mk b/package/efl/libeina/libeina.mk
deleted file mode 100644
index ae9f1c6..0000000
--- a/package/efl/libeina/libeina.mk
+++ /dev/null
@@ -1,18 +0,0 @@
-################################################################################
-#
-# libeina
-#
-################################################################################
-
-LIBEINA_VERSION = 1.7.10
-LIBEINA_SOURCE = eina-$(LIBEINA_VERSION).tar.bz2
-LIBEINA_SITE = http://download.enlightenment.org/releases
-LIBEINA_LICENSE = LGPLv2.1+
-LIBEINA_LICENSE_FILES = COPYING
-
-LIBEINA_INSTALL_STAGING = YES
-
-LIBEINA_DEPENDENCIES = host-pkgconf
-
-$(eval $(autotools-package))
-$(eval $(host-autotools-package))
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 36/36] package/libemotion-generic-players: new package
  2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
                   ` (34 preceding siblings ...)
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 35/36] package/efl/libeina: " Romain Naour
@ 2015-10-24 21:01 ` Romain Naour
  2015-10-25 17:04   ` Yann E. MORIN
  35 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-24 21:01 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v5: Use depends on BR2_PACKAGE_EFL instead of select (ThomasP)
    update comment on dependencies
v4: update Config.in to use libefl
v3: remove trailing slash (Vicente Bergas)
---
 package/Config.in                                       |  1 +
 package/libemotion-generic-players/Config.in            | 15 +++++++++++++++
 .../libemotion-generic-players.hash                     |  2 ++
 .../libemotion-generic-players.mk                       | 17 +++++++++++++++++
 4 files changed, 35 insertions(+)
 create mode 100644 package/libemotion-generic-players/Config.in
 create mode 100644 package/libemotion-generic-players/libemotion-generic-players.hash
 create mode 100644 package/libemotion-generic-players/libemotion-generic-players.mk

diff --git a/package/Config.in b/package/Config.in
index 8ecb2df..d157004 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -819,6 +819,7 @@ menu "Graphics"
 	source "package/libdri2/Config.in"
 	source "package/libdrm/Config.in"
 	source "package/libexif/Config.in"
+	source "package/libemotion-generic-players/Config.in"
 	source "package/libevas-generic-loaders/Config.in"
 	source "package/libfm/Config.in"
 	source "package/libfm-extra/Config.in"
diff --git a/package/libemotion-generic-players/Config.in b/package/libemotion-generic-players/Config.in
new file mode 100644
index 0000000..71bca42
--- /dev/null
+++ b/package/libemotion-generic-players/Config.in
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_LIBEMOTION_GENERIC_PLAYERS
+	bool "libemotion generic players"
+	select BR2_PACKAGE_VLC # needs libvlc
+	depends on BR2_PACKAGE_EFL
+	depends on BR2_TOOLCHAIN_USES_GLIBC # vlc
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7 # vlc
+	help
+	  A media object library for Evas and Ecore.
+
+	  https://www.enlightenment.org
+	  https://docs.enlightenment.org/stable/efl/emotion_main.html
+
+comment "libemotion generic players needs a (e)glibc toolchain"
+	depends on !BR2_TOOLCHAIN_USES_GLIBC
+	depends on BR2_USE_MMU
diff --git a/package/libemotion-generic-players/libemotion-generic-players.hash b/package/libemotion-generic-players/libemotion-generic-players.hash
new file mode 100644
index 0000000..80c8123
--- /dev/null
+++ b/package/libemotion-generic-players/libemotion-generic-players.hash
@@ -0,0 +1,2 @@
+# From https://download.enlightenment.org/rel/libs/emotion_generic_players/emotion_generic_players-1.15.0.tar.xz.sha256
+sha256	9f6d5e9041ac7c014d663dac56d1b39ac42a45abe954d09d0edbf6e759e55f5f	emotion_generic_players-1.15.0.tar.xz
diff --git a/package/libemotion-generic-players/libemotion-generic-players.mk b/package/libemotion-generic-players/libemotion-generic-players.mk
new file mode 100644
index 0000000..70b8ba3
--- /dev/null
+++ b/package/libemotion-generic-players/libemotion-generic-players.mk
@@ -0,0 +1,17 @@
+################################################################################
+#
+# libemotion-generic-players
+#
+################################################################################
+
+LIBEMOTION_GENERIC_PLAYERS_VERSION = 1.15.0
+LIBEMOTION_GENERIC_PLAYERS_SOURCE = emotion_generic_players-$(LIBEMOTION_GENERIC_PLAYERS_VERSION).tar.xz
+LIBEMOTION_GENERIC_PLAYERS_SITE = http://download.enlightenment.org/rel/libs/emotion_generic_players
+LIBEMOTION_GENERIC_PLAYERS_LICENSE = GPLv2
+LIBEMOTION_GENERIC_PLAYERS_LICENSE_FILES = COPYING
+
+LIBEMOTION_GENERIC_PLAYERS_INSTALL_STAGING = YES
+
+LIBEMOTION_GENERIC_PLAYERS_DEPENDENCIES = libefl vlc
+
+$(eval $(autotools-package))
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 11/36] package/efl/libefl: add frame buffer config option
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 11/36] package/efl/libefl: add frame buffer config option Romain Naour
@ 2015-10-25 12:31   ` Yann E. MORIN
  2015-10-25 12:33     ` Yann E. MORIN
  2015-10-25 14:43   ` Yann E. MORIN
  1 sibling, 1 reply; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 12:31 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> Add an config option to enable frame buffer support
> in the efl libraries.
> 
> From the README [1]:
> This requires linux frame-buffer support, headers etc. This supports
> basic frame-buffers like /dev/fb as well as input via /dev/input for
> keyboards and mice in a basic way.
> 
> [1] https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n521
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> v4: rename to libefl
>     improve commit log
> ---
>  package/efl/libefl/Config.in | 5 +++++
>  package/efl/libefl/libefl.mk | 6 ++++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
> index c72ea7e..e25911f 100644
> --- a/package/efl/libefl/Config.in
> +++ b/package/efl/libefl/Config.in
> @@ -37,6 +37,11 @@ config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
>  	  otherwise we need to add a very long and obscure option
>  	  to start the build.
>  
> +comment "libecore video support"
> +
> +config BR2_PACKAGE_LIBEFL_FB
> +	bool "libecore framebuffer support"
> +
>  comment "libevas loaders"
>  
>  config BR2_PACKAGE_LIBEFL_PNG
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index 9633630..3a4aab1 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -166,6 +166,12 @@ else
>  LIBEFL_CONF_OPTS += --enable-wayland=no
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBEFL_FB),y)
> +LIBEFL_CONF_OPTS += --enable-fb=yes
> +else
> +LIBEFL_CONF_OPTS += --enable-fb=no
> +endif
> +
>  # image loader: handle only loaders that requires dependencies.
>  # All other loaders are builded by default statically.
>  ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 11/36] package/efl/libefl: add frame buffer config option
  2015-10-25 12:31   ` Yann E. MORIN
@ 2015-10-25 12:33     ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 12:33 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-25 13:31 +0100, Yann E. MORIN spake thusly:
> Romain, All,
> 
> On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> > Add an config option to enable frame buffer support
> > in the efl libraries.
> > 
> > From the README [1]:
> > This requires linux frame-buffer support, headers etc. This supports
> > basic frame-buffers like /dev/fb as well as input via /dev/input for
> > keyboards and mice in a basic way.
> > 
> > [1] https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n521
> > 
> > Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> 
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Gah... I replied to the wrong message... :-(

Forget it for now, I'll come to reviewing this patch later; I'll review
the preceding ones first...

Grr...

> Regards,
> Yann E. MORIN.
> 
> > ---
> > v4: rename to libefl
> >     improve commit log
> > ---
> >  package/efl/libefl/Config.in | 5 +++++
> >  package/efl/libefl/libefl.mk | 6 ++++++
> >  2 files changed, 11 insertions(+)
> > 
> > diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
> > index c72ea7e..e25911f 100644
> > --- a/package/efl/libefl/Config.in
> > +++ b/package/efl/libefl/Config.in
> > @@ -37,6 +37,11 @@ config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
> >  	  otherwise we need to add a very long and obscure option
> >  	  to start the build.
> >  
> > +comment "libecore video support"
> > +
> > +config BR2_PACKAGE_LIBEFL_FB
> > +	bool "libecore framebuffer support"
> > +
> >  comment "libevas loaders"
> >  
> >  config BR2_PACKAGE_LIBEFL_PNG
> > diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> > index 9633630..3a4aab1 100644
> > --- a/package/efl/libefl/libefl.mk
> > +++ b/package/efl/libefl/libefl.mk
> > @@ -166,6 +166,12 @@ else
> >  LIBEFL_CONF_OPTS += --enable-wayland=no
> >  endif
> >  
> > +ifeq ($(BR2_PACKAGE_LIBEFL_FB),y)
> > +LIBEFL_CONF_OPTS += --enable-fb=yes
> > +else
> > +LIBEFL_CONF_OPTS += --enable-fb=no
> > +endif
> > +
> >  # image loader: handle only loaders that requires dependencies.
> >  # All other loaders are builded by default statically.
> >  ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)
> > -- 
> > 2.4.3
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 01/36] package/expedite: move to package directory
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 01/36] package/expedite: move to package directory Romain Naour
@ 2015-10-25 12:33   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 12:33 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> There is no advantage for efl related packages to share the same version
> number anymore (except for Efl and Elementary).
> 
> Here are the version number used for the 1.15 stable release:
> EFL                     1.15.2
> Elementary              1.15.2
> Emotion Generic Players 1.15.0
> Evas Generic Loaders    1.15.0
> Python-EFL              1.15.0
> 
> Also, we usually do not have a sub-directory for a family of related
> packages which don't share the same version number, so move expedite
> to the package directory. Expedite now appears in the
> "Graphic libraries and applications (graphic/text)" in the Kconfig menu.
> 
> In a followup patch, expedite will be downloaded directly from the 1.15
> branch in the git repository since there is no new tarball release after
> 1.7.0.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

And now, I'm sure this is the correct patch I wanted to review... :-)

Regards,
Yann E. MORIN.

> ---
> v5: fixes typos (ThomasP)
>     Use depends on BR2_PACKAGE_EFL instead of select (ThomasP)
> v4: improve the commit log (ThomasP)
>     move expedite to "Graphic applications" under
>     "Graphic libraries and applications" menu (ThomasP)
>     fix package comment dependency on BR2_USE_MMU
> ---
>  package/Config.in                      | 1 +
>  package/efl/Config.in                  | 1 -
>  package/{efl => }/expedite/Config.in   | 1 +
>  package/{efl => }/expedite/expedite.mk | 0
>  4 files changed, 2 insertions(+), 1 deletion(-)
>  rename package/{efl => }/expedite/Config.in (95%)
>  rename package/{efl => }/expedite/expedite.mk (100%)
> 
> diff --git a/package/Config.in b/package/Config.in
> index 2f74439..c3b9a7a 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -219,6 +219,7 @@ endmenu
>  menu "Graphic libraries and applications (graphic/text)"
>  
>  comment "Graphic applications"
> +	source "package/expedite/Config.in"
>  	source "package/fswebcam/Config.in"
>  	source "package/glmark2/Config.in"
>  	source "package/gnuplot/Config.in"
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index 3d31a26..cb91660 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -10,7 +10,6 @@ menuconfig BR2_PACKAGE_EFL
>  
>  if BR2_PACKAGE_EFL
>  
> -source "package/efl/expedite/Config.in"
>  source "package/efl/libeina/Config.in"
>  source "package/efl/libecore/Config.in"
>  source "package/efl/libeet/Config.in"
> diff --git a/package/efl/expedite/Config.in b/package/expedite/Config.in
> similarity index 95%
> rename from package/efl/expedite/Config.in
> rename to package/expedite/Config.in
> index 1e12108..de6a056 100644
> --- a/package/efl/expedite/Config.in
> +++ b/package/expedite/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_EXPEDITE
>  	select BR2_PACKAGE_LIBEINA
>  	select BR2_PACKAGE_LIBEVAS
>  	select BR2_PACKAGE_LIBEET
> +	depends on BR2_PACKAGE_EFL
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # libevas
>  	help
> diff --git a/package/efl/expedite/expedite.mk b/package/expedite/expedite.mk
> similarity index 100%
> rename from package/efl/expedite/expedite.mk
> rename to package/expedite/expedite.mk
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 02/36] package/libevas-generic-loaders: move to package directory
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 02/36] package/libevas-generic-loaders: " Romain Naour
@ 2015-10-25 12:56   ` Yann E. MORIN
  2015-10-25 19:21     ` Romain Naour
  0 siblings, 1 reply; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 12:56 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> As for expedite package, there is no advantage for efl related
> packages to share the same version number anymore
> (except for efl and libelementary).
> 
> Also, we usually do not have a sub-directory for a family of related
> packages which doen't share the same version number, so move
> libevas-generic-loaders to package directory.
> Libevas-generic-loaders appear now in "Libraries" -> "Graphics" in
> the Kconfig menu.
> 
> While at it, remove BR2_USE_WCHAR dependency since the efl package
> already depend on it.

Are you sure that libevas-generic-loaders does not itself depend on
wchar?

If it does, then please keep the dependency, even if it is automatically
inherited through the dependency on EFL. This is so, in case EFL loses
its dependency on wchar, libevas-generic-loaders would still have its
own.

If it is not needed, then:

    Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v5: Use depends on BR2_PACKAGE_EFL instead of select (ThomasP)
> v4: improve the commit log (ThomasP)
>     move libevas-generic-loaders to "Libraries" -> "Graphics" (ThomasP)
>     fix package comment dependency on BR2_USE_MMU
> ---
>  package/Config.in                                                   | 1 +
>  package/efl/Config.in                                               | 1 -
>  package/{efl => }/libevas-generic-loaders/Config.in                 | 6 +++---
>  .../{efl => }/libevas-generic-loaders/libevas-generic-loaders.mk    | 0
>  4 files changed, 4 insertions(+), 4 deletions(-)
>  rename package/{efl => }/libevas-generic-loaders/Config.in (79%)
>  rename package/{efl => }/libevas-generic-loaders/libevas-generic-loaders.mk (100%)
> 
> diff --git a/package/Config.in b/package/Config.in
> index c3b9a7a..8ecb2df 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -819,6 +819,7 @@ menu "Graphics"
>  	source "package/libdri2/Config.in"
>  	source "package/libdrm/Config.in"
>  	source "package/libexif/Config.in"
> +	source "package/libevas-generic-loaders/Config.in"
>  	source "package/libfm/Config.in"
>  	source "package/libfm-extra/Config.in"
>  	source "package/libfreeimage/Config.in"
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index cb91660..7ce5a36 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -16,7 +16,6 @@ source "package/efl/libeet/Config.in"
>  source "package/efl/libefreet/Config.in"
>  source "package/efl/libeio/Config.in"
>  source "package/efl/libevas/Config.in"
> -source "package/efl/libevas-generic-loaders/Config.in"
>  source "package/efl/libembryo/Config.in"
>  source "package/efl/libedje/Config.in"
>  source "package/efl/libethumb/Config.in"
> diff --git a/package/efl/libevas-generic-loaders/Config.in b/package/libevas-generic-loaders/Config.in
> similarity index 79%
> rename from package/efl/libevas-generic-loaders/Config.in
> rename to package/libevas-generic-loaders/Config.in
> index 3f7581f..d0c3cf4 100644
> --- a/package/efl/libevas-generic-loaders/Config.in
> +++ b/package/libevas-generic-loaders/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
>  	bool "libevas generic loaders"
>  	select BR2_PACKAGE_LIBEINA
>  	select BR2_PACKAGE_ZLIB
> +	depends on BR2_PACKAGE_EFL
>  	help
>  	  These are additional "generic" loaders for Evas that are
>  	  stand-alone executables that evas may run from its generic
> @@ -15,15 +16,14 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
>  	bool "SVG loader"
>  	select BR2_PACKAGE_LIBRSVG
>  	select BR2_PACKAGE_CAIRO
> -	depends on BR2_USE_WCHAR # librsvg -> glib2
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # librsvg -> glib2
>  	depends on BR2_INSTALL_LIBSTDCPP # librsvg -> pango
>  	depends on BR2_ARCH_HAS_ATOMICS # cairo
>  	help
>  	  This option enables the Evas generic SVG loader
>  
> -comment "SVG loader needs a toolchain w/ wchar, threads, C++"
> +comment "SVG loader needs a toolchain w/ threads, C++"
>  	depends on BR2_ARCH_HAS_ATOMICS
> -	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
>  
>  endif
> diff --git a/package/efl/libevas-generic-loaders/libevas-generic-loaders.mk b/package/libevas-generic-loaders/libevas-generic-loaders.mk
> similarity index 100%
> rename from package/efl/libevas-generic-loaders/libevas-generic-loaders.mk
> rename to package/libevas-generic-loaders/libevas-generic-loaders.mk
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 03/36] package/efl/libefl: new host-package
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 03/36] package/efl/libefl: new host-package Romain Naour
@ 2015-10-25 13:10   ` Yann E. MORIN
  2015-10-25 19:24     ` Romain Naour
  0 siblings, 1 reply; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 13:10 UTC (permalink / raw)
  To: buildroot

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> This new host-package provide edje_cc, embryo_cc and eet binaries
> that will be used by the upcomming libefl packages which will
> contain the new version of efl libraries.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v4: keep efl as a sub-directory.
>     rename this new package to libefl since we want to keep a efl
>     and elementary version in sync.
> v3: remove trailing slash (Vicente Bergas)
>     bump to 1.15.2
> ---
>  package/efl/libefl/libefl.hash |  2 ++
>  package/efl/libefl/libefl.mk   | 75 ++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 77 insertions(+)
>  create mode 100644 package/efl/libefl/libefl.hash
>  create mode 100644 package/efl/libefl/libefl.mk
> 
> diff --git a/package/efl/libefl/libefl.hash b/package/efl/libefl/libefl.hash
> new file mode 100644
> index 0000000..7ac26f4
> --- /dev/null
> +++ b/package/efl/libefl/libefl.hash
> @@ -0,0 +1,2 @@
> +# From https://download.enlightenment.org/rel/libs/efl/efl-1.15.2.tar.xz.sha256
> +sha256	dd738f19f454621a7fa1fdb4c008457c170989f5f0c535edfed7b6773ae6c2a4	efl-1.15.2.tar.xz
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> new file mode 100644
> index 0000000..4dca733
> --- /dev/null
> +++ b/package/efl/libefl/libefl.mk
> @@ -0,0 +1,75 @@
> +################################################################################
> +#
> +# libefl
> +#
> +################################################################################
> +
> +# hardcode the version here since the bump to 1.15 is not complete in Buildroot
> +LIBEFL_VERSION = 1.15.2
> +LIBEFL_SOURCE = efl-$(LIBEFL_VERSION).tar.xz
> +LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl
> +LIBEFL_LICENSE = BSD-2c, LGPLv2.1+, GPLv2+
> +LIBEFL_LICENSE_FILES = COPYING

There are much more license files:

    LIBEFL_LICENSE_FILES = \
        COPYING \
        licenses/COPYING.BSD \
        licenses/COPYING.FTL \
        licenses/COPYING.GPL \
        licenses/COPYING.LGPL \
        licenses/COPYING.SMALL

We may also want to add COMPLIANCE to this list, since it has a few
suggestions about legal info.

Regards,
Yann E. MORIN.

> +################################################################################
> +#
> +# host-libefl
> +#
> +################################################################################
> +
> +# We want to build only some host tools used later in the build.
> +# Actually we want: edje_cc, embryo_cc and eet.
> +
> +# Host dependencies:
> +# * host-dbus: for Eldbus
> +# * host-freetype: for libevas
> +# * host-libglib2: for libecore
> +# * host-libjpeg, host-libpng: for libevas image loader
> +# * host-lua: disable luajit dependency
> +HOST_LIBEFL_DEPENDENCIES = \
> +	host-pkgconf \
> +	host-dbus \
> +	host-freetype \
> +	host-libglib2 \
> +	host-libjpeg \
> +	host-libpng \
> +	host-lua \
> +	host-zlib
> +
> +# Configure options:
> +# --disable-audio, --disable-multisense remove libsndfile dependency.
> +# --disable-cxx-bindings: disable C++11 bindings.
> +# --disable-fontconfig: remove dependency on fontconfig.
> +# --disable-fribidi: remove dependency on libfribidi.
> +# --disable-gstreamer1: remove dependency on gtreamer 1.0.
> +# --disable-libeeze: remove libudev dependency.
> +# --disable-libmount: remove dependency on host-util-linux libmount.
> +# --disable-physics: remove Bullet dependency.
> +# --enable-image-loader-gif=no: disable Gif dependency.
> +# --enable-image-loader-tiff=no: disable Tiff dependency.
> +# --enable-lua-old: disable Elua and remove luajit dependency.
> +# --with-crypto=none: remove dependencies on openssl or gnutls.
> +# --with-x11=none: remove dependency on X.org.
> +#   Yes I really know what I am doing.
> +HOST_LIBEFL_CONF_OPTS += \
> +	--disable-audio \
> +	--disable-cxx-bindings \
> +	--disable-fontconfig \
> +	--disable-fribidi \
> +	--disable-gstreamer1 \
> +	--disable-libeeze \
> +	--disable-libmount \
> +	--disable-multisense \
> +	--disable-physics \
> +	--enable-image-loader-gif=no \
> +	--enable-image-loader-jpeg=yes \
> +	--enable-image-loader-png=yes \
> +	--enable-image-loader-tiff=no \
> +	--enable-lua-old \
> +	--with-crypto=none \
> +	--with-glib=yes \
> +	--with-opengl=none \
> +	--with-x11=none \
> +	--enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-aba
> +
> +$(eval $(host-autotools-package))
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 04/36] package/efl/libefl: new package
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 04/36] package/efl/libefl: new package Romain Naour
@ 2015-10-25 13:55   ` Yann E. MORIN
  2015-10-26 21:53     ` Romain Naour
  0 siblings, 1 reply; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 13:55 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> Add the libefl package which contains an updated version of the following
> libraries:
> libecore, libedje, libeet, libfreet, libeina, libeio, libembryo, libthumb
> and libevas. It also contains eldbus, ephysics, and escape, see [1].
> 
> For now, the bump to efl 1.15.x is not complete.
> This allows to build at least a default configuration whithout X11 support
> or graphics acceleration.
> This support will be added by a follow up patches in the series.
> 
> Also, add BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG config option in order to
> select all recommended packages that allows to build efl-core whithout the
> extra-long --enable-i-really-know-what-i-am-doing...
> 
> At the end of the configure script, the summary tab will show that
> alsa support is allways disabled even if alsa-utils has been build
> before efl-core package.
> 
> "Ecore_Audio.....: yes (-alsa +pulseaudio +sndfile)"
> This is intentional.
> 
> An initial runtime test has been done under Qemu with a glibc x86 toolchain.
> 
> An additional runtime test has been done with a uClibc-ng 1.0.5 toolchain
> patched with [2] in order to add mkstemps() which is used by Eina library.
> This patch has been upstreamed in uClubc-ng 1.0.6 release.
> 
> Another test has been done with a musl toolchain by Vicente Bergas (Thanks!)
> 
> Add a dependency on threads support since clearly efl libraries are
> not even built without thread support [3].
> 
> [1] See https://phab.enlightenment.org/phame/live/3/post/efl_1_8/
> [2] http://mailman.uclibc-ng.org/pipermail/devel/2015-August/000432.html
> [3] https://git.enlightenment.org/core/efl.git/tree/configure.ac#n5032
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> Cc: Vicente Bergas <vicencb@gmail.com>
> ---
> v4: rename to libefl
>     EFL needs a toolchain with threads support
> v3: fix same typo again
>     Add a note about multisense support
> v2: remove glibc only dependency
>     update commit log accordingly
>     fix typo in Config.in (Vicente Bergas)
> 
> Vicente, can you test this new series and resend your Tested-By tag ? Thanks !
> ---
>  package/efl/Config.in        |  16 +++--
>  package/efl/libefl/Config.in |  65 +++++++++++++++++
>  package/efl/libefl/libefl.mk | 161 +++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 237 insertions(+), 5 deletions(-)
>  create mode 100644 package/efl/libefl/Config.in
> 
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index 7ce5a36..2860cd6 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -1,8 +1,12 @@
>  menuconfig BR2_PACKAGE_EFL
>  	bool "Enlightenment Foundation Libraries"
> -	depends on BR2_USE_WCHAR
> -	# libeina uses madvise(). To revisit when bumping EFL to 1.8
> -	depends on BR2_USE_MMU
> +	depends on BR2_INSTALL_LIBSTDCPP # libefl
> +	depends on BR2_PACKAGE_HAS_UDEV # libefl -> libudev
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # libefl
> +	depends on BR2_USE_MMU # libefl
> +	depends on BR2_USE_WCHAR # libefl
> +	depends on !BR2_STATIC_LIBS # libefl
> +	select BR2_PACKAGE_LIBEFL
>  	help
>  	  Enlightenment Foundation Libraries
>  
> @@ -13,6 +17,7 @@ if BR2_PACKAGE_EFL
>  source "package/efl/libeina/Config.in"
>  source "package/efl/libecore/Config.in"
>  source "package/efl/libeet/Config.in"
> +source "package/efl/libefl/Config.in"
>  source "package/efl/libefreet/Config.in"
>  source "package/efl/libeio/Config.in"
>  source "package/efl/libevas/Config.in"
> @@ -24,5 +29,6 @@ source "package/efl/libedbus/Config.in"
>  
>  endif # BR2_PACKAGE_EFL
>  
> -comment "EFL needs a toolchain w/ wchar"
> -	depends on !BR2_USE_WCHAR
> +comment "EFL needs udev /dev management and a toolchain w/ C++, dynamic library, threads, wchar"
> +	depends on !BR2_PACKAGE_HAS_UDEV || !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR

Please, split this very long line...

> +	depends on BR2_USE_MMU
> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
> new file mode 100644
> index 0000000..2b758f0
> --- /dev/null
> +++ b/package/efl/libefl/Config.in
> @@ -0,0 +1,65 @@
> +config BR2_PACKAGE_LIBEFL
> +	bool "libefl"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_PACKAGE_HAS_UDEV # libudev
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # untested without threads
> +	depends on BR2_USE_MMU
> +	depends on BR2_USE_WCHAR # use wchar_t
> +	depends on !BR2_STATIC_LIBS # dlfcn.h
> +	select BR2_PACKAGE_DBUS
> +	select BR2_PACKAGE_FREETYPE
> +	select BR2_PACKAGE_JPEG # Emile needs libjpeg
> +	select BR2_PACKAGE_LUA # Evas lua 5.1 or 5.2

You can not select Lua, as it is a provider of the virtual package
luainterpreter: it is not alowed to select the provider of a virtual
package, see the manual:
    http://buildroot.org/downloads/manual/manual.html#_notes_on_depending_on_a_specific_provider

    If your package really requires a specific provider, then you?ll
    have to make your package depends on this provider; you can not
    select a provider.

You'll have to make libefl (and efl) both depend on BR2_PACKAGE_LUA.

That's unfortunate, but the manual has explanations on why this is so.

> +	help
> +	  Enlightenment Foundation Libraries
> +
> +	  https://enlightenment.org
> +
> +if BR2_PACKAGE_LIBEFL
> +
> +config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
> +	bool "Use recommended and tested configurations"
> +	select BR2_PACKAGE_BULLET
> +	select BR2_PACKAGE_FONTCONFIG
> +	select BR2_PACKAGE_GSTREAMER1
> +	select BR2_PACKAGE_GST1_PLUGINS_BASE
> +	select BR2_PACKAGE_LIBFRIBIDI
> +	select BR2_PACKAGE_LIBSNDFILE
> +	select BR2_PACKAGE_PULSEAUDIO

You forgot to propagate P.A.'s dependency on BR2_ARCH_HAS_ATOMICS.

> +	select BR2_PACKAGE_UTIL_LINUX
> +	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
> +	default y
> +	help
> +	  Avoid to use untested or not recommended configurations,
> +	  otherwise we need to add a very long and obscure option
> +	  to start the build.

No need to explain the nitty-gritty implementation details on why this
is so. Just state something like:

    Enable the basic set of recommended features.

    Without that, the EFL developpers consider the build to be
    potentially broken and won't provide any support for it.

    This turns on the following features:

      - util-linux' libmount: Libmount is used heavily inside Eeze for
        support of removable devices etc... and disabling this will hurt
        support for Enlightenment and its filemanager.

      - fontconfig: If fontconfig is disabled, this is going to make
        general font searching not work, and only some very direct 'load
        /path/file.ttf' will work alongside some old-school ttf file
        path searching. This is very likely not what you want, so highly
        reconsider turning fontconfig off. Having it off will lead to
        visual problems like missing text in many UI areas etc...

And so on, you get the idea. ;-)

Drop the corresponding comment in the .mk file. It is better to thave
those comments in the Config.in, so the user can actually see them and
act accordingly.

[--SNIP--]
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index 4dca733..781f397 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -11,6 +11,167 @@ LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl
>  LIBEFL_LICENSE = BSD-2c, LGPLv2.1+, GPLv2+
>  LIBEFL_LICENSE_FILES = COPYING
>  
> +LIBEFL_INSTALL_STAGING = YES
> +
> +LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg lua udev zlib
> +
> +# Configure options:
> +# --disable-cxx-bindings: disable C++11 bindings.
> +# --enable-lua-old: disable Elua and remove luajit dependency.
> +# --with-x11=none: remove dependency on X.org.
> +LIBEFL_CONF_OPTS = \
> +	--with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc \
> +	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
> +	--disable-cxx-bindings \
> +	--enable-lua-old \
> +	--with-x11=none
> +
> +# Disable untested configuration warning.
> +ifeq ($(BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG),)
> +LIBEFL_CONF_OPTS += --enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-aba
> +endif
> +
> +# Libmount is used heavily inside Eeze for support of removable devices etc.
> +# and disabling this will hurt support for Enlightenment and its filemanager.
> +ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBMOUNT),y)
> +LIBEFL_DEPENDENCIES += util-linux
> +LIBEFL_CONF_OPTS += --enable-libmount
> +else
> +LIBEFL_CONF_OPTS += --disable-libmount
> +endif
> +
> +# If fontconfig is disabled, this is going to make general font
> +# searching not work, and only some very direct 'load /path/file.ttf'
> +# will work alongside some old-school ttf file path searching. This
> +# is very likely not what you want, so highly reconsider turning
> +# fontconfig off. Having it off will lead to visual problems like
> +# missing text in many UI areas etc.
> +ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
> +LIBEFL_CONF_OPTS += --enable-fontconfig
> +LIBEFL_DEPENDENCIES += fontconfig
> +else
> +LIBEFL_CONF_OPTS += --disable-fontconfig
> +endif
> +
> +# Fribidi is used for handling right-to-left text (like Arabic,
> +# Hebrew, Farsi, Persian etc.) and is very likely not a feature
> +# you want to disable unless you know for absolute certain you
> +# will never encounter and have to display such scripts. Also
> +# note that we don't test with fribidi disabled so you may also
> +# trigger code paths with bugs that are never normally used.
> +ifeq ($(BR2_PACKAGE_LIBFRIBIDI),y)
> +LIBEFL_CONF_OPTS += --enable-fribidi
> +LIBEFL_DEPENDENCIES += libfribidi
> +else
> +LIBEFL_CONF_OPTS += --disable-fribidi
> +endif
> +
> +# If Gstreamer 1.x support is disabled, it will heavily limit your media
> +# support options and render some functionality as useless, leading to
> +# visible application bugs.
> +ifeq ($(BR2_PACKAGE_GSTREAMER1)$(BR2_PACKAGE_GST1_PLUGINS_BASE),yy)
> +LIBEFL_CONF_OPTS += --enable-gstreamer1
> +LIBEFL_DEPENDENCIES += gstreamer1 gst1-plugins-base
> +else
> +LIBEFL_CONF_OPTS += --disable-gstreamer1
> +endif
> +
> +# You have chosen to disable physics support. This disables lots of
> +# core functionality and is effectively never tested. You are going
> +# to find features that suddenly don't work and as a result cause
> +# a series of breakages. This is simply not tested so you are on
> +# your own in terms of ensuring everything works if you do this
> +ifeq ($(BR2_PACKAGE_BULLET),y)
> +LIBEFL_CONF_OPTS += --enable-physics
> +LIBEFL_DEPENDENCIES += bullet
> +else
> +LIBEFL_CONF_OPTS += --disable-physics
> +endif
> +
> +# You disabled audio support in Ecore. This is not tested and may
> +# Create bugs for you due to it creating untested code paths.
> +# Reconsider disabling audio.
> +ifeq ($(BR2_PACKAGE_LIBSNDFILE),y)
> +LIBEFL_CONF_OPTS += --enable-audio
> +LIBEFL_DEPENDENCIES += libsndfile
> +else
> +LIBEFL_CONF_OPTS += --disable-audio
> +endif
> +
> +# The only audio output method supported by Ecore right now is via
> +# Pulseaudio. You have disabled that and likely have broken a whole
> +# bunch of things in the process. Reconsider your configure options.
> +# NOTE: multisense support is automatically enabled with pulseaudio.
> +ifeq ($(BR2_PACKAGE_PULSEAUDIO),y)
> +LIBEFL_CONF_OPTS += --enable-pulseaudio
> +LIBEFL_DEPENDENCIES += pulseaudio
> +else
> +LIBEFL_CONF_OPTS += --disable-pulseaudio
> +endif

As I previously suggested, move all the above comments to the Config.in
file, to help user make an enlighted (muahahaha!) decision.

> +# There is no alsa support yet in Ecore_Audio.
> +# configure will disable alsa support even if alsa-lib is selected.

So what? Having this comment stand alone is not much use. You should
probably add "LIBEFL_CONF_OPTS += --disable-alsa", then, no?

> +ifeq ($(BR2_PACKAGE_TSLIB),y)
> +LIBEFL_DEPENDENCIES += tslib
> +LIBEFL_CONF_OPTS += --enable-tslib
> +else
> +LIBEFL_CONF_OPTS += --disable-tslib
> +endif
> +
> +ifeq ($(BR2_PACKAGE_LIBGLIB2),y)
> +LIBEFL_DEPENDENCIES += libglib2
> +# we can also say "always"

Useless comment, drop it.

> +LIBEFL_CONF_OPTS += --with-glib=yes
> +else
> +LIBEFL_CONF_OPTS += --with-glib=no
> +endif
> +
> +# Prefer openssl (the default) over gnutls.
> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +LIBEFL_DEPENDENCIES += openssl
> +LIBEFL_CONF_OPTS += --with-crypto=openssl
> +else
> +ifeq ($(BR2_PACKAGE_GNUTLS)$(BR2_PACKAGE_LIBGCRYPT),yy)

use the else ifeq construct rather than nested if-blocks, ...

> +LIBEFL_DEPENDENCIES += gnutls libgcrypt
> +LIBEFL_CONF_OPTS += --with-crypto=gnutls \
> +	--with-libgcrypt-prefix=$(STAGING_DIR)/usr
> +else
> +LIBEFL_CONF_OPTS += --with-crypto=none
> +endif
> +endif # BR2_PACKAGE_OPENSSL

.. you'll gain one endif here.

> +# image loader: handle only loaders that requires dependencies.
> +# All other loaders are builded by default statically.
> +ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)
> +LIBEFL_CONF_OPTS += --enable-image-loader-png=yes
> +LIBEFL_DEPENDENCIES += libpng
> +else
> +LIBEFL_CONF_OPTS += --enable-image-loader-png=no
> +endif
> +
> +ifeq ($(BR2_PACKAGE_LIBEFL_JPEG),y)
> +LIBEFL_CONF_OPTS += --enable-image-loader-jpeg=yes

Maybe add a comment that the 'jpeg' dependency is already covered as a
global dependency of libefl. Otherwise, it is strange to not see it here
(I only remembered it because I previously checked if the dependencies
of jpeg were prorerly propagated).

Regards,
Yann E. MORIN.

> +else
> +LIBEFL_CONF_OPTS += --enable-image-loader-jpeg=no
> +endif
> +
> +ifeq ($(BR2_PACKAGE_LIBEFL_GIF),y)
> +LIBEFL_CONF_OPTS += --enable-image-loader-gif=yes
> +LIBEFL_DEPENDENCIES += giflib
> +else
> +LIBEFL_CONF_OPTS += --enable-image-loader-gif=no
> +endif
> +
> +ifeq ($(BR2_PACKAGE_LIBEFL_TIFF),y)
> +LIBEFL_CONF_OPTS += --enable-image-loader-tiff=yes
> +LIBEFL_DEPENDENCIES += tiff
> +else
> +LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no
> +endif
> +
> +$(eval $(autotools-package))
> +
>  ################################################################################
>  #
>  # host-libefl
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 05/36] package/efl/libefl: regenerate the configure script
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 05/36] package/efl/libefl: regenerate the configure script Romain Naour
@ 2015-10-25 14:00   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 14:00 UTC (permalink / raw)
  To: buildroot

romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> Workaround a build issue with eldbus-codegen:
> 
>   CCLD     bin/eldbus/eldbus-codegen
>   CXXLD    bin/eolian_cxx/eolian_cxx
>   CCLD     lib/ecore_x/ecore_x_vsync
>   CCLD     lib/evas/common/libevas_op_blend_sse3.la
>   CCLD     lib/evas/common/libevas_convert_rgb_32.la
>   CCLD     lib/ecore_ipc/libecore_ipc.la
> [...]/i686-ctng-linux-gnu/bin/ld: warning: libefl.so.1, needed by lib/ecore/.libs/libecore.so, not found (try using -rpath or -rpath-link)
> lib/ecore/.libs/libecore.so: undefined reference to `efl_control_suspend_set'
> lib/ecore/.libs/libecore.so: undefined reference to `efl_control_interface_get'
> collect2: error: ld returned 1 exit status
> Makefile:19135: recipe for target 'bin/eldbus/eldbus-codegen' failed
> make[6]: *** [bin/eldbus/eldbus-codegen] Error 1
> 
> A dependency on libefl seems to be missing for eldbus but by
> regenerating eldbus-codegen build correctly.
> 
> Reported upstream: https://phab.enlightenment.org/T2718
> 
> Also, gettextize is needed since *.po files were generated with
> an "old" gettext version (0.18):
> 
> Making all in po
> *** error: gettext infrastructure mismatch: using a Makefile.in.in from gettext version 0.18 but the autoconf macros are from gettext version 0.19
> Makefile:149: recipe for target 'check-macro-version' failed
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Please fold this commit into the previous one. But keep all the
explanations above, of course.

Regards,
Yann E. MORIN.

> ---
> v4: rename to libefl
> v3: fix gettextize
> ---
>  package/efl/libefl/libefl.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index 781f397..609ae6a 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -15,6 +15,11 @@ LIBEFL_INSTALL_STAGING = YES
>  
>  LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg lua udev zlib
>  
> +# regenerate the configure script:
> +# https://phab.enlightenment.org/T2718
> +LIBEFL_AUTORECONF = YES
> +LIBEFL_GETTEXTIZE = YES
> +
>  # Configure options:
>  # --disable-cxx-bindings: disable C++11 bindings.
>  # --enable-lua-old: disable Elua and remove luajit dependency.
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 06/36] package/efl/libefl: add harfbuzz dependency
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 06/36] package/efl/libefl: add harfbuzz dependency Romain Naour
@ 2015-10-25 14:22   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 14:22 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> Harfbuzz allow to enable complex text shaping and layouting
> support in efl libraries.
> 
> Also, it one of the "highly recommended" dependecies
> according to the README but disabling it doesn't need
> the --enable-i-really-know-what-i-am-doing... option.
> That's why harfbuzz is not added to
> BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> v4: rename to libefl
>     improve commit log.
> ---
>  package/efl/libefl/libefl.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index 609ae6a..2e42bb7 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -117,6 +117,13 @@ endif
>  # There is no alsa support yet in Ecore_Audio.
>  # configure will disable alsa support even if alsa-lib is selected.
>  
> +ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
> +LIBEFL_DEPENDENCIES += harfbuzz
> +LIBEFL_CONF_OPTS += --enable-harfbuzz=yes
> +else
> +LIBEFL_CONF_OPTS += --enable-harfbuzz=no
> +endif
> +
>  ifeq ($(BR2_PACKAGE_TSLIB),y)
>  LIBEFL_DEPENDENCIES += tslib
>  LIBEFL_CONF_OPTS += --enable-tslib
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 07/36] package/efl/libefl: add wayland dependency
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 07/36] package/efl/libefl: add wayland dependency Romain Naour
@ 2015-10-25 14:25   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 14:25 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> See:
> https://www.enlightenment.org/about-wayland
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

> ---
> v4: rename to libefl
> ---
>  package/efl/libefl/Config.in | 1 +
>  package/efl/libefl/libefl.mk | 7 +++++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
> index 2b758f0..07aee42 100644
> --- a/package/efl/libefl/Config.in
> +++ b/package/efl/libefl/Config.in
> @@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBEFL
>  	select BR2_PACKAGE_FREETYPE
>  	select BR2_PACKAGE_JPEG # Emile needs libjpeg
>  	select BR2_PACKAGE_LUA # Evas lua 5.1 or 5.2
> +	select BR2_PACKAGE_LIBXKBCOMMON if BR2_PACKAGE_WAYLAND
>  	help
>  	  Enlightenment Foundation Libraries
>  
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index 2e42bb7..c697e41 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -153,6 +153,13 @@ LIBEFL_CONF_OPTS += --with-crypto=none
>  endif
>  endif # BR2_PACKAGE_OPENSSL
>  
> +ifeq ($(BR2_PACKAGE_WAYLAND),y)
> +LIBEFL_DEPENDENCIES += wayland libxkbcommon
> +LIBEFL_CONF_OPTS += --enable-wayland=yes
> +else
> +LIBEFL_CONF_OPTS += --enable-wayland=no
> +endif
> +
>  # image loader: handle only loaders that requires dependencies.
>  # All other loaders are builded by default statically.
>  ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 08/36] package/efl/libefl: add libcurl dependency
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 08/36] package/efl/libefl: add libcurl dependency Romain Naour
@ 2015-10-25 14:37   ` Yann E. MORIN
  2015-10-28 21:39     ` Romain Naour
  0 siblings, 1 reply; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 14:37 UTC (permalink / raw)
  To: buildroot

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> Curl is listed as an dependency in the README:
> https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n453
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v4: rename to libefl
> ---
>  package/efl/libefl/Config.in | 1 +
>  package/efl/libefl/libefl.mk | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
> index 07aee42..29aef05 100644
> --- a/package/efl/libefl/Config.in
> +++ b/package/efl/libefl/Config.in
> @@ -9,6 +9,7 @@ config BR2_PACKAGE_LIBEFL
>  	select BR2_PACKAGE_DBUS
>  	select BR2_PACKAGE_FREETYPE
>  	select BR2_PACKAGE_JPEG # Emile needs libjpeg
> +	select BR2_PACKAGE_LIBCURL # eina_module, runtime dependency

If it is a runtime dependency, ...

>  	select BR2_PACKAGE_LUA # Evas lua 5.1 or 5.2
>  	select BR2_PACKAGE_LIBXKBCOMMON if BR2_PACKAGE_WAYLAND
>  	help
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index c697e41..b26f848 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -13,7 +13,8 @@ LIBEFL_LICENSE_FILES = COPYING
>  
>  LIBEFL_INSTALL_STAGING = YES
>  
> -LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg lua udev zlib
> +LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg libcurl lua \
> +	udev zlib

... then why do you add it to build dependencies?

Moreover, it looks more like a build dependency, given the number of
calls to the libcurl functions throughout the libelf code. Can you
confirm whether this is only a runtime dependency or a build dependency?

Regards,
Yann E. MORIN.

>  # regenerate the configure script:
>  # https://phab.enlightenment.org/T2718
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 09/36] package/efl/libefl: add libblkid dependency
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 09/36] package/efl/libefl: add libblkid dependency Romain Naour
@ 2015-10-25 14:40   ` Yann E. MORIN
  2015-10-28 22:03     ` Romain Naour
  0 siblings, 1 reply; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 14:40 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> util-linux libblkid is listed as an dependency in the README:
> https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n478
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v4: rename to libefl
> ---
>  package/efl/libefl/Config.in | 1 +
>  package/efl/libefl/libefl.mk | 5 +++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
> index 29aef05..5c65744 100644
> --- a/package/efl/libefl/Config.in
> +++ b/package/efl/libefl/Config.in
> @@ -29,6 +29,7 @@ config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
>  	select BR2_PACKAGE_LIBSNDFILE
>  	select BR2_PACKAGE_PULSEAUDIO
>  	select BR2_PACKAGE_UTIL_LINUX
> +	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
>  	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
>  	default y
>  	help
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index b26f848..c7ecf51 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -46,6 +46,11 @@ else
>  LIBEFL_CONF_OPTS += --disable-libmount
>  endif
>  
> +# libblkid is part of required tools, see EFL's README.

If it is indeed a required dependency, fold this in the patch adding
libefl.

> +ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),y)
> +LIBEFL_DEPENDENCIES += util-linux
> +endif

Besides, no need to make it conditional: it will always be 'y' since you
select it.

Regards,
Yann E. MORIN.

> +
>  # If fontconfig is disabled, this is going to make general font
>  # searching not work, and only some very direct 'load /path/file.ttf'
>  # will work alongside some old-school ttf file path searching. This
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 10/36] package/efl/libefl: add webp dependency
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 10/36] package/efl/libefl: add webp dependency Romain Naour
@ 2015-10-25 14:41   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 14:41 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> WebP is a new image format that provides lossless and lossy
> compression for images on the web. So enabling webp support
> in efl libraries allow to loads images using WebP.
> 
> Also, it one of the "highly recommended" dependecies [1]
> according to the README but disabling it doesn't need
> the --enable-i-really-know-what-i-am-doing... option.
> That's why BR2_PACKAGE_LIBEFL_WEBP is not added to
> BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG.
> 
> [1] https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n486
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v4: rename to libefl
>     improve commit log
> ---
>  package/efl/libefl/Config.in | 5 +++++
>  package/efl/libefl/libefl.mk | 7 +++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
> index 5c65744..c72ea7e 100644
> --- a/package/efl/libefl/Config.in
> +++ b/package/efl/libefl/Config.in
> @@ -65,4 +65,9 @@ config BR2_PACKAGE_LIBEFL_TIFF
>  	help
>  	  This enables the loader code that loads tiff files.
>  
> +config BR2_PACKAGE_LIBEFL_WEBP
> +	bool "libevas webp image loader"

You forgot to select BR2_PACKAGE_WEBP.

Regards,
Yann E. MORIN.

> +	help
> +	  This enables the loader code that loads images using WebP.
> +
>  endif # BR2_PACKAGE_LIBEFL
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index c7ecf51..9633630 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -195,6 +195,13 @@ else
>  LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBEFL_WEBP),y)
> +LIBEFL_CONF_OPTS += --enable-image-loader-webp=yes
> +LIBEFL_DEPENDENCIES += webp
> +else
> +LIBEFL_CONF_OPTS += --enable-image-loader-webp=no
> +endif
> +
>  $(eval $(autotools-package))
>  
>  ################################################################################
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 11/36] package/efl/libefl: add frame buffer config option
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 11/36] package/efl/libefl: add frame buffer config option Romain Naour
  2015-10-25 12:31   ` Yann E. MORIN
@ 2015-10-25 14:43   ` Yann E. MORIN
  1 sibling, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 14:43 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> Add an config option to enable frame buffer support
> in the efl libraries.
> 
> From the README [1]:
> This requires linux frame-buffer support, headers etc. This supports
> basic frame-buffers like /dev/fb as well as input via /dev/input for
> keyboards and mice in a basic way.
> 
> [1] https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n521
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

This time for real:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> v4: rename to libefl
>     improve commit log
> ---
>  package/efl/libefl/Config.in | 5 +++++
>  package/efl/libefl/libefl.mk | 6 ++++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
> index c72ea7e..e25911f 100644
> --- a/package/efl/libefl/Config.in
> +++ b/package/efl/libefl/Config.in
> @@ -37,6 +37,11 @@ config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
>  	  otherwise we need to add a very long and obscure option
>  	  to start the build.
>  
> +comment "libecore video support"
> +
> +config BR2_PACKAGE_LIBEFL_FB
> +	bool "libecore framebuffer support"
> +
>  comment "libevas loaders"
>  
>  config BR2_PACKAGE_LIBEFL_PNG
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index 9633630..3a4aab1 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -166,6 +166,12 @@ else
>  LIBEFL_CONF_OPTS += --enable-wayland=no
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBEFL_FB),y)
> +LIBEFL_CONF_OPTS += --enable-fb=yes
> +else
> +LIBEFL_CONF_OPTS += --enable-fb=no
> +endif
> +
>  # image loader: handle only loaders that requires dependencies.
>  # All other loaders are builded by default statically.
>  ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 12/36] package/efl/libefl: fix framebuffer support
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 12/36] package/efl/libefl: fix framebuffer support Romain Naour
@ 2015-10-25 14:45   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 14:45 UTC (permalink / raw)
  To: buildroot

romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> From: Vicente Bergas <vicencb@gmail.com>
> 
> From [1]:
> When running terminology, a message appears in eina_module_load with:
> could not dlopen("/usr/lib/ecore_evas/engines/fb/v-1.15/module.so",
> Error relocating /usr/lib/ecore_evas/engines/fb/v-1.15/module.so:
> ecore_fb_ts_shutdown: symbol not found): RTLD_NOW
> It seems like the EAPI macro has no effect...
> 
> A patch from Ross Vandegrift has been posted on enlightenment mailing
> list [2], but it's not yet an upstream patch.
> 
> [1] http://sourceforge.net/p/enlightenment/mailman/message/34493376
> [2] http://sourceforge.net/p/enlightenment/mailman/message/34492801

Then you should fold this into the previous patch that adds the
framebuffer option.

Regards,
Yann E. MORIN.

> Signed-off-by: Vicente Bergas <vicencb@gmail.com>
> [Romain: use a git formated patch and add a commit log]
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v4: move the patch to libefl
>     improve the commit log
> v3: new patch
> ---
>  ...ecore_fb_private.h-define-EAPI-before-use.patch | 64 ++++++++++++++++++++++
>  1 file changed, 64 insertions(+)
>  create mode 100644 package/efl/libefl/0001-ecore_fb_private.h-define-EAPI-before-use.patch
> 
> diff --git a/package/efl/libefl/0001-ecore_fb_private.h-define-EAPI-before-use.patch b/package/efl/libefl/0001-ecore_fb_private.h-define-EAPI-before-use.patch
> new file mode 100644
> index 0000000..81d14f9
> --- /dev/null
> +++ b/package/efl/libefl/0001-ecore_fb_private.h-define-EAPI-before-use.patch
> @@ -0,0 +1,64 @@
> +From 2fb4fdf641e67e49b87a3524038a694c8dd0ba4e Mon Sep 17 00:00:00 2001
> +From: Vicente Bergas <vicencb@gmail.com>
> +Date: Fri, 9 Oct 2015 23:35:20 +0200
> +Subject: [PATCH] ecore_fb_private.h: define EAPI before use
> +
> +From [1]:
> +When running terminology, a message appears in eina_module_load with:
> +could not dlopen("/usr/lib/ecore_evas/engines/fb/v-1.15/module.so",
> +Error relocating /usr/lib/ecore_evas/engines/fb/v-1.15/module.so:
> +ecore_fb_ts_shutdown: symbol not found): RTLD_NOW
> +It seems like the EAPI macro has no effect...
> +
> +A patch from Ross Vandegrift has been posted on enlightenment mailing
> +list [2], but it's not yet an upstream patch.
> +
> +[1] http://sourceforge.net/p/enlightenment/mailman/message/34493376
> +[2] http://sourceforge.net/p/enlightenment/mailman/message/34492801
> +
> +Signed-off-by: Vicente Bergas <vicencb@gmail.com>
> +[Romain:
> +  - Add a commit log
> +  - Add a link to the enlightenment mailing list
> +  - Add Vicente's SoB line]
> +Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> +---
> + src/lib/ecore_fb/ecore_fb_private.h | 17 +++++++++++++++++
> + 1 file changed, 17 insertions(+)
> +
> +diff --git a/src/lib/ecore_fb/ecore_fb_private.h b/src/lib/ecore_fb/ecore_fb_private.h
> +index f7dc0c6..f54c8d2 100644
> +--- a/src/lib/ecore_fb/ecore_fb_private.h
> ++++ b/src/lib/ecore_fb/ecore_fb_private.h
> +@@ -33,6 +33,20 @@
> + 
> + #include <Ecore_Fb.h>
> + 
> ++#ifdef EAPI
> ++# undef EAPI
> ++#endif
> ++
> ++#ifdef __GNUC__
> ++# if __GNUC__ >= 4
> ++#  define EAPI __attribute__ ((visibility("default")))
> ++# else
> ++#  define EAPI
> ++# endif
> ++#else
> ++# define EAPI
> ++#endif
> ++
> + /* ecore_fb_li.c */
> + struct _Ecore_Fb_Input_Device
> + {
> +@@ -92,4 +106,7 @@ void ecore_fb_vt_shutdown(void);
> + #define TS_GET_CAL 0x8014660a
> + #endif
> +   
> ++#undef EAPI
> ++#define EAPI
> ++
> + #endif
> +-- 
> +2.4.3
> +
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 13/36] package/efl/libefl: add jp2k config option
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 13/36] package/efl/libefl: add jp2k config option Romain Naour
@ 2015-10-25 14:48   ` Yann E. MORIN
  2015-10-26 22:04     ` Romain Naour
  2015-10-25 14:48   ` Yann E. MORIN
  1 sibling, 1 reply; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 14:48 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> Like for webp format, add an option to enable the JPEG 2000
> codec support in the efl libraries.

Suddenly, I wonder why you added a bunch of image loaders in the first
patch adding libelf, but you add a few more such loaders in separate
patches.

Can't you do either:
  - introduce all of them as separate patches, or
  - introduce all of them in the first patch adding libefl?

Or is there an underlying good reason to do as you did?

Regards,
Yann E. MORIN.

> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v4: rename to libefl
>     improve commit log
> ---
>  package/efl/libefl/Config.in | 7 +++++++
>  package/efl/libefl/libefl.mk | 7 +++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
> index e25911f..53adea2 100644
> --- a/package/efl/libefl/Config.in
> +++ b/package/efl/libefl/Config.in
> @@ -51,6 +51,13 @@ config BR2_PACKAGE_LIBEFL_PNG
>  	  This enables the loader code that loads png files using
>  	  libpng.
>  
> +config BR2_PACKAGE_LIBEFL_JP2K
> +	bool "libevas jp2k loader"
> +	select BR2_PACKAGE_OPENJPEG
> +	help
> +	  This enables the loader code that loads jp2k files using
> +	  openjpeg.
> +
>  config BR2_PACKAGE_LIBEFL_JPEG
>  	bool "libevas jpeg loader"
>  	help
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index 3a4aab1..e53470d 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -201,6 +201,13 @@ else
>  LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBEFL_JP2K),y)
> +LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=yes
> +LIBEFL_DEPENDENCIES += openjpeg
> +else
> +LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=no
> +endif
> +
>  ifeq ($(BR2_PACKAGE_LIBEFL_WEBP),y)
>  LIBEFL_CONF_OPTS += --enable-image-loader-webp=yes
>  LIBEFL_DEPENDENCIES += webp
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 13/36] package/efl/libefl: add jp2k config option
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 13/36] package/efl/libefl: add jp2k config option Romain Naour
  2015-10-25 14:48   ` Yann E. MORIN
@ 2015-10-25 14:48   ` Yann E. MORIN
  1 sibling, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 14:48 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> Like for webp format, add an option to enable the JPEG 2000
> codec support in the efl libraries.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

I forgot:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> v4: rename to libefl
>     improve commit log
> ---
>  package/efl/libefl/Config.in | 7 +++++++
>  package/efl/libefl/libefl.mk | 7 +++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
> index e25911f..53adea2 100644
> --- a/package/efl/libefl/Config.in
> +++ b/package/efl/libefl/Config.in
> @@ -51,6 +51,13 @@ config BR2_PACKAGE_LIBEFL_PNG
>  	  This enables the loader code that loads png files using
>  	  libpng.
>  
> +config BR2_PACKAGE_LIBEFL_JP2K
> +	bool "libevas jp2k loader"
> +	select BR2_PACKAGE_OPENJPEG
> +	help
> +	  This enables the loader code that loads jp2k files using
> +	  openjpeg.
> +
>  config BR2_PACKAGE_LIBEFL_JPEG
>  	bool "libevas jpeg loader"
>  	help
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index 3a4aab1..e53470d 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -201,6 +201,13 @@ else
>  LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBEFL_JP2K),y)
> +LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=yes
> +LIBEFL_DEPENDENCIES += openjpeg
> +else
> +LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=no
> +endif
> +
>  ifeq ($(BR2_PACKAGE_LIBEFL_WEBP),y)
>  LIBEFL_CONF_OPTS += --enable-image-loader-webp=yes
>  LIBEFL_DEPENDENCIES += webp
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 14/36] package/efl/libefl: add X11 support
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 14/36] package/efl/libefl: add X11 support Romain Naour
@ 2015-10-25 15:01   ` Yann E. MORIN
  2015-10-29 20:49     ` Romain Naour
  0 siblings, 1 reply; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 15:01 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> Add an option to enable X11 support in libecore without graphic
> acceleration. libecore can use xlib or xcb support but the latter
> in not recommended by efl developpers.
> 
> Also, set x-includes and x-libraries configure option for cross-compiling.
> Previous efl versions had cross-compilation issue (poisoned paths)
> if these options are not passed to configure script.
> 
> In order to remove the dependency on libXp wich is no longer bundled in
> recent X11 release [1], backport an upstream patch [2] to remove xprint
> usage.
> 
> [1] http://www.x.org/wiki/Releases/ModuleVersions
> [2] https://git.enlightenment.org/core/efl.git/commit/?h=efl-1.15&id=434572355c7e929b84210b2f795634d38f13c913
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
[--SNIP--]
> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
> index 53adea2..8356fa1 100644
> --- a/package/efl/libefl/Config.in
> +++ b/package/efl/libefl/Config.in
> @@ -42,6 +42,47 @@ comment "libecore video support"
>  config BR2_PACKAGE_LIBEFL_FB
>  	bool "libecore framebuffer support"
>  
> +config BR2_PACKAGE_LIBEFL_X
> +	bool "libecore X support"
> +	depends on BR2_PACKAGE_XORG7
> +	select BR2_PACKAGE_XLIB_LIBX11
> +	select BR2_PACKAGE_XLIB_LIBXEXT
> +
> +if BR2_PACKAGE_LIBEFL_X
> +
> +choice
> +	prompt "select libecore XLIB/XCB support"
> +
> +config BR2_PACKAGE_LIBEFL_X_XLIB
> +	bool "libecore XLIB support"
> +	select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
> +	select BR2_PACKAGE_XLIB_LIBXCURSOR
> +	select BR2_PACKAGE_XLIB_LIBXDAMAGE
> +	select BR2_PACKAGE_XLIB_LIBXINERAMA
> +	select BR2_PACKAGE_XLIB_LIBXP
> +	select BR2_PACKAGE_XLIB_LIBXRANDR
> +	select BR2_PACKAGE_XLIB_LIBXRENDER
> +	select BR2_PACKAGE_XLIB_LIBXSCRNSAVER
> +	select BR2_PACKAGE_XLIB_LIBXTST
> +	select BR2_PACKAGE_XPROTO_GLPROTO
> +
> +config BR2_PACKAGE_LIBEFL_X_XCB
> +	bool "libecore XCB support"
> +	depends on !BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
> +	select BR2_PACKAGE_LIBXCB
> +	select BR2_PACKAGE_XCB_UTIL_IMAGE # xcb-image.pc
> +	select BR2_PACKAGE_XCB_UTIL_KEYSYMS # xcb-keysyms.pc
> +	select BR2_PACKAGE_XCB_UTIL_RENDERUTIL # xcb-renderutil.pc
> +	select BR2_PACKAGE_XCB_UTIL_WM # xcb-icccm.pc
> +	select BR2_PACKAGE_XLIB_LIBX11
> +
> +comment "for libecore XCB support disable recommended configurations"
> +	depends on BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
> +
> +endchoice
> +
> +endif # BR2_PACKAGE_LIBEFL_X

Make that a single choice:

    choice
        bool "X11 support"

    config BR2_PACKAGE_LIBEFL_X_NONE
        bool "none"

    config BR2_PACKAGE_LIBEFL_X_XLIB
        bool "xlib"

    config BR2_PACKAGE_LIBEFL_X_XCB
        bool "xcb"

    endchoice # X11 support

Of course, with the appropriate depends/selects and comment.

>  comment "libevas loaders"
>  
>  config BR2_PACKAGE_LIBEFL_PNG
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index e53470d..6a1a8ae 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -18,6 +18,7 @@ LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg libcurl lua \
>  
>  # regenerate the configure script:
>  # https://phab.enlightenment.org/T2718
> +# configure.ac patched by 0002-ecore_x-Remove-XPrint-usage.patch

This comment might become misleading in the future, in case it we no
longer patch configure.ac. What about:

    # Regenerate the autotools:
    #  - to fix an issue in eldbus-codegen: https://phab.enlightenment.org/T2718
    #  - to remove dependency on libXp: https://phab.enlightenment.org/D3150 

>  LIBEFL_AUTORECONF = YES
>  LIBEFL_GETTEXTIZE = YES
>  
> @@ -30,7 +31,7 @@ LIBEFL_CONF_OPTS = \
>  	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
>  	--disable-cxx-bindings \
>  	--enable-lua-old \
> -	--with-x11=none
> +	--enable-lua-old

Now we've got --enable-lua-old twice. ;-)

>  # Disable untested configuration warning.
>  ifeq ($(BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG),)
> @@ -172,6 +173,65 @@ else
>  LIBEFL_CONF_OPTS += --enable-fb=no
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
> +LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \
> +	--x-includes=$(STAGING_DIR)/usr/include \
> +	--x-libraries=$(STAGING_DIR)/usr/lib \
> +	--with-opengl=none
> +
> +LIBEFL_DEPENDENCIES += \
> +	xlib_libX11 \
> +	xlib_libXext
> +else
> +LIBEFL_CONF_OPTS += --with-x=no \
> +	--with-x11=none
> +endif
> +
> +ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB),y)
> +LIBEFL_DEPENDENCIES += \
> +	xlib_libX11 \

xlib_libx11 already a dependency, above.

> +	xlib_libXcomposite \
> +	xlib_libXcursor \
> +	xlib_libXdamage \
> +	xlib_libXext \

Ditto.

> +	xlib_libXinerama \
> +	xlib_libXrandr \
> +	xlib_libXrender \
> +	xlib_libXScrnSaver \
> +	xlib_libXtst
> +LIBEFL_CONF_OPTS += --with-x11=xlib
> +endif
> +
> +# xcb-util-image to provide xcb-image.pc
> +# xcb-util-renderutil to provide xcb-renderutil.pc
> +# xcb-util-wm to provide xcb-icccm.pc
> +# xcb-util-keysyms to provide xcb-keysyms.pc
> +ifeq ($(BR2_PACKAGE_LIBEFL_X_XCB),y)
> +LIBEFL_DEPENDENCIES += libxcb \
> +	xcb-util-image \
> +	xcb-util-keysyms \
> +	xcb-util-renderutil \
> +	xcb-util-wm
> +# You have chosen to use XCB instead of Xlib. It is a myth that XCB
> +# is amazingly faster than Xlib (when used sensibly). It can be
> +# faster in a few corner cases on startup of an app, but it comes
> +# with many downsides. One of those is more complex code inside
> +# ecore_x, which is far less tested in XCB mode than Xlib. Also
> +# the big catch is that OpenGL support basically requires Xlib anyway
> +# so if you want OpenGL in X11, you need Xlib regardless and so you
> +# gain nothing really in terms of speed and no savings in memory
> +# because Xlib is still linked, loaded and used, BUT instead you
> +# have OpenGL drivers working with an hybrid XCB/Xlib (mostly XCB)
> +# toolkit and this is basically never tested by anyone working on
> +# the OpenGL drivers, so you will have bugs. Do not enable XCB
> +# and use OpenGL. XCB is only useful if you wish to shave a few Kb
> +# off the memory footprint of a whole system and live with less
> +# tested code, and possibly unimplemented features in ecore_x. To
> +# remove the XCB setup, remove the --with-x11=xcb option to
> +# configure.

Why this big comment? At best, it belongs to the help text of
BR2_PACKAGE_LIBEFL_X_XCB in the Config.in.

Also, I guess you're only quoting the EFL developers here, so you should
state so and add a pointer to that message upstream:

    https://git.enlightenment.org/core/efl.git/tree/configure.ac#n5002

But if it were purely on me, I would just drop it.

Regards,
Yann E. MORIN.

> +LIBEFL_CONF_OPTS += --with-x11=xcb
> +endif
> +
>  # image loader: handle only loaders that requires dependencies.
>  # All other loaders are builded by default statically.
>  ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 15/36] package/efl/libefl: add OpenGL/OpenGLES support
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 15/36] package/efl/libefl: add OpenGL/OpenGLES support Romain Naour
@ 2015-10-25 15:08   ` Yann E. MORIN
  2015-10-29 21:02     ` Romain Naour
  0 siblings, 1 reply; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 15:08 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> Allow to enable graphic acceleration using OpenGL or
> OpenGLES with efl libraries.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v4: rename libefl
>     improve commit log
> ---
>  package/efl/libefl/Config.in | 26 ++++++++++++++++++++++++++
>  package/efl/libefl/libefl.mk | 17 +++++++++++++++--
>  2 files changed, 41 insertions(+), 2 deletions(-)
> 
> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
> index 8356fa1..a3b6f0e 100644
> --- a/package/efl/libefl/Config.in
> +++ b/package/efl/libefl/Config.in
> @@ -81,6 +81,32 @@ comment "for libecore XCB support disable recommended configurations"
>  
>  endchoice
>  
> +if BR2_PACKAGE_LIBEFL_X_XLIB
> +
> +choice
> +	prompt "select libevas OpenGL support"
> +
> +config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_FULL
> +	bool "libevas OpenGL full support"
> +	depends on BR2_PACKAGE_HAS_LIBGL
> +
> +comment "libevas OpenGLES support needs libgl"
> +	depends on !BR2_PACKAGE_HAS_LIBGL
> +
> +config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_ES
> +	bool "libevas OpenGLES support"
> +	depends on BR2_PACKAGE_HAS_LIBGLES
> +
> +comment "libevas OpenGLES support needs libgles"
> +	depends on !BR2_PACKAGE_HAS_LIBGLES
> +
> +config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_NONE
> +	bool "libevas disable OpenGL support"
> +
> +endchoice
> +
> +endif # BR2_PACKAGE_LIBEFL_X_XLIB
> +

Here is a proposal to rewrite the option names and prompts:

    choice
        bool "OpenGL support"
        default BR2_PACKAGE_LIBEFL_X_XLIB_OPENGL   if BR2_PACKAGE_HAS_LIBGL
        default BR2_PACKAGE_LIBEFL_X_XLIB_OPENGLES if BR2_PACKAGE_HAS_LIBGLES
        help
          libevas can be configured to use HW acceleration with OpenGL
          or OpenGLES.

    config BR2_PACKAGE_LIBEFL_X_XLIB_OPENGL_NONE
        bool "none"

    config BR2_PACKAGE_LIBEFL_X_XLIB_OPENGL
        bool "opengl"
        depends on BR2_PACKAGE_HAS_LIBGL

    comment "opengl support needs an OpenGL provider"
        depends on !BR2_PACKAGE_HAS_LIBGL

    config BR2_PACKAGE_LIBEFL_X_XLIB_OPENGLES
        bool "opengles"
        depends on BR2_PACKAGE_HAS_LIBGLES

    comment "opengles support needs an opengles provider"
        depends on !BR2_PACKAGE_HAS_LIBGLES

    endchoice

If you fell inclined into adoptiong this, update the corresponding
options in the .mk, of course.

Regards,
Yann E. MORIN.

>  endif # BR2_PACKAGE_LIBEFL_X
>  
>  comment "libevas loaders"
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index 6a1a8ae..e275699 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -176,8 +176,7 @@ endif
>  ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
>  LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \
>  	--x-includes=$(STAGING_DIR)/usr/include \
> -	--x-libraries=$(STAGING_DIR)/usr/lib \
> -	--with-opengl=none
> +	--x-libraries=$(STAGING_DIR)/usr/lib
>  
>  LIBEFL_DEPENDENCIES += \
>  	xlib_libX11 \
> @@ -187,6 +186,20 @@ LIBEFL_CONF_OPTS += --with-x=no \
>  	--with-x11=none
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB_GLX_FULL),y)
> +LIBEFL_CONF_OPTS += --with-opengl=full
> +LIBEFL_DEPENDENCIES += libgl
> +endif
> +
> +ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB_GLX_ES),y)
> +LIBEFL_CONF_OPTS += --with-opengl=es
> +LIBEFL_DEPENDENCIES += libgles
> +endif
> +
> +ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB_GLX_NONE),y)
> +LIBEFL_CONF_OPTS += --with-opengl=none
> +endif
> +
>  ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB),y)
>  LIBEFL_DEPENDENCIES += \
>  	xlib_libX11 \
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 16/36] package/efl/libefl: enable xinput2.2
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 16/36] package/efl/libefl: enable xinput2.2 Romain Naour
@ 2015-10-25 15:11   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 15:11 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> X11 XInput v2.2+ support is one of the recommended
> feature for the efl libraries:
> https://git.enlightenment.org/core/efl.git/tree/README?h=efl-1.15#n490
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v4: rename to libefl
>     improve commit log
> v3: new patch
> ---
>  package/efl/libefl/libefl.mk | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index e275699..02c9005 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -173,10 +173,12 @@ else
>  LIBEFL_CONF_OPTS += --enable-fb=no
>  endif
>  
> +# --enable-xinput22 is recommended
>  ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
>  LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \
>  	--x-includes=$(STAGING_DIR)/usr/include \
> -	--x-libraries=$(STAGING_DIR)/usr/lib
> +	--x-libraries=$(STAGING_DIR)/usr/lib \
> +	--enable-xinput22

xinput22 needs xlib_libXi.

Also, you may also want to explicitly enable (or disable?) xinput2.

Regards,
Yann E. MORIN.

>  LIBEFL_DEPENDENCIES += \
>  	xlib_libX11 \
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 17/36] package/efl/libefl: add systemd dependency
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 17/36] package/efl/libefl: add systemd dependency Romain Naour
@ 2015-10-25 15:13   ` Yann E. MORIN
  2015-10-29 21:38     ` Romain Naour
  0 siblings, 1 reply; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 15:13 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> systemd it one of the "highly recommended" dependecies
> according to the README [1] but disabling it doesn't need
> the --enable-i-really-know-what-i-am-doing... option.
> That's why systemd is not added to
> BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG.
> 
> [1] https://git.enlightenment.org/core/efl.git/tree/README?h=efl-1.15#n491
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

However, see a comment, below...

> ---
> v4: rename to libefl
>     improve commit log
> v3: new patch
> ---
>  package/efl/libefl/libefl.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index 02c9005..c26c9c5 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -52,6 +52,13 @@ ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),y)
>  LIBEFL_DEPENDENCIES += util-linux
>  endif
>  
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +LIBEFL_CONF_OPTS += --enable-systemd
> +LIBEFL_DEPENDENCIES += systemd
> +else
> +LIBEFL_CONF_OPTS += --disable-systemd
> +endif

You're adding optional dependencies with various patches; that's
perfectly good.

However, I woiuld like that all those optional features be forcibly
disabled form the first patch adding libefl. Then each of your patches
would transform the hard-coded --disable-XXXX into conditional blocks
(with or without Config.in options).

Regards,
Yann E. MORIN.

>  # If fontconfig is disabled, this is going to make general font
>  # searching not work, and only some very direct 'load /path/file.ttf'
>  # will work alongside some old-school ttf file path searching. This
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 18/36] package/efl/libefl: add sdl2 support
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 18/36] package/efl/libefl: add sdl2 support Romain Naour
@ 2015-10-25 15:20   ` Yann E. MORIN
  2015-10-29 21:17     ` Romain Naour
  0 siblings, 1 reply; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 15:20 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> SDL support can't be used with OpenGLES.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v5: new patch added since sdl2 package is new available
> ---
>  package/efl/libefl/Config.in |  7 +++++++
>  package/efl/libefl/libefl.mk | 11 +++++++++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
> index a3b6f0e..44860a2 100644
> --- a/package/efl/libefl/Config.in
> +++ b/package/efl/libefl/Config.in
> @@ -42,6 +42,12 @@ comment "libecore video support"
>  config BR2_PACKAGE_LIBEFL_FB
>  	bool "libecore framebuffer support"
>  
> +config BR2_PACKAGE_LIBEFL_SDL2
> +	bool "libevas SDL2 support"

FB and X11 refere to libecore, but SDL2 refer to libevas. Is that an
oversight, or is that correct?

However, I would simply drop it, to have just:

    FB support
    SDL2 support
    X11 support

> +	# SDL support is not available with OpenGLES.
> +	depends on !BR2_PACKAGE_LIBEFL_X_XLIB_GLX_ES
> +	select BR2_PACKAGE_SDL2
> +
>  config BR2_PACKAGE_LIBEFL_X
>  	bool "libecore X support"
>  	depends on BR2_PACKAGE_XORG7
> @@ -89,6 +95,7 @@ choice
>  config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_FULL
>  	bool "libevas OpenGL full support"
>  	depends on BR2_PACKAGE_HAS_LIBGL
> +	select BR2_PACKAGE_LIBGLU if BR2_PACKAGE_LIBEFL_SDL2 # evas depends on libglu header in evas_engine.c

I have troubles understanding this set of options.

So, with the current code, one may select SDL2 and not X11. Is that a
viable situation?

If so, then OpenGL support will never be available, since OpenGL depends
on X11 being enabled. Is that OK? Don't you need to unhide the OpenGL
choice for SDL2 too?

Did I miss something?

>  comment "libevas OpenGLES support needs libgl"
>  	depends on !BR2_PACKAGE_HAS_LIBGL
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index c26c9c5..8ddca64 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -180,6 +180,17 @@ else
>  LIBEFL_CONF_OPTS += --enable-fb=no
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBEFL_SDL2),y)
> +LIBEFL_CONF_OPTS += --enable-sdl=yes
> +LIBEFL_DEPENDENCIES += sdl2
> +else
> +LIBEFL_CONF_OPTS += --enable-sdl=no
> +endif
> +
> +ifeq ($(BR2_PACKAGE_EFL_X_XLIB_GLX_FULL)$(BR2_PACKAGE_EFL_SDL2),yy)
> +EFL_DEPENDENCIES += libglu
> +endif

Hmm.. It seems that SDL2 can be over X11, right?

So, how does SDL2 compare to FB and X11? Is it at the same "level" (i.e.
a rendering backend talking to the hardwware), or is it layered on-top
of X11?

Regards,
Yann E. MORIN.

>  # --enable-xinput22 is recommended
>  ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
>  LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 19/36] package/libevas-generic-loaders: bump to version 1.15.0
  2015-10-24 21:00 ` [Buildroot] [PATCH v5 19/36] package/libevas-generic-loaders: bump to version 1.15.0 Romain Naour
@ 2015-10-25 16:01   ` Yann E. MORIN
  2015-10-25 21:08     ` Yann E. MORIN
  0 siblings, 1 reply; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:01 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> Use the newly added libefl package wich provide a new version
> of libeina.
> 
> Also, update the upstream url and add a hash file.
> 
> While at it, remove BR2_TOOLCHAIN_HAS_THREADS and BR2_INSTALL_LIBSTDCPP
> dependencies since the efl package already depend on them.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> v5: Use depends on BR2_PACKAGE_EFL instead of select (ThomasP)
> v4: rename to libefl
>     improve commit log
>     add a dependency on threads
> v3: remove trailing slash (Vicente Bergas)
> v2: bump to 1.15
>     remove glibc only dependency
> ---
>  package/libevas-generic-loaders/Config.in                    | 9 +--------
>  package/libevas-generic-loaders/libevas-generic-loaders.hash | 2 ++
>  package/libevas-generic-loaders/libevas-generic-loaders.mk   | 9 +++++----
>  3 files changed, 8 insertions(+), 12 deletions(-)
>  create mode 100644 package/libevas-generic-loaders/libevas-generic-loaders.hash
> 
> diff --git a/package/libevas-generic-loaders/Config.in b/package/libevas-generic-loaders/Config.in
> index d0c3cf4..5b9f009 100644
> --- a/package/libevas-generic-loaders/Config.in
> +++ b/package/libevas-generic-loaders/Config.in
> @@ -1,6 +1,5 @@
>  config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
>  	bool "libevas generic loaders"
> -	select BR2_PACKAGE_LIBEINA
>  	select BR2_PACKAGE_ZLIB
>  	depends on BR2_PACKAGE_EFL
>  	help
> @@ -8,7 +7,7 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
>  	  stand-alone executables that evas may run from its generic
>  	  loader module.
>  
> -	  http://trac.enlightenment.org/e/wiki/Evas_Generic_Loaders
> +	  https://www.enlightenment.org/
>  
>  if BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
>  
> @@ -16,14 +15,8 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
>  	bool "SVG loader"
>  	select BR2_PACKAGE_LIBRSVG
>  	select BR2_PACKAGE_CAIRO
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # librsvg -> glib2
> -	depends on BR2_INSTALL_LIBSTDCPP # librsvg -> pango
>  	depends on BR2_ARCH_HAS_ATOMICS # cairo
>  	help
>  	  This option enables the Evas generic SVG loader
>  
> -comment "SVG loader needs a toolchain w/ threads, C++"
> -	depends on BR2_ARCH_HAS_ATOMICS
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
> -
>  endif
> diff --git a/package/libevas-generic-loaders/libevas-generic-loaders.hash b/package/libevas-generic-loaders/libevas-generic-loaders.hash
> new file mode 100644
> index 0000000..32723ba
> --- /dev/null
> +++ b/package/libevas-generic-loaders/libevas-generic-loaders.hash
> @@ -0,0 +1,2 @@
> +# From https://download.enlightenment.org/rel/libs/evas_generic_loaders/evas_generic_loaders-1.15.0.tar.xz.sha256
> +sha256	1e539e4d4d4e1590345caeb7fdd84f47ec7cd63bb76b6b7107a87420a401fd7f	evas_generic_loaders-1.15.0.tar.xz
> diff --git a/package/libevas-generic-loaders/libevas-generic-loaders.mk b/package/libevas-generic-loaders/libevas-generic-loaders.mk
> index ac6b1cc..d8ab252 100644
> --- a/package/libevas-generic-loaders/libevas-generic-loaders.mk
> +++ b/package/libevas-generic-loaders/libevas-generic-loaders.mk
> @@ -4,17 +4,18 @@
>  #
>  ################################################################################
>  
> -LIBEVAS_GENERIC_LOADERS_VERSION = 1.7.10
> -LIBEVAS_GENERIC_LOADERS_SOURCE = evas_generic_loaders-$(LIBEVAS_GENERIC_LOADERS_VERSION).tar.bz2
> -LIBEVAS_GENERIC_LOADERS_SITE = http://download.enlightenment.org/releases
> +LIBEVAS_GENERIC_LOADERS_VERSION = 1.15.0
> +LIBEVAS_GENERIC_LOADERS_SOURCE = evas_generic_loaders-$(LIBEVAS_GENERIC_LOADERS_VERSION).tar.xz
> +LIBEVAS_GENERIC_LOADERS_SITE = http://download.enlightenment.org/rel/libs/evas_generic_loaders
>  LIBEVAS_GENERIC_LOADERS_LICENSE = GPLv2
>  LIBEVAS_GENERIC_LOADERS_LICENSE_FILES = COPYING
>  
>  LIBEVAS_GENERIC_LOADERS_INSTALL_STAGING = YES
>  
> -LIBEVAS_GENERIC_LOADERS_DEPENDENCIES = libeina zlib
> +LIBEVAS_GENERIC_LOADERS_DEPENDENCIES = libefl zlib
>  
>  # For now, we only support the SVG loader
> +# poppler >= 0.32 is not supported with libevas-generic-loaders 1.14.0
>  LIBEVAS_GENERIC_LOADERS_CONF_OPTS += \
>  	--disable-poppler \
>  	--disable-spectre \
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 20/36] package/libevas-generic-loaders: add libraw dependency
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 20/36] package/libevas-generic-loaders: add libraw dependency Romain Naour
@ 2015-10-25 16:03   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:03 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> libraw it's one of the "highly recommended" dependecies
> according to the README [1].
> 
> [1] https://git.enlightenment.org/core/evas_generic_loaders.git/tree/README?id=v1.15.0#n31
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v4: improve commit log
> ---
>  package/libevas-generic-loaders/Config.in                  | 5 +++++
>  package/libevas-generic-loaders/libevas-generic-loaders.mk | 9 +++++++--
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/package/libevas-generic-loaders/Config.in b/package/libevas-generic-loaders/Config.in
> index 5b9f009..26166a8 100644
> --- a/package/libevas-generic-loaders/Config.in
> +++ b/package/libevas-generic-loaders/Config.in
> @@ -11,6 +11,11 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
>  
>  if BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
>  
> +config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_LIBRAW
> +	bool "Libraw loader"

You forgot to select BR2_PACKAGE_LIBRAW and propagate its dependency on
C++.

Regards,
Yann E. MORIN.

> +	help
> +	  This option enables the Evas generic Libraw loader
> +
>  config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
>  	bool "SVG loader"
>  	select BR2_PACKAGE_LIBRSVG
> diff --git a/package/libevas-generic-loaders/libevas-generic-loaders.mk b/package/libevas-generic-loaders/libevas-generic-loaders.mk
> index d8ab252..4665ded 100644
> --- a/package/libevas-generic-loaders/libevas-generic-loaders.mk
> +++ b/package/libevas-generic-loaders/libevas-generic-loaders.mk
> @@ -14,14 +14,19 @@ LIBEVAS_GENERIC_LOADERS_INSTALL_STAGING = YES
>  
>  LIBEVAS_GENERIC_LOADERS_DEPENDENCIES = libefl zlib
>  
> -# For now, we only support the SVG loader
>  # poppler >= 0.32 is not supported with libevas-generic-loaders 1.14.0
>  LIBEVAS_GENERIC_LOADERS_CONF_OPTS += \
>  	--disable-poppler \
>  	--disable-spectre \
> -	--disable-libraw \
>  	--disable-gstreamer
>  
> +ifeq ($(BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_LIBRAW),y)
> +LIBEVAS_GENERIC_LOADERS_DEPENDENCIES += libraw
> +LIBEVAS_GENERIC_LOADERS_CONF_OPTS += --enable-libraw
> +else
> +LIBEVAS_GENERIC_LOADERS_CONF_OPTS += --disable-libraw
> +endif
> +
>  ifeq ($(BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG),y)
>  LIBEVAS_GENERIC_LOADERS_DEPENDENCIES += librsvg cairo
>  LIBEVAS_GENERIC_LOADERS_CONF_OPTS += --enable-svg
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 21/36] package/efl/libelementary: bump to version 1.15.2
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 21/36] package/efl/libelementary: bump to version 1.15.2 Romain Naour
@ 2015-10-25 16:09   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:09 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> Use the newly added libefl package wich provide a new version
> of libeina, libevas, libecore and libedje.
> 
> Update the upstream url and add a hash file.
> 
> Since eet, eolian_gen and eldbus_codegen are installed in
> HOST_DIR by host-efl package, help configure script to find
> them.
> 
> Explicitly disable doxygen and elementary-test.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

See however a comment in the next patch of yours.

Regards,
Yann E. MORIN.

> ---
> v5: move the hash file to package/efl/libelementary
> v4: keep libelementary in package/efl/
> v3: bump to 1.15.2
>     remove trailing slash (Vicente Bergas)
> v2: bump to 1.15.1
>     remove glibc only dependency
> ---
>  package/efl/libelementary/Config.in          | 11 +----------
>  package/efl/libelementary/libelementary.hash |  2 ++
>  package/efl/libelementary/libelementary.mk   | 25 +++++++++----------------
>  3 files changed, 12 insertions(+), 26 deletions(-)
>  create mode 100644 package/efl/libelementary/libelementary.hash
> 
> diff --git a/package/efl/libelementary/Config.in b/package/efl/libelementary/Config.in
> index 4f62592..182b14a 100644
> --- a/package/efl/libelementary/Config.in
> +++ b/package/efl/libelementary/Config.in
> @@ -1,17 +1,8 @@
> -comment "libelementary needs a toolchain w/ threads, dynamic library"
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
> -
>  config BR2_PACKAGE_LIBELEMENTARY
>  	bool "libelementary"
> -	select BR2_PACKAGE_LIBEINA
> -	select BR2_PACKAGE_LIBEVAS
> -	select BR2_PACKAGE_LIBECORE
> -	select BR2_PACKAGE_LIBEDJE
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # libevas
> -	depends on !BR2_STATIC_LIBS
>  	help
>  	  Elementary is a widget toolkit and EFL wrapper and convenience
>  	  library to make it easy to build applications and tools with UIs
>  	  with less code.
>  
> -	  http://trac.enlightenment.org/e/wiki/Elementary
> +	  https://enlightenment.org
> diff --git a/package/efl/libelementary/libelementary.hash b/package/efl/libelementary/libelementary.hash
> new file mode 100644
> index 0000000..2cd36d8
> --- /dev/null
> +++ b/package/efl/libelementary/libelementary.hash
> @@ -0,0 +1,2 @@
> +# From https://download.enlightenment.org/rel/libs/elementary/elementary-1.15.2.tar.xz.sha256
> +sha256	523c3073210b611817d0f56aa8348962ec757282f9f7dfde93825afa164a0f3f	elementary-1.15.2.tar.xz
> diff --git a/package/efl/libelementary/libelementary.mk b/package/efl/libelementary/libelementary.mk
> index 8bd69fe..a2c4a60 100644
> --- a/package/efl/libelementary/libelementary.mk
> +++ b/package/efl/libelementary/libelementary.mk
> @@ -4,29 +4,22 @@
>  #
>  ################################################################################
>  
> -LIBELEMENTARY_VERSION = 1.7.10
> -LIBELEMENTARY_SOURCE = elementary-$(LIBELEMENTARY_VERSION).tar.bz2
> -LIBELEMENTARY_SITE = http://download.enlightenment.org/releases
> +LIBELEMENTARY_VERSION = 1.15.2
> +LIBELEMENTARY_SOURCE = elementary-$(LIBELEMENTARY_VERSION).tar.xz
> +LIBELEMENTARY_SITE = http://download.enlightenment.org/rel/libs/elementary
>  LIBELEMENTARY_LICENSE = LGPLv2.1
>  LIBELEMENTARY_LICENSE_FILES = COPYING
>  
>  LIBELEMENTARY_INSTALL_STAGING = YES
>  
> -LIBELEMENTARY_DEPENDENCIES = \
> -	libeina libevas libecore libedje host-libedje \
> -	host-libeet
> +LIBELEMENTARY_DEPENDENCIES = host-pkgconf host-libefl libefl
>  
>  LIBELEMENTARY_CONF_OPTS = \
>  	--with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc \
> -	--with-eet-eet=$(HOST_DIR)/usr/bin/eet
> -
> -# libethumb_client is only built when ethumbd is built.
> -# ethumbd is only built if edbus is built.
> -ifeq ($(BR2_PACKAGE_LIBETHUMB)$(BR2_PACKAGE_LIBEDBUS),yy)
> -LIBELEMENTARY_DEPENDENCIES += libethumb
> -LIBELEMENTARY_CONF_OPTS += --enable-ethumb
> -else
> -LIBELEMENTARY_CONF_OPTS += --disable-ethumb
> -endif
> +	--with-eet-eet=$(HOST_DIR)/usr/bin/eet \
> +	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
> +	--with-eldbus_codegen=$(HOST_DIR)/usr/bin/eldbus-codegen \
> +	--with-doxygen=no \
> +	--disable-elementary-test
>  
>  $(eval $(autotools-package))
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 22/36] package/efl/libelementary: add host package
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 22/36] package/efl/libelementary: add host package Romain Naour
@ 2015-10-25 16:11   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:11 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> elm_prefs_cc builded for the host machine is
> needed to cross-compile correctly libelementary
> for the target. Otherwise, elm_prefs_cc for the
> target is used on the host machine.

Then,  either:
  - this should be folded in the previous patch, or
  - this should come berore the previous patch.

In which case you can keep my:
    Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

in that previous patch and add it to this one.

Regards,
Yann E. MORIN.

> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v4: use libefl
>     reword the commit message
> ---
>  package/efl/libelementary/libelementary.mk | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/package/efl/libelementary/libelementary.mk b/package/efl/libelementary/libelementary.mk
> index a2c4a60..4ba8681 100644
> --- a/package/efl/libelementary/libelementary.mk
> +++ b/package/efl/libelementary/libelementary.mk
> @@ -12,14 +12,26 @@ LIBELEMENTARY_LICENSE_FILES = COPYING
>  
>  LIBELEMENTARY_INSTALL_STAGING = YES
>  
> -LIBELEMENTARY_DEPENDENCIES = host-pkgconf host-libefl libefl
> +LIBELEMENTARY_DEPENDENCIES = host-pkgconf host-libefl host-libelementary libefl
>  
>  LIBELEMENTARY_CONF_OPTS = \
>  	--with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc \
>  	--with-eet-eet=$(HOST_DIR)/usr/bin/eet \
>  	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
>  	--with-eldbus_codegen=$(HOST_DIR)/usr/bin/eldbus-codegen \
> +	--with-elm-prefs-cc=$(HOST_DIR)/usr/bin/elm_prefs_cc \
> +	--with-doxygen=no \
> +	--disable-elementary-test
> +
> +# We need a host package in order to provide elm_prefs_cc and
> +# elementary_codegen.
> +HOST_LIBELEMENTARY_DEPENDENCIES = host-pkgconf host-libefl
> +HOST_LIBELEMENTARY_CONF_OPTS = \
> +	--with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc \
> +	--with-eet-eet=$(HOST_DIR)/usr/bin/eet \
> +	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
>  	--with-doxygen=no \
>  	--disable-elementary-test
>  
>  $(eval $(autotools-package))
> +$(eval $(host-autotools-package))
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 23/36] package/efl: libefl and libelementary share the same version number
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 23/36] package/efl: libefl and libelementary share the same version number Romain Naour
@ 2015-10-25 16:13   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:13 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

However, see a comment/question below...

> ---
>  package/efl/efl.mk                         | 2 ++
>  package/efl/libefl/libefl.mk               | 3 +--
>  package/efl/libelementary/libelementary.mk | 2 +-
>  3 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/package/efl/efl.mk b/package/efl/efl.mk
> index 99e4d14..151ac28 100644
> --- a/package/efl/efl.mk
> +++ b/package/efl/efl.mk
> @@ -1,2 +1,4 @@
>  
> +EFL_VERSION = 1.15.2
> +
>  include $(sort $(wildcard package/efl/*/*.mk))
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index 8ddca64..6aaa08b 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -4,8 +4,7 @@
>  #
>  ################################################################################
>  
> -# hardcode the version here since the bump to 1.15 is not complete in Buildroot
> -LIBEFL_VERSION = 1.15.2
> +LIBEFL_VERSION = $(EFL_VERSION)
>  LIBEFL_SOURCE = efl-$(LIBEFL_VERSION).tar.xz
>  LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl
>  LIBEFL_LICENSE = BSD-2c, LGPLv2.1+, GPLv2+
> diff --git a/package/efl/libelementary/libelementary.mk b/package/efl/libelementary/libelementary.mk
> index 4ba8681..c920801 100644
> --- a/package/efl/libelementary/libelementary.mk
> +++ b/package/efl/libelementary/libelementary.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -LIBELEMENTARY_VERSION = 1.15.2
> +LIBELEMENTARY_VERSION = $(EFL_VERSION)

Even though this is true right now, will that ever be the case?

I.e. are we sure libefl and libelementary will always be released in
tandem?

Regards,
Yann E. MORIN.

>  LIBELEMENTARY_SOURCE = elementary-$(LIBELEMENTARY_VERSION).tar.xz
>  LIBELEMENTARY_SITE = http://download.enlightenment.org/rel/libs/elementary
>  LIBELEMENTARY_LICENSE = LGPLv2.1
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 24/36] package/enlightenment: bump to version 0.19.12
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 24/36] package/enlightenment: bump to version 0.19.12 Romain Naour
@ 2015-10-25 16:28   ` Yann E. MORIN
  2015-10-31 14:10     ` Romain Naour
  0 siblings, 1 reply; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:28 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> Use the newly added libefl package wich provide a new version
> of efl libraries.
> This new version needs libelementary dependency.
> 
> Update upstream url, add hash file and use xz archive.
> 
> Select png and jpeg image loader since enlightenment_start
> fail at runtime if png and jpeg image loader are not
> available in elf libraries.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> v5: Use depends on BR2_PACKAGE_EFL instead of select (ThomasP)
>     remove comment on dependencies
> v4: update Config.in to use libefl
>     improve commit log
>     keep the dependency on threads
> v3: bymp to 0.19.12
>     remove trailing slash (Vicente Bergas)
> v2: bump to 0.19.9
>     remove glibc only dependency
> ---
>  package/enlightenment/Config.in          | 36 +++++++-------------------------
>  package/enlightenment/enlightenment.hash |  2 ++
>  package/enlightenment/enlightenment.mk   | 22 +++++++------------
>  3 files changed, 17 insertions(+), 43 deletions(-)
>  create mode 100644 package/enlightenment/enlightenment.hash
> 
> diff --git a/package/enlightenment/Config.in b/package/enlightenment/Config.in
> index 58f8f39..4a349fb 100644
> --- a/package/enlightenment/Config.in
> +++ b/package/enlightenment/Config.in
> @@ -1,33 +1,16 @@
>  config BR2_PACKAGE_ENLIGHTENMENT
>  	bool "enlightenment"
> -	select BR2_PACKAGE_EFL
> -	select BR2_PACKAGE_LIBECORE
> -	select BR2_PACKAGE_LIBECORE_X
> -	select BR2_PACKAGE_LIBEINA
> -	select BR2_PACKAGE_LIBEET
> -	select BR2_PACKAGE_LIBEVAS
> -	select BR2_PACKAGE_LIBEVAS_JPEG
> -	select BR2_PACKAGE_LIBEVAS_PNG
> -	select BR2_PACKAGE_LIBEVAS_EET
> -	select BR2_PACKAGE_LIBECORE_EVAS
> -	select BR2_PACKAGE_LIBEDJE
> -	select BR2_PACKAGE_LIBEFREET
> -	select BR2_PACKAGE_LIBEDBUS
> -	select BR2_PACKAGE_LIBEIO
> -	select BR2_PACKAGE_XCB_UTIL_KEYSYMS
> +	select BR2_PACKAGE_LIBEFL_X
> +	select BR2_PACKAGE_LIBEFL_JPEG # needed at runtime by enlightenment_start
> +	select BR2_PACKAGE_LIBEFL_PNG # needed at runtime by enlightenment_start
> +	select BR2_PACKAGE_LIBELEMENTARY
>  	select BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
>  	select BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
> -	# libevas-generic-loaders-svg -> librsvg -> glib2 / pango
> -	depends on BR2_USE_WCHAR
> -	depends on BR2_INSTALL_LIBSTDCPP
> -	# libedbus -> dbus
> -	# libedbus -> glib2, libevas
> -	depends on BR2_TOOLCHAIN_HAS_THREADS
> -	# libedbus -> dbus, efl libraries
> -	depends on BR2_USE_MMU
> -	depends on BR2_PACKAGE_XORG7
> +	select BR2_PACKAGE_XCB_UTIL_KEYSYMS
>  	# libevas-generic-loaders-svg -> librsvg -> pango -> cairo
>  	depends on BR2_ARCH_HAS_ATOMICS
> +	depends on BR2_PACKAGE_EFL
> +	depends on BR2_PACKAGE_XORG7

I really do not like those depends that go after the selects. It is
more complex to read.

Even though the ordering has absolutely no consequences in Kconfig, it
is not logical (when reading). It is more logical and far easier to
understand when depends come first, followed by the selects.

(i.e it runs as thus in my head: this stuff needs foo and bar, so it
depends on them. Then, once dependenecies are fullfilled, I can select
other stuff.)

Note: it is not your fault, the code was already laid out thusly before
your patch. Still, this is looking ugly to me.

> diff --git a/package/enlightenment/enlightenment.mk b/package/enlightenment/enlightenment.mk
> index ddebe06..9127099 100644
> --- a/package/enlightenment/enlightenment.mk
> +++ b/package/enlightenment/enlightenment.mk
> @@ -4,24 +4,18 @@
>  #
>  ################################################################################
>  
> -ENLIGHTENMENT_VERSION = 0.17.6
> -ENLIGHTENMENT_SITE = http://download.enlightenment.org/releases
> +ENLIGHTENMENT_VERSION = 0.19.12
> +ENLIGHTENMENT_SOURCE = enlightenment-$(ENLIGHTENMENT_VERSION).tar.xz
> +ENLIGHTENMENT_SITE = http://download.enlightenment.org/rel/apps/enlightenment
>  ENLIGHTENMENT_LICENSE = BSD-2c
>  ENLIGHTENMENT_LICENSE_FILES = COPYING
>  
> -ENLIGHTENMENT_DEPENDENCIES = 	\
> -	host-pkgconf 		\
> -	libecore 		\
> -	libeet 			\
> -	libeina 		\
> -	libevas 		\
> +ENLIGHTENMENT_DEPENDENCIES = \
> +	host-pkgconf \
> +	host-libefl \
> +	libefl \
> +	libelementary \
>  	libevas-generic-loaders \
> -	libedje 		\
> -	libefreet 		\
> -	libedbus 		\
> -	libeio 			\
> -	host-libedje 		\
> -	host-libeet		\
>  	xcb-util-keysyms
>  
>  ENLIGHTENMENT_CONF_OPTS = \

A bit later in that file, we have:

    # alsa backend needs mixer support
    ifeq ($(BR2_PACKAGE_ALSA_LIB)$(BR2_PACKAGE_ALSA_LIB_MIXER),yy)
    ENLIGHTENMENT_DEPENDENCIES += alsa-lib
    else
    ENLIGHTENMENT_CONF_ENV += enable_alsa=no
    endif

However, you previously said, when introducing libefl, that alsa support
was not working at all (even when alsa-lib was found).

How does that affect the enlightment package?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 25/36] package/expedite: bump to efl-1.15 branch
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 25/36] package/expedite: bump to efl-1.15 branch Romain Naour
@ 2015-10-25 16:36   ` Yann E. MORIN
  2015-10-31 14:19     ` Romain Naour
  0 siblings, 1 reply; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:36 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> Since expedite hasn't been released since 1.7.10 release,
> use efl-1.15 branch in the git tree.
> 
> Use the newly added libefl package wich provide a new version
> of efl libraries.
> 
> Autoreconf the package since there is no configure script
> in the git tree.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
[--SNIP--]
> diff --git a/package/expedite/expedite.mk b/package/expedite/expedite.mk
> index 9b232f8..ae30535 100644
> --- a/package/expedite/expedite.mk
> +++ b/package/expedite/expedite.mk
> @@ -4,14 +4,19 @@
>  #
>  ################################################################################
>  
> -EXPEDITE_VERSION = 1.7.10
> -EXPEDITE_SITE = http://download.enlightenment.org/releases
> +# efl-1.15 branch
> +EXPEDITE_VERSION = 3ce8b3f1451700f9a2da60c2e717c644220e2449
> +EXPEDITE_SITE = http://git.enlightenment.org/tools/expedite.git
> +EXPEDITE_SITE_METHOD = git
>  EXPEDITE_LICENSE = BSD-2c
>  EXPEDITE_LICENSE_FILES = COPYING
>  
> -EXPEDITE_DEPENDENCIES = libevas libeina libeet
> +EXPEDITE_DEPENDENCIES = host-libefl libefl

It also uses PKG_CHECK_MODULES, so you need host-pkgconf.

BTW, please check the previous patches, I did not systematically checked
for it. I've seen it on some of the efl packages, but I'm not sure all
depend on host-pkgconf when needed.

Regards,
Yann E. MORIN.

> -ifeq ($(BR2_PACKAGE_LIBEVAS_X11),y)
> +# There is no configure script in the git tree.
> +EXPEDITE_AUTORECONF = YES
> +
> +ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
>  EXPEDITE_CONF_OPTS += --with-x=$(STAGING_DIR) \
>  	--x-includes=$(STAGING_DIR)/usr/include \
>  	--x-libraries=$(STAGING_DIR)/usr/lib
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 26/36] package/efl/libethumb: remove package
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 26/36] package/efl/libethumb: remove package Romain Naour
@ 2015-10-25 16:38   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:38 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> Libethumb is now available in efl package.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> v4: remove libethumb from package/efl/
> v3: update legacy option for 2015.11
>     update help text
> ---
>  Config.in.legacy                   |  7 +++++++
>  package/efl/Config.in              |  1 -
>  package/efl/libethumb/Config.in    | 15 ---------------
>  package/efl/libethumb/libethumb.mk | 27 ---------------------------
>  4 files changed, 7 insertions(+), 43 deletions(-)
>  delete mode 100644 package/efl/libethumb/Config.in
>  delete mode 100644 package/efl/libethumb/libethumb.mk
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index c5b8223..d35a241 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -107,6 +107,13 @@ endif
>  ###############################################################################
>  comment "Legacy options removed in 2015.11"
>  
> +config BR2_PACKAGE_LIBETHUMB
> +	bool "libethumb package has been removed"
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_EFL
> +	help
> +	  The libethumb package has been removed with the efl bump to 1.15.
> +
>  config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_REAL
>  	bool "gst1-plugins-bad real plugin has been removed"
>  	select BR2_LEGACY
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index 2860cd6..0729e02 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -23,7 +23,6 @@ source "package/efl/libeio/Config.in"
>  source "package/efl/libevas/Config.in"
>  source "package/efl/libembryo/Config.in"
>  source "package/efl/libedje/Config.in"
> -source "package/efl/libethumb/Config.in"
>  source "package/efl/libelementary/Config.in"
>  source "package/efl/libedbus/Config.in"
>  
> diff --git a/package/efl/libethumb/Config.in b/package/efl/libethumb/Config.in
> deleted file mode 100644
> index 3e9cbde..0000000
> --- a/package/efl/libethumb/Config.in
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -comment "libethumb needs a toolchain w/ threads"
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS
> -
> -config BR2_PACKAGE_LIBETHUMB
> -	bool "libethumb"
> -	select BR2_PACKAGE_LIBEINA
> -	select BR2_PACKAGE_LIBEVAS
> -	select BR2_PACKAGE_LIBECORE
> -	select BR2_PACKAGE_LIBECORE_EVAS
> -	select BR2_PACKAGE_LIBEDJE
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # libevas
> -	help
> -	  Ethumb is a library for generating thumbnail images of documents.
> -
> -	  http://trac.enlightenment.org/e/wiki/Ethumb
> diff --git a/package/efl/libethumb/libethumb.mk b/package/efl/libethumb/libethumb.mk
> deleted file mode 100644
> index 314ddf9..0000000
> --- a/package/efl/libethumb/libethumb.mk
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -################################################################################
> -#
> -# libethumb
> -#
> -################################################################################
> -
> -LIBETHUMB_VERSION = 1.7.10
> -LIBETHUMB_SOURCE = ethumb-$(LIBETHUMB_VERSION).tar.bz2
> -LIBETHUMB_SITE = http://download.enlightenment.org/releases
> -LIBETHUMB_LICENSE = LGPLv2.1+
> -LIBETHUMB_LICENSE_FILES = COPYING
> -
> -LIBETHUMB_INSTALL_STAGING = YES
> -
> -LIBETHUMB_DEPENDENCIES = libeina libevas libecore libedje host-libedje
> -
> -LIBETHUMB_CONF_OPTS = --with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc
> -
> -ifeq ($(BR2_PACKAGE_LIBEXIF),y)
> -LIBETHUMB_DEPENDENCIES += libexif
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEDBUS),y)
> -LIBETHUMB_DEPENDENCIES += libedbus
> -endif
> -
> -$(eval $(autotools-package))
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 27/36] package/efl/libedje: remove package
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 27/36] package/efl/libedje: " Romain Naour
@ 2015-10-25 16:41   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:41 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> Libedje is now available in efl package.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

However. see a comment below...

> ---
> v5: remove libedje directory
> v4: update Config.in to use libefl
> v3: update legacy option for 2015.11
>     update help text
> ---
>  Config.in.legacy               |  7 +++++++
>  package/efl/Config.in          |  1 -
>  package/efl/libedje/Config.in  | 28 ----------------------------
>  package/efl/libedje/libedje.mk | 28 ----------------------------
>  4 files changed, 7 insertions(+), 57 deletions(-)
>  delete mode 100644 package/efl/libedje/Config.in
>  delete mode 100644 package/efl/libedje/libedje.mk
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index d35a241..3349c50 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -107,6 +107,13 @@ endif
>  ###############################################################################
>  comment "Legacy options removed in 2015.11"
>  
> +config BR2_PACKAGE_LIBEDJE
> +	bool "libedje package has been removed"
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_EFL
> +	help
> +	  The libedje package has been removed with the efl bump to 1.15.

It would be interesting to explain that it has been integrating into the
libefl package by upstream, like so:

    With EFL 1.15, libedje is now provided by the libefl package.

Probably something similar for libethumb, below (forgot to say so in my
previous mail).

Regards,
Yann E. MORIN.

>  config BR2_PACKAGE_LIBETHUMB
>  	bool "libethumb package has been removed"
>  	select BR2_LEGACY

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 28/36] package/efl/libembryo: remove package
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 28/36] package/efl/libembryo: " Romain Naour
@ 2015-10-25 16:43   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:43 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> Libembryo is now available in efl package.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Same comment as libedje about the legacy comment.

Regards,
Yann E. MORIN.

> ---
> v5: remove libembryo directory
> v4: update Config.in to use libefl
> v3: update legacy option for 2015.11
>     update help text
> ---
>  Config.in.legacy                   |  7 +++++++
>  package/efl/Config.in              |  1 -
>  package/efl/libembryo/Config.in    |  9 ---------
>  package/efl/libembryo/libembryo.mk | 18 ------------------
>  4 files changed, 7 insertions(+), 28 deletions(-)
>  delete mode 100644 package/efl/libembryo/Config.in
>  delete mode 100644 package/efl/libembryo/libembryo.mk
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 3349c50..e7e49e3 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -107,6 +107,13 @@ endif
>  ###############################################################################
>  comment "Legacy options removed in 2015.11"
>  
> +config BR2_PACKAGE_LIBEMBRYO
> +	bool "libembryo package has been removed"
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_EFL
> +	help
> +	  The libembryo package has been removed with the efl bump to 1.15.
> +
>  config BR2_PACKAGE_LIBEDJE
>  	bool "libedje package has been removed"
>  	select BR2_LEGACY
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index 5a14192..31dc066 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -21,7 +21,6 @@ source "package/efl/libefl/Config.in"
>  source "package/efl/libefreet/Config.in"
>  source "package/efl/libeio/Config.in"
>  source "package/efl/libevas/Config.in"
> -source "package/efl/libembryo/Config.in"
>  source "package/efl/libelementary/Config.in"
>  source "package/efl/libedbus/Config.in"
>  
> diff --git a/package/efl/libembryo/Config.in b/package/efl/libembryo/Config.in
> deleted file mode 100644
> index 63c7064..0000000
> --- a/package/efl/libembryo/Config.in
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -config BR2_PACKAGE_LIBEMBRYO
> -	bool "libembryo"
> -	select BR2_PACKAGE_LIBEINA
> -	help
> -	  Embryo is primarily a shared library that gives you an API
> -	  to load and control interpreted programs compiled into an
> -	  abstract machine bytecode that it understands.
> -
> -	  http://trac.enlightenment.org/e/wiki/Embryo
> diff --git a/package/efl/libembryo/libembryo.mk b/package/efl/libembryo/libembryo.mk
> deleted file mode 100644
> index fc45e42..0000000
> --- a/package/efl/libembryo/libembryo.mk
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -################################################################################
> -#
> -# libembryo
> -#
> -################################################################################
> -
> -LIBEMBRYO_VERSION = 1.7.10
> -LIBEMBRYO_SOURCE = embryo-$(LIBEMBRYO_VERSION).tar.bz2
> -LIBEMBRYO_SITE = http://download.enlightenment.org/releases
> -LIBEMBRYO_LICENSE = BSD-2c, Embryo license
> -LIBEMBRYO_LICENSE_FILES = COPYING
> -
> -LIBEMBRYO_INSTALL_STAGING = YES
> -
> -LIBEMBRYO_DEPENDENCIES = host-pkgconf libeina
> -
> -$(eval $(autotools-package))
> -$(eval $(host-autotools-package))
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 29/36] package/efl/libeio: remove package
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 29/36] package/efl/libeio: " Romain Naour
@ 2015-10-25 16:44   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:44 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> Libeio is now available in efl package.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Again, still the same comment as for the previous removals.

Regards,
Yann E. MORIN.

> ---
> v5: remove libeio directory
> v4: update Config.in to use libefl
> v3: update legacy option for 2015.11
>     update help text
> ---
>  Config.in.legacy             |  7 +++++++
>  package/efl/Config.in        |  1 -
>  package/efl/libeio/Config.in | 22 ----------------------
>  package/efl/libeio/libeio.mk | 16 ----------------
>  4 files changed, 7 insertions(+), 39 deletions(-)
>  delete mode 100644 package/efl/libeio/Config.in
>  delete mode 100644 package/efl/libeio/libeio.mk
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index e7e49e3..feda47b 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -107,6 +107,13 @@ endif
>  ###############################################################################
>  comment "Legacy options removed in 2015.11"
>  
> +config BR2_PACKAGE_LIBEIO
> +	bool "libeio package has been removed"
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_EFL
> +	help
> +	  The libeio package has been removed with the efl bump to 1.15.
> +
>  config BR2_PACKAGE_LIBEMBRYO
>  	bool "libembryo package has been removed"
>  	select BR2_LEGACY
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index 31dc066..9d258eb 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -19,7 +19,6 @@ source "package/efl/libecore/Config.in"
>  source "package/efl/libeet/Config.in"
>  source "package/efl/libefl/Config.in"
>  source "package/efl/libefreet/Config.in"
> -source "package/efl/libeio/Config.in"
>  source "package/efl/libevas/Config.in"
>  source "package/efl/libelementary/Config.in"
>  source "package/efl/libedbus/Config.in"
> diff --git a/package/efl/libeio/Config.in b/package/efl/libeio/Config.in
> deleted file mode 100644
> index 5b1e395..0000000
> --- a/package/efl/libeio/Config.in
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -config BR2_PACKAGE_LIBEIO
> -	bool "libeio"
> -	select BR2_PACKAGE_LIBEET
> -	select BR2_PACKAGE_LIBEINA
> -	select BR2_PACKAGE_LIBECORE
> -	depends on BR2_TOOLCHAIN_HAS_THREADS
> -	help
> -	  Eio integrates with EFL (Ecore, Eina) to provide efficient
> -	  filesystem Input/Output (I/O). It use the best techniques to
> -	  achieve such purpose, like using at-variants, splice,
> -	  properly handling errors and doing it in an asynchronous
> -	  fashion by means of worker threads. It is also ported to
> -	  Windows, so multi-platform.
> -
> -	  Whenever you need to list a directory, copy, move or delete
> -	  files, Eio will do that task better than you'd achieve with
> -	  naive implementations, and it is easy to use.
> -
> -	  http://trac.enlightenment.org/e/wiki/Eio
> -
> -comment "libeio needs a toolchain w/ threads"
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/efl/libeio/libeio.mk b/package/efl/libeio/libeio.mk
> deleted file mode 100644
> index e687c32..0000000
> --- a/package/efl/libeio/libeio.mk
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -################################################################################
> -#
> -# libeio
> -#
> -################################################################################
> -
> -LIBEIO_VERSION = 1.7.10
> -LIBEIO_SOURCE = eio-$(LIBEIO_VERSION).tar.bz2
> -LIBEIO_SITE = http://download.enlightenment.org/releases
> -LIBEIO_LICENSE = LGPLv2.1
> -LIBEIO_LICENSE_FILES = COPYING
> -
> -LIBEIO_INSTALL_STAGING = YES
> -LIBEIO_DEPENDENCIES = libeina libeet libecore
> -
> -$(eval $(autotools-package))
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 30/36] package/efl/libefreet: remove package
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 30/36] package/efl/libefreet: " Romain Naour
@ 2015-10-25 16:45   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:45 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> Libefreet is now available in efl package.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Still the same comment as for previous removals. ;-)

Regards,
Yann E. MORIN.

> ---
> v5: remove libefreet directory
> v4: update Config.in to use libefl
> v3: update legacy option for 2015.11
>     update help text
> ---
>  Config.in.legacy                   |  7 +++++++
>  package/efl/Config.in              |  1 -
>  package/efl/libefreet/Config.in    | 10 ----------
>  package/efl/libefreet/libefreet.mk | 17 -----------------
>  4 files changed, 7 insertions(+), 28 deletions(-)
>  delete mode 100644 package/efl/libefreet/Config.in
>  delete mode 100644 package/efl/libefreet/libefreet.mk
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index feda47b..e8b6579 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -107,6 +107,13 @@ endif
>  ###############################################################################
>  comment "Legacy options removed in 2015.11"
>  
> +config BR2_PACKAGE_LIBEFREET
> +	bool "libefreet package has been removed"
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_EFL
> +	help
> +	  The libefreet package has been removed with the efl bump to 1.15.
> +
>  config BR2_PACKAGE_LIBEIO
>  	bool "libeio package has been removed"
>  	select BR2_LEGACY
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index 9d258eb..ba71705 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -18,7 +18,6 @@ source "package/efl/libeina/Config.in"
>  source "package/efl/libecore/Config.in"
>  source "package/efl/libeet/Config.in"
>  source "package/efl/libefl/Config.in"
> -source "package/efl/libefreet/Config.in"
>  source "package/efl/libevas/Config.in"
>  source "package/efl/libelementary/Config.in"
>  source "package/efl/libedbus/Config.in"
> diff --git a/package/efl/libefreet/Config.in b/package/efl/libefreet/Config.in
> deleted file mode 100644
> index 8687db4..0000000
> --- a/package/efl/libefreet/Config.in
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -config BR2_PACKAGE_LIBEFREET
> -	bool "libefreet"
> -	select BR2_PACKAGE_LIBEINA
> -	select BR2_PACKAGE_LIBEET
> -	select BR2_PACKAGE_LIBECORE
> -	help
> -	  Efreet is a library designed to help apps work with several of the
> -	  Freedesktop.org standards regarding Icons, Desktop files and Menus.
> -
> -	  http://trac.enlightenment.org/e/wiki/Efreet
> diff --git a/package/efl/libefreet/libefreet.mk b/package/efl/libefreet/libefreet.mk
> deleted file mode 100644
> index 65dbd12..0000000
> --- a/package/efl/libefreet/libefreet.mk
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -################################################################################
> -#
> -# libefreet
> -#
> -################################################################################
> -
> -LIBEFREET_VERSION = 1.7.10
> -LIBEFREET_SOURCE = efreet-$(LIBEFREET_VERSION).tar.bz2
> -LIBEFREET_SITE = http://download.enlightenment.org/releases
> -LIBEFREET_LICENSE = BSD-2c
> -LIBEFREET_LICENSE_FILES = COPYING
> -
> -LIBEFREET_INSTALL_STAGING = YES
> -
> -LIBEFREET_DEPENDENCIES = libeina libeet libecore
> -
> -$(eval $(autotools-package))
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 31/36] package/efl/libedbus: remove package
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 31/36] package/efl/libedbus: " Romain Naour
@ 2015-10-25 16:46   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:46 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> Libedbus is now available in efl package.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Guess what? ;-)

Regards,
Yann E. MORIN.

> ---
> v5: remove libedbus directory
> v3: update legacy option for 2015.11
>     update help text
> ---
>  Config.in.legacy                 |  7 +++++++
>  package/efl/Config.in            |  1 -
>  package/efl/libedbus/Config.in   | 44 ----------------------------------------
>  package/efl/libedbus/libedbus.mk | 37 ---------------------------------
>  4 files changed, 7 insertions(+), 82 deletions(-)
>  delete mode 100644 package/efl/libedbus/Config.in
>  delete mode 100644 package/efl/libedbus/libedbus.mk
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index e8b6579..bba5086 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -107,6 +107,13 @@ endif
>  ###############################################################################
>  comment "Legacy options removed in 2015.11"
>  
> +config BR2_PACKAGE_LIBEDBUS
> +	bool "libedbus package has been removed"
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_EFL
> +	help
> +	  The libedbus package has been removed with the efl bump to 1.15.
> +
>  config BR2_PACKAGE_LIBEFREET
>  	bool "libefreet package has been removed"
>  	select BR2_LEGACY
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index ba71705..3092c8f 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -20,7 +20,6 @@ source "package/efl/libeet/Config.in"
>  source "package/efl/libefl/Config.in"
>  source "package/efl/libevas/Config.in"
>  source "package/efl/libelementary/Config.in"
> -source "package/efl/libedbus/Config.in"
>  
>  endif # BR2_PACKAGE_EFL
>  
> diff --git a/package/efl/libedbus/Config.in b/package/efl/libedbus/Config.in
> deleted file mode 100644
> index 7e862d3..0000000
> --- a/package/efl/libedbus/Config.in
> +++ /dev/null
> @@ -1,44 +0,0 @@
> -config BR2_PACKAGE_LIBEDBUS
> -	bool "libedbus"
> -	select BR2_PACKAGE_LIBEINA
> -	select BR2_PACKAGE_LIBECORE
> -	select BR2_PACKAGE_DBUS
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus
> -	depends on BR2_USE_MMU # dbus
> -	help
> -	  E_Dbus is a set of wrappers around D-Bus APIs so they can be
> -	  easily used by EFL applications, automatically providing
> -	  Ecore/main loop integration, as well as Eina data types.
> -
> -	  http://trac.enlightenment.org/e/wiki/E_Dbus
> -
> -if BR2_PACKAGE_LIBEDBUS
> -
> -config BR2_PACKAGE_LIBEDBUS_BLUEZ
> -	bool "bluez support"
> -	depends on !BR2_STATIC_LIBS # bluez_utils
> -	depends on BR2_USE_WCHAR # bluez_utils -> glib2
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # bluez_utils -> glib2
> -	select BR2_PACKAGE_BLUEZ_UTILS
> -	help
> -	  Bluetooth support.
> -
> -comment "bluez support needs a toolchain w/ wchar, threads, dynamic library"
> -	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
> -
> -config BR2_PACKAGE_LIBEDBUS_CONNMAN
> -	bool "connman support"
> -	depends on BR2_PACKAGE_CONNMAN
> -	help
> -	  Connection manager support.
> -
> -config BR2_PACKAGE_LIBEDBUS_NOTIFY
> -	bool "notify support"
> -	help
> -	  Notify support.
> -
> -endif
> -
> -comment "libedbus needs a toolchain w/ threads"
> -	depends on BR2_USE_MMU
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/efl/libedbus/libedbus.mk b/package/efl/libedbus/libedbus.mk
> deleted file mode 100644
> index 634ceaf..0000000
> --- a/package/efl/libedbus/libedbus.mk
> +++ /dev/null
> @@ -1,37 +0,0 @@
> -################################################################################
> -#
> -# libedbus
> -#
> -################################################################################
> -
> -LIBEDBUS_VERSION = 1.7.10
> -LIBEDBUS_SOURCE = e_dbus-$(LIBEDBUS_VERSION).tar.bz2
> -LIBEDBUS_SITE = http://download.enlightenment.org/releases
> -LIBEDBUS_LICENSE = BSD-2c
> -LIBEDBUS_LICENSE_FILES = COPYING
> -
> -LIBEDBUS_INSTALL_STAGING = YES
> -
> -LIBEDBUS_DEPENDENCIES = host-pkgconf dbus libeina libecore
> -
> -ifeq ($(BR2_PACKAGE_LIBEDBUS_BLUEZ),y)
> -LIBEDBUS_CONF_OPTS += --enable-ebluez
> -LIBEDBUS_DEPENDENCIES += bluez_utils
> -else
> -LIBEDBUS_CONF_OPTS += --disable-ebluez
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEDBUS_CONNMAN),y)
> -LIBEDBUS_CONF_OPTS += --enable-econnman0_7x
> -LIBEDBUS_DEPENDENCIES += connman
> -else
> -LIBEDBUS_CONF_OPTS += --disable-econnman0_7x
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEDBUS_NOTIFY),y)
> -LIBEDBUS_CONF_OPTS += --enable-enotify --disable-edbus-notify-test
> -else
> -LIBEDBUS_CONF_OPTS += --disable-enotify
> -endif
> -
> -$(eval $(autotools-package))
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 32/36] package/efl/libecore: remove package
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 32/36] package/efl/libecore: " Romain Naour
@ 2015-10-25 16:50   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:50 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> Libecore is now available in efl package.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Aha! This time I have a completely different comment! ;-)

    $ git grep BR2_PACKAGE_LIBECORE
    Config.in.legacy:config BR2_PACKAGE_LIBECORE
    package/dbus-cpp/dbus-cpp.mk:ifeq ($(BR2_PACKAGE_LIBECORE),y)

Aha... ;-)

I gues you should switch dbus-cpp to use libefl and then start removing
the old EFL packages. I.e. just before removing libethumb.

Regards,
Yann E. MORIN.

> ---
> v5: remove libecore directory
> v4: update Config.in to use libefl
> v3: update legacy option for 2015.11
>     update help text
> ---
>  Config.in.legacy                 |   7 +++
>  package/efl/Config.in            |   1 -
>  package/efl/libecore/Config.in   |  46 ----------------
>  package/efl/libecore/libecore.mk | 114 ---------------------------------------
>  4 files changed, 7 insertions(+), 161 deletions(-)
>  delete mode 100644 package/efl/libecore/Config.in
>  delete mode 100644 package/efl/libecore/libecore.mk
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index bba5086..6c72a54 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -107,6 +107,13 @@ endif
>  ###############################################################################
>  comment "Legacy options removed in 2015.11"
>  
> +config BR2_PACKAGE_LIBECORE
> +	bool "libecore package has been removed"
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_EFL
> +	help
> +	  The libecore package has been removed with the efl bump to 1.15.
> +
>  config BR2_PACKAGE_LIBEDBUS
>  	bool "libedbus package has been removed"
>  	select BR2_LEGACY
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index 3092c8f..7bd73dc 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -15,7 +15,6 @@ menuconfig BR2_PACKAGE_EFL
>  if BR2_PACKAGE_EFL
>  
>  source "package/efl/libeina/Config.in"
> -source "package/efl/libecore/Config.in"
>  source "package/efl/libeet/Config.in"
>  source "package/efl/libefl/Config.in"
>  source "package/efl/libevas/Config.in"
> diff --git a/package/efl/libecore/Config.in b/package/efl/libecore/Config.in
> deleted file mode 100644
> index a9408dc..0000000
> --- a/package/efl/libecore/Config.in
> +++ /dev/null
> @@ -1,46 +0,0 @@
> -config BR2_PACKAGE_LIBECORE
> -	bool "libecore"
> -	select BR2_PACKAGE_LIBEINA
> -	help
> -	  Ecore is the event/X abstraction layer that makes doing
> -	  selections, Xdnd, general X stuff, event loops, timeouts and
> -	  idle handlers fast, optimized, and convenient.
> -
> -	  http://trac.enlightenment.org/e/wiki/Ecore
> -
> -if BR2_PACKAGE_LIBECORE
> -
> -config BR2_PACKAGE_LIBECORE_DIRECTFB
> -	bool "libecore DirectFB support"
> -	depends on BR2_PACKAGE_DIRECTFB
> -	default y
> -
> -config BR2_PACKAGE_LIBECORE_FB
> -	bool "libecore framebuffer support"
> -
> -config BR2_PACKAGE_LIBECORE_SDL
> -	bool "libecore SDL support"
> -	select BR2_PACKAGE_SDL
> -
> -config BR2_PACKAGE_LIBECORE_X
> -	bool "libecore X support"
> -	depends on BR2_PACKAGE_XORG7
> -	select BR2_PACKAGE_XLIB_LIBX11
> -	select BR2_PACKAGE_XLIB_LIBXEXT
> -
> -config BR2_PACKAGE_LIBECORE_X_XCB
> -	bool "libecore XCB support"
> -	depends on BR2_PACKAGE_XORG7
> -	select BR2_PACKAGE_LIBXCB
> -	select BR2_PACKAGE_XLIB_LIBX11
> -	select BR2_PACKAGE_XCB_UTIL
> -
> -config BR2_PACKAGE_LIBECORE_EVAS
> -	bool "libecore Evas support"
> -	select BR2_PACKAGE_LIBEVAS
> -	depends on BR2_TOOLCHAIN_HAS_THREADS
> -
> -comment "evas support needs a toolchain w/ threads"
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS
> -
> -endif # BR2_PACKAGE_LIBECORE
> diff --git a/package/efl/libecore/libecore.mk b/package/efl/libecore/libecore.mk
> deleted file mode 100644
> index b5016dc..0000000
> --- a/package/efl/libecore/libecore.mk
> +++ /dev/null
> @@ -1,114 +0,0 @@
> -################################################################################
> -#
> -# libecore
> -#
> -################################################################################
> -
> -LIBECORE_VERSION = 1.7.10
> -LIBECORE_SOURCE = ecore-$(LIBECORE_VERSION).tar.bz2
> -LIBECORE_SITE = http://download.enlightenment.org/releases
> -LIBECORE_LICENSE = BSD-2c
> -LIBECORE_LICENSE_FILES = COPYING
> -
> -LIBECORE_INSTALL_STAGING = YES
> -
> -LIBECORE_DEPENDENCIES = host-pkgconf libeina
> -
> -HOST_LIBECORE_DEPENDENCIES = host-pkgconf host-libeina host-libevas
> -HOST_LIBECORE_CONF_OPTS += 		\
> -	--enable-ecore-evas 		\
> -	--disable-simple-x11 		\
> -	--disable-ecore-directfb 	\
> -	--disable-ecore-x 		\
> -	--disable-ecore-x-xcb 		\
> -	--disable-ecore-imf-xim
> -
> -# default options
> -LIBECORE_CONF_OPTS = --disable-simple-x11
> -
> -ifeq ($(BR2_PACKAGE_TSLIB),y)
> -LIBECORE_DEPENDENCIES += tslib
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBGLIB2),y)
> -LIBECORE_DEPENDENCIES += libglib2
> -endif
> -
> -ifeq ($(BR2_PACKAGE_OPENSSL),y)
> -LIBECORE_DEPENDENCIES += openssl
> -LIBECORE_CONF_OPTS += --enable-openssl
> -else
> -LIBECORE_CONF_OPTS += --disable-openssl
> -endif
> -
> -ifeq ($(BR2_PACKAGE_GNUTLS)$(BR2_PACKAGE_LIBGCRYPT),yy)
> -LIBECORE_DEPENDENCIES += gnutls libgcrypt
> -LIBECORE_CONF_OPTS += --enable-gnutls --with-libgcrypt-prefix=$(STAGING_DIR)/usr
> -else
> -LIBECORE_CONF_OPTS += --disable-gnutls
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBCURL),y)
> -LIBECORE_DEPENDENCIES += libcurl
> -endif
> -
> -# libecore
> -ifeq ($(BR2_PACKAGE_LIBECORE_DIRECTFB),y)
> -LIBECORE_CONF_OPTS += --enable-ecore-directfb
> -LIBECORE_DEPENDENCIES += directfb
> -else
> -LIBECORE_CONF_OPTS += --disable-ecore-directfb
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBECORE_FB),y)
> -LIBECORE_CONF_OPTS += --enable-ecore-fb
> -else
> -LIBECORE_CONF_OPTS += --disable-ecore-fb
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBECORE_SDL),y)
> -LIBECORE_CONF_OPTS += --enable-ecore-sdl
> -LIBECORE_DEPENDENCIES += sdl
> -else
> -LIBECORE_CONF_OPTS += --disable-ecore-sdl
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBECORE_X),y)
> -LIBECORE_CONF_OPTS += --enable-ecore-x \
> -	--with-x=$(STAGING_DIR) \
> -	--x-includes=$(STAGING_DIR)/usr/include \
> -	--x-libraries=$(STAGING_DIR)/usr/lib
> -LIBECORE_DEPENDENCIES += xlib_libXext xlib_libX11
> -else
> -LIBECORE_CONF_OPTS += --disable-ecore-x --disable-ecore-imf-xim
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBECORE_X_XCB),y)
> -LIBECORE_CONF_OPTS += --enable-ecore-x-xcb
> -LIBECORE_DEPENDENCIES += libxcb xlib_libX11 xcb-util pixman
> -
> -# src/util/makekeys is executed at build time to generate
> -# ecore_xcb_keysym_table.h, so it should get compiled for the host.
> -# The ecore makefile unfortunately doesn't know about cross
> -# compilation so this doesn't work.  Long term, we should probably
> -# teach it about CC_FOR_BUILD, but for now simply build makekeys by
> -# hand in advance
> -define LIBECORE_BUILD_MAKEKEYS_FOR_HOST
> -	$(HOST_CONFIGURE_OPTS) $(MAKE1) -C $(@D)/src/util makekeys.o makekeys
> -endef
> -
> -LIBECORE_POST_EXTRACT_HOOKS += LIBECORE_BUILD_MAKEKEYS_FOR_HOST
> -else
> -LIBECORE_CONF_OPTS += --disable-ecore-x-xcb
> -endif
> -
> -# libecore-evas
> -ifeq ($(BR2_PACKAGE_LIBECORE_EVAS),y)
> -LIBECORE_CONF_OPTS += --enable-ecore-evas
> -LIBECORE_DEPENDENCIES += libevas
> -else
> -LIBECORE_CONF_OPTS += --disable-ecore-evas
> -endif
> -
> -$(eval $(autotools-package))
> -$(eval $(host-autotools-package))
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 33/36] package/efl/libevas: remove package
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 33/36] package/efl/libevas: " Romain Naour
@ 2015-10-25 16:52   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:52 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> Libevas is now available in efl package.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

OK, let's respin the old-times comment about the legacy comment. ;-)

Regards,
Yann E. MORIN.

> ---
> v5: remove libevas directory
> v4: update Config.in to use libefl
> v3: update legacy option for 2015.11
>     update help text
> ---
>  Config.in.legacy                      |   7 +
>  package/efl/Config.in                 |   1 -
>  package/efl/libevas/0001-giflib.patch |  98 --------------
>  package/efl/libevas/Config.in         | 211 -----------------------------
>  package/efl/libevas/libevas.mk        | 247 ----------------------------------
>  5 files changed, 7 insertions(+), 557 deletions(-)
>  delete mode 100644 package/efl/libevas/0001-giflib.patch
>  delete mode 100644 package/efl/libevas/Config.in
>  delete mode 100644 package/efl/libevas/libevas.mk
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 6c72a54..cb49112 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -107,6 +107,13 @@ endif
>  ###############################################################################
>  comment "Legacy options removed in 2015.11"
>  
> +config BR2_PACKAGE_LIBEVAS
> +	bool "libevas package has been removed"
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_EFL
> +	help
> +	  The libevas package has been removed with the efl bump to 1.15.
> +
>  config BR2_PACKAGE_LIBECORE
>  	bool "libecore package has been removed"
>  	select BR2_LEGACY
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index 7bd73dc..b35e666 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -17,7 +17,6 @@ if BR2_PACKAGE_EFL
>  source "package/efl/libeina/Config.in"
>  source "package/efl/libeet/Config.in"
>  source "package/efl/libefl/Config.in"
> -source "package/efl/libevas/Config.in"
>  source "package/efl/libelementary/Config.in"
>  
>  endif # BR2_PACKAGE_EFL
> diff --git a/package/efl/libevas/0001-giflib.patch b/package/efl/libevas/0001-giflib.patch
> deleted file mode 100644
> index 9342687..0000000
> --- a/package/efl/libevas/0001-giflib.patch
> +++ /dev/null
> @@ -1,98 +0,0 @@
> -Adjust source code to work with giflib 5.1x
> -
> -From http://giflib.sourceforge.net/gif_lib.html: GIF file openers and
> -closers - DGifOpenFileName(), DGifOpenFileHandle(), DGifOpen(),
> -DGifClose(), EGifOpenFileName(), EGifOpenFileHandle(), EGifOpen(), and
> -EGifClose() - all now take a final integer address argument. If
> -non-null, this is used to pass back an error code when the function
> -returns NULL.
> -
> -Downloaded from
> -http://commit.cvs.pld.groups.com.ru/332837-packagesevas_fix_building_with_giflib_51_rel_6
> -
> -Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> -
> -diff -uNr evas-1.7.10.org/src/modules/loaders/gif/evas_image_load_gif.c evas-1.7.10/src/modules/loaders/gif/evas_image_load_gif.c
> ---- evas-1.7.10.org/src/modules/loaders/gif/evas_image_load_gif.c	2013-08-01 17:41:35.000000000 +0200
> -+++ evas-1.7.10/src/modules/loaders/gif/evas_image_load_gif.c	2015-01-26 19:44:20.132955194 +0100
> -@@ -338,7 +338,7 @@
> - 
> -    if (!cmap)
> -      {
> --        DGifCloseFile(gif);
> -+        DGifCloseFile(gif, NULL);
> -         for (i = 0; i < scale_h; i++)
> -           {
> -              free(rows[i]);
> -@@ -725,7 +725,7 @@
> -    if ((w < 1) || (h < 1) || (w > IMG_MAX_SIZE) || (h > IMG_MAX_SIZE) ||
> -        IMG_TOO_BIG(w, h))
> -      {
> --        DGifCloseFile(gif);
> -+        DGifCloseFile(gif, NULL);
> -         if (IMG_TOO_BIG(w, h))
> -           *error = EVAS_LOAD_ERROR_RESOURCE_ALLOCATION_FAILED;
> -         else
> -@@ -740,7 +740,7 @@
> -         if (DGifGetRecordType(gif, &rec) == GIF_ERROR)
> -           {
> -              /* PrintGifError(); */
> --             DGifCloseFile(gif);
> -+             DGifCloseFile(gif, NULL);
> -              *error = EVAS_LOAD_ERROR_UNKNOWN_FORMAT;
> -              return EINA_FALSE;
> -           }
> -@@ -754,7 +754,7 @@
> -              if (DGifGetImageDesc(gif) == GIF_ERROR)
> -                {
> -                   /* PrintGifError(); */
> --                  DGifCloseFile(gif);
> -+                  DGifCloseFile(gif, NULL);
> -                   *error = EVAS_LOAD_ERROR_UNKNOWN_FORMAT;
> -                   return EINA_FALSE;
> -                }
> -@@ -762,7 +762,7 @@
> -              if (DGifGetCode(gif, &img_code, &img) == GIF_ERROR)
> -                {
> -                   /* PrintGifError(); */
> --                  DGifCloseFile(gif);
> -+                  DGifCloseFile(gif, NULL);
> -                   *error = EVAS_LOAD_ERROR_UNKNOWN_FORMAT;
> -                   return EINA_FALSE;
> -                }
> -@@ -818,7 +818,7 @@
> -         ie->frames = NULL;
> -      }
> - 
> --   DGifCloseFile(gif);
> -+   DGifCloseFile(gif, NULL);
> -    *error = EVAS_LOAD_ERROR_NONE;
> -    return EINA_TRUE;
> - }
> -@@ -885,7 +885,7 @@
> -      }
> - 
> -    ie->frames = eina_list_append(ie->frames, frame);
> --   DGifCloseFile(gif);
> -+   DGifCloseFile(gif, NULL);
> -    return EINA_TRUE;
> - }
> - 
> -@@ -959,7 +959,7 @@
> -                   *error = EVAS_LOAD_ERROR_UNKNOWN_FORMAT;
> -                   return EINA_FALSE;
> -                }
> --             DGifCloseFile(gif);
> -+             DGifCloseFile(gif, NULL);
> -              *error = EVAS_LOAD_ERROR_NONE;
> -              return EINA_TRUE;
> -           }
> -@@ -1080,7 +1080,7 @@
> -          }
> -      } while (rec != TERMINATE_RECORD_TYPE);
> - 
> --   DGifCloseFile(gif);
> -+   DGifCloseFile(gif, NULL);
> -    return duration;
> - }
> - 
> diff --git a/package/efl/libevas/Config.in b/package/efl/libevas/Config.in
> deleted file mode 100644
> index 6645a14..0000000
> --- a/package/efl/libevas/Config.in
> +++ /dev/null
> @@ -1,211 +0,0 @@
> -comment "libevas needs a toolchain w/ threads"
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS
> -
> -config BR2_PACKAGE_LIBEVAS
> -	bool "libevas"
> -	# libevas should normally build without threads, but due to a
> -	# build issue when the async preloader is disabled, which is
> -	# needed when no threads are available, we don't allow evas to
> -	# be built without threads. This should be revisited when efl
> -	# is bumped to 1.8.
> -	depends on BR2_TOOLCHAIN_HAS_THREADS
> -	select BR2_PACKAGE_FREETYPE
> -	select BR2_PACKAGE_LIBEINA
> -	# required to build so far
> -	select BR2_PACKAGE_LIBEVAS_SCALE_SMOOTH
> -	help
> -	  Evas is a clean display canvas API for several target
> -	  display systems that can draw anti-aliased text, smooth
> -	  super and sub-sampled scaled images, alpha-blend objects
> -	  much and more.
> -
> -	  http://trac.enlightenment.org/e/wiki/Evas
> -
> -if BR2_PACKAGE_LIBEVAS
> -
> -comment "libevas rendering options"
> -
> -config BR2_PACKAGE_LIBEVAS_SCALE_SAMPLE
> -	bool "libevas sampling scaler"
> -	help
> -	  This enables the sampling scaler code. This is the fastest
> -	  image scaling code, but also the lowest quality.
> -
> -config BR2_PACKAGE_LIBEVAS_SCALE_SMOOTH
> -	bool "libevas smooth scaler"
> -	help
> -	  This is the nicest looking scaler that is not that much
> -	  slower than tri-linear, but it looks really good.
> -
> -config BR2_PACKAGE_LIBEVAS_SMALL_DITHERING
> -	bool "libevas small dithering"
> -	help
> -	  This uses a 4x4 dither mask instead of 128x128. On desktop
> -	  boxes these days (Pentium, Pentium2, amd etc.) the speed
> -	  difference is not really measurable, but the quality of the
> -	  128x128 dither mask is quite a lot better.
> -
> -config BR2_PACKAGE_LIBEVAS_LINE_DITHERING
> -	bool "libevas line dithering"
> -
> -config BR2_PACKAGE_LIBEVAS_NO_DITHERING
> -	bool "libevas no dithering"
> -
> -
> -comment "libevas backends"
> -
> -config BR2_PACKAGE_LIBEVAS_BUFFER
> -	bool "libevas buffer backend"
> -	help
> -	  This enables the software buffer rendering engine. There is
> -	  no hardware assist here.
> -
> -config BR2_PACKAGE_LIBEVAS_DIRECTFB
> -	bool "libevas DirectFB backend"
> -	depends on BR2_PACKAGE_DIRECTFB
> -	default y
> -	help
> -	  This is the DirectFB engine that uses the DirectFB library
> -	  (http://www.directfb.org) on Linux to access the framebuffer
> -	  with (or maybe without) acceleration.
> -
> -config BR2_PACKAGE_LIBEVAS_FB
> -	bool "libevas frame buffer backend"
> -	help
> -	  This is the software framebuffer driving engine. this uses
> -	  the linux framebuffer device (/dev/fb<x>) and will currently
> -	  just inherit the current framebuffer settings on the fb
> -	  device and use them to run in.
> -
> -config BR2_PACKAGE_LIBEVAS_SDL
> -	bool "libevas SDL backend"
> -	select BR2_PACKAGE_SDL
> -	help
> -	  This is the software SDL engine that uses SDL library
> -	  (http://www.libsdl.org). This library should work on many
> -	  operating systems.
> -
> -config BR2_PACKAGE_LIBEVAS_SDL_GL
> -	bool "libevas SDL OpenGL backend"
> -	depends on BR2_PACKAGE_SDL_X11
> -	depends on BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR # mesa needs big X
> -	help
> -	  This is the SDL OpenGL engine that uses SDL library
> -	  and OpenGL to render. This may be hardware accelerated.
> -
> -comment "SDL OpenGL backend needs modular X.org and X11 support in SDL"
> -	depends on !(BR2_PACKAGE_SDL_X11 && BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR)
> -
> -config BR2_PACKAGE_LIBEVAS_X11
> -	bool "libevas X11 backend"
> -	depends on BR2_PACKAGE_XORG7
> -	select BR2_PACKAGE_XLIB_LIBX11
> -	select BR2_PACKAGE_XLIB_LIBXEXT
> -	help
> -	  This enables the software X11 rendering engine that renders
> -	  to X drawable targets using highly optimised software
> -	  routines. There is no hardware assist here.
> -
> -config BR2_PACKAGE_LIBEVAS_X11_GLX
> -	bool "libevas X11 GLX backend"
> -	depends on BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR # mesa needs big X
> -	select BR2_PACKAGE_XLIB_LIBX11
> -	select BR2_PACKAGE_XLIB_LIBXRENDER
> -	select BR2_PACKAGE_XLIB_LIBXEXT
> -	select BR2_PACKAGE_XPROTO_GLPROTO
> -	help
> -	  This enables the OpenGL X11 rendering engine that renders
> -	  using GLX which may be hardware accelerated.
> -
> -config BR2_PACKAGE_LIBEVAS_XCB
> -	bool "libevas XCB backend"
> -	depends on BR2_PACKAGE_XORG7
> -	select BR2_PACKAGE_LIBXCB
> -	select BR2_PACKAGE_XCB_UTIL
> -	select BR2_PACKAGE_XCB_PROTO
> -	select BR2_PACKAGE_PIXMAN
> -	help
> -	  This enable the software XCB rendering engine. It allows the
> -	  same features than the software X11 engine.
> -
> -config BR2_PACKAGE_LIBEVAS_XCB_GLX
> -	bool "libevas XCB GLX backend"
> -	depends on BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR # mesa needs big X
> -	select BR2_PACKAGE_LIBXCB
> -	select BR2_PACKAGE_XCB_UTIL
> -	select BR2_PACKAGE_XCB_PROTO
> -	select BR2_PACKAGE_XPROTO_GLPROTO
> -	help
> -	  This enables the OpenGL X11 XCB rendering engine that renders
> -	  using GLX which may be hardware accelerated.
> -
> -choice
> -	prompt "libevas OpenGL flavor"
> -	depends on BR2_PACKAGE_LIBEVAS_SDL_GL || BR2_PACKAGE_LIBEVAS_X11_GLX || BR2_PACKAGE_LIBEVAS_XCB_GLX
> -	default BR2_PACKAGE_LIBEVAS_GL
> -
> -config BR2_PACKAGE_LIBEVAS_GL
> -	bool "generic OpenGL"
> -	depends on BR2_PACKAGE_HAS_LIBGL
> -	select BR2_PACKAGE_LIBEET
> -
> -config BR2_PACKAGE_LIBEVAS_GLES_SGX
> -	bool "OpenGL-ES SGX"
> -
> -config BR2_PACKAGE_LIBEVAS_GLES_S3C6410
> -	bool "OpenGL-ES S3C6410"
> -endchoice
> -
> -
> -comment "libevas loaders"
> -
> -config BR2_PACKAGE_LIBEVAS_PNG
> -	bool "libevas png loader"
> -	select BR2_PACKAGE_LIBPNG
> -	help
> -	  This enables the loader code that loads png files using
> -	  libpng.
> -
> -config BR2_PACKAGE_LIBEVAS_JPEG
> -	bool "libevas jpeg loader"
> -	select BR2_PACKAGE_JPEG
> -	help
> -	  This enables the loader code that loads jpeg files using
> -	  libjpeg.
> -
> -config BR2_PACKAGE_LIBEVAS_GIF
> -	bool "libevas gif loader"
> -	select BR2_PACKAGE_GIFLIB
> -	help
> -	  This enables the loader code that loads gif files using
> -	  libungif.
> -
> -config BR2_PACKAGE_LIBEVAS_PMAPS
> -	bool "libevas pmaps loader"
> -	help
> -	  This enables the loader code that loads pmaps files.
> -
> -config BR2_PACKAGE_LIBEVAS_TIFF
> -	bool "libevas tiff loader"
> -	select BR2_PACKAGE_TIFF
> -	help
> -	  This enables the loader code that loads tiff files.
> -
> -config BR2_PACKAGE_LIBEVAS_XPM
> -	bool "libevas xpm loader"
> -	help
> -	  This enables the loader code that loads xpm files.
> -
> -config BR2_PACKAGE_LIBEVAS_EET
> -	bool "libevas eet image loader"
> -	select BR2_PACKAGE_LIBEET
> -	help
> -	  This enables the loader code that loads images using libeet.
> -
> -config BR2_PACKAGE_LIBEVAS_EET_FONT
> -	bool "libevas eet font loader"
> -	select BR2_PACKAGE_LIBEET
> -	help
> -	  This enables the loader code that loads fonts using libeet.
> -
> -endif # BR2_PACKAGE_LIBEVAS
> diff --git a/package/efl/libevas/libevas.mk b/package/efl/libevas/libevas.mk
> deleted file mode 100644
> index 9adb128..0000000
> --- a/package/efl/libevas/libevas.mk
> +++ /dev/null
> @@ -1,247 +0,0 @@
> -################################################################################
> -#
> -# libevas
> -#
> -################################################################################
> -
> -LIBEVAS_VERSION = 1.7.10
> -LIBEVAS_SOURCE = evas-$(LIBEVAS_VERSION).tar.bz2
> -LIBEVAS_SITE = http://download.enlightenment.org/releases
> -LIBEVAS_LICENSE = BSD-2c
> -LIBEVAS_LICENSE_FILES = COPYING
> -
> -LIBEVAS_INSTALL_STAGING = YES
> -
> -LIBEVAS_DEPENDENCIES = host-pkgconf zlib libeina freetype
> -
> -HOST_LIBEVAS_DEPENDENCIES = \
> -	host-pkgconf host-zlib host-libeina \
> -	host-freetype host-libpng host-libjpeg
> -HOST_LIBEVAS_CONF_OPTS += \
> -	--enable-image-loader-png \
> -	--enable-image-loader-jpeg \
> -	--disable-image-loader-gif \
> -	--disable-image-loader-tiff \
> -	--disable-image-loader-eet \
> -	--disable-font-loader-eet \
> -	--disable-cpu-sse3 \
> -	--disable-software-sdl \
> -	--disable-gl-sdl \
> -	--disable-software-xlib \
> -	--disable-gl-xlib \
> -	--enable-software-xcb \
> -	--disable-gl-xcb
> -
> -# rendering options
> -ifeq ($(BR2_PACKAGE_LIBEVAS_SCALE_SAMPLE),y)
> -LIBEVAS_CONF_OPTS += --enable-scale-sample
> -else
> -LIBEVAS_CONF_OPTS += --disable-scale-sample
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_SCALE_SMOOTH),y)
> -LIBEVAS_CONF_OPTS += --enable-scale-smooth
> -else
> -LIBEVAS_CONF_OPTS += --disable-scale-smooth
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_SMALL_DITHERING),y)
> -LIBEVAS_CONF_OPTS += --enable-small-dither-mask
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_LINE_DITHERING),y)
> -LIBEVAS_CONF_OPTS += --enable-line-dither-mask
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_NO_DITHERING),y)
> -LIBEVAS_CONF_OPTS += --enable-no-dither-mask
> -endif
> -
> -# backends
> -ifeq ($(BR2_PACKAGE_LIBEVAS_BUFFER),y)
> -LIBEVAS_CONF_OPTS += --enable-buffer
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_X11),y)
> -LIBEVAS_CONF_OPTS += --enable-software-xlib \
> -	--with-x=$(STAGING_DIR) \
> -	--x-includes=$(STAGING_DIR)/usr/include \
> -	--x-libraries=$(STAGING_DIR)/usr/lib
> -LIBEVAS_DEPENDENCIES += xlib_libX11 xlib_libXext
> -else
> -LIBEVAS_CONF_OPTS += --disable-software-xlib
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_X11_GLX),y)
> -LIBEVAS_CONF_OPTS += --enable-gl-xlib
> -LIBEVAS_DEPENDENCIES += \
> -	xproto_glproto xlib_libX11 xlib_libXrender \
> -	xlib_libXext libeet
> -else
> -LIBEVAS_CONF_OPTS += --disable-gl-xlib
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_XCB),y)
> -LIBEVAS_CONF_OPTS += --enable-software-xcb
> -LIBEVAS_DEPENDENCIES += libxcb xcb-proto xcb-util pixman
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_XCB_GLX),y)
> -LIBEVAS_CONF_OPTS += --enable-gl-xcb
> -LIBEVAS_DEPENDENCIES += libxcb xcb-proto xcb-util xproto_glproto
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_FB),y)
> -LIBEVAS_CONF_OPTS += --enable-fb
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_DIRECTFB),y)
> -LIBEVAS_CONF_OPTS += --enable-directfb
> -LIBEVAS_DEPENDENCIES += directfb
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_SDL),y)
> -LIBEVAS_CONF_OPTS += --enable-software-sdl
> -LIBEVAS_DEPENDENCIES += sdl
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_SDL_GL),y)
> -LIBEVAS_CONF_OPTS += --enable-gl-sdl
> -LIBEVAS_DEPENDENCIES += sdl
> -# configure script forgets to check for eet / fill this out
> -LIBEVAS_CONF_ENV += \
> -	GL_EET_CFLAGS='-I$(STAGING_DIR)/usr/include/eet-1' \
> -	GL_EET_LIBS='-leet'
> -endif
> -
> -# libevas OpenGL flavor
> -ifeq ($(BR2_PACKAGE_LIBEVAS_GL),y)
> -LIBEVAS_DEPENDENCIES += mesa3d libeet
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_GLES_SGX),y)
> -LIBEVAS_CONF_OPTS += --enable-gl-flavor-gles --enable-gles-variety-sgx
> -else
> -LIBEVAS_CONF_OPTS += --disable-gles-variety-sgx
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_GLES_S3C6410),y)
> -LIBEVAS_CONF_OPTS += --enable-gl-flavor-gles --enable-gles-variety-s3c6410
> -else
> -LIBEVAS_CONF_OPTS += --disable-gles-variety-s3c6410
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_GLES_SGX)$(BR2_PACKAGE_LIBEVAS_GLES_S3C6410),)
> -LIBEVAS_CONF_OPTS += --disable-gl-flavor-gles
> -endif
> -
> -# code options
> -ifeq ($(BR2_X86_CPU_HAS_MMX),y)
> -LIBEVAS_CONF_OPTS += --enable-cpu-mmx
> -else
> -LIBEVAS_CONF_OPTS += --disable-cpu-mmx
> -endif
> -
> -ifeq ($(BR2_X86_CPU_HAS_SSE),y)
> -LIBEVAS_CONF_OPTS += --enable-cpu-sse
> -else
> -LIBEVAS_CONF_OPTS += --disable-cpu-sse
> -endif
> -
> -ifeq ($(BR2_X86_CPU_HAS_SSE3),y)
> -LIBEVAS_CONF_OPTS += --enable-cpu-sse3
> -else
> -LIBEVAS_CONF_OPTS += --disable-cpu-sse3
> -endif
> -
> -ifeq ($(BR2_POWERPC_CPU_HAS_ALTIVEC),y)
> -LIBEVAS_CONF_OPTS += --enable-cpu-altivec
> -else
> -LIBEVAS_CONF_OPTS += --disable-cpu-altivec
> -endif
> -
> -ifeq ($(BR2_ARM_CPU_HAS_NEON),y)
> -LIBEVAS_CONF_OPTS += --enable-cpu-neon
> -else
> -LIBEVAS_CONF_OPTS += --disable-cpu-neon
> -endif
> -
> -# loaders
> -ifeq ($(BR2_PACKAGE_LIBEVAS_PNG),y)
> -LIBEVAS_CONF_OPTS += --enable-image-loader-png
> -LIBEVAS_DEPENDENCIES += libpng
> -else
> -LIBEVAS_CONF_OPTS += --disable-image-loader-png
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_JPEG),y)
> -LIBEVAS_CONF_OPTS += --enable-image-loader-jpeg
> -LIBEVAS_DEPENDENCIES += jpeg
> -else
> -LIBEVAS_CONF_OPTS += --disable-image-loader-jpeg
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_GIF),y)
> -LIBEVAS_CONF_OPTS += --enable-image-loader-gif
> -LIBEVAS_DEPENDENCIES += giflib
> -else
> -LIBEVAS_CONF_OPTS += --disable-image-loader-gif
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_PMAPS),y)
> -LIBEVAS_CONF_OPTS += --enable-image-loader-pmaps
> -else
> -LIBEVAS_CONF_OPTS += --disable-image-loader-pmaps
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_TIFF),y)
> -LIBEVAS_CONF_OPTS += --enable-image-loader-tiff
> -LIBEVAS_DEPENDENCIES += tiff
> -else
> -LIBEVAS_CONF_OPTS += --disable-image-loader-tiff
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_XPM),y)
> -LIBEVAS_CONF_OPTS += --enable-image-loader-xpm
> -else
> -LIBEVAS_CONF_OPTS += --disable-image-loader-xpm
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_EET),y)
> -LIBEVAS_CONF_OPTS += --enable-image-loader-eet
> -LIBEVAS_DEPENDENCIES += libeet
> -else
> -LIBEVAS_CONF_OPTS += --disable-image-loader-eet
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEVAS_EET_FONT),y)
> -LIBEVAS_CONF_OPTS += --enable-font-loader-eet
> -LIBEVAS_DEPENDENCIES += libeet
> -else
> -LIBEVAS_CONF_OPTS += --disable-font-loader-eet
> -endif
> -
> -ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
> -LIBEVAS_CONF_OPTS += --enable-fontconfig
> -LIBEVAS_DEPENDENCIES += fontconfig
> -else
> -LIBEVAS_CONF_OPTS += --disable-fontconfig
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBFRIBIDI),y)
> -LIBEVAS_CONF_OPTS += --enable-fribidi
> -LIBEVAS_DEPENDENCIES += libfribidi
> -else
> -LIBEVAS_CONF_OPTS += --disable-fribidi
> -endif
> -
> -# libevas installs the source code of examples on the target, which
> -# are generally not useful.
> -define LIBEVAS_REMOVE_EXAMPLES
> -	rm -rf $(TARGET_DIR)/usr/share/evas/examples/
> -endef
> -
> -LIBEVAS_POST_INSTALL_TARGET_HOOKS += LIBEVAS_REMOVE_EXAMPLES
> -
> -$(eval $(autotools-package))
> -$(eval $(host-autotools-package))
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 34/36] package/efl/libeet: remove package
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 34/36] package/efl/libeet: " Romain Naour
@ 2015-10-25 16:52   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:52 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> Libeet is now available in efl package.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Oh, BTW, I think I had a comment about a comment... ;-)

Regards,
Yann E. MORIN.

> ---
> v5: remove libeet directory
> v4: update Config.in to use libefl
> v3: update legacy option for 2015.11
>     update help text
> ---
>  Config.in.legacy             |  7 +++++++
>  package/efl/Config.in        |  1 -
>  package/efl/libeet/Config.in | 11 -----------
>  package/efl/libeet/libeet.mk | 27 ---------------------------
>  4 files changed, 7 insertions(+), 39 deletions(-)
>  delete mode 100644 package/efl/libeet/Config.in
>  delete mode 100644 package/efl/libeet/libeet.mk
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index cb49112..14da2f2 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -107,6 +107,13 @@ endif
>  ###############################################################################
>  comment "Legacy options removed in 2015.11"
>  
> +config BR2_PACKAGE_LIBEET
> +	bool "libeet package has been removed"
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_EFL
> +	help
> +	  The libeet package has been removed with the efl bump to 1.15.
> +
>  config BR2_PACKAGE_LIBEVAS
>  	bool "libevas package has been removed"
>  	select BR2_LEGACY
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index b35e666..9e92a6e 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -15,7 +15,6 @@ menuconfig BR2_PACKAGE_EFL
>  if BR2_PACKAGE_EFL
>  
>  source "package/efl/libeina/Config.in"
> -source "package/efl/libeet/Config.in"
>  source "package/efl/libefl/Config.in"
>  source "package/efl/libelementary/Config.in"
>  
> diff --git a/package/efl/libeet/Config.in b/package/efl/libeet/Config.in
> deleted file mode 100644
> index 48631a0..0000000
> --- a/package/efl/libeet/Config.in
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -config BR2_PACKAGE_LIBEET
> -	bool "libeet"
> -	select BR2_PACKAGE_ZLIB
> -	select BR2_PACKAGE_JPEG
> -	select BR2_PACKAGE_LIBEINA
> -	help
> -	  Eet is a tiny library designed to write an arbitary set of
> -	  chunks of data to a file and optionally compress each chunk
> -	  (very much like a zip file).
> -
> -	  http://trac.enlightenment.org/e/wiki/Eet
> diff --git a/package/efl/libeet/libeet.mk b/package/efl/libeet/libeet.mk
> deleted file mode 100644
> index fc3d7f9..0000000
> --- a/package/efl/libeet/libeet.mk
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -################################################################################
> -#
> -# libeet
> -#
> -################################################################################
> -
> -LIBEET_VERSION = 1.7.10
> -LIBEET_SOURCE = eet-$(LIBEET_VERSION).tar.bz2
> -LIBEET_SITE = http://download.enlightenment.org/releases
> -LIBEET_LICENSE = BSD-2c
> -LIBEET_LICENSE_FILES = COPYING
> -
> -LIBEET_INSTALL_STAGING = YES
> -
> -LIBEET_DEPENDENCIES = host-pkgconf zlib jpeg libeina
> -HOST_LIBEET_DEPENDENCIES = host-pkgconf host-zlib host-libjpeg host-libeina
> -
> -ifeq ($(BR2_PACKAGE_GNUTLS)$(BR2_PACKAGE_LIBGCRYPT),yy)
> -LIBEET_DEPENDENCIES += gnutls libgcrypt
> -LIBEET_CONF_ENV += LIBGCRYPT_CONFIG=$(STAGING_DIR)/usr/bin/libgcrypt-config
> -LIBEET_CONF_OPTS += --enable-gnutls
> -else
> -LIBEET_CONF_OPTS += --disable-gnutls
> -endif
> -
> -$(eval $(autotools-package))
> -$(eval $(host-autotools-package))
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 35/36] package/efl/libeina: remove package
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 35/36] package/efl/libeina: " Romain Naour
@ 2015-10-25 16:56   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 16:56 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> Libeina is now available in efl package.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Oh... Comment...

/me is feeling like a grumpy old chap, always rehashing the same litany
again and again...

Regards,
Yann E. MORIN.

> ---
> v5: remove libeina directory
> v4: update Config.in to use libefl
> v3: update legacy option for 2015.11
>     update help text
> ---
>  Config.in.legacy               |  7 +++++++
>  package/efl/Config.in          |  1 -
>  package/efl/libeina/Config.in  |  6 ------
>  package/efl/libeina/libeina.mk | 18 ------------------
>  4 files changed, 7 insertions(+), 25 deletions(-)
>  delete mode 100644 package/efl/libeina/Config.in
>  delete mode 100644 package/efl/libeina/libeina.mk
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 14da2f2..d6cb451 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -107,6 +107,13 @@ endif
>  ###############################################################################
>  comment "Legacy options removed in 2015.11"
>  
> +config BR2_PACKAGE_LIBEINA
> +	bool "libeina package has been removed"
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_EFL
> +	help
> +	  The libeina package has been removed with the efl bump to 1.15.
> +
>  config BR2_PACKAGE_LIBEET
>  	bool "libeet package has been removed"
>  	select BR2_LEGACY
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index 9e92a6e..bddff8c 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -14,7 +14,6 @@ menuconfig BR2_PACKAGE_EFL
>  
>  if BR2_PACKAGE_EFL
>  
> -source "package/efl/libeina/Config.in"
>  source "package/efl/libefl/Config.in"
>  source "package/efl/libelementary/Config.in"
>  
> diff --git a/package/efl/libeina/Config.in b/package/efl/libeina/Config.in
> deleted file mode 100644
> index 80600ad..0000000
> --- a/package/efl/libeina/Config.in
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -config BR2_PACKAGE_LIBEINA
> -	bool "libeina"
> -	help
> -	  Eina is a tiny library to handle data types (list, hash, etc.)
> -
> -	  http://trac.enlightenment.org/e/wiki/Eina
> diff --git a/package/efl/libeina/libeina.mk b/package/efl/libeina/libeina.mk
> deleted file mode 100644
> index ae9f1c6..0000000
> --- a/package/efl/libeina/libeina.mk
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -################################################################################
> -#
> -# libeina
> -#
> -################################################################################
> -
> -LIBEINA_VERSION = 1.7.10
> -LIBEINA_SOURCE = eina-$(LIBEINA_VERSION).tar.bz2
> -LIBEINA_SITE = http://download.enlightenment.org/releases
> -LIBEINA_LICENSE = LGPLv2.1+
> -LIBEINA_LICENSE_FILES = COPYING
> -
> -LIBEINA_INSTALL_STAGING = YES
> -
> -LIBEINA_DEPENDENCIES = host-pkgconf
> -
> -$(eval $(autotools-package))
> -$(eval $(host-autotools-package))
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 36/36] package/libemotion-generic-players: new package
  2015-10-24 21:01 ` [Buildroot] [PATCH v5 36/36] package/libemotion-generic-players: new package Romain Naour
@ 2015-10-25 17:04   ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 17:04 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
[--SNIP--]
> diff --git a/package/libemotion-generic-players/Config.in b/package/libemotion-generic-players/Config.in
> new file mode 100644
> index 0000000..71bca42
> --- /dev/null
> +++ b/package/libemotion-generic-players/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_LIBEMOTION_GENERIC_PLAYERS
> +	bool "libemotion generic players"
> +	select BR2_PACKAGE_VLC # needs libvlc
> +	depends on BR2_PACKAGE_EFL
> +	depends on BR2_TOOLCHAIN_USES_GLIBC # vlc
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7 # vlc

Please put the depends before the selects. ;-)

Also, you forgot a *lot* of VLC dependencies. Please propagate all of
them.

> +	help
> +	  A media object library for Evas and Ecore.
> +
> +	  https://www.enlightenment.org
> +	  https://docs.enlightenment.org/stable/efl/emotion_main.html
> +
> +comment "libemotion generic players needs a (e)glibc toolchain"
> +	depends on !BR2_TOOLCHAIN_USES_GLIBC
> +	depends on BR2_USE_MMU
> diff --git a/package/libemotion-generic-players/libemotion-generic-players.hash b/package/libemotion-generic-players/libemotion-generic-players.hash
> new file mode 100644
> index 0000000..80c8123
> --- /dev/null
> +++ b/package/libemotion-generic-players/libemotion-generic-players.hash
> @@ -0,0 +1,2 @@
> +# From https://download.enlightenment.org/rel/libs/emotion_generic_players/emotion_generic_players-1.15.0.tar.xz.sha256
> +sha256	9f6d5e9041ac7c014d663dac56d1b39ac42a45abe954d09d0edbf6e759e55f5f	emotion_generic_players-1.15.0.tar.xz
> diff --git a/package/libemotion-generic-players/libemotion-generic-players.mk b/package/libemotion-generic-players/libemotion-generic-players.mk
> new file mode 100644
> index 0000000..70b8ba3
> --- /dev/null
> +++ b/package/libemotion-generic-players/libemotion-generic-players.mk
> @@ -0,0 +1,17 @@
> +################################################################################
> +#
> +# libemotion-generic-players
> +#
> +################################################################################
> +
> +LIBEMOTION_GENERIC_PLAYERS_VERSION = 1.15.0
> +LIBEMOTION_GENERIC_PLAYERS_SOURCE = emotion_generic_players-$(LIBEMOTION_GENERIC_PLAYERS_VERSION).tar.xz
> +LIBEMOTION_GENERIC_PLAYERS_SITE = http://download.enlightenment.org/rel/libs/emotion_generic_players
> +LIBEMOTION_GENERIC_PLAYERS_LICENSE = GPLv2

This is BSD-2c, not GPLv2.

> +LIBEMOTION_GENERIC_PLAYERS_LICENSE_FILES = COPYING
> +
> +LIBEMOTION_GENERIC_PLAYERS_INSTALL_STAGING = YES
> +
> +LIBEMOTION_GENERIC_PLAYERS_DEPENDENCIES = libefl vlc

Missing host-pkgconf.

Regards,
Yann E. MORIN.

> +$(eval $(autotools-package))
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 02/36] package/libevas-generic-loaders: move to package directory
  2015-10-25 12:56   ` Yann E. MORIN
@ 2015-10-25 19:21     ` Romain Naour
  2015-10-25 21:04       ` Yann E. MORIN
  0 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-25 19:21 UTC (permalink / raw)
  To: buildroot

Hi Yann, All,

Le 25/10/2015 13:56, Yann E. MORIN a ?crit :
> Romain, All,
> 
> On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
>> As for expedite package, there is no advantage for efl related
>> packages to share the same version number anymore
>> (except for efl and libelementary).
>>
>> Also, we usually do not have a sub-directory for a family of related
>> packages which doen't share the same version number, so move
>> libevas-generic-loaders to package directory.
>> Libevas-generic-loaders appear now in "Libraries" -> "Graphics" in
>> the Kconfig menu.
>>
>> While at it, remove BR2_USE_WCHAR dependency since the efl package
>> already depend on it.
> 
> Are you sure that libevas-generic-loaders does not itself depend on
> wchar?
> 
> If it does, then please keep the dependency, even if it is automatically
> inherited through the dependency on EFL. This is so, in case EFL loses
> its dependency on wchar, libevas-generic-loaders would still have its
> own.

libevas-generic-loaders doesn't use wchar by itself, it's a reverse dependency
that come from librsvg which is required for svg support only.

So, IIUC when a package A select a package B, we must propagate all reverse
dependencies of the package B when the package A already depends on them
implicitly (i.e when using a depends on BR2_PACKAGE_C).

Also, in the libevas-generic-loaders bump I removed two other dependencies for
the same reason (BR2_TOOLCHAIN_HAS_THREADS and BR2_INSTALL_LIBSTDCPP):
http://lists.busybox.net/pipermail/buildroot/2015-October/142950.html

Thoughts ?

Best regards,
Romain
> 
> If it is not needed, then:
> 
>     Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Regards,
> Yann E. MORIN.
> 

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 03/36] package/efl/libefl: new host-package
  2015-10-25 13:10   ` Yann E. MORIN
@ 2015-10-25 19:24     ` Romain Naour
  0 siblings, 0 replies; 94+ messages in thread
From: Romain Naour @ 2015-10-25 19:24 UTC (permalink / raw)
  To: buildroot

Yann, All,

Le 25/10/2015 14:10, Yann E. MORIN a ?crit :
> On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
>> This new host-package provide edje_cc, embryo_cc and eet binaries
>> that will be used by the upcomming libefl packages which will
>> contain the new version of efl libraries.
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>> v4: keep efl as a sub-directory.
>>     rename this new package to libefl since we want to keep a efl
>>     and elementary version in sync.
>> v3: remove trailing slash (Vicente Bergas)
>>     bump to 1.15.2
>> ---
>>  package/efl/libefl/libefl.hash |  2 ++
>>  package/efl/libefl/libefl.mk   | 75 ++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 77 insertions(+)
>>  create mode 100644 package/efl/libefl/libefl.hash
>>  create mode 100644 package/efl/libefl/libefl.mk
>>
>> diff --git a/package/efl/libefl/libefl.hash b/package/efl/libefl/libefl.hash
>> new file mode 100644
>> index 0000000..7ac26f4
>> --- /dev/null
>> +++ b/package/efl/libefl/libefl.hash
>> @@ -0,0 +1,2 @@
>> +# From https://download.enlightenment.org/rel/libs/efl/efl-1.15.2.tar.xz.sha256
>> +sha256	dd738f19f454621a7fa1fdb4c008457c170989f5f0c535edfed7b6773ae6c2a4	efl-1.15.2.tar.xz
>> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
>> new file mode 100644
>> index 0000000..4dca733
>> --- /dev/null
>> +++ b/package/efl/libefl/libefl.mk
>> @@ -0,0 +1,75 @@
>> +################################################################################
>> +#
>> +# libefl
>> +#
>> +################################################################################
>> +
>> +# hardcode the version here since the bump to 1.15 is not complete in Buildroot
>> +LIBEFL_VERSION = 1.15.2
>> +LIBEFL_SOURCE = efl-$(LIBEFL_VERSION).tar.xz
>> +LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl
>> +LIBEFL_LICENSE = BSD-2c, LGPLv2.1+, GPLv2+
>> +LIBEFL_LICENSE_FILES = COPYING
> 
> There are much more license files:
> 
>     LIBEFL_LICENSE_FILES = \
>         COPYING \
>         licenses/COPYING.BSD \
>         licenses/COPYING.FTL \
>         licenses/COPYING.GPL \
>         licenses/COPYING.LGPL \
>         licenses/COPYING.SMALL
> 
> We may also want to add COMPLIANCE to this list, since it has a few
> suggestions about legal info.

Thanks, I missed the directory licenses (I was looking for COPYING file).
I'll add all of them.

Best regards,
Romain

> 
> Regards,
> Yann E. MORIN.
> 
>> +################################################################################
>> +#
>> +# host-libefl
>> +#
>> +################################################################################
>> +
>> +# We want to build only some host tools used later in the build.
>> +# Actually we want: edje_cc, embryo_cc and eet.
>> +
>> +# Host dependencies:
>> +# * host-dbus: for Eldbus
>> +# * host-freetype: for libevas
>> +# * host-libglib2: for libecore
>> +# * host-libjpeg, host-libpng: for libevas image loader
>> +# * host-lua: disable luajit dependency
>> +HOST_LIBEFL_DEPENDENCIES = \
>> +	host-pkgconf \
>> +	host-dbus \
>> +	host-freetype \
>> +	host-libglib2 \
>> +	host-libjpeg \
>> +	host-libpng \
>> +	host-lua \
>> +	host-zlib
>> +
>> +# Configure options:
>> +# --disable-audio, --disable-multisense remove libsndfile dependency.
>> +# --disable-cxx-bindings: disable C++11 bindings.
>> +# --disable-fontconfig: remove dependency on fontconfig.
>> +# --disable-fribidi: remove dependency on libfribidi.
>> +# --disable-gstreamer1: remove dependency on gtreamer 1.0.
>> +# --disable-libeeze: remove libudev dependency.
>> +# --disable-libmount: remove dependency on host-util-linux libmount.
>> +# --disable-physics: remove Bullet dependency.
>> +# --enable-image-loader-gif=no: disable Gif dependency.
>> +# --enable-image-loader-tiff=no: disable Tiff dependency.
>> +# --enable-lua-old: disable Elua and remove luajit dependency.
>> +# --with-crypto=none: remove dependencies on openssl or gnutls.
>> +# --with-x11=none: remove dependency on X.org.
>> +#   Yes I really know what I am doing.
>> +HOST_LIBEFL_CONF_OPTS += \
>> +	--disable-audio \
>> +	--disable-cxx-bindings \
>> +	--disable-fontconfig \
>> +	--disable-fribidi \
>> +	--disable-gstreamer1 \
>> +	--disable-libeeze \
>> +	--disable-libmount \
>> +	--disable-multisense \
>> +	--disable-physics \
>> +	--enable-image-loader-gif=no \
>> +	--enable-image-loader-jpeg=yes \
>> +	--enable-image-loader-png=yes \
>> +	--enable-image-loader-tiff=no \
>> +	--enable-lua-old \
>> +	--with-crypto=none \
>> +	--with-glib=yes \
>> +	--with-opengl=none \
>> +	--with-x11=none \
>> +	--enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-aba
>> +
>> +$(eval $(host-autotools-package))
>> -- 
>> 2.4.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 02/36] package/libevas-generic-loaders: move to package directory
  2015-10-25 19:21     ` Romain Naour
@ 2015-10-25 21:04       ` Yann E. MORIN
  2015-10-25 21:41         ` Romain Naour
  0 siblings, 1 reply; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 21:04 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-25 20:21 +0100, Romain Naour spake thusly:
> Le 25/10/2015 13:56, Yann E. MORIN a ?crit :
> > On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> >> As for expedite package, there is no advantage for efl related
> >> packages to share the same version number anymore
> >> (except for efl and libelementary).
> >>
> >> Also, we usually do not have a sub-directory for a family of related
> >> packages which doen't share the same version number, so move
> >> libevas-generic-loaders to package directory.
> >> Libevas-generic-loaders appear now in "Libraries" -> "Graphics" in
> >> the Kconfig menu.
> >>
> >> While at it, remove BR2_USE_WCHAR dependency since the efl package
> >> already depend on it.
> > 
> > Are you sure that libevas-generic-loaders does not itself depend on
> > wchar?
> > 
> > If it does, then please keep the dependency, even if it is automatically
> > inherited through the dependency on EFL. This is so, in case EFL loses
> > its dependency on wchar, libevas-generic-loaders would still have its
> > own.
> 
> libevas-generic-loaders doesn't use wchar by itself, it's a reverse dependency
> that come from librsvg which is required for svg support only.

OK, so if libevas-generic-loader does not need it, and does not have to
inherit it through one of its select, then dropping is OK.

> So, IIUC when a package A select a package B, we must propagate all reverse
> dependencies of the package B when the package A already depends on them
> implicitly (i.e when using a depends on BR2_PACKAGE_C).

I'm not sure I groked what you wrote, so here's a litle example. Say you
have a pacakge foo that needs bar and bar needs threads; here's how
you'd express it:

    config foo
        bool "foo"
        depends on threads # bar
        select bar

    config bar
        bool "bar"
        depends on threads

Now, if package foo also needs threads for itself, here's how you'd
express it:

    config foo
        bool "foo"
        depends on threads
        select bar

    config bar
        bool "bar"
        depends on threads

Note that the threads dependency in foo no longer has the '# bar'
comment.

> Also, in the libevas-generic-loaders bump I removed two other dependencies for
> the same reason (BR2_TOOLCHAIN_HAS_THREADS and BR2_INSTALL_LIBSTDCPP):
> http://lists.busybox.net/pipermail/buildroot/2015-October/142950.html

Hmm... I may have missed properly checkign that. If libevas-generic-loader
does not need threads or C++, then you can indeed drop them. However, if
it needs it, you must depend on them, even if you inherit them from the
EFL dependency.

Looking at the libevas-generic-loader code, it seems there is no need
for threads, so you can drop it.

As for C++, evas-generic-loader needs it: first, tis configure.ac has
AC_PROG_CXX, and it has one C++ file, src/pdf/main.cpp. So you have to
keep the dependency on C++.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 19/36] package/libevas-generic-loaders: bump to version 1.15.0
  2015-10-25 16:01   ` Yann E. MORIN
@ 2015-10-25 21:08     ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 21:08 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-25 17:01 +0100, Yann E. MORIN spake thusly:
> On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> > Use the newly added libefl package wich provide a new version
> > of libeina.
> > 
> > Also, update the upstream url and add a hash file.
> > 
> > While at it, remove BR2_TOOLCHAIN_HAS_THREADS and BR2_INSTALL_LIBSTDCPP
> > dependencies since the efl package already depend on them.
> > 
> > Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> 
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

As we discussed on another patch, you can indeed drop threads, because
they are not used by evas-generic-loader.

However, it has a C++ file (for PDF rendering), and configure.ac checks
for it with AC_PROG_CXX, so you need to keep the dependency on C++.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 02/36] package/libevas-generic-loaders: move to package directory
  2015-10-25 21:04       ` Yann E. MORIN
@ 2015-10-25 21:41         ` Romain Naour
  2015-10-25 21:50           ` Yann E. MORIN
  0 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-25 21:41 UTC (permalink / raw)
  To: buildroot

Hi Yann, All,

Le 25/10/2015 22:04, Yann E. MORIN a ?crit :
> Romain, All,
> 
> On 2015-10-25 20:21 +0100, Romain Naour spake thusly:
>> Le 25/10/2015 13:56, Yann E. MORIN a ?crit :
>>> On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
>>>> As for expedite package, there is no advantage for efl related
>>>> packages to share the same version number anymore
>>>> (except for efl and libelementary).
>>>>
>>>> Also, we usually do not have a sub-directory for a family of related
>>>> packages which doen't share the same version number, so move
>>>> libevas-generic-loaders to package directory.
>>>> Libevas-generic-loaders appear now in "Libraries" -> "Graphics" in
>>>> the Kconfig menu.
>>>>
>>>> While at it, remove BR2_USE_WCHAR dependency since the efl package
>>>> already depend on it.
>>>
>>> Are you sure that libevas-generic-loaders does not itself depend on
>>> wchar?
>>>
>>> If it does, then please keep the dependency, even if it is automatically
>>> inherited through the dependency on EFL. This is so, in case EFL loses
>>> its dependency on wchar, libevas-generic-loaders would still have its
>>> own.
>>
>> libevas-generic-loaders doesn't use wchar by itself, it's a reverse dependency
>> that come from librsvg which is required for svg support only.
> 
> OK, so if libevas-generic-loader does not need it, and does not have to
> inherit it through one of its select, then dropping is OK.
> 
>> So, IIUC when a package A select a package B, we must propagate all reverse
>> dependencies of the package B when the package A already depends on them
>> implicitly (i.e when using a depends on BR2_PACKAGE_C).
> 
> I'm not sure I groked what you wrote, so here's a litle example. Say you
> have a pacakge foo that needs bar and bar needs threads; here's how
> you'd express it:
> 
>     config foo
>         bool "foo"
>         depends on threads # bar
>         select bar
> 
>     config bar
>         bool "bar"
>         depends on threads

In my example based on libevas-generic-loaders, I had 3 packages:

     config foo
         bool "foo"
         depends on threads

     config bar
         bool "bar"
         depends on foo
         [depends on threads # baz]
         select baz

     config baz
         bool "baz"
         depends on threads

So foo and baz depends on threads, bar depends on foo.
The question is do we need to add [depends on threads # baz] for bar in that case ?
bar implicitly depends on threads thanks to foo dependency.

So, what I understand after your comment is that we must keep the reverse
dependency on threads for the package bar because it select baz.

> 
> Now, if package foo also needs threads for itself, here's how you'd
> express it:
> 
>     config foo
>         bool "foo"
>         depends on threads
>         select bar
> 
>     config bar
>         bool "bar"
>         depends on threads
> 
> Note that the threads dependency in foo no longer has the '# bar'
> comment.
> 
>> Also, in the libevas-generic-loaders bump I removed two other dependencies for
>> the same reason (BR2_TOOLCHAIN_HAS_THREADS and BR2_INSTALL_LIBSTDCPP):
>> http://lists.busybox.net/pipermail/buildroot/2015-October/142950.html
> 
> Hmm... I may have missed properly checkign that. If libevas-generic-loader
> does not need threads or C++, then you can indeed drop them. However, if
> it needs it, you must depend on them, even if you inherit them from the
> EFL dependency.
> 
> Looking at the libevas-generic-loader code, it seems there is no need
> for threads, so you can drop it.
> 
> As for C++, evas-generic-loader needs it: first, tis configure.ac has
> AC_PROG_CXX, and it has one C++ file, src/pdf/main.cpp. So you have to
> keep the dependency on C++.

Ok, I'll look at it latter the week, I'll try to resend a new series before the
next week-end.

Best regards,
Romain

> 
> Regards,
> Yann E. MORIN.
> 

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 02/36] package/libevas-generic-loaders: move to package directory
  2015-10-25 21:41         ` Romain Naour
@ 2015-10-25 21:50           ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-25 21:50 UTC (permalink / raw)
  To: buildroot

romain, All,

On 2015-10-25 22:41 +0100, Romain Naour spake thusly:
> Le 25/10/2015 22:04, Yann E. MORIN a ?crit :
> > On 2015-10-25 20:21 +0100, Romain Naour spake thusly:
[--SNIP--]
> >> So, IIUC when a package A select a package B, we must propagate all reverse
> >> dependencies of the package B when the package A already depends on them
> >> implicitly (i.e when using a depends on BR2_PACKAGE_C).
> > 
> > I'm not sure I groked what you wrote, so here's a litle example. Say you
> > have a pacakge foo that needs bar and bar needs threads; here's how
> > you'd express it:
> > 
> >     config foo
> >         bool "foo"
> >         depends on threads # bar
> >         select bar
> > 
> >     config bar
> >         bool "bar"
> >         depends on threads
> 
> In my example based on libevas-generic-loaders, I had 3 packages:
> 
>      config foo
>          bool "foo"
>          depends on threads
> 
>      config bar
>          bool "bar"
>          depends on foo
>          [depends on threads # baz]
>          select baz
> 
>      config baz
>          bool "baz"
>          depends on threads
> 
> So foo and baz depends on threads, bar depends on foo.
> The question is do we need to add [depends on threads # baz] for bar in that case ?
> bar implicitly depends on threads thanks to foo dependency.
> 
> So, what I understand after your comment is that we must keep the reverse
> dependency on threads for the package bar because it select baz.

Yes, you need to keep it in that case, because, if foo looses its
dependency on threads, bar still needs it because it selects baz.

The other reason you would keep it is if bar itself would need threads.

> Ok, I'll look at it latter the week, I'll try to resend a new series before the
> next week-end.

Hehe! ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 04/36] package/efl/libefl: new package
  2015-10-25 13:55   ` Yann E. MORIN
@ 2015-10-26 21:53     ` Romain Naour
  2015-10-27 19:16       ` Arnout Vandecappelle
  0 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-26 21:53 UTC (permalink / raw)
  To: buildroot

Hi Yann, All,

Le 25/10/2015 14:55, Yann E. MORIN a ?crit :
> Romain, All,
> 
> On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
>> Add the libefl package which contains an updated version of the following
>> libraries:
>> libecore, libedje, libeet, libfreet, libeina, libeio, libembryo, libthumb
>> and libevas. It also contains eldbus, ephysics, and escape, see [1].
>>
>> For now, the bump to efl 1.15.x is not complete.
>> This allows to build at least a default configuration whithout X11 support
>> or graphics acceleration.
>> This support will be added by a follow up patches in the series.
>>
>> Also, add BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG config option in order to
>> select all recommended packages that allows to build efl-core whithout the
>> extra-long --enable-i-really-know-what-i-am-doing...
>>
>> At the end of the configure script, the summary tab will show that
>> alsa support is allways disabled even if alsa-utils has been build
>> before efl-core package.
>>
>> "Ecore_Audio.....: yes (-alsa +pulseaudio +sndfile)"
>> This is intentional.
>>
>> An initial runtime test has been done under Qemu with a glibc x86 toolchain.
>>
>> An additional runtime test has been done with a uClibc-ng 1.0.5 toolchain
>> patched with [2] in order to add mkstemps() which is used by Eina library.
>> This patch has been upstreamed in uClubc-ng 1.0.6 release.
>>
>> Another test has been done with a musl toolchain by Vicente Bergas (Thanks!)
>>
>> Add a dependency on threads support since clearly efl libraries are
>> not even built without thread support [3].
>>
>> [1] See https://phab.enlightenment.org/phame/live/3/post/efl_1_8/
>> [2] http://mailman.uclibc-ng.org/pipermail/devel/2015-August/000432.html
>> [3] https://git.enlightenment.org/core/efl.git/tree/configure.ac#n5032
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> Cc: Vicente Bergas <vicencb@gmail.com>
>> ---
>> v4: rename to libefl
>>     EFL needs a toolchain with threads support
>> v3: fix same typo again
>>     Add a note about multisense support
>> v2: remove glibc only dependency
>>     update commit log accordingly
>>     fix typo in Config.in (Vicente Bergas)
>>
>> Vicente, can you test this new series and resend your Tested-By tag ? Thanks !
>> ---
>>  package/efl/Config.in        |  16 +++--
>>  package/efl/libefl/Config.in |  65 +++++++++++++++++
>>  package/efl/libefl/libefl.mk | 161 +++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 237 insertions(+), 5 deletions(-)
>>  create mode 100644 package/efl/libefl/Config.in
>>
>> diff --git a/package/efl/Config.in b/package/efl/Config.in
>> index 7ce5a36..2860cd6 100644
>> --- a/package/efl/Config.in
>> +++ b/package/efl/Config.in
>> @@ -1,8 +1,12 @@
>>  menuconfig BR2_PACKAGE_EFL
>>  	bool "Enlightenment Foundation Libraries"
>> -	depends on BR2_USE_WCHAR
>> -	# libeina uses madvise(). To revisit when bumping EFL to 1.8
>> -	depends on BR2_USE_MMU
>> +	depends on BR2_INSTALL_LIBSTDCPP # libefl
>> +	depends on BR2_PACKAGE_HAS_UDEV # libefl -> libudev
>> +	depends on BR2_TOOLCHAIN_HAS_THREADS # libefl
>> +	depends on BR2_USE_MMU # libefl
>> +	depends on BR2_USE_WCHAR # libefl
>> +	depends on !BR2_STATIC_LIBS # libefl
>> +	select BR2_PACKAGE_LIBEFL
>>  	help
>>  	  Enlightenment Foundation Libraries
>>  
>> @@ -13,6 +17,7 @@ if BR2_PACKAGE_EFL
>>  source "package/efl/libeina/Config.in"
>>  source "package/efl/libecore/Config.in"
>>  source "package/efl/libeet/Config.in"
>> +source "package/efl/libefl/Config.in"
>>  source "package/efl/libefreet/Config.in"
>>  source "package/efl/libeio/Config.in"
>>  source "package/efl/libevas/Config.in"
>> @@ -24,5 +29,6 @@ source "package/efl/libedbus/Config.in"
>>  
>>  endif # BR2_PACKAGE_EFL
>>  
>> -comment "EFL needs a toolchain w/ wchar"
>> -	depends on !BR2_USE_WCHAR
>> +comment "EFL needs udev /dev management and a toolchain w/ C++, dynamic library, threads, wchar"
>> +	depends on !BR2_PACKAGE_HAS_UDEV || !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
> 
> Please, split this very long line...

Ok, but...

> 
>> +	depends on BR2_USE_MMU
>> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
>> new file mode 100644
>> index 0000000..2b758f0
>> --- /dev/null
>> +++ b/package/efl/libefl/Config.in
>> @@ -0,0 +1,65 @@
>> +config BR2_PACKAGE_LIBEFL
>> +	bool "libefl"
>> +	depends on BR2_INSTALL_LIBSTDCPP
>> +	depends on BR2_PACKAGE_HAS_UDEV # libudev
>> +	depends on BR2_TOOLCHAIN_HAS_THREADS # untested without threads
>> +	depends on BR2_USE_MMU
>> +	depends on BR2_USE_WCHAR # use wchar_t
>> +	depends on !BR2_STATIC_LIBS # dlfcn.h
>> +	select BR2_PACKAGE_DBUS
>> +	select BR2_PACKAGE_FREETYPE
>> +	select BR2_PACKAGE_JPEG # Emile needs libjpeg
>> +	select BR2_PACKAGE_LUA # Evas lua 5.1 or 5.2
> 
> You can not select Lua, as it is a provider of the virtual package
> luainterpreter: it is not alowed to select the provider of a virtual
> package, see the manual:
>     http://buildroot.org/downloads/manual/manual.html#_notes_on_depending_on_a_specific_provider
> 
>     If your package really requires a specific provider, then you?ll
>     have to make your package depends on this provider; you can not
>     select a provider.
> 
> You'll have to make libefl (and efl) both depend on BR2_PACKAGE_LUA.
> 
> That's unfortunate, but the manual has explanations on why this is so.

...the comments line start to be very long, should I do something like:

comment "EFL needs Lua, udev /dev management and a toolchain w/ C++, dynamic library, threads, wchar"
	depends on !BR2_PACKAGE_LUA || !BR2_PACKAGE_HAS_UDEV || !BR2_INSTALL_LIBSTDCPP \
		|| BR2_STATIC_LIBS  || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
	depends on BR2_USE_MMU

> 
>> +	help
>> +	  Enlightenment Foundation Libraries
>> +
>> +	  https://enlightenment.org
>> +
>> +if BR2_PACKAGE_LIBEFL
>> +
>> +config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
>> +	bool "Use recommended and tested configurations"
>> +	select BR2_PACKAGE_BULLET
>> +	select BR2_PACKAGE_FONTCONFIG
>> +	select BR2_PACKAGE_GSTREAMER1
>> +	select BR2_PACKAGE_GST1_PLUGINS_BASE
>> +	select BR2_PACKAGE_LIBFRIBIDI
>> +	select BR2_PACKAGE_LIBSNDFILE
>> +	select BR2_PACKAGE_PULSEAUDIO
> 
> You forgot to propagate P.A.'s dependency on BR2_ARCH_HAS_ATOMICS.

OK

> 
>> +	select BR2_PACKAGE_UTIL_LINUX
>> +	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
>> +	default y
>> +	help
>> +	  Avoid to use untested or not recommended configurations,
>> +	  otherwise we need to add a very long and obscure option
>> +	  to start the build.
> 
> No need to explain the nitty-gritty implementation details on why this
> is so. Just state something like:
> 
>     Enable the basic set of recommended features.
> 
>     Without that, the EFL developpers consider the build to be
>     potentially broken and won't provide any support for it.
> 
>     This turns on the following features:
> 
>       - util-linux' libmount: Libmount is used heavily inside Eeze for
>         support of removable devices etc... and disabling this will hurt
>         support for Enlightenment and its filemanager.
> 
>       - fontconfig: If fontconfig is disabled, this is going to make
>         general font searching not work, and only some very direct 'load
>         /path/file.ttf' will work alongside some old-school ttf file
>         path searching. This is very likely not what you want, so highly
>         reconsider turning fontconfig off. Having it off will lead to
>         visual problems like missing text in many UI areas etc...
> 
> And so on, you get the idea. ;-)
> 
> Drop the corresponding comment in the .mk file. It is better to thave
> those comments in the Config.in, so the user can actually see them and
> act accordingly.

Ok, done.

> 
> [--SNIP--]
>> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
>> index 4dca733..781f397 100644
>> --- a/package/efl/libefl/libefl.mk
>> +++ b/package/efl/libefl/libefl.mk
>> @@ -11,6 +11,167 @@ LIBEFL_SITE = http://download.enlightenment.org/rel/libs/efl
>>  LIBEFL_LICENSE = BSD-2c, LGPLv2.1+, GPLv2+
>>  LIBEFL_LICENSE_FILES = COPYING
>>  
>> +LIBEFL_INSTALL_STAGING = YES
>> +
>> +LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg lua udev zlib
>> +
>> +# Configure options:
>> +# --disable-cxx-bindings: disable C++11 bindings.
>> +# --enable-lua-old: disable Elua and remove luajit dependency.
>> +# --with-x11=none: remove dependency on X.org.
>> +LIBEFL_CONF_OPTS = \
>> +	--with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc \
>> +	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
>> +	--disable-cxx-bindings \
>> +	--enable-lua-old \
>> +	--with-x11=none
>> +
>> +# Disable untested configuration warning.
>> +ifeq ($(BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG),)
>> +LIBEFL_CONF_OPTS += --enable-i-really-know-what-i-am-doing-and-that-this-will-probably-break-things-and-i-will-fix-them-myself-and-send-patches-aba
>> +endif
>> +
>> +# Libmount is used heavily inside Eeze for support of removable devices etc.
>> +# and disabling this will hurt support for Enlightenment and its filemanager.
>> +ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBMOUNT),y)
>> +LIBEFL_DEPENDENCIES += util-linux
>> +LIBEFL_CONF_OPTS += --enable-libmount
>> +else
>> +LIBEFL_CONF_OPTS += --disable-libmount
>> +endif
>> +
>> +# If fontconfig is disabled, this is going to make general font
>> +# searching not work, and only some very direct 'load /path/file.ttf'
>> +# will work alongside some old-school ttf file path searching. This
>> +# is very likely not what you want, so highly reconsider turning
>> +# fontconfig off. Having it off will lead to visual problems like
>> +# missing text in many UI areas etc.
>> +ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
>> +LIBEFL_CONF_OPTS += --enable-fontconfig
>> +LIBEFL_DEPENDENCIES += fontconfig
>> +else
>> +LIBEFL_CONF_OPTS += --disable-fontconfig
>> +endif
>> +
>> +# Fribidi is used for handling right-to-left text (like Arabic,
>> +# Hebrew, Farsi, Persian etc.) and is very likely not a feature
>> +# you want to disable unless you know for absolute certain you
>> +# will never encounter and have to display such scripts. Also
>> +# note that we don't test with fribidi disabled so you may also
>> +# trigger code paths with bugs that are never normally used.
>> +ifeq ($(BR2_PACKAGE_LIBFRIBIDI),y)
>> +LIBEFL_CONF_OPTS += --enable-fribidi
>> +LIBEFL_DEPENDENCIES += libfribidi
>> +else
>> +LIBEFL_CONF_OPTS += --disable-fribidi
>> +endif
>> +
>> +# If Gstreamer 1.x support is disabled, it will heavily limit your media
>> +# support options and render some functionality as useless, leading to
>> +# visible application bugs.
>> +ifeq ($(BR2_PACKAGE_GSTREAMER1)$(BR2_PACKAGE_GST1_PLUGINS_BASE),yy)
>> +LIBEFL_CONF_OPTS += --enable-gstreamer1
>> +LIBEFL_DEPENDENCIES += gstreamer1 gst1-plugins-base
>> +else
>> +LIBEFL_CONF_OPTS += --disable-gstreamer1
>> +endif
>> +
>> +# You have chosen to disable physics support. This disables lots of
>> +# core functionality and is effectively never tested. You are going
>> +# to find features that suddenly don't work and as a result cause
>> +# a series of breakages. This is simply not tested so you are on
>> +# your own in terms of ensuring everything works if you do this
>> +ifeq ($(BR2_PACKAGE_BULLET),y)
>> +LIBEFL_CONF_OPTS += --enable-physics
>> +LIBEFL_DEPENDENCIES += bullet
>> +else
>> +LIBEFL_CONF_OPTS += --disable-physics
>> +endif
>> +
>> +# You disabled audio support in Ecore. This is not tested and may
>> +# Create bugs for you due to it creating untested code paths.
>> +# Reconsider disabling audio.
>> +ifeq ($(BR2_PACKAGE_LIBSNDFILE),y)
>> +LIBEFL_CONF_OPTS += --enable-audio
>> +LIBEFL_DEPENDENCIES += libsndfile
>> +else
>> +LIBEFL_CONF_OPTS += --disable-audio
>> +endif
>> +
>> +# The only audio output method supported by Ecore right now is via
>> +# Pulseaudio. You have disabled that and likely have broken a whole
>> +# bunch of things in the process. Reconsider your configure options.
>> +# NOTE: multisense support is automatically enabled with pulseaudio.
>> +ifeq ($(BR2_PACKAGE_PULSEAUDIO),y)
>> +LIBEFL_CONF_OPTS += --enable-pulseaudio
>> +LIBEFL_DEPENDENCIES += pulseaudio
>> +else
>> +LIBEFL_CONF_OPTS += --disable-pulseaudio
>> +endif
> 
> As I previously suggested, move all the above comments to the Config.in
> file, to help user make an enlighted (muahahaha!) decision.

Lol :)

> 
>> +# There is no alsa support yet in Ecore_Audio.
>> +# configure will disable alsa support even if alsa-lib is selected.
> 
> So what? Having this comment stand alone is not much use. You should
> probably add "LIBEFL_CONF_OPTS += --disable-alsa", then, no?

I'll add it to LIBEFL_CONF_OPTS at the top of the mk file.

> 
>> +ifeq ($(BR2_PACKAGE_TSLIB),y)
>> +LIBEFL_DEPENDENCIES += tslib
>> +LIBEFL_CONF_OPTS += --enable-tslib
>> +else
>> +LIBEFL_CONF_OPTS += --disable-tslib
>> +endif
>> +
>> +ifeq ($(BR2_PACKAGE_LIBGLIB2),y)
>> +LIBEFL_DEPENDENCIES += libglib2
>> +# we can also say "always"
> 
> Useless comment, drop it.
ok
> 
>> +LIBEFL_CONF_OPTS += --with-glib=yes
>> +else
>> +LIBEFL_CONF_OPTS += --with-glib=no
>> +endif
>> +
>> +# Prefer openssl (the default) over gnutls.
>> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
>> +LIBEFL_DEPENDENCIES += openssl
>> +LIBEFL_CONF_OPTS += --with-crypto=openssl
>> +else
>> +ifeq ($(BR2_PACKAGE_GNUTLS)$(BR2_PACKAGE_LIBGCRYPT),yy)
> 
> use the else ifeq construct rather than nested if-blocks, ...
> 
>> +LIBEFL_DEPENDENCIES += gnutls libgcrypt
>> +LIBEFL_CONF_OPTS += --with-crypto=gnutls \
>> +	--with-libgcrypt-prefix=$(STAGING_DIR)/usr
>> +else
>> +LIBEFL_CONF_OPTS += --with-crypto=none
>> +endif
>> +endif # BR2_PACKAGE_OPENSSL
> 
> .. you'll gain one endif here.

ok

> 
>> +# image loader: handle only loaders that requires dependencies.
>> +# All other loaders are builded by default statically.
>> +ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)
>> +LIBEFL_CONF_OPTS += --enable-image-loader-png=yes
>> +LIBEFL_DEPENDENCIES += libpng
>> +else
>> +LIBEFL_CONF_OPTS += --enable-image-loader-png=no
>> +endif
>> +
>> +ifeq ($(BR2_PACKAGE_LIBEFL_JPEG),y)
>> +LIBEFL_CONF_OPTS += --enable-image-loader-jpeg=yes
> 
> Maybe add a comment that the 'jpeg' dependency is already covered as a
> global dependency of libefl. Otherwise, it is strange to not see it here
> (I only remembered it because I previously checked if the dependencies
> of jpeg were prorerly propagated).

ok.

> 
> Regards,
> Yann E. MORIN.
> 
>> +else
>> +LIBEFL_CONF_OPTS += --enable-image-loader-jpeg=no
>> +endif
>> +
>> +ifeq ($(BR2_PACKAGE_LIBEFL_GIF),y)
>> +LIBEFL_CONF_OPTS += --enable-image-loader-gif=yes
>> +LIBEFL_DEPENDENCIES += giflib
>> +else
>> +LIBEFL_CONF_OPTS += --enable-image-loader-gif=no
>> +endif
>> +
>> +ifeq ($(BR2_PACKAGE_LIBEFL_TIFF),y)
>> +LIBEFL_CONF_OPTS += --enable-image-loader-tiff=yes
>> +LIBEFL_DEPENDENCIES += tiff
>> +else
>> +LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no
>> +endif
>> +
>> +$(eval $(autotools-package))
>> +
>>  ################################################################################
>>  #
>>  # host-libefl
>> -- 
>> 2.4.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 13/36] package/efl/libefl: add jp2k config option
  2015-10-25 14:48   ` Yann E. MORIN
@ 2015-10-26 22:04     ` Romain Naour
  0 siblings, 0 replies; 94+ messages in thread
From: Romain Naour @ 2015-10-26 22:04 UTC (permalink / raw)
  To: buildroot

Hi Yann, All,

Le 25/10/2015 15:48, Yann E. MORIN a ?crit :
> Romain, All,
> 
> On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
>> Like for webp format, add an option to enable the JPEG 2000
>> codec support in the efl libraries.
> 
> Suddenly, I wonder why you added a bunch of image loaders in the first
> patch adding libelf, but you add a few more such loaders in separate
> patches.
> 
> Can't you do either:
>   - introduce all of them as separate patches, or
>   - introduce all of them in the first patch adding libefl?
> 
> Or is there an underlying good reason to do as you did?

Yes there is a reason (good maybe), I wanted to add in the first patch all
images loader that are already present in the previous version of efl package.
So, I added new one in separate patches.

Best regards,
Romain

> 
> Regards,
> Yann E. MORIN.
> 
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>> v4: rename to libefl
>>     improve commit log
>> ---
>>  package/efl/libefl/Config.in | 7 +++++++
>>  package/efl/libefl/libefl.mk | 7 +++++++
>>  2 files changed, 14 insertions(+)
>>
>> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
>> index e25911f..53adea2 100644
>> --- a/package/efl/libefl/Config.in
>> +++ b/package/efl/libefl/Config.in
>> @@ -51,6 +51,13 @@ config BR2_PACKAGE_LIBEFL_PNG
>>  	  This enables the loader code that loads png files using
>>  	  libpng.
>>  
>> +config BR2_PACKAGE_LIBEFL_JP2K
>> +	bool "libevas jp2k loader"
>> +	select BR2_PACKAGE_OPENJPEG
>> +	help
>> +	  This enables the loader code that loads jp2k files using
>> +	  openjpeg.
>> +
>>  config BR2_PACKAGE_LIBEFL_JPEG
>>  	bool "libevas jpeg loader"
>>  	help
>> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
>> index 3a4aab1..e53470d 100644
>> --- a/package/efl/libefl/libefl.mk
>> +++ b/package/efl/libefl/libefl.mk
>> @@ -201,6 +201,13 @@ else
>>  LIBEFL_CONF_OPTS += --enable-image-loader-tiff=no
>>  endif
>>  
>> +ifeq ($(BR2_PACKAGE_LIBEFL_JP2K),y)
>> +LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=yes
>> +LIBEFL_DEPENDENCIES += openjpeg
>> +else
>> +LIBEFL_CONF_OPTS += --enable-image-loader-jp2k=no
>> +endif
>> +
>>  ifeq ($(BR2_PACKAGE_LIBEFL_WEBP),y)
>>  LIBEFL_CONF_OPTS += --enable-image-loader-webp=yes
>>  LIBEFL_DEPENDENCIES += webp
>> -- 
>> 2.4.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 

-- 
Romain Naour

OPEN WIDE Ing?nierie - Paris
23/25, rue Daviel| 75013 PARIS
http://ingenierie.openwide.fr

Le blog des technologies libres et embarqu?es :
http://www.linuxembedded.fr

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 04/36] package/efl/libefl: new package
  2015-10-26 21:53     ` Romain Naour
@ 2015-10-27 19:16       ` Arnout Vandecappelle
  0 siblings, 0 replies; 94+ messages in thread
From: Arnout Vandecappelle @ 2015-10-27 19:16 UTC (permalink / raw)
  To: buildroot

On 26-10-15 22:53, Romain Naour wrote:
> ...the comments line start to be very long, should I do something like:
> 
> comment "EFL needs Lua, udev /dev management and a toolchain w/ C++, dynamic library, threads, wchar"
> 	depends on !BR2_PACKAGE_LUA || !BR2_PACKAGE_HAS_UDEV || !BR2_INSTALL_LIBSTDCPP \
> 		|| BR2_STATIC_LIBS  || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
> 	depends on BR2_USE_MMU

 In this case, I think it's worthwhile to split it into two comments, one for
lua and udev and another for the toolchain.

 BTW I personally would put lua in lowercase here, because the option in the
menu is also in lowercase.

 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 08/36] package/efl/libefl: add libcurl dependency
  2015-10-25 14:37   ` Yann E. MORIN
@ 2015-10-28 21:39     ` Romain Naour
  0 siblings, 0 replies; 94+ messages in thread
From: Romain Naour @ 2015-10-28 21:39 UTC (permalink / raw)
  To: buildroot

Yann, All,

Sorry for the slow response time, but I'm doing this on my free time only.

Le 25/10/2015 15:37, Yann E. MORIN a ?crit :
> On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
>> Curl is listed as an dependency in the README:
>> https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n453
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>> v4: rename to libefl
>> ---
>>  package/efl/libefl/Config.in | 1 +
>>  package/efl/libefl/libefl.mk | 3 ++-
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
>> index 07aee42..29aef05 100644
>> --- a/package/efl/libefl/Config.in
>> +++ b/package/efl/libefl/Config.in
>> @@ -9,6 +9,7 @@ config BR2_PACKAGE_LIBEFL
>>  	select BR2_PACKAGE_DBUS
>>  	select BR2_PACKAGE_FREETYPE
>>  	select BR2_PACKAGE_JPEG # Emile needs libjpeg
>> +	select BR2_PACKAGE_LIBCURL # eina_module, runtime dependency
> 
> If it is a runtime dependency, ...
> 
>>  	select BR2_PACKAGE_LUA # Evas lua 5.1 or 5.2
>>  	select BR2_PACKAGE_LIBXKBCOMMON if BR2_PACKAGE_WAYLAND
>>  	help
>> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
>> index c697e41..b26f848 100644
>> --- a/package/efl/libefl/libefl.mk
>> +++ b/package/efl/libefl/libefl.mk
>> @@ -13,7 +13,8 @@ LIBEFL_LICENSE_FILES = COPYING
>>  
>>  LIBEFL_INSTALL_STAGING = YES
>>  
>> -LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg lua udev zlib
>> +LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg libcurl lua \
>> +	udev zlib
> 
> ... then why do you add it to build dependencies?
> 
> Moreover, it looks more like a build dependency, given the number of
> calls to the libcurl functions throughout the libelf code. Can you
> confirm whether this is only a runtime dependency or a build dependency?

It's confirmed by this commit:
https://git.enlightenment.org/core/efl.git/commit/?id=2c1c6b9335e38c6e52b06829a95d9b58d780c99e

You're right, I'll remove this build time dependency.

Best regards,
Romain

> 
> Regards,
> Yann E. MORIN.
> 
>>  # regenerate the configure script:
>>  # https://phab.enlightenment.org/T2718
>> -- 
>> 2.4.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 09/36] package/efl/libefl: add libblkid dependency
  2015-10-25 14:40   ` Yann E. MORIN
@ 2015-10-28 22:03     ` Romain Naour
  0 siblings, 0 replies; 94+ messages in thread
From: Romain Naour @ 2015-10-28 22:03 UTC (permalink / raw)
  To: buildroot

Yann, All,

Le 25/10/2015 15:40, Yann E. MORIN a ?crit :
> Romain, All,
> 
> On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
>> util-linux libblkid is listed as an dependency in the README:
>> https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n478
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>> v4: rename to libefl
>> ---
>>  package/efl/libefl/Config.in | 1 +
>>  package/efl/libefl/libefl.mk | 5 +++++
>>  2 files changed, 6 insertions(+)
>>
>> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
>> index 29aef05..5c65744 100644
>> --- a/package/efl/libefl/Config.in
>> +++ b/package/efl/libefl/Config.in
>> @@ -29,6 +29,7 @@ config BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
>>  	select BR2_PACKAGE_LIBSNDFILE
>>  	select BR2_PACKAGE_PULSEAUDIO
>>  	select BR2_PACKAGE_UTIL_LINUX
>> +	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
>>  	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
>>  	default y
>>  	help
>> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
>> index b26f848..c7ecf51 100644
>> --- a/package/efl/libefl/libefl.mk
>> +++ b/package/efl/libefl/libefl.mk
>> @@ -46,6 +46,11 @@ else
>>  LIBEFL_CONF_OPTS += --disable-libmount
>>  endif
>>  
>> +# libblkid is part of required tools, see EFL's README.
> 
> If it is indeed a required dependency, fold this in the patch adding
> libefl.
> 
>> +ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),y)
>> +LIBEFL_DEPENDENCIES += util-linux
>> +endif
> 
> Besides, no need to make it conditional: it will always be 'y' since you
> select it.

It's only selected with BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG not when the
package is selected.

But I'll add util-linux to the dependency list and always select
BR2_PACKAGE_UTIL_LINUX_LIBBLKID.

I haven't tested much minimal efl configuration.

Best regards,
Romain

> 
> Regards,
> Yann E. MORIN.
> 
>> +
>>  # If fontconfig is disabled, this is going to make general font
>>  # searching not work, and only some very direct 'load /path/file.ttf'
>>  # will work alongside some old-school ttf file path searching. This
>> -- 
>> 2.4.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 14/36] package/efl/libefl: add X11 support
  2015-10-25 15:01   ` Yann E. MORIN
@ 2015-10-29 20:49     ` Romain Naour
  2015-10-29 21:01       ` Yann E. MORIN
  0 siblings, 1 reply; 94+ messages in thread
From: Romain Naour @ 2015-10-29 20:49 UTC (permalink / raw)
  To: buildroot

Yann, All,

Le 25/10/2015 16:01, Yann E. MORIN a ?crit :
> Romain, All,
> 
> On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
>> Add an option to enable X11 support in libecore without graphic
>> acceleration. libecore can use xlib or xcb support but the latter
>> in not recommended by efl developpers.
>>
>> Also, set x-includes and x-libraries configure option for cross-compiling.
>> Previous efl versions had cross-compilation issue (poisoned paths)
>> if these options are not passed to configure script.
>>
>> In order to remove the dependency on libXp wich is no longer bundled in
>> recent X11 release [1], backport an upstream patch [2] to remove xprint
>> usage.
>>
>> [1] http://www.x.org/wiki/Releases/ModuleVersions
>> [2] https://git.enlightenment.org/core/efl.git/commit/?h=efl-1.15&id=434572355c7e929b84210b2f795634d38f13c913
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> [--SNIP--]
>> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
>> index 53adea2..8356fa1 100644
>> --- a/package/efl/libefl/Config.in
>> +++ b/package/efl/libefl/Config.in
>> @@ -42,6 +42,47 @@ comment "libecore video support"
>>  config BR2_PACKAGE_LIBEFL_FB
>>  	bool "libecore framebuffer support"
>>  
>> +config BR2_PACKAGE_LIBEFL_X
>> +	bool "libecore X support"
>> +	depends on BR2_PACKAGE_XORG7
>> +	select BR2_PACKAGE_XLIB_LIBX11
>> +	select BR2_PACKAGE_XLIB_LIBXEXT
>> +
>> +if BR2_PACKAGE_LIBEFL_X
>> +
>> +choice
>> +	prompt "select libecore XLIB/XCB support"
>> +
>> +config BR2_PACKAGE_LIBEFL_X_XLIB
>> +	bool "libecore XLIB support"
>> +	select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
>> +	select BR2_PACKAGE_XLIB_LIBXCURSOR
>> +	select BR2_PACKAGE_XLIB_LIBXDAMAGE
>> +	select BR2_PACKAGE_XLIB_LIBXINERAMA
>> +	select BR2_PACKAGE_XLIB_LIBXP
>> +	select BR2_PACKAGE_XLIB_LIBXRANDR
>> +	select BR2_PACKAGE_XLIB_LIBXRENDER
>> +	select BR2_PACKAGE_XLIB_LIBXSCRNSAVER
>> +	select BR2_PACKAGE_XLIB_LIBXTST
>> +	select BR2_PACKAGE_XPROTO_GLPROTO
>> +
>> +config BR2_PACKAGE_LIBEFL_X_XCB
>> +	bool "libecore XCB support"
>> +	depends on !BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
>> +	select BR2_PACKAGE_LIBXCB
>> +	select BR2_PACKAGE_XCB_UTIL_IMAGE # xcb-image.pc
>> +	select BR2_PACKAGE_XCB_UTIL_KEYSYMS # xcb-keysyms.pc
>> +	select BR2_PACKAGE_XCB_UTIL_RENDERUTIL # xcb-renderutil.pc
>> +	select BR2_PACKAGE_XCB_UTIL_WM # xcb-icccm.pc
>> +	select BR2_PACKAGE_XLIB_LIBX11
>> +
>> +comment "for libecore XCB support disable recommended configurations"
>> +	depends on BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG
>> +
>> +endchoice
>> +
>> +endif # BR2_PACKAGE_LIBEFL_X
> 
> Make that a single choice:
> 
>     choice
>         bool "X11 support"
> 
>     config BR2_PACKAGE_LIBEFL_X_NONE
>         bool "none"
> 
>     config BR2_PACKAGE_LIBEFL_X_XLIB
>         bool "xlib"
> 
>     config BR2_PACKAGE_LIBEFL_X_XCB
>         bool "xcb"
> 
>     endchoice # X11 support
> 
> Of course, with the appropriate depends/selects and comment.

Ok

> 
>>  comment "libevas loaders"
>>  
>>  config BR2_PACKAGE_LIBEFL_PNG
>> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
>> index e53470d..6a1a8ae 100644
>> --- a/package/efl/libefl/libefl.mk
>> +++ b/package/efl/libefl/libefl.mk
>> @@ -18,6 +18,7 @@ LIBEFL_DEPENDENCIES = host-pkgconf host-libefl dbus freetype jpeg libcurl lua \
>>  
>>  # regenerate the configure script:
>>  # https://phab.enlightenment.org/T2718
>> +# configure.ac patched by 0002-ecore_x-Remove-XPrint-usage.patch
> 
> This comment might become misleading in the future, in case it we no
> longer patch configure.ac. What about:
> 
>     # Regenerate the autotools:
>     #  - to fix an issue in eldbus-codegen: https://phab.enlightenment.org/T2718
>     #  - to remove dependency on libXp: https://phab.enlightenment.org/D3150 
> 
>>  LIBEFL_AUTORECONF = YES
>>  LIBEFL_GETTEXTIZE = YES
>>  
>> @@ -30,7 +31,7 @@ LIBEFL_CONF_OPTS = \
>>  	--with-eolian-gen=$(HOST_DIR)/usr/bin/eolian_gen \
>>  	--disable-cxx-bindings \
>>  	--enable-lua-old \
>> -	--with-x11=none
>> +	--enable-lua-old
> 
> Now we've got --enable-lua-old twice. ;-)

Probably a rebase issue :p

> 
>>  # Disable untested configuration warning.
>>  ifeq ($(BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG),)
>> @@ -172,6 +173,65 @@ else
>>  LIBEFL_CONF_OPTS += --enable-fb=no
>>  endif
>>  
>> +ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
>> +LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \
>> +	--x-includes=$(STAGING_DIR)/usr/include \
>> +	--x-libraries=$(STAGING_DIR)/usr/lib \
>> +	--with-opengl=none
>> +
>> +LIBEFL_DEPENDENCIES += \
>> +	xlib_libX11 \
>> +	xlib_libXext
>> +else
>> +LIBEFL_CONF_OPTS += --with-x=no \
>> +	--with-x11=none
>> +endif
>> +
>> +ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB),y)
>> +LIBEFL_DEPENDENCIES += \
>> +	xlib_libX11 \
> 
> xlib_libx11 already a dependency, above.
> 
>> +	xlib_libXcomposite \
>> +	xlib_libXcursor \
>> +	xlib_libXdamage \
>> +	xlib_libXext \
> 
> Ditto.
> 
>> +	xlib_libXinerama \
>> +	xlib_libXrandr \
>> +	xlib_libXrender \
>> +	xlib_libXScrnSaver \
>> +	xlib_libXtst
>> +LIBEFL_CONF_OPTS += --with-x11=xlib
>> +endif
>> +
>> +# xcb-util-image to provide xcb-image.pc
>> +# xcb-util-renderutil to provide xcb-renderutil.pc
>> +# xcb-util-wm to provide xcb-icccm.pc
>> +# xcb-util-keysyms to provide xcb-keysyms.pc
>> +ifeq ($(BR2_PACKAGE_LIBEFL_X_XCB),y)
>> +LIBEFL_DEPENDENCIES += libxcb \
>> +	xcb-util-image \
>> +	xcb-util-keysyms \
>> +	xcb-util-renderutil \
>> +	xcb-util-wm
>> +# You have chosen to use XCB instead of Xlib. It is a myth that XCB
>> +# is amazingly faster than Xlib (when used sensibly). It can be
>> +# faster in a few corner cases on startup of an app, but it comes
>> +# with many downsides. One of those is more complex code inside
>> +# ecore_x, which is far less tested in XCB mode than Xlib. Also
>> +# the big catch is that OpenGL support basically requires Xlib anyway
>> +# so if you want OpenGL in X11, you need Xlib regardless and so you
>> +# gain nothing really in terms of speed and no savings in memory
>> +# because Xlib is still linked, loaded and used, BUT instead you
>> +# have OpenGL drivers working with an hybrid XCB/Xlib (mostly XCB)
>> +# toolkit and this is basically never tested by anyone working on
>> +# the OpenGL drivers, so you will have bugs. Do not enable XCB
>> +# and use OpenGL. XCB is only useful if you wish to shave a few Kb
>> +# off the memory footprint of a whole system and live with less
>> +# tested code, and possibly unimplemented features in ecore_x. To
>> +# remove the XCB setup, remove the --with-x11=xcb option to
>> +# configure.
> 
> Why this big comment? At best, it belongs to the help text of
> BR2_PACKAGE_LIBEFL_X_XCB in the Config.in.
> 
> Also, I guess you're only quoting the EFL developers here, so you should
> state so and add a pointer to that message upstream:
> 
>     https://git.enlightenment.org/core/efl.git/tree/configure.ac#n5002
> 
> But if it were purely on me, I would just drop it.

Well, I'm wondering if I should keep XCB support in this package since it's not
a "recommended" configuration. I kept it only because it was already there with
efl 1.7.10 package.

Thoughts ?

Best regards,
Romain

> 
> Regards,
> Yann E. MORIN.
> 
>> +LIBEFL_CONF_OPTS += --with-x11=xcb
>> +endif
>> +
>>  # image loader: handle only loaders that requires dependencies.
>>  # All other loaders are builded by default statically.
>>  ifeq ($(BR2_PACKAGE_LIBEFL_PNG),y)
>> -- 
>> 2.4.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 14/36] package/efl/libefl: add X11 support
  2015-10-29 20:49     ` Romain Naour
@ 2015-10-29 21:01       ` Yann E. MORIN
  0 siblings, 0 replies; 94+ messages in thread
From: Yann E. MORIN @ 2015-10-29 21:01 UTC (permalink / raw)
  To: buildroot

Romain, All,

On 2015-10-29 21:49 +0100, Romain Naour spake thusly:
> Le 25/10/2015 16:01, Yann E. MORIN a ?crit :
> > On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
> >> Add an option to enable X11 support in libecore without graphic
> >> acceleration. libecore can use xlib or xcb support but the latter
> >> in not recommended by efl developpers.
> >>
> >> Also, set x-includes and x-libraries configure option for cross-compiling.
> >> Previous efl versions had cross-compilation issue (poisoned paths)
> >> if these options are not passed to configure script.
> >>
> >> In order to remove the dependency on libXp wich is no longer bundled in
> >> recent X11 release [1], backport an upstream patch [2] to remove xprint
> >> usage.
> >>
> >> [1] http://www.x.org/wiki/Releases/ModuleVersions
> >> [2] https://git.enlightenment.org/core/efl.git/commit/?h=efl-1.15&id=434572355c7e929b84210b2f795634d38f13c913
> >>
> >> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
[--SNIP--]
> >> +ifeq ($(BR2_PACKAGE_LIBEFL_X_XCB),y)
> >> +LIBEFL_DEPENDENCIES += libxcb \
> >> +	xcb-util-image \
> >> +	xcb-util-keysyms \
> >> +	xcb-util-renderutil \
> >> +	xcb-util-wm
> >> +# You have chosen to use XCB instead of Xlib. It is a myth that XCB
> >> +# is amazingly faster than Xlib (when used sensibly). It can be
> >> +# faster in a few corner cases on startup of an app, but it comes
> >> +# with many downsides. One of those is more complex code inside
> >> +# ecore_x, which is far less tested in XCB mode than Xlib. Also
> >> +# the big catch is that OpenGL support basically requires Xlib anyway
> >> +# so if you want OpenGL in X11, you need Xlib regardless and so you
> >> +# gain nothing really in terms of speed and no savings in memory
> >> +# because Xlib is still linked, loaded and used, BUT instead you
> >> +# have OpenGL drivers working with an hybrid XCB/Xlib (mostly XCB)
> >> +# toolkit and this is basically never tested by anyone working on
> >> +# the OpenGL drivers, so you will have bugs. Do not enable XCB
> >> +# and use OpenGL. XCB is only useful if you wish to shave a few Kb
> >> +# off the memory footprint of a whole system and live with less
> >> +# tested code, and possibly unimplemented features in ecore_x. To
> >> +# remove the XCB setup, remove the --with-x11=xcb option to
> >> +# configure.
> > 
> > Why this big comment? At best, it belongs to the help text of
> > BR2_PACKAGE_LIBEFL_X_XCB in the Config.in.
> > 
> > Also, I guess you're only quoting the EFL developers here, so you should
> > state so and add a pointer to that message upstream:
> > 
> >     https://git.enlightenment.org/core/efl.git/tree/configure.ac#n5002
> > 
> > But if it were purely on me, I would just drop it.
> 
> Well, I'm wondering if I should keep XCB support in this package since it's not
> a "recommended" configuration. I kept it only because it was already there with
> efl 1.7.10 package.
> 
> Thoughts ?

If you're not at ease with it, just ditch it. Just keep Xlib-based X11
support. Jus tsay so in the commit log, with something along the lines
of:

    Drop XCB support, since it is not very well supported by upstream.

If anyone is interested in XCB support, he would add it back.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 15/36] package/efl/libefl: add OpenGL/OpenGLES support
  2015-10-25 15:08   ` Yann E. MORIN
@ 2015-10-29 21:02     ` Romain Naour
  0 siblings, 0 replies; 94+ messages in thread
From: Romain Naour @ 2015-10-29 21:02 UTC (permalink / raw)
  To: buildroot

Hi Yann, All,

Le 25/10/2015 16:08, Yann E. MORIN a ?crit :
> Romain, All,
> 
> On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
>> Allow to enable graphic acceleration using OpenGL or
>> OpenGLES with efl libraries.
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>> v4: rename libefl
>>     improve commit log
>> ---
>>  package/efl/libefl/Config.in | 26 ++++++++++++++++++++++++++
>>  package/efl/libefl/libefl.mk | 17 +++++++++++++++--
>>  2 files changed, 41 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
>> index 8356fa1..a3b6f0e 100644
>> --- a/package/efl/libefl/Config.in
>> +++ b/package/efl/libefl/Config.in
>> @@ -81,6 +81,32 @@ comment "for libecore XCB support disable recommended configurations"
>>  
>>  endchoice
>>  
>> +if BR2_PACKAGE_LIBEFL_X_XLIB
>> +
>> +choice
>> +	prompt "select libevas OpenGL support"
>> +
>> +config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_FULL
>> +	bool "libevas OpenGL full support"
>> +	depends on BR2_PACKAGE_HAS_LIBGL
>> +
>> +comment "libevas OpenGLES support needs libgl"
>> +	depends on !BR2_PACKAGE_HAS_LIBGL
>> +
>> +config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_ES
>> +	bool "libevas OpenGLES support"
>> +	depends on BR2_PACKAGE_HAS_LIBGLES
>> +
>> +comment "libevas OpenGLES support needs libgles"
>> +	depends on !BR2_PACKAGE_HAS_LIBGLES
>> +
>> +config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_NONE
>> +	bool "libevas disable OpenGL support"
>> +
>> +endchoice
>> +
>> +endif # BR2_PACKAGE_LIBEFL_X_XLIB
>> +
> 
> Here is a proposal to rewrite the option names and prompts:
> 
>     choice
>         bool "OpenGL support"
>         default BR2_PACKAGE_LIBEFL_X_XLIB_OPENGL   if BR2_PACKAGE_HAS_LIBGL
>         default BR2_PACKAGE_LIBEFL_X_XLIB_OPENGLES if BR2_PACKAGE_HAS_LIBGLES
>         help
>           libevas can be configured to use HW acceleration with OpenGL
>           or OpenGLES.
> 
>     config BR2_PACKAGE_LIBEFL_X_XLIB_OPENGL_NONE
>         bool "none"
> 
>     config BR2_PACKAGE_LIBEFL_X_XLIB_OPENGL
>         bool "opengl"
>         depends on BR2_PACKAGE_HAS_LIBGL
> 
>     comment "opengl support needs an OpenGL provider"
>         depends on !BR2_PACKAGE_HAS_LIBGL
> 
>     config BR2_PACKAGE_LIBEFL_X_XLIB_OPENGLES
>         bool "opengles"
>         depends on BR2_PACKAGE_HAS_LIBGLES
> 
>     comment "opengles support needs an opengles provider"
>         depends on !BR2_PACKAGE_HAS_LIBGLES
> 
>     endchoice
> 
> If you fell inclined into adoptiong this, update the corresponding
> options in the .mk, of course.

No problem, the upcoming v6 of this series start to be heavily modified compared
to v5. So ok, "while at it" ;)

As you noticed in the followup patch, opengl support depends on X11 here.
I'll give a try to move opengl support outside of LIBEFL_X_XLIB

Best regards,
Romain

> 
> Regards,
> Yann E. MORIN.
> 
>>  endif # BR2_PACKAGE_LIBEFL_X
>>  
>>  comment "libevas loaders"
>> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
>> index 6a1a8ae..e275699 100644
>> --- a/package/efl/libefl/libefl.mk
>> +++ b/package/efl/libefl/libefl.mk
>> @@ -176,8 +176,7 @@ endif
>>  ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
>>  LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \
>>  	--x-includes=$(STAGING_DIR)/usr/include \
>> -	--x-libraries=$(STAGING_DIR)/usr/lib \
>> -	--with-opengl=none
>> +	--x-libraries=$(STAGING_DIR)/usr/lib
>>  
>>  LIBEFL_DEPENDENCIES += \
>>  	xlib_libX11 \
>> @@ -187,6 +186,20 @@ LIBEFL_CONF_OPTS += --with-x=no \
>>  	--with-x11=none
>>  endif
>>  
>> +ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB_GLX_FULL),y)
>> +LIBEFL_CONF_OPTS += --with-opengl=full
>> +LIBEFL_DEPENDENCIES += libgl
>> +endif
>> +
>> +ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB_GLX_ES),y)
>> +LIBEFL_CONF_OPTS += --with-opengl=es
>> +LIBEFL_DEPENDENCIES += libgles
>> +endif
>> +
>> +ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB_GLX_NONE),y)
>> +LIBEFL_CONF_OPTS += --with-opengl=none
>> +endif
>> +
>>  ifeq ($(BR2_PACKAGE_LIBEFL_X_XLIB),y)
>>  LIBEFL_DEPENDENCIES += \
>>  	xlib_libX11 \
>> -- 
>> 2.4.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 18/36] package/efl/libefl: add sdl2 support
  2015-10-25 15:20   ` Yann E. MORIN
@ 2015-10-29 21:17     ` Romain Naour
  0 siblings, 0 replies; 94+ messages in thread
From: Romain Naour @ 2015-10-29 21:17 UTC (permalink / raw)
  To: buildroot

Yann, All,

Le 25/10/2015 16:20, Yann E. MORIN a ?crit :
> Romain, All,
> 
> On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
>> SDL support can't be used with OpenGLES.
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>> v5: new patch added since sdl2 package is new available
>> ---
>>  package/efl/libefl/Config.in |  7 +++++++
>>  package/efl/libefl/libefl.mk | 11 +++++++++++
>>  2 files changed, 18 insertions(+)
>>
>> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
>> index a3b6f0e..44860a2 100644
>> --- a/package/efl/libefl/Config.in
>> +++ b/package/efl/libefl/Config.in
>> @@ -42,6 +42,12 @@ comment "libecore video support"
>>  config BR2_PACKAGE_LIBEFL_FB
>>  	bool "libecore framebuffer support"
>>  
>> +config BR2_PACKAGE_LIBEFL_SDL2
>> +	bool "libevas SDL2 support"
> 
> FB and X11 refere to libecore, but SDL2 refer to libevas. Is that an
> oversight, or is that correct?

It seems that enable sdl2 support for both.
There is even a ecore_evas_sdl.c file in the source.

> 
> However, I would simply drop it, to have just:
> 
>     FB support
>     SDL2 support
>     X11 support

Ok, I'll remove libecore/libevas reference.

> 
>> +	# SDL support is not available with OpenGLES.
>> +	depends on !BR2_PACKAGE_LIBEFL_X_XLIB_GLX_ES
>> +	select BR2_PACKAGE_SDL2
>> +
>>  config BR2_PACKAGE_LIBEFL_X
>>  	bool "libecore X support"
>>  	depends on BR2_PACKAGE_XORG7
>> @@ -89,6 +95,7 @@ choice
>>  config BR2_PACKAGE_LIBEFL_X_XLIB_GLX_FULL
>>  	bool "libevas OpenGL full support"
>>  	depends on BR2_PACKAGE_HAS_LIBGL
>> +	select BR2_PACKAGE_LIBGLU if BR2_PACKAGE_LIBEFL_SDL2 # evas depends on libglu header in evas_engine.c
> 
> I have troubles understanding this set of options.
> 
> So, with the current code, one may select SDL2 and not X11. Is that a
> viable situation?
> 
> If so, then OpenGL support will never be available, since OpenGL depends
> on X11 being enabled. Is that OK? Don't you need to unhide the OpenGL
> choice for SDL2 too?
> 
> Did I miss something?

I'm not very familiar with graphic stuff (X11, opengl, sdl), so the efl
packaging on this part can be wrong.

> 
>>  comment "libevas OpenGLES support needs libgl"
>>  	depends on !BR2_PACKAGE_HAS_LIBGL
>> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
>> index c26c9c5..8ddca64 100644
>> --- a/package/efl/libefl/libefl.mk
>> +++ b/package/efl/libefl/libefl.mk
>> @@ -180,6 +180,17 @@ else
>>  LIBEFL_CONF_OPTS += --enable-fb=no
>>  endif
>>  
>> +ifeq ($(BR2_PACKAGE_LIBEFL_SDL2),y)
>> +LIBEFL_CONF_OPTS += --enable-sdl=yes
>> +LIBEFL_DEPENDENCIES += sdl2
>> +else
>> +LIBEFL_CONF_OPTS += --enable-sdl=no
>> +endif
>> +
>> +ifeq ($(BR2_PACKAGE_EFL_X_XLIB_GLX_FULL)$(BR2_PACKAGE_EFL_SDL2),yy)
>> +EFL_DEPENDENCIES += libglu
>> +endif
> 
> Hmm.. It seems that SDL2 can be over X11, right?
> 
> So, how does SDL2 compare to FB and X11? Is it at the same "level" (i.e.
> a rendering backend talking to the hardwware), or is it layered on-top
> of X11?

The sdl2 support can't be enabled with opengles, so it require a full opengl
support which require X11. So sdl2 should be only available when X11 is enable.

I'll probably drop the sdl2 patch for now and continue with the remaining
patches. I'll try to add it in a followup patch.

Best regards,
Romain

> 
> Regards,
> Yann E. MORIN.
> 
>>  # --enable-xinput22 is recommended
>>  ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
>>  LIBEFL_CONF_OPTS += --with-x=$(STAGING_DIR) \
>> -- 
>> 2.4.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 17/36] package/efl/libefl: add systemd dependency
  2015-10-25 15:13   ` Yann E. MORIN
@ 2015-10-29 21:38     ` Romain Naour
  0 siblings, 0 replies; 94+ messages in thread
From: Romain Naour @ 2015-10-29 21:38 UTC (permalink / raw)
  To: buildroot

Yann, All,

Le 25/10/2015 16:13, Yann E. MORIN a ?crit :
> Romain, All,
> 
> On 2015-10-24 23:00 +0200, Romain Naour spake thusly:
>> systemd it one of the "highly recommended" dependecies
>> according to the README [1] but disabling it doesn't need
>> the --enable-i-really-know-what-i-am-doing... option.
>> That's why systemd is not added to
>> BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG.
>>
>> [1] https://git.enlightenment.org/core/efl.git/tree/README?h=efl-1.15#n491
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> 
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> However, see a comment, below...
> 
>> ---
>> v4: rename to libefl
>>     improve commit log
>> v3: new patch
>> ---
>>  package/efl/libefl/libefl.mk | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
>> index 02c9005..c26c9c5 100644
>> --- a/package/efl/libefl/libefl.mk
>> +++ b/package/efl/libefl/libefl.mk
>> @@ -52,6 +52,13 @@ ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBBLKID),y)
>>  LIBEFL_DEPENDENCIES += util-linux
>>  endif
>>  
>> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
>> +LIBEFL_CONF_OPTS += --enable-systemd
>> +LIBEFL_DEPENDENCIES += systemd
>> +else
>> +LIBEFL_CONF_OPTS += --disable-systemd
>> +endif
> 
> You're adding optional dependencies with various patches; that's
> perfectly good.
> 
> However, I woiuld like that all those optional features be forcibly
> disabled form the first patch adding libefl. Then each of your patches
> would transform the hard-coded --disable-XXXX into conditional blocks
> (with or without Config.in options).

There is a very long list of config options that are not handled by the
packaging actually, I'll try to do that at least for the option I use in the
package and for auto detected options.

Speaking of config option, some of them use --disable-XXXX and --enable-XXXX,
but some other use --enable-XXXX=no and --enable-XXXX=yes. I'll unify this by
using --disable-XXXX and --enable-XXXX.

Best regards,
Romain

> 
> Regards,
> Yann E. MORIN.
> 
>>  # If fontconfig is disabled, this is going to make general font
>>  # searching not work, and only some very direct 'load /path/file.ttf'
>>  # will work alongside some old-school ttf file path searching. This
>> -- 
>> 2.4.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 24/36] package/enlightenment: bump to version 0.19.12
  2015-10-25 16:28   ` Yann E. MORIN
@ 2015-10-31 14:10     ` Romain Naour
  0 siblings, 0 replies; 94+ messages in thread
From: Romain Naour @ 2015-10-31 14:10 UTC (permalink / raw)
  To: buildroot

Hi Yann, All,

Le 25/10/2015 17:28, Yann E. MORIN a ?crit :
> Romain, All,
> 
> On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
>> Use the newly added libefl package wich provide a new version
>> of efl libraries.
>> This new version needs libelementary dependency.
>>
>> Update upstream url, add hash file and use xz archive.
>>
>> Select png and jpeg image loader since enlightenment_start
>> fail at runtime if png and jpeg image loader are not
>> available in elf libraries.
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>> v5: Use depends on BR2_PACKAGE_EFL instead of select (ThomasP)
>>     remove comment on dependencies
>> v4: update Config.in to use libefl
>>     improve commit log
>>     keep the dependency on threads
>> v3: bymp to 0.19.12
>>     remove trailing slash (Vicente Bergas)
>> v2: bump to 0.19.9
>>     remove glibc only dependency
>> ---
>>  package/enlightenment/Config.in          | 36 +++++++-------------------------
>>  package/enlightenment/enlightenment.hash |  2 ++
>>  package/enlightenment/enlightenment.mk   | 22 +++++++------------
>>  3 files changed, 17 insertions(+), 43 deletions(-)
>>  create mode 100644 package/enlightenment/enlightenment.hash
>>
>> diff --git a/package/enlightenment/Config.in b/package/enlightenment/Config.in
>> index 58f8f39..4a349fb 100644
>> --- a/package/enlightenment/Config.in
>> +++ b/package/enlightenment/Config.in
>> @@ -1,33 +1,16 @@
>>  config BR2_PACKAGE_ENLIGHTENMENT
>>  	bool "enlightenment"
>> -	select BR2_PACKAGE_EFL
>> -	select BR2_PACKAGE_LIBECORE
>> -	select BR2_PACKAGE_LIBECORE_X
>> -	select BR2_PACKAGE_LIBEINA
>> -	select BR2_PACKAGE_LIBEET
>> -	select BR2_PACKAGE_LIBEVAS
>> -	select BR2_PACKAGE_LIBEVAS_JPEG
>> -	select BR2_PACKAGE_LIBEVAS_PNG
>> -	select BR2_PACKAGE_LIBEVAS_EET
>> -	select BR2_PACKAGE_LIBECORE_EVAS
>> -	select BR2_PACKAGE_LIBEDJE
>> -	select BR2_PACKAGE_LIBEFREET
>> -	select BR2_PACKAGE_LIBEDBUS
>> -	select BR2_PACKAGE_LIBEIO
>> -	select BR2_PACKAGE_XCB_UTIL_KEYSYMS
>> +	select BR2_PACKAGE_LIBEFL_X
>> +	select BR2_PACKAGE_LIBEFL_JPEG # needed at runtime by enlightenment_start
>> +	select BR2_PACKAGE_LIBEFL_PNG # needed at runtime by enlightenment_start
>> +	select BR2_PACKAGE_LIBELEMENTARY
>>  	select BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
>>  	select BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
>> -	# libevas-generic-loaders-svg -> librsvg -> glib2 / pango
>> -	depends on BR2_USE_WCHAR
>> -	depends on BR2_INSTALL_LIBSTDCPP
>> -	# libedbus -> dbus
>> -	# libedbus -> glib2, libevas
>> -	depends on BR2_TOOLCHAIN_HAS_THREADS
>> -	# libedbus -> dbus, efl libraries
>> -	depends on BR2_USE_MMU
>> -	depends on BR2_PACKAGE_XORG7
>> +	select BR2_PACKAGE_XCB_UTIL_KEYSYMS
>>  	# libevas-generic-loaders-svg -> librsvg -> pango -> cairo
>>  	depends on BR2_ARCH_HAS_ATOMICS
>> +	depends on BR2_PACKAGE_EFL
>> +	depends on BR2_PACKAGE_XORG7
> 
> I really do not like those depends that go after the selects. It is
> more complex to read.
> 
> Even though the ordering has absolutely no consequences in Kconfig, it
> is not logical (when reading). It is more logical and far easier to
> understand when depends come first, followed by the selects.
> 
> (i.e it runs as thus in my head: this stuff needs foo and bar, so it
> depends on them. Then, once dependenecies are fullfilled, I can select
> other stuff.)
> 
> Note: it is not your fault, the code was already laid out thusly before
> your patch. Still, this is looking ugly to me.

Ok, I'll add some clean up patches then.

> 
>> diff --git a/package/enlightenment/enlightenment.mk b/package/enlightenment/enlightenment.mk
>> index ddebe06..9127099 100644
>> --- a/package/enlightenment/enlightenment.mk
>> +++ b/package/enlightenment/enlightenment.mk
>> @@ -4,24 +4,18 @@
>>  #
>>  ################################################################################
>>  
>> -ENLIGHTENMENT_VERSION = 0.17.6
>> -ENLIGHTENMENT_SITE = http://download.enlightenment.org/releases
>> +ENLIGHTENMENT_VERSION = 0.19.12
>> +ENLIGHTENMENT_SOURCE = enlightenment-$(ENLIGHTENMENT_VERSION).tar.xz
>> +ENLIGHTENMENT_SITE = http://download.enlightenment.org/rel/apps/enlightenment
>>  ENLIGHTENMENT_LICENSE = BSD-2c
>>  ENLIGHTENMENT_LICENSE_FILES = COPYING
>>  
>> -ENLIGHTENMENT_DEPENDENCIES = 	\
>> -	host-pkgconf 		\
>> -	libecore 		\
>> -	libeet 			\
>> -	libeina 		\
>> -	libevas 		\
>> +ENLIGHTENMENT_DEPENDENCIES = \
>> +	host-pkgconf \
>> +	host-libefl \
>> +	libefl \
>> +	libelementary \
>>  	libevas-generic-loaders \
>> -	libedje 		\
>> -	libefreet 		\
>> -	libedbus 		\
>> -	libeio 			\
>> -	host-libedje 		\
>> -	host-libeet		\
>>  	xcb-util-keysyms
>>  
>>  ENLIGHTENMENT_CONF_OPTS = \
> 
> A bit later in that file, we have:
> 
>     # alsa backend needs mixer support
>     ifeq ($(BR2_PACKAGE_ALSA_LIB)$(BR2_PACKAGE_ALSA_LIB_MIXER),yy)
>     ENLIGHTENMENT_DEPENDENCIES += alsa-lib

Probably I should add :
ENLIGHTENMENT_CONF_ENV += enable_alsa=yes

>     else
>     ENLIGHTENMENT_CONF_ENV += enable_alsa=no
>     endif
> 
> However, you previously said, when introducing libefl, that alsa support
> was not working at all (even when alsa-lib was found).
> 
> How does that affect the enlightment package?

It seems that there is a optional module mixer which use alsa.
As far I understand this support doesn't come from efl libraries.

Also I added --disable-pam and --disable-systemd to ENLIGHTENMENT_CONF_OPTS
since the support is auto detected.

Best regards,
Romain
> 
> Regards,
> Yann E. MORIN.
> 

^ permalink raw reply	[flat|nested] 94+ messages in thread

* [Buildroot] [PATCH v5 25/36] package/expedite: bump to efl-1.15 branch
  2015-10-25 16:36   ` Yann E. MORIN
@ 2015-10-31 14:19     ` Romain Naour
  0 siblings, 0 replies; 94+ messages in thread
From: Romain Naour @ 2015-10-31 14:19 UTC (permalink / raw)
  To: buildroot

Hi Yann, All,

Le 25/10/2015 17:36, Yann E. MORIN a ?crit :
> Romain, All,
> 
> On 2015-10-24 23:01 +0200, Romain Naour spake thusly:
>> Since expedite hasn't been released since 1.7.10 release,
>> use efl-1.15 branch in the git tree.
>>
>> Use the newly added libefl package wich provide a new version
>> of efl libraries.
>>
>> Autoreconf the package since there is no configure script
>> in the git tree.
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> [--SNIP--]
>> diff --git a/package/expedite/expedite.mk b/package/expedite/expedite.mk
>> index 9b232f8..ae30535 100644
>> --- a/package/expedite/expedite.mk
>> +++ b/package/expedite/expedite.mk
>> @@ -4,14 +4,19 @@
>>  #
>>  ################################################################################
>>  
>> -EXPEDITE_VERSION = 1.7.10
>> -EXPEDITE_SITE = http://download.enlightenment.org/releases
>> +# efl-1.15 branch
>> +EXPEDITE_VERSION = 3ce8b3f1451700f9a2da60c2e717c644220e2449
>> +EXPEDITE_SITE = http://git.enlightenment.org/tools/expedite.git
>> +EXPEDITE_SITE_METHOD = git
>>  EXPEDITE_LICENSE = BSD-2c
>>  EXPEDITE_LICENSE_FILES = COPYING
>>  
>> -EXPEDITE_DEPENDENCIES = libevas libeina libeet
>> +EXPEDITE_DEPENDENCIES = host-libefl libefl
> 
> It also uses PKG_CHECK_MODULES, so you need host-pkgconf.
> 
> BTW, please check the previous patches, I did not systematically checked
> for it. I've seen it on some of the efl packages, but I'm not sure all
> depend on host-pkgconf when needed.

Thanks, I've checked the previous patches and I added host-pkgconf to
libevas-generic-loaders and libemotion-generic-players

Thanks!

Best regards,
Romain

> 
> Regards,
> Yann E. MORIN.
> 
>> -ifeq ($(BR2_PACKAGE_LIBEVAS_X11),y)
>> +# There is no configure script in the git tree.
>> +EXPEDITE_AUTORECONF = YES
>> +
>> +ifeq ($(BR2_PACKAGE_LIBEFL_X),y)
>>  EXPEDITE_CONF_OPTS += --with-x=$(STAGING_DIR) \
>>  	--x-includes=$(STAGING_DIR)/usr/include \
>>  	--x-libraries=$(STAGING_DIR)/usr/lib
>> -- 
>> 2.4.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 94+ messages in thread

end of thread, other threads:[~2015-10-31 14:19 UTC | newest]

Thread overview: 94+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-24 21:00 [Buildroot] [PATCH v5 00/36] efl bump to 1.15.2 Romain Naour
2015-10-24 21:00 ` [Buildroot] [PATCH v5 01/36] package/expedite: move to package directory Romain Naour
2015-10-25 12:33   ` Yann E. MORIN
2015-10-24 21:00 ` [Buildroot] [PATCH v5 02/36] package/libevas-generic-loaders: " Romain Naour
2015-10-25 12:56   ` Yann E. MORIN
2015-10-25 19:21     ` Romain Naour
2015-10-25 21:04       ` Yann E. MORIN
2015-10-25 21:41         ` Romain Naour
2015-10-25 21:50           ` Yann E. MORIN
2015-10-24 21:00 ` [Buildroot] [PATCH v5 03/36] package/efl/libefl: new host-package Romain Naour
2015-10-25 13:10   ` Yann E. MORIN
2015-10-25 19:24     ` Romain Naour
2015-10-24 21:00 ` [Buildroot] [PATCH v5 04/36] package/efl/libefl: new package Romain Naour
2015-10-25 13:55   ` Yann E. MORIN
2015-10-26 21:53     ` Romain Naour
2015-10-27 19:16       ` Arnout Vandecappelle
2015-10-24 21:00 ` [Buildroot] [PATCH v5 05/36] package/efl/libefl: regenerate the configure script Romain Naour
2015-10-25 14:00   ` Yann E. MORIN
2015-10-24 21:00 ` [Buildroot] [PATCH v5 06/36] package/efl/libefl: add harfbuzz dependency Romain Naour
2015-10-25 14:22   ` Yann E. MORIN
2015-10-24 21:00 ` [Buildroot] [PATCH v5 07/36] package/efl/libefl: add wayland dependency Romain Naour
2015-10-25 14:25   ` Yann E. MORIN
2015-10-24 21:00 ` [Buildroot] [PATCH v5 08/36] package/efl/libefl: add libcurl dependency Romain Naour
2015-10-25 14:37   ` Yann E. MORIN
2015-10-28 21:39     ` Romain Naour
2015-10-24 21:00 ` [Buildroot] [PATCH v5 09/36] package/efl/libefl: add libblkid dependency Romain Naour
2015-10-25 14:40   ` Yann E. MORIN
2015-10-28 22:03     ` Romain Naour
2015-10-24 21:00 ` [Buildroot] [PATCH v5 10/36] package/efl/libefl: add webp dependency Romain Naour
2015-10-25 14:41   ` Yann E. MORIN
2015-10-24 21:00 ` [Buildroot] [PATCH v5 11/36] package/efl/libefl: add frame buffer config option Romain Naour
2015-10-25 12:31   ` Yann E. MORIN
2015-10-25 12:33     ` Yann E. MORIN
2015-10-25 14:43   ` Yann E. MORIN
2015-10-24 21:00 ` [Buildroot] [PATCH v5 12/36] package/efl/libefl: fix framebuffer support Romain Naour
2015-10-25 14:45   ` Yann E. MORIN
2015-10-24 21:00 ` [Buildroot] [PATCH v5 13/36] package/efl/libefl: add jp2k config option Romain Naour
2015-10-25 14:48   ` Yann E. MORIN
2015-10-26 22:04     ` Romain Naour
2015-10-25 14:48   ` Yann E. MORIN
2015-10-24 21:00 ` [Buildroot] [PATCH v5 14/36] package/efl/libefl: add X11 support Romain Naour
2015-10-25 15:01   ` Yann E. MORIN
2015-10-29 20:49     ` Romain Naour
2015-10-29 21:01       ` Yann E. MORIN
2015-10-24 21:00 ` [Buildroot] [PATCH v5 15/36] package/efl/libefl: add OpenGL/OpenGLES support Romain Naour
2015-10-25 15:08   ` Yann E. MORIN
2015-10-29 21:02     ` Romain Naour
2015-10-24 21:00 ` [Buildroot] [PATCH v5 16/36] package/efl/libefl: enable xinput2.2 Romain Naour
2015-10-25 15:11   ` Yann E. MORIN
2015-10-24 21:00 ` [Buildroot] [PATCH v5 17/36] package/efl/libefl: add systemd dependency Romain Naour
2015-10-25 15:13   ` Yann E. MORIN
2015-10-29 21:38     ` Romain Naour
2015-10-24 21:00 ` [Buildroot] [PATCH v5 18/36] package/efl/libefl: add sdl2 support Romain Naour
2015-10-25 15:20   ` Yann E. MORIN
2015-10-29 21:17     ` Romain Naour
2015-10-24 21:00 ` [Buildroot] [PATCH v5 19/36] package/libevas-generic-loaders: bump to version 1.15.0 Romain Naour
2015-10-25 16:01   ` Yann E. MORIN
2015-10-25 21:08     ` Yann E. MORIN
2015-10-24 21:01 ` [Buildroot] [PATCH v5 20/36] package/libevas-generic-loaders: add libraw dependency Romain Naour
2015-10-25 16:03   ` Yann E. MORIN
2015-10-24 21:01 ` [Buildroot] [PATCH v5 21/36] package/efl/libelementary: bump to version 1.15.2 Romain Naour
2015-10-25 16:09   ` Yann E. MORIN
2015-10-24 21:01 ` [Buildroot] [PATCH v5 22/36] package/efl/libelementary: add host package Romain Naour
2015-10-25 16:11   ` Yann E. MORIN
2015-10-24 21:01 ` [Buildroot] [PATCH v5 23/36] package/efl: libefl and libelementary share the same version number Romain Naour
2015-10-25 16:13   ` Yann E. MORIN
2015-10-24 21:01 ` [Buildroot] [PATCH v5 24/36] package/enlightenment: bump to version 0.19.12 Romain Naour
2015-10-25 16:28   ` Yann E. MORIN
2015-10-31 14:10     ` Romain Naour
2015-10-24 21:01 ` [Buildroot] [PATCH v5 25/36] package/expedite: bump to efl-1.15 branch Romain Naour
2015-10-25 16:36   ` Yann E. MORIN
2015-10-31 14:19     ` Romain Naour
2015-10-24 21:01 ` [Buildroot] [PATCH v5 26/36] package/efl/libethumb: remove package Romain Naour
2015-10-25 16:38   ` Yann E. MORIN
2015-10-24 21:01 ` [Buildroot] [PATCH v5 27/36] package/efl/libedje: " Romain Naour
2015-10-25 16:41   ` Yann E. MORIN
2015-10-24 21:01 ` [Buildroot] [PATCH v5 28/36] package/efl/libembryo: " Romain Naour
2015-10-25 16:43   ` Yann E. MORIN
2015-10-24 21:01 ` [Buildroot] [PATCH v5 29/36] package/efl/libeio: " Romain Naour
2015-10-25 16:44   ` Yann E. MORIN
2015-10-24 21:01 ` [Buildroot] [PATCH v5 30/36] package/efl/libefreet: " Romain Naour
2015-10-25 16:45   ` Yann E. MORIN
2015-10-24 21:01 ` [Buildroot] [PATCH v5 31/36] package/efl/libedbus: " Romain Naour
2015-10-25 16:46   ` Yann E. MORIN
2015-10-24 21:01 ` [Buildroot] [PATCH v5 32/36] package/efl/libecore: " Romain Naour
2015-10-25 16:50   ` Yann E. MORIN
2015-10-24 21:01 ` [Buildroot] [PATCH v5 33/36] package/efl/libevas: " Romain Naour
2015-10-25 16:52   ` Yann E. MORIN
2015-10-24 21:01 ` [Buildroot] [PATCH v5 34/36] package/efl/libeet: " Romain Naour
2015-10-25 16:52   ` Yann E. MORIN
2015-10-24 21:01 ` [Buildroot] [PATCH v5 35/36] package/efl/libeina: " Romain Naour
2015-10-25 16:56   ` Yann E. MORIN
2015-10-24 21:01 ` [Buildroot] [PATCH v5 36/36] package/libemotion-generic-players: new package Romain Naour
2015-10-25 17:04   ` Yann E. MORIN

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.