* [PATCH] i2c: busses: Use setup_timer
@ 2015-10-20 18:17 Muhammad Falak R Wani
2015-10-25 14:58 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Muhammad Falak R Wani @ 2015-10-20 18:17 UTC (permalink / raw)
To: Vitaly Wool, Wolfram Sang, linux-i2c, linux-kernel; +Cc: Muhammad Falak R Wani
Use timer API function setup_timer instead of init_timer to
initialize the timer.
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
drivers/i2c/busses/i2c-pnx.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pnx.c b/drivers/i2c/busses/i2c-pnx.c
index e814a36..cdbf632 100644
--- a/drivers/i2c/busses/i2c-pnx.c
+++ b/drivers/i2c/busses/i2c-pnx.c
@@ -659,9 +659,8 @@ static int i2c_pnx_probe(struct platform_device *pdev)
if (IS_ERR(alg_data->clk))
return PTR_ERR(alg_data->clk);
- init_timer(&alg_data->mif.timer);
- alg_data->mif.timer.function = i2c_pnx_timeout;
- alg_data->mif.timer.data = (unsigned long)alg_data;
+ setup_timer(&alg_data->mif.timer, i2c_pnx_timeout,
+ (unsigned long)alg_data);
snprintf(alg_data->adapter.name, sizeof(alg_data->adapter.name),
"%s", pdev->name);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: busses: Use setup_timer
2015-10-20 18:17 [PATCH] i2c: busses: Use setup_timer Muhammad Falak R Wani
@ 2015-10-25 14:58 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2015-10-25 14:58 UTC (permalink / raw)
To: Muhammad Falak R Wani; +Cc: Vitaly Wool, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
On Tue, Oct 20, 2015 at 11:47:19PM +0530, Muhammad Falak R Wani wrote:
> Use timer API function setup_timer instead of init_timer to
> initialize the timer.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Please note that the proper prefix in the subject would be "i2c: pnx: "
Fixed this and applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-25 14:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-20 18:17 [PATCH] i2c: busses: Use setup_timer Muhammad Falak R Wani
2015-10-25 14:58 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.