From: Mark Rutland <mark.rutland@arm.com> To: fu.wei@linaro.org Cc: linaro-acpi@lists.linaro.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, tekkamanninja@gmail.com, arnd@arndb.de, linux@roeck-us.net, vgandhi@codeaurora.org, wim@iguana.be, jcm@redhat.com, leo.duran@amd.com, corbet@lwn.net, catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net, dyoung@redhat.com, panand@redhat.com, Suravee.Suthikulpanit@amd.com, robherring2@gmail.com Subject: Re: [PATCH v8 1/5] Documentation: add sbsa-gwdt driver documentation Date: Tue, 27 Oct 2015 16:22:57 +0000 [thread overview] Message-ID: <20151027162257.GJ3091@leverpostej> (raw) In-Reply-To: <1445961999-9506-2-git-send-email-fu.wei@linaro.org> On Wed, Oct 28, 2015 at 12:06:35AM +0800, fu.wei@linaro.org wrote: > From: Fu Wei <fu.wei@linaro.org> > > The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for > introducing SBSA(Server Base System Architecture) Generic Watchdog > device node info into FDT. > > Also add sbsa-gwdt introduction in watchdog-parameters.txt > > Acked-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Fu Wei <fu.wei@linaro.org> > --- > .../devicetree/bindings/watchdog/sbsa-gwdt.txt | 46 ++++++++++++++++++++++ > Documentation/watchdog/watchdog-parameters.txt | 6 +++ > 2 files changed, 52 insertions(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt b/Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt > new file mode 100644 > index 0000000..ad8e99a > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt > @@ -0,0 +1,46 @@ > +* SBSA (Server Base System Architecture) Generic Watchdog > + > +The SBSA Generic Watchdog Timer is used to force a reset of the system > +after two stages of timeout have elapsed. A detailed definition of the > +watchdog timer can be found in the ARM document: ARM-DEN-0029 - Server > +Base System Architecture (SBSA) > + > +Required properties: > +- compatible: Should at least contain "arm,sbsa-gwdt". > + > +- reg: Each entry specifies the base physical 64-bit address of a register > + frame and the 64-bit length of that frame; currently, two frames must be Remove "64-bit" here. This depends on #address-cells and #size-cells, as usual. > + defined, in this order: > + 1: Watchdog control frame > + 2: Refresh frame. > + > +- interrupts: At least one interrupt must be defined that will be used as > + the WS0 interrupt. A WS1 interrupt definition can be provided, but is > + optional. The interrupts must be defined in this order: > + 1: WS0 interrupt > + 2: WS1 interrupt Why is WS1 optional? > +Optional properties > +- timeout-sec: To use a timeout value that is different from the driver > + default values, use this property. Either define a default value, or don't state anything about the behaviour when this is not present. > If used, at least one timeout value > + (in seconds) must be provided. A second optional timeout value (in > + seconds) may also be provided and will be used as the pre-timeout value, > + if it is given. > + > + There are two possible sources for driver default timeout values: > + (1) the driver contains hard-coded default values, or > + (2) module parameters can be given when the module is loaded > + > + If timeout/pretimeout values are provided when the module loads, they > + will take priority. Second priority will be the timeout-sec from DTB, > + and third the hard-coded driver values. The last two paragraphs should go. They describe Linux behaviour rather than the binding. Thanks, Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> To: fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org Cc: linaro-acpi-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tekkamanninja-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, vgandhi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, leo.duran-5C7GfCeVMHo@public.gmane.org, corbet-T1hC0tSOHrs@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org, dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, panand-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org, robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Subject: Re: [PATCH v8 1/5] Documentation: add sbsa-gwdt driver documentation Date: Tue, 27 Oct 2015 16:22:57 +0000 [thread overview] Message-ID: <20151027162257.GJ3091@leverpostej> (raw) In-Reply-To: <1445961999-9506-2-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> On Wed, Oct 28, 2015 at 12:06:35AM +0800, fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org wrote: > From: Fu Wei <fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > > The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for > introducing SBSA(Server Base System Architecture) Generic Watchdog > device node info into FDT. > > Also add sbsa-gwdt introduction in watchdog-parameters.txt > > Acked-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> > Signed-off-by: Fu Wei <fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > --- > .../devicetree/bindings/watchdog/sbsa-gwdt.txt | 46 ++++++++++++++++++++++ > Documentation/watchdog/watchdog-parameters.txt | 6 +++ > 2 files changed, 52 insertions(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt b/Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt > new file mode 100644 > index 0000000..ad8e99a > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt > @@ -0,0 +1,46 @@ > +* SBSA (Server Base System Architecture) Generic Watchdog > + > +The SBSA Generic Watchdog Timer is used to force a reset of the system > +after two stages of timeout have elapsed. A detailed definition of the > +watchdog timer can be found in the ARM document: ARM-DEN-0029 - Server > +Base System Architecture (SBSA) > + > +Required properties: > +- compatible: Should at least contain "arm,sbsa-gwdt". > + > +- reg: Each entry specifies the base physical 64-bit address of a register > + frame and the 64-bit length of that frame; currently, two frames must be Remove "64-bit" here. This depends on #address-cells and #size-cells, as usual. > + defined, in this order: > + 1: Watchdog control frame > + 2: Refresh frame. > + > +- interrupts: At least one interrupt must be defined that will be used as > + the WS0 interrupt. A WS1 interrupt definition can be provided, but is > + optional. The interrupts must be defined in this order: > + 1: WS0 interrupt > + 2: WS1 interrupt Why is WS1 optional? > +Optional properties > +- timeout-sec: To use a timeout value that is different from the driver > + default values, use this property. Either define a default value, or don't state anything about the behaviour when this is not present. > If used, at least one timeout value > + (in seconds) must be provided. A second optional timeout value (in > + seconds) may also be provided and will be used as the pre-timeout value, > + if it is given. > + > + There are two possible sources for driver default timeout values: > + (1) the driver contains hard-coded default values, or > + (2) module parameters can be given when the module is loaded > + > + If timeout/pretimeout values are provided when the module loads, they > + will take priority. Second priority will be the timeout-sec from DTB, > + and third the hard-coded driver values. The last two paragraphs should go. They describe Linux behaviour rather than the binding. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-27 16:23 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-10-27 16:06 [PATCH v8 0/5] Watchdog: introduce ARM SBSA watchdog driver fu.wei 2015-10-27 16:06 ` [PATCH v8 1/5] Documentation: add sbsa-gwdt driver documentation fu.wei 2015-10-27 16:22 ` Mark Rutland [this message] 2015-10-27 16:22 ` Mark Rutland 2015-10-28 4:10 ` Fu Wei 2015-10-28 4:10 ` Fu Wei 2015-10-30 17:46 ` Timur Tabi 2015-10-30 17:46 ` Timur Tabi 2015-10-30 18:35 ` Fu Wei 2015-10-30 18:53 ` Timur Tabi 2015-10-30 18:53 ` Timur Tabi 2015-10-30 19:05 ` Mark Rutland 2015-10-30 20:37 ` Timur Tabi 2015-11-02 4:10 ` Fu Wei 2015-11-02 4:10 ` Fu Wei 2015-11-02 4:03 ` Fu Wei 2015-11-02 4:03 ` Fu Wei 2015-11-02 4:06 ` Timur Tabi 2015-11-02 4:06 ` Timur Tabi 2015-11-02 4:23 ` Jon Masters 2015-10-27 16:06 ` [PATCH v8 2/5] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts fu.wei 2015-10-27 16:06 ` [PATCH v8 3/5] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi fu.wei 2015-10-27 16:06 ` [PATCH v8 4/5] Watchdog: introdouce "pretimeout" into framework fu.wei 2015-10-27 16:06 ` [PATCH v8 5/5] Watchdog: introduce ARM SBSA watchdog driver fu.wei 2015-11-05 1:59 ` [Linaro-acpi] " Timur Tabi 2015-11-05 5:13 ` Guenter Roeck 2015-11-05 11:58 ` Fu Wei 2015-11-05 13:47 ` Timur Tabi 2015-11-05 13:47 ` Timur Tabi 2015-11-05 13:47 ` Timur Tabi 2015-11-05 14:03 ` Fu Wei 2015-11-05 14:03 ` Fu Wei 2015-11-05 14:08 ` Timur Tabi 2015-11-05 14:35 ` Fu Wei 2015-11-05 14:40 ` Timur Tabi 2015-11-05 15:00 ` Fu Wei 2015-11-05 16:41 ` Guenter Roeck 2015-11-05 17:58 ` Fu Wei 2015-11-05 17:59 ` Timur Tabi 2015-11-05 18:04 ` Fu Wei 2015-11-13 0:06 ` Al Stone 2015-11-13 0:23 ` Timur Tabi 2015-11-19 23:50 ` Al Stone 2015-11-13 0:25 ` Guenter Roeck 2015-11-13 0:25 ` Guenter Roeck 2015-11-20 0:11 ` Al Stone 2015-11-20 0:11 ` Al Stone 2015-11-20 0:26 ` Timur Tabi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20151027162257.GJ3091@leverpostej \ --to=mark.rutland@arm.com \ --cc=Suravee.Suthikulpanit@amd.com \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=corbet@lwn.net \ --cc=devicetree@vger.kernel.org \ --cc=dyoung@redhat.com \ --cc=fu.wei@linaro.org \ --cc=jcm@redhat.com \ --cc=leo.duran@amd.com \ --cc=linaro-acpi@lists.linaro.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=panand@redhat.com \ --cc=rjw@rjwysocki.net \ --cc=robherring2@gmail.com \ --cc=tekkamanninja@gmail.com \ --cc=vgandhi@codeaurora.org \ --cc=will.deacon@arm.com \ --cc=wim@iguana.be \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.