From: Wolfram Sang <wsa@the-dreams.de>
To: Nicola Corna <nicola@corna.info>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>,
Jonathan Cameron <jic23@kernel.org>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 4/4] iio: humidity: si7020: added No Hold read mode
Date: Wed, 28 Oct 2015 00:30:00 +0100 [thread overview]
Message-ID: <20151027233000.GB1572@katana> (raw)
In-Reply-To: <1445976718-7449-4-git-send-email-nicola@corna.info>
[-- Attachment #1: Type: text/plain, Size: 215 bytes --]
Not a complete review, I just stumbled over this one:
> + if (client->adapter->quirks &&
> + client->adapter->quirks->flags |
'|' should be '&', or?
> + I2C_AQ_NO_CLK_STRETCH)
> + return -ENODEV;
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] iio: humidity: si7020: added No Hold read mode
Date: Wed, 28 Oct 2015 00:30:00 +0100 [thread overview]
Message-ID: <20151027233000.GB1572@katana> (raw)
In-Reply-To: <1445976718-7449-4-git-send-email-nicola@corna.info>
Not a complete review, I just stumbled over this one:
> + if (client->adapter->quirks &&
> + client->adapter->quirks->flags |
'|' should be '&', or?
> + I2C_AQ_NO_CLK_STRETCH)
> + return -ENODEV;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151028/0f7f2007/attachment.sig>
next prev parent reply other threads:[~2015-10-27 23:30 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 20:11 [PATCH 1/4] i2c: added i2c quirk flag for unsupported clock stretching Nicola Corna
2015-10-27 20:11 ` Nicola Corna
2015-10-27 20:11 ` Nicola Corna
2015-10-27 20:11 ` [PATCH 2/4] i2c: added I2C_AQ_NO_CLK_STRETCH to i2c-algo-bit.c Nicola Corna
2015-10-27 20:11 ` Nicola Corna
2015-10-27 20:11 ` Nicola Corna
2015-10-27 20:11 ` [PATCH 3/4] i2c: added I2C_AQ_NO_CLK_STRETCH to i2c-bcm2835.c Nicola Corna
2015-10-27 20:11 ` Nicola Corna
2015-10-27 20:11 ` Nicola Corna
[not found] ` <1445976718-7449-3-git-send-email-nicola-V0pQiMyom5mh6J55Ss3d3w@public.gmane.org>
2015-10-28 19:16 ` Eric Anholt
2015-10-28 19:16 ` Eric Anholt
2015-10-28 19:16 ` Eric Anholt
2015-10-29 4:10 ` Stephen Warren
2015-10-29 4:10 ` Stephen Warren
2015-10-27 20:11 ` [PATCH v3 4/4] iio: humidity: si7020: added No Hold read mode Nicola Corna
2015-10-27 20:11 ` Nicola Corna
2015-10-27 20:11 ` Nicola Corna
2015-10-27 23:30 ` Wolfram Sang [this message]
2015-10-27 23:30 ` Wolfram Sang
2015-10-28 6:46 ` Nicola Corna
2015-10-28 6:46 ` Nicola Corna
2015-10-28 6:46 ` Nicola Corna
2015-10-28 6:58 ` [PATCH v4 " Nicola Corna
2015-10-28 6:58 ` Nicola Corna
2015-10-28 6:58 ` Nicola Corna
[not found] ` <1446015506-21371-1-git-send-email-nicola-V0pQiMyom5mh6J55Ss3d3w@public.gmane.org>
2015-10-28 9:38 ` Lars-Peter Clausen
2015-10-28 9:38 ` Lars-Peter Clausen
2015-10-28 9:38 ` Lars-Peter Clausen
2015-10-28 18:35 ` Nicola Corna
2015-10-28 18:35 ` Nicola Corna
2015-10-28 18:46 ` Lars-Peter Clausen
2015-10-28 18:46 ` Lars-Peter Clausen
2015-10-28 20:17 ` Nicola Corna
2015-10-28 20:17 ` Nicola Corna
2015-10-28 20:17 ` Nicola Corna
[not found] ` <563117FB.5030506-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2015-10-28 20:19 ` Nicola Corna
2015-10-28 20:19 ` Nicola Corna
2015-10-28 20:19 ` Nicola Corna
2015-10-29 9:17 ` Lars-Peter Clausen
2015-10-29 9:17 ` Lars-Peter Clausen
2015-10-29 11:34 ` [PATCH v2 1/5] i2c: add i2c quirk flag for unsupported clock stretching Nicola Corna
2015-10-29 11:34 ` Nicola Corna
2015-10-29 11:34 ` Nicola Corna
2015-10-29 11:34 ` [PATCH v2 2/5] i2c: add I2C_AQ_NO_CLK_STRETCH to i2c-algo-bit.c Nicola Corna
2015-10-29 11:34 ` Nicola Corna
2015-10-29 11:34 ` Nicola Corna
[not found] ` <1446118467-26453-2-git-send-email-nicola-V0pQiMyom5mh6J55Ss3d3w@public.gmane.org>
2015-11-30 17:26 ` Wolfram Sang
2015-11-30 17:26 ` Wolfram Sang
2015-11-30 17:26 ` Wolfram Sang
2015-10-29 11:34 ` [PATCH v2 3/5] i2c: add I2C_AQ_NO_CLK_STRETCH to i2c-bcm2835.c Nicola Corna
2015-10-29 11:34 ` Nicola Corna
2015-10-29 11:34 ` Nicola Corna
2015-11-30 17:27 ` Wolfram Sang
2015-11-30 17:27 ` Wolfram Sang
2015-10-29 11:34 ` [PATCH 4/5] i2c: add i2c_check_quirks helper function Nicola Corna
2015-10-29 11:34 ` Nicola Corna
2015-10-29 11:34 ` Nicola Corna
[not found] ` <1446118467-26453-4-git-send-email-nicola-V0pQiMyom5mh6J55Ss3d3w@public.gmane.org>
2015-10-31 10:18 ` Jonathan Cameron
2015-10-31 10:18 ` Jonathan Cameron
2015-10-31 10:18 ` Jonathan Cameron
[not found] ` <56349581.8070900-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-11-30 17:28 ` Wolfram Sang
2015-11-30 17:28 ` Wolfram Sang
2015-11-30 17:28 ` Wolfram Sang
2015-11-30 17:30 ` Wolfram Sang
2015-11-30 17:30 ` Wolfram Sang
2015-10-29 11:34 ` [PATCH v5 5/5] iio: humidity: si7020: add No Hold read mode Nicola Corna
2015-10-29 11:34 ` Nicola Corna
2015-10-29 11:34 ` Nicola Corna
2015-10-31 10:21 ` Jonathan Cameron
2015-10-31 10:21 ` Jonathan Cameron
[not found] ` <56349644.2060308-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-11-30 17:33 ` Wolfram Sang
2015-11-30 17:33 ` Wolfram Sang
2015-11-30 17:33 ` Wolfram Sang
2015-12-05 18:24 ` Jonathan Cameron
2015-12-05 18:24 ` Jonathan Cameron
2015-12-05 19:01 ` Wolfram Sang
2015-12-05 19:01 ` Wolfram Sang
2017-05-10 14:46 ` Andrea Galbusera
2015-11-30 17:24 ` [PATCH v2 1/5] i2c: add i2c quirk flag for unsupported clock stretching Wolfram Sang
2015-11-30 17:24 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027233000.GB1572@katana \
--to=wsa@the-dreams.de \
--cc=eric@anholt.net \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=nicola@corna.info \
--cc=pmeerw@pmeerw.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.