* [Buildroot] [PATCH 1/1] boost: add option to build boost_coroutine
@ 2015-11-03 16:59 Edson Siqueira
2015-11-03 17:35 ` Thomas Petazzoni
2015-11-03 20:17 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Edson Siqueira @ 2015-11-03 16:59 UTC (permalink / raw)
To: buildroot
It was disabled by default by commit 611dfe6cb55ed72d7df3b7c102f4a723248a4037
due to the upgrade to boost 1.54.0.
Signed-off-by: Edson Siqueira <edson.siqueira@datacom.ind.br>
---
package/boost/Config.in | 4 ++++
package/boost/boost.mk | 4 +---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/package/boost/Config.in b/package/boost/Config.in
index ac70152..150174c 100644
--- a/package/boost/Config.in
+++ b/package/boost/Config.in
@@ -70,6 +70,10 @@ config BR2_PACKAGE_BOOST_CONTEXT
depends on (BR2_arm || BR2_armeb || BR2_i386 || BR2_mips || BR2_mipsel \
|| BR2_powerpc || BR2_sparc || BR2_x86_64)
+config BR2_PACKAGE_BOOST_COROUTINE
+ bool "boost-coroutine"
+ depends on BR2_PACKAGE_BOOST_CONTEXT
+
config BR2_PACKAGE_BOOST_DATE_TIME
bool "boost-date_time"
diff --git a/package/boost/boost.mk b/package/boost/boost.mk
index 16d05cd..80325b0 100644
--- a/package/boost/boost.mk
+++ b/package/boost/boost.mk
@@ -20,13 +20,11 @@ HOST_BOOST_FLAGS = --without-icu \
iostreams locale log math mpi program_options python random regex \
serialization signals system test thread timer wave)
-# coroutine breaks on some weak toolchains and it's new for 1.54+
-BOOST_WITHOUT_FLAGS = coroutine
-
BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_ATOMIC),,atomic)
BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_CHRONO),,chrono)
BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_CONTAINER),,container)
BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_CONTEXT),,context)
+BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_COROUTINE),,coroutine)
BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_DATE_TIME),,date_time)
BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_EXCEPTION),,exception)
BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_FILESYSTEM),,filesystem)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] boost: add option to build boost_coroutine
2015-11-03 16:59 [Buildroot] [PATCH 1/1] boost: add option to build boost_coroutine Edson Siqueira
@ 2015-11-03 17:35 ` Thomas Petazzoni
2015-11-03 18:14 ` DATACOM - Edson Siqueira
2015-11-03 20:17 ` Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2015-11-03 17:35 UTC (permalink / raw)
To: buildroot
Dear Edson Siqueira,
On Tue, 3 Nov 2015 14:59:38 -0200, Edson Siqueira wrote:
> It was disabled by default by commit 611dfe6cb55ed72d7df3b7c102f4a723248a4037
> due to the upgrade to boost 1.54.0.
>
> Signed-off-by: Edson Siqueira <edson.siqueira@datacom.ind.br>
Thanks for your contribution. However, you don't explain why you think
that the problems that lead to commit
611dfe6cb55ed72d7df3b7c102f4a723248a4037 have now been fixed. Can you
give more details ? Have you tested the configurations pointed by the
611dfe6cb55ed72d7df3b7c102f4a723248a4037 commit log and verified that
they now build fine with the coroutine module enabled ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] boost: add option to build boost_coroutine
2015-11-03 17:35 ` Thomas Petazzoni
@ 2015-11-03 18:14 ` DATACOM - Edson Siqueira
0 siblings, 0 replies; 4+ messages in thread
From: DATACOM - Edson Siqueira @ 2015-11-03 18:14 UTC (permalink / raw)
To: buildroot
Hello Thomas Petazzoni,
At the time of commit 611dfe6cb55ed72d7df3b7c102f4a723248a4037, this library
was new to boost and being built regardless of the config. The fix was to
always remove it from compilation to avoid problems with some compilers.
Now, with a proper option, it should be possible to enable it only when
the compiler supports the compilation of this library.
I've tested this patch using a ppc32 toolchain to build the library.
Thanks,
On 03-11-2015 15:35, Thomas Petazzoni wrote:
> Dear Edson Siqueira,
>
> On Tue, 3 Nov 2015 14:59:38 -0200, Edson Siqueira wrote:
>> It was disabled by default by commit 611dfe6cb55ed72d7df3b7c102f4a723248a4037
>> due to the upgrade to boost 1.54.0.
>>
>> Signed-off-by: Edson Siqueira <edson.siqueira@datacom.ind.br>
> Thanks for your contribution. However, you don't explain why you think
> that the problems that lead to commit
> 611dfe6cb55ed72d7df3b7c102f4a723248a4037 have now been fixed. Can you
> give more details ? Have you tested the configurations pointed by the
> 611dfe6cb55ed72d7df3b7c102f4a723248a4037 commit log and verified that
> they now build fine with the coroutine module enabled ?
>
> Thanks,
>
> Thomas
--
Edson Siqueira
DATACOM
Projetista de Software Embarcado - P&D
Rua da Gl?ria, 251 - 8 ? andar - Centro C?vico - Curitiba, PR
Fone: +55 41 3089-3670
edson.siqueira at datacom.ind.br
www.datacom.ind.br
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] boost: add option to build boost_coroutine
2015-11-03 16:59 [Buildroot] [PATCH 1/1] boost: add option to build boost_coroutine Edson Siqueira
2015-11-03 17:35 ` Thomas Petazzoni
@ 2015-11-03 20:17 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2015-11-03 20:17 UTC (permalink / raw)
To: buildroot
Dear Edson Siqueira,
On Tue, 3 Nov 2015 14:59:38 -0200, Edson Siqueira wrote:
> It was disabled by default by commit 611dfe6cb55ed72d7df3b7c102f4a723248a4037
> due to the upgrade to boost 1.54.0.
>
> Signed-off-by: Edson Siqueira <edson.siqueira@datacom.ind.br>
> ---
> package/boost/Config.in | 4 ++++
> package/boost/boost.mk | 4 +---
> 2 files changed, 5 insertions(+), 3 deletions(-)
Thanks, I've applied after doing a bit of research, and tweaking the
commit log as follows:
boost: add option to build boost_coroutine
It was disabled by default by commit
611dfe6cb55ed72d7df3b7c102f4a723248a4037 because it caused some build
failures on AArch64 and SuperH. However, the coroutine module needs
the context module, which is only available on certain architectures.
We can therefore allow enabling the coroutine module, but only if the
context module is available.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-03 20:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-03 16:59 [Buildroot] [PATCH 1/1] boost: add option to build boost_coroutine Edson Siqueira
2015-11-03 17:35 ` Thomas Petazzoni
2015-11-03 18:14 ` DATACOM - Edson Siqueira
2015-11-03 20:17 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.