* [patch -next] qlogic/qed: remove bogus NULL check
@ 2015-11-04 13:27 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-11-04 13:27 UTC (permalink / raw)
To: Yuval Mintz; +Cc: Ariel Elior, everest-linux-l2, netdev, kernel-janitors
We check if "p_hwfn" is NULL and then dereference it in the error
handling code. I read the code and it isn't NULL so let's remove the
check.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c b/drivers/net/ethernet/qlogic/qed/qed_int.c
index 2e399b6..de50e84 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_int.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_int.c
@@ -251,11 +251,6 @@ void qed_int_sp_dpc(unsigned long hwfn_cookie)
int arr_size;
u16 rc = 0;
- if (!p_hwfn) {
- DP_ERR(p_hwfn->cdev, "DPC called - no hwfn!\n");
- return;
- }
-
if (!p_hwfn->p_sp_sb) {
DP_ERR(p_hwfn->cdev, "DPC called - no p_sp_sb\n");
return;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [patch -next] qlogic/qed: remove bogus NULL check
@ 2015-11-04 13:27 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-11-04 13:27 UTC (permalink / raw)
To: Yuval Mintz; +Cc: Ariel Elior, everest-linux-l2, netdev, kernel-janitors
We check if "p_hwfn" is NULL and then dereference it in the error
handling code. I read the code and it isn't NULL so let's remove the
check.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c b/drivers/net/ethernet/qlogic/qed/qed_int.c
index 2e399b6..de50e84 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_int.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_int.c
@@ -251,11 +251,6 @@ void qed_int_sp_dpc(unsigned long hwfn_cookie)
int arr_size;
u16 rc = 0;
- if (!p_hwfn) {
- DP_ERR(p_hwfn->cdev, "DPC called - no hwfn!\n");
- return;
- }
-
if (!p_hwfn->p_sp_sb) {
DP_ERR(p_hwfn->cdev, "DPC called - no p_sp_sb\n");
return;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [patch -next] qlogic/qed: remove bogus NULL check
2015-11-04 13:27 ` Dan Carpenter
@ 2015-11-04 13:31 ` Yuval Mintz
-1 siblings, 0 replies; 6+ messages in thread
From: Yuval Mintz @ 2015-11-04 13:31 UTC (permalink / raw)
To: Dan Carpenter
Cc: Ariel Elior, Dept-Eng Everest Linux L2, netdev, kernel-janitors
> We check if "p_hwfn" is NULL and then dereference it in the error handling
> code. I read the code and it isn't NULL so let's remove the check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Our current interrupt handling logic is being uber-defensive. Thanks.
Acked-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [patch -next] qlogic/qed: remove bogus NULL check
@ 2015-11-04 13:31 ` Yuval Mintz
0 siblings, 0 replies; 6+ messages in thread
From: Yuval Mintz @ 2015-11-04 13:31 UTC (permalink / raw)
To: Dan Carpenter
Cc: Ariel Elior, Dept-Eng Everest Linux L2, netdev, kernel-janitors
> We check if "p_hwfn" is NULL and then dereference it in the error handling
> code. I read the code and it isn't NULL so let's remove the check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Our current interrupt handling logic is being uber-defensive. Thanks.
Acked-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch -next] qlogic/qed: remove bogus NULL check
2015-11-04 13:27 ` Dan Carpenter
@ 2015-11-05 3:06 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2015-11-05 3:06 UTC (permalink / raw)
To: dan.carpenter
Cc: Yuval.Mintz, Ariel.Elior, everest-linux-l2, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 4 Nov 2015 16:27:16 +0300
> We check if "p_hwfn" is NULL and then dereference it in the error
> handling code. I read the code and it isn't NULL so let's remove the
> check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch -next] qlogic/qed: remove bogus NULL check
@ 2015-11-05 3:06 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2015-11-05 3:06 UTC (permalink / raw)
To: dan.carpenter
Cc: Yuval.Mintz, Ariel.Elior, everest-linux-l2, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 4 Nov 2015 16:27:16 +0300
> We check if "p_hwfn" is NULL and then dereference it in the error
> handling code. I read the code and it isn't NULL so let's remove the
> check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-05 3:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-04 13:27 [patch -next] qlogic/qed: remove bogus NULL check Dan Carpenter
2015-11-04 13:27 ` Dan Carpenter
2015-11-04 13:31 ` Yuval Mintz
2015-11-04 13:31 ` Yuval Mintz
2015-11-05 3:06 ` David Miller
2015-11-05 3:06 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.