Re: [PATCH RESEND 16/16] regulator: add LM363X driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]

On Mon, Nov 02, 2015 at 02:24:35PM +0900, Milo Kim wrote:

This looks mostly good, just a few fairly small things:

> +lm363x_regulator_of_get_init_data(struct device *dev,
> +			struct lm363x_regulator *lm363x_regulator, int id)
> +{
> +	struct device_node *np = dev->of_node;
> +	int count;
> +
> +	count = of_regulator_match(dev, np, &lm363x_regulator_matches[id], 1);
> +	if (count <= 0)
> +		return ERR_PTR(-ENODEV);
> +
> +	return lm363x_regulator_matches[id].init_data;
> +}

Don't open code DT matching, use of_match in the regulator_desc and let
the core do it for you.

> +	/*
> +	 * Check LCM_EN1/2_GPIO is configured.
> +	 * Those pins are used for enabling VPOS/VNEG LDOs.
> +	 */
> +	if (id == LM3632_LDO_POS)
> +		gpio = of_get_named_gpio(np, "ti,lcm-en1-gpio", 0);
> +	else if (id == LM3632_LDO_NEG)
> +		gpio = of_get_named_gpio(np, "ti,lcm-en2-gpio", 0);

This looks like it should be a switch statement.

> +	rdev = regulator_register(&lm363x_regulator_desc[id], &cfg);
> +	if (IS_ERR(rdev)) {

Use devm_regulator_register().

> +static const struct of_device_id lm363x_regulator_of_match[] = {
> +	{ .compatible = "ti,lm363x-regulator" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, lm363x_regulator_of_match);

You shouldn't need a compatible string for a device like this, the MFD
should just register a platform device based on the compatible string
for the MFD.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]