All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Peter Hurley <peter@hurleysoftware.com>,
	Andre Przywara <andre.przywara@arm.com>,
	Andrew.Jackson@arm.com, Timur Tabi <timur@tabi.org>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>, Jun Nie <jun.nie@linaro.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 11/11] tty: amba-pl011: add support for ZTE UART (EXPERIMENTAL)
Date: Thu, 5 Nov 2015 09:27:04 +0000	[thread overview]
Message-ID: <20151105092703.GN8644@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CACRpkdbMUTUTJvCZXusMHDO4oqhXwo1DT8=h67ej9GSoDR5jvw@mail.gmail.com>

On Thu, Nov 05, 2015 at 09:28:23AM +0100, Linus Walleij wrote:
> On Tue, Nov 3, 2015 at 3:51 PM, Russell King
> <rmk+kernel@arm.linux.org.uk> wrote:
> 
> > Add (incomplete) support for the ZTE UART to the AMBA PL011 driver.
> > This is similar to the ARM and ST variants, except it has a different
> > register address layout, and requires 32-bit accesses to the registers.
> > Use the newly introduced register tables and access size support to
> > cope with these differences.
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> 
> I applied the whole series, 1-11 and tested on Ux500 (ST Micro variant)
> and on the ARM RealView PB11MPCore.
> 
> It works like a charm. I also like the looks of this transformation.
> Tested-by: Linus Walleij <linus.walleij@linaro.org>

As I mentioned, the change in pl011_putc() needs undoing (I've already
modified that in my series).  Also, I'll try switching to the relaxed
accessors and checking that.  Thanks for the tested-by though, can I
assume that you're happy I add that even with the pl011_putc() change
undone?

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/11] tty: amba-pl011: add support for ZTE UART (EXPERIMENTAL)
Date: Thu, 5 Nov 2015 09:27:04 +0000	[thread overview]
Message-ID: <20151105092703.GN8644@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CACRpkdbMUTUTJvCZXusMHDO4oqhXwo1DT8=h67ej9GSoDR5jvw@mail.gmail.com>

On Thu, Nov 05, 2015 at 09:28:23AM +0100, Linus Walleij wrote:
> On Tue, Nov 3, 2015 at 3:51 PM, Russell King
> <rmk+kernel@arm.linux.org.uk> wrote:
> 
> > Add (incomplete) support for the ZTE UART to the AMBA PL011 driver.
> > This is similar to the ARM and ST variants, except it has a different
> > register address layout, and requires 32-bit accesses to the registers.
> > Use the newly introduced register tables and access size support to
> > cope with these differences.
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> 
> I applied the whole series, 1-11 and tested on Ux500 (ST Micro variant)
> and on the ARM RealView PB11MPCore.
> 
> It works like a charm. I also like the looks of this transformation.
> Tested-by: Linus Walleij <linus.walleij@linaro.org>

As I mentioned, the change in pl011_putc() needs undoing (I've already
modified that in my series).  Also, I'll try switching to the relaxed
accessors and checking that.  Thanks for the tested-by though, can I
assume that you're happy I add that even with the pl011_putc() change
undone?

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2015-11-05  9:27 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-02 12:24 [PATCH DRAFT 0/2] Sketch for ZTE ZX296702 UART integration Andre Przywara
2015-11-02 12:24 ` Andre Przywara
2015-11-02 12:24 ` [PATCH DRAFT 1/2] drivers: serial: PL011: refactor register access Andre Przywara
2015-11-02 12:24   ` Andre Przywara
2015-11-02 13:27   ` Timur Tabi
2015-11-02 13:27     ` Timur Tabi
2015-11-02 13:40     ` Andre Przywara
2015-11-02 13:40       ` Andre Przywara
2015-11-02 13:44       ` Timur Tabi
2015-11-02 13:44         ` Timur Tabi
2015-11-02 12:24 ` [PATCH DRAFT 2/2] drivers: serial: PL011: [DRAFT] implement register diverson for ZTE UART Andre Przywara
2015-11-02 12:24   ` Andre Przywara
2015-11-03 13:46   ` Russell King - ARM Linux
2015-11-03 13:46     ` Russell King - ARM Linux
2015-11-03 13:57     ` Andre Przywara
2015-11-03 13:57       ` Andre Przywara
2015-11-05  9:54     ` Jun Nie
2015-11-05  9:54       ` Jun Nie
2015-11-03 14:23   ` Russell King - ARM Linux
2015-11-03 14:23     ` Russell King - ARM Linux
2015-11-03 14:30     ` Andre Przywara
2015-11-03 14:30       ` Andre Przywara
2015-11-03 13:43 ` [PATCH DRAFT 0/2] Sketch for ZTE ZX296702 UART integration Russell King - ARM Linux
2015-11-03 13:43   ` Russell King - ARM Linux
2015-11-03 14:48   ` Russell King - ARM Linux
2015-11-03 14:48     ` Russell King - ARM Linux
2015-11-03 14:50   ` [PATCH 01/11] tty: amba-pl011: add register accessor functions Russell King
2015-11-03 14:50     ` Russell King
2015-11-03 14:53     ` Timur Tabi
2015-11-03 14:53       ` Timur Tabi
2015-11-03 15:18       ` Russell King - ARM Linux
2015-11-03 15:18         ` Russell King - ARM Linux
2015-11-03 14:51   ` [PATCH 02/11] tty: amba-pl011: convert accessor functions to take uart_amba_port Russell King
2015-11-03 14:51     ` Russell King
2015-11-03 14:51   ` [PATCH 03/11] tty: amba-pl011: add helper to detect split LCRH register Russell King
2015-11-03 14:51     ` Russell King
2015-11-03 14:51   ` [PATCH 04/11] tty: amba-pl011: prepare REG_* register indexes Russell King
2015-11-03 14:51     ` Russell King
2015-11-03 14:51   ` [PATCH 05/11] tty: amba-pl011: add register lookup table Russell King
2015-11-03 14:51     ` Russell King
2015-11-06  0:00     ` Timur Tabi
2015-11-06  0:00       ` Timur Tabi
2015-11-06  0:24       ` Russell King - ARM Linux
2015-11-06  0:24         ` Russell King - ARM Linux
2015-11-06  0:27         ` Timur Tabi
2015-11-06  0:27           ` Timur Tabi
2015-12-13  6:03     ` Greg Kroah-Hartman
2015-12-13  6:03       ` Greg Kroah-Hartman
2015-11-03 14:51   ` [PATCH 06/11] tty: amba-pl011: add register offset table to vendor data Russell King
2015-11-03 14:51     ` Russell King
2015-11-03 14:51   ` [PATCH 07/11] tty: amba-pl011: add ST register offset table Russell King
2015-11-03 14:51     ` Russell King
2015-11-03 14:51   ` [PATCH 08/11] tty: amba-pl011: clean up LCR register offsets Russell King
2015-11-03 14:51     ` Russell King
2015-11-03 14:51   ` [PATCH 09/11] tty: amba-pl011: remove ST micro registers from standard table Russell King
2015-11-03 14:51     ` Russell King
2015-11-03 14:51   ` [PATCH 10/11] tty: amba-pl011: add support for 32-bit register access Russell King
2015-11-03 14:51     ` Russell King
2015-11-03 14:57     ` Timur Tabi
2015-11-03 14:57       ` Timur Tabi
2015-11-03 16:19       ` Russell King - ARM Linux
2015-11-03 16:19         ` Russell King - ARM Linux
2015-11-05  4:46         ` Peter Hurley
2015-11-05  4:46           ` Peter Hurley
2015-11-03 14:51   ` [PATCH 11/11] tty: amba-pl011: add support for ZTE UART (EXPERIMENTAL) Russell King
2015-11-03 14:51     ` Russell King
2015-11-05  8:28     ` Linus Walleij
2015-11-05  8:28       ` Linus Walleij
2015-11-05  9:27       ` Russell King - ARM Linux [this message]
2015-11-05  9:27         ` Russell King - ARM Linux
2015-11-05  9:54         ` Linus Walleij
2015-11-05  9:54           ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151105092703.GN8644@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=Andrew.Jackson@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=jun.nie@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.