* [PATCH] drivers: staging: fbtft: Removed the whitespace
@ 2015-11-09 9:18 Anjali Menon
2015-11-09 9:30 ` kbuild test robot
2015-11-09 9:45 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Anjali Menon @ 2015-11-09 9:18 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Anjali Menon
Remove the whitespace before declaration detected by
checkpatch.pl
ERROR: space prohibited before that close parenthesis
Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
---
drivers/staging/fbtft/fbtft-bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 52af9cb..6e18f58 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -70,9 +70,9 @@ void func(struct fbtft_par *par, int len, ...) \
} \
EXPORT_SYMBOL(func);
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)
void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
{
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: staging: fbtft: Removed the whitespace
2015-11-09 9:18 [PATCH] drivers: staging: fbtft: Removed the whitespace Anjali Menon
@ 2015-11-09 9:30 ` kbuild test robot
2015-11-09 9:45 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2015-11-09 9:30 UTC (permalink / raw)
To: Anjali Menon; +Cc: kbuild-all, gregkh, devel, linux-kernel, Anjali Menon
[-- Attachment #1: Type: text/plain, Size: 6171 bytes --]
Hi Anjali,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.3 next-20151109]
url: https://github.com/0day-ci/linux/commits/Anjali-Menon/drivers-staging-fbtft-Removed-the-whitespace/20151109-172010
config: x86_64-randconfig-x015-201545 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
>> drivers/staging/fbtft/fbtft-bus.c:71:49: error: macro "define_fbtft_write_reg" requires 3 arguments, but only 2 given
define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
^
>> drivers/staging/fbtft/fbtft-bus.c:14:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
void func(struct fbtft_par *par, int len, ...) \
^
>> drivers/staging/fbtft/fbtft-bus.c:72:1: note: in expansion of macro 'define_fbtft_write_reg'
define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
^
drivers/staging/fbtft/fbtft-bus.c:73:52: error: macro "define_fbtft_write_reg" requires 3 arguments, but only 2 given
define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)
^
drivers/staging/fbtft/fbtft-bus.c:75:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
^
vim +/define_fbtft_write_reg +71 drivers/staging/fbtft/fbtft-bus.c
8 *
9 * void (*write_reg)(struct fbtft_par *par, int len, ...);
10 *
11 *****************************************************************************/
12
13 #define define_fbtft_write_reg(func, type, modifier) \
> 14 void func(struct fbtft_par *par, int len, ...) \
15 { \
16 va_list args; \
17 int i, ret; \
18 int offset = 0; \
19 type *buf = (type *)par->buf; \
20 \
21 if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) { \
22 va_start(args, len); \
23 for (i = 0; i < len; i++) { \
24 buf[i] = (type)va_arg(args, unsigned int); \
25 } \
26 va_end(args); \
27 fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device, type, buf, len, "%s: ", __func__); \
28 } \
29 \
30 va_start(args, len); \
31 \
32 if (par->startbyte) { \
33 *(u8 *)par->buf = par->startbyte; \
34 buf = (type *)(par->buf + 1); \
35 offset = 1; \
36 } \
37 \
38 *buf = modifier((type)va_arg(args, unsigned int)); \
39 if (par->gpio.dc != -1) \
40 gpio_set_value(par->gpio.dc, 0); \
41 ret = par->fbtftops.write(par, par->buf, sizeof(type) + offset); \
42 if (ret < 0) { \
43 va_end(args); \
44 dev_err(par->info->device, "%s: write() failed and returned %d\n", __func__, ret); \
45 return; \
46 } \
47 len--; \
48 \
49 if (par->startbyte) \
50 *(u8 *)par->buf = par->startbyte | 0x2; \
51 \
52 if (len) { \
53 i = len; \
54 while (i--) { \
55 *buf++ = modifier((type)va_arg(args, unsigned int)); \
56 } \
57 if (par->gpio.dc != -1) \
58 gpio_set_value(par->gpio.dc, 1); \
59 ret = par->fbtftops.write(par, par->buf, \
60 len * (sizeof(type) + offset)); \
61 if (ret < 0) { \
62 va_end(args); \
63 dev_err(par->info->device, "%s: write() failed and returned %d\n", __func__, ret); \
64 return; \
65 } \
66 } \
67 va_end(args); \
68 } \
69 EXPORT_SYMBOL(func);
70
> 71 define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
> 72 define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
73 define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)
74
75 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 22422 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: staging: fbtft: Removed the whitespace
2015-11-09 9:18 [PATCH] drivers: staging: fbtft: Removed the whitespace Anjali Menon
2015-11-09 9:30 ` kbuild test robot
@ 2015-11-09 9:45 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-11-09 9:45 UTC (permalink / raw)
To: Anjali Menon; +Cc: gregkh, devel, linux-kernel
Did you try to compile this?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-09 9:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-09 9:18 [PATCH] drivers: staging: fbtft: Removed the whitespace Anjali Menon
2015-11-09 9:30 ` kbuild test robot
2015-11-09 9:45 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.