From: Borislav Petkov <bp@alien8.de> To: "Kirill A. Shutemov" <kirill@shutemov.name> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, jgross@suse.com, konrad.wilk@oracle.com, elliott@hpe.com, boris.ostrovsky@oracle.com, Toshi Kani <toshi.kani@hpe.com> Subject: Re: [PATCH] x86/mm: fix regression with huge pages on PAE Date: Tue, 10 Nov 2015 15:46:48 +0100 [thread overview] Message-ID: <20151110144648.GG19187@pd.tnic> (raw) In-Reply-To: <20151110135303.GA11246@node.shutemov.name> On Tue, Nov 10, 2015 at 03:53:03PM +0200, Kirill A. Shutemov wrote: > Oh.. pmdval_t/pudval_t is 'unsinged long' on 64 bit. But realmode code > uses -m16 which makes 'unsigned long' 32-bit therefore truncation warning. > > These helpers not really used in realmode code. Hrrm, yeah, that's just the nasty include hell causing it. The diff below fixes it with my config but it'll probably need a more careful analysis and reshuffling of includes/defines. Certainly better to do that than accomodating realmode to not throw warnings with ifdeffery... --- diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h index 0033e96c3f09..9011a88353de 100644 --- a/arch/x86/boot/boot.h +++ b/arch/x86/boot/boot.h @@ -23,7 +23,6 @@ #include <stdarg.h> #include <linux/types.h> #include <linux/edd.h> -#include <asm/boot.h> #include <asm/setup.h> #include "bitops.h" #include "ctype.h" diff --git a/arch/x86/boot/video-mode.c b/arch/x86/boot/video-mode.c index aa8a96b052e3..896077ed3381 100644 --- a/arch/x86/boot/video-mode.c +++ b/arch/x86/boot/video-mode.c @@ -19,6 +19,9 @@ #include "video.h" #include "vesa.h" +#define NORMAL_VGA 0xffff /* 80x25 mode */ +#define EXTENDED_VGA 0xfffe /* 80x50 mode */ + /* * Common variables */ diff --git a/arch/x86/boot/video.c b/arch/x86/boot/video.c index 05111bb8d018..a839448038b6 100644 --- a/arch/x86/boot/video.c +++ b/arch/x86/boot/video.c @@ -17,6 +17,8 @@ #include "video.h" #include "vesa.h" +#define ASK_VGA 0xfffd /* ask for it at bootup */ + static u16 video_segment; static void store_cursor_position(void) diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h index 48d34d28f5a6..cd0fc0cc78bc 100644 --- a/arch/x86/include/asm/x86_init.h +++ b/arch/x86/include/asm/x86_init.h @@ -1,7 +1,6 @@ #ifndef _ASM_X86_PLATFORM_H #define _ASM_X86_PLATFORM_H -#include <asm/pgtable_types.h> #include <asm/bootparam.h> struct mpc_bus; -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de> To: "Kirill A. Shutemov" <kirill@shutemov.name> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, jgross@suse.com, konrad.wilk@oracle.com, elliott@hpe.com, boris.ostrovsky@oracle.com, Toshi Kani <toshi.kani@hpe.com> Subject: Re: [PATCH] x86/mm: fix regression with huge pages on PAE Date: Tue, 10 Nov 2015 15:46:48 +0100 [thread overview] Message-ID: <20151110144648.GG19187@pd.tnic> (raw) In-Reply-To: <20151110135303.GA11246@node.shutemov.name> On Tue, Nov 10, 2015 at 03:53:03PM +0200, Kirill A. Shutemov wrote: > Oh.. pmdval_t/pudval_t is 'unsinged long' on 64 bit. But realmode code > uses -m16 which makes 'unsigned long' 32-bit therefore truncation warning. > > These helpers not really used in realmode code. Hrrm, yeah, that's just the nasty include hell causing it. The diff below fixes it with my config but it'll probably need a more careful analysis and reshuffling of includes/defines. Certainly better to do that than accomodating realmode to not throw warnings with ifdeffery... --- diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h index 0033e96c3f09..9011a88353de 100644 --- a/arch/x86/boot/boot.h +++ b/arch/x86/boot/boot.h @@ -23,7 +23,6 @@ #include <stdarg.h> #include <linux/types.h> #include <linux/edd.h> -#include <asm/boot.h> #include <asm/setup.h> #include "bitops.h" #include "ctype.h" diff --git a/arch/x86/boot/video-mode.c b/arch/x86/boot/video-mode.c index aa8a96b052e3..896077ed3381 100644 --- a/arch/x86/boot/video-mode.c +++ b/arch/x86/boot/video-mode.c @@ -19,6 +19,9 @@ #include "video.h" #include "vesa.h" +#define NORMAL_VGA 0xffff /* 80x25 mode */ +#define EXTENDED_VGA 0xfffe /* 80x50 mode */ + /* * Common variables */ diff --git a/arch/x86/boot/video.c b/arch/x86/boot/video.c index 05111bb8d018..a839448038b6 100644 --- a/arch/x86/boot/video.c +++ b/arch/x86/boot/video.c @@ -17,6 +17,8 @@ #include "video.h" #include "vesa.h" +#define ASK_VGA 0xfffd /* ask for it at bootup */ + static u16 video_segment; static void store_cursor_position(void) diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h index 48d34d28f5a6..cd0fc0cc78bc 100644 --- a/arch/x86/include/asm/x86_init.h +++ b/arch/x86/include/asm/x86_init.h @@ -1,7 +1,6 @@ #ifndef _ASM_X86_PLATFORM_H #define _ASM_X86_PLATFORM_H -#include <asm/pgtable_types.h> #include <asm/bootparam.h> struct mpc_bus; -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-10 14:47 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-09 23:18 [PATCH] x86/mm: fix regression with huge pages on PAE Kirill A. Shutemov 2015-11-09 23:18 ` Kirill A. Shutemov 2015-11-09 23:43 ` Toshi Kani 2015-11-09 23:43 ` Toshi Kani 2015-11-09 23:57 ` Kirill A. Shutemov 2015-11-09 23:57 ` Kirill A. Shutemov 2015-11-10 0:12 ` Toshi Kani 2015-11-10 0:12 ` Toshi Kani 2015-11-10 12:34 ` Borislav Petkov 2015-11-10 12:34 ` Borislav Petkov 2015-11-10 13:53 ` Kirill A. Shutemov 2015-11-10 13:53 ` Kirill A. Shutemov 2015-11-10 14:46 ` Borislav Petkov [this message] 2015-11-10 14:46 ` Borislav Petkov 2015-11-10 15:07 ` Kirill A. Shutemov 2015-11-10 15:07 ` Kirill A. Shutemov 2015-11-10 17:04 ` Borislav Petkov 2015-11-10 17:04 ` Borislav Petkov 2015-11-11 9:51 ` Borislav Petkov 2015-11-11 9:51 ` Borislav Petkov 2015-11-12 7:48 ` Ingo Molnar 2015-11-12 7:48 ` Ingo Molnar 2015-11-12 7:57 ` Kirill A. Shutemov 2015-11-12 7:57 ` Kirill A. Shutemov 2015-11-12 8:00 ` Ingo Molnar 2015-11-12 8:00 ` Ingo Molnar 2015-11-12 8:46 ` Kirill A. Shutemov 2015-11-12 8:46 ` Kirill A. Shutemov 2015-11-12 8:54 ` Ingo Molnar 2015-11-12 8:54 ` Ingo Molnar 2015-11-12 9:00 ` Kirill A. Shutemov 2015-11-12 9:00 ` Kirill A. Shutemov 2015-11-12 13:29 ` Ingo Molnar 2015-11-12 13:29 ` Ingo Molnar 2015-11-24 14:59 ` Boris Ostrovsky 2015-11-24 14:59 ` Boris Ostrovsky 2015-11-24 20:14 ` Kirill A. Shutemov 2015-11-24 20:14 ` Kirill A. Shutemov 2015-11-25 10:27 ` Borislav Petkov 2015-11-25 10:27 ` Borislav Petkov 2015-11-27 10:14 ` Ingo Molnar 2015-11-27 10:14 ` Ingo Molnar 2015-11-12 8:55 ` Ingo Molnar 2015-11-12 8:55 ` Ingo Molnar 2015-11-12 19:29 ` Linus Torvalds 2015-11-12 19:29 ` Linus Torvalds 2015-11-13 9:01 ` Dan Williams 2015-11-13 9:01 ` Dan Williams 2015-11-30 10:10 [PATCH] tip-queue 2015-11-30 Borislav Petkov 2015-11-30 10:10 ` [PATCH] x86/mm: Fix regression with huge pages on PAE Borislav Petkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20151110144648.GG19187@pd.tnic \ --to=bp@alien8.de \ --cc=akpm@linux-foundation.org \ --cc=boris.ostrovsky@oracle.com \ --cc=elliott@hpe.com \ --cc=hpa@zytor.com \ --cc=jgross@suse.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=kirill@shutemov.name \ --cc=konrad.wilk@oracle.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mingo@redhat.com \ --cc=tglx@linutronix.de \ --cc=toshi.kani@hpe.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.