All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Sebastian Andrzej Siewior
	<sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>
Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 1/2] ARM: Availability of psci_smp_available depends on CONFIG_SMP
Date: Thu, 12 Nov 2015 09:49:20 +0000	[thread overview]
Message-ID: <20151112094920.GB20270@arm.com> (raw)
In-Reply-To: <20151112094332.GA4645-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>

On Thu, Nov 12, 2015 at 10:43:33AM +0100, Sebastian Andrzej Siewior wrote:
> On 2015-10-06 16:18:58 [+0100], Will Deacon wrote:
> > On Tue, Oct 06, 2015 at 10:11:24AM +0200, Thierry Reding wrote:
> > > On Wed, Sep 23, 2015 at 08:39:43AM +0200, Jan Kiszka wrote:
> > > > Ensure that we can use psci_smp_available without checking for
> > > > CONFIG_SMP first.
> > > > 
> > > > Signed-off-by: Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
> > > > ---
> > > >  arch/arm/include/asm/psci.h | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/arch/arm/include/asm/psci.h b/arch/arm/include/asm/psci.h
> > > > index 68ee3ce..ff956f4 100644
> > > > --- a/arch/arm/include/asm/psci.h
> > > > +++ b/arch/arm/include/asm/psci.h
> > > > @@ -16,7 +16,7 @@
> > > >  
> > > >  extern struct smp_operations psci_smp_ops;
> > > >  
> > > > -#ifdef CONFIG_ARM_PSCI
> > > > +#if defined(CONFIG_ARM_PSCI) && defined(CONFIG_SMP)
> > > >  bool psci_smp_available(void);
> > > >  #else
> > > >  static inline bool psci_smp_available(void) { return false; }
> > 
> > Sure, I'm fine with this patch in isolation, I just didn't (don't) fully
> > grok what the series is trying to achieve.
> 
> Will, do you want this patch re-sent or do you just need some time to pick
> it up?

I wasn't planning to pick this one up as I assumed you'd be taking it
via arm-soc along with the second patch that depends on it. I just
stopped moaning about not understanding it :)

Will

WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: Availability of psci_smp_available depends on CONFIG_SMP
Date: Thu, 12 Nov 2015 09:49:20 +0000	[thread overview]
Message-ID: <20151112094920.GB20270@arm.com> (raw)
In-Reply-To: <20151112094332.GA4645@breakpoint.cc>

On Thu, Nov 12, 2015 at 10:43:33AM +0100, Sebastian Andrzej Siewior wrote:
> On 2015-10-06 16:18:58 [+0100], Will Deacon wrote:
> > On Tue, Oct 06, 2015 at 10:11:24AM +0200, Thierry Reding wrote:
> > > On Wed, Sep 23, 2015 at 08:39:43AM +0200, Jan Kiszka wrote:
> > > > Ensure that we can use psci_smp_available without checking for
> > > > CONFIG_SMP first.
> > > > 
> > > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > > > ---
> > > >  arch/arm/include/asm/psci.h | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/arch/arm/include/asm/psci.h b/arch/arm/include/asm/psci.h
> > > > index 68ee3ce..ff956f4 100644
> > > > --- a/arch/arm/include/asm/psci.h
> > > > +++ b/arch/arm/include/asm/psci.h
> > > > @@ -16,7 +16,7 @@
> > > >  
> > > >  extern struct smp_operations psci_smp_ops;
> > > >  
> > > > -#ifdef CONFIG_ARM_PSCI
> > > > +#if defined(CONFIG_ARM_PSCI) && defined(CONFIG_SMP)
> > > >  bool psci_smp_available(void);
> > > >  #else
> > > >  static inline bool psci_smp_available(void) { return false; }
> > 
> > Sure, I'm fine with this patch in isolation, I just didn't (don't) fully
> > grok what the series is trying to achieve.
> 
> Will, do you want this patch re-sent or do you just need some time to pick
> it up?

I wasn't planning to pick this one up as I assumed you'd be taking it
via arm-soc along with the second patch that depends on it. I just
stopped moaning about not understanding it :)

Will

  parent reply	other threads:[~2015-11-12  9:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-23  6:39 [PATCH v2 0/2] Make Tegra cpuidle driver PSCI compatible Jan Kiszka
2015-09-23  6:39 ` Jan Kiszka
     [not found] ` <cover.1442990383.git.jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2015-09-23  6:39   ` [PATCH v2 1/2] ARM: Availability of psci_smp_available depends on CONFIG_SMP Jan Kiszka
2015-09-23  6:39     ` Jan Kiszka
     [not found]     ` <8b94f7869972d64f442f97208707a5856cbc8b14.1442990383.git.jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2015-10-06  8:11       ` Thierry Reding
2015-10-06  8:11         ` Thierry Reding
     [not found]         ` <20151006081122.GA21527-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2015-10-06 15:18           ` Will Deacon
2015-10-06 15:18             ` Will Deacon
     [not found]             ` <20151006151857.GA2416-5wv7dgnIgG8@public.gmane.org>
2015-10-08 16:04               ` Thierry Reding
2015-10-08 16:04                 ` Thierry Reding
2015-11-12  9:43               ` Sebastian Andrzej Siewior
2015-11-12  9:43                 ` Sebastian Andrzej Siewior
     [not found]                 ` <20151112094332.GA4645-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>
2015-11-12  9:49                   ` Will Deacon [this message]
2015-11-12  9:49                     ` Will Deacon
     [not found]                     ` <20151112094920.GB20270-5wv7dgnIgG8@public.gmane.org>
2015-11-12 10:07                       ` Sebastian Andrzej Siewior
2015-11-12 10:07                         ` Sebastian Andrzej Siewior
2015-09-23  6:39 ` [PATCH v2 2/2] ARM: tegra: Disable cpuidle driver if PSCI is present Jan Kiszka
2015-09-23  6:39   ` Jan Kiszka
     [not found]   ` <5151ffebe8611545c55f8cc499cf2368b1b789c4.1442990383.git.jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2015-10-06  8:21     ` Thierry Reding
2015-10-06  8:21       ` Thierry Reding
     [not found]       ` <20151006082106.GB21527-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2015-10-06  8:36         ` Jan Kiszka
2015-10-06  8:36           ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151112094920.GB20270@arm.com \
    --to=will.deacon-5wv7dgnigg8@public.gmane.org \
    --cc=jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.