* [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference @ 2015-11-12 7:46 LABBE Corentin 2015-11-12 8:03 ` Frans Klaver 2015-11-12 8:19 ` Uwe Kleine-König 0 siblings, 2 replies; 12+ messages in thread From: LABBE Corentin @ 2015-11-12 7:46 UTC (permalink / raw) To: baruch, clabbe.montjoie, computersforpeace, dwmw2, fransklaver, k.kozlowski.k, luis, s.hauer, u.kleine-koenig Cc: linux-kernel, linux-mtd of_match_device could return NULL, and so cause a NULL pointer dereference later. Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> --- drivers/mtd/nand/mxc_nand.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c index 136e73a..9e42431 100644 --- a/drivers/mtd/nand/mxc_nand.c +++ b/drivers/mtd/nand/mxc_nand.c @@ -1464,8 +1464,7 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host *host) { struct device_node *np = host->dev->of_node; struct mxc_nand_platform_data *pdata = &host->pdata; - const struct of_device_id *of_id = - of_match_device(mxcnd_dt_ids, host->dev); + const struct of_device_id *of_id; int buswidth; if (!np) @@ -1482,6 +1481,9 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host *host) pdata->width = buswidth / 8; + of_id = of_match_device(mxcnd_dt_ids, host->dev); + if (!of_id) + return -ENODEV; host->devtype_data = of_id->data; return 0; -- 2.4.10 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference 2015-11-12 7:46 [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference LABBE Corentin @ 2015-11-12 8:03 ` Frans Klaver 2015-11-12 8:26 ` Uwe Kleine-König 2015-11-12 8:19 ` Uwe Kleine-König 1 sibling, 1 reply; 12+ messages in thread From: Frans Klaver @ 2015-11-12 8:03 UTC (permalink / raw) To: LABBE Corentin Cc: baruch, Brian Norris, David Woodhouse, Krzysztof Kozłowski, Luis de Bethencourt, s.hauer, u.kleine-koenig, linux-kernel, linux-mtd Hi, On Thu, Nov 12, 2015 at 8:46 AM, LABBE Corentin <clabbe.montjoie@gmail.com> wrote: > of_match_device could return NULL, and so cause a NULL pointer > dereference later. Did you actually run into this? It seems to me that this driver is only probed if and only if we have a match and that therefore of_match_device will always return a valid pointer (it is using the same match table). Am I missing something? > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> > --- > drivers/mtd/nand/mxc_nand.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c > index 136e73a..9e42431 100644 > --- a/drivers/mtd/nand/mxc_nand.c > +++ b/drivers/mtd/nand/mxc_nand.c > @@ -1464,8 +1464,7 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host *host) > { > struct device_node *np = host->dev->of_node; > struct mxc_nand_platform_data *pdata = &host->pdata; > - const struct of_device_id *of_id = > - of_match_device(mxcnd_dt_ids, host->dev); > + const struct of_device_id *of_id; > int buswidth; > > if (!np) > @@ -1482,6 +1481,9 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host *host) > > pdata->width = buswidth / 8; > > + of_id = of_match_device(mxcnd_dt_ids, host->dev); > + if (!of_id) > + return -ENODEV; > host->devtype_data = of_id->data; > > return 0; > -- > 2.4.10 > Thanks, Frans ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference 2015-11-12 8:03 ` Frans Klaver @ 2015-11-12 8:26 ` Uwe Kleine-König 2015-11-12 8:36 ` Frans Klaver 0 siblings, 1 reply; 12+ messages in thread From: Uwe Kleine-König @ 2015-11-12 8:26 UTC (permalink / raw) To: Frans Klaver Cc: LABBE Corentin, baruch, Brian Norris, David Woodhouse, Krzysztof Kozłowski, Luis de Bethencourt, s.hauer, linux-kernel, linux-mtd On Thu, Nov 12, 2015 at 09:03:11AM +0100, Frans Klaver wrote: > Hi, > > On Thu, Nov 12, 2015 at 8:46 AM, LABBE Corentin > <clabbe.montjoie@gmail.com> wrote: > > of_match_device could return NULL, and so cause a NULL pointer > > dereference later. > > Did you actually run into this? It seems to me that this driver is > only probed if and only if we have a match and that therefore > of_match_device will always return a valid pointer (it is using the > same match table). Am I missing something? Yes, you're missing something. The driver would probe for a dt snippet like: mxc_nand { compatible = "foobar"; } In this case dev->of_node is non-NULL but of_match_device(mxcnd_dt_ids, dev) is. (I didn't actually test this, so there is a chance I'm wrong here. And if not I wonder if it is sensible at all to match the device name on driver name for of-created platform devices.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference 2015-11-12 8:26 ` Uwe Kleine-König @ 2015-11-12 8:36 ` Frans Klaver 2015-11-12 8:53 ` Uwe Kleine-König 0 siblings, 1 reply; 12+ messages in thread From: Frans Klaver @ 2015-11-12 8:36 UTC (permalink / raw) To: Uwe Kleine-König Cc: LABBE Corentin, baruch, Brian Norris, David Woodhouse, Krzysztof Kozłowski, Luis de Bethencourt, s.hauer, linux-kernel, linux-mtd On Thu, Nov 12, 2015 at 9:26 AM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > On Thu, Nov 12, 2015 at 09:03:11AM +0100, Frans Klaver wrote: >> Hi, >> >> On Thu, Nov 12, 2015 at 8:46 AM, LABBE Corentin >> <clabbe.montjoie@gmail.com> wrote: >> > of_match_device could return NULL, and so cause a NULL pointer >> > dereference later. >> >> Did you actually run into this? It seems to me that this driver is >> only probed if and only if we have a match and that therefore >> of_match_device will always return a valid pointer (it is using the >> same match table). Am I missing something? > > Yes, you're missing something. The driver would probe for a dt snippet > like: > > mxc_nand { > compatible = "foobar"; > } > > In this case dev->of_node is non-NULL but of_match_device(mxcnd_dt_ids, > dev) is. > > (I didn't actually test this, so there is a chance I'm wrong here. And > if not I wonder if it is sensible at all to match the device name on > driver name for of-created platform devices.) Yea, looks like you're right. platform devices check a number of things to determine a match, among which is driver name if all else fails (platform.c, platform_match()). Thanks, Frans ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference 2015-11-12 8:36 ` Frans Klaver @ 2015-11-12 8:53 ` Uwe Kleine-König 2015-11-12 8:57 ` Frans Klaver 0 siblings, 1 reply; 12+ messages in thread From: Uwe Kleine-König @ 2015-11-12 8:53 UTC (permalink / raw) To: Frans Klaver Cc: LABBE Corentin, baruch, Brian Norris, David Woodhouse, Krzysztof Kozłowski, Luis de Bethencourt, kernel, linux-kernel, Greg Kroah-Hartman CC += devicetree@vger.kernel.org, gregkh On Thu, Nov 12, 2015 at 09:36:55AM +0100, Frans Klaver wrote: > On Thu, Nov 12, 2015 at 9:26 AM, Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> wrote: > > On Thu, Nov 12, 2015 at 09:03:11AM +0100, Frans Klaver wrote: > >> Hi, > >> > >> On Thu, Nov 12, 2015 at 8:46 AM, LABBE Corentin > >> <clabbe.montjoie@gmail.com> wrote: > >> > of_match_device could return NULL, and so cause a NULL pointer > >> > dereference later. > >> > >> Did you actually run into this? It seems to me that this driver is > >> only probed if and only if we have a match and that therefore > >> of_match_device will always return a valid pointer (it is using the > >> same match table). Am I missing something? > > > > Yes, you're missing something. The driver would probe for a dt snippet > > like: > > > > mxc_nand { > > compatible = "foobar"; > > } > > > > In this case dev->of_node is non-NULL but of_match_device(mxcnd_dt_ids, > > dev) is. > > > > (I didn't actually test this, so there is a chance I'm wrong here. And > > if not I wonder if it is sensible at all to match the device name on > > driver name for of-created platform devices.) > > Yea, looks like you're right. platform devices check a number of > things to determine a match, among which is driver name if all else > fails (platform.c, platform_match()). Maybe something like this would help to reduce surprises: diff --git a/drivers/base/platform.c b/drivers/base/platform.c index f80aaaf9f610..a9fc22c86552 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -840,8 +840,8 @@ static int platform_match(struct device *dev, struct device_driver *drv) return !strcmp(pdev->driver_override, drv->name); /* Attempt an OF style match first */ - if (of_driver_match_device(dev, drv)) - return 1; + if (pdev->dev.of_node) + return of_driver_match_device(dev, drv); /* Then try ACPI style match */ if (acpi_driver_match_device(dev, drv)) Maybe something similar for acpi devices is desirable, too? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference 2015-11-12 8:53 ` Uwe Kleine-König @ 2015-11-12 8:57 ` Frans Klaver 2015-11-12 9:01 ` Uwe Kleine-König 0 siblings, 1 reply; 12+ messages in thread From: Frans Klaver @ 2015-11-12 8:57 UTC (permalink / raw) To: Uwe Kleine-König Cc: LABBE Corentin, baruch, Brian Norris, David Woodhouse, Krzysztof Kozłowski, Luis de Bethencourt, kernel, linux-kernel, Greg Kroah-Hartman On Thu, Nov 12, 2015 at 9:53 AM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > CC += devicetree@vger.kernel.org, gregkh You added linux@pengutronix instead of devicetree. > > On Thu, Nov 12, 2015 at 09:36:55AM +0100, Frans Klaver wrote: >> On Thu, Nov 12, 2015 at 9:26 AM, Uwe Kleine-König >> <u.kleine-koenig@pengutronix.de> wrote: >> > On Thu, Nov 12, 2015 at 09:03:11AM +0100, Frans Klaver wrote: >> >> Hi, >> >> >> >> On Thu, Nov 12, 2015 at 8:46 AM, LABBE Corentin >> >> <clabbe.montjoie@gmail.com> wrote: >> >> > of_match_device could return NULL, and so cause a NULL pointer >> >> > dereference later. >> >> >> >> Did you actually run into this? It seems to me that this driver is >> >> only probed if and only if we have a match and that therefore >> >> of_match_device will always return a valid pointer (it is using the >> >> same match table). Am I missing something? >> > >> > Yes, you're missing something. The driver would probe for a dt snippet >> > like: >> > >> > mxc_nand { >> > compatible = "foobar"; >> > } >> > >> > In this case dev->of_node is non-NULL but of_match_device(mxcnd_dt_ids, >> > dev) is. >> > >> > (I didn't actually test this, so there is a chance I'm wrong here. And >> > if not I wonder if it is sensible at all to match the device name on >> > driver name for of-created platform devices.) >> >> Yea, looks like you're right. platform devices check a number of >> things to determine a match, among which is driver name if all else >> fails (platform.c, platform_match()). > > Maybe something like this would help to reduce surprises: > > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > index f80aaaf9f610..a9fc22c86552 100644 > --- a/drivers/base/platform.c > +++ b/drivers/base/platform.c > @@ -840,8 +840,8 @@ static int platform_match(struct device *dev, struct device_driver *drv) > return !strcmp(pdev->driver_override, drv->name); > > /* Attempt an OF style match first */ > - if (of_driver_match_device(dev, drv)) > - return 1; > + if (pdev->dev.of_node) > + return of_driver_match_device(dev, drv); > > /* Then try ACPI style match */ > if (acpi_driver_match_device(dev, drv)) That looks sensible, yea. There is a chance that misbehaving DT nodes will fail after this change, of course. Thanks, Frans ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference 2015-11-12 8:57 ` Frans Klaver @ 2015-11-12 9:01 ` Uwe Kleine-König 0 siblings, 0 replies; 12+ messages in thread From: Uwe Kleine-König @ 2015-11-12 9:01 UTC (permalink / raw) To: Frans Klaver Cc: LABBE Corentin, baruch, Brian Norris, David Woodhouse, Krzysztof Kozłowski, Luis de Bethencourt, kernel, linux-kernel, Greg Kroah-Hartman, devicetree On Thu, Nov 12, 2015 at 09:57:07AM +0100, Frans Klaver wrote: > On Thu, Nov 12, 2015 at 9:53 AM, Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> wrote: > > CC += devicetree@vger.kernel.org, gregkh > > You added linux@pengutronix instead of devicetree. Well I substituted Sascha by kernel@pengutronix.de on purpose, but considered that too unimportant for the outer world :-) But I really forgot devicetree@vger.kernel.org. Added now. > > On Thu, Nov 12, 2015 at 09:36:55AM +0100, Frans Klaver wrote: > >> On Thu, Nov 12, 2015 at 9:26 AM, Uwe Kleine-König > >> <u.kleine-koenig@pengutronix.de> wrote: > >> > On Thu, Nov 12, 2015 at 09:03:11AM +0100, Frans Klaver wrote: > >> >> Hi, > >> >> > >> >> On Thu, Nov 12, 2015 at 8:46 AM, LABBE Corentin > >> >> <clabbe.montjoie@gmail.com> wrote: > >> >> > of_match_device could return NULL, and so cause a NULL pointer > >> >> > dereference later. > >> >> > >> >> Did you actually run into this? It seems to me that this driver is > >> >> only probed if and only if we have a match and that therefore > >> >> of_match_device will always return a valid pointer (it is using the > >> >> same match table). Am I missing something? > >> > > >> > Yes, you're missing something. The driver would probe for a dt snippet > >> > like: > >> > > >> > mxc_nand { > >> > compatible = "foobar"; > >> > } > >> > > >> > In this case dev->of_node is non-NULL but of_match_device(mxcnd_dt_ids, > >> > dev) is. > >> > > >> > (I didn't actually test this, so there is a chance I'm wrong here. And > >> > if not I wonder if it is sensible at all to match the device name on > >> > driver name for of-created platform devices.) > >> > >> Yea, looks like you're right. platform devices check a number of > >> things to determine a match, among which is driver name if all else > >> fails (platform.c, platform_match()). > > > > Maybe something like this would help to reduce surprises: > > > > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > > index f80aaaf9f610..a9fc22c86552 100644 > > --- a/drivers/base/platform.c > > +++ b/drivers/base/platform.c > > @@ -840,8 +840,8 @@ static int platform_match(struct device *dev, struct device_driver *drv) > > return !strcmp(pdev->driver_override, drv->name); > > > > /* Attempt an OF style match first */ > > - if (of_driver_match_device(dev, drv)) > > - return 1; > > + if (pdev->dev.of_node) > > + return of_driver_match_device(dev, drv); > > > > /* Then try ACPI style match */ > > if (acpi_driver_match_device(dev, drv)) > > That looks sensible, yea. There is a chance that misbehaving DT nodes > will fail after this change, of course. Which is ok if this behaviour is considered a misbehave :-) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference 2015-11-12 7:46 [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference LABBE Corentin 2015-11-12 8:03 ` Frans Klaver @ 2015-11-12 8:19 ` Uwe Kleine-König 2015-11-12 10:03 ` LABBE Corentin 2015-11-16 18:33 ` Brian Norris 1 sibling, 2 replies; 12+ messages in thread From: Uwe Kleine-König @ 2015-11-12 8:19 UTC (permalink / raw) To: LABBE Corentin Cc: baruch, computersforpeace, dwmw2, fransklaver, k.kozlowski.k, luis, s.hauer, linux-kernel, linux-mtd Hello Corentin, On Thu, Nov 12, 2015 at 08:46:55AM +0100, LABBE Corentin wrote: > of_match_device could return NULL, and so cause a NULL pointer > dereference later. > > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> > --- > drivers/mtd/nand/mxc_nand.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c > index 136e73a..9e42431 100644 > --- a/drivers/mtd/nand/mxc_nand.c > +++ b/drivers/mtd/nand/mxc_nand.c > @@ -1464,8 +1464,7 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host *host) > { > struct device_node *np = host->dev->of_node; > struct mxc_nand_platform_data *pdata = &host->pdata; > - const struct of_device_id *of_id = > - of_match_device(mxcnd_dt_ids, host->dev); > + const struct of_device_id *of_id; > int buswidth; > > if (!np) > @@ -1482,6 +1481,9 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host *host) > > pdata->width = buswidth / 8; > > + of_id = of_match_device(mxcnd_dt_ids, host->dev); > + if (!of_id) > + return -ENODEV; You should return 1 here instead of -ENODEV. Also this check should better be done instead of if (!np) return 1; at the start of the function. I really wonder there is no helper function like: #define of_sensible_name(dev) of_match_device(dev->driver->of_match_table, dev) Best regards Uwe > host->devtype_data = of_id->data; > > return 0; > -- > 2.4.10 > > -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference 2015-11-12 8:19 ` Uwe Kleine-König @ 2015-11-12 10:03 ` LABBE Corentin 2015-11-12 10:14 ` Uwe Kleine-König 2015-11-16 18:33 ` Brian Norris 1 sibling, 1 reply; 12+ messages in thread From: LABBE Corentin @ 2015-11-12 10:03 UTC (permalink / raw) To: Uwe Kleine-König Cc: LABBE Corentin, baruch, computersforpeace, dwmw2, fransklaver, k.kozlowski.k, luis, s.hauer, linux-kernel, linux-mtd On Thu, Nov 12, 2015 at 09:19:09AM +0100, Uwe Kleine-König wrote: > Hello Corentin, > > On Thu, Nov 12, 2015 at 08:46:55AM +0100, LABBE Corentin wrote: > > of_match_device could return NULL, and so cause a NULL pointer > > dereference later. > > > > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> > > --- > > drivers/mtd/nand/mxc_nand.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c > > index 136e73a..9e42431 100644 > > --- a/drivers/mtd/nand/mxc_nand.c > > +++ b/drivers/mtd/nand/mxc_nand.c > > @@ -1464,8 +1464,7 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host *host) > > { > > struct device_node *np = host->dev->of_node; > > struct mxc_nand_platform_data *pdata = &host->pdata; > > - const struct of_device_id *of_id = > > - of_match_device(mxcnd_dt_ids, host->dev); > > + const struct of_device_id *of_id; > > int buswidth; > > > > if (!np) > > @@ -1482,6 +1481,9 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host *host) > > > > pdata->width = buswidth / 8; > > > > + of_id = of_match_device(mxcnd_dt_ids, host->dev); > > + if (!of_id) > > + return -ENODEV; > > You should return 1 here instead of -ENODEV. Also this check should > better be done instead of > > if (!np) > return 1; > > at the start of the function. Are you sure for the "1" value ? It seems a very bad error value. And I found plenty of case where if (!np) return -Esomething and no example of return 1 Regards ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference 2015-11-12 10:03 ` LABBE Corentin @ 2015-11-12 10:14 ` Uwe Kleine-König 0 siblings, 0 replies; 12+ messages in thread From: Uwe Kleine-König @ 2015-11-12 10:14 UTC (permalink / raw) To: LABBE Corentin Cc: LABBE Corentin, baruch, computersforpeace, dwmw2, fransklaver, k.kozlowski.k, luis, s.hauer, linux-kernel, linux-mtd Hello, On Thu, Nov 12, 2015 at 11:03:28AM +0100, LABBE Corentin wrote: > On Thu, Nov 12, 2015 at 09:19:09AM +0100, Uwe Kleine-König wrote: > > Hello Corentin, > > > > On Thu, Nov 12, 2015 at 08:46:55AM +0100, LABBE Corentin wrote: > > > of_match_device could return NULL, and so cause a NULL pointer > > > dereference later. > > > > > > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> > > > --- > > > drivers/mtd/nand/mxc_nand.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c > > > index 136e73a..9e42431 100644 > > > --- a/drivers/mtd/nand/mxc_nand.c > > > +++ b/drivers/mtd/nand/mxc_nand.c > > > @@ -1464,8 +1464,7 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host *host) > > > { > > > struct device_node *np = host->dev->of_node; > > > struct mxc_nand_platform_data *pdata = &host->pdata; > > > - const struct of_device_id *of_id = > > > - of_match_device(mxcnd_dt_ids, host->dev); > > > + const struct of_device_id *of_id; > > > int buswidth; > > > > > > if (!np) > > > @@ -1482,6 +1481,9 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host *host) > > > > > > pdata->width = buswidth / 8; > > > > > > + of_id = of_match_device(mxcnd_dt_ids, host->dev); > > > + if (!of_id) > > > + return -ENODEV; > > > > You should return 1 here instead of -ENODEV. Also this check should > > better be done instead of > > > > if (!np) > > return 1; > > > > at the start of the function. > > Are you sure for the "1" value ? It seems a very bad error value. > And I found plenty of case where if (!np) return -Esomething and no example of return 1 This is not an error value. The semantic is: 0 everything ok, initialized from dt 1 device was not probed by dt -> fall back to board-file stuff <0 error that should abort probing Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference 2015-11-12 8:19 ` Uwe Kleine-König 2015-11-12 10:03 ` LABBE Corentin @ 2015-11-16 18:33 ` Brian Norris 2015-11-16 19:12 ` Corentin LABBE 1 sibling, 1 reply; 12+ messages in thread From: Brian Norris @ 2015-11-16 18:33 UTC (permalink / raw) To: Uwe Kleine-König Cc: LABBE Corentin, baruch, dwmw2, fransklaver, k.kozlowski.k, luis, s.hauer, linux-kernel, linux-mtd On Thu, Nov 12, 2015 at 09:19:09AM +0100, Uwe Kleine-König wrote: > I really wonder there is no helper > function like: > > #define of_sensible_name(dev) of_match_device(dev->driver->of_match_table, dev) How about of_device_get_match_data()? It's not exactly what you asked for, but it gets what you need here. Brian ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference 2015-11-16 18:33 ` Brian Norris @ 2015-11-16 19:12 ` Corentin LABBE 0 siblings, 0 replies; 12+ messages in thread From: Corentin LABBE @ 2015-11-16 19:12 UTC (permalink / raw) To: Brian Norris, Uwe Kleine-König Cc: baruch, dwmw2, fransklaver, k.kozlowski.k, luis, s.hauer, linux-kernel, linux-mtd Le 16/11/2015 19:33, Brian Norris a écrit : > On Thu, Nov 12, 2015 at 09:19:09AM +0100, Uwe Kleine-König wrote: >> I really wonder there is no helper >> function like: >> >> #define of_sensible_name(dev) of_match_device(dev->driver->of_match_table, dev) > > How about of_device_get_match_data()? > > It's not exactly what you asked for, but it gets what you need here. > > Brian > I have got the same comment from another thread. I will use it. Thanks Regards ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2015-11-16 19:12 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-11-12 7:46 [PATCH] mtd: nand: mxc_nand: fix a possible NULL dereference LABBE Corentin 2015-11-12 8:03 ` Frans Klaver 2015-11-12 8:26 ` Uwe Kleine-König 2015-11-12 8:36 ` Frans Klaver 2015-11-12 8:53 ` Uwe Kleine-König 2015-11-12 8:57 ` Frans Klaver 2015-11-12 9:01 ` Uwe Kleine-König 2015-11-12 8:19 ` Uwe Kleine-König 2015-11-12 10:03 ` LABBE Corentin 2015-11-12 10:14 ` Uwe Kleine-König 2015-11-16 18:33 ` Brian Norris 2015-11-16 19:12 ` Corentin LABBE
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.