All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] btrfs-progs: allow device deletion using 'missing' keyword again
@ 2015-11-07  0:26 Alexander Fougner
  2015-11-13 15:13 ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Fougner @ 2015-11-07  0:26 UTC (permalink / raw)
  To: dsterba; +Cc: linux-btrfs, Alexander Fougner

Device deletion procedures ensures the device is a block device.
This patch introduces 'missing' as keyword again, correctly
passing it on to the kernel instead of complaining about
'missing' not being a block device.

Signed-off-by: Alexander Fougner <fougner89@gmail.com>
---
 cmds-device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmds-device.c b/cmds-device.c
index c2f3a40..dca30d7 100644
--- a/cmds-device.c
+++ b/cmds-device.c
@@ -161,7 +161,7 @@ static int _cmd_device_remove(int argc, char **argv,
 		struct	btrfs_ioctl_vol_args arg;
 		int	res;
 
-		if (is_block_device(argv[i]) != 1) {
+		if (is_block_device(argv[i]) != 1 && strcmp(argv[i], "missing")) {
 			fprintf(stderr,
 				"ERROR: %s is not a block device\n", argv[i]);
 			ret++;
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] btrfs-progs: allow device deletion using 'missing' keyword again
  2015-11-07  0:26 [PATCH] btrfs-progs: allow device deletion using 'missing' keyword again Alexander Fougner
@ 2015-11-13 15:13 ` David Sterba
  0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2015-11-13 15:13 UTC (permalink / raw)
  To: Alexander Fougner; +Cc: dsterba, linux-btrfs

On Sat, Nov 07, 2015 at 01:26:24AM +0100, Alexander Fougner wrote:
> Device deletion procedures ensures the device is a block device.
> This patch introduces 'missing' as keyword again, correctly
> passing it on to the kernel instead of complaining about
> 'missing' not being a block device.
> 
> Signed-off-by: Alexander Fougner <fougner89@gmail.com>

Applied, thanks. Scheduled for 4.3.1.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-13 15:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-07  0:26 [PATCH] btrfs-progs: allow device deletion using 'missing' keyword again Alexander Fougner
2015-11-13 15:13 ` David Sterba

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.