Re: [PATCH] bonding: Offloading bonds to hardware

[Jiri Pirko <jiri@resnulli.us>]

Mon, Nov 16, 2015 at 07:48:34AM CET, pjonnala@broadcom.com wrote:
>> 
>> Thu, Nov 12, 2015 at 05:02:18PM CET, pjonnala@broadcom.com wrote:
>> >Packet forwarding to/from bond interfaces is done in software.
>> >
>> >This patch enables certain platforms to bridge traffic to/from
>> >bond interfaces in hardware.  Notifications are sent out when
>> >the "active" slave set for a bond interface is updated in
>> >software.  Platforms use the notifications to program the
>> >hardware accordingly.  The changes have been verified to work
>> >with configured and 802.3ad bond interfaces.
>> >
>> >Signed-off-by: Premkumar Jonnala <pjonnala@broadcom.com>
>
>Thank you for the comments Jiri.
>
>> This patch is wrong, in many different acpects. Leaving the submission
>> style, and no in-tree consumer aside, adding ndos for this thing is
>> unacceptable. It should be handled as a part of switchdev attrs.
>> Also, the solution should not be bonding-centric.
>
>Can you elaborate on how you envision the solution to be, when you say 
>the solution should not be "bonding centric"?

You should be able to offload team as well, using the same api.

>
>Thanks
>Prem
>
>> 
>> I have a patchset in my queue which does this correctly, for bond and team
>> using switchdev attr and with actual in-tree consumer, mlxsw driver.
>> I plan to send that soon after net-next opens.
>> 
>> Jiri