From: Premkumar Jonnala <pjonnala@broadcom.com>
To: David Miller <davem@davemloft.net>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"sfeldma@gmail.com" <sfeldma@gmail.com>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"nikolay@cumulusnetworks.com" <nikolay@cumulusnetworks.com>,
"idosch@mellanox.com" <idosch@mellanox.com>,
"gospo@cumulusnetworks.com" <gospo@cumulusnetworks.com>
Subject: RE: [PATCH] bonding: Offloading bonds to hardware
Date: Mon, 16 Nov 2015 06:12:24 +0000 [thread overview]
Message-ID: <77EF4405DD4BB54AACCE7DB593DF6A9AA08010@SJEXCHMB14.corp.ad.broadcom.com> (raw)
In-Reply-To: <20151113.141006.1048458234203733687.davem@davemloft.net>
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Saturday, November 14, 2015 12:40 AM
> To: f.fainelli@gmail.com
> Cc: Premkumar Jonnala; netdev@vger.kernel.org; sfeldma@gmail.com;
> jiri@resnulli.us; nikolay@cumulusnetworks.com; idosch@mellanox.com;
> gospo@cumulusnetworks.com
> Subject: Re: [PATCH] bonding: Offloading bonds to hardware
>
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Fri, 13 Nov 2015 10:38:48 -0800
>
> > This is a good explanation of why you want the changes, and how this is
> > implemented in a system utilizing that, but this is not documenting why
> > you are making these changes to the bonding code, nor how they are
> > supposed to be used by an implementor driver, since there is no such
> > user posted (yet?).
>
> I am basically not even going to look at proposals for new device ops
> that don't also show an actual user of the new interfaces.
>
> That's not how we do development, and not providing a real example
> user of a new set of interfaces makes it impossible to properly review
> such changes.
Thank you for the feedback David. I am currently handling/implementing
these notifications in a custom (closed source) driver. I will update the diff
with an actual demo of the handler, and resend the diffs.
Thanks
Prem
next prev parent reply other threads:[~2015-11-16 6:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 16:02 [PATCH] bonding: Offloading bonds to hardware Premkumar Jonnala
2015-11-12 17:08 ` Andrew Lunn
2015-11-14 9:40 ` Jiri Pirko
2015-11-13 18:38 ` Florian Fainelli
2015-11-13 19:10 ` David Miller
2015-11-16 6:12 ` Premkumar Jonnala [this message]
2015-11-16 6:51 ` David Miller
2015-11-16 6:49 ` Premkumar Jonnala
2015-11-16 6:54 ` David Miller
2015-11-16 6:10 ` Premkumar Jonnala
2015-11-13 21:11 ` Andrew Lunn
2015-11-16 6:15 ` Premkumar Jonnala
2015-11-14 9:39 ` Jiri Pirko
2015-11-15 5:51 ` John Fastabend
2015-11-15 9:01 ` Jiri Pirko
2015-11-16 16:24 ` John Fastabend
2015-11-16 6:48 ` Premkumar Jonnala
2015-11-16 7:46 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77EF4405DD4BB54AACCE7DB593DF6A9AA08010@SJEXCHMB14.corp.ad.broadcom.com \
--to=pjonnala@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gospo@cumulusnetworks.com \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.