* [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
@ 2015-11-16 3:06 Masahiro Yamada
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
0 siblings, 1 reply; 26+ messages in thread
From: Masahiro Yamada @ 2015-11-16 3:06 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
arm-DgEjT+Ai2ygdnm+yROfE0A
Cc: Andrew Lunn, Krzysztof Kozlowski, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Liviu Dudau,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Masahiro Yamada,
Thierry Reding, Alexandre Belloni, Matthias Brugger, Jamie Iles,
Heiko Stuebner, Alexandre Courbot,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Florian Fainelli,
Russell King, Viresh Kumar, Stephen Warren, Magnus Damm,
Michal Simek, Wei Xu, Lorenzo Pieralisi, linux-roc
Many ARM sub-architectures use prompts followed by "if" conditional,
but it is wrong.
Please notice the difference between
config ARCH_FOO
bool "Foo SoCs" if ARCH_MULTI_V7
and
config ARCH_FOO
bool "Foo SoCs"
depends on ARCH_MULTI_V7
These two are *not* equivalent!
In the former statement, it is not ARCH_FOO, but its prompt that
depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
not unmet dependency, Kconfig never warns. This is probably not what
you want.
The former should be used only when you need to do so, and you really
understand what you are doing. (In most cases, it should be wrong!)
For enabling/disabling sub-architectures, the latter is always correct.
As a good side effect, this commit fixes some entries over 80 columns
(mach-imx, mach-integrator, mach-mbevu).
Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
---
I hope this patch is applied to ARM-SOC, but am CCing Kbuild ML
because the correct understanding of Kconfig is required for this patch.
arch/arm/Kconfig | 3 ++-
arch/arm/mach-alpine/Kconfig | 3 ++-
arch/arm/mach-at91/Kconfig | 15 ++++++++++-----
arch/arm/mach-axxia/Kconfig | 3 ++-
arch/arm/mach-bcm/Kconfig | 27 ++++++++++++++++++---------
arch/arm/mach-berlin/Kconfig | 3 ++-
arch/arm/mach-cns3xxx/Kconfig | 3 ++-
arch/arm/mach-exynos/Kconfig | 3 ++-
arch/arm/mach-highbank/Kconfig | 3 ++-
arch/arm/mach-hisi/Kconfig | 12 ++++++++----
arch/arm/mach-imx/Kconfig | 6 ++++--
arch/arm/mach-integrator/Kconfig | 3 ++-
arch/arm/mach-mediatek/Kconfig | 3 ++-
arch/arm/mach-meson/Kconfig | 3 ++-
arch/arm/mach-moxart/Kconfig | 3 ++-
arch/arm/mach-mvebu/Kconfig | 24 ++++++++++++++++--------
arch/arm/mach-picoxcell/Kconfig | 3 ++-
arch/arm/mach-prima2/Kconfig | 3 ++-
arch/arm/mach-qcom/Kconfig | 3 ++-
arch/arm/mach-rockchip/Kconfig | 3 ++-
arch/arm/mach-s5pv210/Kconfig | 3 ++-
arch/arm/mach-shmobile/Kconfig | 4 ++--
arch/arm/mach-socfpga/Kconfig | 3 ++-
arch/arm/mach-spear/Kconfig | 3 ++-
arch/arm/mach-sti/Kconfig | 3 ++-
arch/arm/mach-sunxi/Kconfig | 3 ++-
arch/arm/mach-tegra/Kconfig | 3 ++-
arch/arm/mach-u300/Kconfig | 4 ++--
arch/arm/mach-ux500/Kconfig | 4 ++--
arch/arm/mach-vexpress/Kconfig | 3 ++-
arch/arm/mach-zx/Kconfig | 3 ++-
arch/arm/mach-zynq/Kconfig | 3 ++-
32 files changed, 110 insertions(+), 58 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 0365cbb..54fda82 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -794,7 +794,8 @@ config ARCH_MULTI_CPU_AUTO
endmenu
config ARCH_VIRT
- bool "Dummy Virtual Machine" if ARCH_MULTI_V7
+ bool "Dummy Virtual Machine"
+ depends on ARCH_MULTI_V7
select ARM_AMBA
select ARM_GIC
select ARM_GIC_V3
diff --git a/arch/arm/mach-alpine/Kconfig b/arch/arm/mach-alpine/Kconfig
index 2c44b93..5c2d54f 100644
--- a/arch/arm/mach-alpine/Kconfig
+++ b/arch/arm/mach-alpine/Kconfig
@@ -1,5 +1,6 @@
config ARCH_ALPINE
- bool "Annapurna Labs Alpine platform" if ARCH_MULTI_V7
+ bool "Annapurna Labs Alpine platform"
+ depends on ARCH_MULTI_V7
select ARM_AMBA
select ARM_GIC
select GENERIC_IRQ_CHIP
diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index 9267300..8649f03 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -9,7 +9,8 @@ menuconfig ARCH_AT91
if ARCH_AT91
config SOC_SAMA5D2
- bool "SAMA5D2 family" if ARCH_MULTI_V7
+ bool "SAMA5D2 family"
+ depends on ARCH_MULTI_V7
select SOC_SAMA5
select CACHE_L2X0
select HAVE_FB_ATMEL
@@ -21,7 +22,8 @@ config SOC_SAMA5D2
Select this if ou are using one of Atmel's SAMA5D2 family SoC.
config SOC_SAMA5D3
- bool "SAMA5D3 family" if ARCH_MULTI_V7
+ bool "SAMA5D3 family"
+ depends on ARCH_MULTI_V7
select SOC_SAMA5
select HAVE_FB_ATMEL
select HAVE_AT91_UTMI
@@ -32,7 +34,8 @@ config SOC_SAMA5D3
This support covers SAMA5D31, SAMA5D33, SAMA5D34, SAMA5D35, SAMA5D36.
config SOC_SAMA5D4
- bool "SAMA5D4 family" if ARCH_MULTI_V7
+ bool "SAMA5D4 family"
+ depends on ARCH_MULTI_V7
select SOC_SAMA5
select CACHE_L2X0
select HAVE_FB_ATMEL
@@ -44,7 +47,8 @@ config SOC_SAMA5D4
Select this if you are using one of Atmel's SAMA5D4 family SoC.
config SOC_AT91RM9200
- bool "AT91RM9200" if ARCH_MULTI_V4T
+ bool "AT91RM9200"
+ depends on ARCH_MULTI_V4T
select ATMEL_AIC_IRQ
select ATMEL_ST
select CPU_ARM920T
@@ -56,7 +60,8 @@ config SOC_AT91RM9200
Select this if you are using Atmel's AT91RM9200 SoC.
config SOC_AT91SAM9
- bool "AT91SAM9" if ARCH_MULTI_V5
+ bool "AT91SAM9"
+ depends on ARCH_MULTI_V5
select ATMEL_AIC_IRQ
select ATMEL_SDRAMC
select CPU_ARM926T
diff --git a/arch/arm/mach-axxia/Kconfig b/arch/arm/mach-axxia/Kconfig
index 8be7e0a..6c6d5e7 100644
--- a/arch/arm/mach-axxia/Kconfig
+++ b/arch/arm/mach-axxia/Kconfig
@@ -1,5 +1,6 @@
config ARCH_AXXIA
- bool "LSI Axxia platforms" if (ARCH_MULTI_V7 && ARM_LPAE)
+ bool "LSI Axxia platforms"
+ depends on ARCH_MULTI_V7 && ARM_LPAE
select ARCH_DMA_ADDR_T_64BIT
select ARM_AMBA
select ARM_GIC
diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index 8c53c55..77116dc 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_BCM
- bool "Broadcom SoC Support" if ARCH_MULTI_V6_V7
+ bool "Broadcom SoC Support"
+ depends on ARCH_MULTI_V6_V7
help
This enables support for Broadcom ARM based SoC chips
@@ -27,7 +28,8 @@ config ARCH_BCM_IPROC
Currently supported SoCs are Cygnus.
config ARCH_BCM_CYGNUS
- bool "Broadcom Cygnus Support" if ARCH_MULTI_V7
+ bool "Broadcom Cygnus Support"
+ depends on ARCH_MULTI_V7
select ARCH_BCM_IPROC
help
Enable support for the Cygnus family,
@@ -36,7 +38,8 @@ config ARCH_BCM_CYGNUS
BCM58300, BCM58302, BCM58303, BCM58305.
config ARCH_BCM_NSP
- bool "Broadcom Northstar Plus SoC Support" if ARCH_MULTI_V7
+ bool "Broadcom Northstar Plus SoC Support"
+ depends on ARCH_MULTI_V7
select ARCH_BCM_IPROC
select ARM_ERRATA_754322
select ARM_ERRATA_775420
@@ -50,7 +53,8 @@ config ARCH_BCM_NSP
NAND flash, SATA and several other IO controllers.
config ARCH_BCM_5301X
- bool "Broadcom BCM470X / BCM5301X ARM SoC" if ARCH_MULTI_V7
+ bool "Broadcom BCM470X / BCM5301X ARM SoC"
+ depends on ARCH_MULTI_V7
select ARCH_BCM_IPROC
help
Support for Broadcom BCM470X and BCM5301X SoCs with ARM CPU cores.
@@ -82,7 +86,8 @@ config ARCH_BCM_MOBILE
This enables support for systems based on Broadcom mobile SoCs.
config ARCH_BCM_281XX
- bool "Broadcom BCM281XX SoC family" if ARCH_MULTI_V7
+ bool "Broadcom BCM281XX SoC family"
+ depends on ARCH_MULTI_V7
select ARCH_BCM_MOBILE
select HAVE_SMP
help
@@ -91,7 +96,8 @@ config ARCH_BCM_281XX
variants.
config ARCH_BCM_21664
- bool "Broadcom BCM21664 SoC family" if ARCH_MULTI_V7
+ bool "Broadcom BCM21664 SoC family"
+ depends on ARCH_MULTI_V7
select ARCH_BCM_MOBILE
select HAVE_SMP
help
@@ -122,7 +128,8 @@ config ARCH_BCM_MOBILE_SMP
comment "Other Architectures"
config ARCH_BCM2835
- bool "Broadcom BCM2835 family" if ARCH_MULTI_V6
+ bool "Broadcom BCM2835 family"
+ depends on ARCH_MULTI_V6
select ARCH_REQUIRE_GPIOLIB
select ARM_AMBA
select ARM_ERRATA_411920
@@ -135,7 +142,8 @@ config ARCH_BCM2835
used in the Raspberry Pi and Roku 2 devices.
config ARCH_BCM_63XX
- bool "Broadcom BCM63xx DSL SoC" if ARCH_MULTI_V7
+ bool "Broadcom BCM63xx DSL SoC"
+ depends on ARCH_MULTI_V7
depends on MMU
select ARM_ERRATA_754322
select ARM_ERRATA_764369 if SMP
@@ -152,7 +160,8 @@ config ARCH_BCM_63XX
the BCM63138 variant.
config ARCH_BRCMSTB
- bool "Broadcom BCM7XXX based boards" if ARCH_MULTI_V7
+ bool "Broadcom BCM7XXX based boards"
+ depends on ARCH_MULTI_V7
select ARM_GIC
select ARM_ERRATA_798181 if SMP
select HAVE_ARM_ARCH_TIMER
diff --git a/arch/arm/mach-berlin/Kconfig b/arch/arm/mach-berlin/Kconfig
index 742d53a..ffbfa0b 100644
--- a/arch/arm/mach-berlin/Kconfig
+++ b/arch/arm/mach-berlin/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_BERLIN
- bool "Marvell Berlin SoCs" if ARCH_MULTI_V7
+ bool "Marvell Berlin SoCs"
+ depends on ARCH_MULTI_V7
select ARCH_HAS_RESET_CONTROLLER
select ARCH_REQUIRE_GPIOLIB
select ARM_GIC
diff --git a/arch/arm/mach-cns3xxx/Kconfig b/arch/arm/mach-cns3xxx/Kconfig
index 3c22a19..eb14a0f 100644
--- a/arch/arm/mach-cns3xxx/Kconfig
+++ b/arch/arm/mach-cns3xxx/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_CNS3XXX
- bool "Cavium Networks CNS3XXX family" if ARCH_MULTI_V6
+ bool "Cavium Networks CNS3XXX family"
+ depends on ARCH_MULTI_V6
select ARM_GIC
select PCI_DOMAINS if PCI
help
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 3a10f1a..49e8dcf 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -8,7 +8,8 @@
# Configuration options for the EXYNOS4
menuconfig ARCH_EXYNOS
- bool "Samsung EXYNOS" if ARCH_MULTI_V7
+ bool "Samsung EXYNOS"
+ depends on ARCH_MULTI_V7
select ARCH_HAS_BANDGAP
select ARCH_HAS_HOLES_MEMORYMODEL
select ARCH_REQUIRE_GPIOLIB
diff --git a/arch/arm/mach-highbank/Kconfig b/arch/arm/mach-highbank/Kconfig
index 31aa866..81110ec 100644
--- a/arch/arm/mach-highbank/Kconfig
+++ b/arch/arm/mach-highbank/Kconfig
@@ -1,5 +1,6 @@
config ARCH_HIGHBANK
- bool "Calxeda ECX-1000/2000 (Highbank/Midway)" if ARCH_MULTI_V7
+ bool "Calxeda ECX-1000/2000 (Highbank/Midway)"
+ depends on ARCH_MULTI_V7
select ARCH_DMA_ADDR_T_64BIT if ARM_LPAE
select ARCH_HAS_HOLES_MEMORYMODEL
select ARCH_SUPPORTS_BIG_ENDIAN
diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig
index 83061ad..a3b091a 100644
--- a/arch/arm/mach-hisi/Kconfig
+++ b/arch/arm/mach-hisi/Kconfig
@@ -13,7 +13,8 @@ if ARCH_HISI
menu "Hisilicon platform type"
config ARCH_HI3xxx
- bool "Hisilicon Hi36xx family" if ARCH_MULTI_V7
+ bool "Hisilicon Hi36xx family"
+ depends on ARCH_MULTI_V7
select CACHE_L2X0
select HAVE_ARM_SCU if SMP
select HAVE_ARM_TWD if SMP
@@ -23,7 +24,8 @@ config ARCH_HI3xxx
Support for Hisilicon Hi36xx SoC family
config ARCH_HIP01
- bool "Hisilicon HIP01 family" if ARCH_MULTI_V7
+ bool "Hisilicon HIP01 family"
+ depends on ARCH_MULTI_V7
select HAVE_ARM_SCU if SMP
select HAVE_ARM_TWD if SMP
select ARM_GLOBAL_TIMER
@@ -31,7 +33,8 @@ config ARCH_HIP01
Support for Hisilicon HIP01 SoC family
config ARCH_HIP04
- bool "Hisilicon HiP04 Cortex A15 family" if ARCH_MULTI_V7
+ bool "Hisilicon HiP04 Cortex A15 family"
+ depends on ARCH_MULTI_V7
select ARM_ERRATA_798181 if SMP
select HAVE_ARM_ARCH_TIMER
select MCPM if SMP
@@ -40,7 +43,8 @@ config ARCH_HIP04
Support for Hisilicon HiP04 SoC family
config ARCH_HIX5HD2
- bool "Hisilicon X5HD2 family" if ARCH_MULTI_V7
+ bool "Hisilicon X5HD2 family"
+ depends on ARCH_MULTI_V7
select CACHE_L2X0
select HAVE_ARM_SCU if SMP
select HAVE_ARM_TWD if SMP
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 8ceda28..0ac180f 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_MXC
- bool "Freescale i.MX family" if ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7 || ARM_SINGLE_ARMV7M
+ bool "Freescale i.MX family"
+ depends on ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7 || ARM_SINGLE_ARMV7M
select ARCH_REQUIRE_GPIOLIB
select ARM_CPU_SUSPEND if PM
select CLKSRC_IMX_GPT
@@ -596,7 +597,8 @@ choice
default VF_USE_ARM_GLOBAL_TIMER
config VF_USE_ARM_GLOBAL_TIMER
- bool "Use ARM Global Timer" if ARCH_MULTI_V7
+ bool "Use ARM Global Timer"
+ depends on ARCH_MULTI_V7
select ARM_GLOBAL_TIMER
select CLKSRC_ARM_GLOBAL_TIMER_SCHED_CLOCK
help
diff --git a/arch/arm/mach-integrator/Kconfig b/arch/arm/mach-integrator/Kconfig
index 02d0834..2fa9d11 100644
--- a/arch/arm/mach-integrator/Kconfig
+++ b/arch/arm/mach-integrator/Kconfig
@@ -1,5 +1,6 @@
config ARCH_INTEGRATOR
- bool "ARM Ltd. Integrator family" if (ARCH_MULTI_V4T || ARCH_MULTI_V5 || ARCH_MULTI_V6)
+ bool "ARM Ltd. Integrator family"
+ depends on ARCH_MULTI_V4T || ARCH_MULTI_V5 || ARCH_MULTI_V6
select ARM_AMBA
select ARM_PATCH_PHYS_VIRT if MMU
select AUTO_ZRELADDR
diff --git a/arch/arm/mach-mediatek/Kconfig b/arch/arm/mach-mediatek/Kconfig
index aeece17..0abcc51 100644
--- a/arch/arm/mach-mediatek/Kconfig
+++ b/arch/arm/mach-mediatek/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_MEDIATEK
- bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7
+ bool "Mediatek MT65xx & MT81xx SoC"
+ depends on ARCH_MULTI_V7
select ARM_GIC
select PINCTRL
select MTK_TIMER
diff --git a/arch/arm/mach-meson/Kconfig b/arch/arm/mach-meson/Kconfig
index 5d56f86..31bdd91 100644
--- a/arch/arm/mach-meson/Kconfig
+++ b/arch/arm/mach-meson/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_MESON
- bool "Amlogic Meson SoCs" if ARCH_MULTI_V7
+ bool "Amlogic Meson SoCs"
+ depends on ARCH_MULTI_V7
select ARCH_REQUIRE_GPIOLIB
select GENERIC_IRQ_CHIP
select ARM_GIC
diff --git a/arch/arm/mach-moxart/Kconfig b/arch/arm/mach-moxart/Kconfig
index f49328c..180d9d2 100644
--- a/arch/arm/mach-moxart/Kconfig
+++ b/arch/arm/mach-moxart/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_MOXART
- bool "MOXA ART SoC" if ARCH_MULTI_V4
+ bool "MOXA ART SoC"
+ depends on ARCH_MULTI_V4
select CPU_FA526
select ARM_DMA_MEM_BUFFERABLE
select CLKSRC_MMIO
diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
index e20fc41..64e3d2c 100644
--- a/arch/arm/mach-mvebu/Kconfig
+++ b/arch/arm/mach-mvebu/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_MVEBU
- bool "Marvell Engineering Business Unit (MVEBU) SoCs" if (ARCH_MULTI_V7 || ARCH_MULTI_V5)
+ bool "Marvell Engineering Business Unit (MVEBU) SoCs"
+ depends on ARCH_MULTI_V7 || ARCH_MULTI_V5
select ARCH_SUPPORTS_BIG_ENDIAN
select CLKSRC_MMIO
select GENERIC_IRQ_CHIP
@@ -25,7 +26,8 @@ config MACH_MVEBU_V7
select MACH_MVEBU_ANY
config MACH_ARMADA_370
- bool "Marvell Armada 370 boards" if ARCH_MULTI_V7
+ bool "Marvell Armada 370 boards"
+ depends on ARCH_MULTI_V7
select ARMADA_370_CLK
select CPU_PJ4B
select MACH_MVEBU_V7
@@ -35,7 +37,8 @@ config MACH_ARMADA_370
on the Marvell Armada 370 SoC with device tree.
config MACH_ARMADA_375
- bool "Marvell Armada 375 boards" if ARCH_MULTI_V7
+ bool "Marvell Armada 375 boards"
+ depends on ARCH_MULTI_V7
select ARM_ERRATA_720789
select ARM_ERRATA_753970
select ARM_GIC
@@ -50,7 +53,8 @@ config MACH_ARMADA_375
on the Marvell Armada 375 SoC with device tree.
config MACH_ARMADA_38X
- bool "Marvell Armada 380/385 boards" if ARCH_MULTI_V7
+ bool "Marvell Armada 380/385 boards"
+ depends on ARCH_MULTI_V7
select ARM_ERRATA_720789
select ARM_ERRATA_753970
select ARM_GIC
@@ -65,7 +69,8 @@ config MACH_ARMADA_38X
on the Marvell Armada 380/385 SoC with device tree.
config MACH_ARMADA_39X
- bool "Marvell Armada 39x boards" if ARCH_MULTI_V7
+ bool "Marvell Armada 39x boards"
+ depends on ARCH_MULTI_V7
select ARM_GIC
select ARMADA_39X_CLK
select CACHE_L2X0
@@ -79,7 +84,8 @@ config MACH_ARMADA_39X
on the Marvell Armada 39x SoC with device tree.
config MACH_ARMADA_XP
- bool "Marvell Armada XP boards" if ARCH_MULTI_V7
+ bool "Marvell Armada XP boards"
+ depends on ARCH_MULTI_V7
select ARMADA_XP_CLK
select CPU_PJ4B
select MACH_MVEBU_V7
@@ -89,7 +95,8 @@ config MACH_ARMADA_XP
on the Marvell Armada XP SoC with device tree.
config MACH_DOVE
- bool "Marvell Dove boards" if ARCH_MULTI_V7
+ bool "Marvell Dove boards"
+ depends on ARCH_MULTI_V7
select CACHE_L2X0
select CPU_PJ4
select DOVE_CLK
@@ -103,7 +110,8 @@ config MACH_DOVE
Marvell Dove using flattened device tree.
config MACH_KIRKWOOD
- bool "Marvell Kirkwood boards" if ARCH_MULTI_V5
+ bool "Marvell Kirkwood boards"
+ depends on ARCH_MULTI_V5
select ARCH_REQUIRE_GPIOLIB
select CPU_FEROCEON
select KIRKWOOD_CLK
diff --git a/arch/arm/mach-picoxcell/Kconfig b/arch/arm/mach-picoxcell/Kconfig
index 62240f6..aef92ba 100644
--- a/arch/arm/mach-picoxcell/Kconfig
+++ b/arch/arm/mach-picoxcell/Kconfig
@@ -1,5 +1,6 @@
config ARCH_PICOXCELL
- bool "Picochip PicoXcell" if ARCH_MULTI_V6
+ bool "Picochip PicoXcell"
+ depends on ARCH_MULTI_V6
select ARCH_REQUIRE_GPIOLIB
select ARM_VIC
select DW_APB_TIMER_OF
diff --git a/arch/arm/mach-prima2/Kconfig b/arch/arm/mach-prima2/Kconfig
index 9ab8932..f998eb1 100644
--- a/arch/arm/mach-prima2/Kconfig
+++ b/arch/arm/mach-prima2/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_SIRF
- bool "CSR SiRF" if ARCH_MULTI_V7
+ bool "CSR SiRF"
+ depends on ARCH_MULTI_V7
select ARCH_HAS_RESET_CONTROLLER
select ARCH_REQUIRE_GPIOLIB
select GENERIC_IRQ_CHIP
diff --git a/arch/arm/mach-qcom/Kconfig b/arch/arm/mach-qcom/Kconfig
index 2256cd1..7349450 100644
--- a/arch/arm/mach-qcom/Kconfig
+++ b/arch/arm/mach-qcom/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_QCOM
- bool "Qualcomm Support" if ARCH_MULTI_V7
+ bool "Qualcomm Support"
+ depends on ARCH_MULTI_V7
select ARCH_SUPPORTS_BIG_ENDIAN
select ARM_GIC
select ARM_AMBA
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index ae4eb7c..cef42fd 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -1,5 +1,6 @@
config ARCH_ROCKCHIP
- bool "Rockchip RK2928 and RK3xxx SOCs" if ARCH_MULTI_V7
+ bool "Rockchip RK2928 and RK3xxx SOCs"
+ depends on ARCH_MULTI_V7
select PINCTRL
select PINCTRL_ROCKCHIP
select ARCH_HAS_RESET_CONTROLLER
diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
index 330bfc8..13bc982 100644
--- a/arch/arm/mach-s5pv210/Kconfig
+++ b/arch/arm/mach-s5pv210/Kconfig
@@ -8,7 +8,8 @@
# Configuration options for the S5PV210/S5PC110
config ARCH_S5PV210
- bool "Samsung S5PV210/S5PC110" if ARCH_MULTI_V7
+ bool "Samsung S5PV210/S5PC110"
+ depends on ARCH_MULTI_V7
select ARCH_HAS_HOLES_MEMORYMODEL
select ARCH_REQUIRE_GPIOLIB
select ARM_VIC
diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
index 88734a5..0f25f8f 100644
--- a/arch/arm/mach-shmobile/Kconfig
+++ b/arch/arm/mach-shmobile/Kconfig
@@ -30,8 +30,8 @@ config ARCH_RMOBILE
select SYS_SUPPORTS_SH_TMU
menuconfig ARCH_SHMOBILE_MULTI
- bool "Renesas ARM SoCs" if ARCH_MULTI_V7
- depends on MMU
+ bool "Renesas ARM SoCs"
+ depends on ARCH_MULTI_V7 && MMU
select ARCH_SHMOBILE
select HAVE_ARM_SCU if SMP
select HAVE_ARM_TWD if SMP
diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig
index 90efdeb..d0f62ea 100644
--- a/arch/arm/mach-socfpga/Kconfig
+++ b/arch/arm/mach-socfpga/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_SOCFPGA
- bool "Altera SOCFPGA family" if ARCH_MULTI_V7
+ bool "Altera SOCFPGA family"
+ depends on ARCH_MULTI_V7
select ARCH_SUPPORTS_BIG_ENDIAN
select ARM_AMBA
select ARM_GIC
diff --git a/arch/arm/mach-spear/Kconfig b/arch/arm/mach-spear/Kconfig
index b6f4bda2..ea9ea95 100644
--- a/arch/arm/mach-spear/Kconfig
+++ b/arch/arm/mach-spear/Kconfig
@@ -3,7 +3,8 @@
#
menuconfig PLAT_SPEAR
- bool "ST SPEAr Family" if ARCH_MULTI_V7 || ARCH_MULTI_V5
+ bool "ST SPEAr Family"
+ depends on ARCH_MULTI_V7 || ARCH_MULTI_V5
select ARCH_REQUIRE_GPIOLIB
select ARM_AMBA
select CLKSRC_MMIO
diff --git a/arch/arm/mach-sti/Kconfig b/arch/arm/mach-sti/Kconfig
index 125865d..736abe6 100644
--- a/arch/arm/mach-sti/Kconfig
+++ b/arch/arm/mach-sti/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_STI
- bool "STMicroelectronics Consumer Electronics SOCs" if ARCH_MULTI_V7
+ bool "STMicroelectronics Consumer Electronics SOCs"
+ depends on ARCH_MULTI_V7
select ARM_GIC
select ST_IRQCHIP
select ARM_GLOBAL_TIMER
diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
index 4efe2d4..c124d65 100644
--- a/arch/arm/mach-sunxi/Kconfig
+++ b/arch/arm/mach-sunxi/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_SUNXI
- bool "Allwinner SoCs" if ARCH_MULTI_V7
+ bool "Allwinner SoCs"
+ depends on ARCH_MULTI_V7
select ARCH_REQUIRE_GPIOLIB
select ARCH_HAS_RESET_CONTROLLER
select CLKSRC_MMIO
diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
index 0fa4c5f..a90f355 100644
--- a/arch/arm/mach-tegra/Kconfig
+++ b/arch/arm/mach-tegra/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_TEGRA
- bool "NVIDIA Tegra" if ARCH_MULTI_V7
+ bool "NVIDIA Tegra"
+ depends on ARCH_MULTI_V7
select ARCH_REQUIRE_GPIOLIB
select ARCH_SUPPORTS_TRUSTED_FOUNDATIONS
select ARM_AMBA
diff --git a/arch/arm/mach-u300/Kconfig b/arch/arm/mach-u300/Kconfig
index bc51a71..301a984 100644
--- a/arch/arm/mach-u300/Kconfig
+++ b/arch/arm/mach-u300/Kconfig
@@ -1,6 +1,6 @@
menuconfig ARCH_U300
- bool "ST-Ericsson U300 Series" if ARCH_MULTI_V5
- depends on MMU
+ bool "ST-Ericsson U300 Series"
+ depends on ARCH_MULTI_V5 && MMU
select ARCH_REQUIRE_GPIOLIB
select ARM_AMBA
select ARM_VIC
diff --git a/arch/arm/mach-ux500/Kconfig b/arch/arm/mach-ux500/Kconfig
index c9ac19b..a5c3373 100644
--- a/arch/arm/mach-ux500/Kconfig
+++ b/arch/arm/mach-ux500/Kconfig
@@ -1,6 +1,6 @@
menuconfig ARCH_U8500
- bool "ST-Ericsson U8500 Series" if ARCH_MULTI_V7
- depends on MMU
+ bool "ST-Ericsson U8500 Series"
+ depends on ARCH_MULTI_V7 && MMU
select AB8500_CORE
select ABX500_CORE
select ARCH_REQUIRE_GPIOLIB
diff --git a/arch/arm/mach-vexpress/Kconfig b/arch/arm/mach-vexpress/Kconfig
index 10f9389..398a297 100644
--- a/arch/arm/mach-vexpress/Kconfig
+++ b/arch/arm/mach-vexpress/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_VEXPRESS
- bool "ARM Ltd. Versatile Express family" if ARCH_MULTI_V7
+ bool "ARM Ltd. Versatile Express family"
+ depends on ARCH_MULTI_V7
select ARCH_REQUIRE_GPIOLIB
select ARCH_SUPPORTS_BIG_ENDIAN
select ARM_AMBA
diff --git a/arch/arm/mach-zx/Kconfig b/arch/arm/mach-zx/Kconfig
index 7fdc5bf..42e107c 100644
--- a/arch/arm/mach-zx/Kconfig
+++ b/arch/arm/mach-zx/Kconfig
@@ -1,5 +1,6 @@
menuconfig ARCH_ZX
- bool "ZTE ZX family" if ARCH_MULTI_V7
+ bool "ZTE ZX family"
+ depends on ARCH_MULTI_V7
help
Support for ZTE ZX-based family of processors. TV
set-top-box processor is supported. More will be
diff --git a/arch/arm/mach-zynq/Kconfig b/arch/arm/mach-zynq/Kconfig
index 78e5e00..f287667 100644
--- a/arch/arm/mach-zynq/Kconfig
+++ b/arch/arm/mach-zynq/Kconfig
@@ -1,5 +1,6 @@
config ARCH_ZYNQ
- bool "Xilinx Zynq ARM Cortex A9 Platform" if ARCH_MULTI_V7
+ bool "Xilinx Zynq ARM Cortex A9 Platform"
+ depends on ARCH_MULTI_V7
select ARCH_SUPPORTS_BIG_ENDIAN
select ARM_AMBA
select ARM_GIC
--
1.9.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
@ 2015-11-16 9:31 ` Maxime Ripard
2015-11-16 10:05 ` Arnd Bergmann
` (13 subsequent siblings)
14 siblings, 0 replies; 26+ messages in thread
From: Maxime Ripard @ 2015-11-16 9:31 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Andrew Lunn, Krzysztof Kozlowski, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Liviu Dudau,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matthias Brugger,
Thierry Reding, Alexandre Belloni, Jamie Iles, Heiko Stuebner,
Alexandre Courbot, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
Florian Fainelli, Russell King, Viresh Kumar, Stephen Warren,
Magnus Damm, Michal Simek, Wei Xu, Lorenzo Pieralisi,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai
[-- Attachment #1.1: Type: text/plain, Size: 1427 bytes --]
Hi,
On Mon, Nov 16, 2015 at 12:06:10PM +0900, Masahiro Yamada wrote:
> Many ARM sub-architectures use prompts followed by "if" conditional,
> but it is wrong.
>
> Please notice the difference between
>
> config ARCH_FOO
> bool "Foo SoCs" if ARCH_MULTI_V7
>
> and
>
> config ARCH_FOO
> bool "Foo SoCs"
> depends on ARCH_MULTI_V7
>
> These two are *not* equivalent!
>
> In the former statement, it is not ARCH_FOO, but its prompt that
> depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
> is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
> not unmet dependency, Kconfig never warns. This is probably not what
> you want.
>
> The former should be used only when you need to do so, and you really
> understand what you are doing. (In most cases, it should be wrong!)
>
> For enabling/disabling sub-architectures, the latter is always correct.
>
> As a good side effect, this commit fixes some entries over 80 columns
> (mach-imx, mach-integrator, mach-mbevu).
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
For the sunxi part,
Acked-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 200 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2015-11-16 9:31 ` Maxime Ripard
@ 2015-11-16 10:05 ` Arnd Bergmann
2015-11-16 10:32 ` yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A
2015-11-16 10:38 ` Nicolas Ferre
` (12 subsequent siblings)
14 siblings, 1 reply; 26+ messages in thread
From: Arnd Bergmann @ 2015-11-16 10:05 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Andrew Lunn, Krzysztof Kozlowski, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Liviu Dudau,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matthias Brugger,
Thierry Reding, Alexandre Belloni, Jamie Iles, Heiko Stuebner,
Alexandre Courbot, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
Florian Fainelli, Russell King, Viresh Kumar, Stephen Warren,
Magnus Damm, Michal Simek, Wei Xu, Lorenzo Pieralisi,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai
On Monday 16 November 2015 12:06:10 Masahiro Yamada wrote:
> Many ARM sub-architectures use prompts followed by "if" conditional,
> but it is wrong.
>
> Please notice the difference between
>
> config ARCH_FOO
> bool "Foo SoCs" if ARCH_MULTI_V7
>
> and
>
> config ARCH_FOO
> bool "Foo SoCs"
> depends on ARCH_MULTI_V7
>
> These two are *not* equivalent!
>
> In the former statement, it is not ARCH_FOO, but its prompt that
> depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
> is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
> not unmet dependency, Kconfig never warns. This is probably not what
> you want.
Did you encounter a case where someone actually did a 'select' on one
of those symbols? I probably introduced a lot of them and did not
expect that to happen.
> The former should be used only when you need to do so, and you really
> understand what you are doing. (In most cases, it should be wrong!)
>
> For enabling/disabling sub-architectures, the latter is always correct.
>
> As a good side effect, this commit fixes some entries over 80 columns
> (mach-imx, mach-integrator, mach-mbevu).
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
> ---
>
> I hope this patch is applied to ARM-SOC, but am CCing Kbuild ML
> because the correct understanding of Kconfig is required for this patch.
Yes, we can take it through arm-soc, I don't think it's important but
I also don't mind the change.
> diff --git a/arch/arm/mach-integrator/Kconfig b/arch/arm/mach-integrator/Kconfig
> index 02d0834..2fa9d11 100644
> --- a/arch/arm/mach-integrator/Kconfig
> +++ b/arch/arm/mach-integrator/Kconfig
> @@ -1,5 +1,6 @@
> config ARCH_INTEGRATOR
> - bool "ARM Ltd. Integrator family" if (ARCH_MULTI_V4T || ARCH_MULTI_V5 || ARCH_MULTI_V6)
> + bool "ARM Ltd. Integrator family"
> + depends on ARCH_MULTI_V4T || ARCH_MULTI_V5 || ARCH_MULTI_V6
> select ARM_AMBA
> select ARM_PATCH_PHYS_VIRT if MMU
> select AUTO_ZRELADDR
There is one related change that I would like to see, and that is
to convert all top-level 'config' statements that have sub-options
into 'menuconfig' statements for consistency. At the moment, the
platform menu has a mix of platform-selection and platform-specific
options, and I'd like to make that more consistent.
Arnd
^ permalink raw reply [flat|nested] 26+ messages in thread
* RE: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
2015-11-16 10:05 ` Arnd Bergmann
2015-11-16 10:32 ` yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A
(?)
@ 2015-11-16 10:32 ` yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A
0 siblings, 0 replies; 26+ messages in thread
From: yamada.masahiro @ 2015-11-16 10:32 UTC (permalink / raw)
To: arnd-r2nGTMty4D4
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
arm-DgEjT+Ai2ygdnm+yROfE0A, mmarek-IBi9RG/b67k,
olof-nZhT3qVonbNeoWH0uzbU5w, linux-kbuild-u79uwXL29TY76Z2rM5mHXA,
jamie-wmLquQDDieKakBO8gow8eQ, agross-sgV2jX0FEOL9JmXXK+q4OQ,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
linux-sh-u79uwXL29TY76Z2rM5mHXA,
tsahee-IEYhy/pPZWng2XuLRlxkFAC/G2K4zDHf,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
linus.walleij-QSEj5FYQhm4dnm+yROfE0A,
galak-sgV2jX0FEOL9JmXXK+q4OQ, plagnioj-sclMFOaUSTBWk0Htik3J/w,
dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx,
baohua-DgEjT+Ai2ygdnm+yROfE0A,
shiraz.linux.kernel-Re5JQEeQqe8AvxtiuMwx3w,
rjui-dY08KVG/lbpWk0Htik3J/w, patrice.chotard-qxv4g6HH51o,
kernel-F5mvAk5X5gdBDgjK7y7TUQ,
soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA,
horms-/R6kz+dDXgpPR4JQBCEnsQ,
michal.simek-gjFFaj9aHVfQT0dZR+AlfA,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-soc-u79uwXL29TY76Z2rM5mHXA, davidb-sgV2jX0FEOL9JmXXK+q4OQ,
sbranden-dY08KVG/lbpWk0Htik3J/w, vireshk-DgEjT+Ai2ygdnm+yROfE0A,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ, mappyland78
SGkgQXJuZCwNCg0KIA0KPiBPbiBNb25kYXkgMTYgTm92ZW1iZXIgMjAxNSAxMjowNjoxMCBNYXNh
aGlybyBZYW1hZGEgd3JvdGU6DQo+ID4gTWFueSBBUk0gc3ViLWFyY2hpdGVjdHVyZXMgdXNlIHBy
b21wdHMgZm9sbG93ZWQgYnkgImlmIiBjb25kaXRpb25hbCwNCj4gPiBidXQgaXQgaXMgd3Jvbmcu
DQo+ID4NCj4gPiBQbGVhc2Ugbm90aWNlIHRoZSBkaWZmZXJlbmNlIGJldHdlZW4NCj4gPg0KPiA+
ICAgICBjb25maWcgQVJDSF9GT08NCj4gPiAgICAgICAgICAgICBib29sICJGb28gU29DcyIgaWYg
QVJDSF9NVUxUSV9WNw0KPiA+DQo+ID4gYW5kDQo+ID4NCj4gPiAgICAgY29uZmlnIEFSQ0hfRk9P
DQo+ID4gICAgICAgICAgICAgYm9vbCAiRm9vIFNvQ3MiDQo+ID4gICAgICAgICAgICAgZGVwZW5k
cyBvbiBBUkNIX01VTFRJX1Y3DQo+ID4NCj4gPiBUaGVzZSB0d28gYXJlICpub3QqIGVxdWl2YWxl
bnQhDQo+ID4NCj4gPiBJbiB0aGUgZm9ybWVyIHN0YXRlbWVudCwgaXQgaXMgbm90IEFSQ0hfRk9P
LCBidXQgaXRzIHByb21wdCB0aGF0DQo+ID4gZGVwZW5kcyBvbiBBUkNIX01VTFRJX1Y3LiAgU28s
IGl0IGlzIGNvbXBsZXRlbHkgdmFsaWQgdGhhdCBBUkNIX0ZPTyBpcw0KPiA+IHNlbGVjdGVkIGJ5
IGFub3RoZXIsIGJ1dCBBUkNIX01VTFRJX1Y3IGlzIHN0aWxsIGRpc2FibGVkLiBBcyBpdCBpcyBu
b3QNCj4gPiB1bm1ldCBkZXBlbmRlbmN5LCBLY29uZmlnIG5ldmVyIHdhcm5zLiAgVGhpcyBpcyBw
cm9iYWJseSBub3Qgd2hhdCB5b3UNCj4gPiB3YW50Lg0KPiANCj4gRGlkIHlvdSBlbmNvdW50ZXIg
YSBjYXNlIHdoZXJlIHNvbWVvbmUgYWN0dWFsbHkgZGlkIGEgJ3NlbGVjdCcgb24gb25lIG9mDQo+
IHRob3NlIHN5bWJvbHM/IEkgcHJvYmFibHkgaW50cm9kdWNlZCBhIGxvdCBvZiB0aGVtIGFuZCBk
aWQgbm90IGV4cGVjdCB0aGF0DQo+IHRvIGhhcHBlbi4NCg0KTm8sIGZvciBBUk0gc3ViLWFyY2hp
dGVjdHVyZXMuDQpCdXQsIHllcyBmb3IgdGhlIEFSTSBjb3JlIHBhcnQuDQoNCg0KRm9yIGV4YW1w
bGUsIHRoZSBmb2xsb3dpbmcgZW50cnkgaW4gYXJjaC9hcm0vS2NvbmZpZyBpcyBzdXNwaWNvdXMu
DQoNCmNvbmZpZyBQQ0kNCiAgICAgICAgYm9vbCAiUENJIHN1cHBvcnQiIGlmIE1JR0hUX0hBVkVf
UENJDQogICAgICAgIGhlbHANCiAgICAgICAgICBGaW5kIG91dCB3aGV0aGVyIHlvdSBoYXZlIGEg
UENJIG1vdGhlcmJvYXJkLiBQQ0kgaXMgdGhlIG5hbWUgb2YgYQ0KICAgICAgICAgIGJ1cyBzeXN0
ZW0sIGkuZS4gdGhlIHdheSB0aGUgQ1BVIHRhbGtzIHRvIHRoZSBvdGhlciBzdHVmZiBpbnNpZGUN
CiAgICAgICAgICB5b3VyIGJveC4gT3RoZXIgYnVzIHN5c3RlbXMgYXJlIElTQSwgRUlTQSwgTWlj
cm9DaGFubmVsIChNQ0EpIG9yDQogICAgICAgICAgVkVTQS4gSWYgeW91IGhhdmUgUENJLCBzYXkg
WSwgb3RoZXJ3aXNlIE4uDQoNCg0KDQoNClRyeSAibWFrZSBBUkNIPWFybSBmb290YnJpZGdlX2Rl
ZmNvbmZpZyIgYW5kIGNoZWNrIHRoZSAuY29uZmlnIGZpbGUuDQoNCkl0IGRlZmluZXMgQ09ORklH
X1BDST15LCBidXQgbm90IENPTkZJR19NSUdIVF9IQVZFX1BDSS4NCkkgYW0gbm90IHN1cmUgdGhp
cyBpcyBhIHNhbmUgLmNvbmZpZyBvciBub3QuDQoNCkJ1dCwgYW55d2F5LCBLY29uZmlnIGRvZXMg
bm90IGNvbXBsYWluIGFib3V0IGl0Lg0KDQoNCldlIGhhdmUgc2ltaWxhciBpc3N1ZXMgZm9yIENQ
VV9WNiwgQ1BVX1Y2SywgQ1BVX1Y3LCBldGMuDQpUaGUgY29uZmlnIGlzIHNlbGVjdGVkLCBidXQg
dGhlICJpZiIgY29uZGl0aW9uYWwgaXMgdW5tZXQuDQooSSBkZWNpZGVkIHRvIHBvc3Rwb25lIHRo
aXMgcHJvYmxlbSBiZWNhdXNlIGl0IHdvdWxkIHRha2Ugc29tZSB0aW1lIHRvIHVuZGVyc3RhbmQN
CmNvbXBsaWNhdGVkIGRlcGVuZGVuY3kuKQ0KDQpUaGUgdXNlIG9mIGEgcHJvbXB0IGZvbGxvd2Vk
IGJ5ICJpZiIgd2l0aG91dCBjb3JyZWN0IHVuZGVyc3RhbmRpbmcgaXMgZGFuZ2Vyb3VzDQpiZWNh
dXNlIGl0IGNvdWxkIGhpZGUgdGhlIHVubWV0IGRlcGVuZGVuY3kgcHJvYmxlbS4NCg0KSSB3YW50
IHRvIGVsaW1pbmF0ZSB0aGUgcG90ZW50aWFsIHByb2JsZW0gYnkgdGhpcyBwYXRjaA0KYmVmb3Jl
IHNvbWVib2R5IGludHJvZHVjZSBpbnNhbmUgZGVwZW5kZW5jeS4NCg0KDQo+IA0KPiA+IGRpZmYg
LS1naXQgYS9hcmNoL2FybS9tYWNoLWludGVncmF0b3IvS2NvbmZpZw0KPiA+IGIvYXJjaC9hcm0v
bWFjaC1pbnRlZ3JhdG9yL0tjb25maWcNCj4gPiBpbmRleCAwMmQwODM0Li4yZmE5ZDExIDEwMDY0
NA0KPiA+IC0tLSBhL2FyY2gvYXJtL21hY2gtaW50ZWdyYXRvci9LY29uZmlnDQo+ID4gKysrIGIv
YXJjaC9hcm0vbWFjaC1pbnRlZ3JhdG9yL0tjb25maWcNCj4gPiBAQCAtMSw1ICsxLDYgQEANCj4g
PiAgY29uZmlnIEFSQ0hfSU5URUdSQVRPUg0KPiA+IC0JYm9vbCAiQVJNIEx0ZC4gSW50ZWdyYXRv
ciBmYW1pbHkiIGlmIChBUkNIX01VTFRJX1Y0VCB8fA0KPiBBUkNIX01VTFRJX1Y1IHx8IEFSQ0hf
TVVMVElfVjYpDQo+ID4gKwlib29sICJBUk0gTHRkLiBJbnRlZ3JhdG9yIGZhbWlseSINCj4gPiAr
CWRlcGVuZHMgb24gQVJDSF9NVUxUSV9WNFQgfHwgQVJDSF9NVUxUSV9WNSB8fCBBUkNIX01VTFRJ
X1Y2DQo+ID4gIAlzZWxlY3QgQVJNX0FNQkENCj4gPiAgCXNlbGVjdCBBUk1fUEFUQ0hfUEhZU19W
SVJUIGlmIE1NVQ0KPiA+ICAJc2VsZWN0IEFVVE9fWlJFTEFERFINCj4gDQo+IFRoZXJlIGlzIG9u
ZSByZWxhdGVkIGNoYW5nZSB0aGF0IEkgd291bGQgbGlrZSB0byBzZWUsIGFuZCB0aGF0IGlzIHRv
IGNvbnZlcnQNCj4gYWxsIHRvcC1sZXZlbCAnY29uZmlnJyBzdGF0ZW1lbnRzIHRoYXQgaGF2ZSBz
dWItb3B0aW9ucyBpbnRvICdtZW51Y29uZmlnJw0KPiBzdGF0ZW1lbnRzIGZvciBjb25zaXN0ZW5j
eS4gQXQgdGhlIG1vbWVudCwgdGhlIHBsYXRmb3JtIG1lbnUgaGFzIGEgbWl4IG9mDQo+IHBsYXRm
b3JtLXNlbGVjdGlvbiBhbmQgcGxhdGZvcm0tc3BlY2lmaWMgb3B0aW9ucywgYW5kIEknZCBsaWtl
IHRvIG1ha2UgdGhhdA0KPiBtb3JlIGNvbnNpc3RlbnQuDQoNCkkgYWdyZWUsIGJ1dCBpbiBhbm90
aGVyIHBhdGNoIChvciBzZXJpZXMpPw0KDQoNCg0KQmVzdCBSZWdhcmRzDQpNYXNoYWlybyBZYW1h
ZGENCg0K
^ permalink raw reply [flat|nested] 26+ messages in thread
* RE: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
@ 2015-11-16 10:32 ` yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A
0 siblings, 0 replies; 26+ messages in thread
From: yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A @ 2015-11-16 10:32 UTC (permalink / raw)
To: arnd-r2nGTMty4D4
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
arm-DgEjT+Ai2ygdnm+yROfE0A, mmarek-IBi9RG/b67k,
olof-nZhT3qVonbNeoWH0uzbU5w, linux-kbuild-u79uwXL29TY76Z2rM5mHXA,
jamie-wmLquQDDieKakBO8gow8eQ, agross-sgV2jX0FEOL9JmXXK+q4OQ,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
linux-sh-u79uwXL29TY76Z2rM5mHXA,
tsahee-IEYhy/pPZWng2XuLRlxkFAC/G2K4zDHf,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
linus.walleij-QSEj5FYQhm4dnm+yROfE0A,
galak-sgV2jX0FEOL9JmXXK+q4OQ, plagnioj-sclMFOaUSTBWk0Htik3J/w,
dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx,
baohua-DgEjT+Ai2ygdnm+yROfE0A,
shiraz.linux.kernel-Re5JQEeQqe8AvxtiuMwx3w,
rjui-dY08KVG/lbpWk0Htik3J/w, patrice.chotard-qxv4g6HH51o,
kernel-F5mvAk5X5gdBDgjK7y7TUQ,
soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA,
horms-/R6kz+dDXgpPR4JQBCEnsQ,
michal.simek-gjFFaj9aHVfQT0dZR+AlfA,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-soc-u79uwXL29TY76Z2rM5mHXA, davidb-sgV2jX0FEOL9JmXXK+q4OQ,
sbranden-dY08KVG/lbpWk0Htik3J/w, vireshk-DgEjT+Ai2ygdnm+yROfE0A,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ, mappyland78
Hi Arnd,
> On Monday 16 November 2015 12:06:10 Masahiro Yamada wrote:
> > Many ARM sub-architectures use prompts followed by "if" conditional,
> > but it is wrong.
> >
> > Please notice the difference between
> >
> > config ARCH_FOO
> > bool "Foo SoCs" if ARCH_MULTI_V7
> >
> > and
> >
> > config ARCH_FOO
> > bool "Foo SoCs"
> > depends on ARCH_MULTI_V7
> >
> > These two are *not* equivalent!
> >
> > In the former statement, it is not ARCH_FOO, but its prompt that
> > depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO is
> > selected by another, but ARCH_MULTI_V7 is still disabled. As it is not
> > unmet dependency, Kconfig never warns. This is probably not what you
> > want.
>
> Did you encounter a case where someone actually did a 'select' on one of
> those symbols? I probably introduced a lot of them and did not expect that
> to happen.
No, for ARM sub-architectures.
But, yes for the ARM core part.
For example, the following entry in arch/arm/Kconfig is suspicous.
config PCI
bool "PCI support" if MIGHT_HAVE_PCI
help
Find out whether you have a PCI motherboard. PCI is the name of a
bus system, i.e. the way the CPU talks to the other stuff inside
your box. Other bus systems are ISA, EISA, MicroChannel (MCA) or
VESA. If you have PCI, say Y, otherwise N.
Try "make ARCH=arm footbridge_defconfig" and check the .config file.
It defines CONFIG_PCI=y, but not CONFIG_MIGHT_HAVE_PCI.
I am not sure this is a sane .config or not.
But, anyway, Kconfig does not complain about it.
We have similar issues for CPU_V6, CPU_V6K, CPU_V7, etc.
The config is selected, but the "if" conditional is unmet.
(I decided to postpone this problem because it would take some time to understand
complicated dependency.)
The use of a prompt followed by "if" without correct understanding is dangerous
because it could hide the unmet dependency problem.
I want to eliminate the potential problem by this patch
before somebody introduce insane dependency.
>
> > diff --git a/arch/arm/mach-integrator/Kconfig
> > b/arch/arm/mach-integrator/Kconfig
> > index 02d0834..2fa9d11 100644
> > --- a/arch/arm/mach-integrator/Kconfig
> > +++ b/arch/arm/mach-integrator/Kconfig
> > @@ -1,5 +1,6 @@
> > config ARCH_INTEGRATOR
> > - bool "ARM Ltd. Integrator family" if (ARCH_MULTI_V4T ||
> ARCH_MULTI_V5 || ARCH_MULTI_V6)
> > + bool "ARM Ltd. Integrator family"
> > + depends on ARCH_MULTI_V4T || ARCH_MULTI_V5 || ARCH_MULTI_V6
> > select ARM_AMBA
> > select ARM_PATCH_PHYS_VIRT if MMU
> > select AUTO_ZRELADDR
>
> There is one related change that I would like to see, and that is to convert
> all top-level 'config' statements that have sub-options into 'menuconfig'
> statements for consistency. At the moment, the platform menu has a mix of
> platform-selection and platform-specific options, and I'd like to make that
> more consistent.
I agree, but in another patch (or series)?
Best Regards
Mashairo Yamada
^ permalink raw reply [flat|nested] 26+ messages in thread
* RE: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
@ 2015-11-16 10:32 ` yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A
0 siblings, 0 replies; 26+ messages in thread
From: yamada.masahiro @ 2015-11-16 10:32 UTC (permalink / raw)
To: arnd
Cc: linux-arm-kernel, arm, mmarek, olof, linux-kbuild, jamie, agross,
kernel, gregory.clement, linux-sh, tsahee, linux-arm-msm,
linus.walleij, galak, plagnioj, dinguyen, baohua,
shiraz.linux.kernel, rjui, patrice.chotard, kernel,
soren.brinkmann, horms, michal.simek, heiko, linux-rockchip,
linux-soc, davidb, sbranden, vireshk, alexandre.belloni,
kyungmin.park, mappyland78, k.kozlowski,
bcm-kernel-feedback-list, f.fainelli, gnurou, matthias.bgg,
kgene, thierry.reding, robh, linux-kernel, spear-devel,
sebastian.hesselbarth, sudeep.holla, andrew, linux,
linux-samsung-soc, linux-mediatek, linux-tegra, maxime.coquelin,
srinivas.kandagatla, shawnguo, liviu.dudau, jun.nie,
lorenzo.pieralisi, nicolas.ferre, jason, swarren, khalasa,
xuwei5, magnus.damm, wens, maxime.ripard
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 3205 bytes --]
Hi Arnd,
> On Monday 16 November 2015 12:06:10 Masahiro Yamada wrote:
> > Many ARM sub-architectures use prompts followed by "if" conditional,
> > but it is wrong.
> >
> > Please notice the difference between
> >
> > config ARCH_FOO
> > bool "Foo SoCs" if ARCH_MULTI_V7
> >
> > and
> >
> > config ARCH_FOO
> > bool "Foo SoCs"
> > depends on ARCH_MULTI_V7
> >
> > These two are *not* equivalent!
> >
> > In the former statement, it is not ARCH_FOO, but its prompt that
> > depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO is
> > selected by another, but ARCH_MULTI_V7 is still disabled. As it is not
> > unmet dependency, Kconfig never warns. This is probably not what you
> > want.
>
> Did you encounter a case where someone actually did a 'select' on one of
> those symbols? I probably introduced a lot of them and did not expect that
> to happen.
No, for ARM sub-architectures.
But, yes for the ARM core part.
For example, the following entry in arch/arm/Kconfig is suspicous.
config PCI
bool "PCI support" if MIGHT_HAVE_PCI
help
Find out whether you have a PCI motherboard. PCI is the name of a
bus system, i.e. the way the CPU talks to the other stuff inside
your box. Other bus systems are ISA, EISA, MicroChannel (MCA) or
VESA. If you have PCI, say Y, otherwise N.
Try "make ARCH=arm footbridge_defconfig" and check the .config file.
It defines CONFIG_PCI=y, but not CONFIG_MIGHT_HAVE_PCI.
I am not sure this is a sane .config or not.
But, anyway, Kconfig does not complain about it.
We have similar issues for CPU_V6, CPU_V6K, CPU_V7, etc.
The config is selected, but the "if" conditional is unmet.
(I decided to postpone this problem because it would take some time to understand
complicated dependency.)
The use of a prompt followed by "if" without correct understanding is dangerous
because it could hide the unmet dependency problem.
I want to eliminate the potential problem by this patch
before somebody introduce insane dependency.
>
> > diff --git a/arch/arm/mach-integrator/Kconfig
> > b/arch/arm/mach-integrator/Kconfig
> > index 02d0834..2fa9d11 100644
> > --- a/arch/arm/mach-integrator/Kconfig
> > +++ b/arch/arm/mach-integrator/Kconfig
> > @@ -1,5 +1,6 @@
> > config ARCH_INTEGRATOR
> > - bool "ARM Ltd. Integrator family" if (ARCH_MULTI_V4T ||
> ARCH_MULTI_V5 || ARCH_MULTI_V6)
> > + bool "ARM Ltd. Integrator family"
> > + depends on ARCH_MULTI_V4T || ARCH_MULTI_V5 || ARCH_MULTI_V6
> > select ARM_AMBA
> > select ARM_PATCH_PHYS_VIRT if MMU
> > select AUTO_ZRELADDR
>
> There is one related change that I would like to see, and that is to convert
> all top-level 'config' statements that have sub-options into 'menuconfig'
> statements for consistency. At the moment, the platform menu has a mix of
> platform-selection and platform-specific options, and I'd like to make that
> more consistent.
I agree, but in another patch (or series)?
Best Regards
Mashairo Yamada
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 26+ messages in thread
* RE: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
@ 2015-11-16 10:32 ` yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A
0 siblings, 0 replies; 26+ messages in thread
From: yamada.masahiro @ 2015-11-16 10:32 UTC (permalink / raw)
To: arnd
Cc: linux-arm-kernel, arm, mmarek, olof, linux-kbuild, jamie, agross,
kernel, gregory.clement, linux-sh, tsahee, linux-arm-msm,
linus.walleij, galak, plagnioj, dinguyen, baohua,
shiraz.linux.kernel, rjui, patrice.chotard, kernel,
soren.brinkmann, horms, michal.simek, heiko, linux-rockchip,
linux-soc, davidb, sbranden, vireshk, alexandre.belloni,
kyungmin.park, mappyland78, k.kozlowski,
bcm-kernel-feedback-list, f.fainelli, gnurou, matthias.bgg,
kgene, thierry.reding, robh, linux-kernel, spear-devel,
sebastian.hesselbarth, sudeep.holla, andrew, linux,
linux-samsung-soc, linux-mediatek, linux-tegra, maxime.coquelin,
srinivas.kandagatla, shawnguo, liviu.dudau, jun.nie,
lorenzo.pieralisi, nicolas.ferre, jason, swarren, khalasa,
xuwei5, magnus.damm, wens, maxime.ripard
Hi Arnd,
> On Monday 16 November 2015 12:06:10 Masahiro Yamada wrote:
> > Many ARM sub-architectures use prompts followed by "if" conditional,
> > but it is wrong.
> >
> > Please notice the difference between
> >
> > config ARCH_FOO
> > bool "Foo SoCs" if ARCH_MULTI_V7
> >
> > and
> >
> > config ARCH_FOO
> > bool "Foo SoCs"
> > depends on ARCH_MULTI_V7
> >
> > These two are *not* equivalent!
> >
> > In the former statement, it is not ARCH_FOO, but its prompt that
> > depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO is
> > selected by another, but ARCH_MULTI_V7 is still disabled. As it is not
> > unmet dependency, Kconfig never warns. This is probably not what you
> > want.
>
> Did you encounter a case where someone actually did a 'select' on one of
> those symbols? I probably introduced a lot of them and did not expect that
> to happen.
No, for ARM sub-architectures.
But, yes for the ARM core part.
For example, the following entry in arch/arm/Kconfig is suspicous.
config PCI
bool "PCI support" if MIGHT_HAVE_PCI
help
Find out whether you have a PCI motherboard. PCI is the name of a
bus system, i.e. the way the CPU talks to the other stuff inside
your box. Other bus systems are ISA, EISA, MicroChannel (MCA) or
VESA. If you have PCI, say Y, otherwise N.
Try "make ARCH=arm footbridge_defconfig" and check the .config file.
It defines CONFIG_PCI=y, but not CONFIG_MIGHT_HAVE_PCI.
I am not sure this is a sane .config or not.
But, anyway, Kconfig does not complain about it.
We have similar issues for CPU_V6, CPU_V6K, CPU_V7, etc.
The config is selected, but the "if" conditional is unmet.
(I decided to postpone this problem because it would take some time to understand
complicated dependency.)
The use of a prompt followed by "if" without correct understanding is dangerous
because it could hide the unmet dependency problem.
I want to eliminate the potential problem by this patch
before somebody introduce insane dependency.
>
> > diff --git a/arch/arm/mach-integrator/Kconfig
> > b/arch/arm/mach-integrator/Kconfig
> > index 02d0834..2fa9d11 100644
> > --- a/arch/arm/mach-integrator/Kconfig
> > +++ b/arch/arm/mach-integrator/Kconfig
> > @@ -1,5 +1,6 @@
> > config ARCH_INTEGRATOR
> > - bool "ARM Ltd. Integrator family" if (ARCH_MULTI_V4T ||
> ARCH_MULTI_V5 || ARCH_MULTI_V6)
> > + bool "ARM Ltd. Integrator family"
> > + depends on ARCH_MULTI_V4T || ARCH_MULTI_V5 || ARCH_MULTI_V6
> > select ARM_AMBA
> > select ARM_PATCH_PHYS_VIRT if MMU
> > select AUTO_ZRELADDR
>
> There is one related change that I would like to see, and that is to convert
> all top-level 'config' statements that have sub-options into 'menuconfig'
> statements for consistency. At the moment, the platform menu has a mix of
> platform-selection and platform-specific options, and I'd like to make that
> more consistent.
I agree, but in another patch (or series)?
Best Regards
Mashairo Yamada
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2015-11-16 9:31 ` Maxime Ripard
2015-11-16 10:05 ` Arnd Bergmann
@ 2015-11-16 10:38 ` Nicolas Ferre
2015-11-16 11:12 ` Heiko Stübner
` (11 subsequent siblings)
14 siblings, 0 replies; 26+ messages in thread
From: Nicolas Ferre @ 2015-11-16 10:38 UTC (permalink / raw)
To: Masahiro Yamada,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
arm-DgEjT+Ai2ygdnm+yROfE0A
Cc: Andrew Lunn, Krzysztof Kozlowski, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Liviu Dudau,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matthias Brugger,
Thierry Reding, Alexandre Belloni, Jamie Iles, Heiko Stuebner,
Alexandre Courbot, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
Florian Fainelli, Russell King, Viresh Kumar, Stephen Warren,
Magnus Damm, Michal Simek, Wei Xu, Lorenzo Pieralisi,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai
Le 16/11/2015 04:06, Masahiro Yamada a écrit :
> Many ARM sub-architectures use prompts followed by "if" conditional,
> but it is wrong.
>
> Please notice the difference between
>
> config ARCH_FOO
> bool "Foo SoCs" if ARCH_MULTI_V7
>
> and
>
> config ARCH_FOO
> bool "Foo SoCs"
> depends on ARCH_MULTI_V7
>
> These two are *not* equivalent!
>
> In the former statement, it is not ARCH_FOO, but its prompt that
> depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
> is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
> not unmet dependency, Kconfig never warns. This is probably not what
> you want.
>
> The former should be used only when you need to do so, and you really
> understand what you are doing. (In most cases, it should be wrong!)
>
> For enabling/disabling sub-architectures, the latter is always correct.
>
> As a good side effect, this commit fixes some entries over 80 columns
> (mach-imx, mach-integrator, mach-mbevu).
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
> ---
>
> I hope this patch is applied to ARM-SOC, but am CCing Kbuild ML
> because the correct understanding of Kconfig is required for this patch.
>
>
> arch/arm/Kconfig | 3 ++-
> arch/arm/mach-alpine/Kconfig | 3 ++-
> arch/arm/mach-at91/Kconfig | 15 ++++++++++-----
For AT91 part:
Acked-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Thanks, best regards.
> arch/arm/mach-axxia/Kconfig | 3 ++-
> arch/arm/mach-bcm/Kconfig | 27 ++++++++++++++++++---------
> arch/arm/mach-berlin/Kconfig | 3 ++-
> arch/arm/mach-cns3xxx/Kconfig | 3 ++-
> arch/arm/mach-exynos/Kconfig | 3 ++-
> arch/arm/mach-highbank/Kconfig | 3 ++-
> arch/arm/mach-hisi/Kconfig | 12 ++++++++----
> arch/arm/mach-imx/Kconfig | 6 ++++--
> arch/arm/mach-integrator/Kconfig | 3 ++-
> arch/arm/mach-mediatek/Kconfig | 3 ++-
> arch/arm/mach-meson/Kconfig | 3 ++-
> arch/arm/mach-moxart/Kconfig | 3 ++-
> arch/arm/mach-mvebu/Kconfig | 24 ++++++++++++++++--------
> arch/arm/mach-picoxcell/Kconfig | 3 ++-
> arch/arm/mach-prima2/Kconfig | 3 ++-
> arch/arm/mach-qcom/Kconfig | 3 ++-
> arch/arm/mach-rockchip/Kconfig | 3 ++-
> arch/arm/mach-s5pv210/Kconfig | 3 ++-
> arch/arm/mach-shmobile/Kconfig | 4 ++--
> arch/arm/mach-socfpga/Kconfig | 3 ++-
> arch/arm/mach-spear/Kconfig | 3 ++-
> arch/arm/mach-sti/Kconfig | 3 ++-
> arch/arm/mach-sunxi/Kconfig | 3 ++-
> arch/arm/mach-tegra/Kconfig | 3 ++-
> arch/arm/mach-u300/Kconfig | 4 ++--
> arch/arm/mach-ux500/Kconfig | 4 ++--
> arch/arm/mach-vexpress/Kconfig | 3 ++-
> arch/arm/mach-zx/Kconfig | 3 ++-
> arch/arm/mach-zynq/Kconfig | 3 ++-
> 32 files changed, 110 insertions(+), 58 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 0365cbb..54fda82 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -794,7 +794,8 @@ config ARCH_MULTI_CPU_AUTO
> endmenu
>
> config ARCH_VIRT
> - bool "Dummy Virtual Machine" if ARCH_MULTI_V7
> + bool "Dummy Virtual Machine"
> + depends on ARCH_MULTI_V7
> select ARM_AMBA
> select ARM_GIC
> select ARM_GIC_V3
> diff --git a/arch/arm/mach-alpine/Kconfig b/arch/arm/mach-alpine/Kconfig
> index 2c44b93..5c2d54f 100644
> --- a/arch/arm/mach-alpine/Kconfig
> +++ b/arch/arm/mach-alpine/Kconfig
> @@ -1,5 +1,6 @@
> config ARCH_ALPINE
> - bool "Annapurna Labs Alpine platform" if ARCH_MULTI_V7
> + bool "Annapurna Labs Alpine platform"
> + depends on ARCH_MULTI_V7
> select ARM_AMBA
> select ARM_GIC
> select GENERIC_IRQ_CHIP
> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index 9267300..8649f03 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -9,7 +9,8 @@ menuconfig ARCH_AT91
>
> if ARCH_AT91
> config SOC_SAMA5D2
> - bool "SAMA5D2 family" if ARCH_MULTI_V7
> + bool "SAMA5D2 family"
> + depends on ARCH_MULTI_V7
> select SOC_SAMA5
> select CACHE_L2X0
> select HAVE_FB_ATMEL
> @@ -21,7 +22,8 @@ config SOC_SAMA5D2
> Select this if ou are using one of Atmel's SAMA5D2 family SoC.
>
> config SOC_SAMA5D3
> - bool "SAMA5D3 family" if ARCH_MULTI_V7
> + bool "SAMA5D3 family"
> + depends on ARCH_MULTI_V7
> select SOC_SAMA5
> select HAVE_FB_ATMEL
> select HAVE_AT91_UTMI
> @@ -32,7 +34,8 @@ config SOC_SAMA5D3
> This support covers SAMA5D31, SAMA5D33, SAMA5D34, SAMA5D35, SAMA5D36.
>
> config SOC_SAMA5D4
> - bool "SAMA5D4 family" if ARCH_MULTI_V7
> + bool "SAMA5D4 family"
> + depends on ARCH_MULTI_V7
> select SOC_SAMA5
> select CACHE_L2X0
> select HAVE_FB_ATMEL
> @@ -44,7 +47,8 @@ config SOC_SAMA5D4
> Select this if you are using one of Atmel's SAMA5D4 family SoC.
>
> config SOC_AT91RM9200
> - bool "AT91RM9200" if ARCH_MULTI_V4T
> + bool "AT91RM9200"
> + depends on ARCH_MULTI_V4T
> select ATMEL_AIC_IRQ
> select ATMEL_ST
> select CPU_ARM920T
> @@ -56,7 +60,8 @@ config SOC_AT91RM9200
> Select this if you are using Atmel's AT91RM9200 SoC.
>
> config SOC_AT91SAM9
> - bool "AT91SAM9" if ARCH_MULTI_V5
> + bool "AT91SAM9"
> + depends on ARCH_MULTI_V5
> select ATMEL_AIC_IRQ
> select ATMEL_SDRAMC
> select CPU_ARM926T
> diff --git a/arch/arm/mach-axxia/Kconfig b/arch/arm/mach-axxia/Kconfig
> index 8be7e0a..6c6d5e7 100644
> --- a/arch/arm/mach-axxia/Kconfig
> +++ b/arch/arm/mach-axxia/Kconfig
> @@ -1,5 +1,6 @@
> config ARCH_AXXIA
> - bool "LSI Axxia platforms" if (ARCH_MULTI_V7 && ARM_LPAE)
> + bool "LSI Axxia platforms"
> + depends on ARCH_MULTI_V7 && ARM_LPAE
> select ARCH_DMA_ADDR_T_64BIT
> select ARM_AMBA
> select ARM_GIC
> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
> index 8c53c55..77116dc 100644
> --- a/arch/arm/mach-bcm/Kconfig
> +++ b/arch/arm/mach-bcm/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_BCM
> - bool "Broadcom SoC Support" if ARCH_MULTI_V6_V7
> + bool "Broadcom SoC Support"
> + depends on ARCH_MULTI_V6_V7
> help
> This enables support for Broadcom ARM based SoC chips
>
> @@ -27,7 +28,8 @@ config ARCH_BCM_IPROC
> Currently supported SoCs are Cygnus.
>
> config ARCH_BCM_CYGNUS
> - bool "Broadcom Cygnus Support" if ARCH_MULTI_V7
> + bool "Broadcom Cygnus Support"
> + depends on ARCH_MULTI_V7
> select ARCH_BCM_IPROC
> help
> Enable support for the Cygnus family,
> @@ -36,7 +38,8 @@ config ARCH_BCM_CYGNUS
> BCM58300, BCM58302, BCM58303, BCM58305.
>
> config ARCH_BCM_NSP
> - bool "Broadcom Northstar Plus SoC Support" if ARCH_MULTI_V7
> + bool "Broadcom Northstar Plus SoC Support"
> + depends on ARCH_MULTI_V7
> select ARCH_BCM_IPROC
> select ARM_ERRATA_754322
> select ARM_ERRATA_775420
> @@ -50,7 +53,8 @@ config ARCH_BCM_NSP
> NAND flash, SATA and several other IO controllers.
>
> config ARCH_BCM_5301X
> - bool "Broadcom BCM470X / BCM5301X ARM SoC" if ARCH_MULTI_V7
> + bool "Broadcom BCM470X / BCM5301X ARM SoC"
> + depends on ARCH_MULTI_V7
> select ARCH_BCM_IPROC
> help
> Support for Broadcom BCM470X and BCM5301X SoCs with ARM CPU cores.
> @@ -82,7 +86,8 @@ config ARCH_BCM_MOBILE
> This enables support for systems based on Broadcom mobile SoCs.
>
> config ARCH_BCM_281XX
> - bool "Broadcom BCM281XX SoC family" if ARCH_MULTI_V7
> + bool "Broadcom BCM281XX SoC family"
> + depends on ARCH_MULTI_V7
> select ARCH_BCM_MOBILE
> select HAVE_SMP
> help
> @@ -91,7 +96,8 @@ config ARCH_BCM_281XX
> variants.
>
> config ARCH_BCM_21664
> - bool "Broadcom BCM21664 SoC family" if ARCH_MULTI_V7
> + bool "Broadcom BCM21664 SoC family"
> + depends on ARCH_MULTI_V7
> select ARCH_BCM_MOBILE
> select HAVE_SMP
> help
> @@ -122,7 +128,8 @@ config ARCH_BCM_MOBILE_SMP
> comment "Other Architectures"
>
> config ARCH_BCM2835
> - bool "Broadcom BCM2835 family" if ARCH_MULTI_V6
> + bool "Broadcom BCM2835 family"
> + depends on ARCH_MULTI_V6
> select ARCH_REQUIRE_GPIOLIB
> select ARM_AMBA
> select ARM_ERRATA_411920
> @@ -135,7 +142,8 @@ config ARCH_BCM2835
> used in the Raspberry Pi and Roku 2 devices.
>
> config ARCH_BCM_63XX
> - bool "Broadcom BCM63xx DSL SoC" if ARCH_MULTI_V7
> + bool "Broadcom BCM63xx DSL SoC"
> + depends on ARCH_MULTI_V7
> depends on MMU
> select ARM_ERRATA_754322
> select ARM_ERRATA_764369 if SMP
> @@ -152,7 +160,8 @@ config ARCH_BCM_63XX
> the BCM63138 variant.
>
> config ARCH_BRCMSTB
> - bool "Broadcom BCM7XXX based boards" if ARCH_MULTI_V7
> + bool "Broadcom BCM7XXX based boards"
> + depends on ARCH_MULTI_V7
> select ARM_GIC
> select ARM_ERRATA_798181 if SMP
> select HAVE_ARM_ARCH_TIMER
> diff --git a/arch/arm/mach-berlin/Kconfig b/arch/arm/mach-berlin/Kconfig
> index 742d53a..ffbfa0b 100644
> --- a/arch/arm/mach-berlin/Kconfig
> +++ b/arch/arm/mach-berlin/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_BERLIN
> - bool "Marvell Berlin SoCs" if ARCH_MULTI_V7
> + bool "Marvell Berlin SoCs"
> + depends on ARCH_MULTI_V7
> select ARCH_HAS_RESET_CONTROLLER
> select ARCH_REQUIRE_GPIOLIB
> select ARM_GIC
> diff --git a/arch/arm/mach-cns3xxx/Kconfig b/arch/arm/mach-cns3xxx/Kconfig
> index 3c22a19..eb14a0f 100644
> --- a/arch/arm/mach-cns3xxx/Kconfig
> +++ b/arch/arm/mach-cns3xxx/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_CNS3XXX
> - bool "Cavium Networks CNS3XXX family" if ARCH_MULTI_V6
> + bool "Cavium Networks CNS3XXX family"
> + depends on ARCH_MULTI_V6
> select ARM_GIC
> select PCI_DOMAINS if PCI
> help
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index 3a10f1a..49e8dcf 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -8,7 +8,8 @@
> # Configuration options for the EXYNOS4
>
> menuconfig ARCH_EXYNOS
> - bool "Samsung EXYNOS" if ARCH_MULTI_V7
> + bool "Samsung EXYNOS"
> + depends on ARCH_MULTI_V7
> select ARCH_HAS_BANDGAP
> select ARCH_HAS_HOLES_MEMORYMODEL
> select ARCH_REQUIRE_GPIOLIB
> diff --git a/arch/arm/mach-highbank/Kconfig b/arch/arm/mach-highbank/Kconfig
> index 31aa866..81110ec 100644
> --- a/arch/arm/mach-highbank/Kconfig
> +++ b/arch/arm/mach-highbank/Kconfig
> @@ -1,5 +1,6 @@
> config ARCH_HIGHBANK
> - bool "Calxeda ECX-1000/2000 (Highbank/Midway)" if ARCH_MULTI_V7
> + bool "Calxeda ECX-1000/2000 (Highbank/Midway)"
> + depends on ARCH_MULTI_V7
> select ARCH_DMA_ADDR_T_64BIT if ARM_LPAE
> select ARCH_HAS_HOLES_MEMORYMODEL
> select ARCH_SUPPORTS_BIG_ENDIAN
> diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig
> index 83061ad..a3b091a 100644
> --- a/arch/arm/mach-hisi/Kconfig
> +++ b/arch/arm/mach-hisi/Kconfig
> @@ -13,7 +13,8 @@ if ARCH_HISI
> menu "Hisilicon platform type"
>
> config ARCH_HI3xxx
> - bool "Hisilicon Hi36xx family" if ARCH_MULTI_V7
> + bool "Hisilicon Hi36xx family"
> + depends on ARCH_MULTI_V7
> select CACHE_L2X0
> select HAVE_ARM_SCU if SMP
> select HAVE_ARM_TWD if SMP
> @@ -23,7 +24,8 @@ config ARCH_HI3xxx
> Support for Hisilicon Hi36xx SoC family
>
> config ARCH_HIP01
> - bool "Hisilicon HIP01 family" if ARCH_MULTI_V7
> + bool "Hisilicon HIP01 family"
> + depends on ARCH_MULTI_V7
> select HAVE_ARM_SCU if SMP
> select HAVE_ARM_TWD if SMP
> select ARM_GLOBAL_TIMER
> @@ -31,7 +33,8 @@ config ARCH_HIP01
> Support for Hisilicon HIP01 SoC family
>
> config ARCH_HIP04
> - bool "Hisilicon HiP04 Cortex A15 family" if ARCH_MULTI_V7
> + bool "Hisilicon HiP04 Cortex A15 family"
> + depends on ARCH_MULTI_V7
> select ARM_ERRATA_798181 if SMP
> select HAVE_ARM_ARCH_TIMER
> select MCPM if SMP
> @@ -40,7 +43,8 @@ config ARCH_HIP04
> Support for Hisilicon HiP04 SoC family
>
> config ARCH_HIX5HD2
> - bool "Hisilicon X5HD2 family" if ARCH_MULTI_V7
> + bool "Hisilicon X5HD2 family"
> + depends on ARCH_MULTI_V7
> select CACHE_L2X0
> select HAVE_ARM_SCU if SMP
> select HAVE_ARM_TWD if SMP
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 8ceda28..0ac180f 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_MXC
> - bool "Freescale i.MX family" if ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7 || ARM_SINGLE_ARMV7M
> + bool "Freescale i.MX family"
> + depends on ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7 || ARM_SINGLE_ARMV7M
> select ARCH_REQUIRE_GPIOLIB
> select ARM_CPU_SUSPEND if PM
> select CLKSRC_IMX_GPT
> @@ -596,7 +597,8 @@ choice
> default VF_USE_ARM_GLOBAL_TIMER
>
> config VF_USE_ARM_GLOBAL_TIMER
> - bool "Use ARM Global Timer" if ARCH_MULTI_V7
> + bool "Use ARM Global Timer"
> + depends on ARCH_MULTI_V7
> select ARM_GLOBAL_TIMER
> select CLKSRC_ARM_GLOBAL_TIMER_SCHED_CLOCK
> help
> diff --git a/arch/arm/mach-integrator/Kconfig b/arch/arm/mach-integrator/Kconfig
> index 02d0834..2fa9d11 100644
> --- a/arch/arm/mach-integrator/Kconfig
> +++ b/arch/arm/mach-integrator/Kconfig
> @@ -1,5 +1,6 @@
> config ARCH_INTEGRATOR
> - bool "ARM Ltd. Integrator family" if (ARCH_MULTI_V4T || ARCH_MULTI_V5 || ARCH_MULTI_V6)
> + bool "ARM Ltd. Integrator family"
> + depends on ARCH_MULTI_V4T || ARCH_MULTI_V5 || ARCH_MULTI_V6
> select ARM_AMBA
> select ARM_PATCH_PHYS_VIRT if MMU
> select AUTO_ZRELADDR
> diff --git a/arch/arm/mach-mediatek/Kconfig b/arch/arm/mach-mediatek/Kconfig
> index aeece17..0abcc51 100644
> --- a/arch/arm/mach-mediatek/Kconfig
> +++ b/arch/arm/mach-mediatek/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_MEDIATEK
> - bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7
> + bool "Mediatek MT65xx & MT81xx SoC"
> + depends on ARCH_MULTI_V7
> select ARM_GIC
> select PINCTRL
> select MTK_TIMER
> diff --git a/arch/arm/mach-meson/Kconfig b/arch/arm/mach-meson/Kconfig
> index 5d56f86..31bdd91 100644
> --- a/arch/arm/mach-meson/Kconfig
> +++ b/arch/arm/mach-meson/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_MESON
> - bool "Amlogic Meson SoCs" if ARCH_MULTI_V7
> + bool "Amlogic Meson SoCs"
> + depends on ARCH_MULTI_V7
> select ARCH_REQUIRE_GPIOLIB
> select GENERIC_IRQ_CHIP
> select ARM_GIC
> diff --git a/arch/arm/mach-moxart/Kconfig b/arch/arm/mach-moxart/Kconfig
> index f49328c..180d9d2 100644
> --- a/arch/arm/mach-moxart/Kconfig
> +++ b/arch/arm/mach-moxart/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_MOXART
> - bool "MOXA ART SoC" if ARCH_MULTI_V4
> + bool "MOXA ART SoC"
> + depends on ARCH_MULTI_V4
> select CPU_FA526
> select ARM_DMA_MEM_BUFFERABLE
> select CLKSRC_MMIO
> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
> index e20fc41..64e3d2c 100644
> --- a/arch/arm/mach-mvebu/Kconfig
> +++ b/arch/arm/mach-mvebu/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_MVEBU
> - bool "Marvell Engineering Business Unit (MVEBU) SoCs" if (ARCH_MULTI_V7 || ARCH_MULTI_V5)
> + bool "Marvell Engineering Business Unit (MVEBU) SoCs"
> + depends on ARCH_MULTI_V7 || ARCH_MULTI_V5
> select ARCH_SUPPORTS_BIG_ENDIAN
> select CLKSRC_MMIO
> select GENERIC_IRQ_CHIP
> @@ -25,7 +26,8 @@ config MACH_MVEBU_V7
> select MACH_MVEBU_ANY
>
> config MACH_ARMADA_370
> - bool "Marvell Armada 370 boards" if ARCH_MULTI_V7
> + bool "Marvell Armada 370 boards"
> + depends on ARCH_MULTI_V7
> select ARMADA_370_CLK
> select CPU_PJ4B
> select MACH_MVEBU_V7
> @@ -35,7 +37,8 @@ config MACH_ARMADA_370
> on the Marvell Armada 370 SoC with device tree.
>
> config MACH_ARMADA_375
> - bool "Marvell Armada 375 boards" if ARCH_MULTI_V7
> + bool "Marvell Armada 375 boards"
> + depends on ARCH_MULTI_V7
> select ARM_ERRATA_720789
> select ARM_ERRATA_753970
> select ARM_GIC
> @@ -50,7 +53,8 @@ config MACH_ARMADA_375
> on the Marvell Armada 375 SoC with device tree.
>
> config MACH_ARMADA_38X
> - bool "Marvell Armada 380/385 boards" if ARCH_MULTI_V7
> + bool "Marvell Armada 380/385 boards"
> + depends on ARCH_MULTI_V7
> select ARM_ERRATA_720789
> select ARM_ERRATA_753970
> select ARM_GIC
> @@ -65,7 +69,8 @@ config MACH_ARMADA_38X
> on the Marvell Armada 380/385 SoC with device tree.
>
> config MACH_ARMADA_39X
> - bool "Marvell Armada 39x boards" if ARCH_MULTI_V7
> + bool "Marvell Armada 39x boards"
> + depends on ARCH_MULTI_V7
> select ARM_GIC
> select ARMADA_39X_CLK
> select CACHE_L2X0
> @@ -79,7 +84,8 @@ config MACH_ARMADA_39X
> on the Marvell Armada 39x SoC with device tree.
>
> config MACH_ARMADA_XP
> - bool "Marvell Armada XP boards" if ARCH_MULTI_V7
> + bool "Marvell Armada XP boards"
> + depends on ARCH_MULTI_V7
> select ARMADA_XP_CLK
> select CPU_PJ4B
> select MACH_MVEBU_V7
> @@ -89,7 +95,8 @@ config MACH_ARMADA_XP
> on the Marvell Armada XP SoC with device tree.
>
> config MACH_DOVE
> - bool "Marvell Dove boards" if ARCH_MULTI_V7
> + bool "Marvell Dove boards"
> + depends on ARCH_MULTI_V7
> select CACHE_L2X0
> select CPU_PJ4
> select DOVE_CLK
> @@ -103,7 +110,8 @@ config MACH_DOVE
> Marvell Dove using flattened device tree.
>
> config MACH_KIRKWOOD
> - bool "Marvell Kirkwood boards" if ARCH_MULTI_V5
> + bool "Marvell Kirkwood boards"
> + depends on ARCH_MULTI_V5
> select ARCH_REQUIRE_GPIOLIB
> select CPU_FEROCEON
> select KIRKWOOD_CLK
> diff --git a/arch/arm/mach-picoxcell/Kconfig b/arch/arm/mach-picoxcell/Kconfig
> index 62240f6..aef92ba 100644
> --- a/arch/arm/mach-picoxcell/Kconfig
> +++ b/arch/arm/mach-picoxcell/Kconfig
> @@ -1,5 +1,6 @@
> config ARCH_PICOXCELL
> - bool "Picochip PicoXcell" if ARCH_MULTI_V6
> + bool "Picochip PicoXcell"
> + depends on ARCH_MULTI_V6
> select ARCH_REQUIRE_GPIOLIB
> select ARM_VIC
> select DW_APB_TIMER_OF
> diff --git a/arch/arm/mach-prima2/Kconfig b/arch/arm/mach-prima2/Kconfig
> index 9ab8932..f998eb1 100644
> --- a/arch/arm/mach-prima2/Kconfig
> +++ b/arch/arm/mach-prima2/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_SIRF
> - bool "CSR SiRF" if ARCH_MULTI_V7
> + bool "CSR SiRF"
> + depends on ARCH_MULTI_V7
> select ARCH_HAS_RESET_CONTROLLER
> select ARCH_REQUIRE_GPIOLIB
> select GENERIC_IRQ_CHIP
> diff --git a/arch/arm/mach-qcom/Kconfig b/arch/arm/mach-qcom/Kconfig
> index 2256cd1..7349450 100644
> --- a/arch/arm/mach-qcom/Kconfig
> +++ b/arch/arm/mach-qcom/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_QCOM
> - bool "Qualcomm Support" if ARCH_MULTI_V7
> + bool "Qualcomm Support"
> + depends on ARCH_MULTI_V7
> select ARCH_SUPPORTS_BIG_ENDIAN
> select ARM_GIC
> select ARM_AMBA
> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> index ae4eb7c..cef42fd 100644
> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -1,5 +1,6 @@
> config ARCH_ROCKCHIP
> - bool "Rockchip RK2928 and RK3xxx SOCs" if ARCH_MULTI_V7
> + bool "Rockchip RK2928 and RK3xxx SOCs"
> + depends on ARCH_MULTI_V7
> select PINCTRL
> select PINCTRL_ROCKCHIP
> select ARCH_HAS_RESET_CONTROLLER
> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
> index 330bfc8..13bc982 100644
> --- a/arch/arm/mach-s5pv210/Kconfig
> +++ b/arch/arm/mach-s5pv210/Kconfig
> @@ -8,7 +8,8 @@
> # Configuration options for the S5PV210/S5PC110
>
> config ARCH_S5PV210
> - bool "Samsung S5PV210/S5PC110" if ARCH_MULTI_V7
> + bool "Samsung S5PV210/S5PC110"
> + depends on ARCH_MULTI_V7
> select ARCH_HAS_HOLES_MEMORYMODEL
> select ARCH_REQUIRE_GPIOLIB
> select ARM_VIC
> diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
> index 88734a5..0f25f8f 100644
> --- a/arch/arm/mach-shmobile/Kconfig
> +++ b/arch/arm/mach-shmobile/Kconfig
> @@ -30,8 +30,8 @@ config ARCH_RMOBILE
> select SYS_SUPPORTS_SH_TMU
>
> menuconfig ARCH_SHMOBILE_MULTI
> - bool "Renesas ARM SoCs" if ARCH_MULTI_V7
> - depends on MMU
> + bool "Renesas ARM SoCs"
> + depends on ARCH_MULTI_V7 && MMU
> select ARCH_SHMOBILE
> select HAVE_ARM_SCU if SMP
> select HAVE_ARM_TWD if SMP
> diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig
> index 90efdeb..d0f62ea 100644
> --- a/arch/arm/mach-socfpga/Kconfig
> +++ b/arch/arm/mach-socfpga/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_SOCFPGA
> - bool "Altera SOCFPGA family" if ARCH_MULTI_V7
> + bool "Altera SOCFPGA family"
> + depends on ARCH_MULTI_V7
> select ARCH_SUPPORTS_BIG_ENDIAN
> select ARM_AMBA
> select ARM_GIC
> diff --git a/arch/arm/mach-spear/Kconfig b/arch/arm/mach-spear/Kconfig
> index b6f4bda2..ea9ea95 100644
> --- a/arch/arm/mach-spear/Kconfig
> +++ b/arch/arm/mach-spear/Kconfig
> @@ -3,7 +3,8 @@
> #
>
> menuconfig PLAT_SPEAR
> - bool "ST SPEAr Family" if ARCH_MULTI_V7 || ARCH_MULTI_V5
> + bool "ST SPEAr Family"
> + depends on ARCH_MULTI_V7 || ARCH_MULTI_V5
> select ARCH_REQUIRE_GPIOLIB
> select ARM_AMBA
> select CLKSRC_MMIO
> diff --git a/arch/arm/mach-sti/Kconfig b/arch/arm/mach-sti/Kconfig
> index 125865d..736abe6 100644
> --- a/arch/arm/mach-sti/Kconfig
> +++ b/arch/arm/mach-sti/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_STI
> - bool "STMicroelectronics Consumer Electronics SOCs" if ARCH_MULTI_V7
> + bool "STMicroelectronics Consumer Electronics SOCs"
> + depends on ARCH_MULTI_V7
> select ARM_GIC
> select ST_IRQCHIP
> select ARM_GLOBAL_TIMER
> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
> index 4efe2d4..c124d65 100644
> --- a/arch/arm/mach-sunxi/Kconfig
> +++ b/arch/arm/mach-sunxi/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_SUNXI
> - bool "Allwinner SoCs" if ARCH_MULTI_V7
> + bool "Allwinner SoCs"
> + depends on ARCH_MULTI_V7
> select ARCH_REQUIRE_GPIOLIB
> select ARCH_HAS_RESET_CONTROLLER
> select CLKSRC_MMIO
> diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
> index 0fa4c5f..a90f355 100644
> --- a/arch/arm/mach-tegra/Kconfig
> +++ b/arch/arm/mach-tegra/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_TEGRA
> - bool "NVIDIA Tegra" if ARCH_MULTI_V7
> + bool "NVIDIA Tegra"
> + depends on ARCH_MULTI_V7
> select ARCH_REQUIRE_GPIOLIB
> select ARCH_SUPPORTS_TRUSTED_FOUNDATIONS
> select ARM_AMBA
> diff --git a/arch/arm/mach-u300/Kconfig b/arch/arm/mach-u300/Kconfig
> index bc51a71..301a984 100644
> --- a/arch/arm/mach-u300/Kconfig
> +++ b/arch/arm/mach-u300/Kconfig
> @@ -1,6 +1,6 @@
> menuconfig ARCH_U300
> - bool "ST-Ericsson U300 Series" if ARCH_MULTI_V5
> - depends on MMU
> + bool "ST-Ericsson U300 Series"
> + depends on ARCH_MULTI_V5 && MMU
> select ARCH_REQUIRE_GPIOLIB
> select ARM_AMBA
> select ARM_VIC
> diff --git a/arch/arm/mach-ux500/Kconfig b/arch/arm/mach-ux500/Kconfig
> index c9ac19b..a5c3373 100644
> --- a/arch/arm/mach-ux500/Kconfig
> +++ b/arch/arm/mach-ux500/Kconfig
> @@ -1,6 +1,6 @@
> menuconfig ARCH_U8500
> - bool "ST-Ericsson U8500 Series" if ARCH_MULTI_V7
> - depends on MMU
> + bool "ST-Ericsson U8500 Series"
> + depends on ARCH_MULTI_V7 && MMU
> select AB8500_CORE
> select ABX500_CORE
> select ARCH_REQUIRE_GPIOLIB
> diff --git a/arch/arm/mach-vexpress/Kconfig b/arch/arm/mach-vexpress/Kconfig
> index 10f9389..398a297 100644
> --- a/arch/arm/mach-vexpress/Kconfig
> +++ b/arch/arm/mach-vexpress/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_VEXPRESS
> - bool "ARM Ltd. Versatile Express family" if ARCH_MULTI_V7
> + bool "ARM Ltd. Versatile Express family"
> + depends on ARCH_MULTI_V7
> select ARCH_REQUIRE_GPIOLIB
> select ARCH_SUPPORTS_BIG_ENDIAN
> select ARM_AMBA
> diff --git a/arch/arm/mach-zx/Kconfig b/arch/arm/mach-zx/Kconfig
> index 7fdc5bf..42e107c 100644
> --- a/arch/arm/mach-zx/Kconfig
> +++ b/arch/arm/mach-zx/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_ZX
> - bool "ZTE ZX family" if ARCH_MULTI_V7
> + bool "ZTE ZX family"
> + depends on ARCH_MULTI_V7
> help
> Support for ZTE ZX-based family of processors. TV
> set-top-box processor is supported. More will be
> diff --git a/arch/arm/mach-zynq/Kconfig b/arch/arm/mach-zynq/Kconfig
> index 78e5e00..f287667 100644
> --- a/arch/arm/mach-zynq/Kconfig
> +++ b/arch/arm/mach-zynq/Kconfig
> @@ -1,5 +1,6 @@
> config ARCH_ZYNQ
> - bool "Xilinx Zynq ARM Cortex A9 Platform" if ARCH_MULTI_V7
> + bool "Xilinx Zynq ARM Cortex A9 Platform"
> + depends on ARCH_MULTI_V7
> select ARCH_SUPPORTS_BIG_ENDIAN
> select ARM_AMBA
> select ARM_GIC
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
2015-11-16 10:32 ` yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A
@ 2015-11-16 11:06 ` Russell King - ARM Linux
-1 siblings, 0 replies; 26+ messages in thread
From: Russell King - ARM Linux @ 2015-11-16 11:06 UTC (permalink / raw)
To: yamada.masahiro
Cc: arnd, linux-arm-kernel, arm, mmarek, olof, linux-kbuild, jamie,
agross, kernel, gregory.clement, linux-sh, tsahee, linux-arm-msm,
linus.walleij, galak, plagnioj, dinguyen, baohua,
shiraz.linux.kernel, rjui, patrice.chotard, kernel,
soren.brinkmann, horms, michal.simek, heiko, linux-rockchip,
linux-soc, davidb, sbranden, vireshk, alexandre.belloni,
kyungmin.park, mappyland78, k.kozlowski, bcm-kernel-fee
On Mon, Nov 16, 2015 at 10:32:51AM +0000, yamada.masahiro@socionext.com wrote:
> Hi Arnd,
>
>
> > On Monday 16 November 2015 12:06:10 Masahiro Yamada wrote:
> > > Many ARM sub-architectures use prompts followed by "if" conditional,
> > > but it is wrong.
> > >
> > > Please notice the difference between
> > >
> > > config ARCH_FOO
> > > bool "Foo SoCs" if ARCH_MULTI_V7
> > >
> > > and
> > >
> > > config ARCH_FOO
> > > bool "Foo SoCs"
> > > depends on ARCH_MULTI_V7
> > >
> > > These two are *not* equivalent!
> > >
> > > In the former statement, it is not ARCH_FOO, but its prompt that
> > > depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO is
> > > selected by another, but ARCH_MULTI_V7 is still disabled. As it is not
> > > unmet dependency, Kconfig never warns. This is probably not what you
> > > want.
> >
> > Did you encounter a case where someone actually did a 'select' on one of
> > those symbols? I probably introduced a lot of them and did not expect that
> > to happen.
>
> No, for ARM sub-architectures.
> But, yes for the ARM core part.
>
>
> For example, the following entry in arch/arm/Kconfig is suspicous.
>
> config PCI
> bool "PCI support" if MIGHT_HAVE_PCI
> help
> Find out whether you have a PCI motherboard. PCI is the name of a
> bus system, i.e. the way the CPU talks to the other stuff inside
> your box. Other bus systems are ISA, EISA, MicroChannel (MCA) or
> VESA. If you have PCI, say Y, otherwise N.
>
>
>
>
> Try "make ARCH=arm footbridge_defconfig" and check the .config file.
>
> It defines CONFIG_PCI=y, but not CONFIG_MIGHT_HAVE_PCI.
> I am not sure this is a sane .config or not.
It's correct. "MIGHT_HAVE_PCI" is used by platforms which _might_ _have_
_PCI_, not by platforms which _do_ _have_ _PCI_. Platforms which _do_
_have_ _PCI_ select PCI directly, and because "MIGHT_HAVE_PCI" is not
set, users are not offered an option that they can never disable.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
@ 2015-11-16 11:06 ` Russell King - ARM Linux
0 siblings, 0 replies; 26+ messages in thread
From: Russell King - ARM Linux @ 2015-11-16 11:06 UTC (permalink / raw)
To: yamada.masahiro
Cc: arnd, linux-arm-kernel, arm, mmarek, olof, linux-kbuild, jamie,
agross, kernel, gregory.clement, linux-sh, tsahee, linux-arm-msm,
linus.walleij, galak, plagnioj, dinguyen, baohua,
shiraz.linux.kernel, rjui, patrice.chotard, kernel,
soren.brinkmann, horms, michal.simek, heiko, linux-rockchip,
linux-soc, davidb, sbranden, vireshk, alexandre.belloni,
kyungmin.park, mappyland78, k.kozlowski,
bcm-kernel-feedback-list, f.fainelli, gnurou, matthias.bgg,
kgene, thierry.reding, robh, linux-kernel, spear-devel,
sebastian.hesselbarth, sudeep.holla, andrew, linux-samsung-soc,
linux-mediatek, linux-tegra, maxime.coquelin,
srinivas.kandagatla, shawnguo, liviu.dudau, jun.nie,
lorenzo.pieralisi, nicolas.ferre, jason, swarren, khalasa,
xuwei5, magnus.damm, wens, maxime.ripard
On Mon, Nov 16, 2015 at 10:32:51AM +0000, yamada.masahiro@socionext.com wrote:
> Hi Arnd,
>
>
> > On Monday 16 November 2015 12:06:10 Masahiro Yamada wrote:
> > > Many ARM sub-architectures use prompts followed by "if" conditional,
> > > but it is wrong.
> > >
> > > Please notice the difference between
> > >
> > > config ARCH_FOO
> > > bool "Foo SoCs" if ARCH_MULTI_V7
> > >
> > > and
> > >
> > > config ARCH_FOO
> > > bool "Foo SoCs"
> > > depends on ARCH_MULTI_V7
> > >
> > > These two are *not* equivalent!
> > >
> > > In the former statement, it is not ARCH_FOO, but its prompt that
> > > depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO is
> > > selected by another, but ARCH_MULTI_V7 is still disabled. As it is not
> > > unmet dependency, Kconfig never warns. This is probably not what you
> > > want.
> >
> > Did you encounter a case where someone actually did a 'select' on one of
> > those symbols? I probably introduced a lot of them and did not expect that
> > to happen.
>
> No, for ARM sub-architectures.
> But, yes for the ARM core part.
>
>
> For example, the following entry in arch/arm/Kconfig is suspicous.
>
> config PCI
> bool "PCI support" if MIGHT_HAVE_PCI
> help
> Find out whether you have a PCI motherboard. PCI is the name of a
> bus system, i.e. the way the CPU talks to the other stuff inside
> your box. Other bus systems are ISA, EISA, MicroChannel (MCA) or
> VESA. If you have PCI, say Y, otherwise N.
>
>
>
>
> Try "make ARCH=arm footbridge_defconfig" and check the .config file.
>
> It defines CONFIG_PCI=y, but not CONFIG_MIGHT_HAVE_PCI.
> I am not sure this is a sane .config or not.
It's correct. "MIGHT_HAVE_PCI" is used by platforms which _might_ _have_
_PCI_, not by platforms which _do_ _have_ _PCI_. Platforms which _do_
_have_ _PCI_ select PCI directly, and because "MIGHT_HAVE_PCI" is not
set, users are not offered an option that they can never disable.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
` (2 preceding siblings ...)
2015-11-16 10:38 ` Nicolas Ferre
@ 2015-11-16 11:12 ` Heiko Stübner
2015-11-16 12:26 ` Patrice Chotard
` (10 subsequent siblings)
14 siblings, 0 replies; 26+ messages in thread
From: Heiko Stübner @ 2015-11-16 11:12 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Andrew Lunn, Krzysztof Kozlowski, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Liviu Dudau,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matthias Brugger,
Thierry Reding, Alexandre Belloni, Jamie Iles, Alexandre Courbot,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Florian Fainelli,
Russell King, Viresh Kumar, Stephen Warren, Magnus Damm,
Michal Simek, Wei Xu, Lorenzo Pieralisi,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai,
arm-DgEjT+Ai2ygdnm+yROfE0A, bcm-kernel
Am Montag, 16. November 2015, 12:06:10 schrieb Masahiro Yamada:
> Many ARM sub-architectures use prompts followed by "if" conditional,
> but it is wrong.
>
> Please notice the difference between
>
> config ARCH_FOO
> bool "Foo SoCs" if ARCH_MULTI_V7
>
> and
>
> config ARCH_FOO
> bool "Foo SoCs"
> depends on ARCH_MULTI_V7
>
> These two are *not* equivalent!
>
> In the former statement, it is not ARCH_FOO, but its prompt that
> depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
> is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
> not unmet dependency, Kconfig never warns. This is probably not what
> you want.
>
> The former should be used only when you need to do so, and you really
> understand what you are doing. (In most cases, it should be wrong!)
>
> For enabling/disabling sub-architectures, the latter is always correct.
>
> As a good side effect, this commit fixes some entries over 80 columns
> (mach-imx, mach-integrator, mach-mbevu).
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
> ---
>
> I hope this patch is applied to ARM-SOC, but am CCing Kbuild ML
> because the correct understanding of Kconfig is required for this patch.
>
>
[...]
> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> index ae4eb7c..cef42fd 100644
> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -1,5 +1,6 @@
> config ARCH_ROCKCHIP
> - bool "Rockchip RK2928 and RK3xxx SOCs" if ARCH_MULTI_V7
> + bool "Rockchip RK2928 and RK3xxx SOCs"
> + depends on ARCH_MULTI_V7
> select PINCTRL
> select PINCTRL_ROCKCHIP
> select ARCH_HAS_RESET_CONTROLLER
for the Rockchip part
Acked-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
` (3 preceding siblings ...)
2015-11-16 11:12 ` Heiko Stübner
@ 2015-11-16 12:26 ` Patrice Chotard
2015-11-16 12:59 ` Liviu Dudau
` (9 subsequent siblings)
14 siblings, 0 replies; 26+ messages in thread
From: Patrice Chotard @ 2015-11-16 12:26 UTC (permalink / raw)
To: Masahiro Yamada,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
arm-DgEjT+Ai2ygdnm+yROfE0A
Cc: Andrew Lunn, Krzysztof Kozlowski, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Liviu Dudau,
Matthias Brugger, Thierry Reding, Alexandre Belloni, Jamie Iles,
Heiko Stuebner, Alexandre Courbot,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Florian Fainelli,
Russell King, Viresh Kumar, Stephen Warren, Magnus Damm,
Michal Simek, Wei Xu, Lorenzo Pieralisi,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai,
Kukjin Kim
Hi
On 11/16/2015 04:06 AM, Masahiro Yamada wrote:
> Many ARM sub-architectures use prompts followed by "if" conditional,
> but it is wrong.
>
> Please notice the difference between
>
> config ARCH_FOO
> bool "Foo SoCs" if ARCH_MULTI_V7
>
> and
>
> config ARCH_FOO
> bool "Foo SoCs"
> depends on ARCH_MULTI_V7
>
> These two are *not* equivalent!
>
> In the former statement, it is not ARCH_FOO, but its prompt that
> depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
> is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
> not unmet dependency, Kconfig never warns. This is probably not what
> you want.
>
> The former should be used only when you need to do so, and you really
> understand what you are doing. (In most cases, it should be wrong!)
>
> For enabling/disabling sub-architectures, the latter is always correct.
>
> As a good side effect, this commit fixes some entries over 80 columns
> (mach-imx, mach-integrator, mach-mbevu).
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
> ---
>
> I hope this patch is applied to ARM-SOC, but am CCing Kbuild ML
> because the correct understanding of Kconfig is required for this patch.
[...]
>
> diff --git a/arch/arm/mach-sti/Kconfig b/arch/arm/mach-sti/Kconfig
> index 125865d..736abe6 100644
> --- a/arch/arm/mach-sti/Kconfig
> +++ b/arch/arm/mach-sti/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_STI
> - bool "STMicroelectronics Consumer Electronics SOCs" if ARCH_MULTI_V7
> + bool "STMicroelectronics Consumer Electronics SOCs"
> + depends on ARCH_MULTI_V7
> select ARM_GIC
> select ST_IRQCHIP
> select ARM_GLOBAL_TIMER
>
For STI part:
Acked-by: Patrice Chotard <patrice.chotard-qxv4g6HH51o@public.gmane.org>
Thanks
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
` (4 preceding siblings ...)
2015-11-16 12:26 ` Patrice Chotard
@ 2015-11-16 12:59 ` Liviu Dudau
2015-11-16 23:49 ` Krzysztof Kozlowski
` (8 subsequent siblings)
14 siblings, 0 replies; 26+ messages in thread
From: Liviu Dudau @ 2015-11-16 12:59 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Andrew Lunn, Krzysztof Kozlowski, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Nicolas Ferre,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matthias Brugger,
Thierry Reding, Alexandre Belloni, Jamie Iles, Heiko Stuebner,
Alexandre Courbot, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
Florian Fainelli, Russell King, Viresh Kumar, Stephen Warren,
Magnus Damm, Michal Simek, Wei Xu, Lorenzo Pieralisi,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Mon, Nov 16, 2015 at 12:06:10PM +0900, Masahiro Yamada wrote:
> Many ARM sub-architectures use prompts followed by "if" conditional,
> but it is wrong.
>
> Please notice the difference between
>
> config ARCH_FOO
> bool "Foo SoCs" if ARCH_MULTI_V7
>
> and
>
> config ARCH_FOO
> bool "Foo SoCs"
> depends on ARCH_MULTI_V7
>
> These two are *not* equivalent!
>
> In the former statement, it is not ARCH_FOO, but its prompt that
> depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
> is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
> not unmet dependency, Kconfig never warns. This is probably not what
> you want.
>
> The former should be used only when you need to do so, and you really
> understand what you are doing. (In most cases, it should be wrong!)
>
> For enabling/disabling sub-architectures, the latter is always correct.
>
> As a good side effect, this commit fixes some entries over 80 columns
> (mach-imx, mach-integrator, mach-mbevu).
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> I hope this patch is applied to ARM-SOC, but am CCing Kbuild ML
> because the correct understanding of Kconfig is required for this patch.
>
>
> arch/arm/mach-vexpress/Kconfig | 3 ++-
>
> diff --git a/arch/arm/mach-vexpress/Kconfig b/arch/arm/mach-vexpress/Kconfig
> index 10f9389..398a297 100644
> --- a/arch/arm/mach-vexpress/Kconfig
> +++ b/arch/arm/mach-vexpress/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_VEXPRESS
> - bool "ARM Ltd. Versatile Express family" if ARCH_MULTI_V7
> + bool "ARM Ltd. Versatile Express family"
> + depends on ARCH_MULTI_V7
> select ARCH_REQUIRE_GPIOLIB
> select ARCH_SUPPORTS_BIG_ENDIAN
> select ARM_AMBA
For the vexpress part:
Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
` (5 preceding siblings ...)
2015-11-16 12:59 ` Liviu Dudau
@ 2015-11-16 23:49 ` Krzysztof Kozlowski
2015-11-17 10:42 ` Matthias Brugger
` (7 subsequent siblings)
14 siblings, 0 replies; 26+ messages in thread
From: Krzysztof Kozlowski @ 2015-11-16 23:49 UTC (permalink / raw)
To: Masahiro Yamada,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
arm-DgEjT+Ai2ygdnm+yROfE0A
Cc: Andrew Lunn, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Liviu Dudau,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matthias Brugger,
Thierry Reding, Alexandre Belloni, Jamie Iles, Heiko Stuebner,
Alexandre Courbot, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
Florian Fainelli, Russell King, Viresh Kumar, Stephen Warren,
Magnus Damm, Michal Simek, Wei Xu, Lorenzo Pieralisi,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai,
Kukjin Kim, bcm-kerne
On 16.11.2015 12:06, Masahiro Yamada wrote:
> Many ARM sub-architectures use prompts followed by "if" conditional,
> but it is wrong.
>
> Please notice the difference between
>
> config ARCH_FOO
> bool "Foo SoCs" if ARCH_MULTI_V7
>
> and
>
> config ARCH_FOO
> bool "Foo SoCs"
> depends on ARCH_MULTI_V7
>
> These two are *not* equivalent!
>
> In the former statement, it is not ARCH_FOO, but its prompt that
> depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
> is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
> not unmet dependency, Kconfig never warns. This is probably not what
> you want.
>
> The former should be used only when you need to do so, and you really
> understand what you are doing. (In most cases, it should be wrong!)
>
> For enabling/disabling sub-architectures, the latter is always correct.
>
> As a good side effect, this commit fixes some entries over 80 columns
> (mach-imx, mach-integrator, mach-mbevu).
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
> ---
>
> I hope this patch is applied to ARM-SOC, but am CCing Kbuild ML
> because the correct understanding of Kconfig is required for this patch.
>
>
> arch/arm/Kconfig | 3 ++-
> arch/arm/mach-alpine/Kconfig | 3 ++-
> arch/arm/mach-at91/Kconfig | 15 ++++++++++-----
> arch/arm/mach-axxia/Kconfig | 3 ++-
> arch/arm/mach-bcm/Kconfig | 27 ++++++++++++++++++---------
> arch/arm/mach-berlin/Kconfig | 3 ++-
> arch/arm/mach-cns3xxx/Kconfig | 3 ++-
> arch/arm/mach-exynos/Kconfig | 3 ++-
> arch/arm/mach-highbank/Kconfig | 3 ++-
> arch/arm/mach-hisi/Kconfig | 12 ++++++++----
> arch/arm/mach-imx/Kconfig | 6 ++++--
> arch/arm/mach-integrator/Kconfig | 3 ++-
> arch/arm/mach-mediatek/Kconfig | 3 ++-
> arch/arm/mach-meson/Kconfig | 3 ++-
> arch/arm/mach-moxart/Kconfig | 3 ++-
> arch/arm/mach-mvebu/Kconfig | 24 ++++++++++++++++--------
> arch/arm/mach-picoxcell/Kconfig | 3 ++-
> arch/arm/mach-prima2/Kconfig | 3 ++-
> arch/arm/mach-qcom/Kconfig | 3 ++-
> arch/arm/mach-rockchip/Kconfig | 3 ++-
> arch/arm/mach-s5pv210/Kconfig | 3 ++-
For Exynos and S5PV210:
Acked-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Best regards,
Krzysztof
> arch/arm/mach-shmobile/Kconfig | 4 ++--
> arch/arm/mach-socfpga/Kconfig | 3 ++-
> arch/arm/mach-spear/Kconfig | 3 ++-
> arch/arm/mach-sti/Kconfig | 3 ++-
> arch/arm/mach-sunxi/Kconfig | 3 ++-
> arch/arm/mach-tegra/Kconfig | 3 ++-
> arch/arm/mach-u300/Kconfig | 4 ++--
> arch/arm/mach-ux500/Kconfig | 4 ++--
> arch/arm/mach-vexpress/Kconfig | 3 ++-
> arch/arm/mach-zx/Kconfig | 3 ++-
> arch/arm/mach-zynq/Kconfig | 3 ++-
> 32 files changed, 110 insertions(+), 58 deletions(-)
>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
` (6 preceding siblings ...)
2015-11-16 23:49 ` Krzysztof Kozlowski
@ 2015-11-17 10:42 ` Matthias Brugger
2015-11-17 18:04 ` Simon Horman
` (6 subsequent siblings)
14 siblings, 0 replies; 26+ messages in thread
From: Matthias Brugger @ 2015-11-17 10:42 UTC (permalink / raw)
To: Masahiro Yamada,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
arm-DgEjT+Ai2ygdnm+yROfE0A
Cc: Andrew Lunn, Krzysztof Kozlowski, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Liviu Dudau,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, Thierry Reding,
Alexandre Belloni, Jamie Iles, Heiko Stuebner, Alexandre Courbot,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Florian Fainelli,
Russell King, Viresh Kumar, Stephen Warren, Magnus Damm,
Michal Simek, Wei Xu, Lorenzo Pieralisi,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai,
Kukjin
On 16/11/15 04:06, Masahiro Yamada wrote:
> Many ARM sub-architectures use prompts followed by "if" conditional,
> but it is wrong.
>
> Please notice the difference between
>
> config ARCH_FOO
> bool "Foo SoCs" if ARCH_MULTI_V7
>
> and
>
> config ARCH_FOO
> bool "Foo SoCs"
> depends on ARCH_MULTI_V7
>
> These two are *not* equivalent!
>
> In the former statement, it is not ARCH_FOO, but its prompt that
> depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
> is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
> not unmet dependency, Kconfig never warns. This is probably not what
> you want.
>
> The former should be used only when you need to do so, and you really
> understand what you are doing. (In most cases, it should be wrong!)
>
> For enabling/disabling sub-architectures, the latter is always correct.
>
> As a good side effect, this commit fixes some entries over 80 columns
> (mach-imx, mach-integrator, mach-mbevu).
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
> ---
>
> I hope this patch is applied to ARM-SOC, but am CCing Kbuild ML
> because the correct understanding of Kconfig is required for this patch.
>
[...]
> arch/arm/mach-mediatek/Kconfig | 3 ++-
[...]
> diff --git a/arch/arm/mach-mediatek/Kconfig b/arch/arm/mach-mediatek/Kconfig
> index aeece17..0abcc51 100644
> --- a/arch/arm/mach-mediatek/Kconfig
> +++ b/arch/arm/mach-mediatek/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_MEDIATEK
> - bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7
> + bool "Mediatek MT65xx & MT81xx SoC"
> + depends on ARCH_MULTI_V7
> select ARM_GIC
> select PINCTRL
> select MTK_TIMER
for Mediatek:
Acked-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
` (7 preceding siblings ...)
2015-11-17 10:42 ` Matthias Brugger
@ 2015-11-17 18:04 ` Simon Horman
2015-11-23 18:10 ` Gregory CLEMENT
` (5 subsequent siblings)
14 siblings, 0 replies; 26+ messages in thread
From: Simon Horman @ 2015-11-17 18:04 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Andrew Lunn, Krzysztof Kozlowski, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Liviu Dudau,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matthias Brugger,
Thierry Reding, Alexandre Belloni, Jamie Iles, Heiko Stuebner,
Alexandre Courbot, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
Florian Fainelli, Russell King, Viresh Kumar, Stephen Warren,
Magnus Damm, Michal Simek, Wei Xu, Lorenzo Pieralisi,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai
On Mon, Nov 16, 2015 at 12:06:10PM +0900, Masahiro Yamada wrote:
> Many ARM sub-architectures use prompts followed by "if" conditional,
> but it is wrong.
>
> Please notice the difference between
>
> config ARCH_FOO
> bool "Foo SoCs" if ARCH_MULTI_V7
>
> and
>
> config ARCH_FOO
> bool "Foo SoCs"
> depends on ARCH_MULTI_V7
>
> These two are *not* equivalent!
>
> In the former statement, it is not ARCH_FOO, but its prompt that
> depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
> is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
> not unmet dependency, Kconfig never warns. This is probably not what
> you want.
>
> The former should be used only when you need to do so, and you really
> understand what you are doing. (In most cases, it should be wrong!)
>
> For enabling/disabling sub-architectures, the latter is always correct.
>
> As a good side effect, this commit fixes some entries over 80 columns
> (mach-imx, mach-integrator, mach-mbevu).
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
> ---
>
> I hope this patch is applied to ARM-SOC, but am CCing Kbuild ML
> because the correct understanding of Kconfig is required for this patch.
Thanks for cleaning this up.
As per a response to another ARM-SoC-wide patch:
My suggestion is to split this patch up. In its current form
it seems bound to cause some merge conflicts at some point.
If you were to submit the mach-shmobile portion as a separate patch
I would be happy to queue it up.
That aside, I don't have any objections to the mach-shmobile change.
So if you wish to proceed with a large patch then for the mach-shmobile
portion:
Acked-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
` (8 preceding siblings ...)
2015-11-17 18:04 ` Simon Horman
@ 2015-11-23 18:10 ` Gregory CLEMENT
2015-11-24 9:30 ` Shawn Guo
` (4 subsequent siblings)
14 siblings, 0 replies; 26+ messages in thread
From: Gregory CLEMENT @ 2015-11-23 18:10 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Andrew Lunn, Krzysztof Kozlowski, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Liviu Dudau,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, Thierry Reding,
Alexandre Belloni, Jamie Iles, Heiko Stuebner, Alexandre Courbot,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Florian Fainelli,
Russell King, Viresh Kumar, Stephen Warren, Magnus Damm,
Michal Simek, Wei Xu, Lorenzo Pieralisi,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai,
arm
Hi Masahiro,
On lun., nov. 16 2015, Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org> wrote:
> Many ARM sub-architectures use prompts followed by "if" conditional,
> but it is wrong.
>
> Please notice the difference between
>
> config ARCH_FOO
> bool "Foo SoCs" if ARCH_MULTI_V7
>
> and
>
> config ARCH_FOO
> bool "Foo SoCs"
> depends on ARCH_MULTI_V7
>
> These two are *not* equivalent!
>
> In the former statement, it is not ARCH_FOO, but its prompt that
> depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
> is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
> not unmet dependency, Kconfig never warns. This is probably not what
> you want.
>
> The former should be used only when you need to do so, and you really
> understand what you are doing. (In most cases, it should be wrong!)
>
> For enabling/disabling sub-architectures, the latter is always correct.
>
> As a good side effect, this commit fixes some entries over 80 columns
> (mach-imx, mach-integrator, mach-mbevu).
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
> ---
>
> I hope this patch is applied to ARM-SOC, but am CCing Kbuild ML
> because the correct understanding of Kconfig is required for this patch.
>
[...]
> arch/arm/mach-mvebu/Kconfig | 24 ++++++++++++++++--------
For mvebu part
Acked-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Thanks,
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
` (9 preceding siblings ...)
2015-11-23 18:10 ` Gregory CLEMENT
@ 2015-11-24 9:30 ` Shawn Guo
2015-11-24 15:58 ` Thierry Reding
` (3 subsequent siblings)
14 siblings, 0 replies; 26+ messages in thread
From: Shawn Guo @ 2015-11-24 9:30 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Andrew Lunn, Krzysztof Kozlowski, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Liviu Dudau,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matthias Brugger,
Thierry Reding, Alexandre Belloni, Jamie Iles, Heiko Stuebner,
Alexandre Courbot, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
Florian Fainelli, Russell King, Viresh Kumar, Stephen Warren,
Magnus Damm, Michal Simek, Wei Xu, Lorenzo Pieralisi,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai
On Mon, Nov 16, 2015 at 12:06:10PM +0900, Masahiro Yamada wrote:
> Many ARM sub-architectures use prompts followed by "if" conditional,
> but it is wrong.
>
> Please notice the difference between
>
> config ARCH_FOO
> bool "Foo SoCs" if ARCH_MULTI_V7
>
> and
>
> config ARCH_FOO
> bool "Foo SoCs"
> depends on ARCH_MULTI_V7
>
> These two are *not* equivalent!
>
> In the former statement, it is not ARCH_FOO, but its prompt that
> depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
> is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
> not unmet dependency, Kconfig never warns. This is probably not what
> you want.
>
> The former should be used only when you need to do so, and you really
> understand what you are doing. (In most cases, it should be wrong!)
>
> For enabling/disabling sub-architectures, the latter is always correct.
>
> As a good side effect, this commit fixes some entries over 80 columns
> (mach-imx, mach-integrator, mach-mbevu).
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
> ---
...
> arch/arm/mach-imx/Kconfig | 6 ++++--
Acked-by: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
` (10 preceding siblings ...)
2015-11-24 9:30 ` Shawn Guo
@ 2015-11-24 15:58 ` Thierry Reding
2015-11-25 2:09 ` yamada.masahiro
2015-11-25 12:13 ` Krzysztof Hałasa
` (2 subsequent siblings)
14 siblings, 1 reply; 26+ messages in thread
From: Thierry Reding @ 2015-11-24 15:58 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Andrew Lunn, Krzysztof Kozlowski, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Liviu Dudau,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matthias Brugger,
Alexandre Belloni, Jamie Iles, Heiko Stuebner, Alexandre Courbot,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Florian Fainelli,
Russell King, Viresh Kumar, Stephen Warren, Magnus Damm,
Michal Simek, Wei Xu, Lorenzo Pieralisi,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai,
arm-DgEjT+Ai2ygdnm+yROfE0A, bcm-kernel-feedback-
[-- Attachment #1.1: Type: text/plain, Size: 328 bytes --]
On Mon, Nov 16, 2015 at 12:06:10PM +0900, Masahiro Yamada wrote:
[...]
> arch/arm/mach-tegra/Kconfig | 3 ++-
There will be a slight conflict between this and a patch in the tegra
tree, but nothing that the ARM SoC maintainers can't handle, so:
Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 200 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 26+ messages in thread
* RE: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
2015-11-24 15:58 ` Thierry Reding
2015-11-25 2:09 ` yamada.masahiro
(?)
@ 2015-11-25 2:09 ` yamada.masahiro
0 siblings, 0 replies; 26+ messages in thread
From: yamada.masahiro @ 2015-11-25 2:09 UTC (permalink / raw)
To: thierry.reding, arnd, arm
Cc: linux-arm-kernel, mmarek, olof, linux-kbuild, jamie, agross,
kernel, gregory.clement, linux-sh, tsahee, linux-arm-msm,
linus.walleij, galak, plagnioj, dinguyen, baohua,
shiraz.linux.kernel, rjui, patrice.chotard, kernel,
soren.brinkmann, horms, michal.simek, heiko, linux-rockchip,
linux-soc, davidb, sbranden, vireshk, alexandre.belloni,
kyungmin.park, k.kozlowski, bcm
SGkgQXJuZCwNCg0KQ291bGQgeW91IGFwcGx5IHRoaXMgcGF0Y2ggd2l0aCBBY2tlZC1ieSBzdG9y
bQ0Kc28gdGhhdCBvdGhlciBzdWJhcmNodGVjdHVyZXMgY2FuIGJhc2Ugb24gaXQ/DQoNCkFsc28s
IHRoZSBmb2xsb3dpbmcgc2VyaWVzOg0KDQoxLzI6IEFSTTogaGlzaTogZG8gbm90IGV4cG9ydCBz
bXBfb3BlcmF0aW9ucyBzdHJ1Y3R1cmVzDQoyLzI6IEFSTTogdXNlIGNvbnN0IGFuZCBfX2luaXRj
b25zdCBmb3Igc21wX29wZXJhdGlvbnMNCg0KDQoNCg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2Fn
ZS0tLS0tDQo+IEZyb206IFRoaWVycnkgUmVkaW5nIFttYWlsdG86dGhpZXJyeS5yZWRpbmdAZ21h
aWwuY29tXQ0KPiBTZW50OiBXZWRuZXNkYXksIE5vdmVtYmVyIDI1LCAyMDE1IDEyOjU5IEFNDQo+
IFRvOiBZYW1hZGEsIE1hc2FoaXJvDQo+IENjOiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh
ZGVhZC5vcmc7IGFybUBrZXJuZWwub3JnOyBNaWNoYWwgTWFyZWs7DQo+IEFybmQgQmVyZ21hbm47
IE9sb2YgSm9oYW5zc29uOyBsaW51eC1rYnVpbGRAdmdlci5rZXJuZWwub3JnOyBKYW1pZSBJbGVz
Ow0KPiBBbmR5IEdyb3NzOyBTYXNjaGEgSGF1ZXI7IEdyZWdvcnkgQ2xlbWVudDsgbGludXgtc2hA
dmdlci5rZXJuZWwub3JnOw0KPiBUc2FoZWUgWmlkZW5iZXJnOyBsaW51eC1hcm0tbXNtQHZnZXIu
a2VybmVsLm9yZzsgTGludXMgV2FsbGVpajsgS3VtYXINCj4gR2FsYTsgSmVhbi1DaHJpc3RvcGhl
IFBsYWduaW9sLVZpbGxhcmQ7IERpbmggTmd1eWVuOyBCYXJyeSBTb25nOyBTaGlyYXoNCj4gSGFz
aGltOyBSYXkgSnVpOyBQYXRyaWNlIENob3RhcmQ7IGtlcm5lbEBzdGxpbnV4LmNvbTsgU8O2cmVu
IEJyaW5rbWFubjsNCj4gU2ltb24gSG9ybWFuOyBNaWNoYWwgU2ltZWs7IEhlaWtvIFN0dWVibmVy
Ow0KPiBsaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnOyBsaW51eC1zb2NAdmdlci5r
ZXJuZWwub3JnOyBEYXZpZA0KPiBCcm93bjsgU2NvdHQgQnJhbmRlbjsgVmlyZXNoIEt1bWFyOyBB
bGV4YW5kcmUgQmVsbG9uaTsgS3l1bmdtaW4gUGFyazsNCj4gS3J6eXN6dG9mIEtvemxvd3NraTsg
YmNtLWtlcm5lbC1mZWVkYmFjay1saXN0QGJyb2FkY29tLmNvbTsgRmxvcmlhbg0KPiBGYWluZWxs
aTsgQWxleGFuZHJlIENvdXJib3Q7IE1hdHRoaWFzIEJydWdnZXI7IEt1a2ppbiBLaW07IFJvYiBI
ZXJyaW5nOw0KPiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOyBzcGVhci1kZXZlbEBsaXN0
LnN0LmNvbTsgU2ViYXN0aWFuDQo+IEhlc3NlbGJhcnRoOyBTdWRlZXAgSG9sbGE7IEFuZHJldyBM
dW5uOyBSdXNzZWxsIEtpbmc7DQo+IGxpbnV4LXNhbXN1bmctc29jQHZnZXIua2VybmVsLm9yZzsg
bGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFkZWFkLm9yZzsNCj4gbGludXgtdGVncmFAdmdlci5r
ZXJuZWwub3JnOyBNYXhpbWUgQ29xdWVsaW47IFNyaW5pdmFzIEthbmRhZ2F0bGE7IFNoYXduDQo+
IEd1bzsgTGl2aXUgRHVkYXU7IEp1biBOaWU7IExvcmVuem8gUGllcmFsaXNpOyBOaWNvbGFzIEZl
cnJlOyBKYXNvbiBDb29wZXI7DQo+IFN0ZXBoZW4gV2FycmVuOyBLcnp5c3p0b2YgSGFsYXNhOyBX
ZWkgWHU7IE1hZ251cyBEYW1tOyBDaGVuLVl1IFRzYWk7IE1heGltZQ0KPiBSaXBhcmQNCj4gU3Vi
amVjdDogUmU6IFtQQVRDSF0gQVJNOiB1c2UgImRlcGVuZHMgb24iIGZvciBTb0MgY29uZmlncyBp
bnN0ZWFkIG9mICJpZiINCj4gYWZ0ZXIgcHJvbXB0DQo+IA0KPiBPbiBNb24sIE5vdiAxNiwgMjAx
NSBhdCAxMjowNjoxMFBNICswOTAwLCBNYXNhaGlybyBZYW1hZGEgd3JvdGU6DQo+IFsuLi5dDQo+
ID4gIGFyY2gvYXJtL21hY2gtdGVncmEvS2NvbmZpZyAgICAgIHwgIDMgKystDQo+IA0KPiBUaGVy
ZSB3aWxsIGJlIGEgc2xpZ2h0IGNvbmZsaWN0IGJldHdlZW4gdGhpcyBhbmQgYSBwYXRjaCBpbiB0
aGUgdGVncmEgdHJlZSwNCj4gYnV0IG5vdGhpbmcgdGhhdCB0aGUgQVJNIFNvQyBtYWludGFpbmVy
cyBjYW4ndCBoYW5kbGUsIHNvOg0KPiANCj4gQWNrZWQtYnk6IFRoaWVycnkgUmVkaW5nIDx0cmVk
aW5nQG52aWRpYS5jb20+DQo
^ permalink raw reply [flat|nested] 26+ messages in thread
* RE: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
@ 2015-11-25 2:09 ` yamada.masahiro
0 siblings, 0 replies; 26+ messages in thread
From: yamada.masahiro @ 2015-11-25 2:09 UTC (permalink / raw)
To: thierry.reding, arnd, arm
Cc: linux-arm-kernel, mmarek, olof, linux-kbuild, jamie, agross,
kernel, gregory.clement, linux-sh, tsahee, linux-arm-msm,
linus.walleij, galak, plagnioj, dinguyen, baohua,
shiraz.linux.kernel, rjui, patrice.chotard, kernel,
soren.brinkmann, horms, michal.simek, heiko, linux-rockchip,
linux-soc, davidb, sbranden, vireshk, alexandre.belloni,
kyungmin.park, k.kozlowski, bcm
Hi Arnd,
Could you apply this patch with Acked-by storm
so that other subarchtectures can base on it?
Also, the following series:
1/2: ARM: hisi: do not export smp_operations structures
2/2: ARM: use const and __initconst for smp_operations
> -----Original Message-----
> From: Thierry Reding [mailto:thierry.reding@gmail.com]
> Sent: Wednesday, November 25, 2015 12:59 AM
> To: Yamada, Masahiro
> Cc: linux-arm-kernel@lists.infradead.org; arm@kernel.org; Michal Marek;
> Arnd Bergmann; Olof Johansson; linux-kbuild@vger.kernel.org; Jamie Iles;
> Andy Gross; Sascha Hauer; Gregory Clement; linux-sh@vger.kernel.org;
> Tsahee Zidenberg; linux-arm-msm@vger.kernel.org; Linus Walleij; Kumar
> Gala; Jean-Christophe Plagniol-Villard; Dinh Nguyen; Barry Song; Shiraz
> Hashim; Ray Jui; Patrice Chotard; kernel@stlinux.com; Sören Brinkmann;
> Simon Horman; Michal Simek; Heiko Stuebner;
> linux-rockchip@lists.infradead.org; linux-soc@vger.kernel.org; David
> Brown; Scott Branden; Viresh Kumar; Alexandre Belloni; Kyungmin Park;
> Krzysztof Kozlowski; bcm-kernel-feedback-list@broadcom.com; Florian
> Fainelli; Alexandre Courbot; Matthias Brugger; Kukjin Kim; Rob Herring;
> linux-kernel@vger.kernel.org; spear-devel@list.st.com; Sebastian
> Hesselbarth; Sudeep Holla; Andrew Lunn; Russell King;
> linux-samsung-soc@vger.kernel.org; linux-mediatek@lists.infradead.org;
> linux-tegra@vger.kernel.org; Maxime Coquelin; Srinivas Kandagatla; Shawn
> Guo; Liviu Dudau; Jun Nie; Lorenzo Pieralisi; Nicolas Ferre; Jason Cooper;
> Stephen Warren; Krzysztof Halasa; Wei Xu; Magnus Damm; Chen-Yu Tsai; Maxime
> Ripard
> Subject: Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if"
> after prompt
>
> On Mon, Nov 16, 2015 at 12:06:10PM +0900, Masahiro Yamada wrote:
> [...]
> > arch/arm/mach-tegra/Kconfig | 3 ++-
>
> There will be a slight conflict between this and a patch in the tegra tree,
> but nothing that the ARM SoC maintainers can't handle, so:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
^ permalink raw reply [flat|nested] 26+ messages in thread
* RE: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
@ 2015-11-25 2:09 ` yamada.masahiro
0 siblings, 0 replies; 26+ messages in thread
From: yamada.masahiro @ 2015-11-25 2:09 UTC (permalink / raw)
To: thierry.reding, arnd, arm
Cc: linux-arm-kernel, mmarek, olof, linux-kbuild, jamie, agross,
kernel, gregory.clement, linux-sh, tsahee, linux-arm-msm,
linus.walleij, galak, plagnioj, dinguyen, baohua,
shiraz.linux.kernel, rjui, patrice.chotard, kernel,
soren.brinkmann, horms, michal.simek, heiko, linux-rockchip,
linux-soc, davidb, sbranden, vireshk, alexandre.belloni,
kyungmin.park, k.kozlowski, bcm-kernel-feedback-list, f.fainelli,
gnurou, matthias.bgg, kgene, robh, linux-kernel, spear-devel,
sebastian.hesselbarth, sudeep.holla, andrew, linux,
linux-samsung-soc, linux-mediatek, linux-tegra, maxime.coquelin,
srinivas.kandagatla, shawnguo, liviu.dudau, jun.nie,
lorenzo.pieralisi, nicolas.ferre, jason, swarren, khalasa,
xuwei5, magnus.damm, wens, maxime.ripard
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2182 bytes --]
Hi Arnd,
Could you apply this patch with Acked-by storm
so that other subarchtectures can base on it?
Also, the following series:
1/2: ARM: hisi: do not export smp_operations structures
2/2: ARM: use const and __initconst for smp_operations
> -----Original Message-----
> From: Thierry Reding [mailto:thierry.reding@gmail.com]
> Sent: Wednesday, November 25, 2015 12:59 AM
> To: Yamada, Masahiro
> Cc: linux-arm-kernel@lists.infradead.org; arm@kernel.org; Michal Marek;
> Arnd Bergmann; Olof Johansson; linux-kbuild@vger.kernel.org; Jamie Iles;
> Andy Gross; Sascha Hauer; Gregory Clement; linux-sh@vger.kernel.org;
> Tsahee Zidenberg; linux-arm-msm@vger.kernel.org; Linus Walleij; Kumar
> Gala; Jean-Christophe Plagniol-Villard; Dinh Nguyen; Barry Song; Shiraz
> Hashim; Ray Jui; Patrice Chotard; kernel@stlinux.com; Sören Brinkmann;
> Simon Horman; Michal Simek; Heiko Stuebner;
> linux-rockchip@lists.infradead.org; linux-soc@vger.kernel.org; David
> Brown; Scott Branden; Viresh Kumar; Alexandre Belloni; Kyungmin Park;
> Krzysztof Kozlowski; bcm-kernel-feedback-list@broadcom.com; Florian
> Fainelli; Alexandre Courbot; Matthias Brugger; Kukjin Kim; Rob Herring;
> linux-kernel@vger.kernel.org; spear-devel@list.st.com; Sebastian
> Hesselbarth; Sudeep Holla; Andrew Lunn; Russell King;
> linux-samsung-soc@vger.kernel.org; linux-mediatek@lists.infradead.org;
> linux-tegra@vger.kernel.org; Maxime Coquelin; Srinivas Kandagatla; Shawn
> Guo; Liviu Dudau; Jun Nie; Lorenzo Pieralisi; Nicolas Ferre; Jason Cooper;
> Stephen Warren; Krzysztof Halasa; Wei Xu; Magnus Damm; Chen-Yu Tsai; Maxime
> Ripard
> Subject: Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if"
> after prompt
>
> On Mon, Nov 16, 2015 at 12:06:10PM +0900, Masahiro Yamada wrote:
> [...]
> > arch/arm/mach-tegra/Kconfig | 3 ++-
>
> There will be a slight conflict between this and a patch in the tegra tree,
> but nothing that the ARM SoC maintainers can't handle, so:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 26+ messages in thread
* RE: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
@ 2015-11-25 2:09 ` yamada.masahiro
0 siblings, 0 replies; 26+ messages in thread
From: yamada.masahiro @ 2015-11-25 2:09 UTC (permalink / raw)
To: thierry.reding, arnd, arm
Cc: linux-arm-kernel, mmarek, olof, linux-kbuild, jamie, agross,
kernel, gregory.clement, linux-sh, tsahee, linux-arm-msm,
linus.walleij, galak, plagnioj, dinguyen, baohua,
shiraz.linux.kernel, rjui, patrice.chotard, kernel,
soren.brinkmann, horms, michal.simek, heiko, linux-rockchip,
linux-soc, davidb, sbranden, vireshk, alexandre.belloni,
kyungmin.park, k.kozlowski, bcm-kernel-feedback-list, f.fainelli,
gnurou, matthias.bgg, kgene, robh, linux-kernel, spear-devel,
sebastian.hesselbarth, sudeep.holla, andrew, linux,
linux-samsung-soc, linux-mediatek, linux-tegra, maxime.coquelin,
srinivas.kandagatla, shawnguo, liviu.dudau, jun.nie,
lorenzo.pieralisi, nicolas.ferre, jason, swarren, khalasa,
xuwei5, magnus.damm, wens, maxime.ripard
Hi Arnd,
Could you apply this patch with Acked-by storm
so that other subarchtectures can base on it?
Also, the following series:
1/2: ARM: hisi: do not export smp_operations structures
2/2: ARM: use const and __initconst for smp_operations
> -----Original Message-----
> From: Thierry Reding [mailto:thierry.reding@gmail.com]
> Sent: Wednesday, November 25, 2015 12:59 AM
> To: Yamada, Masahiro
> Cc: linux-arm-kernel@lists.infradead.org; arm@kernel.org; Michal Marek;
> Arnd Bergmann; Olof Johansson; linux-kbuild@vger.kernel.org; Jamie Iles;
> Andy Gross; Sascha Hauer; Gregory Clement; linux-sh@vger.kernel.org;
> Tsahee Zidenberg; linux-arm-msm@vger.kernel.org; Linus Walleij; Kumar
> Gala; Jean-Christophe Plagniol-Villard; Dinh Nguyen; Barry Song; Shiraz
> Hashim; Ray Jui; Patrice Chotard; kernel@stlinux.com; Sören Brinkmann;
> Simon Horman; Michal Simek; Heiko Stuebner;
> linux-rockchip@lists.infradead.org; linux-soc@vger.kernel.org; David
> Brown; Scott Branden; Viresh Kumar; Alexandre Belloni; Kyungmin Park;
> Krzysztof Kozlowski; bcm-kernel-feedback-list@broadcom.com; Florian
> Fainelli; Alexandre Courbot; Matthias Brugger; Kukjin Kim; Rob Herring;
> linux-kernel@vger.kernel.org; spear-devel@list.st.com; Sebastian
> Hesselbarth; Sudeep Holla; Andrew Lunn; Russell King;
> linux-samsung-soc@vger.kernel.org; linux-mediatek@lists.infradead.org;
> linux-tegra@vger.kernel.org; Maxime Coquelin; Srinivas Kandagatla; Shawn
> Guo; Liviu Dudau; Jun Nie; Lorenzo Pieralisi; Nicolas Ferre; Jason Cooper;
> Stephen Warren; Krzysztof Halasa; Wei Xu; Magnus Damm; Chen-Yu Tsai; Maxime
> Ripard
> Subject: Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if"
> after prompt
>
> On Mon, Nov 16, 2015 at 12:06:10PM +0900, Masahiro Yamada wrote:
> [...]
> > arch/arm/mach-tegra/Kconfig | 3 ++-
>
> There will be a slight conflict between this and a patch in the tegra tree,
> but nothing that the ARM SoC maintainers can't handle, so:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
` (11 preceding siblings ...)
2015-11-24 15:58 ` Thierry Reding
@ 2015-11-25 12:13 ` Krzysztof Hałasa
2015-11-30 10:43 ` Maxime Coquelin
2015-12-01 21:46 ` Arnd Bergmann
14 siblings, 0 replies; 26+ messages in thread
From: Krzysztof Hałasa @ 2015-11-25 12:13 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Andrew Lunn, Krzysztof Kozlowski, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Liviu Dudau,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matthias Brugger,
Thierry Reding, Alexandre Belloni, Jamie Iles, Heiko Stuebner,
Alexandre Courbot, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
Florian Fainelli, Russell King, Viresh Kumar, Stephen Warren,
Magnus Damm, Michal Simek, Wei Xu, Lorenzo Pieralisi,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai
Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org> writes:
> --- a/arch/arm/mach-cns3xxx/Kconfig
> +++ b/arch/arm/mach-cns3xxx/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_CNS3XXX
> - bool "Cavium Networks CNS3XXX family" if ARCH_MULTI_V6
> + bool "Cavium Networks CNS3XXX family"
> + depends on ARCH_MULTI_V6
> select ARM_GIC
> select PCI_DOMAINS if PCI
> help
Acked-by: Krzysztof Halasa <khc-NlWvg49iv0c@public.gmane.org>
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
` (12 preceding siblings ...)
2015-11-25 12:13 ` Krzysztof Hałasa
@ 2015-11-30 10:43 ` Maxime Coquelin
2015-12-01 21:46 ` Arnd Bergmann
14 siblings, 0 replies; 26+ messages in thread
From: Maxime Coquelin @ 2015-11-30 10:43 UTC (permalink / raw)
To: Masahiro Yamada,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
arm-DgEjT+Ai2ygdnm+yROfE0A
Cc: Andrew Lunn, Krzysztof Kozlowski, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Liviu Dudau,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matthias Brugger,
Thierry Reding, Alexandre Belloni, Jamie Iles, Heiko Stuebner,
Alexandre Courbot, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
Florian Fainelli, Russell King, Viresh Kumar, Stephen Warren,
Magnus Damm, Michal Simek, Wei Xu, Lorenzo Pieralisi,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai
On 11/16/2015 04:06 AM, Masahiro Yamada wrote:
> diff --git a/arch/arm/mach-sti/Kconfig b/arch/arm/mach-sti/Kconfig
> index 125865d..736abe6 100644
> --- a/arch/arm/mach-sti/Kconfig
> +++ b/arch/arm/mach-sti/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig ARCH_STI
> - bool "STMicroelectronics Consumer Electronics SOCs" if ARCH_MULTI_V7
> + bool "STMicroelectronics Consumer Electronics SOCs"
> + depends on ARCH_MULTI_V7
> select ARM_GIC
> select ST_IRQCHIP
> select ARM_GLOBAL_TIMER
For STi part:
Acked-by: Maxime Coquelin <maxime.coquelin-qxv4g6HH51o@public.gmane.org>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
` (13 preceding siblings ...)
2015-11-30 10:43 ` Maxime Coquelin
@ 2015-12-01 21:46 ` Arnd Bergmann
14 siblings, 0 replies; 26+ messages in thread
From: Arnd Bergmann @ 2015-12-01 21:46 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Andrew Lunn, Krzysztof Kozlowski, kernel-F5mvAk5X5gdBDgjK7y7TUQ,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Liviu Dudau,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Matthias Brugger,
Thierry Reding, Alexandre Belloni, Jamie Iles, Heiko Stuebner,
Alexandre Courbot, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
Florian Fainelli, Russell King, Viresh Kumar, Stephen Warren,
Magnus Damm, Michal Simek, Wei Xu, Lorenzo Pieralisi,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chen-Yu Tsai
On Monday 16 November 2015 12:06:10 Masahiro Yamada wrote:
> For enabling/disabling sub-architectures, the latter is always correct.
>
> As a good side effect, this commit fixes some entries over 80 columns
> (mach-imx, mach-integrator, mach-mbevu).
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
> ---
>
> I hope this patch is applied to ARM-SOC, but am CCing Kbuild ML
> because the correct understanding of Kconfig is required for this patch.
>
I have applied the patch to next/cleanup now, and added a comment about the
fact that there is not really a bug here.
Thanks!
Arnd
^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2015-12-01 21:46 UTC | newest]
Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-16 3:06 [PATCH] ARM: use "depends on" for SoC configs instead of "if" after prompt Masahiro Yamada
[not found] ` <1447643170-23773-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2015-11-16 9:31 ` Maxime Ripard
2015-11-16 10:05 ` Arnd Bergmann
2015-11-16 10:32 ` yamada.masahiro
2015-11-16 10:32 ` yamada.masahiro
2015-11-16 10:32 ` yamada.masahiro
2015-11-16 10:32 ` yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A
2015-11-16 11:06 ` Russell King - ARM Linux
2015-11-16 11:06 ` Russell King - ARM Linux
2015-11-16 10:38 ` Nicolas Ferre
2015-11-16 11:12 ` Heiko Stübner
2015-11-16 12:26 ` Patrice Chotard
2015-11-16 12:59 ` Liviu Dudau
2015-11-16 23:49 ` Krzysztof Kozlowski
2015-11-17 10:42 ` Matthias Brugger
2015-11-17 18:04 ` Simon Horman
2015-11-23 18:10 ` Gregory CLEMENT
2015-11-24 9:30 ` Shawn Guo
2015-11-24 15:58 ` Thierry Reding
2015-11-25 2:09 ` yamada.masahiro
2015-11-25 2:09 ` yamada.masahiro
2015-11-25 2:09 ` yamada.masahiro
2015-11-25 2:09 ` yamada.masahiro
2015-11-25 12:13 ` Krzysztof Hałasa
2015-11-30 10:43 ` Maxime Coquelin
2015-12-01 21:46 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.