All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/gauche: fix build error on BR2_STATIC_LIBS
@ 2015-11-18  9:30 Hiroshi Kawashima
  2015-11-18 20:58 ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Hiroshi Kawashima @ 2015-11-18  9:30 UTC (permalink / raw)
  To: buildroot

Building gauche depends on dynamic link, so add dependency on
!BR2_STATIC_LIBS.

Fix:
http://autobuild.buildroot.org/results/da5/da5b9605552d4914c5e6f0d890367b92536419c1

Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
---
 package/gauche/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/gauche/Config.in b/package/gauche/Config.in
index 0720672..24377c4 100644
--- a/package/gauche/Config.in
+++ b/package/gauche/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_GAUCHE
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_ARCH_HAS_ATOMICS
+	depends on !BR2_STATIC_LIBS
 	help
 	  Gauche is an R7RS Scheme implementation developed to be a
 	  handy script interpreter, which allows programmers and
@@ -13,7 +14,7 @@ config BR2_PACKAGE_GAUCHE
 
 	  http://practical-scheme.net/gauche/
 
-comment "gauche needs a toolchain w/ NPTL"
+comment "gauche needs a toolchain w/ NPTL, dynamic library"
 	depends on BR2_USE_MMU
 	depends on BR2_ARCH_HAS_ATOMICS
-	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
============================================================
    Hiroshi Kawashima

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/gauche: fix build error on BR2_STATIC_LIBS
  2015-11-18  9:30 [Buildroot] [PATCH] package/gauche: fix build error on BR2_STATIC_LIBS Hiroshi Kawashima
@ 2015-11-18 20:58 ` Thomas Petazzoni
  2015-11-19 10:03   ` Hiroshi Kawashima
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2015-11-18 20:58 UTC (permalink / raw)
  To: buildroot

Dear Hiroshi Kawashima,

On Wed, 18 Nov 2015 18:30:23 +0900, Hiroshi Kawashima wrote:
> Building gauche depends on dynamic link, so add dependency on
> !BR2_STATIC_LIBS.
> 
> Fix:
> http://autobuild.buildroot.org/results/da5/da5b9605552d4914c5e6f0d890367b92536419c1
> 
> Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
> ---
>  package/gauche/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Applied to master, thanks. However, your patch didn't apply properly, I
had to fix up some conflicts. If possible, please try to send patches
that apply on top of the latest master.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/gauche: fix build error on BR2_STATIC_LIBS
  2015-11-18 20:58 ` Thomas Petazzoni
@ 2015-11-19 10:03   ` Hiroshi Kawashima
  0 siblings, 0 replies; 3+ messages in thread
From: Hiroshi Kawashima @ 2015-11-19 10:03 UTC (permalink / raw)
  To: buildroot

Dear Thomas.

Thank you for applying.
Sorry for conflicts patch.

I will send v2 patch (diff from master) as your request next.

Regards,
Kawashima

Thomas Petazzoni writes:
> Dear Hiroshi Kawashima,
> 
> On Wed, 18 Nov 2015 18:30:23 +0900, Hiroshi Kawashima wrote:
> > Building gauche depends on dynamic link, so add dependency on
> > !BR2_STATIC_LIBS.
> > 
> > Fix:
> > http://autobuild.buildroot.org/results/da5/da5b9605552d4914c5e6f0d890367b92
> 536419c1
> > 
> > Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
> > ---
> >  package/gauche/Config.in | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Applied to master, thanks. However, your patch didn't apply properly, I
> had to fix up some conflicts. If possible, please try to send patches
> that apply on top of the latest master.
> 
> Thanks!
> 
> Thomas
============================================================
    Hiroshi Kawashima

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-11-19 10:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-18  9:30 [Buildroot] [PATCH] package/gauche: fix build error on BR2_STATIC_LIBS Hiroshi Kawashima
2015-11-18 20:58 ` Thomas Petazzoni
2015-11-19 10:03   ` Hiroshi Kawashima

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.